Added two new options 'offset' and 'size'. This makes it possible to use
only part of the file as a device. This can be used e.g. to limit the
access only to single partition in a disk image or use a disk inside a
tar archive (like OVA).
When 'size' is specified we do our best to honour it.
Signe
v7 -> v8:
- handling offset in raw_co_pwrite_zeroes and raw_co_pdiscard (+tests)
- offset and size are not allowed for SCSI generic devices
- raw_aio_ioctl: not allowed when offset or size is set
- raw_probe_blocksizes: return -ENOTSUP if offset is not multiple of block size
- raw_probe_geometry: r
Signed-off-by: Tomáš Golembiovský
---
tests/qemu-iotests/171 | 212 ++
tests/qemu-iotests/171.out | 313 +
tests/qemu-iotests/group | 1 +
3 files changed, 526 insertions(+)
create mode 100755 tests/qemu-iotests/171
Am 31.10.2016 um 11:27 hat Tomáš Golembiovský geschrieben:
> v7 -> v8:
> - handling offset in raw_co_pwrite_zeroes and raw_co_pdiscard (+tests)
> - offset and size are not allowed for SCSI generic devices
> - raw_aio_ioctl: not allowed when offset or size is set
> - raw_probe_blocksizes: return -EN
Am 31.10.2016 um 11:27 hat Tomáš Golembiovský geschrieben:
> Added two new options 'offset' and 'size'. This makes it possible to use
> only part of the file as a device. This can be used e.g. to limit the
> access only to single partition in a disk image or use a disk inside a
> tar archive (like
Am 28.10.2016 um 19:09 hat Ashijeet Acharya geschrieben:
> Make NFS block driver use various fine grained runtime_opts.
> Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
> new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
> the URI.
> Add a new option "serv
Am 28.10.2016 um 23:30 hat John Snow geschrieben:
> On 10/28/2016 05:23 PM, John Snow wrote:
> >blk_eject is only used by scsi-disk and atapi, and in both cases we
> >only attempt to invoke blk_eject if we have a bona-fide change in
> >tray state.
> >
> >The "issue" here is that the tray state does
Am 29.10.2016 um 00:32 hat John Snow geschrieben:
> For the purposes of byte_count_limit verification, add a new flag that
> identifies read_cd as sometimes returning data, then check the BCL in
> its command handler after we know that it will indeed return data.
>
> Reported-by: Hervé Poussineau
Am 20.09.2016 um 16:39 hat Daniel P. Berrange geschrieben:
> On Tue, Sep 20, 2016 at 09:38:33AM -0500, Eric Blake wrote:
> > On 09/20/2016 09:15 AM, Daniel P. Berrange wrote:
> > >>> I guess we could keep things simple by not inventing a new format,
> > >>> but instead of using 'check.time', use 'c
On Mon, Oct 31, 2016 at 03:28:23PM +0100, Kevin Wolf wrote:
> Am 20.09.2016 um 16:39 hat Daniel P. Berrange geschrieben:
> > On Tue, Sep 20, 2016 at 09:38:33AM -0500, Eric Blake wrote:
> > > On 09/20/2016 09:15 AM, Daniel P. Berrange wrote:
> > > >>> I guess we could keep things simple by not inven
Am 27.10.2016 um 22:23 hat Eric Blake geschrieben:
> Missed in commit 82ac554.
>
> Signed-off-by: Eric Blake
Thanks, applied to the block branch.
Kevin
Previously posted series patches:
v5: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07580.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07449.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg06903.html
v2: https://lists.gnu.org/archive/html/qemu-devel
On 10/30/2016 01:49 PM, Hervé Poussineau wrote:
Le 29/10/2016 à 00:32, John Snow a écrit :
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return d
Make NFS block driver use various fine grained runtime_opts.
Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
the URI.
Add a new option "server" which then accepts a new struct NFSServer.
Signed-off-by: Ashi
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
support blockdev-add for NFS network protocol driver. Also make a new
struct NFSServer to support tcp connection.
Signed-off-by: Ashijeet Acharya
---
qapi/block-core.json | 74 +--
Checking the status of an image when it is being used by guest is
usually useful, and there is no risk of corrupting data, so don't let
the upcoming image locking feature limit this use case.
Signed-off-by: Fam Zheng
---
qemu-img.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/055 | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055
index 1d3fd04..20a7596 100755
--- a/tests/qemu-iotests/055
+++ b/tests/qemu-iotests/055
@@ -45
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/030 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030
index 107049b..c0ab4df 100755
--- a/tests/qemu-iotests/030
+++ b/tests/qemu-iotests/030
@@ -95,7 +95,7 @@ class TestSingleDri
Signed-off-by: Fam Zheng
---
include/block/block.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index 107c603..d09a932 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -98,6 +98,8 @@ typedef struct HDGeometry {
This is v9 of the image locking series. I redid the whole series, adopting the
"two locks" approach from Kevin and Max.
Depends on "[Qemu-devel] [PATCH] raw-posix: Rename 'raw_s' to 'rs'" in Max's
block branch.
Fam Zheng (14):
osdep: Add qemu_lock_fd and qemu_unlock_fd
block: Define BDRV_O_SH
In the case where we test the expected error when a blockdev-snapshot
target already has a backing image, backing chain is opened multiple
times. This will be a problem when we use image locking, so use a
different backing file that is not already open.
Signed-off-by: Fam Zheng
---
tests/qemu-io
The test scenario doesn't require the same image, instead it focuses on
the duplicated node-name, so use null-co to avoid locking conflict.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/087 | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/087 b/tests
In this case we may open the source's backing image chain multiple
times. Setting share flag means the new open won't try to acquire or
check any lock, once we implement image locking.
Signed-off-by: Fam Zheng
---
An alternative is reusing (and bdrv_ref) the existing source's backing
bs instead
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/091 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
index 32bbd56..10ac4a8 100755
--- a/tests/qemu-iotests/091
+++ b/tests/qemu-iotests/091
@@ -95,7 +95,9 @@ echo "vm2: qemu process running succe
Signed-off-by: Fam Zheng
---
tests/Makefile.include | 2 +
tests/test-image-lock.c | 179
2 files changed, 181 insertions(+)
create mode 100644 tests/test-image-lock.c
diff --git a/tests/Makefile.include b/tests/Makefile.include
index cd058ef.
On 10/31/2016 10:06 AM, Kevin Wolf wrote:
Am 29.10.2016 um 00:32 hat John Snow geschrieben:
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return
Hi Peter,
while testing the blockdev-add for NFS series, I noticed that apart from
a few obvious false positives, qemu-iotests case 077 fails in a
concerning way:
--- /home/kwolf/source/qemu/tests/qemu-iotests/077.out 2016-09-14
11:23:41.143593271 +0200
+++ 077.out.bad 2016-10-31 16:27:17.64470
They are wrappers of POSIX fcntl "file private locking".
Signed-off-by: Fam Zheng
---
include/qemu/osdep.h | 2 ++
util/osdep.c | 29 +
2 files changed, 31 insertions(+)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 0e3c330..f15e122 100644
-
Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben:
> Make NFS block driver use various fine grained runtime_opts.
> Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
> new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
> the URI.
> Add a new option "serv
On 10/31/2016 10:13 AM, Kevin Wolf wrote:
Am 28.10.2016 um 23:30 hat John Snow geschrieben:
On 10/28/2016 05:23 PM, John Snow wrote:
blk_eject is only used by scsi-disk and atapi, and in both cases we
only attempt to invoke blk_eject if we have a bona-fide change in
tray state.
The "issue" h
qemu-io is a low level tool to read or modify guest visible data, which
implies the user knows very well what is being done. Allowing reading
from a locked image is harmless in most cases, so do it.
Signed-off-by: Fam Zheng
---
qemu-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qemu
In this way the source side QEMU is writing to the image. We need to
open it, so share-rw is required.
Signed-off-by: Fam Zheng
---
blockdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 9992c5d..230c7c1 100644
--- a/blockdev.c
+++ b/bloc
Signed-off-by: Fam Zheng
---
tests/drive_del-test.c| 2 +-
tests/nvme-test.c | 2 +-
tests/usb-hcd-uhci-test.c | 2 +-
tests/usb-hcd-xhci-test.c | 2 +-
tests/virtio-blk-test.c | 2 +-
tests/virtio-scsi-test.c | 4 ++--
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a
This implements open flag sensible image locking for local file
and host device protocol.
virtlockd in libvirt locks the first byte, so we start looking at the
file bytes from 1.
Quoting what was proposed by Kevin Wolf , there are
four locking modes by combining two bits (BDRV_O_RDWR and
BDRV_O_S
Am 31.10.2016 um 16:05 hat Ashijeet Acharya geschrieben:
> Previously posted series patches:
> v5: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07580.html
> v4: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07449.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2016-1
From: Ashijeet Acharya
Make inet_connect_saddr() in util/qemu-sockets.c public in order to be
able to use it with InetSocketAddress sockets outside of
util/qemu-sockets.c independently.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
include/qemu/sockets
From: Ashijeet Acharya
We have 5 options plus ("server") option which is added in the next
patch that conflict with specifying a SSH filename. We need to iterate
over all the options to check whether its key has an "server." prefix.
This iteration will help us adding the new option "server" easi
The following changes since commit 0bb1137930f51a89fb1bfeb0c46aa68af0395167:
Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20161031' into
staging (2016-10-31 14:48:47 +)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
From: Ashijeet Acharya
Drop the use of legacy options in favour of the InetSocketAddress
options.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Max Reitz
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
block/ssh.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --g
From: Ashijeet Acharya
Add InetSocketAddress compatibility to SSH driver.
Add a new option "server" to the SSH block driver which then accepts
a InetSocketAddress.
"host" and "port" are supported as legacy options and are mapped to
their InetSocketAddress representation.
Signed-off-by: Ashijee
From: Alberto Garcia
When a block job is created on a certain BlockDriverState, operations
are blocked there while the job exists. However, some block jobs may
involve additional BDSs, which must be blocked separately when the job
is created and unblocked manually afterwards.
This patch adds blo
From: Alberto Garcia
When a BlockDriverState is about to be reopened it can trigger certain
operations that need to write to disk. During this process a different
block job can be woken up. If that block job completes and also needs
to call bdrv_reopen() it can happen that it needs to do it on th
From: Ashijeet Acharya
Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
support blockdev-add for SSH network protocol driver. Use only 'struct
InetSocketAddress' since SSH only supports connection over TCP.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Kevin Wolf
[ kwolf: Re
From: Alberto Garcia
bdrv_drain_all() doesn't allow the caller to do anything after all
pending requests have been completed but before block jobs are
resumed.
This patch splits bdrv_drain_all() into _begin() and _end() for that
purpose. It also adds aio_{disable,enable}_external() calls to disa
From: Alberto Garcia
When block-commit is launched without the top parameter, it uses
internally a mirror block job. In that case all intermediate nodes
between the active and base nodes must be blocked as well.
Signed-off-by: Alberto Garcia
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
-
From: Alberto Garcia
There's many tests that need Quorum support in order to run. At the
moment each test implements its own check to see if Quorum is
enabled. This patch centralizes all those checks in a new function
called iotests.supports_quorum().
Signed-off-by: Alberto Garcia
Reviewed-by:
From: Alberto Garcia
Use block_job_add_bdrv() instead of blocking all operations in
backup_start() and unblocking them in backup_run().
Signed-off-by: Alberto Garcia
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
block/backup.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
From: Alberto Garcia
Quorum children are special in the sense that they're not directly
attached to a block backend but they're not used as backing images
either. However the intermediate block streaming code supports
streaming to them. This is a test case for that scenario.
Signed-off-by: Alber
From: Alberto Garcia
Use block_job_add_bdrv() instead of blocking all operations in
mirror_start_job() and unblocking them in mirror_exit().
Signed-off-by: Alberto Garcia
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
block/mirror.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
From: Alberto Garcia
After a successful block-commit operation all nodes between top and
base are removed from the backing chain, and top's overlay needs to
be updated to point to base. Because of that we should prevent other
block jobs from messing with them.
This patch blocks all operations in
From: Alberto Garcia
qmp_block_commit() checks for op blockers in the active and
destination (base) images. However all nodes between top_bs and base
are also involved, and they are removed from the chain afterwards.
In addition to that, if top_bs is not the active layer then top_bs's
overlay al
From: Alberto Garcia
This makes sure that the image we are streaming into is open in
read-write mode during the operation.
Operation blockers are also set in all intermediate nodes, since they
will be removed from the chain afterwards.
Finally, this also unblocks the stream operation in backing
From: Alberto Garcia
This patch makes the 'device' parameter of the 'block-stream' command
accept a node name that is not a root node. The presence of this
feature can't be directly tested with introspection; soon we'll
introduce a 'base-node' parameter whose presence can be checked for
this purp
From: Alberto Garcia
This adds test_stream_intermediate(), similar to test_stream() but
streams to the intermediate image instead.
Signed-off-by: Alberto Garcia
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/030 | 21 -
tests/qemu-iotests/030.out | 4 ++--
2 files c
From: Alberto Garcia
As with test_stream_parallel(), we allow mixing block-stream and
block-commit operations in the same backing chain as long as there's
no overlap among the involved nodes.
Signed-off-by: Alberto Garcia
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/030 | 30 +
From: Alberto Garcia
These test cases check that it's not possible to perform two
block-stream or block-commit operations if there are nodes involved in
both.
Signed-off-by: Alberto Garcia
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/030 | 89 +
From: Alberto Garcia
The way to specify the node from which to copy data in the
block-stream operation is by using the 'base' parameter. This
parameter however takes a file name, not a node name.
Since we want to be able to perform this operation using only node
names, this patch adds a new 'bas
From: Alberto Garcia
Signed-off-by: Alberto Garcia
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
docs/live-block-ops.txt | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/docs/live-block-ops.txt b/docs/live-block-ops.txt
index a
From: Alberto Garcia
This test case checks that it's possible to launch several stream
operations in parallel in the same snapshot chain, each one involving
a different set of nodes.
Signed-off-by: Alberto Garcia
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/030
From: Alberto Garcia
The block-stream command has traditionally used the 'base' parameter
to indicate the image to copy the data from. This test checks that the
'base-node' parameter can also be used for the same purpose.
Signed-off-by: Alberto Garcia
Signed-off-by: Kevin Wolf
---
tests/qemu-
From: Tomáš Golembiovský
Added two new options 'offset' and 'size'. This makes it possible to use
only part of the file as a device. This can be used e.g. to limit the
access only to single partition in a disk image or use a disk inside a
tar archive (like OVA).
When 'size' is specified we do ou
From: Eric Blake
Missed in commit 82ac554.
Signed-off-by: Eric Blake
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index df3b987..7299da3 100644
--- a/qapi/block-core.json
+++
From: Ashijeet Acharya
Make NFS block driver use various fine grained runtime_opts.
Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
the URI.
Add a new option "server" which then accepts a new struct NFSSer
From: Tomáš Golembiovský
Signed-off-by: Tomáš Golembiovský
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/171 | 212 ++
tests/qemu-iotests/171.out | 313 +
tests/qemu-iotests/group | 1 +
3 files changed, 526 ins
From: Ashijeet Acharya
Introduce new object 'BlockdevOptionsNFS' in qapi/block-core.json to
support blockdev-add for NFS network protocol driver. Also make a new
struct NFSServer to support tcp connection.
Signed-off-by: Ashijeet Acharya
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 74
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it.
Signed-off-by: Ashijeet Acharya
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd.c b/block/nbd.c
index 8ef1438..ff9d01a 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -545,6
This patch drops the unused parameter "BDRVSSHState" being passed into
the ssh_config() function and fixes the bug.
Signed-off-by: Ashijeet Acharya
---
block/ssh.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index ca071c5..15ed281 100644
---
On 10/31/2016 12:51 PM, Ashijeet Acharya wrote:
> This patch frees the leaked visitor in nbd_refresh_filename() and uses
> visit_free() to fix it.
>
> Signed-off-by: Ashijeet Acharya
> ---
> block/nbd.c | 1 +
> 1 file changed, 1 insertion(+)
Would be nice to mention that it was commit 491d6c7
On 31 October 2016 at 17:25, Kevin Wolf wrote:
> The following changes since commit 0bb1137930f51a89fb1bfeb0c46aa68af0395167:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20161031' into
> staging (2016-10-31 14:48:47 +)
>
> are available in the gi
The "logfile" option to BlockdevOptionsGluster will not be in
QEMU until 2.8. Update comment to indicate this.
Reported-by: Eric Blake
Signed-off-by: Jeff Cody
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.js
From: Xiubo Li
Make it a bit clearer and more readable.
Signed-off-by: Xiubo Li
Reviewed-by: Stefan Hajnoczi
Reviewed-by: John Snow
Reviewed-by: Jeff Cody
Message-id: 1476519973-6436-1-git-send-email-lixi...@cmss.chinamobile.com
CC: John Snow
Signed-off-by: Jeff Cody
---
block/rbd.c | 29
Add checks to see if the system compiling QEMU has support for
SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek
data is unsupported in gluster.
Note: this is not a check on whether the gluster server itself supports
SEEK_DATA (that is already done during runtime), but rather if
From: Prasanna Kumar Kalever
Currently, for every drive accessed via gfapi we create a new glfs
instance (call glfs_new() followed by glfs_init()) which could consume
memory in few 100 MB's, from the table below it looks like for each
instance ~300 MB VSZ was consumed
Before:
---
Disks VSZ
The following changes since commit 6bc56d317f7b5004ea2d89d264bddc8b4d081700:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-mttcg' into
staging (2016-10-31 15:29:12 +)
are available in the git repository at:
g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-req
From: Prasanna Kumar Kalever
After introduction of qapi schema in gluster block driver code, the port
type is now string as per InetSocketAddress
{ 'struct': 'InetSocketAddress',
'data': {
'host': 'str',
'port': 'str',
'*to': 'uint16',
'*ipv4': 'bool',
'*ipv6': 'bool' } }
From: Fam Zheng
We already specified BDRV_O_UNMAP when opening images in 'qemu-img
commit', but didn't turn on the "unmap" in the active commit job. This
patch fixes that so that zeroed clusters in top image can be discarded
which is desired in the virt-sparsify use case, where a temporary
overla
From: John Snow
Bubble up the internal interface to commit and backup jobs, then switch
replication tasks over to using this methodology.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
Message-id: 1477584421-1399-4-git-send-email-js...@redhat.com
Signed-off-by: Jeff C
From: John Snow
If jobs are not created directly by the user, do not allow them to be
seen by the user/management utility. At the moment, 'internal' jobs are
those that do not have an ID. As of this patch it is impossible to
create such jobs.
Signed-off-by: John Snow
Message-id: 1477584421-1399
From: Prasanna Kumar Kalever
using atoi() for converting string to int may be error prone in case if
string supplied in the argument is not a fold of numerical number,
This is not a bug because in the existing code,
static QemuOptsList runtime_tcp_opts = {
.name = "gluster_tcp",
.head =
From: John Snow
Add the ability to create jobs without an ID.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
Message-id: 1477584421-1399-3-git-send-email-js...@redhat.com
Signed-off-by: Jeff Cody
---
block/backup.c| 2 +-
block/commit.c| 2
From: John Snow
BlockJobs will begin hiding their state in preparation for some
refactorings anyway, so let's internalize the user_pause mechanism
instead of leaving it to callers to correctly manage.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
Message-id: 14775844
From: John Snow
(Trivial)
Fix wrong function names in documentation.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed-by: Jeff Cody
Message-id: 1477584421-1399-8-git-send-email-js...@redhat.com
Signed-off-by: Jeff Cody
---
include/block/blockjob_int.h | 4 ++--
1 file changed, 2 i
From: John Snow
There's no reason to leave this to blockdev; we can do it in blockjobs
directly and get rid of an extra callback for most users.
All non-internal events, even those created outside of QMP, will
consistently emit events.
Signed-off-by: John Snow
Reviewed-by: Kevin Wolf
Reviewed
From: John Snow
To make it a little more obvious which functions are intended to be
public interface and which are intended to be for use only by jobs
themselves, split the interface into "public" and "private" files.
Convert blockjobs (e.g. block/backup) to using the private interface.
Leave bl
Some older GCC versions (e.g. 4.4.7) report a warning on an
uninitialized variable for 'request', even though all possible code
paths that reference 'request' will be initialized. To appease
these versions, initialize the variable to 0.
Reported-by: Mark Cave-Ayland
Signed-off-by: Jeff Cody
--
On 10/31/2016 10:38 AM, Fam Zheng wrote:
> This implements open flag sensible image locking for local file
> and host device protocol.
>
> virtlockd in libvirt locks the first byte, so we start looking at the
> file bytes from 1.
What happens if we try to use a raw file with less than 3 bytes? Th
On Mon, Oct 31, 2016 at 05:01:44PM -0500, Eric Blake wrote:
> On 10/31/2016 10:38 AM, Fam Zheng wrote:
> > This implements open flag sensible image locking for local file
> > and host device protocol.
> >
> > virtlockd in libvirt locks the first byte, so we start looking at the
> > file bytes fro
On 2016/11/1 5:50, Jeff Cody wrote:
Some older GCC versions (e.g. 4.4.7) report a warning on an
uninitialized variable for 'request', even though all possible code
paths that reference 'request' will be initialized. To appease
these versions, initialize the variable to 0.
Thanks for reportin
On Mon, 10/31 17:01, Eric Blake wrote:
> On 10/31/2016 10:38 AM, Fam Zheng wrote:
> > This implements open flag sensible image locking for local file
> > and host device protocol.
> >
> > virtlockd in libvirt locks the first byte, so we start looking at the
> > file bytes from 1.
>
> What happens
v2:
- Actually applied the changes this time ...
- And added a test to the AHCI suite...
- ...Which revealed a few small issues in the suite.
The AHCI test should be sufficient in terms of general proof
for ATAPI regardless of the HBA used.
_
These can simply be the size of the number of sectors we're reading,
plus one for a buffer. We don't need them to be any larger.
Signed-off-by: John Snow
---
tests/ahci-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 70bcaf
For the purposes of byte_count_limit verification, add a new flag that
identifies read_cd as sometimes returning data, then check the BCL in
its command handler after we know that it will indeed return data.
Reported-by: Hervé Poussineau
Signed-off-by: John Snow
---
hw/ide/atapi.c | 51
Commit 9ef2e93f introduced the concept of tagging ATAPI commands as
NONDATA, but this introduced a regression for certain commands better
described as CONDDATA. read_cd is such a command that both requires
a non-zero BCL if a transfer size is set, but is perfectly content to
accept a zero BCL if th
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH v2 0/3] atapi: classify read_cd as conditionally
returning data
Message-id: 1477970211-25754-1-git-send-email-js...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/
94 matches
Mail list logo