On 11/02/2016 03:49 PM, Hervé Poussineau wrote:
Le 01/11/2016 à 04:16, John Snow a écrit :
v2:
- Actually applied the changes this time ...
- And added a test to the AHCI suite...
- ...Which revealed a few small issues in the suite.
The AHCI test should be sufficient in terms of general
Le 01/11/2016 à 04:16, John Snow a écrit :
v2:
- Actually applied the changes this time ...
- And added a test to the AHCI suite...
- ...Which revealed a few small issues in the suite.
The AHCI test should be sufficient in terms of general proof
for ATAPI regardless of the HBA used.
All
On Wed, Nov 02, 2016 at 06:55:38PM +0100, Max Reitz wrote:
> A follow-up patch will remove the curl block driver's TFTP support, so
> remove the protocol from the QAPI schema.
>
> Signed-off-by: Max Reitz
> ---
> docs/qmp-commands.txt | 2 +-
> qapi/block-core.json | 7
On Wed, Nov 02, 2016 at 06:55:37PM +0100, Max Reitz wrote:
> A follow-up patch will remove the curl block driver's TFTP support;
> therefore, we should no longer mention it anywhere in our documentation.
>
> Signed-off-by: Max Reitz
> ---
> qemu-options.hx | 6 +++---
> 1
On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote:
> See patch 3 for the reason why we have actually never supported TFTP at
> all (except for very small files (i.e. below 256 kB or so)).
>
> I would consider this series a bug fix because, well, it doesn't really
> change any
On 2 November 2016 at 17:03, Stefan Hajnoczi wrote:
> On Tue, Nov 01, 2016 at 08:50:57AM -0400, Jeff Cody wrote:
>> The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1:
>>
>> Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into
A follow-up patch will remove the curl block driver's TFTP support, so
remove the protocol from the QAPI schema.
Signed-off-by: Max Reitz
---
docs/qmp-commands.txt | 2 +-
qapi/block-core.json | 7 +++
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git
Because TFTP does not support byte ranges, it was never usable with our
curl block driver. Since apparently nobody has ever complained loudly
enough for someone to take care of the issue until now, it seems
reasonable to assume that nobody has ever actually used it.
Therefore, it should be safe
A follow-up patch will remove the curl block driver's TFTP support;
therefore, we should no longer mention it anywhere in our documentation.
Signed-off-by: Max Reitz
---
qemu-options.hx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx
Add a regression test for the case found by Vladimir.
Reported-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: John Snow
---
tests/qemu-iotests/124 | 53 ++
tests/qemu-iotests/124.out | 4 ++--
2 files
See patch 3 for the reason why we have actually never supported TFTP at
all (except for very small files (i.e. below 256 kB or so)).
I would consider this series a bug fix because, well, it doesn't really
change any functionality, and the bug is "We don't support TFTP but we
pretend we do".
Cleaning up after we have deferred to the main thread but before the
transaction has converged can be dangerous and result in deadlocks
if the job cleanup invokes any BH polling loops.
A job may attempt to begin cleaning up, but may induce another job to
enter its cleanup routine. The second job,
There are a few problems with transactional job completion right now.
First, if jobs complete so quickly they complete before remaining jobs
get a chance to join the transaction, the completion mode can leave well
known state and the QLIST can get corrupted and the transactional jobs
can complete
Refactor backup_start as backup_job_create, which only creates the job,
but does not automatically start it. The old interface, 'backup_start',
is not kept in favor of limiting the number of nearly-identical interfaces
that would have to be edited to keep up with QAPI changes in the future.
Instead of automatically starting jobs at creation time via backup_start
et al, we'd like to return a job object pointer that can be started
manually at later point in time.
For now, add the block_job_start mechanism and start the jobs
automatically as we have been doing, with conversions
From: Vladimir Sementsov-Ogievskiy
Though it is not intended to be reached through normal circumstances,
if we do not gracefully deconstruct the transaction QLIST, we may wind
up with stale pointers in the list.
The rest of this series attempts to address the
On Tue, Nov 01, 2016 at 08:50:57AM -0400, Jeff Cody wrote:
> The following changes since commit bf99fd3983d7185178a0f65ce29bb94b1aecaed1:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-sparc-20161031-2' into
> staging (2016-11-01 11:21:02 +)
>
> are available in the git
Am 02.11.2016 um 16:01 hat John Snow geschrieben:
>
>
> On 11/02/2016 09:33 AM, Kevin Wolf wrote:
> >Am 01.11.2016 um 04:16 hat John Snow geschrieben:
> >>Commit 9ef2e93f introduced the concept of tagging ATAPI commands as
> >>NONDATA, but this introduced a regression for certain commands better
On 11/02/2016 06:15 AM, Kevin Wolf wrote:
> Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben:
>> Sorry for a bit late response. The function looks fine but just some
>> doubt on g_renew in this piece of code(and the legacy), does
>> g_renew(realloc) has much performance impact if it's call many
On 11/02/2016 09:33 AM, Kevin Wolf wrote:
Am 01.11.2016 um 04:16 hat John Snow geschrieben:
Commit 9ef2e93f introduced the concept of tagging ATAPI commands as
NONDATA, but this introduced a regression for certain commands better
described as CONDDATA. read_cd is such a command that both
On Tue 26 Apr 2016 11:31:59 PM CEST, Max Reitz wrote:
> There are some issues regarding filename generation right now:
>
> - You always get a JSON filename if you set even a single qcow2-specific
> runtime options (as long as it does not have a dot in it, which is a
> bug, too, but here it is
On 02.11.2016 16:00, Alberto Garcia wrote:
> On Tue 26 Apr 2016 11:31:59 PM CEST, Max Reitz wrote:
>
>> There are some issues regarding filename generation right now:
>>
>> - You always get a JSON filename if you set even a single qcow2-specific
>> runtime options (as long as it does not have a
Am 01.11.2016 um 04:16 hat John Snow geschrieben:
> v2:
> - Actually applied the changes this time ...
> - And added a test to the AHCI suite...
> - ...Which revealed a few small issues in the suite.
>
> The AHCI test should be sufficient in terms of general proof
> for ATAPI regardless of the
Am 01.11.2016 um 04:16 hat John Snow geschrieben:
> Commit 9ef2e93f introduced the concept of tagging ATAPI commands as
> NONDATA, but this introduced a regression for certain commands better
> described as CONDDATA. read_cd is such a command that both requires
> a non-zero BCL if a transfer size
On 11/02/2016 02:13 PM, Stefan Hajnoczi wrote:
> On Tue, Oct 25, 2016 at 04:04:35PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> ping
>>
>> For now there are some notes mostly about accessory patches. What about
>> migration itself? Is it ok? Has it a chance of being merged one day?
> This series
在 2016-11-02 19:15, Kevin Wolf 写道:
Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben:
Sorry for a bit late response. The function looks fine but just some
doubt on g_renew in this piece of code(and the legacy), does
g_renew(realloc) has much performance impact if it's call many times
since
Am 02.11.2016 um 11:52 hat Hao QingFeng geschrieben:
> Sorry for a bit late response. The function looks fine but just some
> doubt on g_renew in this piece of code(and the legacy), does
> g_renew(realloc) has much performance impact if it's call many times
> since alloc and memory copy are both
Am 02.11.2016 um 11:53 hat Ashijeet Acharya geschrieben:
> This patch drops the unused parameter "BDRVSSHState" being passed into
> the ssh_config() function and does code cleanup. The unused parameter
> was introduced by the commit c322712.
>
> Signed-off-by: Ashijeet Acharya
On Tue, Oct 25, 2016 at 04:04:35PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> ping
>
> For now there are some notes mostly about accessory patches. What about
> migration itself? Is it ok? Has it a chance of being merged one day?
This series mostly touches migration/ code. Juan or DaveG?
>
This patch drops the unused parameter "BDRVSSHState" being passed into
the ssh_config() function and does code cleanup. The unused parameter
was introduced by the commit c322712.
Signed-off-by: Ashijeet Acharya
---
Changes in v2:
- Modify the commit message and subject
Am 02.11.2016 um 11:40 hat Ashijeet Acharya geschrieben:
> This patch frees the leaked visitor in nbd_refresh_filename() and uses
> visit_free() to fix it. The leak was introduced by the commit 491d6c7.
>
> Signed-off-by: Ashijeet Acharya
> Reviewed-by: Eric Blake
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Eric Blake
---
Changes in v3:
- Modify the Subject line
- Free
On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf wrote:
> Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben:
>> This patch drops the unused parameter "BDRVSSHState" being passed into
>> the ssh_config() function and fixes the bug.
>>
>> Signed-off-by: Ashijeet Acharya
On Wed, Nov 2, 2016 at 4:00 PM, Kevin Wolf wrote:
> Am 02.11.2016 um 10:48 hat Ashijeet Acharya geschrieben:
>> This patch frees the leaked visitor in nbd_refresh_filename() and uses
>> visit_free() to fix it. The leak was introduced by the commit 491d6c7.
>>
>> Signed-off-by:
Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben:
> This patch drops the unused parameter "BDRVSSHState" being passed into
> the ssh_config() function and fixes the bug.
>
> Signed-off-by: Ashijeet Acharya
The patch looks good, but why do claim that this is a
Am 02.11.2016 um 10:48 hat Ashijeet Acharya geschrieben:
> This patch frees the leaked visitor in nbd_refresh_filename() and uses
> visit_free() to fix it. The leak was introduced by the commit 491d6c7.
>
> Signed-off-by: Ashijeet Acharya
> Reviewed-by: Eric Blake
This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.
Signed-off-by: Ashijeet Acharya
Reviewed-by: Eric Blake
---
Changes in v2:
- Include the regression commit
On 31/10/16 21:50, Jeff Cody wrote:
> Some older GCC versions (e.g. 4.4.7) report a warning on an
> uninitialized variable for 'request', even though all possible code
> paths that reference 'request' will be initialized. To appease
> these versions, initialize the variable to 0.
>
>
38 matches
Mail list logo