Re: [Qemu-block] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands

On Fri, 12/02 01:52, Max Reitz wrote: > > diff --git a/qemu-img.c b/qemu-img.c > > index afcd51f..b2f4077 100644 > > --- a/qemu-img.c > > +++ b/qemu-img.c > > @@ -679,6 +679,10 @@ static int img_check(int argc, char **argv) > > break; > > } > > } > > + > > +if

Re: [Qemu-block] [PATCH 01/14] osdep: Add qemu_lock_fd and qemu_unlock_fd

On Fri, 12/02 01:30, Max Reitz wrote: > On 31.10.2016 16:38, Fam Zheng wrote: > > They are wrappers of POSIX fcntl "file private locking". > > > > Signed-off-by: Fam Zheng > > --- > > include/qemu/osdep.h | 2 ++ > > util/osdep.c | 29 + > >

Re: [Qemu-block] [Qemu-devel] [PATCH] migration: re-active images when migration fails to complete

Hi， On 2016/12/6 23:24, Dr. David Alan Gilbert wrote: * Kevin Wolf (kw...@redhat.com) wrote: Am 19.11.2016 um 12:43 hat zhanghailiang geschrieben: commit fe904ea8242cbae2d7e69c052c754b8f5f1ba1d6 fixed a case which migration aborted QEMU because it didn't regain the control of images while

Re: [Qemu-block] [Qemu-devel] [PATCH 08/21] block: introduce auto-loading bitmaps

On 11/22/2016 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps store in the disk image, which should > be loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [PATCH 09/21] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > >

Re: [Qemu-block] [PATCH 16/21] qmp: add persistent flag to block-dirty-bitmap-add

On 11/22/2016 11:26 AM, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > --- > +++

Re: [Qemu-block] [PATCH 08/21] block: introduce auto-loading bitmaps

On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps store in the disk image, which should s/store/stored/ > be loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

Re: [Qemu-block] [PATCH 07/21] qcow2: add bitmaps extension

On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Add bitmap extension as specified in docs/specs/qcow2.txt. > For now, just mirror extension header into Qcow2 state and check > constraints. > > For now, disable image resize if it has bitmaps. It will be fixed later. > > Signed-off-by:

Re: [Qemu-block] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

Am 07.12.2016 um 16:50 hat Eric Blake geschrieben: > On 12/07/2016 04:44 AM, Kevin Wolf wrote: > >> Just because the NBD spec describes the bit does NOT require that > >> servers HAVE to set the bit on all images that are all zeroes. It is > >> perfectly compliant if the server never advertises

Re: [Qemu-block] [PATCH v3 1/5] blkdebug: Sanity check block layer guarantees

Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: > Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment > any I/O to fit within device boundaries. Additionally, when using a > minimum alignment of 4k, we want to ensure the block layer does proper > read-modify-write rather than

Re: [Qemu-block] [PATCH v3 3/5] blkdebug: Simplify override logic

Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: > Rather than store into a local variable, the copy to the struct > if the value is valid, then reporting errors otherwise, it is > simpler to just store into the struct and report errors if the > value is invalid. This however requires that the

Re: [Qemu-block] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes

Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: > Use blkdebug's new geometry constraints to emulate setups that > have caused recent regression fixes: write zeroes asserting > when running through a loopback block device with max-transfer > smaller than cluster size, and discard rounding away

Re: [Qemu-block] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

On 12/07/2016 04:44 AM, Kevin Wolf wrote: >> Just because the NBD spec describes the bit does NOT require that >> servers HAVE to set the bit on all images that are all zeroes. It is >> perfectly compliant if the server never advertises the bit. > > True, but if no server exists that would

Re: [Qemu-block] [Qemu-devel] [PULL for-2.8 0/3] Block patches for -rc3

On 12/07/2016 04:08 AM, Kevin Wolf wrote: >> # Since: 2.7 >> ## >> @@ -2148,25 +2205,163 @@ >>'data': { 'volume': 'str', >> 'path': 'str', >> 'server': ['GlusterServer'], >> -'*debug-level': 'int' } } >> +'*debug': 'int', >> +

Re: [Qemu-block] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

On 12/07/2016 07:55 AM, Kevin Wolf wrote: > Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: >> In order to test the effects of artificial geometry constraints >> on operations like write zero or discard, we first need blkdebug >> to manage these actions. It also allows us to inject errors on

[Qemu-block] [PATCH v2] qemu-img: fix in-flight count for qemu-img bench

With aio=native (qemu-img bench -n) one or more requests can be completed when a new request is submitted. This in turn can cause bench_cb to recurse before b->in_flight is updated. This causes multiple I/Os to be submitted with the same offset and, furthermore, the blk_aio_* coroutines are

Re: [Qemu-block] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries

Am 02.12.2016 um 20:22 hat Eric Blake geschrieben: > Make it easier to simulate various unusual hardware setups (for > example, recent commits 3482b9b and b8d0a98 affect the Dell > Equallogic iSCSI with its 15M preferred and maximum unmap and > write zero sizing, or b2f95fe deals with the Linux

Re: [Qemu-block] [Qemu-devel] vpc max table entries calculation error

Am 29.11.2016 um 22:07 hat Nick Owens geschrieben: > i'm writing to discuss an issue in qemu's vpc creation. > > when creating a dynamic-type vpc image with qemu-img like so: > > $ qemu-img create -f vpc vhd.vhd 100M > Formatting 'vhd.vhd', fmt=vpc size=104857600 > > and then inspecting the

Re: [Qemu-block] [PATCH] doc: Propose NBD_FLAG_INIT_ZEROES extension

Am 06.12.2016 um 16:21 hat Eric Blake geschrieben: > On 12/06/2016 03:25 AM, Kevin Wolf wrote: > > Am 06.12.2016 um 00:42 hat Eric Blake geschrieben: > >> While not directly related to NBD_CMD_WRITE_ZEROES, the qemu > >> team discovered that it is useful if a server can advertise > >> whether an

Re: [Qemu-block] [Qemu-devel] [PULL for-2.8 0/3] Block patches for -rc3

Am 06.12.2016 um 16:43 hat Eric Blake geschrieben: > On 12/06/2016 09:11 AM, Eric Blake wrote: > > >> BlockdevOptionsGluster.debug(-level) does not have "Added in 2.8" so I > >> had to dig through git-blame(1) to verify that it was indeed added in > >> the current release cycle. > > > > Then

Re: [Qemu-block] [Qemu-devel] Meeting notes on -blockdev, dynamic backend reconfiguration

On Wed, 12/07 10:48, Kevin Wolf wrote: > > If so I think there is no race to worry about, mirror-filter should go > > away only after a QMP command. > > Currently, a mirror job goes away whenever it is done. This is not > directly tied to a QMP command. Ah right, block-job-complete is only

Re: [Qemu-block] [Qemu-devel] Meeting notes on -blockdev, dynamic backend reconfiguration

Am 07.12.2016 um 03:55 hat Fam Zheng geschrieben: > On Mon, 12/05 13:03, Markus Armbruster wrote: > > == Basic dynamic reconfiguration operation == > > > > The basic operation is "replace child". > > > > Beware of race conditions. Consider: > > > > BB > > | > >