Re: [Qemu-block] [PATCH 2/2] qemu-img: Add dd seek= option

2018-08-16 Thread Kevin Wolf
Am 16.08.2018 um 04:49 hat Max Reitz geschrieben: > On 2018-08-16 04:39, Eric Blake wrote: > > If convert were more powerful, I'd be fine dropping 'qemu-img dd' after > > a proper deprecation period. > > Technically it has those features already, with the raw block driver's > offset and size param

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area

2018-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180814121443.33114-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area === TEST SCRIPT BEGIN === #!/bin/bash B

Re: [Qemu-block] [PULL 00/21] Block layer patches

2018-08-16 Thread Peter Maydell
On 15 August 2018 at 13:55, Kevin Wolf wrote: > The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866: > > Update version for v3.0.0 release (2018-08-14 16:38:43 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > f

Re: [Qemu-block] [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues

2018-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180809213528.14738-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues === TEST SCRIPT BEGIN === #!/bin/bash BA

[Qemu-block] [PATCH v2 1/4] block: adding lzfse decompressing support as a module.

2018-08-16 Thread Julio Faracco
QEMU dmg support includes zlib and bzip2, but it does not contains lzfse support. This commit adds the source file to extend compression support for new DMGs. Signed-off-by: Julio Faracco --- block/dmg-lzfse.c | 49 +++ 1 file changed, 49 insertions(+)

[Qemu-block] [PATCH v2 3/4] dmg: including dmg-lzfse module inside dmg block driver.

2018-08-16 Thread Julio Faracco
This commit includes the support to new module dmg-lzfse into dmg block driver. It includes the support for block type ULFO (0x8007). Signed-off-by: Julio Faracco --- block/dmg.c | 28 block/dmg.h | 3 +++ 2 files changed, 31 insertions(+) diff --git a/block/dm

[Qemu-block] [PATCH v2 2/4] configure: adding support to lzfse library.

2018-08-16 Thread Julio Faracco
This commit includes the support to lzfse opensource library. With this library dmg block driver can decompress images with this type of compression inside. Signed-off-by: Julio Faracco --- block/Makefile.objs | 2 ++ configure | 31 +++ 2 files changed, 33

Re: [Qemu-block] [PATCH 0/7] qcow2: async handling of fragmented io

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
16.08.2018 03:51, Max Reitz wrote: On 2018-08-07 19:43, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is an asynchronous scheme for handling fragmented qcow2 reads and writes. Both qcow2 read and write functions loops through sequential portions of data. The series aim it to parallelize thes

[Qemu-block] [PATCH v2 0/4] Adding LZFSE compression support for DMG block driver.

2018-08-16 Thread Julio Faracco
Since Mac OS X El Capitain (v10.11), Apple uses LZFSE compression to generate compressed DMGs as an alternative to BZIP2. Possible, Apple want to keep this algorithm as default in long term. Some years ago, Apple opened the LZFSE algorithm to opensource and the main source (or the most active re

[Qemu-block] [PATCH v2 4/4] dmg: exchanging hardcoded dmg UDIF block types to enum.

2018-08-16 Thread Julio Faracco
This change is better to understand what kind of block type is being handled by the code. Using a syntax similar to the DMG documentation is easier than tracking all hex values assigned to a block type. Signed-off-by: Julio Faracco --- block/dmg.c | 43 ---

Re: [Qemu-block] [Qemu-devel] [RFC] new, node-graph-based fleecing and backup

2018-08-16 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814165349.56344-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [RFC] new, node-grap

Re: [Qemu-block] [Qemu-devel] [RFC v2] new, node-graph-based fleecing and backup

2018-08-16 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814170126.56461-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [RFC v2] new, node-

Re: [Qemu-block] [Qemu-devel] [RFC] new, node-graph-based fleecing and backup

2018-08-16 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814165349.56344-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [RFC] new, node-gra

Re: [Qemu-block] [Qemu-devel] [RFC] new, node-graph-based fleecing and backup

2018-08-16 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814165349.56344-2-vsement...@virtuozzo.com Subject: [Qemu-devel] [RFC] new, node-grap

Re: [Qemu-block] [Qemu-devel] [RFC] new, node-graph-based fleecing and backup

2018-08-16 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814165349.56344-2-vsement...@virtuozzo.com Subject: [Qemu-devel] [RFC] new, node-gra

Re: [Qemu-block] [Qemu-devel] [RFC v2] new, node-graph-based fleecing and backup

2018-08-16 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180814170126.56461-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [RFC v2] new, node-g

[Qemu-block] [PATCH 0/4] block nodes graph visualization

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Hi all! On the way of backup schemes development (and in general any complicated developments in Qemu block layer) it would be good to have a way to print out graph of block nodes with their permissions. Here is this way. Instead of a lot of words I'll reply to this cover letter with example grap

[Qemu-block] [PATCH 1/4] block: improve blk_root_get_parent_desc

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Make blk_root_get_parent_desc return different descriptions for different blk's in worst case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index fa120630be.

[Qemu-block] [PATCH 2/4] qapi: add x-query-block-nodes-relations

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Add new command, returning list of block nodes graph edges. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 71 +++ include/block/block.h | 1 + block.c | 57 + blockdev

[Qemu-block] [PATCH 3/4] scripts/qemu: add render_block_graph method for QEMUMachine

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Render block nodes graph with help of graphviz Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/qemu.py | 53 + 1 file changed, 53 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index f099ce7278..cff562c713 100644 --- a/sc

Re: [Qemu-block] [Qemu-devel] [RFC v2] new, node-graph-based fleecing and backup

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Hmm, how should I properly set based-on, if there two series under this one? Based on: [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area and [PATCH 0/2] block: make .bdrv_close optional 16.08.2018 18:05, no-re...@patchew.org wrote: Hi, This series failed docker-mingw@f

[Qemu-block] [PATCH 4/4] not-for-commit: example of new command usage for debugging

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/222 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222 index 0ead56d574..6e2d96cd72 100644 --- a/tests/qemu-iotests/222 +++ b/tests/qemu-iotests/222 @@ -137,6 +137,7 @@ with iotests

Re: [Qemu-block] [PATCH 1/4] block: improve blk_root_get_parent_desc

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Hmm, now I think, that instead of this, it is better to use pointer as parent id for nod-bds parents, to be sure they will not intersect. And add special field to qapi block relation info "parent-description" for such parents. Also I'm afraid that this patch may break iotests.. 16.08.2018 20:2

Re: [Qemu-block] [Qemu-devel] [RFC v2] new, node-graph-based fleecing and backup

2018-08-16 Thread Eric Blake
On 08/16/2018 12:28 PM, Vladimir Sementsov-Ogievskiy wrote: Hmm, how should I properly set based-on, if there two series under this one? Based on:    [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area    and    [PATCH 0/2] block: make .bdrv_close optional patchew goes off mail

Re: [Qemu-block] [Qemu-devel] [PATCH 00/33] Qtest driver framework

2018-08-16 Thread Emanuele
On 15/08/2018 14:38, Markus Armbruster wrote: Emanuele Giuseppe Esposito writes: Qgraph API for the qtest driver framework This series of patches introduce a different qtest driver organization, viewing machines, drivers and tests as node in a graph, each having one or multiple edges relation

[Qemu-block] [PATCH v2 1/2] block: for jobs, do not clear user_paused until after the resume

2018-08-16 Thread Jeff Cody
The function job_cancel_async() will always cause an assert for blockjob user resume. We set job->user_paused to false, and then call job->driver->user_resume(). In the case of blockjobs, this is the block_job_user_resume() function. In that function, we assert that job.user_paused is set to tru

[Qemu-block] [PATCH v2 2/2] block: iotest to catch abort on forced blockjob cancel

2018-08-16 Thread Jeff Cody
Signed-off-by: Jeff Cody --- tests/qemu-iotests/229 | 95 ++ tests/qemu-iotests/229.out | 23 + tests/qemu-iotests/group | 1 + 3 files changed, 119 insertions(+) create mode 100755 tests/qemu-iotests/229 create mode 100644 tests/qemu-iotests/2

[Qemu-block] [PATCH v2 0/2] block: for jobs, do not clear user_paused until after the resume

2018-08-16 Thread Jeff Cody
v2 changes: Patch 1: Added r-b from John, Eric (Thanks) Patch 2: Attached an iotest as patch 2 * cc'ed qemu-stable For the test in patch 2, failure here is the failure output w/o patch 1: {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANG

[Qemu-block] nbd oldstyle negotiation

2018-08-16 Thread Vladimir Sementsov-Ogievskiy
Hi Eric! There is a small problem with our qemu-nbd cmdline interface: people forget to use option -x or don't know about it and face into problems with old protocol version. One of may colleagues after such situation (because of this option, he could not use utility nbd-client, which doesn't

Re: [Qemu-block] [PATCH for-3.1 v10 02/31] block: Use children list in bdrv_refresh_filename

2018-08-16 Thread Eric Blake
On 08/09/2018 04:34 PM, Max Reitz wrote: bdrv_refresh_filename() should invoke itself recursively on all children, not just on file. With that change, we can remove the manual invocations in blkverify, quorum, commit, mirror, and blklogwrites. Signed-off-by: Max Reitz --- block.c

Re: [Qemu-block] [PATCH] doc: Permit BLOCK_STATUS reply to extend beyond request

2018-08-16 Thread Eric Blake
On 08/15/2018 04:23 AM, Vladimir Sementsov-Ogievskiy wrote: ping. Finally, Qemu 3.0 released, and it is incompatible with current NBD protocol. Please, commit this patch. Indeed, qemu 3.0 with the qemu:dirty-bitmap:NAME context does exceed the final length when REQ_ONE is not in force. As

Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] Improve qemu-img dd

2018-08-16 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180815025614.53588-1-ebl...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] Improve qemu-im

Re: [Qemu-block] nbd oldstyle negotiation

2018-08-16 Thread Eric Blake
On 08/16/2018 02:02 PM, Vladimir Sementsov-Ogievskiy wrote: Hi Eric! There is a small problem with our qemu-nbd cmdline interface: people forget to use option -x or don't know about it and face into problems with old protocol version. One of may colleagues after such situation (because of thi

Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] Improve qemu-img dd

2018-08-16 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180815025614.53588-1-ebl...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] Improve qemu-i

Re: [Qemu-block] [PATCH] qemu-img.c: increase spacing between commands in documentation

2018-08-16 Thread Programmingkid
> On Aug 14, 2018, at 4:40 AM, Kevin Wolf wrote: > > Am 13.08.2018 um 20:19 hat Eric Blake geschrieben: >> On 08/13/2018 11:56 AM, Max Reitz wrote: >>> >>> Ah, hm, so much for that. Hm... I don't quite know what to think of >>> this. It does indeed improve legibility. But the question is w

Re: [Qemu-block] [PATCH 3/4] scripts/qemu: add render_block_graph method for QEMUMachine

2018-08-16 Thread Eduardo Habkost
On Thu, Aug 16, 2018 at 08:20:26PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Render block nodes graph with help of graphviz > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks for your patch. Comments below: > --- > scripts/qemu.py | 53 ++

[Qemu-block] [PATCH v3 1/3] file-posix: Skip effectiveless OFD lock operations

2018-08-16 Thread Fam Zheng
If we know we've already locked the bytes, don't do it again; similarly don't unlock a byte if we haven't locked it. This doesn't change the behavior, but fixes a corner case explained below. Libvirt had an error handling bug that an image can get its (ownership, file mode, SELinux) permissions ch

[Qemu-block] [PATCH v3 2/3] file-posix: Drop s->lock_fd

2018-08-16 Thread Fam Zheng
The lock_fd field is not strictly necessary because transferring locked bytes from old fd to the new one shouldn't fail anyway. This spares the user one fd per image. Signed-off-by: Fam Zheng --- block/file-posix.c | 37 + 1 file changed, 13 insertions(+), 24

[Qemu-block] [PATCH v3 0/3] file-posix: Simplifications on image locking

2018-08-16 Thread Fam Zheng
The first patch reduces chances of QEMU crash in unusual (but not unlikely) cases especially when used by Libvirt (see commit message). The second patch halves fd for images. The third adds some more test for patch one (would have caught the regression caused by v2). Fam Zheng (3): file-posix:

[Qemu-block] [PATCH v3 3/3] tests: Add unit tests for image locking

2018-08-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/Makefile.include | 2 + tests/test-image-locking.c | 152 + 2 files changed, 154 insertions(+) create mode 100644 tests/test-image-locking.c diff --git a/tests/Makefile.include b/tests/Makefile.include index 760a0f18b6