Re: [Qemu-block] Combining synchronous and asynchronous IO

2019-03-15 Thread Kevin Wolf
Am 15.03.2019 um 16:33 hat Sergio Lopez geschrieben: > > Stefan Hajnoczi writes: > > > On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote: > >> Our current AIO path does a great job at unloading the work from the VM, > >> and combined with IOThreads provides a good performance in most >

Re: [Qemu-block] Combining synchronous and asynchronous IO

2019-03-15 Thread Sergio Lopez
Stefan Hajnoczi writes: > On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote: >> Our current AIO path does a great job at unloading the work from the VM, >> and combined with IOThreads provides a good performance in most >> scenarios. But it also comes with its costs, in both a longer

Re: [Qemu-block] [PATCH] vpc: unlock Coroutine lock to make IO submit Concurrently

2019-03-15 Thread Kevin Wolf
Am 15.03.2019 um 15:04 hat Zhengui li geschrieben: > Concurrent IO becomes serial IO because of the qemu Coroutine lock, > which reduce IO performance severely. > > So unlock Coroutine lock before bdrv_co_pwritev and > bdrv_co_preadv to fix it. > > Signed-off-by: Zhengui li Thanks, applied to t

Re: [Qemu-block] [PATCH] vpc: unlock Coroutine lock to make IO submit Concurrently

2019-03-15 Thread Paolo Bonzini
On 15/03/19 15:04, Zhengui li wrote: > Concurrent IO becomes serial IO because of the qemu Coroutine lock, > which reduce IO performance severely. > > So unlock Coroutine lock before bdrv_co_pwritev and > bdrv_co_preadv to fix it. > > Signed-off-by: Zhengui li > --- > block/vpc.c | 4 > 1

Re: [Qemu-block] Combining synchronous and asynchronous IO

2019-03-15 Thread Stefan Hajnoczi
On Thu, Mar 14, 2019 at 06:31:34PM +0100, Sergio Lopez wrote: > Our current AIO path does a great job at unloading the work from the VM, > and combined with IOThreads provides a good performance in most > scenarios. But it also comes with its costs, in both a longer execution > path and the need of

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Markus Armbruster
Kevin Wolf writes: > Coverity doesn't like that the return value of bdrv_check_update_perm() > stays unused only in this place (CID 1399710). > > Even if checking local_err should be equivalent to checking ret < 0, > let's switch to using the return value to be more consistent (and in > case of a

Re: [Qemu-block] [Qemu-devel] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate

2019-03-15 Thread Markus Armbruster
Anthony PERARD writes: > On Thu, Mar 14, 2019 at 08:04:00PM +0100, Markus Armbruster wrote: >> Kevin Wolf writes: >> >> > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben: >> >> Patch created mechanically by rerunning: >> >> >> >> $ spatch --sp-file scripts/coccinelle/qobject.cocci

Re: [Qemu-block] [Qemu-devel] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 14:27, Kevin Wolf wrote: > > Coverity doesn't like that the return value of bdrv_check_update_perm() > stays unused only in this place (CID 1399710). > > Even if checking local_err should be equivalent to checking ret < 0, > let's switch to using the return value to be more

Re: [Qemu-block] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Alberto Garcia
On Fri 15 Mar 2019 12:18:43 PM CET, Kevin Wolf wrote: > Coverity doesn't like that the return value of bdrv_check_update_perm() > stays unused only in this place (CID 1399710). > > Even if checking local_err should be equivalent to checking ret < 0, > let's switch to using the return value to be m

[Qemu-block] [PATCH] vpc: unlock Coroutine lock to make IO submit Concurrently

2019-03-15 Thread Zhengui li
Concurrent IO becomes serial IO because of the qemu Coroutine lock, which reduce IO performance severely. So unlock Coroutine lock before bdrv_co_pwritev and bdrv_co_preadv to fix it. Signed-off-by: Zhengui li --- block/vpc.c | 4 1 file changed, 4 insertions(+) diff --git a/block/vpc.c b

Re: [Qemu-block] [Qemu-devel] [PULL 34/54] commit: Support multiple roots above top node

2019-03-15 Thread Kevin Wolf
Am 14.03.2019 um 18:06 hat Peter Maydell geschrieben: > On Fri, 6 Oct 2017 at 17:20, Kevin Wolf wrote: > > > > This changes the commit block job to support operation in a graph where > > there is more than a single active layer that references the top node. > > > > This involves inserting the comm

Re: [Qemu-block] [PATCH] iotests: 153: Wait for an answer to QMP commands

2019-03-15 Thread Kevin Wolf
Am 15.03.2019 um 12:46 hat Sergio Lopez geschrieben: > There are various actions in this test that must be executed > sequentially, as the result of it depends on the state triggered by the > previous one. > > If the last argument of _send_qemu_cmd() is an empty string, it just > sends the QMP com

[Qemu-block] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Kevin Wolf
Coverity doesn't like that the return value of bdrv_check_update_perm() stays unused only in this place (CID 1399710). Even if checking local_err should be equivalent to checking ret < 0, let's switch to using the return value to be more consistent (and in case of a bug somewhere down the call cha

Re: [Qemu-block] [Qemu-devel] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate

2019-03-15 Thread Anthony PERARD
On Thu, Mar 14, 2019 at 08:04:00PM +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben: > >> Patch created mechanically by rerunning: > >> > >> $ spatch --sp-file scripts/coccinelle/qobject.cocci \ > >> --macro-file

[Qemu-block] [PATCH] iotests: 153: Wait for an answer to QMP commands

2019-03-15 Thread Sergio Lopez
There are various actions in this test that must be executed sequentially, as the result of it depends on the state triggered by the previous one. If the last argument of _send_qemu_cmd() is an empty string, it just sends the QMP commands without waiting for an answer. While unlikely, it may happe

Re: [Qemu-block] [PULL 13/28] file-posix: Prepare permission code for fd switching

2019-03-15 Thread Kevin Wolf
Am 14.03.2019 um 18:27 hat Peter Maydell geschrieben: > On Tue, 12 Mar 2019 at 17:30, Kevin Wolf wrote: > > > > In order to be able to dynamically reopen the file read-only or > > read-write, depending on the users that are attached, we need to be able > > to switch to a different file descriptor

Re: [Qemu-block] [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash

2019-03-15 Thread Michal Privoznik
On 3/14/19 8:01 PM, Markus Armbruster wrote: Michal Privoznik writes: On 3/8/19 2:14 PM, Markus Armbruster wrote: The previous commit added a way to configure firmware with -blockdev rather than -drive if=pflash. Document it as the preferred way. Signed-off-by: Markus Armbruster --- doc