On Mon, Oct 07, 2019 at 12:01:54PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Michael,
>
> On 10/5/19 11:46 PM, Michael S. Tsirkin wrote:
> > On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote:
> > > Hi.
> > >
> > > Following the thread discussion between Peter/Markus/Damien
On 10/7/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote:
Make it more obvious how to add new fields to the version 3 header and
how to interpret them.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
docs/interop/qcow2.txt | 26 +++---
1 file changed, 23 insertions(+), 3
On 10/7/19 7:05 AM, Max Reitz wrote:
On 24.09.19 16:35, Eric Blake wrote:
Log the QMP input to qemu, not just the QMP output.
Why not just add this functionality to _send_qemu_cmd directly? (Like
silent already does for replies, although it’s inverted.)
Interesting idea. I'll give it a
On 10/7/19 5:48 AM, Vladimir Sementsov-Ogievskiy wrote:
We want to wait until listening socket is prepared..
In shell:
qemu-nbd --pid-file=/path/to/file ...
while [ ! -e /path/to/file ]; do
sleep ... # fractional second, or exponential, or whatever...
done
# Now the listening socket is
One benefit of --pid-file is that it is easier to probe the file
system to see if a pid file has been created than it is to probe if a
socket is available for connection. Document that this is an
intentional feature.
Signed-off-by: Eric Blake
---
qemu-nbd.texi | 3 ++-
1 file changed, 2
On 10/7/19 5:49 AM, Markus Armbruster wrote:
> John Snow writes:
>
>> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
>> I'd like to refactor these some day, and getting rid of the super-object
>> will make that easier.
>
> Device "scsi-disk" is similar. However,
On 10/7/19 9:03 AM, Max Reitz wrote:
> On 03.10.19 01:51, John Snow wrote:
>>
>>
>> On 10/2/19 11:50 AM, Max Reitz wrote:
>>> On 02.10.19 17:10, Thomas Huth wrote:
On 02/10/2019 17.03, Daniel P. Berrangé wrote:
> On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote:
>>
On 10/7/19 7:35 PM, John Snow wrote:
On 10/7/19 8:33 AM, Peter Maydell wrote:
On Thu, 3 Oct 2019 at 20:33, John Snow wrote:
The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc:
Merge remote-tracking branch
'remotes/huth-gitlab/tags/pull-request-2019-10-01' into
On 10/7/19 8:33 AM, Peter Maydell wrote:
> On Thu, 3 Oct 2019 at 20:33, John Snow wrote:
>>
>> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc:
>>
>> Merge remote-tracking branch
>> 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01
>>
07.10.2019 18:27, Max Reitz wrote:
> On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
>> Currently total allocation for parallel requests to block-copy instance
>> is unlimited. Let's limit it to 128 MiB.
>>
>> For now block-copy is used only in backup, so actually we limit total
>>
07.10.2019 19:21, Daniel P. Berrangé wrote:
> On Mon, Oct 07, 2019 at 06:16:51PM +0200, Cornelia Huck wrote:
>> On Mon, 7 Oct 2019 16:10:02 +
>> Vladimir Sementsov-Ogievskiy wrote:
>>
>>> 07.10.2019 18:55, Cornelia Huck wrote:
On Tue, 1 Oct 2019 18:52:54 +0300
Vladimir
On 07.10.19 18:28, Thomas Huth wrote:
> On 07/10/2019 15.11, Thomas Huth wrote:
>> On 07/10/2019 14.52, Max Reitz wrote:
>>> On 07.10.19 14:16, Thomas Huth wrote:
On 04/10/2019 14.44, Max Reitz wrote:
> On 04.10.19 12:19, Kevin Wolf wrote:
>> Am 02.10.2019 um 19:47 hat Max Reitz
07.10.2019 18:22, Max Reitz wrote:
> On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
>> Introduce an API for some shared splitable resource, like memory.
>
> *splittable, I suppose
>
>> It's going to be used by backup. Backup uses both read/write io and
>> copy_range. copy_range may
07.10.2019 17:17, Max Reitz wrote:
> On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
>> Merge copying code into one function block_copy_do_copy, which only
>> calls bdrv_ io functions and don't do any synchronization (like dirty
>> bitmap set/reset).
>>
>> Refactor block_copy() function so
On 07/10/2019 15.11, Thomas Huth wrote:
> On 07/10/2019 14.52, Max Reitz wrote:
>> On 07.10.19 14:16, Thomas Huth wrote:
>>> On 04/10/2019 14.44, Max Reitz wrote:
On 04.10.19 12:19, Kevin Wolf wrote:
> Am 02.10.2019 um 19:47 hat Max Reitz geschrieben:
>> On 02.10.19 18:44, Kevin Wolf
On Mon, Oct 07, 2019 at 06:16:51PM +0200, Cornelia Huck wrote:
> On Mon, 7 Oct 2019 16:10:02 +
> Vladimir Sementsov-Ogievskiy wrote:
>
> > 07.10.2019 18:55, Cornelia Huck wrote:
> > > On Tue, 1 Oct 2019 18:52:54 +0300
> > > Vladimir Sementsov-Ogievskiy wrote:
>
> > >> +def
07.10.2019 18:48, Max Reitz wrote:
> On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
>> No reason to limit buffered copy to one cluster. Let's allow up to 1
>> MiB.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
>> include/block/block-copy.h | 2 +-
>> block/block-copy.c
On Mon, 7 Oct 2019 16:10:02 +
Vladimir Sementsov-Ogievskiy wrote:
> 07.10.2019 18:55, Cornelia Huck wrote:
> > On Tue, 1 Oct 2019 18:52:54 +0300
> > Vladimir Sementsov-Ogievskiy wrote:
> >> +def git_add(pattern):
> >> +subprocess.run(['git', 'add', pattern])
> >> +
> >> +
> >> +def
07.10.2019 18:55, Cornelia Huck wrote:
> On Tue, 1 Oct 2019 18:52:54 +0300
> Vladimir Sementsov-Ogievskiy wrote:
>
>> Add script to automatically commit tree-wide changes per-subsystem.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>> ---
>>
>> CC: kw...@redhat.com
>> CC: mre...@redhat.com
The patch add new additional field to qcow2 header: compression_type,
which specifies compression type. If field is absent or zero, default
compression type is set: ZLIB, which corresponds to current behavior.
New compression type (ZSTD) is to be added in further commit.
Suggested-by: Denis
On Tue, 1 Oct 2019 18:52:54 +0300
Vladimir Sementsov-Ogievskiy wrote:
> Add script to automatically commit tree-wide changes per-subsystem.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
>
> CC: kw...@redhat.com
> CC: mre...@redhat.com
> CC: js...@redhat.com
> CC: f...@euphon.net
>
Hi all!
Here is my proposal, about how to correctly update qcow2 specification
to introduce new field, keeping in mind currently existing images and
downstream Qemu instances.
Let's consider discussing from this.
I called it v7, as it's a continuation of
"[PATCH v6 0/3] qcow2: add zstd cluster
Make it more obvious how to add new fields to the version 3 header and
how to interpret them.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
docs/interop/qcow2.txt | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/docs/interop/qcow2.txt
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> No reason to limit buffered copy to one cluster. Let's allow up to 1
> MiB.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/block-copy.h | 2 +-
> block/block-copy.c | 44
On Fri, 4 Oct 2019 at 11:00, Kevin Wolf wrote:
>
> The following changes since commit 4f59102571fce49af180cfc6d4cdd2b5df7bdb14:
>
> Merge remote-tracking branch
> 'remotes/amarkovic/tags/mips-queue-oct-01-2019' into staging (2019-10-01
> 16:21:42 +0100)
>
> are available in the Git repository
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> No reason to limit buffered copy to one cluster. Let's allow up to 1
> MiB.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/block-copy.h | 2 +-
> block/block-copy.c | 44
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> Introduce an API for some shared splitable resource, like memory.
*splittable, I suppose
> It's going to be used by backup. Backup uses both read/write io and
> copy_range. copy_range may consume memory implictly, so new API is
*the new
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> Currently total allocation for parallel requests to block-copy instance
> is unlimited. Let's limit it to 128 MiB.
>
> For now block-copy is used only in backup, so actually we limit total
> allocation for backup job.
>
> Signed-off-by:
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> Merge copying code into one function block_copy_do_copy, which only
> calls bdrv_ io functions and don't do any synchronization (like dirty
> bitmap set/reset).
>
> Refactor block_copy() function so that it takes full decision about
> size
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> Large copy range may imply memory allocation and large io effort, so
> using 2G copy range request may be bad idea. Let's limit it to 16 MiB.
> It also helps the following patch to refactor copy-with-offload
> fallback to
On 03.10.19 19:15, Vladimir Sementsov-Ogievskiy wrote:
> Move bounce_buffer allocation block_copy_with_bounce_buffer. This
> commit simplifies further work on implementing copying by larger chunks
> (of different size) and further asynchronous handling of block_copy
> iterations (with help of
On 07/10/2019 14.52, Max Reitz wrote:
> On 07.10.19 14:16, Thomas Huth wrote:
>> On 04/10/2019 14.44, Max Reitz wrote:
>>> On 04.10.19 12:19, Kevin Wolf wrote:
Am 02.10.2019 um 19:47 hat Max Reitz geschrieben:
> On 02.10.19 18:44, Kevin Wolf wrote:
>> Am 02.10.2019 um 13:57 hat Max
On 27.09.19 16:17, Cleber Rosa wrote:
> The most trivial set of cleanups to iotests common libraries and the
> 044 test.
>
> Cleber Rosa (4):
> qemu-iotests: remove bash shebang from library files
> qemu-iotests: remove forceful execution success from library files
> qemu-iotests: 044: pass
On 03.10.19 01:51, John Snow wrote:
>
>
> On 10/2/19 11:50 AM, Max Reitz wrote:
>> On 02.10.19 17:10, Thomas Huth wrote:
>>> On 02/10/2019 17.03, Daniel P. Berrangé wrote:
On Wed, Oct 02, 2019 at 04:21:46PM +0200, Thomas Huth wrote:
> Running the iotests during "make check" is causing
On 07.10.19 14:16, Thomas Huth wrote:
> On 04/10/2019 14.44, Max Reitz wrote:
>> On 04.10.19 12:19, Kevin Wolf wrote:
>>> Am 02.10.2019 um 19:47 hat Max Reitz geschrieben:
On 02.10.19 18:44, Kevin Wolf wrote:
> Am 02.10.2019 um 13:57 hat Max Reitz geschrieben:
>> It usually worked
On Mon, 7 Oct 2019 at 13:32, Thomas Huth wrote:
> On 04/10/2019 14.44, Max Reitz wrote:
> > Whenever make check fails, it’s urgent. Without iotests running in make
> > check, we had some time to sort the situation out. That’s no longer the
> > case.
> >
> > That means we need to take care of
On Thu, 3 Oct 2019 at 20:33, John Snow wrote:
>
> The following changes since commit 7f21573c822805a8e6be379d9bcf3ad9effef3dc:
>
> Merge remote-tracking branch
> 'remotes/huth-gitlab/tags/pull-request-2019-10-01' into staging (2019-10-01
> 13:13:38 +0100)
>
> are available in the Git
On 04/10/2019 14.44, Max Reitz wrote:
> On 04.10.19 12:19, Kevin Wolf wrote:
>> Am 02.10.2019 um 19:47 hat Max Reitz geschrieben:
>>> On 02.10.19 18:44, Kevin Wolf wrote:
Am 02.10.2019 um 13:57 hat Max Reitz geschrieben:
> It usually worked fine for me because it’s rather rare that
On 24.09.19 16:35, Eric Blake wrote:
> Run the test twice, once without iothreads, and again with, for more
> coverage of both setups.
>
> Suggested-by: Nir Soffer
> Signed-off-by: Eric Blake
> ---
> tests/qemu-iotests/223 | 66 +
> tests/qemu-iotests/223.out | 98
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/check | 15 ++-
tests/qemu-iotests/common.rc | 14 ++
tests/qemu-iotests/iotests.py | 12 ++--
3 files changed, 38 insertions(+), 3 deletions(-)
diff
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/028 | 3 ++-
tests/qemu-iotests/058 | 2 +-
tests/qemu-iotests/089 | 4 ++--
tests/qemu-iotests/091 | 7 ---
tests/qemu-iotests/109 | 3 ++-
tests/qemu-iotests/147 | 5 +++--
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Acked-by: Eric Blake
Signed-off-by: Stefan Hajnoczi
---
qemu-nbd.c| 12
qemu-nbd.texi | 4 ++--
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 9032b6de2a..afa969c785 100644
---
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
block/io_uring.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/block/io_uring.c b/block/io_uring.c
index a5c0d16220..56892fd1ab 100644
--- a/block/io_uring.c
+++
From: Aarushi Mehta
File descriptor registration eliminates the need to get file descriptors
for each request on the host kernel side. The host kernel keeps
references to a set of files that were registered by the application.
These files can be quickly accessed by index instead of a
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
include/block/block.h | 1 +
block.c | 22 ++
blockdev.c| 12
3 files changed, 27 insertions(+), 8 deletions(-)
diff --git a/include/block/block.h
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Reviewed-by: Maxim Levitsky
Signed-off-by: Stefan Hajnoczi
---
block/file-posix.c | 99 --
1 file changed, 79 insertions(+), 20 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
util/async.c | 36
1 file changed, 36 insertions(+)
diff --git a/util/async.c b/util/async.c
index 4e4c7af51e..f8502a9310 100644
--- a/util/async.c
+++ b/util/async.c
@@
From: Aarushi Mehta
Aborts when sqe fails to be set as sqes cannot be returned to the
ring. Adds slow path for short reads for older kernels
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
v10:
* Update MAINTAINERS file [Julia]
* Rename MAX_EVENTS to MAX_ENTRIES [Julia]
*
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
v10:
* Add missing space to qemu-img command-line documentation
---
qemu-img.c | 11 ++-
qemu-img-cmds.hx | 4 ++--
qemu-img.texi| 5 -
3 files changed, 16 insertions(+), 4
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
qemu-io.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index f64eca6940..0abb4af134 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -130,7
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
MAINTAINERS | 1 +
stubs/Makefile.objs | 1 +
stubs/io_uring.c| 32
3 files changed, 34 insertions(+)
create mode 100644 stubs/io_uring.c
diff --git
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
block/io_uring.c | 21 ++---
block/trace-events | 12
2 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/block/io_uring.c b/block/io_uring.c
index
From: Aarushi Mehta
Only enumerates option for devices that support it. Since QAPI schema
supports io_uring, which is the actual name of the Linux API, it is
preferred over io-uring.
Signed-off-by: Aarushi Mehta
Signed-off-by: Stefan Hajnoczi
---
qapi/block-core.json | 4 +++-
1 file
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Reviewed-by: Maxim Levitsky
Signed-off-by: Stefan Hajnoczi
---
configure | 27 +++
1 file changed, 27 insertions(+)
diff --git a/configure b/configure
index 8f8446f52b..3ac597c547 100755
--- a/configure
+++ b/configure
From: Aarushi Mehta
Signed-off-by: Aarushi Mehta
Reviewed-by: Maxim Levitsky
Signed-off-by: Stefan Hajnoczi
---
include/block/block.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/block/block.h b/include/block/block.h
index 37c9de7446..88a9673734 100644
---
v10:
* Dropped kernel submission queue polling, it requires root and has additional
limitations. It should be benchmarked and considered for inclusion later,
maybe even together with kernel side changes.
* Add io_uring_register_files() return value to trace_luring_fd_register()
* Fix
On 24.09.19 16:35, Eric Blake wrote:
> Log the QMP input to qemu, not just the QMP output.
Why not just add this functionality to _send_qemu_cmd directly? (Like
silent already does for replies, although it’s inverted.)
(Although I’m not quite sold on the indentation for commands, because
(1) we
04.10.2019 13:19, Roman Kagan wrote:
> On Wed, Oct 02, 2019 at 05:22:43PM +0300, Andrey Shinkevich wrote:
>> Added possibility to write compressed data by using the
>> blk_write_compressed. This action has the limitations of the format
>> driver. For example we can't write compressed data over
On 24.09.19 21:51, Eric Blake wrote:
> On 9/24/19 2:26 PM, Vladimir Sementsov-Ogievskiy wrote:
>> 24.09.2019 17:35, Eric Blake wrote:
>>> Commit 506902c6 dropped non-iothread coverage in order to test iothread,
>>> better is to run things twice. In doing this, I found it easier to
>>> edit the
On 27.09.19 12:11, Daniel P. Berrangé wrote:
> Some distros are now defaulting to LUKS version 2 which QEMU cannot
> process. For our I/O test that validates interoperability between the
> kernel/cryptsetup and QEMU, we need to explicitly ask for version 1
> of the LUKS format.
>
> Signed-off-by:
04.10.2019 21:05, Eric Blake wrote:
> On 9/24/19 3:31 AM, Vladimir Sementsov-Ogievskiy wrote:
>
+def qemu_nbd_popen(*args):
+ '''Run qemu-nbd in daemon mode and return the parent's exit code'''
+ return subprocess.Popen(qemu_nbd_args + ['--persistent'] + list(args))
+
On 30.09.19 23:38, Maxim Levitsky wrote:
> Fixes commit job / qemu-img commit, when
> commiting qcow2 file which is based on nbd export.
>
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1718727
>
> Signed-off-by: Maxim Levitsky
> ---
> block/nbd.c | 15 +++
> 1 file
Hi Michael,
On 10/5/19 11:46 PM, Michael S. Tsirkin wrote:
On Thu, Sep 26, 2019 at 05:17:22PM +0200, Philippe Mathieu-Daudé wrote:
Hi.
Following the thread discussion between Peter/Markus/Damien about
reset handlers:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg617103.html
I started
On 02.10.19 16:21, Thomas Huth wrote:
> Running the iotests during "make check" is causing more headaches than
> benefits for the block layer maintainers, so let's disable the iotests
> during "make check" again.
>
> Signed-off-by: Thomas Huth
> ---
> tests/Makefile.include | 2 +-
>
John Snow writes:
> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
> I'd like to refactor these some day, and getting rid of the super-object
> will make that easier.
Device "scsi-disk" is similar. However, it's still used by the
scsi_bus_legacy_add_drive() magic. Not
05.10.2019 22:44, John Snow wrote:
> I already try to make sure all bitmaps patches have been reviewed by both
> Red Hat and Virtuozzo anyway, so this formalizes the arrangement.
>
> Fam meanwhile is no longer as active, so I am removing him as a co-maintainer
> simply to reflect the current
Maxim Levitsky writes:
> On Fri, 2019-09-20 at 17:14 -0400, John Snow wrote:
>>
>> On 9/12/19 6:30 PM, Maxim Levitsky wrote:
>> > This patch series is continuation of my work to add encryption
>> > key managment to luks/qcow2 with luks.
>> >
>> > This is second version of this patch set.
>> >
Max Reitz writes:
> On 13.09.19 00:30, Maxim Levitsky wrote:
>> Currently only for changing crypto parameters
>
> Yep, that elegantly avoids most of the problems we’d have otherwise. :-)
>
>> Signed-off-by: Maxim Levitsky
[...]
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>>
Maxim Levitsky writes:
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 7900914506..4a6db98938 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4211,8 +4211,11 @@
> # Driver
Maxim Levitsky writes:
> Signed-off-by: Maxim Levitsky
> ---
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e6edd641f1..7900914506 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -4650,6 +4650,32 @@
>'data': { 'job-id': 'str',
>
Quick QAPI schema review only.
Maxim Levitsky writes:
> Now you can specify which slot to put the encryption key to
> Plus add 'active' option which will let user erase the key secret
> instead of adding it.
> Check that active=true it when creating.
>
> Signed-off-by: Maxim Levitsky
[...]
>
On Sun, Oct 06, 2019 at 16:31:50 -0400, John Snow wrote:
> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
> I'd like to refactor these some day, and getting rid of the super-object
> will make that easier.
>
> Either way, we don't need this.
>
> Signed-off-by: John Snow
72 matches
Mail list logo