Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:47写道：
> Since v1:
> - Removed the pci-host devices
>
Hello I want to know why remove this?
Thanks,
Li Qiang
> - Removed the vmcoreinfo conversion (elmarco) but add a comment.
> - Added Igor's R-b tag.
>
> Following the thread discussion between Pete
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, October 5, 2019 9:06 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: [PATCH v6 2/4] tests/test-replication.c: Add test for for secondar
Vladimir Sementsov-Ogievskiy writes:
> If we want to add some info to errp (by error_prepend() or
> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
> Otherwise, this info will not be added when errp == &fatal_err
> (the program will exit prior to the error_append_hint() or
> erro
Introduce a function to gracefully wake a coroutine sleeping in
qemu_co_sleep_ns().
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Kevin Wolf
Reviewed-by: Eric Blake
---
include/qemu/coroutine.h| 23 +++--
util/qemu-coroutine-sleep.c | 51 +++--
09.10.2019 11:04, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy writes:
>
>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of
>> functions with errp OUT parameter.
>>
>> It has three goals:
>>
>> 1. Fix issue with error_fatal & error_prepend/error_append_hint: user
>
08.10.2019 13:09, Vladimir Sementsov-Ogievskiy wrote:
> 08.10.2019 12:39, Greg Kurz wrote:
>> On Tue, 8 Oct 2019 08:41:08 +
>> Vladimir Sementsov-Ogievskiy wrote:
>>
>>> 08.10.2019 10:30, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
> Hi all!
>
> Here is
Vladimir Sementsov-Ogievskiy writes:
> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of
> functions with errp OUT parameter.
>
> It has three goals:
>
> 1. Fix issue with error_fatal & error_prepend/error_append_hint: user
> can't see this additional information, because exit(
> -Original Message-
> From: Lukas Straub
> Sent: Saturday, October 5, 2019 9:06 PM
> To: qemu-devel
> Cc: Zhang, Chen ; Jason Wang
> ; Wen Congyang ;
> Xie Changlong ; Kevin Wolf
> ; Max Reitz ; qemu-block
>
> Subject: [PATCH v6 4/4] colo: Update Documentation for continuous
> replicat
Hi all!
Here is NBD reconnect. Previously, if connection failed all current
and future requests will fail. After the series, nbd-client driver
will try to reconnect unlimited times. During first @reconnect-delay
seconds of reconnecting all requests will wait for the connection,
and if it is establi
Add test, which starts backup to nbd target and restarts nbd server
during backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/264| 95 +++
tests/qemu-iotests/264.out| 13 +
tests/qemu-iotests/group | 1 +
tests/qemu-io
Implement reconnect. To achieve this:
1. add new modes:
connecting-wait: means, that reconnecting is in progress, and there
were small number of reconnect attempts, so all requests are
waiting for the connection.
connecting-nowait: reconnecting is in progress, there were a lot of
On Thu, Oct 03, 2019 at 11:01:03AM +0100, Stefan Hajnoczi wrote:
> tests/test-bdrv-drain can hang in tests/iothread.c:iothread_run():
>
> while (!atomic_read(&iothread->stopping)) {
> aio_poll(iothread->ctx, true);
> }
>
> The iothread_join() function works as follows:
>
> void iothr
On 08.10.2019 16:24, Stefan Hajnoczi wrote:
On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote:
Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device
Initialization:
"Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it if
they offer VIRTIO_BLK_F_CONFIG_
On 9/29/19 1:49 PM, Maxim Levitsky wrote:
On Fri, 2019-09-27 at 23:13 -0500, Eric Blake wrote:
Qemu as server currently won't accept export names larger than 256
bytes, so most uses of qemu as client have no reason to get anywhere
near the NBD spec maximum of a 4k limit per string. However, we
On Wed, 9 Oct 2019 08:36:52 +
"Zhang, Chen" wrote:
> > -Original Message-
> > From: Lukas Straub
> > Sent: Saturday, October 5, 2019 9:06 PM
> > To: qemu-devel
> > Cc: Zhang, Chen ; Jason Wang
> > ; Wen Congyang ;
> > Xie Changlong ; Kevin Wolf
> > ; Max Reitz ; qemu-block
> >
> >
On 9/30/19 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
A bit light on the commit message for explaining why.
---
include/qemu/hbitmap.h | 7 +++
util/hbitmap.c | 2 ++
2 files changed, 9 insertions(+)
diff --git a/include/qemu/hb
Oops, somehow, I copied subject and forget to fix v9/v10. It's v10.
09.10.2019 11:41, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> Here is NBD reconnect. Previously, if connection failed all current
> and future requests will fail. After the series, nbd-client driver
> will try to reconnect unl
On Wed, 9 Oct 2019 06:03:03 +
"Zhang, Chen" wrote:
> > -Original Message-
> > From: Lukas Straub
> > Sent: Saturday, October 5, 2019 9:06 PM
> > To: qemu-devel
> > Cc: Zhang, Chen ; Jason Wang
> > ; Wen Congyang ;
> > Xie Changlong ; Kevin Wolf
> > ; Max Reitz ; qemu-block
> >
> >
09.10.2019 18:34, Eric Blake wrote:
> On 9/30/19 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Signed-off-by: Vladimir Sementsov-Ogievskiy
>
> A bit light on the commit message for explaining why.
If use just INT64_MAX, the comment below may be move here, accompanied by
your note about disk s
On Fri, Sep 27, 2019 at 11:37:52AM -0500, Eric Blake wrote:
> On 9/27/19 9:17 AM, Cleber Rosa wrote:
> > Due to not being able to find a reason to have shebangs on files that
> > are not executable.
> >
> > Signed-off-by: Cleber Rosa
> > ---
> > tests/qemu-iotests/common.config | 2 --
> > te
On Mon, Oct 07, 2019 at 03:09:25PM +0200, Max Reitz wrote:
> On 27.09.19 16:17, Cleber Rosa wrote:
> > The most trivial set of cleanups to iotests common libraries and the
> > 044 test.
> >
> > Cleber Rosa (4):
> > qemu-iotests: remove bash shebang from library files
> > qemu-iotests: remove f
On 9/30/19 10:15 AM, Vladimir Sementsov-Ogievskiy wrote:
Use bdrv_dirty_bitmap_next_dirty_area for bitmap_to_extents. Since
bdrv_dirty_bitmap_next_dirty_area is very accurate in its interface,
we'll never exceed requested region with last chunk. So, we don't need
dont_fragment, and bitmap_to_exte
On 9/30/19 10:15 AM, Vladimir Sementsov-Ogievskiy wrote:
Introduce NBDExtentArray class, to handle extents list creation in more
controlled way and with less OUT parameters in functions.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
nbd/server.c | 184 +--
On Wed, Oct 09, 2019 at 03:37:35PM +0300, Evgeny Yakovlev wrote:
> On 08.10.2019 16:24, Stefan Hajnoczi wrote:
> > On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote:
> > The motivation for this change looks correct but this patch may cause
> > host_features to change across live migra
On Wed, Oct 09, 2019 at 12:26:27PM -0400, Cleber Rosa wrote:
> On Fri, Sep 27, 2019 at 11:37:52AM -0500, Eric Blake wrote:
> > On 9/27/19 9:17 AM, Cleber Rosa wrote:
> > > Due to not being able to find a reason to have shebangs on files that
> > > are not executable.
> > >
> > > Signed-off-by: Cle
Reviewed-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/044 | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044
index aa2a00ceed..bae99e25cf 100755
--- a/tests/qemu-iotests/044
+++ b/tests/qemu-iotests/044
@
On Tue, Oct 08, 2019 at 02:24:16PM +0100, Stefan Hajnoczi wrote:
> On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote:
> > Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device
> > Initialization:
> >
> > "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it
On 6/6/19 1:41 PM, John Snow wrote:
When adding new persistent dirty bitmaps, we only check constraints
against currently stored bitmaps, and ignore the pending number and size
of any bitmaps yet to be stored.
Rework the "can_store" and "remove" interface to explicit "add" and "remove",
and begi
Reviewed-by: Eric Blake
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/044 | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044
index 8b2afa2a11..aa2a00ceed 100755
--- a/tests/qemu-iotests/044
+++ b/tests/qemu-iotests/044
@@ -102,17 +102,14 @@
On 10/9/19 3:08 AM, Li Qiang wrote:
Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于
2019年10月8日周二 下午10:32写道：
The PIIX3/IDE is a PCI device within the PIIX3 chipset, it will be reset
when the PCI bus it stands on is reset.
Convert its reset handler into a proper Device reset meth
On 10/5/19 3:44 PM, John Snow wrote:
> Hi; I'll be going away on an extended trip this November and have made
> arrangements for reviews to be handled in my absence. I've asked Vladimir
> to take point on any reviews for patches he didn't author, and have asked
> Eric to take point on reviewing
Vladimir Sementsov-Ogievskiy writes:
> 09.10.2019 11:04, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of
>>> functions with errp OUT parameter.
>>>
>>> It has three goals:
>>>
>>> 1. Fix issue with erro
On Tue, Oct 08, 2019 at 04:25:32PM +0200, Philippe Mathieu-Daudé wrote:
> The PIIX4/PM is a PCI device within the PIIX4 chipset, it will be reset
> when the PCI bus it stands on is reset.
>
> Convert its reset handler into a proper Device reset method.
>
> Reviewed-by: Igor Mammedov
> Signed-off
On 10/9/19 2:57 PM, Eric Blake wrote:
> On 6/6/19 1:41 PM, John Snow wrote:
>> When adding new persistent dirty bitmaps, we only check constraints
>> against currently stored bitmaps, and ignore the pending number and size
>> of any bitmaps yet to be stored.
>>
>> Rework the "can_store" and "rem
Hi Li,
On 10/9/19 4:28 AM, Li Qiang wrote:
Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于
2019年10月8日周二 下午10:47写道：
Since v1:
- Removed the pci-host devices
Hello I want to know why remove this?
I haven't removed the devices, I simply remove the patches converting
them to Dev
On 10/9/19 2:47 PM, Cleber Rosa wrote:
Due to not being able to find a reason to have shebangs on files that
are not executable.
While at it, add a mode hint to emacs, which would be clueless or
plain wrong about these containing shell code.
Suggested-by: Eric Blake
Signed-off-by: Cleber Rosa
On 10/2/19 7:24 PM, John Snow wrote:
> This parameter has been deprecated since 2.12.0 and is eligible for
> removal. Remove this parameter as it is actually completely ignored;
> let's not give false hope.
>
> Signed-off-by: John Snow
> Reviewed-by: Eric Blake
> Reviewed-by: Vladimir Sements
The most trivial set of cleanups to iotests common libraries and the
044 test.
Changes from v1:
* Added emacs mode hints on tests/qemu-iotests/common.* files (Eric
Blake)
Cleber Rosa (4):
qemu-iotests: remove bash shebang from library files
qemu-iotests: remove forceful execution success
Should not be necessary on files that are not executed standalone.
Reviewed-by: Eric Blake
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/common.config | 3 ---
tests/qemu-iotests/common.filter | 3 ---
tests/qemu-iotests/common.rc | 3 ---
3 files changed, 9 deletions(-)
diff --git a/t
Due to not being able to find a reason to have shebangs on files that
are not executable.
While at it, add a mode hint to emacs, which would be clueless or
plain wrong about these containing shell code.
Suggested-by: Eric Blake
Signed-off-by: Cleber Rosa
---
tests/qemu-iotests/common.config |
- Original Message -
> From: "Eric Blake"
> To: "Cleber Rosa" , qemu-de...@nongnu.org
> Cc: qemu-block@nongnu.org, "Max Reitz" , "Kevin Wolf"
> , qemu-triv...@nongnu.org,
> "Michael Tokarev" , "Laurent Vivier"
> Sent: Wednesday, October 9, 2019 3:51:56 PM
> Subject: Re: [PATCH v2 1/4]
On 10/8/19 2:51 AM, Markus Armbruster wrote:
>> I'll respin to hit the tests with a stiffer scrub-brush.
> Thanks!
051 is the only test I can find that uses ide-drive, and the non-pc
version of the test doesn't seem to use it, so this actually seems
sufficient.
I'd like to keep the test for id
V2: Change phrasings and spellings as Markus suggested.
John Snow (1):
IDE: deprecate ide-drive
qemu-deprecated.texi | 5 +
hw/ide/qdev.c | 3 +++
tests/qemu-iotests/051.pc.out | 6 --
3 files changed, 12 insertions(+), 2 deletions(-)
--
2.21.0
It's an old compatibility shim that just delegates to ide-cd or ide-hd.
I'd like to refactor these some day, and getting rid of the super-object
will make that easier.
Either way, we don't need this.
Libvirt-checked-by: Peter Krempa
Signed-off-by: John Snow
---
qemu-deprecated.texi |
Philippe Mathieu-Daudé 于2019年10月10日周四 上午3:54写道：
> Hi Li,
>
> On 10/9/19 4:28 AM, Li Qiang wrote:
> > Philippe Mathieu-Daudé mailto:phi...@redhat.com>> 于
> > 2019年10月8日周二 下午10:47写道：
> >
> > Since v1:
> > - Removed the pci-host devices
> >
> >
> > Hello I want to know why remove this?
>
>
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:32写道：
> The SiI3112A SATA controller is a PCI device, it will be reset
> when the PCI bus it stands on is reset.
>
> Convert its reset handler into a proper Device reset method.
>
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> ---
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:36写道：
> The VIA82C686B IDE controller is a PCI device, it will be reset
> when the PCI bus it stands on is reset.
>
> Convert its reset handler into a proper Device reset method.
>
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> ---
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:39写道：
> The VIA VT82C686 Southbridge is a PCI device, it will be reset
> when the PCI bus it stands on is reset.
>
> Convert its reset handler into a proper Device reset method.
>
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> ---
Philippe Mathieu-Daudé 于2019年10月8日周二 下午10:38写道：
> The LM8323 key-scan controller is a I2C device, it will be reset
> when the I2C bus it stands on is reset.
>
> Convert its reset handler into a proper Device reset method.
>
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Li Qiang
> --
09.10.2019 23:44, John Snow wrote:
>
>
> On 10/9/19 2:57 PM, Eric Blake wrote:
>> On 6/6/19 1:41 PM, John Snow wrote:
>>> When adding new persistent dirty bitmaps, we only check constraints
>>> against currently stored bitmaps, and ignore the pending number and size
>>> of any bitmaps yet to be s
50 matches
Mail list logo
