02.02.2021 05:56, Eric Blake wrote:
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
We want 64bit write-zeroes, and for this, convert all io functions to
64bit.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type
On 12/11/20 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> We want 64bit write-zeroes, and for this, convert all io functions to
> 64bit.
>
> We chose signed type, to be consistent with off_t (which is signed) and
> with possibility for signed return type (where negative value means
On Jan 29 10:15, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add support for TP 4065a ("Simple Copy Command"), v2020.05.04
> ("Ratified").
>
> The implementation uses a bounce buffer to first read in the source
> logical blocks, then issue a write of that bounce buffer. The default
> maximum
On Fri, 29 Jan 2021 at 17:22, Peter Maydell wrote:
>
> On Fri, 29 Jan 2021 at 16:13, Peter Maydell wrote:
> >
> > On Fri, 29 Jan 2021 at 14:52, Kevin Wolf wrote:
> > >
> > > Block layer patches:
> > >
> > > - Fix iotests to
On Fri, Jan 29, 2021 at 02:25:56PM +0100, Paolo Bonzini wrote:
> On 29/01/21 13:17, Daniel P. Berrangé wrote:
> > > On this one, my vote would be "no". "Versioned machine names
> > > include the QEMU version number" is pretty well entrenched,
> > > and requiring users to remember that when they
On 29/01/2021 08:15, Markus Armbruster wrote:
Several QOM type names contain ',':
ARM,bitband-memory
etraxfs,pic
etraxfs,serial
etraxfs,timer
fsl,imx25
fsl,imx31
fsl,imx6
fsl,imx6ul
fsl,imx7
grlib,ahbpnp
grlib,apbpnp
grlib,apbuart
On Sun, Jan 31, 2021 at 3:14 AM Philippe Mathieu-Daudé wrote:
>
> ARM_COMPATIBLE_SEMIHOSTING is an architecture feature, move its
> declaration to each target/ARCH/.
>
> Note, we do not modify the linux-user targets, as user-mode builds
> don't use Kconfig.
>
> Signed-off-by: Philippe
On Sun, Jan 31, 2021 at 3:24 AM Philippe Mathieu-Daudé wrote:
>
> Commit 56b5170c87e ("semihosting: Move ARM semihosting code to
> shared directories") selected ARM_COMPATIBLE_SEMIHOSTING which
> already selects SEMIHOSTING. No need to select it again.
>
> Signed-off-by: Philippe Mathieu-Daudé
For -makecheck, the old 'check' implementation skipped the output when
starting a test. It only had the condensed output at the end of a test.
testrunner.py prints the normal output when starting a test even for
-makecheck. This output contains '\r' at the end so that it can be
overwritten with
From: Vladimir Sementsov-Ogievskiy
Ignore two complains, which now lead to 297 failure on testenv.py and
testrunner.py.
Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id:
From: Vladimir Sementsov-Ogievskiy
We should indicate failure by exit code, not only output.
Reported-by: Peter Maydell
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210201085041.3079-1-vsement...@virtuozzo.com>
Signed-off-by: Kevin
From: Vladimir Sementsov-Ogievskiy
I'm developing Qemu backup for several years, and finally new backup
architecture, including block-copy generic engine and backup-top filter
landed upstream, great thanks to reviewers and especially to
Max Reitz!
I also have plans of moving other block-jobs
From: Sergio Lopez
Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
bdrv_drain_all_begin().
Export drivers may have coroutines yielding at some point in the block
layer, so we need to shut them down before draining the block layer,
as otherwise they may get stuck
From: Sergio Lopez
Some graphs may contain an indirect reference to the first BDS in the
chain that can be reached while walking it bottom->up from one its
children.
Doubling-processing of a BDS is especially problematic for the
aio_notifiers, as they might attempt to work on both the old and
The following changes since commit 74208cd252c5da9d867270a178799abd802b9338:
Merge remote-tracking branch
'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging (2021-01-29
19:51:25 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git
On Mon, 1 Feb 2021, Daniel P. Berrangé wrote:
On Mon, Feb 01, 2021 at 06:25:33PM +0100, Paolo Bonzini wrote:
On 01/02/21 17:54, Kevin Wolf wrote:
How does this option parsing work? Would then multiple patterns separated by
comma as in -trace pattern1,pattern2 also work?
This would be
On Mon, Feb 01, 2021 at 06:25:33PM +0100, Paolo Bonzini wrote:
> On 01/02/21 17:54, Kevin Wolf wrote:
> > > How does this option parsing work? Would then multiple patterns separated
> > > by
> > > comma as in -trace pattern1,pattern2 also work?
> > This would be interpreted as an implied "enable"
On Mon, 1 Feb 2021, Paolo Bonzini wrote:
On 01/02/21 17:54, Kevin Wolf wrote:
How does this option parsing work? Would then multiple patterns separated
by
comma as in -trace pattern1,pattern2 also work?
This would be interpreted as an implied "enable" option with a value of
Philippe Mathieu-Daudé writes:
> On 1/31/21 12:50 PM, Philippe Mathieu-Daudé wrote:
>> KVM requires the target cpu to be at least ARMv8 architecture
>> (support on ARMv7 has been dropped in commit 82bf7ae84ce:
>> "target/arm: Remove KVM support for 32-bit Arm hosts").
>>
>> Beside, KVM only
On 01/02/21 17:54, Kevin Wolf wrote:
How does this option parsing work? Would then multiple patterns separated by
comma as in -trace pattern1,pattern2 also work?
This would be interpreted as an implied "enable" option with a value of
"pattern1,pattern2". I don't think anything splits that
01.02.2021 19:58, Kevin Wolf wrote:
Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
01.02.2021 17:50, Kevin Wolf wrote:
Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
28.01.2021 18:28, John Snow wrote:
On 1/28/21 10:09 AM, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
> KVM requires the target cpu to be at least ARMv8 architecture
> (support on ARMv7 has been dropped in commit 82bf7ae84ce:
> "target/arm: Remove KVM support for 32-bit Arm hosts").
>
> Only enable the following ARMv6 CPUs when TCG is available:
>
> - ARM1136
>
Philippe Mathieu-Daudé writes:
> KVM requires the target cpu to be at least ARMv8 architecture
> (support on ARMv7 has been dropped in commit 82bf7ae84ce:
> "target/arm: Remove KVM support for 32-bit Arm hosts").
>
> Only enable the following ARMv4 CPUs when TCG is available:
>
> - StrongARM
Am 01.02.2021 um 17:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 01.02.2021 17:50, Kevin Wolf wrote:
> > Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 28.01.2021 18:28, John Snow wrote:
> > > > On 1/28/21 10:09 AM, Markus Armbruster wrote:
> > > > > Vladimir
Am 01.02.2021 um 17:29 hat BALATON Zoltan geschrieben:
> On Mon, 1 Feb 2021, Kevin Wolf wrote:
> > Am 01.02.2021 um 17:05 hat BALATON Zoltan geschrieben:
> > > On Mon, 1 Feb 2021, Stefan Hajnoczi wrote:
> > > > It is possible to repeat the --trace option to specify multiple
> > > > patterns. This
On Mon, 1 Feb 2021, Kevin Wolf wrote:
Am 01.02.2021 um 17:05 hat BALATON Zoltan geschrieben:
On Mon, 1 Feb 2021, Stefan Hajnoczi wrote:
It is possible to repeat the --trace option to specify multiple
patterns. This may be preferrable to users who do not want to create a
file with a list of
On 2/1/21 5:13 PM, Kevin Wolf wrote:
> Am 01.02.2021 um 17:05 hat BALATON Zoltan geschrieben:
>> On Mon, 1 Feb 2021, Stefan Hajnoczi wrote:
>>> It is possible to repeat the --trace option to specify multiple
>>> patterns. This may be preferrable to users who do not want to create a
>>> file with a
01.02.2021 17:50, Kevin Wolf wrote:
Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
28.01.2021 18:28, John Snow wrote:
On 1/28/21 10:09 AM, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
I'm developing Qemu backup for several years, and finally new
Am 01.02.2021 um 17:05 hat BALATON Zoltan geschrieben:
> On Mon, 1 Feb 2021, Stefan Hajnoczi wrote:
> > It is possible to repeat the --trace option to specify multiple
> > patterns. This may be preferrable to users who do not want to create a
> > file with a list of patterns.
> >
> >
01.02.2021 19:10, Kevin Wolf wrote:
For -makecheck, the old 'check' implementation skipped the output when
starting a test. It only had the condensed output at the end of a test.
testrunner.py prints the normal output when starting a test even for
-makecheck. This output contains '\r' at the
For -makecheck, the old 'check' implementation skipped the output when
starting a test. It only had the condensed output at the end of a test.
testrunner.py prints the normal output when starting a test even for
-makecheck. This output contains '\r' at the end so that it can be
overwritten with
On Mon, 1 Feb 2021, Stefan Hajnoczi wrote:
It is possible to repeat the --trace option to specify multiple
patterns. This may be preferrable to users who do not want to create a
file with a list of patterns.
Suggested-by: BALATON Zoltan
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Philippe
Am 01.02.2021 um 09:50 hat Vladimir Sementsov-Ogievskiy geschrieben:
> We should indicate failure by exit code, not only output.
>
> Reported-by: Peter Maydell
> Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Thanks, applied to the block branch.
It is possible to repeat the --trace option to specify multiple
patterns. This may be preferrable to users who do not want to create a
file with a list of patterns.
Suggested-by: BALATON Zoltan
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Philippe Mathieu-Daudé
Message-id:
From: Volker Rümelin
Commit 4e66c9ef64 "tracetool: add input filename and line number to
Event" forgot to add a line number and a filename argument at one
build method call site.
Traceback (most recent call last):
File "./scripts/simpletrace.py", line 261, in
run(Formatter())
File
From: Daniel P. Berrangé
All variables are 64-bit and so %l / %ll are not required, and the
latter is actually invalid:
$ sudo stap -e 'probe begin{printf ("BEGIN")}' -I .
parse error: invalid or missing conversion specifier
saw: operator ',' at
The documentation still refers to the makefile and the old sub-directory
layout. Meson works differently: tracetool output is placed into the
builddir with mangled filenames like /trace/trace-accel_kvm.h
for the accel/kvm/ trace.h definition.
This meson setup also requires a manually-created
This is a simple rST conversion of the documentation.
Reviewed-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
Message-id: 20201216160923.722894-3-stefa...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
docs/devel/index.rst| 1 +
docs/devel/{tracing.txt => tracing.rst} |
Am 29.01.2021 um 17:13 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Ignore two complains, which now lead to 297 failure on testenv.py and
> testrunner.py.
>
> Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
> Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
> Signed-off-by: Vladimir
Re-generate tracetool output when the tracetool source code changes. Use
the same approach as qapi_gen_depends and introduce a tracetool_depends
files list so meson is aware of the dependencies.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Paolo Bonzini
Message-id:
From: Laurent Vivier
macro is not reset after use, so the format decoded is always the
one of the first "PRI" in the format string.
For instance:
vhost_vdpa_set_config(void *dev, uint32_t offset, uint32_t size, \
uint32_t flags) "dev: %p offset: %"PRIu32" \
The "simple" backend is actually more complicated to use than the "log"
backend. Update the quickstart documentation to feature the "log"
backend instead of the "simple" backend.
Suggested-by: Peter Maydell
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Peter Maydell
Message-id:
Timestamps in tracing output can be distracting. Make it possible to
control tid/timestamp printing with -msg timestamp=on|off. The default
is no tid/timestamps. Previously they were always printed.
Suggested-by: BALATON Zoltan
Signed-off-by: Stefan Hajnoczi
Tested-by: Philippe Mathieu-Daudé
The -msg timestamp=on|off option controls whether a timestamp is printed
with error_report() messages. The "-msg" name suggests that this option
has a wider effect than just error_report(). The next patch extends it
to the 'log' trace backend, so rename the variable from
error_with_timestamp to
The simpletrace documentation section was accidentally split when the
ftrace section was introduced. Move the simpletrace-specific
documentation back into the simpletrace section.
Fixes: e64dd5efb2c6d522a3bc9d096cd49a4e53f0ae10 ("trace: document ftrace
backend")
Reviewed-by: Peter Maydell
The following changes since commit 74208cd252c5da9d867270a178799abd802b9338:
Merge remote-tracking branch
'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging (2021-01-29
19:51:25 +)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git
Am 01.02.2021 um 13:50 hat Sergio Lopez geschrieben:
> This series allows the NBD server to properly switch between AIO contexts,
> having quiesced recv_coroutine and send_coroutine before doing the transition.
>
> We need this because we send back devices running in IO Thread owned contexts
> to
Am 01.02.2021 um 12:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 28.01.2021 18:28, John Snow wrote:
> > On 1/28/21 10:09 AM, Markus Armbruster wrote:
> > > Vladimir Sementsov-Ogievskiy writes:
> > >
> > > > I'm developing Qemu backup for several years, and finally new backup
> > > >
On Mon, Feb 01, 2021 at 01:50:26PM +, Alex Bennée wrote:
>
> Vladimir Sementsov-Ogievskiy writes:
>
> > 28.01.2021 18:28, John Snow wrote:
> >> On 1/28/21 10:09 AM, Markus Armbruster wrote:
> >>> Vladimir Sementsov-Ogievskiy writes:
> >>>
> I'm developing Qemu backup for several
On 1/31/21 4:23 PM, Philippe Mathieu-Daudé wrote:
> On 1/31/21 3:18 PM, Claudio Fontana wrote:
>> On 1/31/21 12:50 PM, Philippe Mathieu-Daudé wrote:
>>> Modules are registered early with type_register_static().
>>>
>>> We would like to call tcg_enabled() when registering QOM types,
>>
>>
>> Hi
Vladimir Sementsov-Ogievskiy writes:
> 28.01.2021 18:28, John Snow wrote:
>> On 1/28/21 10:09 AM, Markus Armbruster wrote:
>>> Vladimir Sementsov-Ogievskiy writes:
>>>
I'm developing Qemu backup for several years, and finally new backup
architecture, including block-copy generic
Philippe Mathieu-Daudé writes:
> Fixes when building with --disable-tcg on ARM:
>
> In file included from target/arm/helper.c:16:
> include/exec/helper-proto.h:42:10: fatal error: tcg-runtime.h: No such file
> or directory
> 42 | #include "tcg-runtime.h"
> |
Peng,
In my analysis, the root casue should be the lock: aio_context, qemu main
thread do an unnecessary release/aquire action,
That's why IO thread could get the lock it shouldn't hold at this stage.
Thanks,
Michael
At 2021-02-01 20:44:00, "Vladimir Sementsov-Ogievskiy"
wrote:
Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
bdrv_drain_all_begin().
Export drivers may have coroutines yielding at some point in the block
layer, so we need to shut them down before draining the block layer,
as otherwise they may get stuck blk_wait_while_drained().
RHBZ:
Some graphs may contain an indirect reference to the first BDS in the
chain that can be reached while walking it bottom->up from one its
children.
Doubling-processing of a BDS is especially problematic for the
aio_notifiers, as they might attempt to work on both the old and the
new AIO contexts.
This series allows the NBD server to properly switch between AIO contexts,
having quiesced recv_coroutine and send_coroutine before doing the transition.
We need this because we send back devices running in IO Thread owned contexts
to the main context when stopping the data plane, something that
Hi!
01.02.2021 15:07, Peng Liang wrote:
Hi,
I encountered the problem months ago too. Could we move the creation of
the block job (block_job_create) before appending the new bs to
mirror_top_bs (bdrv_append) as I wrote in [*]? I found that after
bdrv_append, qemu will use mirror_top_bs to do
On Mon, Feb 01, 2021 at 01:20:30PM +0100, Kevin Wolf wrote:
> Am 21.01.2021 um 18:07 hat Sergio Lopez geschrieben:
> > Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
> > bdrv_drain_all_begin().
> >
> > Export drivers may have coroutines yielding at some point in the block
>
On Mon, Feb 01, 2021 at 01:06:31PM +0100, Kevin Wolf wrote:
> Am 21.01.2021 um 18:06 hat Sergio Lopez geschrieben:
> > Some graphs may contain an indirect reference to the first BDS in the
> > chain that can be reached while walking it bottom->up from one its
> > children.
> >
> >
Am 21.01.2021 um 18:07 hat Sergio Lopez geschrieben:
> Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
> bdrv_drain_all_begin().
>
> Export drivers may have coroutines yielding at some point in the block
> layer, so we need to shut them down before draining the block layer,
>
On 9/23/2020 10:50 PM, John Snow wrote:
> On 8/26/20 9:19 AM, Peng Liang wrote:
>> We found an issue when doing block-commit with iothreads, which tries to
>> dereference a NULL pointer.
>>
>
> I'm clearing out my patch backlog. I am a bit out of the loop on block
> issues at the moment, did this
Hi,
I encountered the problem months ago too. Could we move the creation of
the block job (block_job_create) before appending the new bs to
mirror_top_bs (bdrv_append) as I wrote in [*]? I found that after
bdrv_append, qemu will use mirror_top_bs to do write. And when writing,
qemu will use
Am 21.01.2021 um 18:06 hat Sergio Lopez geschrieben:
> Some graphs may contain an indirect reference to the first BDS in the
> chain that can be reached while walking it bottom->up from one its
> children.
>
> Doubling-processing of a BDS is especially problematic for the
> aio_notifiers, as they
Philippe Mathieu-Daudé writes:
> SEMIHOSTING is an architecture feature, move its declaration to
> each target/ARCH/.
I'm going to punt on this one and leave it to the arch maintainers to
opine because AIUI in a lot of cases semihosting is more of a "useful
hack" than something mandated by
Philippe Mathieu-Daudé writes:
> ARM_COMPATIBLE_SEMIHOSTING is an architecture feature, move its
> declaration to each target/ARCH/.
>
> Note, we do not modify the linux-user targets, as user-mode builds
> don't use Kconfig.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
Philippe Mathieu-Daudé writes:
> Commit 56b5170c87e ("semihosting: Move ARM semihosting code to
> shared directories") selected ARM_COMPATIBLE_SEMIHOSTING which
> already selects SEMIHOSTING. No need to select it again.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
I'm so sorry, forgive my mail client(outlook)
I have try your solution, It doesn't work, still cause crash.
The reason is: we come to bdrv_mirror_top_pwritev() (which means that
mirror-top node is already inserted into block graph), but its bs->opaque->job
is not initialized"
But the root
Philippe Mathieu-Daudé writes:
> V7M is an architecture feature, move its declaration to target/arm/.
>
> Signed-off-by: Philippe Mathieu-Daudé
modulo previous comments:
Reviewed-by: Alex Bennée
--
Alex Bennée
Philippe Mathieu-Daudé writes:
> Add a target-specific Kconfig.
>
> Target foo now has CONFIG_FOO defined.
>
> Two architecture have a particularity, ARM and MIPS:
> their 64-bit version include the 32-bit subset.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> I suppose X86_64 should also
Philippe Mathieu-Daudé writes:
> SEV is an architecture feature, move its declaration to target/i386/.
In docs/devel/kconfig.rst we make the distinction between:
**subsystems**, of which **buses** are a special case
**devices**
**device groups**
**boards**
**internal elements**
Philippe Mathieu-Daudé writes:
> The Milkymist board requires more than the PTIMER. Directly
> select the LM32_PERIPHERALS. This fixes:
>
> /usr/bin/ld:
> libqemu-lm32-softmmu.fa.p/target_lm32_gdbstub.c.o: in function
> `lm32_cpu_gdb_read_register':
> target/lm32/gdbstub.c:46: undefined
28.01.2021 18:28, John Snow wrote:
On 1/28/21 10:09 AM, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
I'm developing Qemu backup for several years, and finally new backup
architecture, including block-copy generic engine and backup-top filter
landed upstream, great thanks to
Philippe Mathieu-Daudé writes:
> We want to be able to use the 'LM32' config for architecture
> specific features. As CONFIG_LM32 is only used to select
> peripherals, rename it CONFIG_LM32_PERIPHERALS.
>
> Signed-off-by: Philippe Mathieu-Daudé
_DEVICES if you want, either way:
Reviewed-by:
Hi!
Tanks for fixing and sorry for a delay!
Please send each new version of a patch as a separate branch. It's a rule from
https://wiki.qemu.org/Contribute/SubmitAPatch and it is more readable and less
probable that your patch will be missed.
28.01.2021 04:30, 08005...@163.com wrote:
From:
Philippe Mathieu-Daudé writes:
> We want to be able to use the 'LM32' config for architecture
> specific features. Introduce CONFIG_LM32_EVR to select the
> lm32-evr / lm32-uclinux boards.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
Philippe Mathieu-Daudé writes:
> We want to be able to use the 'SH4' config for architecture
> specific features. As CONFIG_SH4 is only used to select
> peripherals, rename it CONFIG_SH4_PERIPHERALS.
>
> Signed-off-by: Philippe Mathieu-Daudé
I agree with Balaton Zoltan that _DEVICES might be
We should indicate failure by exit code, not only output.
Reported-by: Peter Maydell
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/check | 5 -
tests/qemu-iotests/testrunner.py | 4 +++-
2 files changed, 7
29.01.2021 20:17, Kevin Wolf wrote:
Am 29.01.2021 um 17:13 hat Peter Maydell geschrieben:
On Fri, 29 Jan 2021 at 14:52, Kevin Wolf wrote:
The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
Merge remote-tracking branch
01.02.2021 11:29, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add QLIST_FOREACH_FUNC_SAFE(), QTAILQ_FOREACH_FUNC_SAFE() and
QTAILQ_POP_HEAD(), to be used in following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/qemu/queue.h | 14 ++
1
Vladimir Sementsov-Ogievskiy writes:
> Add QLIST_FOREACH_FUNC_SAFE(), QTAILQ_FOREACH_FUNC_SAFE() and
> QTAILQ_POP_HEAD(), to be used in following commit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/qemu/queue.h | 14 ++
> 1 file changed, 14 insertions(+)
>
>
29.01.2021 20:30, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20210129165030.640169-1-vsement...@virtuozzo.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id:
81 matches
Mail list logo
