es ;-)
>
> Who's with me?
Happy to chip in wherever I can be useful :-)
Reviewed-by: Kashyap Chamarthy
> Signed-off-by: Alex Bennée
> Cc: Thomas Huth
> Cc: Daniel P. Berrangé
> Cc: Markus Armbruster
> Cc: Kashyap Chamarthy
> Cc: Paolo Bonzini
> Cc: Peter
Hi,
(Sorry for the slowness here.)
On Thu, Jan 20, 2022 at 12:45:02PM +0100, Kevin Wolf wrote:
> Am 20.01.2022 um 09:02 hat Pierre Libeau geschrieben:
[...]
> > Hello,
> >
> > I'm working on a patch in nova to improve the time of file system
> > freeze during live-snapshot on an instance with
On Tue, Oct 26, 2021 at 09:37:29AM +0200, Kevin Wolf wrote:
> Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben:
[...]
> > This commit updates documentation and prepares tests. The next commit
> > updates the QAPI schema. The remaining patches update the QAPI
> > generator and wire up -c
On Tue, Oct 26, 2021 at 09:15:30AM +0200, Markus Armbruster wrote:
> Kashyap Chamarthy writes:
>
> > On Mon, Oct 25, 2021 at 07:25:24AM +0200, Markus Armbruster wrote:
[...]
> > Looks like there's another stable property with an "x-" prefix:
> &
On Mon, Oct 25, 2021 at 07:25:24AM +0200, Markus Armbruster wrote:
> By convention, names starting with "x-" are experimental. The parts
> of external interfaces so named may be withdrawn or changed
> incompatibly in future releases.
>
> Drawback: promoting something from experimental to stable i
st by advice?
>
> docs/interop/live-block-operations.rst | 47 +-
> docs/system/deprecated.rst | 11 ++
> qapi/block-core.json | 5 ++-
The core changes itself looks good; I have some minor nit-picks below,
hope that
hem. FWIW:
Reviewed-by: Kashyap Chamarthy
> diff --git a/docs/interop/bitmaps.rst b/docs/interop/bitmaps.rst
> index 059ad67929..ef95090c81 100644
> --- a/docs/interop/bitmaps.rst
> +++ b/docs/interop/bitmaps.rst
> @@ -539,12 +539,11 @@ other partial disk images on top of a bas
On Mon, Apr 26, 2021 at 01:34:17PM -0400, John Snow wrote:
> On 4/23/21 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
> > Modern way is using blockdev-add + blockdev-backup, which provides a
> > lot more control on how target is opened.
[...]
> 1) Let's add a sphinx reference to
> https://qemu-pro
tests: Update 245 to support replacing files with x-blockdev-reopen
>
> include/block/block.h | 1 +
> block.c| 61 ++
> tests/qemu-iotests/245 | 61 +++---
> tests/qemu-iotests/245.out | 4 +--
> 4 files changed, 121 inse
[Cc: qemu-block]
On Sun, Jan 03, 2021 at 11:35:49AM +0100, Kevin Nguetchouang wrote:
> nobody then ?
[No direct answer but a quick meta note ...]
... if you're looking for guidance on code internals, you might want to
wait a little more time for the block developers to notice. Some
regions of t
On Mon, Oct 19, 2020 at 05:56:56PM +0200, Alberto Garcia wrote:
> On Tue 06 Oct 2020 11:10:01 AM CEST, Kashyap Chamarthy wrote:
> > Hi, folks
> >
> > If this was already discussed on the list, please point me to the
> > thread. I took a quick look at my local
; +
> +**Warning:** Never modify images in use by a running virtual machine or any
> +other process; this may destroy the image. Also, be aware that querying an
> +image that is being modified by another process may encounter inconsistent
> +state.
I wonder if it's appropriate to mention libguestfs for safe, read-only
access to disk images (via `guestfish -ro -i -a disk.qcow2`). I say
this because, the above warning tells what _not_ to do; a pointer on
what to do could be useful. I let you decide on this.
The rest looks good to me; I couldn't even spot a typo.
Reviewed-by: Kashyap Chamarthy
[...]
--
/kashyap
On Tue, Jul 28, 2020 at 01:06:48PM +0200, Kevin Wolf wrote:
> Am 27.07.2020 um 23:50 hat Kashyap Chamarthy geschrieben:
[...]
> > IIUC, specifying 'node-name' should be sufficient. Also, you don't need
> > to specify JSON syntax on the command-line; you c
[Cc: qemu-block]
On Mon, Jul 27, 2020 at 05:11:15PM +0800, Derek Su wrote:
> Hello,
>
> I'm trying to replace "-drive if=ide,id=disk0." with "-blockdev
> '{"node-name": "top-node","
> The "id" is the name of BlockBackend, and the "node-name" is the name
> of the BDS tree's root.
> Is ther
to support strong crypto [1]. RSA
It looks like the reference [1] is supposed to resolve to the following
URL:
https://fedoraproject.org/wiki/Changes/StrongCryptoSettings2
Whoever is applying the patch might want to tweak the commit. FWIW:
Reviewed-by: Kashyap Chamarthy
> with 1
On Fri, May 01, 2020 at 04:05:47PM +0100, Stefan Hajnoczi wrote:
> On Wed, Apr 22, 2020 at 07:51:09AM +0200, Anders Östling wrote:
Hi Anders,
> > I am fighting to understand the difference between backing up a VM by
> > using a regular copy vs using the virsh blockcopy command.
tl;dr: While 'blo
On Thu, Mar 12, 2020 at 02:28:22PM -0500, Eric Blake wrote:
> Creating an image that requires format probing of the backing image is
> inherently unsafe (we've had several CVEs over the years based on
> probes leaking information to the guest on a subsequent boot, although
> these days tools like l
On Tue, Mar 10, 2020 at 07:15:29AM -0500, Eric Blake wrote:
> On 3/10/20 4:47 AM, Kashyap Chamarthy wrote:
[...]
> >
> >
> > Ah, didn't realize the inconsistency of 'convert' lacking the '-F'
> > shorthand ... which reminds me, there are
On Tue, Mar 10, 2020 at 07:19:25AM -0500, Eric Blake wrote:
> On 3/10/20 5:57 AM, Kashyap Chamarthy wrote:
(Slightly long e-mail, as it contains a bunch of tests and their
results; please bear with me.)
[...]
> > $> ~/build/qemu/qemu-img amend -o compat=v3 overlay1.qco
On Mon, Mar 09, 2020 at 10:42:25AM -0500, Eric Blake wrote:
[...]
> > > +qemu-img backing file without format (since 5.0.0)
> > > +''
> > > +
> > > +The use of ``qemu-img create``, ``qemu-img rebase``, ``qemu-img
> > > +convert``, or ``qemu-img amen
On Mon, Mar 09, 2020 at 10:42:25AM -0500, Eric Blake wrote:
> On 3/9/20 10:31 AM, Kashyap Chamarthy wrote:
>
> > After (with the patch series applied to QEMU Git):
> >
> > $> git describe
> > v4.2.0-2204-gd6c7830114
> >
> >
On Fri, Mar 06, 2020 at 04:51:21PM -0600, Eric Blake wrote:
> Creating an image that requires format probing of the backing image is
> inherently unsafe (we've had several CVEs over the years based on
> probes leaking information to the guest on a subsequent boot, although
> these days tools like l
On Fri, Apr 26, 2019 at 06:15:28PM -0400, John Snow wrote:
> This just about rewrites the entirety of the bitmaps.rst document to
> make it consistent with the 4.0 release. I have added new features seen
> in the 4.0 release, as well as tried to clarify some points that keep
> coming up when discus
On Fri, Jul 13, 2018 at 01:35:02PM +0200, Cornelia Huck wrote:
> On Thu, 12 Jul 2018 17:47:00 +0200
> Thomas Huth wrote:
> > On 12.07.2018 08:32, Markus Armbruster wrote:
> > > Daniel P. Berrangé writes:
[...]
> > > Our tool to help with getting cc: wrong less often is the MAINTAINERS
> > > f
On Wed, Jul 04, 2018 at 03:54:10PM +0100, Stefan Hajnoczi wrote:
> Throttle groups consist of members sharing one throttling state
> (including bps/iops limits). Round-robin scheduling is used to ensure
> fairness. If a group member already has a timer pending then other
> groups members do not s
On Tue, Jul 10, 2018 at 05:01:22PM +0200, Cornelia Huck wrote:
[...]
> Who is, in general, testing which libvirt version? I can think of:
> - libvirt developers, which will probably run libvirt current git, but
> more likely a released QEMU?
> - QEMU (and other related tools) developers, who wi
On Thu, Jun 28, 2018 at 05:19:37PM -0400, John Snow wrote:
>
>
> On 06/28/2018 02:05 PM, Eric Blake wrote:
> > On 06/28/2018 01:00 PM, John Snow wrote:
> >> In the case of image fleecing, the node we choose as the source
> >> for a blockdev-backup is going to be both a root node AND the
> >> back
already a
> > great start to prevent regressions, so:
> >
>
> Good suggestions. I'm working toward throwing bitmaps in now, but
> actually cleaning up the VM properly and stopping the NBD server and
> testing some of the latter-half paths would be nice. This was just a bit
> of an RFC to get the bits out there sooner rather than later.
Yeah, they can be added later on. For this test, you can just get away
by cleaning up the VM and the NBD export: log(vm.qmp("nbd-server-stop").
With that:
Reviewed-by: Kashyap Chamarthy
[...]
--
/kashyap
On Wed, Jun 06, 2018 at 03:36:53PM -0300, Eduardo Habkost wrote:
> On Wed, Jun 06, 2018 at 08:33:39PM +0200, Michal Suchánek wrote:
> [...]
> > Lastly we are missing a developer of a management layer committed to
> > support such appliances.
>
> This is important. Without developers of management
On Tue, May 29, 2018 at 03:10:58PM +0200, Kashyap Chamarthy wrote:
> On Tue, May 29, 2018 at 02:30:47PM +0200, Max Reitz wrote:
[...]
> > The special behavior is that you can use block-job-cancel after
> > BLOCK_JOB_READY to complete the job, but not pivot to it. I don't
On Tue, May 29, 2018 at 02:30:47PM +0200, Max Reitz wrote:
> On 2018-05-29 13:59, Kashyap Chamarthy wrote:
> > On Fri, May 25, 2018 at 10:00:35AM +0200, Kevin Wolf wrote:
[...]
> >> It can, and it already has its final semantics, so nothing has to change
> >> before 3.
On Fri, May 25, 2018 at 10:00:35AM +0200, Kevin Wolf wrote:
> Am 24.05.2018 um 19:42 hat John Snow geschrieben:
[...]
(Randomly chiming in for a small clarification.)
> > >> or some other mechanism that accomplishes the same type of behavior. It
> > >> would be nice if it did not have to be dete
On Mon, May 28, 2018 at 02:05:05PM +0200, Kashyap Chamarthy wrote:
> Cc the QEMU Block Layer mailing list (qemu-block@nongnu.org),
[Sigh; now add the QEMU BLock Layer e-mail list to Cc, without typos.]
> who might
> have more insights here; and wrap long lines.
>
> On Mon, May
On Mon, May 21, 2018 at 05:33:22PM -0300, Eduardo Habkost wrote:
> On Mon, May 21, 2018 at 09:18:17PM +0100, Daniel P. Berrangé wrote:
[...]
(Just catching up with this thread.)
[...]
> > > I have very specific goal here: the goal is to make it less
> > > painful to users when OpenStack+libvirt
| 74
>
> 2 files changed, 57 insertions(+), 27 deletions(-)
Thanks!
Reviewed-by: Kashyap Chamarthy
--
/kashyap
ng that this process (which must be read-only,
> because we can't have two writers at once) is permitting some other
> process to be the concurrent writer (but not multiple processes to be
> concurrent writers)
Precisely. So it's worth being clearer.
With the rewording suggested by Eric:
Reviewed-by: Kashyap Chamarthy
--
/kashyap
On Mon, Jan 29, 2018 at 05:01:41PM +0100, Max Reitz wrote:
> On 2017-12-26 03:52, Fam Zheng wrote:
[...]
> So the previous patch makes the use of blank lines consistent and this
> one breaks it again? :-)
>
> > +If specified, @code{qemu-img} will open the image with shared permissions,
> > +whic
On Tue, Dec 26, 2017 at 10:52:45AM +0800, Fam Zheng wrote:
> v5: Clean up the @table @var section first. [Kevin, Peter]
>
> Fam Zheng (2):
> qemu-img.texi: Clean up parameter list
> qemu-img: Document --force-share / -U
Reviewed-by: Kashyap Chamarthy
This documentation patc
On Wed, Jan 10, 2018 at 04:43:22PM +, Nir Soffer wrote:
> On Wed, Jan 10, 2018 at 4:04 PM Kashyap Chamarthy
> wrote:
[...]
> > Yes, for completness' sake, Nova upstream is already patched to use the
> > `qemu-img` '--force-share' flag that comes with QEMU
On Mon, Jan 08, 2018 at 03:41:36PM +0100, Kevin Wolf wrote:
> Am 05.01.2018 um 07:55 hat Fam Zheng geschrieben:
> > Management and users are accustomed to "qemu-img info" to query status of
> > images even when they are used by guests. Since image locking was added,
> > the -U
> > (--force-share)
Zheng
> ---
> qemu-img.texi | 66
> +++
> 1 file changed, 39 insertions(+), 27 deletions(-)
Reviewed-by: Kashyap Chamarthy
[...]
--
/kashyap
On Wed, Dec 20, 2017 at 10:57:40AM +, Daniel P. Berrange wrote:
> On Wed, Dec 20, 2017 at 11:44:36AM +0100, Kashyap Chamarthy wrote:
> > On Mon, Dec 18, 2017 at 11:11:00AM +0100, Markus Armbruster wrote:
[...]
> > > Another thought: do we want to give qemu-syst
On Mon, Dec 18, 2017 at 11:11:00AM +0100, Markus Armbruster wrote:
> Max Reitz writes:
[...]
Thanks, Max, for the detailed notes.
> > Image creation in qemu-system-* vs. qemu-img:
> > In order to get proper introspection for qemu-img create, we need a
> > QAPI schema. If we have a QAPI sch
sed by a running guest. Note that
> +this could produce inconsistent result because of concurrent metadata
> changes,
> +etc. This option is only allowed when opening images in read-only mode.
> +
Reviewed-by: Kashyap Chamarthy
--
/kashyap
On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
>
> ---
> v2: - "code{qemu-img}". [Kashyap, Eric]
> - "etc.." -> "etc.".
> ---
> qemu-img.texi | 9 +
> 1 file changed, 9 insertions(+)
Reviewed-by: Kashyap Chamarthy
[...]
--
/kashyap
On Thu, Dec 07, 2017 at 06:33:04PM +0100, Kevin Wolf wrote:
> Am 07.12.2017 um 12:56 hat Kashyap Chamarthy geschrieben:
[...]
> > So from the above interesting discussion, it seems like Kevin is leaning
> > towards a single job type that offers 'stream', 'comm
On Tue, Nov 21, 2017 at 07:10:19PM -0500, John Snow wrote:
> On 11/21/2017 12:23 PM, Kevin Wolf wrote:
[...] # Snip lot of good discussion.
> > On another note, I would double check before adding a new block job type
> > that this is the right way to go. We have recently noticed that many, if
> >
, so, when applying you
might want to: s/../.../
[*] https://dictionary.cambridge.org/dictionary/english/ellipsis
Regardless:
Reviewed-by: Kashyap Chamarthy
[...]
--
/kashyap
On Mon, Nov 27, 2017 at 12:53:07PM +0100, Kevin Wolf wrote:
> Am 21.11.2017 um 12:52 hat Kashyap Chamarthy geschrieben:
[...]
> > Signed-off-by: Kashyap Chamarthy
> > Reviewed-by: Eric Blake
>
> > +(1) Issuing the command ``block-job-cancel`` (
ended (and the destination now has
a point-in-time copy, which is at the time of cancel).
So add a small note to this effect in 'block-core.json'. While at it,
also update the "Live disk synchronization -- drive-mirror and
blockdev-mirror" section in 'live-block-operations.
On Fri, Nov 17, 2017 at 07:54:44PM +0100, Kashyap Chamarthy wrote:
[...]
> +So there are two possible actions to take, after a 'mirror' job has
> +emitted the event ``BLOCK_JOB_READY``, indicating that the source and
> +target have reached synchronization:
> +
> +(1) Is
On Fri, Nov 17, 2017 at 07:54:44PM +0100, Kashyap Chamarthy wrote:
> When you cancel an in-progress 'mirror' job (or "active `block-commit`)
When applying, can the maintainer please fix-up the missing closing
double-quote in the brackets above? It should be: &qu
(and the destination now has
a point-in-time copy, which is at the time of cancel).
So add a small note to this effect in 'block-core.json'. While at it,
also update the "Live disk synchronization -- drive-mirror and
blockdev-mirror" section in 'live-block-operati
On Fri, Nov 17, 2017 at 11:07:41AM -0600, Eric Blake wrote:
> On 11/17/2017 10:25 AM, Kashyap Chamarthy wrote:
[...]
> Sorry for not wordsmithing on earlier versions:
That's fine. Always appreciate your wordsmithing :-)
> > +'mirror' job *after* it has indic
me copy, which is at the time of cancel).
So add a small note to this effect in 'block-core.json'. While at it,
also update the "Live disk synchronization -- drive-mirror and
blockdev-mirror" section in 'live-block-operations.rst'.
(Thanks: Max Reitz for reminding
On Fri, Nov 17, 2017 at 11:49:05AM +0100, Kevin Wolf wrote:
> Am 16.11.2017 um 10:14 hat Kashyap Chamarthy geschrieben:
> > On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote:
[...]
> > > It's an interesting gotcha that I wasn't really acutely aware of mysel
On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote:
>
>
> On 11/15/2017 04:54 PM, Kashyap Chamarthy wrote:
> > On Wed, Nov 15, 2017 at 02:15:57PM -0500, John Snow wrote:
[...]
> >> is it covered sufficiently in live-block-operations.rst ?
> >
> > I l
On Wed, Nov 15, 2017 at 02:15:57PM -0500, John Snow wrote:
>
>
> On 11/15/2017 04:09 AM, Kashyap Chamarthy wrote:
> > When you cancel an in-progress live block operation with QMP
> > `block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However,
> > when `
"len":41126400,
"offset":41126400,
"speed":0,
"type":"mirror"
}
}
But this is expected behaviour, where the _COMPLETED event indicates
that synchronization has successfully ended (and the destination has a
point-in-t
On Tue, Nov 14, 2017 at 11:26:59AM -0800, no-re...@patchew.org wrote:
> Hi,
>
> This series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce
> it
> locally.
[...]
> In file included from /tmp/qemu-te
When you cancel an in-progress live block operation with QMP
`block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However,
when `block-job-cancel` is issued after `drive-mirror` has indicated (by
emitting the event BLOCK_JOB_READY) that the source and destination
remain synchronized:
[Cc: Matt Booth from Nova upstream; so not snipping the email to retain
context for Matt.]
On Thu, Nov 02, 2017 at 12:02:23PM +, Daniel P. Berrange wrote:
> I've been thinking about a potential design/impl improvement for the way
> that OpenStack Nova handles disk images when booting virtual m
On Mon, Oct 30, 2017 at 11:13:21AM +0100, Kevin Wolf wrote:
> Am 30.10.2017 um 09:39 hat Kashyap Chamarthy geschrieben:
> > On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:
[...]
> > > echo
> > > echo "Starting a second QEMU using the same imag
dio \
Isn't "-display none" preferred instead of "-nographic"?
Assuming you'll change it to "-display none":
Reviewed-by: Kashyap CHamarthy
[...]
--
/kashyap
On Mon, Oct 02, 2017 at 05:32:52PM +0200, Kevin Wolf wrote:
> Am 02.10.2017 um 17:01 hat Kashyap Chamarthy geschrieben:
> > On Tue, Sep 26, 2017 at 07:59:42PM +0200, Kevin Wolf wrote:
[...]
> > {
> > "execute": "block
On Tue, Sep 05, 2017 at 02:37:21PM -0500, Eric Blake wrote:
> On 09/04/2017 08:28 AM, Kashyap Chamarthy wrote:
> > On Mon, Sep 04, 2017 at 08:55:23PM +0800, Fam Zheng wrote:
> >> Hi Kashyap,
> >>
> >> On Mon, 09/04 13:16, Kashyap Chamarthy wrote:
>
&g
On Mon, Sep 04, 2017 at 03:48:12PM +0100, Daniel P. Berrange wrote:
> On Mon, Sep 04, 2017 at 01:16:16PM +0200, Kashyap Chamarthy wrote:
> > The test 192 ("Test NBD export with '-incoming' (non-shared
> > storage migration use case from libvirt")) is currently u
On Mon, Sep 04, 2017 at 08:55:23PM +0800, Fam Zheng wrote:
> Hi Kashyap,
>
> On Mon, 09/04 13:16, Kashyap Chamarthy wrote:
[...]
> > +dest_vm = (iotests.VM('dest').add_drive(test_img_path)
> > + .add_incoming('defer')
related to HMP".
While at it, convert the test from Bash to Python.
Signed-off-by: Kashyap Chamarthy
---
tests/qemu-iotests/192 | 78 ++
tests/qemu-iotests/192.out | 14 -
2 files changed, 38 insertions(+), 54 deletions(-)
diff --g
---
> tests/qemu-iotests/194| 1 +
> tests/qemu-iotests/iotests.py | 4 +++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Kashyap Chamarthy
> diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194
> index a3e3bad664..bfe1859ecf 100755
> --- a/
On Tue, Aug 29, 2017 at 04:16:54PM -0500, Eric Blake wrote:
> On 08/29/2017 12:42 PM, Stefan Hajnoczi wrote:
> > On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy
> > wrote:
> >> This is the follow-up patch that was discussed[*] as part of feedback to
> >> qem
b.cgi?p=qemu.git;a=blob;f=docs/interop/live-block-operations.rst
Signed-off-by: Kashyap Chamarthy
---
Changes in v3:
- Wait for migration to complete before issuing `block-job-cancel`
(StefanH)
- Wait for the event BLOCK_JOB_COMPLETED on the source before stopping
the NBD server on the des
On Tue, Aug 29, 2017 at 03:19:54PM +0100, Stefan Hajnoczi wrote:
> On Tue, Aug 29, 2017 at 11:06:22AM +0200, Kashyap Chamarthy wrote:
[...]
> > +iotests.log('Gracefully ending the `drive-mirror` job on source...')
> > +iotests.log(source_vm.qmp('block-job-cancel
vocation for live storage migration with
``drive-mirror`` + NBD").
[*] https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg04820.html
-- qemu-iotests: add 194 non-shared storage migration test
[+]
https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob;f=docs/interop/live-block-operatio
On Mon, Aug 28, 2017 at 09:51:43AM -0500, Eric Blake wrote:
> On 08/28/2017 06:29 AM, Kashyap Chamarthy wrote:
> > This is the follow-up patch that was discussed[*] as part of feedback to
> > qemu-iotest 194.
> >
> > Changes in this patch:
> >
> > - Sup
on with
``drive-mirror`` + NBD").
[*] https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg04820.html
-- qemu-iotests: add 194 non-shared storage migration test
[+]
https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob;f=docs/interop/live-block-operations.rst
Signed-off-by: Kashyap Cha
-name"
All commands showed in this document were tested while documenting.
Thanks: Eric Blake for the section: "A note on points-in-time vs file
names". This useful bit was originally articulated by Eric in his
KVMForum 2015 presentation, so I included that specific bit in this
docu
avoid ambiguity. Addressing the feedback from
this thread:
https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05428.html
Signed-off-by: Kashyap Chamarthy
Reviewed-by: John Snow
Reviewed-by: Eric Blake
---
* A Sphinx-rendered HTML version is here:
https
https://kashyapc.fedorapeople.org/v7-QEMU-Docs/_build/html/docs/live-block-operations.html
(2) Convert the 'bitmaps.md' document to rST, as discussed on this[+]
thread.
[*] http://wiki.qemu.org/Features/Documentation
[+] https://lists.nongnu.org/archive/html/qemu-devel/2017-0
On Tue, Jul 11, 2017 at 10:03:29AM -0500, Eric Blake wrote:
[...]
> Overall, looking good! Content-wise, I think we have a good document,
> and it was just a few spelling errors and grammar suggestions, minor
> enough that I'm comfortable with you adding:
> Reviewed-by: Eric Blake
All your sug
On Tue, Jul 11, 2017 at 06:33:22AM -0500, Eric Blake wrote:
> On 07/11/2017 02:58 AM, Kashyap Chamarthy wrote:
[...]
> >> A shame that git rename detection doesn't see these as the same rough
> >> contents, but not too bad.
> >
> > _Should_ it detec
On Mon, Jul 10, 2017 at 09:36:50PM -0500, Eric Blake wrote:
> On 07/10/2017 03:15 AM, Kashyap Chamarthy wrote:
[...]
> > Signed-off-by: Kashyap Chamarthy
> > Reviewed-by: John Snow
> > ---
>
> > ---
> > docs/devel/bitmaps.md| 505
lock-operations.html
(2) Convert the 'bitmaps.md' document to rST, as discussed on this[+]
thread.
[*] http://wiki.qemu.org/Features/Documentation
[+] https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05428.html
Kashyap Chamarthy (2):
bitmaps.md: Convert to rST; move it i
avoid ambiguity. Addressing the feedback from
this thread:
https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05428.html
Signed-off-by: Kashyap Chamarthy
Reviewed-by: John Snow
---
* A Sphinx-rendered HTML version is here:
https://kashyapc.fedorapeople.org/v5-QEMU-Docs/_build
"
All commands showed in this document were tested while documenting.
Thanks: Eric Blake for the section: "A note on points-in-time vs file
names". This useful bit was originally articulated by Eric in his
KVMForum 2015 presentation, so I included that specific bit in this
docu
On Fri, Jul 07, 2017 at 06:25:24PM -0400, John Snow wrote:
> Last time, on DRAGON BALL Q:
Didn't know of this before; just learnt the reference.
> On 07/06/2017 10:36 AM, Kashyap Chamarthy wrote:
>
> [A lot of good documentation]
>
> > +
> > +So, the
On Thu, Jul 06, 2017 at 06:41:07PM -0400, John Snow wrote:
> On 07/06/2017 10:36 AM, Kashyap Chamarthy wrote:
[...]
> > +disk image chains by merging data from overlays into backing files; live
> > +synchronize data from a disk image chain (including current active disk)
> &g
On Thu, Jul 06, 2017 at 04:36:46PM +0200, Kashyap Chamarthy wrote:
> This patch documents (including their QMP invocations) all the four
> major kinds of live block operations:
[...]
> (cherry picked from commit aef3e734f2d30b97e29345943d9e1cab794d0846)
Oops, the above "cherry p
avoid ambiguity. Addressing the feedback from
this thread:
https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05428.html
Signed-off-by: Kashyap Chamarthy
Reviewed-by: John Snow
---
* A Sphinx-rendered HTML version is here:
https://kashyapc.fedorapeople.org/v5-QEMU-Docs/_build
ps://kashyapc.fedorapeople.org/v5-QEMU-Docs/_build/html/docs/live-block-operations.html
(2) Convert the 'bitmaps.md' document to rST, as discussed on this[+]
thread.
Sphinx-generted HTML rendering:
https://kashyapc.fedorapeople.org/v5-QEMU-Docs/_build/html/docs/bitmaps.
"
All commands showed in this document were tested while documenting.
Thanks: Eric Blake for the section: "A note on points-in-time vs file
names". This useful bit was originally articulated by Eric in his
KVMForum 2015 presentation, so I included that specific bit in this
docu
On Wed, Jun 28, 2017 at 03:33:49PM -0500, Eric Blake wrote:
> On 06/28/2017 03:15 PM, Alberto Garcia wrote:
> > On Wed 28 Jun 2017 04:58:00 PM CEST, Kashyap Chamarthy wrote:
> >> This patch documents (including their QMP invocations) all the four
> >> major kin
; Signed-off-by: Daniel P. Berrange
> ---
> qemu-img.c | 10 +-
> 1 file changed, 1 insertion(+), 9 deletions(-)
FWIW:
Reviewed-by: Kashyap Chamarthy
> diff --git a/qemu-img.c b/qemu-img.c
> index 91ad6be..a65239f 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
>
On Thu, Jun 29, 2017 at 02:28:55PM +0200, Alberto Garcia wrote:
> On Wed 28 Jun 2017 04:58:00 PM CEST, Kashyap Chamarthy wrote:
> > +Once a 'mirror' job has started, there are two possible actions when a
> > +``drive-mirror`` job is active:
> > +
> > +1. I
avoid ambiguity. Addressing the feedback from
this thread:
https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05428.html
Signed-off-by: Kashyap Chamarthy
---
* A Sphinx-rendered HTML version is here:
https://kashyapc.fedorapeople.org/v4-QEMU-Docs/_build/html/docs/bitmaps.html
"
All commands showed in this document were tested while documenting.
Thanks: Eric Blake for the section: "A note on points-in-time vs file
names". This useful bit was originally articulated by Eric in his
KVMForum 2015 presentation, so I included that specific bit in this
docu
I just
stuck a v4 for this patch, too.
[*] http://wiki.qemu.org/Features/Documentation
[+] https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg05428.html
Kashyap Chamarthy (2):
live-block-ops.txt: Rename, rewrite, and improve it
bitmaps.md: Convert to rST; move it into 'inte
Rewrite the 'live-block-ops.txt' document (after renaming it to
'live-block-operations.rst') in reStructuredText (rST) format. Given
upstream QEMU's desire[*] to take advantage of the Sphinx + rST
framework to gerate its documentation:
"Based on experience from the Linux kernel, QEMU's docs p
On Thu, Jun 22, 2017 at 10:13:03AM -0400, John Snow wrote:
> On 06/22/2017 04:56 AM, Kashyap Chamarthy wrote:
> > On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote:
[...]
> > Yes, I was thinking of this, too -- just link to the 'bitmaps' document.
> >
On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote:
[...]
> > * TODO (after feedback from John Snow):
> >- Eric Blake suggested to consider documenting incremental backup
> > policies as part of the section: "Live disk backup ---
> > `drive-backup` and `blockdev-backup`"
>
>
1 - 100 of 153 matches
Mail list logo