[PATCH] vfio-helpers: Free QEMUVFIOState in qemu_vfio_close()

2020-04-22 Thread Michal Privoznik
==by 0x8FDC73: bdrv_open_inherit (block.c:3291) ==167296==by 0x8FE1B5: bdrv_open (block.c:3384) ==167296==by 0x5EE828: bds_tree_init (blockdev.c:663) ==167296==by 0x5F57F8: qmp_blockdev_add (blockdev.c:3746) ==167296==by 0x5666DC: configure_blockdev (vl.c:1047) Signed-off-by: Michal

Re: [PATCH] Report stringified errno in VFIO related errors

2020-02-14 Thread Michal Privoznik
On 2/14/20 4:49 PM, Alex Williamson wrote: On Fri, 14 Feb 2020 10:19:50 +0100 Michal Privoznik wrote: Do you guys want me to file a bug? Probably a good idea. Thanks, Since I'm reproducing this against upstream, I've reported it here: https://bugs.launchpad.net/qemu/+bug/186

Re: [PATCH] Report stringified errno in VFIO related errors

2020-02-14 Thread Michal Privoznik
On 2/14/20 9:47 AM, Michal Privoznik wrote: In a few places we report errno formatted as a negative integer. This is not as user friendly as it can be. Use strerror() and/or error_setg_errno() instead. Signed-off-by: Michal Privoznik --- hw/vfio/common.c| 2 +- util/vfio-helpers.c | 6

[Qemu-block] [PATCH] nvme: Set number of queues later in nvme_init()

2019-07-10 Thread Michal Privoznik
ckdev_init (file=0x0, bs_opts=0x55d953d00390, errp=0x7ffd8e19e908) at blockdev.c:602 Signed-off-by: Michal Privoznik --- block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/nvme.c b/block/nvme.c index 73ed5fa75f..9896b7f7c6 100644 --- a/block/nvme.c +++ b/bl

Re: [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting

2019-05-30 Thread Michal Privoznik
On 5/29/19 11:34 AM, Paolo Bonzini wrote: On 29/05/19 09:33, Michal Privoznik wrote: On 5/28/19 7:45 PM, Paolo Bonzini wrote: On 28/05/19 15:06, Jie Wang wrote: if pr-helper been killed and qemu send disconnect event to libvirt and libvirt started a new pr-helper process, the new pr-heleper

Re: [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting

2019-05-29 Thread Michal Privoznik
On 5/28/19 7:45 PM, Paolo Bonzini wrote: On 28/05/19 15:06, Jie Wang wrote: if pr-helper been killed and qemu send disconnect event to libvirt and libvirt started a new pr-helper process, the new pr-heleper been killed again when qemu is connectting to the new pr-helper, qemu will never send

Re: [Qemu-block] [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash

2019-03-15 Thread Michal Privoznik
On 3/14/19 8:01 PM, Markus Armbruster wrote: Michal Privoznik writes: On 3/8/19 2:14 PM, Markus Armbruster wrote: The previous commit added a way to configure firmware with -blockdev rather than -drive if=pflash. Document it as the preferred way. Signed-off-by: Markus Armbruster

Re: [Qemu-block] [Qemu-devel] [PATCH v3 12/12] docs/interop/firmware.json: Prefer -machine to if=pflash

2019-03-14 Thread Michal Privoznik
On 3/8/19 2:14 PM, Markus Armbruster wrote: The previous commit added a way to configure firmware with -blockdev rather than -drive if=pflash. Document it as the preferred way. Signed-off-by: Markus Armbruster --- docs/interop/firmware.json | 20 ++-- 1 file changed, 14

[Qemu-block] [PATCH] pr-helper: Rework socket path handling

2018-07-03 Thread Michal Privoznik
() it is the only default path the function handles. For instance, pidfile is allocated outside of this function. And yet again, at different places than 1) Signed-off-by: Michal Privoznik --- scsi/qemu-pr-helper.c | 36 ++-- 1 file changed, 10 insertions(+), 26 deletions

[Qemu-block] [PATCH] qemu-pr-helper: Actually allow users to specify pidfile

2018-03-23 Thread Michal Privoznik
Due to wrong specification of arguments to getopt_long() any attempt to set pidfile resulted in: 1) the default to be leaked 2) the @pidfile variable to be set to NULL (because optarg is NULL without this patch). Signed-off-by: Michal Privoznik <mpriv...@redhat.com> --- scsi/qemu-pr-he

Re: [Qemu-block] [Qemu-devel] QEMU not honouring bootorder

2017-12-14 Thread Michal Privoznik
On 12/13/2017 10:21 PM, Paolo Bonzini wrote: > On 11/12/2017 13:14, Michal Privoznik wrote: >>>> qemu-system-x86_64 \ >>>> -boot menu=on,strict=on \ >>>> -device lsi,id=scsi0,bus=pci.0 \ >>>> -drive >>>> file=/var/lib/

Re: [Qemu-block] [Qemu-devel] QEMU not honouring bootorder

2017-12-11 Thread Michal Privoznik
On 12/11/2017 12:41 PM, Fam Zheng wrote: > On Thu, 12/07 13:10, Michal Privoznik wrote: >> Dear list, >> >> I've encountered the following problem. I have two disks: >> >> /var/lib/libvirt/images/fedora.qcow2 (which contains OS) >> /dev/sde (iSCSI dummy

Re: [Qemu-block] QEMU not honouring bootorder

2017-12-11 Thread Michal Privoznik
On 12/07/2017 01:10 PM, Michal Privoznik wrote: > Dear list, > Ping. Is there anything I can help you with to have this sorted out? Michal

[Qemu-block] QEMU not honouring bootorder

2017-12-07 Thread Michal Privoznik
Dear list, I've encountered the following problem. I have two disks: /var/lib/libvirt/images/fedora.qcow2 (which contains OS) /dev/sde (iSCSI dummy disk just for testing) Now, when I configure QEMU to start with both of them, QEMU/Seabios tries to boot from /dev/sde which fails obviously.

Re: [Qemu-block] [PATCH] block: Add bdrv_runtime_opts to query-command-line-options

2016-10-06 Thread Michal Privoznik
uOptsLists that are > returned in query-command-line-options. For the future, libvirt is > advised to use QMP schema introspection for block device options. > > Reported-by: Michal Privoznik <mpriv...@redhat.com> > Signed-off-by: Kevin Wolf <kw...@redhat.com> Tes