Hi,
There are some problems with iotests 129 (perhaps more than these, but
these are the ones I know of):
1. It checks @busy to see whether a block job is still running; however,
block jobs tend to unset @busy all the time (when they yield).
[Fixed by patch 3]
2. It uses blockdev throttlin
13.01.2021 17:06, Max Reitz wrote:
Hi,
There are some problems with iotests 129 (perhaps more than these, but
these are the ones I know of):
1. It checks @busy to see whether a block job is still running; however,
block jobs tend to unset @busy all the time (when they yield).
[Fixed by
Am 13.01.2021 um 15:06 hat Max Reitz geschrieben:
> - pylint and mypy complain.
> (Running mypy with the options given in 297.)
> [Patch 4 removes one pylint complaint; patch 7 the rest.]
Should we add it to 297 then to make sure we won't regress?
At some point, I guess we'll want to cover al
13.01.2021 17:38, Kevin Wolf wrote:
Am 13.01.2021 um 15:06 hat Max Reitz geschrieben:
- pylint and mypy complain.
(Running mypy with the options given in 297.)
[Patch 4 removes one pylint complaint; patch 7 the rest.]
Should we add it to 297 then to make sure we won't regress?
At some p
On 13.01.21 15:38, Kevin Wolf wrote:
Am 13.01.2021 um 15:06 hat Max Reitz geschrieben:
- pylint and mypy complain.
(Running mypy with the options given in 297.)
[Patch 4 removes one pylint complaint; patch 7 the rest.]
Should we add it to 297 then to make sure we won't regress?
Sounds
On 13.01.21 15:31, Vladimir Sementsov-Ogievskiy wrote:
13.01.2021 17:06, Max Reitz wrote:
Hi,
There are some problems with iotests 129 (perhaps more than these, but
these are the ones I know of):
1. It checks @busy to see whether a block job is still running; however,
block jobs tend to un
13.01.2021 18:19, Max Reitz wrote:
On 13.01.21 15:31, Vladimir Sementsov-Ogievskiy wrote:
13.01.2021 17:06, Max Reitz wrote:
Hi,
There are some problems with iotests 129 (perhaps more than these, but
these are the ones I know of):
1. It checks @busy to see whether a block job is still running
Am 13.01.2021 um 16:26 hat Max Reitz geschrieben:
> On 13.01.21 15:38, Kevin Wolf wrote:
> > Am 13.01.2021 um 15:06 hat Max Reitz geschrieben:
> > > - pylint and mypy complain.
> > >(Running mypy with the options given in 297.)
> > >[Patch 4 removes one pylint complaint; patch 7 the rest.]