[PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Max Reitz
Hi, There are some problems with iotests 129 (perhaps more than these, but these are the ones I know of): 1. It checks @busy to see whether a block job is still running; however, block jobs tend to unset @busy all the time (when they yield). [Fixed by patch 3] 2. It uses blockdev throttlin

Re: [PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 17:06, Max Reitz wrote: Hi, There are some problems with iotests 129 (perhaps more than these, but these are the ones I know of): 1. It checks @busy to see whether a block job is still running; however, block jobs tend to unset @busy all the time (when they yield). [Fixed by

Re: [PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Kevin Wolf
Am 13.01.2021 um 15:06 hat Max Reitz geschrieben: > - pylint and mypy complain. > (Running mypy with the options given in 297.) > [Patch 4 removes one pylint complaint; patch 7 the rest.] Should we add it to 297 then to make sure we won't regress? At some point, I guess we'll want to cover al

Re: [PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 17:38, Kevin Wolf wrote: Am 13.01.2021 um 15:06 hat Max Reitz geschrieben: - pylint and mypy complain. (Running mypy with the options given in 297.) [Patch 4 removes one pylint complaint; patch 7 the rest.] Should we add it to 297 then to make sure we won't regress? At some p

Re: [PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Max Reitz
On 13.01.21 15:38, Kevin Wolf wrote: Am 13.01.2021 um 15:06 hat Max Reitz geschrieben: - pylint and mypy complain. (Running mypy with the options given in 297.) [Patch 4 removes one pylint complaint; patch 7 the rest.] Should we add it to 297 then to make sure we won't regress? Sounds

Re: [PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Max Reitz
On 13.01.21 15:31, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 17:06, Max Reitz wrote: Hi, There are some problems with iotests 129 (perhaps more than these, but these are the ones I know of): 1. It checks @busy to see whether a block job is still running; however,     block jobs tend to un

Re: [PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2021 18:19, Max Reitz wrote: On 13.01.21 15:31, Vladimir Sementsov-Ogievskiy wrote: 13.01.2021 17:06, Max Reitz wrote: Hi, There are some problems with iotests 129 (perhaps more than these, but these are the ones I know of): 1. It checks @busy to see whether a block job is still running

Re: [PATCH 0/7] iotests/129: Fix it

2021-01-13 Thread Kevin Wolf
Am 13.01.2021 um 16:26 hat Max Reitz geschrieben: > On 13.01.21 15:38, Kevin Wolf wrote: > > Am 13.01.2021 um 15:06 hat Max Reitz geschrieben: > > > - pylint and mypy complain. > > >(Running mypy with the options given in 297.) > > >[Patch 4 removes one pylint complaint; patch 7 the rest.]