Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-17 Thread Wainer dos Santos Moschetta
On 2/15/21 7:27 PM, John Snow wrote: On 2/15/21 1:50 PM, Wainer dos Santos Moschetta wrote: In qtest.QEMUQtestMachine.__init__(), the argument named 'test_dir' still make sense, right? - Wainer It might upset pylint/mypy to rename parameters in the initializer for a parent class. If we

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-15 Thread John Snow
On 2/11/21 6:35 PM, Philippe Mathieu-Daudé wrote: Not this patch fault, but I see we use /var/tmp since commit 66613974468 ("scripts: refactor the VM class in iotests for reuse"). Can we use an OS agnostic method to get temp storage directory instead? As a follow-up. Feel free to add

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-15 Thread John Snow
On 2/15/21 1:50 PM, Wainer dos Santos Moschetta wrote: In qtest.QEMUQtestMachine.__init__(), the argument named 'test_dir' still make sense, right? - Wainer It might upset pylint/mypy to rename parameters in the initializer for a parent class. If we rename it in the base class, we should

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-15 Thread John Snow
On 2/11/21 5:01 PM, Cleber Rosa wrote: Each instance of qemu.machine.QEMUMachine currently has a "test directory", which may not have any relation to a "test", and it's really a temporary directory. Users instantiating the QEMUMachine class will be able to set the location of the directory that

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-15 Thread Wainer dos Santos Moschetta
Hi, On 2/11/21 7:01 PM, Cleber Rosa wrote: Each instance of qemu.machine.QEMUMachine currently has a "test directory", which may not have any relation to a "test", and it's really a temporary directory. Users instantiating the QEMUMachine class will be able to set the location of the directory

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-11 Thread Cleber Rosa
On Fri, Feb 12, 2021 at 12:35:26AM +0100, Philippe Mathieu-Daudé wrote: > On 2/11/21 11:01 PM, Cleber Rosa wrote: > > Each instance of qemu.machine.QEMUMachine currently has a "test > > directory", which may not have any relation to a "test", and it's > > really a temporary directory. > > > >

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 11:01 PM, Cleber Rosa wrote: > Each instance of qemu.machine.QEMUMachine currently has a "test > directory", which may not have any relation to a "test", and it's > really a temporary directory. > > Users instantiating the QEMUMachine class will be able to set the > location of the