Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-12 Thread Eric Blake
On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote: > We are going to switch the 'null-co' default 'read-zeroes' value > from FALSE to TRUE in the next commit. First explicit the FALSE > value when it is not set. > > Suggested-by: Eric Blake > Signed-off-by: Philippe Mathieu-Daudé > --- > +++

Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-12 Thread Vladimir Sementsov-Ogievskiy
12.02.2021 01:40, Eric Blake wrote: On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote: We are going to switch the 'null-co' default 'read-zeroes' value from FALSE to TRUE in the next commit. First explicit the FALSE value when it is not set. Grammar suggestion, along with a suggestion for an

Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 11:40 PM, Eric Blake wrote: > On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote: >> We are going to switch the 'null-co' default 'read-zeroes' value >> from FALSE to TRUE in the next commit. First explicit the FALSE >> value when it is not set. > > Grammar suggestion, along with a

Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-11 Thread Eric Blake
On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote: > We are going to switch the 'null-co' default 'read-zeroes' value > from FALSE to TRUE in the next commit. First explicit the FALSE > value when it is not set. Grammar suggestion, along with a suggestion for an additional sentence to make the

Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-11 Thread Philippe Mathieu-Daudé
Hi Vladimir, On 2/11/21 5:29 PM, Vladimir Sementsov-Ogievskiy wrote: > 11.02.2021 17:26, Philippe Mathieu-Daudé wrote: >> We are going to switch the 'null-co' default 'read-zeroes' value >> from FALSE to TRUE in the next commit. First explicit the FALSE >> value when it is not set. >> >>

Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-11 Thread Vladimir Sementsov-Ogievskiy
11.02.2021 17:26, Philippe Mathieu-Daudé wrote: We are going to switch the 'null-co' default 'read-zeroes' value from FALSE to TRUE in the next commit. First explicit the FALSE value when it is not set. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- - Missing: 056 & 155. I

[PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-11 Thread Philippe Mathieu-Daudé
We are going to switch the 'null-co' default 'read-zeroes' value from FALSE to TRUE in the next commit. First explicit the FALSE value when it is not set. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- - Missing: 056 & 155. I couldn't figure out the proper syntax, any help