Re: [PATCH v5 2/5] qcow2: introduce compression type feature

2020-03-11 Thread Max Reitz
On 04.03.20 14:35, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature to qcow2 allowing the use different compression methods for > image clusters (de)compressing. > > It is implied that the compression type is set on the image creation and >

Re: [PATCH v5 2/5] qcow2: introduce compression type feature

2020-03-05 Thread Alberto Garcia
On Wed 04 Mar 2020 02:35:35 PM CET, Denis Plotnikov wrote: > +## > +# @Qcow2CompressionType: I realized that we have a bit of a mix in the way we write this type of identifiers between QCow2FooBar (capital C) and Qcow2FooBar ... what's the recommended one? > @@ -146,6 +146,12 @@ typedef struct QC

Re: [PATCH v5 2/5] qcow2: introduce compression type feature

2020-03-04 Thread Markus Armbruster
Denis Plotnikov writes: > The patch adds some preparation parts for incompatible compression type > feature to qcow2 allowing the use different compression methods for > image clusters (de)compressing. > > It is implied that the compression type is set on the image creation and > can be changed o

[PATCH v5 2/5] qcow2: introduce compression type feature

2020-03-04 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus c