Re: [Qemu-block] [PATCH 3/3] block/nbd: merge NBDClientSession struct back to BDRVNBDState

On 13.06.19 17:16, Eric Blake wrote: > On 6/11/19 5:27 AM, Vladimir Sementsov-Ogievskiy wrote: >> No reason to keep it separate, it differs from others block driver >> behavior and therefor confuses. Instead of generic > > s/therefor/therefore/ (both spellings are valid, but the former looks >

Re: [Qemu-block] [PATCH 3/3] block/nbd: merge NBDClientSession struct back to BDRVNBDState

13.06.2019 18:16, Eric Blake wrote: > On 6/11/19 5:27 AM, Vladimir Sementsov-Ogievskiy wrote: >> No reason to keep it separate, it differs from others block driver >> behavior and therefor confuses. Instead of generic > > s/therefor/therefore/ (both spellings are valid, but the former looks >

Re: [Qemu-block] [PATCH 3/3] block/nbd: merge NBDClientSession struct back to BDRVNBDState

On 6/11/19 5:27 AM, Vladimir Sementsov-Ogievskiy wrote: > No reason to keep it separate, it differs from others block driver > behavior and therefor confuses. Instead of generic s/therefor/therefore/ (both spellings are valid, but the former looks archaic) > 'state = (State*)bs->opaque' we

[Qemu-block] [PATCH 3/3] block/nbd: merge NBDClientSession struct back to BDRVNBDState

No reason to keep it separate, it differs from others block driver behavior and therefor confuses. Instead of generic 'state = (State*)bs->opaque' we have to use special helper. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c | 197