Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-04 Thread Dan Zhang
On Tue, Aug 2, 2022 at 7:25 AM Cédric Le Goater wrote: > > On 7/31/22 00:06, Peter Delevoryas wrote: > > On Sat, Jul 30, 2022 at 11:18:33PM +0200, Cédric Le Goater wrote: > >> On 7/29/22 19:30, Peter Delevoryas wrote: > >>> On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > H

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-02 Thread Iris Chen
Thanks everyone for the insightful feedback! This is really helpful for me. I am taking a look at all the comments now and will investigate into it. Best, Iris

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-02 Thread Cédric Le Goater
On 7/31/22 00:06, Peter Delevoryas wrote: On Sat, Jul 30, 2022 at 11:18:33PM +0200, Cédric Le Goater wrote: On 7/29/22 19:30, Peter Delevoryas wrote: On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: Hello Iris, On 7/29/22 01:23, Iris Chen wrote: Hey everyone, I have been wo

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-01 Thread Peter Delevoryas
On Mon, Aug 01, 2022 at 11:49:09AM +0930, Andrew Jeffery wrote: > > > On Sun, 31 Jul 2022, at 06:48, Cédric Le Goater wrote: > > On 7/29/22 19:30, Peter Delevoryas wrote: > >> Certainly we'd like to use IRQ's instead, but she ran into correctness > >> problems. Maybe we can investigate that furth

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-31 Thread Andrew Jeffery
On Sun, 31 Jul 2022, at 06:48, Cédric Le Goater wrote: > On 7/29/22 19:30, Peter Delevoryas wrote: >> Certainly we'd like to use IRQ's instead, but she ran into correctness >> problems. Maybe we can investigate that further and fix it. Yes, let's not work around problems that we have the abilit

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-30 Thread Peter Delevoryas
On Sat, Jul 30, 2022 at 11:18:33PM +0200, Cédric Le Goater wrote: > On 7/29/22 19:30, Peter Delevoryas wrote: > > On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > > > Hello Iris, > > > > > > On 7/29/22 01:23, Iris Chen wrote: > > > > Hey everyone, > > > > > > > > I have been wo

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-30 Thread Cédric Le Goater
On 7/29/22 19:30, Peter Delevoryas wrote: On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: Hello Iris, On 7/29/22 01:23, Iris Chen wrote: Hey everyone, I have been working on a project to add support for SPI-based TPMs in QEMU. Currently, most of our vboot platforms using a S

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-29 Thread Peter Delevoryas
On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > Hello Iris, > > On 7/29/22 01:23, Iris Chen wrote: > > Hey everyone, > > > > I have been working on a project to add support for SPI-based TPMs in QEMU. > > Currently, most of our vboot platforms using a SPI-based TPM use the Lin

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-29 Thread Cédric Le Goater
On 7/29/22 16:38, Patrick Williams wrote: On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: Hello Iris, On 7/29/22 01:23, Iris Chen wrote: Currently, most of our vboot platforms using a SPI-based TPM use the Linux SPI-GPIO driver to "bit-bang" the SPI protocol. This is because

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-29 Thread Patrick Williams
On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > Hello Iris, > > On 7/29/22 01:23, Iris Chen wrote: > > MOSI pin in spi_gpio: the mosi pin is not included and we poll the realtime > > value > > of the gpio for input bits to prevent bugs with caching the mosi value. It > > was

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-29 Thread Patrick Williams
On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > Hello Iris, > > On 7/29/22 01:23, Iris Chen wrote: > > Currently, most of our vboot platforms using a SPI-based TPM use the Linux > > SPI-GPIO driver to "bit-bang" the SPI protocol. This is because the Aspeed > > SPI controller (m

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-29 Thread Cédric Le Goater
Hello Iris, On 7/29/22 01:23, Iris Chen wrote: Hey everyone, I have been working on a project to add support for SPI-based TPMs in QEMU. Currently, most of our vboot platforms using a SPI-based TPM use the Linux SPI-GPIO driver to "bit-bang" the SPI protocol. This is because the Aspeed SPI cont

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-28 Thread Peter Delevoryas
On Thu, Jul 28, 2022 at 04:23:19PM -0700, Iris Chen wrote: > Hey everyone, > > I have been working on a project to add support for SPI-based TPMs in QEMU. > Currently, most of our vboot platforms using a SPI-based TPM use the Linux > SPI-GPIO driver to "bit-bang" the SPI protocol. This is because

[RFC 0/3] Add Generic SPI GPIO model

2022-07-28 Thread Iris Chen
Hey everyone, I have been working on a project to add support for SPI-based TPMs in QEMU. Currently, most of our vboot platforms using a SPI-based TPM use the Linux SPI-GPIO driver to "bit-bang" the SPI protocol. This is because the Aspeed SPI controller (modeled in QEMU under hw/ssi/aspeed_smc.