Re: [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State

2020-02-21 Thread Alberto Garcia
On Thu 20 Feb 2020 05:48:25 PM CET, Eric Blake wrote: >>> The qcow2 spec changes earlier in the series made it sound like your >>> choices are exactly 1 or 32, >> +#define QCOW_MAX_SUBCLUSTERS_PER_CLUSTER 32 + >>> >>> ...but this name sounds like other values (2, 4, 8, 16) might be >>>

Re: [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State

2020-02-20 Thread Eric Blake
On 2/20/20 10:34 AM, Alberto Garcia wrote: On Thu 20 Feb 2020 04:28:07 PM CET, Eric Blake wrote: Images without subclusters are treated as if they had exactly one, with subcluster_size = cluster_size. The qcow2 spec changes earlier in the series made it sound like your choices are exactly 1

Re: [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State

2020-02-20 Thread Alberto Garcia
On Thu 20 Feb 2020 04:28:07 PM CET, Eric Blake wrote: >> Images without subclusters are treated as if they had exactly one, >> with subcluster_size = cluster_size. > > The qcow2 spec changes earlier in the series made it sound like your > choices are exactly 1 or 32, >> +#define

Re: [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State

2020-02-20 Thread Max Reitz
On 22.12.19 12:36, Alberto Garcia wrote: > This patch adds the following new fields to BDRVQcow2State: > > - subclusters_per_cluster: Number of subclusters in a cluster > - subcluster_size: The size of each subcluster, in bytes > - subcluster_bits: No. of bits so 1 << subcluster_bits =

Re: [RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State

2020-02-20 Thread Eric Blake
On 12/22/19 5:36 AM, Alberto Garcia wrote: This patch adds the following new fields to BDRVQcow2State: - subclusters_per_cluster: Number of subclusters in a cluster - subcluster_size: The size of each subcluster, in bytes - subcluster_bits: No. of bits so 1 << subcluster_bits = subcluster_size

[RFC PATCH v3 07/27] qcow2: Add subcluster-related fields to BDRVQcow2State

2019-12-22 Thread Alberto Garcia
This patch adds the following new fields to BDRVQcow2State: - subclusters_per_cluster: Number of subclusters in a cluster - subcluster_size: The size of each subcluster, in bytes - subcluster_bits: No. of bits so 1 << subcluster_bits = subcluster_size Images without subclusters are treated as if