[Qemu-block] [PATCH v3 16/18] xen: automatically create XenBlockDevice-s

2018-12-11 Thread Paul Durrant
he XenBlockDevice is destroyed. Correspondingly the legacy backend scan for 'qdisk' is removed. After this patch is applied the legacy 'xen_disk' code is redundant. It will be removed by a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc

[Qemu-block] [PATCH v3 18/18] xen: remove the legacy 'xen_disk' backend

2018-12-11 Thread Paul Durrant
This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c

[Qemu-block] [PATCH v3 10/18] xen: add header and build dataplane/xen-block.c

2018-12-11 Thread Paul Durrant
modified by subsequent patches. A typedef for XenBlockDataPlane has been added to the header (based on the old struct XenBlkDev name for the moment) so that the old names don't need to leak out of the dataplane code. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard -

Re: [Qemu-block] [Xen-devel] [PATCH v3 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2018-12-11 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 11 December 2018 15:30 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Stefano > Stabellini ; Stefan H

Re: [Qemu-block] [PATCH v3 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2018-12-11 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 11 December 2018 15:17 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Max Reitz > ; Stefano Stabellini >

Re: [Qemu-block] [PATCH v3 07/18] xen: add event channel interface for XenDevice-s

2018-12-11 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 11 December 2018 15:25 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v3 07/18] xen: add event

[Qemu-block] [PATCH v4 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2018-12-11 Thread Paul Durrant
m the same sites as the legacy xen_be_init() function. Subsequent patches will flesh-out the functionality of these objects. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Ric

[Qemu-block] [PATCH v4 07/18] xen: add event channel interface for XenDevice-s

2018-12-11 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to bind, unbind and send notifications to event channnels. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc

[Qemu-block] [PATCH v4 00/18] Xen PV backend 'qdevification'

2018-12-11 Thread Paul Durrant
rg/archive/html/qemu-devel/2018-11/msg00259.html [2] http://xenbits.xen.org/gitweb/?p=people/pauldu/qemu.git;a=shortlog;h=refs/heads/qom29 Paul Durrant (18): xen: re-name XenDevice to XenLegacyDevice... xen: introduce new 'XenBus' and 'XenDevice' object hierarchy xen: introduc

[Qemu-block] [PATCH v4 01/18] xen: re-name XenDevice to XenLegacyDevice...

2018-12-11 Thread Paul Durrant
re-name parts of existing code to avoid name clashes. The re-named 'legacy' infrastructure will be removed once all backends have been ported to the new framework. This patch is purely cosmetic. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v4 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-12-11 Thread Paul Durrant
k sets the backend 'online' key to 0. NOTE: This patch only adds the framework. A subsequent patch will add a creator function for xen-block devices. Signed-off-by: Paul Durrant --- Cc: Anthony Perard Cc: Stefano Stabellini Cc: Anthony Perard v3: - Use a xenstore transaction in

[Qemu-block] [PATCH v4 06/18] xen: add grant table interface for XenDevice-s

2018-12-11 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v4 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c

2018-12-11 Thread Paul Durrant
This is a purely cosmetic patch that purges remaining use of 'blk' and 'ioreq' in local function names, and then makes sure all functions are prefixed with 'xen_block_'. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano S

[Qemu-block] [PATCH v4 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2018-12-11 Thread Paul Durrant
(). NOTE: The code is still not yet built. Further transformations will be required to make it correctly interface to the new XenBus/XenDevice framework. They will be delivered in a subsequent patch. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Stefan

[Qemu-block] [PATCH v4 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2018-12-11 Thread Paul Durrant
meter formulates the appropriate VBD number for use in the PV protocol. [1] https://xenbits.xen.org/docs/unstable/man/xen-vbd-interface.7.html Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v3: - Fix vdev parsing again, a

[Qemu-block] [PATCH v4 05/18] xen: add xenstore watcher infrastructure

2018-12-11 Thread Paul Durrant
will supply a full implementation for these functions. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v3: - Remove unnecessary instances of local_err v2: - Don't crash when xen_block_disconnect() fails - Check xs_unwat

[Qemu-block] [PATCH v4 04/18] xen: create xenstore areas for XenDevice-s

2018-12-11 Thread Paul Durrant
x27; the xenstore areas. NOTE: An exit handler is also added to make sure the xenstore areas are cleaned up if QEMU terminates without devices being unrealized. [1] The 'scanf' functions are actually not yet needed, but they will be needed by code delivered in subsequent patche

[Qemu-block] [PATCH v4 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c

2018-12-11 Thread Paul Durrant
harder. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: Max Reitz --- MAINTAINERS|1 + hw/block/dataplane/xen-block.c | 1019 2 files changed, 1020 insertions

[Qemu-block] [PATCH v4 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-11 Thread Paul Durrant
nd xenstore area are mapped/bound and used to set up the dataplane. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf Cc: Max Reitz v3: - Add missing return statement to xen_block_realize() - Set device name to 'vbd' now the backend is funct

[Qemu-block] [PATCH v4 18/18] xen: remove the legacy 'xen_disk' backend

2018-12-11 Thread Paul Durrant
This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c

[Qemu-block] [PATCH v4 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c

2018-12-11 Thread Paul Durrant
27;XenBlockRequest' type and 'ioreq' field/variable names with 'request', and then does necessary fix-up to adhere to coding style. Function names are not modified by this patch. They will be dealt with in a subsequent patch. No functional change. Signed-off-by: Paul Du

[Qemu-block] [PATCH v4 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block

2018-12-11 Thread Paul Durrant
This is a purely cosmetic patch that substitutes the old 'struct XenBlkDev' name with 'XenBlockDataPlane' and 'blkdev' field/variable names with 'dataplane', and then does necessary fix-up to adhere to coding style. No functional change. Signed-off-by

[Qemu-block] [PATCH v4 16/18] xen: automatically create XenBlockDevice-s

2018-12-11 Thread Paul Durrant
he XenBlockDevice is destroyed. Correspondingly the legacy backend scan for 'qdisk' is removed. After this patch is applied the legacy 'xen_disk' code is redundant. It will be removed by a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc

[Qemu-block] [PATCH v4 10/18] xen: add header and build dataplane/xen-block.c

2018-12-11 Thread Paul Durrant
modified by subsequent patches. A typedef for XenBlockDataPlane has been added to the header (based on the old struct XenBlkDev name for the moment) so that the old names don't need to leak out of the dataplane code. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard -

[Qemu-block] [PATCH v4 17/18] MAINTAINERS: add myself as a Xen maintainer

2018-12-11 Thread Paul Durrant
therefore seems reasonable that I become a maintainer of the Xen code. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Acked-by: Stefano Stabellini --- Cc: Paolo Bonzini v2: - Fix typo --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-block] [Xen-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2)

2018-12-12 Thread Paul Durrant
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: 12 December 2018 09:00 > To: Kevin Wolf > Cc: Tim Smith ; Stefano Stabellini > ; qemu-block@nongnu.org; arm...@redhat.com; qemu- > de...@nongnu.org; Max Reitz ; Paul Durrant > ; A

[Qemu-block] [PATCH v3 2/3] xen-block: improve response latency

2018-12-12 Thread Paul Durrant
-based and commit comment adjusted. Signed-off-by: Paul Durrant --- Cc: Stefan Hajnoczi Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf Cc: Max Reitz --- hw/block/dataplane/xen-block.c | 56 ++ 1 file changed, 18 insertions(+), 38 deletions

[Qemu-block] [PATCH v3 0/3] Performance improvements for xen_disk^Wxen-block

2018-12-12 Thread Paul Durrant
This series is a re-base of Tim's v2 series [1] on top of my series [2]. [1] https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg00243.html [2] https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02271.html Tim Smith (3): xen-block: improve batching behaviour xen-block: improve resp

[Qemu-block] [PATCH v3 1/3] xen-block: improve batching behaviour

2018-12-12 Thread Paul Durrant
()/ blk_io_unplug() in an amount proportional to the number which were already in flight at the time we started reading the ring. Signed-off-by: Tim Smith Re-based and commit comment adjusted. Signed-off-by: Paul Durrant --- Cc: Stefan Hajnoczi Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf

[Qemu-block] [PATCH v3 3/3] xen-block: avoid repeated memory allocation

2018-12-12 Thread Paul Durrant
-off-by: Tim Smith Re-based and commit comment adjusted. Signed-off-by: Paul Durrant --- Cc: Stefan Hajnoczi Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf Cc: Max Reitz --- hw/block/dataplane/xen-block.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff

Re: [Qemu-block] [PATCH v3 0/3] Performance improvements for xen_disk^Wxen-block

2018-12-12 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 12 December 2018 11:14 > To: qemu-...@nongnu.org; qemu-block@nongnu.org; xen- Fat-fingered the email address, I'll send again. Paul > de...@lists.xenproject.org > Cc: Paul D

[Qemu-block] [PATCH v3 3/3] xen-block: avoid repeated memory allocation

2018-12-12 Thread Paul Durrant
-off-by: Tim Smith Re-based and commit comment adjusted. Signed-off-by: Paul Durrant --- Cc: Stefan Hajnoczi Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf Cc: Max Reitz --- hw/block/dataplane/xen-block.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff

[Qemu-block] [PATCH v3 1/3] xen-block: improve batching behaviour

2018-12-12 Thread Paul Durrant
()/ blk_io_unplug() in an amount proportional to the number which were already in flight at the time we started reading the ring. Signed-off-by: Tim Smith Re-based and commit comment adjusted. Signed-off-by: Paul Durrant --- Cc: Stefan Hajnoczi Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf

[Qemu-block] [PATCH v3 0/3] Performance improvements for xen_disk^Wxen-block

2018-12-12 Thread Paul Durrant
This series is a re-base of Tim's v2 series [1] on top of my series [2]. [1] https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg00243.html [2] https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02271.html Tim Smith (3): xen-block: improve batching behaviour xen-block: improve resp

[Qemu-block] [PATCH v3 2/3] xen-block: improve response latency

2018-12-12 Thread Paul Durrant
-based and commit comment adjusted. Signed-off-by: Paul Durrant --- Cc: Stefan Hajnoczi Cc: Stefano Stabellini Cc: Anthony Perard Cc: Kevin Wolf Cc: Max Reitz --- hw/block/dataplane/xen-block.c | 56 ++ 1 file changed, 18 insertions(+), 38 deletions

Re: [Qemu-block] [Xen-devel] [PATCH v1] xen_disk: fix memory leak

2018-12-13 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Anthony PERARD > Sent: 13 December 2018 11:34 > To: Olaf Hering > Cc: Kevin Wolf ; Stefano Stabellini > ; open list:Block layer core bl...@nongnu.org>; qemu-de...@nongnu.org; Max Reitz ;

Re: [Qemu-block] [PATCH v4 16/18] xen: automatically create XenBlockDevice-s

2018-12-13 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 13 December 2018 11:52 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org; Max Reitz ; Stefano > Stabellini > Subject: Re: [PATCH v4 1

Re: [Qemu-block] [PATCH v4 16/18] xen: automatically create XenBlockDevice-s

2018-12-14 Thread Paul Durrant
> -Original Message- [snip] > > + > > +blockdev->auto_iothread = iothread; > > + > > +object_property_set_bool(OBJECT(dev), true, "realized", > &local_err); > > +if (local_err) { > > +error_propagate_prepend(errp, local_err, > > +"initiali

Re: [Qemu-block] [PATCH v4 16/18] xen: automatically create XenBlockDevice-s

2018-12-14 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 14 December 2018 14:50 > To: 'Kevin Wolf' > Cc: xen-de...@lists.xenproject.org; Stefano Stabellini > ; qemu-de...@nongnu.org; qem

[Qemu-block] [PATCH v5 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2018-12-17 Thread Paul Durrant
m the same sites as the legacy xen_be_init() function. Subsequent patches will flesh-out the functionality of these objects. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Ric

[Qemu-block] [PATCH v5 07/18] xen: add event channel interface for XenDevice-s

2018-12-17 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to bind, unbind and send notifications to event channnels. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc

[Qemu-block] [PATCH v5 00/18] Xen PV backend 'qdevification'

2018-12-17 Thread Paul Durrant
rg/archive/html/qemu-devel/2018-11/msg00259.html [2] http://xenbits.xen.org/gitweb/?p=people/pauldu/qemu.git;a=shortlog;h=refs/heads/qom30 Paul Durrant (18): xen: re-name XenDevice to XenLegacyDevice... xen: introduce new 'XenBus' and 'XenDevice' object hierarchy xen: introduc

[Qemu-block] [PATCH v5 01/18] xen: re-name XenDevice to XenLegacyDevice...

2018-12-17 Thread Paul Durrant
re-name parts of existing code to avoid name clashes. The re-named 'legacy' infrastructure will be removed once all backends have been ported to the new framework. This patch is purely cosmetic. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v5 06/18] xen: add grant table interface for XenDevice-s

2018-12-17 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v5 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2018-12-17 Thread Paul Durrant
meter formulates the appropriate VBD number for use in the PV protocol. [1] https://xenbits.xen.org/docs/unstable/man/xen-vbd-interface.7.html Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v5: - Introduce properties sub-structure

[Qemu-block] [PATCH v5 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
(). NOTE: The code is still not yet built. Further transformations will be required to make it correctly interface to the new XenBus/XenDevice framework. They will be delivered in a subsequent patch. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Stefan

[Qemu-block] [PATCH v5 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
harder. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: Max Reitz --- MAINTAINERS|1 + hw/block/dataplane/xen-block.c | 1019 2 files changed, 1020 insertions

[Qemu-block] [PATCH v5 04/18] xen: create xenstore areas for XenDevice-s

2018-12-17 Thread Paul Durrant
x27; the xenstore areas. NOTE: An exit handler is also added to make sure the xenstore areas are cleaned up if QEMU terminates without devices being unrealized. [1] The 'scanf' functions are actually not yet needed, but they will be needed by code delivered in subsequent patche

[Qemu-block] [PATCH v5 05/18] xen: add xenstore watcher infrastructure

2018-12-17 Thread Paul Durrant
will supply a full implementation for these functions. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v5: - Re-base v3: - Remove unnecessary instances of local_err v2: - Don't crash when xen_block_disconnect() fails

[Qemu-block] [PATCH v5 16/18] xen: automatically create XenBlockDevice-s

2018-12-17 Thread Paul Durrant
d is automatically created for the new XenBlockDevice. This, like the driver layers, will be destroyed after the XenBlockDevice is unrealized. The legacy backend scan for 'qdisk' is removed by this patch, which makes the 'xen_disk' code is redundant. The code will be removed b

[Qemu-block] [PATCH v5 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
27;XenBlockRequest' type and 'ioreq' field/variable names with 'request', and then does necessary fix-up to adhere to coding style. Function names are not modified by this patch. They will be dealt with in a subsequent patch. No functional change. Signed-off-by: Paul Du

[Qemu-block] [PATCH v5 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-12-17 Thread Paul Durrant
the XenBus implementation to handle enumeration of new backends and also destruction of XenDevice-s when the toolstack sets the backend 'online' key to 0. NOTE: This patch only adds the framework. A subsequent patch will add a creator function for xen-block devices. Signed-off-by:

[Qemu-block] [PATCH v5 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block

2018-12-17 Thread Paul Durrant
This is a purely cosmetic patch that substitutes the old 'struct XenBlkDev' name with 'XenBlockDataPlane' and 'blkdev' field/variable names with 'dataplane', and then does necessary fix-up to adhere to coding style. No functional change. Signed-off-by

[Qemu-block] [PATCH v5 17/18] MAINTAINERS: add myself as a Xen maintainer

2018-12-17 Thread Paul Durrant
therefore seems reasonable that I become a maintainer of the Xen code. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Acked-by: Stefano Stabellini --- Cc: Paolo Bonzini v2: - Fix typo --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-block] [PATCH v5 10/18] xen: add header and build dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
modified by subsequent patches. A typedef for XenBlockDataPlane has been added to the header (based on the old struct XenBlkDev name for the moment) so that the old names don't need to leak out of the dataplane code. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard -

[Qemu-block] [PATCH v5 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
This is a purely cosmetic patch that purges remaining use of 'blk' and 'ioreq' in local function names, and then makes sure all functions are prefixed with 'xen_block_'. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano S

[Qemu-block] [PATCH v5 18/18] xen: remove the legacy 'xen_disk' backend

2018-12-17 Thread Paul Durrant
This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c

[Qemu-block] [PATCH v5 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-17 Thread Paul Durrant
nd xenstore area are mapped/bound and used to set up the dataplane. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Kevin Wolf Cc: Max Reitz v5: - Re-base v3: - Add missing return statement to xen_block_realize() - Set device name to 'vbd'

Re: [Qemu-block] [Xen-devel] [PATCH v5 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 17 December 2018 12:28 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Stefano > Stabellini ; Stefan H

[Qemu-block] [PATCH v6 04/18] xen: create xenstore areas for XenDevice-s

2018-12-17 Thread Paul Durrant
x27; the xenstore areas. NOTE: An exit handler is also added to make sure the xenstore areas are cleaned up if QEMU terminates without devices being unrealized. [1] The 'scanf' functions are actually not yet needed, but they will be needed by code delivered in subsequent patche

[Qemu-block] [PATCH v6 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2018-12-17 Thread Paul Durrant
m the same sites as the legacy xen_be_init() function. Subsequent patches will flesh-out the functionality of these objects. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Ric

[Qemu-block] [PATCH v6 07/18] xen: add event channel interface for XenDevice-s

2018-12-17 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to bind, unbind and send notifications to event channnels. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc

[Qemu-block] [PATCH v6 00/18] Xen PV backend 'qdevification'

2018-12-17 Thread Paul Durrant
rg/archive/html/qemu-devel/2018-11/msg00259.html [2] http://xenbits.xen.org/gitweb/?p=people/pauldu/qemu.git;a=shortlog;h=refs/heads/qom31 Paul Durrant (18): xen: re-name XenDevice to XenLegacyDevice... xen: introduce new 'XenBus' and 'XenDevice' object hierarchy xen: introduc

[Qemu-block] [PATCH v6 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
harder. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: Max Reitz --- MAINTAINERS|1 + hw/block/dataplane/xen-block.c | 1019 2 files changed, 1020 insertions(+) create

[Qemu-block] [PATCH v6 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2018-12-17 Thread Paul Durrant
meter formulates the appropriate VBD number for use in the PV protocol. [1] https://xenbits.xen.org/docs/unstable/man/xen-vbd-interface.7.html Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v5: - Introduce properties sub-structure

[Qemu-block] [PATCH v6 06/18] xen: add grant table interface for XenDevice-s

2018-12-17 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v6 05/18] xen: add xenstore watcher infrastructure

2018-12-17 Thread Paul Durrant
will supply a full implementation for these functions. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v5: - Re-base v3: - Remove unnecessary instances of local_err v2: - Don't crash when xen_block_disconnect() fails

[Qemu-block] [PATCH v6 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
(). NOTE: The code is still not yet built. Further transformations will be required to make it correctly interface to the new XenBus/XenDevice framework. They will be delivered in a subsequent patch. Signed-off-by: Paul Durrant --- Cc: Anthony Perard Cc: Stefano Stabellini Cc: Stefan

[Qemu-block] [PATCH v6 01/18] xen: re-name XenDevice to XenLegacyDevice...

2018-12-17 Thread Paul Durrant
re-name parts of existing code to avoid name clashes. The re-named 'legacy' infrastructure will be removed once all backends have been ported to the new framework. This patch is purely cosmetic. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v6 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
27;XenBlockRequest' type and 'ioreq' field/variable names with 'request', and then does necessary fix-up to adhere to coding style. Function names are not modified by this patch. They will be dealt with in a subsequent patch. No functional change. Signed-off-by: Paul Du

[Qemu-block] [PATCH v6 18/18] xen: remove the legacy 'xen_disk' backend

2018-12-17 Thread Paul Durrant
This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c| 1011 ---

[Qemu-block] [PATCH v6 17/18] MAINTAINERS: add myself as a Xen maintainer

2018-12-17 Thread Paul Durrant
therefore seems reasonable that I become a maintainer of the Xen code. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Acked-by: Stefano Stabellini --- Cc: Paolo Bonzini v2: - Fix typo --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-block] [PATCH v6 16/18] xen: automatically create XenBlockDevice-s

2018-12-17 Thread Paul Durrant
d is automatically created for the new XenBlockDevice. This, like the driver layers, will be destroyed after the XenBlockDevice is unrealized. The legacy backend scan for 'qdisk' is removed by this patch, which makes the 'xen_disk' code is redundant. The code will be removed b

[Qemu-block] [PATCH v6 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-17 Thread Paul Durrant
nd xenstore area are mapped/bound and used to set up the dataplane. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Kevin Wolf Cc: Max Reitz v5: - Re-base v3: - Add missing return statement to xen_block_realize() - Set device name to 'vbd'

[Qemu-block] [PATCH v6 10/18] xen: add header and build dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
modified by subsequent patches. A typedef for XenBlockDataPlane has been added to the header (based on the old struct XenBlkDev name for the moment) so that the old names don't need to leak out of the dataplane code. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard -

[Qemu-block] [PATCH v6 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c

2018-12-17 Thread Paul Durrant
This is a purely cosmetic patch that purges remaining use of 'blk' and 'ioreq' in local function names, and then makes sure all functions are prefixed with 'xen_block_'. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano S

[Qemu-block] [PATCH v6 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block

2018-12-17 Thread Paul Durrant
This is a purely cosmetic patch that substitutes the old 'struct XenBlkDev' name with 'XenBlockDataPlane' and 'blkdev' field/variable names with 'dataplane', and then does necessary fix-up to adhere to coding style. No functional change. Signed-off-by

[Qemu-block] [PATCH v6 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-12-17 Thread Paul Durrant
the XenBus implementation to handle enumeration of new backends and also destruction of XenDevice-s when the toolstack sets the backend 'online' key to 0. NOTE: This patch only adds the framework. A subsequent patch will add a creator function for xen-block devices. Signed-off-by:

Re: [Qemu-block] [PATCH v6 16/18] xen: automatically create XenBlockDevice-s

2018-12-19 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 19 December 2018 12:39 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Max Reitz > ; Stefano Stabellini >

Re: [Qemu-block] [PATCH v6 16/18] xen: automatically create XenBlockDevice-s

2018-12-19 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 19 December 2018 14:01 > To: Paul Durrant > Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Max Reitz > ; Stefano Stabellini >

[Qemu-block] [PATCH v7 05/18] xen: add xenstore watcher infrastructure

2018-12-20 Thread Paul Durrant
will supply a full implementation for these functions. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v5: - Re-base v3: - Remove unnecessary instances of local_err v2: - Don't crash when xen_block_disconnect() fails

[Qemu-block] [PATCH v7 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2018-12-20 Thread Paul Durrant
meter formulates the appropriate VBD number for use in the PV protocol. [1] https://xenbits.xen.org/docs/unstable/man/xen-vbd-interface.7.html Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini v5: - Introduce properties sub-structure

[Qemu-block] [PATCH v7 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2018-12-20 Thread Paul Durrant
m the same sites as the legacy xen_be_init() function. Subsequent patches will flesh-out the functionality of these objects. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Ric

[Qemu-block] [PATCH v7 04/18] xen: create xenstore areas for XenDevice-s

2018-12-20 Thread Paul Durrant
x27; the xenstore areas. NOTE: An exit handler is also added to make sure the xenstore areas are cleaned up if QEMU terminates without devices being unrealized. [1] The 'scanf' functions are actually not yet needed, but they will be needed by code delivered in subsequent patche

[Qemu-block] [PATCH v7 06/18] xen: add grant table interface for XenDevice-s

2018-12-20 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v7 01/18] xen: re-name XenDevice to XenLegacyDevice...

2018-12-20 Thread Paul Durrant
re-name parts of existing code to avoid name clashes. The re-named 'legacy' infrastructure will be removed once all backends have been ported to the new framework. This patch is purely cosmetic. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano

[Qemu-block] [PATCH v7 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2018-12-20 Thread Paul Durrant
(). NOTE: The code is still not yet built. Further transformations will be required to make it correctly interface to the new XenBus/XenDevice framework. They will be delivered in a subsequent patch. Signed-off-by: Paul Durrant --- Cc: Anthony Perard Cc: Stefano Stabellini Cc: Stefan

[Qemu-block] [PATCH v7 07/18] xen: add event channel interface for XenDevice-s

2018-12-20 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to bind, unbind and send notifications to event channnels. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc

[Qemu-block] [PATCH v7 00/18] Xen PV backend 'qdevification'

2018-12-20 Thread Paul Durrant
rg/archive/html/qemu-devel/2018-11/msg00259.html [2] http://xenbits.xen.org/gitweb/?p=people/pauldu/qemu.git;a=shortlog;h=refs/heads/qom32 Paul Durrant (18): xen: re-name XenDevice to XenLegacyDevice... xen: introduce new 'XenBus' and 'XenDevice' object hierarchy xen: introduc

[Qemu-block] [PATCH v7 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c

2018-12-20 Thread Paul Durrant
harder. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: Max Reitz --- MAINTAINERS|1 + hw/block/dataplane/xen-block.c | 1019 2 files changed, 1020 insertions(+) create

[Qemu-block] [PATCH v7 17/18] MAINTAINERS: add myself as a Xen maintainer

2018-12-20 Thread Paul Durrant
therefore seems reasonable that I become a maintainer of the Xen code. Signed-off-by: Paul Durrant Acked-by: Anthony Perard Acked-by: Stefano Stabellini --- Cc: Paolo Bonzini v2: - Fix typo --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[Qemu-block] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2018-12-20 Thread Paul Durrant
d is automatically created for the new XenBlockDevice. This, like the driver layers, will be destroyed after the XenBlockDevice is unrealized. The legacy backend scan for 'qdisk' is removed by this patch, which makes the 'xen_disk' code is redundant. The code will be removed b

[Qemu-block] [PATCH v7 14/18] xen: add implementations of xen-block connect and disconnect functions...

2018-12-20 Thread Paul Durrant
nd xenstore area are mapped/bound and used to set up the dataplane. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabellini Cc: Kevin Wolf Cc: Max Reitz v5: - Re-base v3: - Add missing return statement to xen_block_realize() - Set device name to 'vbd'

[Qemu-block] [PATCH v7 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c

2018-12-20 Thread Paul Durrant
This is a purely cosmetic patch that purges remaining use of 'blk' and 'ioreq' in local function names, and then makes sure all functions are prefixed with 'xen_block_'. No functional change. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Stefano S

[Qemu-block] [PATCH v7 10/18] xen: add header and build dataplane/xen-block.c

2018-12-20 Thread Paul Durrant
modified by subsequent patches. A typedef for XenBlockDataPlane has been added to the header (based on the old struct XenBlkDev name for the moment) so that the old names don't need to leak out of the dataplane code. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard -

[Qemu-block] [PATCH v7 18/18] xen: remove the legacy 'xen_disk' backend

2018-12-20 Thread Paul Durrant
This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant Acked-by: Anthony Perard --- Cc: Kevin Wolf Cc: Max Reitz Cc: Stefano Stabellini --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c| 1011 ---

[Qemu-block] [PATCH v7 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c

2018-12-20 Thread Paul Durrant
27;XenBlockRequest' type and 'ioreq' field/variable names with 'request', and then does necessary fix-up to adhere to coding style. Function names are not modified by this patch. They will be dealt with in a subsequent patch. No functional change. Signed-off-by: Paul Du

[Qemu-block] [PATCH v7 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-12-20 Thread Paul Durrant
the XenBus implementation to handle enumeration of new backends and also destruction of XenDevice-s when the toolstack sets the backend 'online' key to 0. NOTE: This patch only adds the framework. A subsequent patch will add a creator function for xen-block devices. Signed-off-by: Paul

[Qemu-block] [PATCH v7 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block

2018-12-20 Thread Paul Durrant
This is a purely cosmetic patch that substitutes the old 'struct XenBlkDev' name with 'XenBlockDataPlane' and 'blkdev' field/variable names with 'dataplane', and then does necessary fix-up to adhere to coding style. No functional change. Signed-off-by

Re: [Qemu-block] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-04 Thread Paul Durrant
Ping Anthony & Kevin? I believe this version is purged of all legacy interface use. > -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 20 December 2018 17:15 > To: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen- > de...@lists.xenpro

<    1   2   3   4   5   >