Now that the (native or emulated) xen_be_copy_grant_refs() helper is
always available, the xen_disk code can be significantly simplified by
removing direct use of grant map and unmap operations.
Signed-off-by: Paul Durrant
Acked-by: Anthony Perard
---
Cc: Stefano Stabellini
Cc: Kevin Wolf
Cc
Not all Xen environments support the xengnttab_grant_copy() operation.
E.g. where the OS is FreeBSD or Xen is older than 4.8.0.
This patch introduces an emulation of that operation using
xengnttab_map_domain_grant_refs() and memcpy() for those environments.
Signed-off-by: Paul Durrant
---
Cc
(previous patch #1) to remain unmodified
from v3 but still compile against Xen 4.7.
Paul Durrant (9):
xen: add a meaningful declaration of grant_copy_segment into
xen_common.h
xen_backend: add grant table helpers
xen_disk: remove open-coded use of libxengnttab
xen: remove other open
Now that helpers are available in xen_backend, use them throughout all
Xen PV backends.
Signed-off-by: Paul Durrant
Acked-by: Anthony Perard
---
Cc: Stefano Stabellini
Cc: Greg Kurz
Cc: Paolo Bonzini
Cc: Jason Wang
Cc: Gerd Hoffmann
v2:
- New in v2
---
hw/9pfs/xen-9p-backend.c | 32
.
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
v4:
- New in v4
---
hw/block/xen_disk.c | 18 --
include/hw/xen/xen_common.h | 17 +++--
2 files changed, 15 insertions(+), 20 deletions(-)
diff --git a/hw/block/xen_disk.c b/hw/block
Now that helpers are present in xen_backend, this patch removes open-coded
calls to libxengnttab from the xen_disk code.
This patch also fixes one whitspace error in the assignment of the
XenDevOps initialise method.
Signed-off-by: Paul Durrant
Acked-by: Anthony Perard
---
Cc: Stefano
Since xen_disk now always copies data to and from a guest there is no need
to maintain a vector entry corresponding to every page of a request.
This means there is less per-request state to maintain so the ioreq
structure can shrink significantly.
Signed-off-by: Paul Durrant
Acked-by: Anthony
clearly
equivalent.
This patch is a purely cosmetic patch which makes sure there is a xendev
pointer on stack for any function where the pointer is need on multiple
occasions modified those functions to use it consistently.
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kev
There is no longer any use of this flag outside of the xen_backend code.
Signed-off-by: Paul Durrant
Acked-by: Anthony Perard
---
Cc: Stefano Stabellini
v2:
- New in v2
---
hw/xen/xen_backend.c | 2 +-
include/hw/xen/xen_backend.h | 1 -
2 files changed, 1 insertion(+), 2 deletions
prior method requires access to the grant table.
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
v2:
- New in v2
---
hw/xen/xen_backend.c | 123 ++-
include/hw/xen/xen_backend.h | 33
2 files changed, 144
> -Original Message-
> From: Paul Durrant [mailto:paul.durr...@citrix.com]
> Sent: 17 May 2018 16:36
> To: xen-de...@lists.xenproject.org; qemu-block@nongnu.org; qemu-
> de...@nongnu.org
> Cc: Paul Durrant ; Stefano Stabellini
> ; Anthony Perard ;
> Kevin Wol
> -Original Message-
> From: Dmitry Fomichev
> Sent: 17 July 2019 22:27
> To: qemu-de...@nongnu.org; qemu-block@nongnu.org
> Cc: John Snow ; Kevin Wolf ; Max Reitz
> ; Keith
> Busch ; Stefan Hajnoczi ; Michael
> S. Tsirkin
> ; Stefano Stabellini ; Anthony Pera
the backend in these circumstances.
Reported-by: Mark Syms
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/xen-block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index
> -Original Message-
> From: John Snow
> Sent: 20 September 2019 22:11
> To: Paul Durrant ; xen-de...@lists.xenproject.org;
> qemu-de...@nongnu.org;
> qemu-block@nongnu.org
> Cc: Kevin Wolf ; Stefano Stabellini
> ; Max Reitz
> ; Anthony Perard ; Mark Syms
&g
acro-file scripts/cocci-macro-file.h \
> --in-place --no-show-diff --max-width 80
>
> Reported-by: Kevin Wolf
> Reported-by: Greg Kurz
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Paul Durrant
tions
> of this macro at the start of functions with either use
> error_prepend/error_append_hint (solving 1) or which use
> local_err+error_propagate to check errors, switching those
> functions to use *errp instead (solving 2 and 3).
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Paul Durrant
Some frontend drivers will handle dynamic resizing of PV disks, so set up
the BlockDevOps resize_cb() method during xen_block_realize() to allow
this to be done.
Signed-off-by: Paul Durrant
---
Cc: Stefan Hajnoczi
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
v2
Some frontend drivers will handle dynamic resizing of PV disks, so set up
the BlockDevOps resize_cb() method during xen_block_realize() to allow
this to be done.
Signed-off-by: Paul Durrant
---
Cc: Stefan Hajnoczi
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
v3
> -Original Message-
> From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> Sent: 31 January 2019 15:25
> To: Paul Durrant
> Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen-
> de...@lists.xenproject.org; Stefan Hajnoczi ; Stefano
> Stabellini ; Kev
> -Original Message-
> From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> Sent: 31 January 2019 15:21
> To: Paul Durrant
> Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org; xen-
> de...@lists.xenproject.org; Stefan Hajnoczi ; Stefano
> Stabellini ; Kev
The assignment to 'p' is unnecessary as the code will either goto 'invalid'
or p will get overwritten.
Spotted by Coverity: CID 1398638
Reported-by: Peter Maydell
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reit
The if() statement is clearly bogus (dead code which should have been
cleaned up when grant mapping was removed).
Spotted by Coverity: CID 1398635
While in the neighbourhood, add a missing 'fall through' annotation.
Reported-by: Peter Maydell
Signed-off-by: Paul Durrant
---
The function needs to make sure it is passed a valid disk name. This is
easily done by making sure that the parsing loop results in a non-zero
value.
Spotted by Coverity: CID 1398640
Reported-by: Peter Maydell
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc
Paul Durrant (3):
dataplane/xen-block: remove dead code
xen-block: remove redundant assignment
xen-block: report error condition from vbd_name_to_disk()
hw/block/dataplane/xen-block.c | 5 +
hw/block/xen-block.c | 24
2 files changed, 17 insertions
and filename are
non-NULL in the normal path.
Reported-by: Peter Maydell
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/xen-block.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/hw/bloc
Apologies... typo-ed qemu-devel...
> -Original Message-
> From: Paul Durrant [mailto:paul.durr...@citrix.com]
> Sent: 19 February 2019 16:35
> To: qeme-de...@nongnu.org; qemu-block@nongnu.org; xen-
> de...@lists.xenproject.org
> Cc: Paul Durrant ; Peter Maydell
>
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: 13 March 2019 17:45
> To: qemu-de...@nongnu.org
> Cc: sstabell...@kernel.org; Anthony Perard ; Paul
> Durrant
> ; xen-de...@lists.xenproject.org;
> qemu-block@nongnu.org
>
to the physical block size.
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/xen-block.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 70fc2
-off-by: Paul Durrant
---
Cc: Stefan Hajnoczi
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/dataplane/xen-block.c | 28 +---
hw/block/xen-block.c | 2 +-
hw/block/xen_blkif.h | 2 ++
3 files changed, 16
> -Original Message-
> From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> Sent: 21 March 2019 11:42
> To: Paul Durrant
> Cc: xen-de...@lists.xenproject.org; qemu-block@nongnu.org;
> qemu-de...@nongnu.org; Stefano Stabellini
> ; Kevin Wolf ; Max Reitz
>
&g
> -Original Message-
> From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> Sent: 21 March 2019 15:00
> To: Paul Durrant
> Cc: xen-de...@lists.xenproject.org; qemu-block@nongnu.org;
> qemu-de...@nongnu.org; Stefan Hajnoczi
> ; Stefano Stabellini ; Kevin
ml/xen-devel/2019-03/msg01600.html
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/xen-block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index a848849f48..57e9da
es the xen-block code accordingly.
Signed-off-by: Paul Durrant
---
Cc: Stefan Hajnoczi
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/dataplane/xen-block.c | 28 +---
hw/block/xen_blkif.h | 2 ++
2 files changed, 15
ries fixes xen-block to adhere to the spec.
Paul Durrant (2):
xen-block: scale sector based quantities correctly
xen-block: always report 'sectors' in terms of 512-byte units
hw/block/dataplane/xen-block.c | 28 +---
hw/block/xen-block.c
> -Original Message-
> From: Andrew Cooper
> Sent: 27 March 2019 18:20
> To: Paul Durrant ; xen-de...@lists.xenproject.org;
> qemu-block@nongnu.org;
> qemu-de...@nongnu.org
> Cc: Kevin Wolf ; Stefano Stabellini
> ; Max Reitz
> ; Stefan Hajnoczi ; Anthony Per
> -Original Message-
> From: Andrew Cooper
> Sent: 28 March 2019 11:46
> To: Anthony Perard ; Paul Durrant
>
> Cc: xen-de...@lists.xenproject.org; qemu-block@nongnu.org;
> qemu-de...@nongnu.org; Kevin Wolf
> ; Stefano Stabellini ; Max Reitz
> ; Stefan
>
> -Original Message-
> From: Kevin Wolf [mailto:kw...@redhat.com]
> Sent: 28 March 2019 11:56
> To: Andrew Cooper
> Cc: Anthony Perard ; Paul Durrant
> ; xen-
> de...@lists.xenproject.org; qemu-block@nongnu.org; qemu-de...@nongnu.org;
> Stefano Stabellini
> ;
> -Original Message-
[snip]
> > >
> > > The old implementation has the sector size hardcoded:
> > >
> > > #define BLOCK_SIZE 512
> > >
> > > Whereas the qdevified version uses DEFINE_BLOCK_PROPERTIES(), which
> > > includes user-visible options for logical/physical_block_size.
> > >
>
k_size is set to anything other than 512.
Signed-off-by: Paul Durrant
---
Cc: Stefan Hajnoczi
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
v3:
- Expand commit comment with more explanation
- Enforce logical_block_size == 512
---
hw/block/dataplane/xen-block.c | 2
This patch adds an AioContext parameter to xen_device_bind_event_channel()
and then uses aio_set_fd_handler() to set the callback rather than
qemu_set_fd_handler().
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Max Reitz
poll of the shared ring should be because
there were previously insufficient resources to fully complete a previous
poll.
Signed-off-by: Paul Durrant
---
Cc: Stefan Hajnoczi
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/dataplane/xen-block.c | 17
Currently xen-block uses an IOThread to handle AIO but the event channels
are dealt with on QEMU's main thread. This series allows them to be
dealt with in the same context.
Paul Durrant (3):
xen-bus: use a separate fd for each event channel
xen-bus: allow AioContext to be specified for
xen_device_realize/unrealize().
NOTE: This patch does not add an AioContext parameter to
xen_device_bind_event_channel(). That will be done in a subsequent
patch.
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
---
hw/xen/xen-bus.c | 79
[2] https://winpvdrvbuild.xenproject.org:8080/job/XENVBD-master/126
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Max Reitz
---
hw/block/dataplane/xen-block.c | 25 --
hw/block/dataplane/xen-block.h | 3 ++-
hw/block/x
> -Original Message-
> From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> Sent: 10 April 2019 13:57
> To: Paul Durrant
> Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org;
> xen-de...@lists.xenproject.org; Stefano Stabellini
> ; Stefan Hajnoczi ; Kevin
> -Original Message-
> From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> Sent: 10 April 2019 16:52
> To: Paul Durrant
> Cc: qemu-de...@nongnu.org; xen-de...@lists.xenproject.org;
> qemu-block@nongnu.org; Stefano Stabellini
> ; Stefan Hajnoczi ; Kevin
> -Original Message-
> From: Anthony PERARD [mailto:anthony.per...@citrix.com]
> Sent: 10 April 2019 16:23
> To: Paul Durrant
> Cc: qemu-de...@nongnu.org; qemu-block@nongnu.org;
> xen-de...@lists.xenproject.org; Stefano Stabellini
> ; Stefan Hajnoczi ; Kevin
> -Original Message-
[snip]
> > > I wonder if the `'is_external' parameter of aio_set_fd_handler shoud be
> > > `true' here, instead. That flag seems to be used when making a snapshot
> > > of a blockdev, for example.
> > >
> > > That was introduced by:
> > > dca21ef23ba48f6f1428c59f295a857
> -Original Message-
> From: Anthony PERARD
> Sent: 02 April 2020 14:08
> To: qemu-de...@nongnu.org
> Cc: qemu-sta...@nongnu.org; Anthony PERARD ;
> Stefano Stabellini
> ; Paul Durrant ; Stefan Hajnoczi
> ; Kevin
> Wolf ; Max Reitz ;
> xen-de...@li
> -Original Message-
> From: Anthony PERARD
> Sent: 06 April 2020 15:02
> To: qemu-de...@nongnu.org
> Cc: qemu-sta...@nongnu.org; Anthony PERARD ;
> Stefano Stabellini
> ; Paul Durrant ; Stefan Hajnoczi
> ; Kevin
> Wolf ; Max Reitz ;
> xen-de...@li
gt; qemu-...@nongnu.org; qemu-
> p...@nongnu.org; Jason Wang ; Markus Armbruster
> ; qemu-
> s3...@nongnu.org; Dr. David Alan Gilbert ; Joel Stanley
> ; David
> Hildenbrand ; Aurelien Jarno ;
> Laurent Vivier
> ; Peter Maydell ; Cornelia Huck
> ;
> Paolo Bonzini ; Andrew Jeff
gt; ; qemu-
> bl...@nongnu.org; Philippe Mathieu-Daudé ; Eric Blake
> ; Paul
> Durrant ; Fam Zheng ; John Snow
> ; Michael S. Tsirkin
> ; Eduardo Habkost ; Keith Busch
> ; Stefano
> Stabellini ; Stefan Hajnoczi
> Subject: [PATCH v6 2/5] block: consolidate blocksize prop
On Mon, 14 Oct 2019 at 15:27, Philippe Mathieu-Daudé wrote:
>
> xen_pt_load_rom.c does not use any of these includes, remove them.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Paul Durrant
> ---
> hw/xen/xen_pt_load_rom.c | 4
> 1 file changed, 4 deletion
ed
back to main thread context before it is closed. aio_set_fd_handler()
already deals with all the necessary synchronization when moving an fd
between AioContext-s so no extra code is needed to manage this.
Reported-by: Julien Grall
Signed-off-by: Paul Durrant
---
Cc: Stefano Stabellini
Cc: Ant
On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy
wrote:
[snip]
> +/*
> + * ERRP_AUTO_PROPAGATE
> + *
> + * This macro is created to be the first line of a function which use
> + * Error **errp parameter to report error. It's needed only in cases where we
> + * want to use error_prepend,
--macro-file scripts/cocci-macro-file.h \
> --in-place --no-show-diff --max-width 80
>
> Reported-by: Kevin Wolf
> Reported-by: Greg Kurz
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Paul Durrant
> -Original Message-
> From: Anthony PERARD
> Sent: 27 October 2020 15:41
> To: qemu-de...@nongnu.org
> Cc: Anthony PERARD ; Paul Durrant ;
> Stefano Stabellini
> ; John Snow ; qemu-block@nongnu.org
> Subject: [PATCH v2] xen: rework pci_piix3_xen_ide_unplug
&
in
> Wolf ; Eric Blake ; Paolo Bonzini
> ; Cornelia
> Huck ; Stefan Berger ; Stefano
> Stabellini
> ; Anthony Perard ; Paul
> Durrant ; Max
> Reitz ; Thomas Huth ; Richard Henderson
> ; David
> Hildenbrand ; Halil Pasic ; Christian
> Borntraeger
> ; Matthew
in
> Wolf ; Eric Blake ; Paolo Bonzini
> ; Stefan
> Berger ; Stefano Stabellini
> ; Anthony Perard
> ; Paul Durrant ; Max Reitz
> ; Cornelia Huck
> ; Halil Pasic ; Christian Borntraeger
> ; Richard Henderson ; David
> Hildenbrand ;
> Thomas Huth ; Matthew Rosato ; A
in
> Wolf ; Eric Blake ; Paolo Bonzini
> ; Stefan
> Berger ; Stefano Stabellini
> ; Anthony Perard
> ; Paul Durrant ; Max Reitz
> ; Cornelia Huck
> ; Halil Pasic ; Christian Borntraeger
> ; Richard Henderson ; David
> Hildenbrand ;
> Thomas Huth ; Matthew Rosato ; Al
Gibson ; Mark Cave-Ayland
> ; Hervé
> Poussineau ; Aleksandar Rikalo
> ; BALATON Zoltan
> ; Guan Xuetao ; Helge Deller
> ; Corey Minyard
> ; Stefano Stabellini ; Anthony
> Perard
> ; Paul Durrant ; Chris Wulff
> ; Marek Vasut
> ; Huacai Chen ; Jiaxun Yang
>
drew
> Jeffery ; Joel
> Stanley ; Andrew Baumann ;
> Philippe Mathieu-Daudé
> ; Eric Auger ; Marcel Apfelbaum
> ;
> Laurent Vivier ; Sergio Lopez ; John Snow
> ; Xiao
> Guangrong ; Peter Chubb
> ; Beniamino Galvani
> ; Edgar E. Iglesias ; Stefano
> Stabellini
ric Le Goater
> ; David Gibson ; Cornelia Huck
> ; Thomas
> Huth ; Halil Pasic ; Christian
> Borntraeger
> ; Philippe Mathieu-Daudé ; Alistair
> Francis
> ; David Hildenbrand ; Laurent
> Vivier ;
> Amit Shah ; Stefano Stabellini ;
> Anthony Perard
> ; Paul Durrant ;
> -Original Message-
> From: Anthony PERARD
> Sent: 18 September 2020 15:53
> To: qemu-de...@nongnu.org
> Cc: Paul Durrant ; Stefano Stabellini ;
> Anthony PERARD
> ; John Snow ;
> qemu-block@nongnu.org
> Subject: [PATCH] xen: rework pci_piix3_xen_ide_unplu
kin
Xen parts...
Reviewed-by: Paul Durrant
lockDrive associated with `xendev' with
s/cann't/can't
With those fixed...
Reviewed-by: Paul Durrant
+ * xen_block_drive_destroy() below.
+ */
+drain_call_rcu();
+
if (iothread) {
xen_block_iothread_destroy(iothread, errp);
if (*errp) {
verything doesn't work anymore, we need to use the "host_device"
driver when the disk image is a block device and "file" driver when it
is a regular file.
Signed-off-by: Anthony PERARD
Acked-by: Paul Durrant
---
hw/block/xen-block.c | 14 +-
1 file ch
David Woodhouse
Signed-off-by: Stefan Hajnoczi
---
hw/i386/kvm/xen_xenstore.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Paul Durrant
f-by: Anthony PERARD
---
hw/block/xen-block.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Paul Durrant
> -Original Message-
> From: Roger Pau Monne
> Sent: 18 January 2021 15:34
> To: qemu-de...@nongnu.org
> Cc: Roger Pau Monne ; Arthur Borsboom
> ; Stefano
> Stabellini ; Anthony Perard
> ; Paul Durrant
> ; Kevin Wolf ; Max Reitz ;
> xen-
> de...
ed, 125 insertions(+), 46 deletions(-)
Reviewed-by: Paul Durrant
2 +-
hw/i386/pc_q35.c | 2 +-
hw/xen/xen-bus.c | 4 +++-
include/hw/i386/pc.h | 4 +++-
include/hw/xen/xen-bus.h | 2 +-
6 files changed, 17 insertions(+), 8 deletions(-)
Reviewed-by: Paul Durrant
fs
option is set.
Signed-off-by: David Woodhouse
---
docs/sphinx/hxtool.py | 18 +-
docs/system/invocation.rst | 1 +
2 files changed, 18 insertions(+), 1 deletion(-)
Reviewed-by: Paul Durrant
.rst | 107 +--
qemu-options.hx | 14 +++--
3 files changed, 91 insertions(+), 32 deletions(-)
Reviewed-by: Paul Durrant
de to hopefully make it clearer to Coverity and human reviewers
alike.
Signed-off-by: David Woodhouse
---
hw/block/xen-block.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
Reviewed-by: Paul Durrant
On 10/11/2023 15:42, Volodymyr Babchuk wrote:
From: Oleksandr Tyshchenko
The PV backend running in other than Dom0 domain (non toolstack domain)
is not allowed to write frontend nodes. The more, the backend does not
need to do that at all, this is purely toolstack/xl devd business.
I do not kn
de to hopefully make it clearer to Coverity and human reviewers
alike.
Signed-off-by: David Woodhouse
---
hw/block/xen-block.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
Reviewed-by: Paul Durrant
On 15/11/2023 17:24, David Woodhouse wrote:
From: David Woodhouse
If a Xen console is configured on the command line, do not add a default
serial port.
Signed-off-by: David Woodhouse
---
system/vl.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Paul Durrant
/xen_nic.c | 2 +-
hw/xen/xen-bus.c | 4
include/hw/xen/xen-backend.h | 2 --
include/hw/xen/xen-bus.h | 2 ++
6 files changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Paul Durrant
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
was created by QEMU
Xen PV devices in QEMU can be created in two ways: either by QEMU
itself, if they were passed via command line, or by Xen toolstack. In
the latter case, QEMU scans XenStore entries and configures devices
accordingly.
In the secon
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: David Woodhouse
This allows a XenDevice implementation to know whether it was created
by QEMU, or merely discovered in XenStore after the toolstack created
it. This will allow us to create frontend/backend nodes only when we
should, rather tha
On 22/11/2023 23:04, David Woodhouse wrote:
On Wed, 2023-11-22 at 22:56 +, Volodymyr Babchuk wrote:
Paul Durrant writes:
On 21/11/2023 22:10, Volodymyr Babchuk wrote:
From: David Woodhouse
This allows a XenDevice implementation to know whether it was
created
by QEMU, or merely
les changed, 502 insertions(+), 502 deletions(-)
Reviewed-by: Paul Durrant
ons(+), 25 deletions(-)
Reviewed-by: Paul Durrant
/test-replication.c | 11 --
util/async.c | 4 -
util/vhost-user-server.c | 3 -
scripts/block-coroutine-wrapper.py | 3 -
tests/tsan/suppressions.tsan | 1 -
41 files changed, 102 insertions(+), 1202 deletions(-)
Reviewed-by: Paul Durrant
/plug.c | 109 +++---
hw/block/dataplane/xen-block.c| 10 +--
hw/block/virtio-blk.c | 4 +-
hw/scsi/virtio-scsi.c | 6 +-
9 files changed, 76 insertions(+), 79 deletions(-)
Reviewed-by: Paul Durrant
d, 2 insertions(+), 3 deletions(-)
Reviewed-by: Paul Durrant
On 16/10/2023 16:18, David Woodhouse wrote:
From: David Woodhouse
A guest which has configured the per-vCPU upcall vector may set the
HVM_PARAM_CALLBACK_IRQ param to fairly much anything other than zero.
For example, Linux v6.0+ after commit b1c3497e604 ("x86/xen: Add support
for HVMOP_set_evt
/interface/vcpu.h | 19 +--
include/hw/xen/interface/version.h| 19 +--
include/hw/xen/interface/xen-compat.h | 19 +--
include/hw/xen/interface/xen.h| 19 +--
29 files changed, 124 insertions(+), 523 deletions(-)
Acked-by: Paul
(+)
Reviewed-by: Paul Durrant
allow guests to *rebind* to the event channel port after a reset.
... although this can also be done by querying the remote end of the
port before reset.
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_xenstore.c | 10 ++
1 file changed, 10 insertions(+)
Reviewed-by: Paul Durrant
On 16/10/2023 16:19, David Woodhouse wrote:
From: David Woodhouse
The primary Xen console is special. The guest's side is set up for it by
the toolstack automatically and not by the standard PV init sequence.
Accordingly, its *frontend* doesn't appear in …/device/console/0 either;
instead it a
On 24/10/2023 13:56, David Woodhouse wrote:
On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote:
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -711,8 +711,16 @@ static void xen_device_frontend_create(XenDevice *xendev,
Error **errp)
{
ERRP_GUARD();
XenBus *xenbus
|= xencons_send(con);
}
+return done_something;
+}
-path = g_string_new(dom_path);
-free(dom_path);
+/* */
-if (con->xendev.dev) {
-g_string_append_printf(path, "/device/console/%d", con->xendev.dev);
-} else {
-g_string_append(path, "/console");
+static void xen_console_disconnect(XenDevice *xendev, Error **errp)
+{
+XenConsole *con = XEN_CONSOLE_DEVICE(xendev);
+
+qemu_chr_fe_set_handlers(&con->chr, NULL, NULL, NULL, NULL,
+ con, NULL, true);
+
nit: extraneous blank line by the looks of it.
With that fixed...
Reviewed-by: Paul Durrant
/xen-backend.h | 1 +
3 files changed, 24 insertions(+), 7 deletions(-)
Reviewed-by: Paul Durrant
On 24/10/2023 14:29, David Woodhouse wrote:
On Tue, 2023-10-24 at 13:59 +0100, Paul Durrant wrote:
On 24/10/2023 13:56, David Woodhouse wrote:
On Tue, 2023-10-24 at 13:42 +0100, Paul Durrant wrote:
--- a/hw/xen/xen-bus.c
+++ b/hw/xen/xen-bus.c
@@ -711,8 +711,16 @@ static void
On 16/10/2023 16:19, David Woodhouse wrote:
From: David Woodhouse
Ensure that we have a XenBackendInstance for every device regardless
of whether it was "discovered" in XenStore or created directly in QEMU.
This allows the backend_list to be a source of truth about whether a
given backend exis
On 16/10/2023 16:19, David Woodhouse wrote:
From: David Woodhouse
The primary console is special because the toolstack maps a page at a
fixed GFN and also allocates the guest-side event channel. Add support
for that in emulated mode, so that we can have a primary console.
Add a *very* rudiment
+++
3 files changed, 14 insertions(+)
Reviewed-by: Paul Durrant
: de26b2619789 ("hw/xen: Implement soft reset for emulated gnttab")
Signed-off-by: David Woodhouse
---
hw/i386/kvm/xen_gnttab.c | 2 --
1 file changed, 2 deletions(-)
Reviewed-by: Paul Durrant
301 - 400 of 408 matches
Mail list logo