This property was only required for the pc-1.0 and earlier machine
types. Since these have been removed now, we can delete the property
as well.
Signed-off-by: Thomas Huth
---
hw/usb/bus.c | 7 +--
include/hw/usb.h | 2 +-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a
even remove more stuff like the various host_features
switches in the virtio devices, but they still might be useful in certain
cases, so I decided not to remove them yet)
Thomas Huth (4):
hw/i386: Remove the deprecated pc-1.x machine types
hw/block/fdc: Remove the check_media_rate property
They have been deprecated since QEMU v5.0, time to remove them now.
Signed-off-by: Thomas Huth
---
docs/system/deprecated.rst | 6 --
docs/system/removed-features.rst | 6 ++
hw/i386/pc_piix.c| 94
3 files changed, 6 insertions(+), 100
This was only required for the pc-1.0 and earlier machine types.
Now that these have been removed, we can also drop the corresponding
code from the FDC device.
Signed-off-by: Thomas Huth
---
hw/block/fdc.c | 17 ++---
tests/qemu-iotests/172.out | 35
On 04/02/2021 09.36, Gerd Hoffmann wrote:
Hi,
enum USBDeviceFlags {
-USB_DEV_FLAG_FULL_PATH,
+USB_DEV_FLAG_FULL_PATH, /* unused since QEMU v6.0 */
Why not just drop it? Any remaining users?
I didn't want to change the values of the other members of the enum ... but
On 05/02/2021 01.40, John Snow wrote:
On 2/3/21 12:18 PM, Thomas Huth wrote:
This was only required for the pc-1.0 and earlier machine types.
Now that these have been removed, we can also drop the corresponding
code from the FDC device.
Signed-off-by: Thomas Huth
---
hw/block/fdc.c
On 05/02/2021 17.23, Peter Maydell wrote:
On Fri, 5 Feb 2021 at 16:21, Stefan Hajnoczi wrote:
Thanks, I update the patch in question.
It looks like the GitLab CI doesn't include a clang version that
produces this error because the pipeline passed for me:
https://gitlab.com/stefanha/qemu/-/pipe
On 06/02/2021 18.57, Philippe Mathieu-Daudé wrote:
On 2/5/21 5:44 PM, Stefan Hajnoczi wrote:
From: Jagannathan Raman
PCI host bridge is setup for the remote device process. It is
implemented using remote-pcihost object. It is an extension of the PCI
host bridge setup by QEMU.
Remote-pcihost co
On 05/02/2021 21.15, John Snow wrote:
On 2/5/21 1:37 AM, Thomas Huth wrote:
On 05/02/2021 01.40, John Snow wrote:
On 2/3/21 12:18 PM, Thomas Huth wrote:
This was only required for the pc-1.0 and earlier machine types.
Now that these have been removed, we can also drop the corresponding
code
On 08/02/2021 21.21, Stefan Hajnoczi wrote:
On Mon, Feb 08, 2021 at 11:02:57AM +0100, Philippe Mathieu-Daudé wrote:
On 2/8/21 10:27 AM, Stefan Hajnoczi wrote:
On Sat, Feb 06, 2021 at 05:03:20PM +, Peter Maydell wrote:
On Fri, 5 Feb 2021 at 22:53, Peter Maydell wrote:
On Fri, 5 Feb 2021
On 09/02/2021 14.50, Daniel P. Berrangé wrote:
The Travis CI system QEMU has been using has removed the unlimited free
usage model, replacing it with a one-time only grant of CI minutes that
is not renewed. The QEMU CI jobs quickly exhaust maintainer's free CI
credits, leaving them unable to test
On 10/02/2021 12.15, Bin Meng wrote:
Hi Philippe,
On Wed, Feb 10, 2021 at 7:12 PM Philippe Mathieu-Daudé
wrote:
Hi Bin,
On 2/10/21 11:23 AM, Bin Meng wrote:
From: Bin Meng
Current QEMU HEAD nvme.c does not compile:
hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in t
Tests in the "auto" group should support qcow2 so that they can
be run during "make check-block". Test 259 only supports "raw", so
it currently always gets skipped when running "make check-block".
Let's skip this unnecessary step and remove it fro
On 16/02/2021 02.49, John Snow wrote:
On 1/26/21 10:15 AM, Vladimir Sementsov-Ogievskiy wrote:
OK, thanks for handling it!
When will we move to python 3.7?
[...]
As for RHEL/CentOS, I think it's in the same shape right now. It's
3.6-based, but I don't know if there's an optional 3.7+ packa
*
I also see some lines in tests/check-block-qdict.c ... are they related and
should be removed, too?
Apart from that, patch looks fine to me:
Reviewed-by: Thomas Huth
docs/system/deprecated.rst | 6 -
docs/system/removed-features.rst | 6 +
monitor/qmp-cmds-control.c | 24 -
qapi/control.json| 45
4 files changed, 6 insertions(+), 75 deletions(-)
Reviewed-by: Thomas Huth
On 24/02/2021 14.11, Daniel P. Berrangé wrote:
This was replaced by the '-device usb-DEV' option.
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 9 ---
docs/system/removed-features.rst | 9 +++
softmmu/vl.c | 42 ---
uot;, "0" },
/* DEV_NVECTORS_UNSPECIFIED as a uint32_t string: */
{ "virtio-serial-pci", "vectors", "0x" },
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 8cd19fa5e9..e70ebc83a0 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -283,20 +283,6 @@ static void ide_cd_realize(IDEDevice *dev, Error **errp)
ide_dev_initfn(dev, IDE_CD, errp);
}
-static void ide_drive_realize(IDEDevice *dev, Error **errp)
-{
-DriveInfo *dinfo = NULL;
-
-warn_report("'ide-drive' is deprecated, "
-"please use 'ide-hd' or 'ide-cd' instead");
-
-if (dev->conf.blk) {
-dinfo = blk_legacy_dinfo(dev->conf.blk);
-}
-
-ide_dev_initfn(dev, dinfo && dinfo->media_cd ? IDE_CD : IDE_HD, errp);
-}
I wonder whether we now could also make the "media" parameter of "-drive" as
deprecated?
Anyway, for this patch:
Reviewed-by: Thomas Huth
On 24/02/2021 14.11, Daniel P. Berrangé wrote:
The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives.
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst | 9 -
docs/system/removed-features.rst | 6
hw/i386/pc.c | 1 -
hw/scsi/
;''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
diff --git a/docs/system/removed-features.rst b/docs/system/removed-features.rst
index bb6bc8dfc8..583f14f02e 100644
--- a/docs/system/removed-features.rst
+++ b/docs/system/removed-features.rst
@@ -112,6 +112,16 @@ chardev client socket with ``wait`` option (removed in 6.0)
Character devices creating sockets in client mode should not specify
the 'wait' field, which is only applicable to sockets in server mode
+``query-named-block-nodes`` result ``encryption_key_missing`` (removed in 6.0)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Always false.
Should that be "Removed with no replacement", too ? (just like the one below)
+``query-block`` result ``inserted.encryption_key_missing`` (removed in 6.0)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Removed with no replacement
+
Apart from that nit:
Reviewed-by: Thomas Huth
On 24/02/2021 15.10, Daniel P. Berrangé wrote:
On Wed, Feb 24, 2021 at 02:58:19PM +0100, Thomas Huth wrote:
On 24/02/2021 14.11, Daniel P. Berrangé wrote:
This was replaced by the '-device usb-DEV' option.
Signed-off-by: Daniel P. Berrangé
---
docs/system/deprecated.rst
t; 0) {
goto authreject;
}
Reviewed-by: Thomas Huth
27; is not in whitelist. "
+raise ValueError("Argument type '%s' is not allowed. "
"Only standard C types and fixed size integer "
"types should be used. struct, union, and "
"other complex pointer types should be "
Reviewed-by: Thomas Huth
On 05/02/2021 18.18, Philippe Mathieu-Daudé wrote:
Follow the inclusive terminology from the "Conscious Language in your
Open Source Projects" guidelines [*] and replace the word "blacklist"
appropriately.
[*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
Reviewed-by: D
list[i].arg_cmp);
if (rc < 0) {
error_setg_errno(errp, -rc,
- "failed to add seccomp blacklist rules");
+ "failed to add seccomp denylist rules");
goto seccomp_return;
}
}
Reviewed-by: Thomas Huth
blocking *fork and execve\n" \
"use 'resourcecontrol' to disable process affinity and
schedular priority\n",
QEMU_ARCH_ALL)
SRST
Reviewed-by: Thomas Huth
mode)) {
+if (!is_allowed(op, rmode)) {
not_implemented();
return;
}
Reviewed-by: Thomas Huth
---
tests/qtest/libqos/libqtest.h | 11 +++
tests/qtest/libqtest.c| 7 ---
2 files changed, 15 insertions(+), 3 deletions(-)
Reviewed-by: Thomas Huth
/libqtest.h | 18 ++
tests/qtest/libqtest.c| 35 +--
2 files changed, 47 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
Let's use 'allowlist' and 'ignorelist' here instead of
problematic words.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/149 | 14 +++---
tests/qemu-iotests/149.out | 8
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/tests/qemu
Let's use 'unsupported_configs' and 'tested_configs' here instead
of non-inclusive words.
Suggested-by: Paolo Bonzini
Signed-off-by: Thomas Huth
---
v2: Use different wordings (suggested by Paolo)
tests/qemu-iotests/149 | 16 +---
tests/qemu-iotests
Let's use 'unsupported_configs' and 'tested_configs' here
instead of non-inclusive words.
Signed-off-by: Thomas Huth
---
v3: Rewording according to the suggestions of Daniel:
- Replaced "cipher not supported" with "config not supported"
- Replac
On 17/01/2024 16.14, Philippe Mathieu-Daudé wrote:
This option has been deprecated before the 8.1 release,
in commit 12fd0f41d0 ("Document that -singlestep command
line option is deprecated"). Time to drop it.
Inspired-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
uri_string_unescape() with g_uri_unescape_segment(), so
we can remove uri_string_unescape() completely now
Thomas Huth (4):
util/uri: Remove uri_string_unescape()
util/uri: Remove unused functions uri_resolve() and
uri_resolve_relative()
util/uri: Remove the uri_string_escape() function
util
Weil
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 2 -
util/uri.c | 689 -
2 files changed, 691 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu/uri.h
index f0722b75da..899ce852
()]
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 1 -
util/uri.c | 97 ++
2 files changed, 11 insertions(+), 87 deletions(-)
diff --git a/include/qemu/uri.h b/include/qemu/uri.h
index 1855b764f2..f0722b75da 100644
--- a/include/qemu/uri.h
They are not used anywhere, so there's no need to keep them around.
Message-ID: <20240122191753.103118-6-th...@redhat.com>
Reviewed-by: Stefan Weil
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: Thomas Huth
---
util/uri.c | 13
Now that uri_resolve_relative() has been removed, this function is not
used in QEMU anymore - and if somebody needs this functionality, they
can simply use g_uri_escape_string() from the glib instead.
Reviewed-by: Stefan Weil
Reviewed-by: "Daniel P. Berrangé"
Signed-off-by: T
cation': 45,
}
foreach test_name, extra: tests
I'd maybe even bump it to 60 seconds, just to be on the safe side.
Anyway:
Reviewed-by: Thomas Huth
ot;qemu/bitops.h"
#include "qemu/error-report.h"
@@ -21,6 +22,9 @@
#include "qemu/rcu_queue.h"
#include "hw/hyperv/hyperv.h"
#include "qom/object.h"
+#include "target/i386/kvm/hyperv-proto.h"
+#include "target/i386/cpu.h"
+#include "exec/cpu-all.h"
struct SynICState {
DeviceState parent_obj;
Reviewed-by: Thomas Huth
For distros like downstream RHEL, it would be helpful to allow to disable
the CompactFlash device. For making this possible, we need a separate
Kconfig switch for this device, and the code should reside in a separate
file.
Signed-off-by: Thomas Huth
---
hw/ide/qdev-ide.h | 41
On 01/02/2024 13.39, BALATON Zoltan wrote:
On Thu, 1 Feb 2024, Thomas Huth wrote:
For distros like downstream RHEL, it would be helpful to allow to disable
the CompactFlash device. For making this possible, we need a separate
Kconfig switch for this device, and the code should reside in a
On 01/02/2024 13.54, BALATON Zoltan wrote:
On Thu, 1 Feb 2024, Thomas Huth wrote:
On 01/02/2024 13.39, BALATON Zoltan wrote:
On Thu, 1 Feb 2024, Thomas Huth wrote:
For distros like downstream RHEL, it would be helpful to allow to disable
the CompactFlash device. For making this possible, we
garch64")) {
+const char *virtmachine[] = { "virt", NULL };
+add_cdrom_param_tests(virtmachine);
} else {
const char *nonemachine[] = { "none", NULL };
add_cdrom_param_tests(nonemachine);
Anyway, using the virt machine is certainly better than the "none" machine, so:
Acked-by: Thomas Huth
On 06/02/2024 03.29, maobibo wrote:
Hi Philippe,
On 2024/2/5 下午8:58, Philippe Mathieu-Daudé wrote:
Hi Bibo,
On 5/2/24 03:13, Bibo Mao wrote:
The cdrom test skips to execute on LoongArch system with command
"make check", this patch enables cdrom test for LoongArch virt
machine platform.
With
;
add_cdrom_param_tests(nonemachine);
base-commit: 5767815218efd3cbfd409505ed824d5f356044ae
Reviewed-by: Thomas Huth
Let's start to unentangle internal.h by moving public IDE device
related definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 145 +-
include/hw/ide/internal.h | 145 +-
hw/ide/ide-
included
by files in hw/ide/ as it should be.
Thomas Huth (7):
hw/ide: Add the possibility to disable the CompactFlash device in the
build
hw/ide: Split qdev.c into ide-bus.c and ide-dev.c
hw/ide: Move IDE device related definitions to ide-dev.h
hw/ide: Move IDE bus related definitions to a
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device handling.
Signed-off-by: Thomas Huth
---
hw/ide/ide-bus.c
llect definitions related to IDE devices.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 41
hw/ide/cf.c | 58
hw/ide/qdev.c| 51 ++-
hw/ide/Kconfig
Let's consolidate the public IDE bus related functions in a separate
header.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-bus.h | 41 +++
include/hw/ide/internal.h | 38 +---
2 files changed, 42 insertions(+
include/hw/ide/internal.h is currently included by include/hw/ide/pci.h
and thus exposed to a lot of files that are not part of the IDE subsystem.
Stop including internal.h there and use the appropriate new headers
ide-bus.h and ide-dma.h instead.
Signed-off-by: Thomas Huth
---
include/hw/ide
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 30 ++
include/hw/ide/internal.h | 27 +
There was only one prototype left in this legacy file. Move it to
ide-dev.h to finally get rid of it.
Signed-off-by: Thomas Huth
---
include/hw/ide.h | 9 -
include/hw/ide/ide-dev.h | 2 ++
include/hw/ide/internal.h | 1 -
3 files changed, 2 insertions(+), 10 deletions
On 16/02/2024 12.03, Philippe Mathieu-Daudé wrote:
QDev objects created with qdev_*new() need to manually add
their parent relationship with object_property_add_child().
Signed-off-by: Philippe Mathieu-Daudé
---
hw/s390x/s390-pci-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/s
On 19/02/2024 12.45, BALATON Zoltan wrote:
On Mon, 19 Feb 2024, Thomas Huth wrote:
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device han
On 19/02/2024 12.32, Philippe Mathieu-Daudé wrote:
On 19/2/24 11:49, Thomas Huth wrote:
Let's start to unentangle internal.h by moving public IDE device
related definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h
On 19/02/2024 12.53, BALATON Zoltan wrote:
On Mon, 19 Feb 2024, Thomas Huth wrote:
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h
There was only one prototype left in this legacy file. Move it to
ide-dev.h to finally get rid of it.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 -
include/hw/ide.h | 9 -
include/hw/ide/ide-dev.h | 2 ++
include/hw/ide
-by: Thomas Huth
---
include/hw/ide/pci.h | 2 +-
hw/i386/pc.c | 2 +-
hw/ide/cmd646.c | 1 +
hw/ide/pci.c | 1 +
hw/ide/piix.c| 1 +
hw/ide/sii3112.c | 1 +
hw/ide/via.c | 1 +
7 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/include/hw/ide
These definitions are required outside of the hw/ide/ code, too,
so lets's move them from internal.h to a new header called ide-dma.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dma.h | 37 +
include/hw/ide/internal.h
Let's consolidate the public IDE bus related functions in a separate
header.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-bus.h | 42 +++
include/hw/ide/internal.h | 40 +
2 files changed, 43 insertions(+
/ide.h
Thomas Huth (7):
hw/ide: Add the possibility to disable the CompactFlash device in the
build
hw/ide: Split qdev.c into ide-bus.c and ide-dev.c
hw/ide: Move IDE DMA related definitions to a separate header
ide-dma.h
hw/ide: Move IDE device related definitions to ide-dev.h
hw
llect definitions related to IDE devices.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 41
hw/ide/cf.c | 58
hw/ide/qdev.c
Unentangle internal.h by moving public IDE device related
definitions to ide-dev.h.
Signed-off-by: Thomas Huth
---
include/hw/ide/ide-dev.h | 143 +-
include/hw/ide/internal.h | 143 +-
hw/ide/ide-dev.c | 1 +
3
qdev.c is a mixture between IDE bus specific functions and IDE device
functions. Let's split it up to make it more obvious which part is
related to bus handling and which part is related to device handling.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Thomas Huth
---
hw/ide/ide-
On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote:
On 20/2/24 09:55, Thomas Huth wrote:
Unentangle internal.h by moving public IDE device related
Disentangle ... from? Untangle? TIL Unentangle.
You're right, "disentangle" seems to be the more appropriate word.
I'll fix
t;hw/ide/internal.h"
+#include "hw/ide/ide-bus.h"
#include "hw/intc/heathrow_pic.h"
#include "hw/misc/macio/cuda.h"
#include "hw/misc/macio/gpio.h"
Oh, I was sure that I got them all ... thanks for double checking!
Reviewed-by: Thomas Huth
S_BUS_DEVICE(dev), 0, qdev_get_gpio_in(sms->gic,
irq));
sysahci = SYSBUS_AHCI(dev);
- ahci = &sysahci->ahci;
ide_drive_get(hd, ARRAY_SIZE(hd));
- for (i = 0; i < ahci->ports; i++) {
- if (hd[i] == NULL) {
- continue;
- }
- ide_bus_create_drive(&ahci->dev[i].port, 0, hd[i]);
- }
+ ahci_ide_create_devs(&sysahci->ahci, hd);
}
Reviewed-by: Thomas Huth
ot;hw/ide/pci.h"
#include "hw/ide/ahci-pci.h"
-#include "ahci_internal.h"
+#include "ahci-internal.h"
#define ICH9_MSI_CAP_OFFSET 0x80
#define ICH9_SATA_CAP_OFFSET0xA8
Reviewed-by: Thomas Huth
ueue);
+virtio_queue_notify(vdev, vq_idx);
return 0;
-
}
Acked-by: Thomas Huth
virtio_ccw_start_ioeventfd(dev);
}
sch->curr_status.scsw.count = ccw.count - sizeof(status);
Acked-by: Thomas Huth
On 05/03/2024 04.21, Xinying Yu wrote:
One more thing, I would ask how do I get the full series patch? Do I copy
the RFC line by line from this link[1]?
For getting patches that you might have missed on the mailing list, I
recommend lore.kernel.org :
https://lore.kernel.org/qemu-devel/202
s = NULL;
GList *iterbdrvs;
@@ -605,6 +606,7 @@ int bdrv_all_goto_snapshot(const char *name,
bool has_devices, strList *devices,
Error **errp)
{
+ERRP_GUARD();
g_autoptr(GList) bdrvs = NULL;
GList *iterbdrvs;
738,7 @@ static int coroutine_fn GRAPH_UNLOCKED
vdi_co_do_create(BlockdevCreateOptions *create_options, size_t block_size,
Error **errp)
{
+ERRP_GUARD();
BlockdevCreateOptionsVdi *vdi_opts;
int ret = 0;
uint64_t bytes = 0;
Reviewed-by: Thomas Huth
Cc: Vladimir Sementsov-Ogievskiy
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-5-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/copy-before-write.c | 1 +
1
_GUARD()").
Cc: Stefan Hajnoczi
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Message-ID: <20240311033822.3142585-10-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qed.c | 1 +
1 file changed, 1 ins
on in the commit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Eric Blake
Message-ID: <20240311033822.3142585-4-zhao1....@linux.intel.com>
Signed-off-by: Thomas Hut
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-11-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/snapshot.c | 2 ++
1 file change
mmit message of commit ae7c80a7bd73
("error: New macro ERRP_GUARD()").
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Eric Blake
Message-ID: <20240311033822.3142585-9-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
b
ed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-8-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/qcow2-bitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index 0e567ed588..87
Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Message-ID: <20240311033822.3142585-12-zhao1@linux.intel.com>
Reviewed-by: Thomas Huth
Signed-off-by: Thomas Huth
---
block/vdi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/vdi.c b/block/vdi.c
ind
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Stefan Hajnoczi
Acked-by: "Michael S. Tsirkin"
Message-ID: <20240311033822.3142585-14-zhao1@linux.intel.com>
Signed-off-by: Thomas Huth
---
hw/block/virtio-blk.c | 1 +
1 file c
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-block@nongnu.org
Signed-off-by: Zhao Liu
Reviewed-by: Vladimir Sementsov-Ogievskiy
Message-ID: <20240311033822.3142585-6-zhao1....@linux.intel.com>
Signed-off-by: Thomas Huth
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
#x27;s a real bug or whether this test should also
simply be marked to work with the "file" protocol only. Suggestions are
welcome!
Thomas Huth (9):
tests/qemu-iotests: Fix test 033 for running with non-file protocols
tests/qemu-iotests: Restrict test 066 to the 'file' p
The test fails completely when you try to use it with a different
protocol, e.g. with "./check -ssh -qcow2 156".
The test uses some hand-crafted JSON statements which cannot work with other
protocols, thus let's change this test to only support the 'file' protocol.
S
These tests 188, 189 and 198 use qemu-io with --image-opts with additional
hard-coded parameters for the file protocol, so they cannot work for other
protocols. Thus we have to limit these tests to the file protocol only.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/188 | 2 +-
tests/qemu
The hand-crafted json statement in this test only works if the test
is run with the "file" protocol, so mark this test accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/066 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/066 b/
Using "-drive ...,backing.file.filename=..." only works with the
file protocol, but not with URIs, so mark this test accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/130 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/130 b/tests/qe
(XXX YYY/sec and XXX ops/sec)
We already check for the qcow2 format here, so let's simply also
add a check for the protocol here, too, to only test the truncation
with the file protocol.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/033 | 6 +++---
1 file changed, 3 insertions(+), 3 dele
Tests 263, 284 and detect-zeroes-registered-buf use qemu-io
with --image-opts so we have to enforce IMGOPTSSYNTAX=true here
to get $TEST_IMG in shape for other protocols than "file".
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/263| 6 --
iotests/scratch/qcow2-ssh-114/t.qcow2.orig'
for writing: No such file or directory
Thus mark this test for "file protocol only" accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/114 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-io
Tests that use "--blockdev" with the "file" driver cannot work with
other protocols, so we should mark them accordingly.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/tests/qcow2-internal-snapshots | 2 +-
tests/qemu-iotests/tests/qsd-jobs | 2 +-
encryption")
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/134 | 2 +-
tests/qemu-iotests/158 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/134 b/tests/qemu-iotests/134
index ded153c0b9..b2c3c03f08 100755
--- a/tests/qemu-iotests/134
+++ b/tests/q
gitlab.com/qemu-project/qemu/-/issues/2228
Fixes: 27a2c66c92ec ("aspeed/smc: Wire CS lines at reset")
Reported-by: Thomas Huth
Signed-off-by: Cédric Le Goater
---
Thanks!
Reviewed-by: Thomas Huth
Tested-by: Thomas Huth
Tests 157 and 227 use the virtio-blk device, so we have to mark these
tests accordingly to be skipped if this devices is not available (e.g.
when running the tests with qemu-system-avr only).
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/157 | 2 ++
tests/qemu-iotests/227 | 2 ++
2 files
On 19/01/2024 17.18, Peter Maydell wrote:
On Fri, 19 Jan 2024 at 15:26, Peter Maydell wrote:
(Also, we should probably put an entry for sh4 in machine_map,
because the default board type (shix) is about to be deprecated,
and the r2d board type is thus a better choice.)
The good news is if we
ned-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Thomas Huth
On 27/03/2024 11.55, Philippe Mathieu-Daudé wrote:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2. Time to remove it.
Keep the RAM_SAVE_FLAG_HOOK definition since it might appears
in old migration stre
Now that we switched all consumers of the URI code to use the URI
parsing functions from glib instead, we can remove our internal
URI parsing code since it is not used anymore.
Signed-off-by: Thomas Huth
---
include/qemu/uri.h | 99 ---
util/uri.c | 1466
1101 - 1200 of 1302 matches
Mail list logo
