ndex a5643d33e7..2a58f9a058 100644
> --- a/tests/tcg/README
> +++ b/tests/tcg/README
> @@ -10,6 +10,6 @@ with "make test-cris".
>
> LM32
>
> -The testsuite for LM32 is in tests/tcg/cris. You can run it
> +The testsuite for LM32 is in tests/tcg/lm32. You can run it
> with "make test-lm32".
Reviewed-by: Thomas Huth
The same definitions can also be found in include/hw/ide/ahci.h
so let's remove these #defines from ahci_internal.h.
Signed-off-by: Thomas Huth
---
hw/ide/ahci_internal.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/hw/ide/ahci_internal.h b/hw/ide/ahci_internal.h
index ce
The same definitions can also be found in include/hw/ide/ahci.h
so let's remove these #defines from ahci_internal.h.
Signed-off-by: Thomas Huth
---
v2: Also remove TYPE_ICH9_AHCI as suggested by John
hw/ide/ahci_internal.h | 12
1 file changed, 12 deletions(-)
diff --git
On 06.12.2017 23:16, John Snow wrote:
> I tweaked this again, sorry:
>
> The names need to stay public, but the wrappers to manipulate the
> objects can stay internal. Minor difference.
>
> If that's okay, I'll just merge this in.
> OK?
Sure. Feel also free to replace my "Signed-off-by" with "Re
Remove the deprecated "-drive boot" and "-hdachs" options and properly
mark some other deprecated options in the deprecation chapter.
Thomas Huth (3):
block: Remove the obsolete -drive boot=on|off parameter
block: Remove the deprecated -hdachs option
block: Mention -d
Looks like we forgot to announce the deprecation of these options in
the corresponding chapter of the qemu-doc text, so let's do that now.
Signed-off-by: Thomas Huth
---
qemu-doc.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/qemu-doc.texi b/qemu-doc.texi
It's not working anymore since QEMU v1.3.0 - time to remove it now.
Signed-off-by: Thomas Huth
---
blockdev.c| 11 ---
qemu-doc.texi | 6 --
2 files changed, 17 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 56a6b24..c21ba27 100644
--- a/blockdev.c
+++ b/block
It's been marked as deprecated since QEMU v2.10.0, and so far nobody
complained that we should keep it, so let's remove this legacy option
now to simplify the code quite a bit.
Signed-off-by: Thomas Huth
---
qemu-doc.texi | 8 --
qemu-options.hx | 19 ++---
vl.c
On 20.12.2017 22:40, John Snow wrote:
>
>
> On 12/18/2017 12:14 PM, Thomas Huth wrote:
>> Remove the deprecated "-drive boot" and "-hdachs" options and properly
>> mark some other deprecated options in the deprecation chapter.
>>
>> Thomas Hut
t; diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 85d2406400..811084b6a7 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -35,6 +35,7 @@
> #include "sysemu/block-backend.h"
>
> #include "qemu/log.h"
> +#include "qemu/cutils.h"
> #include "trace.h"
> #include "nvme.h"
Reviewed-by: Thomas Huth
After reviewing a patch from Philippe that removes block-backend.h
from hw/lm32/milkymist.c, I noticed that this header is included
unnecessarily in a lot of other files, too. Remove those unneeded
includes to speed up the compilation process a little bit.
Signed-off-by: Thomas Huth
---
hw/arm
e. Time to remove this now.
Suggested-by: Markus Armbruster
Signed-off-by: Thomas Huth
---
hw/i386/pc.c | 17 -
hw/i386/pc_piix.c | 4
hw/i386/pc_q35.c | 3 ---
hw/scsi/lsi53c895a.c | 2 +-
hw/scsi/scsi-bus.
On 06.03.2018 17:45, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia
> ---
> tests/qemu-iotests/051.pc.out | 20
> tests/qemu-iotests/186.out| 22 +++---
> 2 files changed, 3 insertions(+), 39 deletions(-)
>
> diff --git a/tests/qemu-iotests/051.pc.
On 15.02.2018 09:55, Thomas Huth wrote:
> After reviewing a patch from Philippe that removes block-backend.h
> from hw/lm32/milkymist.c, I noticed that this header is included
> unnecessarily in a lot of other files, too. Remove those unneeded
> includes to speed up the compilati
On 09/05/2019 20.08, Max Reitz wrote:
> On 02.05.19 10:45, Thomas Huth wrote:
>> People often forget to run the iotests before submitting patches or
>> pull requests - this is likely due to the fact that we do not run the
>> tests during our mandatory "make check"
On 09/05/2019 18.59, Alex Bennée wrote:
> This attempts to clean-up the output to better match the output of the
> rest of the QEMU check system. This includes:
>
> - formatting as " TESTiotest: nnn"
> - calculating time diff at the end
> - only dumping config on failure
>
> Signed-off
On 08/05/2019 07.47, Thomas Huth wrote:
> On 07/05/2019 17.50, Eric Blake wrote:
>> On 5/7/19 10:22 AM, Thomas Huth wrote:
>>> On 07/05/2019 15.22, Markus Armbruster wrote:
>>>> Thomas Huth writes:
>>>>
>>>>> Currently, all tests are i
uot;root").
So let's use the "auto" group for this class of tests now. The initial
list has been determined by running the iotests with non-x86 QEMU targets
and with our CI pipelines on Gitlab, Cirrus-CI and Travis (i.e. including
macOS and FreeBSD).
Signed-off-by: Thomas Huth
--
On 10/05/2019 12.29, Alex Bennée wrote:
> This attempts to clean-up the output to better match the output of the
> rest of the QEMU check system when called with -pretty. This includes:
>
> - formatting as " TESTiotest: nnn"
> - calculating time diff at the end
> - only dumping config o
On 10/05/2019 13.10, Alex Bennée wrote:
>
> Thomas Huth writes:
>
>> On 10/05/2019 12.29, Alex Bennée wrote:
>>> This attempts to clean-up the output to better match the output of the
>>> rest of the QEMU check system when called with -pretty. This includes:
On 10/05/2019 12.48, Thomas Huth wrote:
[...]
>
> I think the "make check" mode should only print out one time for each
> test, preferable at the end, like the other tests (like qtests) are
> doing it...?
s/preferable at the end/preferably at the beginning/
... I think
On 10/05/2019 15.34, Max Reitz wrote:
> On 10.05.19 06:29, Thomas Huth wrote:
>> On 09/05/2019 20.08, Max Reitz wrote:
>>> On 02.05.19 10:45, Thomas Huth wrote:
>>>> People often forget to run the iotests before submitting patches or
>>>> pull requests -
On 10/05/2019 15.47, Max Reitz wrote:
> On 10.05.19 15:36, Thomas Huth wrote:
>> On 10/05/2019 15.34, Max Reitz wrote:
>>> On 10.05.19 06:29, Thomas Huth wrote:
>>>> On 09/05/2019 20.08, Max Reitz wrote:
>>>>> On 02.05.19 10:45, Thomas Huth wrote:
On 10/05/2019 15.54, Max Reitz wrote:
> On 28.04.19 17:18, Thomas Huth wrote:
>> QEMU iotest 175 is failing for me when I run it with -raw:
>>
>> $ ./check -raw 175
>> QEMU --
>> "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../x86_64-soft
="-nodefaults -machine accel=qtest"
> +export QEMU_OPTIONS="-nodefaults -machine accel=qtest -display none"
> export VALGRIND_QEMU=
> export IMGKEYSECRET=
> export IMGOPTSSYNTAX=false
>
Reviewed-by: Thomas Huth
Am Sun, 26 May 2019 00:50:05 +0200
schrieb Laurent Vivier :
> There is no DMA in Quadra 800, so the CPU reads/writes the data from
> the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and
> copies them to/from the memory.
>
> There is a nice assembly loop in the kernel to do that, see
>
Signed-off-by: Laurent Vivier
> Reviewed-by: Hervé Poussineau
> ---
> hw/char/escc.c | 30 --
> include/hw/char/escc.h | 1 +
> 2 files changed, 25 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
Am Sun, 26 May 2019 00:50:13 +0200
schrieb Laurent Vivier :
> If you want to test the machine, it doesn't yet boot a MacROM, but
> you can boot a linux kernel from the command line.
>
> You can install your own disk using debian-installer with:
>
> ./qemu-system-m68k \
> -M q800 \
>
On 12/07/2019 19.36, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/259 | 61 ++
> tests/qemu-iotests/259.out | 14 +
> tests/qemu-iotests/group | 1 +
> 3 files changed, 76 insertions(+)
> create mode 100755 tests/qemu-i
First patch removes some more problematic tests from the "auto" group,
so that we can finally enable the "iotests" during "make check" in the
second patch.
Thomas Huth (2):
tests/qemu-iotests/group: Remove some more tests from the "auto" group
tests: R
k.sh script since we do not need that anymore
(and having two shell wrapper scripts around the block tests seems rather
confusing than helpful).
Signed-off-by: Thomas Huth
[AJB: -makecheck to check-block.sh, move check-block to start and gate it]
Signed-off-by: Alex Bennée
---
tests/Makefile.in
Remove some more tests from the "auto" group that either have issues
in certain environments (like macOS or FreeBSD, or on certain file systems
like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
taking too much time.
Signed-off-by: Thomas Huth
---
tests/qemu-iot
On 15/07/2019 17.12, Eric Blake wrote:
> On 7/15/19 9:54 AM, Thomas Huth wrote:
>> Remove some more tests from the "auto" group that either have issues
>> in certain environments (like macOS or FreeBSD, or on certain file systems
>> like ZFS or tmpfs), do not work
On 15/07/2019 19.17, Max Reitz wrote:
> On 15.07.19 17:18, Thomas Huth wrote:
>> On 15/07/2019 17.12, Eric Blake wrote:
>>> On 7/15/19 9:54 AM, Thomas Huth wrote:
>>>> Remove some more tests from the "auto" group that either have issues
>>>> i
k.sh script since we do not need that anymore
(and having two shell wrapper scripts around the block tests seems rather
confusing than helpful).
Signed-off-by: Thomas Huth
[AJB: -makecheck to check-block.sh, move check-block to start and gate it]
Signed-off-by: Alex Bennée
---
tests/Makefile.in
re tests from the "auto" group, like 197 and 215 which
were sometimes causing the CI pipelines to fail on gitlab
- Added a patch to remove the "duplicated" tests from the gitlab-ci.yml
file.
Thomas Huth (4):
tests/qemu-iotests/check: Allow tests without groups
tests/q
e spaces
at the end of lines automatically.
Thus let's fix the regular expressions so that it is also possible to
have lines with one test number only in the group file.
Suggested-by: Max Reitz
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/check | 4 ++--
1 file changed, 2 insert
Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 248 instead.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 12 +++-
Remove some more tests from the "auto" group that either have issues
in certain environments (like macOS or FreeBSD, or on certain file systems
like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
taking too much time.
Signed-off-by: Thomas Huth
---
tests/qemu-iot
On 16/07/2019 17.26, Max Reitz wrote:
> On 16.07.19 14:28, Thomas Huth wrote:
>> Remove some more tests from the "auto" group that either have issues
>> in certain environments (like macOS or FreeBSD, or on certain file systems
>> like ZFS or tmpfs), do not work wit
On 16/07/2019 17.41, Max Reitz wrote:
> On 16.07.19 14:28, Thomas Huth wrote:
>> Since most iotests are now run during "make check" already, we do not
>> need to test them explicitly from the gitlab-ci.yml script anymore.
>> And while we're at it, add some of t
On 16/07/2019 17.37, Max Reitz wrote:
> On 16.07.19 14:28, Thomas Huth wrote:
>> People often forget to run the iotests before submitting patches or pull
>> requests - this is likely due to the fact that we do not run the tests
>> during our mandatory "make check"
e spaces
at the end of lines automatically.
Thus let's fix the regular expressions so that it is also possible to
have lines with one test number only in the group file.
Suggested-by: Max Reitz
Reviewed-by: Alex Bennée
Reviewed-by: Max Reitz
Signed-off-by: Thomas Huth
---
tests/qemu-iotes
Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 246 instead.
Signed-off-by: Thomas Huth
---
.gitlab-ci.yml | 13 -
Remove some more tests from the "auto" group that either have issues
in certain environments (like macOS or FreeBSD, or on certain file systems
like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
taking too much time.
Reviewed-by: Max Reitz
Signed-off-by: T
not support migration)
v2:
- Added new patch to allow tests without groups, removed the "o_direct"
group again.
- Removed some more tests from the "auto" group, like 197 and 215 which
were sometimes causing the CI pipelines to fail on gitlab
- Added a patch to remove
k.sh script since we do not need that anymore
(and having two shell wrapper scripts around the block tests seems rather
confusing than helpful).
Signed-off-by: Thomas Huth
[AJB: -makecheck to check-block.sh, move check-block to start and gate it]
Signed-off-by: Alex Bennée
---
tests/Makefile.incl
FWIW, I've got a new iotest failure with current master branch:
$ ./check -qed 141
QEMU --
"/tmp/qemu/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64"
-nodefaults -machine accel=qtest
QEMU_IMG -- "/tmp/qemu/tests/qemu-iotests/../../qemu-img"
QEMU_IO -- "/tmp/qemu/
On 16/07/2019 18.12, Max Reitz wrote:
> On 16.07.19 18:09, Eric Blake wrote:
>> On 7/16/19 10:58 AM, Max Reitz wrote:
[...]
Is there any way to create our sockets somewhere under /tmp instead of
inside tests/qemu-iotests, so that we have a shorter filename for
sockets no matter how d
Not sure if it has been reported before, but test 059 currently fails:
059 fail [14:55:21] [14:55:26]output
mismatch (see 059.out.bad)
--- /home/thuth/devel/qemu/tests/qemu-iotests/059.out 2019-07-19
10:19:18.0 +0200
+++ /home/thuth/tmp/qemu-build/tests/qem
ay,
let's simply use the built-in double parentheses for the for-loops
instead.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/007| 2 +-
tests/qemu-iotests/011| 2 +-
tests/qemu-iotests/032| 2 +-
tests/qemu-iotests/035| 2 +-
tests/qemu-i
In case somebody is interested, two of the "auto" iotests are failing
on NetBSD due to non-matching output:
TESTiotest-qcow2: 069 [fail]
--- /var/tmp/qemu-test.1BMupF/tests/qemu-iotests/069.out2019-07-24
09:19:22.0 +
+++ /var/tmp/qemu-test.1BMupF/tests/qemu-iotests/069.o
On 24/07/2019 18.29, Paolo Bonzini wrote:
> On 24/07/19 11:34, Thomas Huth wrote:
>> In case somebody is interested, two of the "auto" iotests are failing
>> on NetBSD due to non-matching output:
>>
>> TESTiotest-qcow2: 069 [fail]
>> --- /var/tmp/
On 29/07/2019 14.46, Andrey Shinkevich wrote:
> This patch is to reduce the number of Valgrind report messages about
> using uninitialized memory with the null-co driver. It helps to filter
> real memory issues and is the same work done for the iotests with the
> commit ID a6862418fec4072.
>
> Sug
On 30/07/2019 14.52, Thomas Huth wrote:
> On 29/07/2019 14.46, Andrey Shinkevich wrote:
>> This patch is to reduce the number of Valgrind report messages about
>> using uninitialized memory with the null-co driver. It helps to filter
>> real memory issues and is the same work
On 8/12/19 9:16 PM, John Snow wrote:
>
>
> On 7/25/19 4:34 AM, Thomas Huth wrote:
>> On 24/07/2019 18.29, Paolo Bonzini wrote:
>>> On 24/07/19 11:34, Thomas Huth wrote:
>>>> In case somebody is interested, two of the "auto" iotests are fai
On 8/12/19 9:20 PM, Max Reitz wrote:
> On 12.08.19 21:14, John Snow wrote:
>>
>>
>> On 7/22/19 8:58 AM, Thomas Huth wrote:
>>> Not sure if it has been reported before, but test 059 currently fails:
>>>
>>> 059 fail [14:55:21] [14:55:26]
On 7/30/19 3:23 PM, Andrey Shinkevich wrote:
>
>
> On 30/07/2019 15:59, Thomas Huth wrote:
>> On 30/07/2019 14.52, Thomas Huth wrote:
>>> On 29/07/2019 14.46, Andrey Shinkevich wrote:
>>>> This patch is to reduce the number of Valgrind report messages about
The libqos library functions should never depend on global_qtest,
since these functions might be used in tests that track multiple
test states. So let's use the test state of the QPCIDevice instead.
Signed-off-by: Thomas Huth
---
tests/libqos/virtio-pci.c | 8
1 file chang
depend on global_qtest or functions that rely on this variable.
This patch series gets rid of these dependencies in most of the libqtest
and libqos code.
Thomas Huth (6):
tests/libqos: Make generic virtio code independent from global_qtest
tests/libqos: Make virtio-pci code independent from
No test is using hmp() anymore, and since this function uses the disliked
global_qtest variable, we should also make sure that nobody adds new code
with this function again. qtest_hmp() should be used instead.
Signed-off-by: Thomas Huth
---
tests/libqtest.c | 11 ---
tests/libqtest.h
The libqos library functions should never depend on global_qtest,
since these functions might be used in tests that track multiple
test states. Pass around a pointer to the QTestState instead.
Signed-off-by: Thomas Huth
---
tests/libqos/virtio.c| 74 ++-
tests/libqos
The generic libqtest library functions should not use functions that
require the global_qtest variable.
Signed-off-by: Thomas Huth
---
tests/libqtest.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 3e9245d4c9..d1aead30ed
The normal libqtest library functions should never depend on global_qtest.
Pass in the test state via parameter instead. And while we're at it,
also rename this function to qtest_qmp_assert_success() to make it clear
that it is part of libqtest.
Signed-off-by: Thomas Huth
---
tests/libqt
Generic library functions like qtest_qmp_device_add() and _del()
should not depend on the global_qtest variable. Pass the test
state via parameter instead.
Signed-off-by: Thomas Huth
---
tests/cpu-plug-test.c | 15 +--
tests/e1000e-test.c| 2 +-
tests/ivshmem-test.c
On 8/13/19 5:20 PM, Eric Blake wrote:
> On 8/13/19 4:30 AM, Thomas Huth wrote:
>> No test is using hmp() anymore, and since this function uses the disliked
>> global_qtest variable, we should also make sure that nobody adds new code
>> with this function again. qtest_hmp() s
On 8/16/19 9:37 AM, tony.ngu...@bt.com wrote:
> Simplify endianness comparisons with consistent use of the more
> expressive MemOp.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Tony Nguyen
> Reviewed-by: Richard Henderson
> Acked-by: David Gibson
This patch is *huge*, more than 800kB.
pen_common and raw_normalize_devicepath; in fact, we can even
use error_setg_file_open to make sure the error message is the same as in
the rest of QEMU.
Message-Id: <20190725095920.28419-1-pbonz...@redhat.com>
Tested-by: Thomas Huth
Signed-off-by: Paolo Bonzini
Reviewed-by: Philippe Mathi
t during "make check"
Paolo Bonzini (1):
block: fix NetBSD qemu-iotests failure
Thomas Huth (2):
tests: Run the iotests during "make check" again
gitlab-ci: Remove qcow2 tests that are handled
k.sh script since we do not need that anymore
(and having two shell wrapper scripts around the block tests seems rather
confusing than helpful).
Message-Id: <20190717111947.30356-4-th...@redhat.com>
Signed-off-by: Thomas Huth
[AJB: -makecheck to check-block.sh, move check-block to start
Since most iotests are now run during "make check" already, we do not
need to test them explicitly from the gitlab-ci.yml script anymore.
And while we're at it, add some of the new non-auto tests >= 246 instead.
Message-Id: <20190717111947.30356-5-th...@redhat.com>
Si
f certain drivers first,
and marks the test as "not run" if one of the drivers is missing.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/071 | 1 +
tests/qemu-iotests/081 | 1 +
tests/qemu-iotests/099 | 1 +
tests/qemu-iotests/184 | 1 +
tests/qemu-iot
The python code already contains a possibility to skip tests if the
corresponding driver is not available in the qemu binary - use it
in more spots to avoid that the tests are failing if the driver has
been disabled.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/030 | 3 +++
tests/qemu
"-nodefaults -machine
> tricore_testboard,accel=qtest"
> +export QEMU_OPTIONS="-nodefaults -display none -machine
> tricore_testboard,accel=qtest"
> ;;
> *)
> -export QEMU_OPTIONS="-nodefaults -machine accel=qtest"
> +export QEMU_OPTIONS="-nodefaults -display none -machine accel=qtest"
> ;;
> esac
Reviewed-by: Thomas Huth
On 8/19/19 10:18 PM, Max Reitz wrote:
> null-aio may not be whitelisted. Skip all test cases that require it.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/093 | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/093 b/tests/qemu-io
/qemu-iotests/245
> index bc1ceb9792..ae169778b0 100644
> --- a/tests/qemu-iotests/245
> +++ b/tests/qemu-iotests/245
> @@ -598,7 +598,7 @@ class TestBlockdevReopen(iotests.QMPTestCase):
> ##
> ## null ##
> ######
> -opts = {'driver': 'null-aio', 'node-name': 'root', 'size': 1024}
> +opts = {'driver': 'null-co', 'node-name': 'root', 'size': 1024}
>
> result = self.vm.qmp('blockdev-add', conv_keys = False, **opts)
> self.assert_qmp(result, 'return', {})
>
Reviewed-by: Thomas Huth
On 8/19/19 9:13 PM, Max Reitz wrote:
> On 19.08.19 11:21, Thomas Huth wrote:
>> The python code already contains a possibility to skip tests if the
>> corresponding driver is not available in the qemu binary - use it
>> in more spots to avoid that the tests are failing if t
On 8/20/19 5:01 PM, Max Reitz wrote:
> On 19.08.19 09:53, Thomas Huth wrote:
>> It is possible to enable only a subset of the block drivers with the
>> "--block-drv-rw-whitelist" option of the "configure" script. All other
>> drivers are marked as unusabl
On 8/20/19 8:48 PM, Max Reitz wrote:
> On 20.08.19 18:01, Thomas Huth wrote:
[...]
>> Well, we disable blkverify in our downstream RHEL version of QEMU - so
>> it would be great if the iotests could at least adapt to that missing
>> driver.
>
> I would like to say that
On 8/23/19 12:34 AM, Paolo Bonzini wrote:
> On 17/08/19 10:54, Thomas Huth wrote:
>> People often forget to run the iotests before submitting patches or pull
>> requests - this is likely due to the fact that we do not run the tests
>> during our mandatory "make check"
U with --enable-sanitizers.
Signed-off-by: Thomas Huth
---
tests/check-block.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/check-block.sh b/tests/check-block.sh
index c8b6cec3f6..679aedec50 100755
--- a/tests/check-block.sh
+++ b/tests/check-block.sh
@@ -21,6 +21,11 @@ if grep -q
On 8/23/19 9:12 AM, Thomas Huth wrote:
> On 8/23/19 12:34 AM, Paolo Bonzini wrote:
>> On 17/08/19 10:54, Thomas Huth wrote:
>>> People often forget to run the iotests before submitting patches or pull
>>> requests - this is likely due to the fact that we do not r
On 8/23/19 11:04 AM, Peter Maydell wrote:
> On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote:
>>
>> The sanitizers (especially the address sanitizer from Clang) are
>> sometimes printing out warnings or false positives - this spoils
>> the output of the iotests, causin
On 8/23/19 11:53 AM, Peter Maydell wrote:
> On Fri, 23 Aug 2019 at 10:35, Thomas Huth wrote:
>>
>> On 8/23/19 11:04 AM, Peter Maydell wrote:
>>> On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote:
>>>>
>>>> The sanitizers (especially the address sanit
quot;qcow2" and "file"
drivers are always available - otherwise it does not make sense to
run "make check-block" at all (which only tests with qcow2 by default).
Signed-off-by: Thomas Huth
---
v2:
- Update the check in _require_drivers() according to Max' suggestion
-
s->buf_align = (align != 1) ? align :
> bs->bl.request_alignment;
> break;
> }
>
Reviewed-by: Thomas Huth
mu-kvm" in RHEL), so
providing more flexibility here would also be good. Thus let's define
some variables for the names of the QEMU command and use those in the
documentation instead: @value{qemu_system} for generic examples, and
@value{qemu_system_x86} for examples that only work with
On 28/08/2019 21.18, John Snow wrote:
>
>
> On 8/28/19 5:34 AM, Thomas Huth wrote:
>> In our documentation, we use a mix of "$QEMU", "qemu-system-i386" and
>> "qemu-system-x86_64" when we give examples to the users how to run
>>
On 03/09/2019 14.55, Max Reitz wrote:
> On 23.08.19 15:35, Thomas Huth wrote:
>> It is possible to enable only a subset of the block drivers with the
>> "--block-drv-rw-whitelist" option of the "configure" script. All other
>> drivers are marked as unusabl
The check script is already printing out which iotest is currently
running, so printing out the name of the check-block.sh shell script
looks superfluous here.
Signed-off-by: Thomas Huth
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
the output might be mixed with the other tests. Thus change the
word "tests" here to "iotests" instead to avoid confusion.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/check | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotest
On 10/09/2019 12.53, Max Reitz wrote:
> On 06.09.19 13:35, Thomas Huth wrote:
>> The check script is already printing out which iotest is currently
>> running, so printing out the name of the check-block.sh shell script
>> looks superfluous here.
>>
>> Signed-off-
On 11/09/2019 08.58, Kevin Wolf wrote:
> Am 10.09.2019 um 21:07 hat Eric Blake geschrieben:
>> On 9/10/19 1:58 PM, Thomas Huth wrote:
>>> Our "tests" directory is very overcrowded - we store the qtests,
>>> unit test and other files there. That makes it
On 11/09/2019 10.54, Kevin Wolf wrote:
> Am 11.09.2019 um 10:01 hat Thomas Huth geschrieben:
>> On 11/09/2019 08.58, Kevin Wolf wrote:
>>> Am 10.09.2019 um 21:07 hat Eric Blake geschrieben:
>>>> On 9/10/19 1:58 PM, Thomas Huth wrote:
>>>>> Our "t
[ "$(head -n 1 "$source_iotests/$seq")" == "#!/usr/bin/env
> python" ]; then
> -run_command="$PYTHON $seq"
> +if $python_usable; then
> +run_command="$PYTHON $seq"
> + else
> +run_command="false"
> +echo "Unsupported Python version" > $seq.notrun
> +fi
> else
> run_command="./$seq"
> fi
>
Reviewed-by: Thomas Huth
On 18/09/2019 00.29, John Snow wrote:
>
>
> On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote:
[...]
>> Finally do we support something except linux for iotests?
>> for bash tests _supported_os also used only with "Linux" in 87 tests..
The iotests in the "auto" group are supposed to work o
$seq"
> +if $python_usable; then
> +run_command="$PYTHON $seq"
> +else
> + run_command="false"
> +echo "Unsupported Python version" > $seq.notrun
> +fi
> else
> run_command="./$seq"
> fi
>
Reviewed-by: Thomas Huth
s/qemu-iotests/nbd-fault-injector.py
> +++ b/tests/qemu-iotests/nbd-fault-injector.py
> @@ -48,10 +48,9 @@ import sys
> import socket
> import struct
> import collections
> -if sys.version_info.major >= 3:
> -import configparser
> -else:
> -import ConfigParser as configparser
> +import configparser
> +
> +assert sys.version_info >= (3,6)
>
> FAKE_DISK_SIZE = 8 * 1024 * 1024 * 1024 # 8 GB
>
Reviewed-by: Thomas Huth
On 24/09/2019 20.49, John Snow wrote:
> Nobody was making movement on this patch series, and in response to Max
> acking the whole series, I was just going to send a pull request for the
> whole thing and see who barked, because nobody likes or hates this
> series enough to offer any feedback.
>
>
On 01/10/2019 20.44, Max Reitz wrote:
[...]
> As I have said, the conceptual problem is that the iotests now run as
> part of make check. As such, allowing auto tests to run on non-Linux
> platforms may introduce build failures that I cannot do anything about.
Well, simply run "make vm-build-open
201 - 300 of 1301 matches
Mail list logo
