On 22/02/2023 00.25, Philippe Mathieu-Daudé wrote:
Since commit 262a69f428 ("osdep.h: Prohibit disabling assert()
in supported builds") we can not build QEMU with NDEBUG (or
G_DISABLE_ASSERT) defined, thus 'assert(0)' always aborts QEMU.
However some static analyzers / compilers doesn't notice N
On 22/02/2023 00.25, Philippe Mathieu-Daudé wrote:
In order to avoid warnings such commit c0a6665c3c ("target/i386:
Remove compilation errors when -Werror=maybe-uninitialized"),
replace all assert(0) and g_assert(0) by g_assert_not_reached().
Remove any code following g_assert_not_reached().
Se
On 22/02/2023 00.25, Philippe Mathieu-Daudé wrote:
In order to avoid warnings such commit c0a6665c3c ("target/i386:
Remove compilation errors when -Werror=maybe-uninitialized"),
replace all assert(0) and g_assert(0) by g_assert_not_reached().
Remove any code following g_assert_not_reached().
Se
eviewed-by: Thomas Huth
chard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Thomas Huth
, 15 insertions(+), 10 deletions(-)
Makes perfectly sense!
Reviewed-by: Thomas Huth
On 24/02/2023 22.35, Philippe Mathieu-Daudé wrote:
Hi,
On 24/2/23 19:50, Peter Maydell wrote:
On Thu, 23 Feb 2023 at 18:51, Kevin Wolf wrote:
The following changes since commit 79b677d658d3d35e1e776826ac4abb28cdce69b8:
Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into
On 28/02/2023 22.41, Philippe Mathieu-Daudé wrote:
On 28/2/23 20:06, Alex Bennée wrote:
To avoid lots of copy and paste lets deal with artefacts in a
template. This way we can filter out most of the pre-binary object and
library files we no longer need as we have the final binaries.
build-syste
On 28/02/2023 20.06, Alex Bennée wrote:
This test is exceptionally heavyweight (nearly 330s) compared to the
two (both endians) TuxRun baseline tests which complete in under 160s.
The coverage is slightly reduced but a more directed test could make
up the difference.
tests/avocado/tuxrun_baselin
The enablement of -Wthread-safety broke compilation on macOS (if
-Werror is enabled, like in our CI). Disable it there by default
until the problems are resolved.
Signed-off-by: Thomas Huth
---
configure | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b
.. to bad that I never got that merged ;-)
Anyway:
Reviewed-by: Thomas Huth
AP version 13')
self.env.print_env('# ')
print('1..%d' % len(tests))
else:
Reviewed-by: Thomas Huth
On 02/03/2023 19.46, Daniel P. Berrangé wrote:
To just repeat the patch 5 description...
Currently meson registers a single test that invokes an entire group of
I/O tests, hiding the test granularity from meson. There are various
downsides of doing this
* You cannot ask 'meson test' to invoke
On 02/03/2023 19.46, Daniel P. Berrangé wrote:
Currently meson registers a single test that invokes an entire group of
I/O tests, hiding the test granularity from meson. There are various
downsides of doing this
* You cannot ask 'meson test' to invoke a single I/O test
* The meson test timeo
On 03/03/2023 09.53, Daniel P. Berrangé wrote:
On Fri, Mar 03, 2023 at 09:30:39AM +0100, Thomas Huth wrote:
On 02/03/2023 19.46, Daniel P. Berrangé wrote:
To just repeat the patch 5 description...
Currently meson registers a single test that invokes an entire group of
I/O tests, hiding the
On 03/03/2023 14.06, Daniel P. Berrangé wrote:
On Fri, Mar 03, 2023 at 10:45:40AM +, Daniel P. Berrangé wrote:
On Fri, Mar 03, 2023 at 09:30:39AM +0100, Thomas Huth wrote:
On 02/03/2023 19.46, Daniel P. Berrangé wrote:
3) When I tried this last year, I had a weird problem that
the
avoid
this while TTY save/restore complexity we can connect the test
stdin to /dev/null instead.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/testrunner.py | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
Reviewed-by: Thomas Huth
---
1 file changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Thomas Huth
aniel P. Berrangé
---
tests/qemu-iotests/meson.build | 35 --
1 file changed, 29 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth
deletions(-)
delete mode 100755 tests/check-block.sh
Reviewed-by: Thomas Huth
++--
tests/qemu-iotests/testenv.py | 13 -
2 files changed, 27 insertions(+), 11 deletions(-)
Reviewed-by: Thomas Huth
on test case for each I/O
test. Parallel execution remains disabled since the I/O tests do not
use self contained execution environments and thus conflict with
each other.
Series
Tested-by: Thomas Huth
Hi,
I've just seen this migrate-bitmaps-postcopy-test failure
while running "make check -j5 SPEED=slow" on my laptop:
@@ -1,5 +1,13 @@
-...
+..F
+==
+FAIL: test_postcopy_success (__main__.TestDirtyBitmapPostcopyMigration)
+--
On 05/02/2023 05.07, Alexander Bulekov wrote:
This protects devices from bh->mmio reentrancy issues.
Reviewed-by: Darren Kenny
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Alexander Bulekov
---
...
diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c
index 65c4979c3c..f077c1b255
On 16/04/2021 14.52, Thomas Huth wrote:
QEMU currently crashes when the user tries to do something like:
qemu-system-x86_64 -M x-remote -device piix3-ide
It's now several months later already, and this crash has still not been
fixed yet. The next softfreeze is around the corner an
Hi,
iotest 206 fails for me with:
$ ./check -qcow2 206
QEMU -- ".../tests/qemu-iotests/../../qemu-system-x86_64"
-nodefaults -display none -accel qtest
QEMU_IMG -- ".../tests/qemu-iotests/../../qemu-img"
QEMU_IO -- ".../tests/qemu-iotests/../../qemu-io" --cache writeback
On 20/07/2021 03.12, Eric Blake wrote:
On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote:
Hi,
iotest 206 fails for me with:
--- 206.out
+++ 206.out.bad
@@ -99,55 +99,19 @@
{"execute": "blockdev-create", "arguments": {"job-id": "j
On 21/07/2021 19.22, Daniel P. Berrangé wrote:
Peter caught the following transient fail on the staging tree:
https://gitlab.com/qemu-project/qemu/-/jobs/1438817749
--- /builds/qemu-project/qemu/tests/qemu-iotests/197.out
+++ 197.out.bad
@@ -12,13 +12,12 @@
128 KiB, X ops; XX:XX:XX.X (XXX
huge reads (which is likely also the reason
why they haven't been added to the "auto" group in the past), so let's
simply disable them in the gitlab-CI now, too.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/buildtest.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
vhost-user-blk-test needs the qemu-storage-deamon, otherwise it
currently hangs. So make sure that we build the daemon before running
the tests.
Signed-off-by: Thomas Huth
---
storage-daemon/meson.build | 8
tests/qtest/meson.build| 7 +--
2 files changed, 9 insertions(+), 6
The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY
points to a non-existing binary. Let's improve this situation by checking
for the availability of the binary first, so we can fail gracefully if
it is not accessible.
Signed-off-by: Thomas Huth
---
tests/qtest/
dge->dest = g_strdup(dest);
edge->edge_name = g_strdup(opts->edge_name ?: dest);
-edge->arg = g_memdup(opts->arg, opts->size_arg);
+edge->arg = g_memdup2(opts->arg, opts->size_arg);
edge->before_cmd_line =
opts->before_cmd_line ? g_strc
On 29/09/2021 07.30, ~farzon wrote:
From: Farzon Lotfi
Hi!
Thanks for your contribution! However, there are some more rules that need
to be followed to get a patch accepted in the QEMU project:
Please provide a proper patch description for your changes (something like:
"QEMU coding style
ere could cause quite some trouble during runtime.
Suggested-by: Kevin Wolf
Signed-off-by: Thomas Huth
---
block/vpc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/vpc.c b/block/vpc.c
index dc0ad9fcdc..ec55d69360 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -286,7 +28
On 19/05/2021 12.56, Kevin Wolf wrote:
[...]
We have a bug in vpc_open(), though: It sets the local variable
disk_type correctly, but other functions use s->footer.type instead and
we never check that it actually matches the disk type we think we're
opening.
So I think we need to add this check
On 11/08/2021 13.08, Peter Maydell wrote:
On Wed, 11 Aug 2021 at 11:00, Thomas Huth wrote:
The vhost-user-blk-test currently hangs if QTEST_QEMU_STORAGE_DAEMON_BINARY
points to a non-existing binary. Let's improve this situation by checking
for the availability of the binary first, so w
On 15/10/2021 12.07, Paolo Bonzini wrote:
Hi all,
Starting with Meson 0.57, "meson test" has all features of QEMU's
makefile-based harness and more.
I just gave it a try, and basically I like this ... but I also encountered
two issues:
* CTRL+C will only interrupt the longest running test.
INERS b/MAINTAINERS
index 00626941f1..174425a941 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1829,7 +1829,7 @@ S: Odd Fixes
F: hw/9pfs/
X: hw/9pfs/xen-9p*
F: fsdev/
-F: docs/interop/virtfs-proxy-helper.rst
+F: docs/tools/virtfs-proxy-helper.rst
FWIW:
Reviewed-by: Thomas Huth
ative impact, thus:
Reviewed-by: Thomas Huth
-
4 files changed, 6 insertions(+), 69 deletions(-)
Patch looks reasonable to me.
Reviewed-by: Thomas Huth
.c
+++ b/hw/sparc64/sun4u.c
@@ -749,7 +749,6 @@ static char *sun4u_fw_dev_path(FWPathProvider *p, BusState
*bus,
DeviceState *dev)
{
PCIDevice *pci;
-int bus_id;
if (!strcmp(object_get_typename(OBJECT(dev)), "pbm-bridge")) {
pci = PCI_DEVICE(dev);
Please squash this hunk into the 'ide-drive' patch instead.
With the two nits fixed:
Reviewed-by: Thomas Huth
On 18/03/2021 18.28, Max Reitz wrote:
[...]
From that it follows that I don’t see much use in testing specific devices
either. Say there’s a platform that provides both virtio-pci and
virtio-mmio, the default (say virtio-pci) is fine for the iotests. I see
little value in testing virtio-mmio
Laurent Vivier
---
softmmu/qdev-monitor.c | 46 +++---
1 file changed, 30 insertions(+), 16 deletions(-)
With the typo mentioned by Philippe fixed:
Reviewed-by: Thomas Huth
On 19/03/2021 11.50, Laurent Vivier wrote:
Le 19/03/2021 à 10:20, Max Reitz a écrit :
On 19.03.21 07:32, Thomas Huth wrote:
On 18/03/2021 18.28, Max Reitz wrote:
[...]
From that it follows that I don’t see much use in testing specific devices
either. Say there’s
a platform that provides
| 3 ++-
tests/qemu-iotests/256| 6 --
tests/qemu-iotests/common.rc | 13 +
tests/qemu-iotests/iotests.py | 5 +
4 files changed, 24 insertions(+), 3 deletions(-)
Reviewed-by: Thomas Huth
nchpad.net/qemu/+bug/1819182
Signed-off-by: Thomas Huth
---
I've marked the subject with RFC since I'm not quite sure whether this
is really a good idea... please let me know what you think about it...
block/vpc.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
d
On 06/04/2021 09.24, Klaus Jensen wrote:
On Apr 6 09:10, Philippe Mathieu-Daudé wrote:
On 4/5/21 7:54 PM, Klaus Jensen wrote:
From: Klaus Jensen
The Non-MDTS DMSRL limit must be recomputed when namespaces are
detached.
Fixes: 645ce1a70cb6 ("hw/block/nvme: support namespace attachment comman
rlier
fallocate(FALLOC_FL_ZERO_RANGE) call, so do it now similar with the
PUNCH_HOLE call.
Signed-off-by: Thomas Huth
---
block/file-posix.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 20e14f8e96..7a40428d52 100644
--- a/block/file-posi
so we can fail there gracefully.
Signed-off-by: Thomas Huth
---
hw/ide/ioport.c | 16 ++--
hw/ide/piix.c | 22 +-
hw/isa/isa-bus.c | 14 ++
include/hw/ide/internal.h | 2 +-
include/hw/isa/isa.h | 13
On 16/04/2021 22.34, Nir Soffer wrote:
On Fri, Apr 16, 2021 at 8:23 AM Thomas Huth wrote:
A customer reported that running
qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2
fails for them with the following error message when the images are
stored on a GPFS file system
On 19/04/2021 21.27, Klaus Jensen wrote:
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
I think it
On 19/04/2021 21.27, Klaus Jensen wrote:
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/block
On 19/04/2021 21.27, Klaus Jensen wrote:
From: Klaus Jensen
Get rid of the (reserved) double underscore use.
Cc: Philippe Mathieu-Daudé
Cc: Thomas Huth
Signed-off-by: Klaus Jensen
---
hw/block/nvme.c | 47 +++
1 file changed, 23 insertions
On 28/04/2021 11.24, Stefan Hajnoczi wrote:
On Fri, Apr 16, 2021 at 02:52:56PM +0200, Thomas Huth wrote:
@@ -158,7 +166,11 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error
**errp)
vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d);
-pci_piix_init_por
On 23/01/2021 11.03, P J P wrote:
From: Prasad J Pandit
While processing ioport command in 'fdctrl_write_dor', device
controller may select a drive which is not initialised with a
block device. This may result in a NULL pointer dereference.
Add checks to avoid it.
Fixes: CVE-2021-20196
Reporte
On 19/04/2021 07.06, Thomas Huth wrote:
On 16/04/2021 22.34, Nir Soffer wrote:
On Fri, Apr 16, 2021 at 8:23 AM Thomas Huth wrote:
A customer reported that running
qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2
fails for them with the following error message when the
On 29/03/2021 09.25, Thomas Huth wrote:
Fixed-size VHD images don't have a header, only a footer. To be able
to still detect them right, support probing via the file name, too.
Without this change, images get detected as raw:
$ qemu-img create -f vpc -o subformat=fixed test.vhd 2G
Forma
On 19/05/2021 12.21, Thomas Huth wrote:
On 19/04/2021 07.06, Thomas Huth wrote:
On 16/04/2021 22.34, Nir Soffer wrote:
On Fri, Apr 16, 2021 at 8:23 AM Thomas Huth wrote:
A customer reported that running
qemu-img convert -t none -O qcow2 -f qcow2 input.qcow2 output.qcow2
fails for them
us we really should ignore the libssh in Ubuntu 18.04 in QEMU, too.
Fix it by bumping the minimum libssh version to something that is
greater than 0.8.0 now. Debian Buster and openSUSE Leap have the
oldest version and so 0.8.7 is the new minimum.
Signed-off-by: Thomas Huth
---
block/ssh.c
the handling for ZERO_RANGE a little bit so that we now also try the other
fallbacks in this case now.
Thomas Huth (2):
block/file-posix: Fix problem with fallocate(PUNCH_HOLE) on GPFS
block/file-posix: Try other fallbacks after invalid
FALLOC_FL_ZERO_RANGE
block/file-posix.c | 28
ately and try the others first.
Since FALLOC_FL_ZERO_RANGE could also return EINVAL if the file descriptor
is not a regular file, we ignore this filesystem bug silently, without
printing an error message for the user.
Signed-off-by: Thomas Huth
---
block/file-posix.c | 18 +-
1
instead.
Signed-off-by: Thomas Huth
---
block/file-posix.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 10b71d9a13..134ff01d82 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -1650,6 +1650,16 @@ static int handle_aio
ONLY);
+g_assert_cmpint(fd, ==, 0);
close(1);
-open("/dev/null", O_RDONLY);
-open("/dev/null", O_WRONLY);
+fd = open("/dev/null", O_WRONLY);
+g_assert_cmpint(fd, ==, 1);
execlp("/bin/sh", "sh", "-c", storage_daemon_command->str, NULL);
exit(1);
Reviewed-by: Thomas Huth
gent_cb_grab_type(GET_NAME(type_name, *(uint32_t
*)data));
switch (*(uint32_t *)data) {
Reviewed-by: Thomas Huth
In downstream, we want to use a different name for the QEMU binary,
and some people might also use the docs for non-x86 binaries, that's
why we already created the |qemu_system| placeholder in the past.
Use it now in the live-block-operations doc, too.
Signed-off-by: Thomas Huth
---
On 08/06/2021 15.42, John Snow wrote:
On 6/4/21 11:53 AM, Alex Bennée wrote:
The assumption that the qemu-system-aarch64 image can run all 32 bit
machines is about to be broken and besides it's not likely this is
What's changing? I'm not deeply familiar with aarch64. Why is this
assumption ab
On 08/06/2021 16.27, Alex Bennée wrote:
Richard Henderson writes:
On 6/4/21 8:53 AM, Alex Bennée wrote:
The assumption that the qemu-system-aarch64 image can run all 32 bit
machines is about to be broken...
Um, what?
Really what we want is to probe the -M (machines) that a binary
support
On 08/06/2021 16.41, Alex Bennée wrote:
Thomas Huth writes:
On 08/06/2021 15.42, John Snow wrote:
On 6/4/21 11:53 AM, Alex Bennée wrote:
The assumption that the qemu-system-aarch64 image can run all 32 bit
machines is about to be broken and besides it's not likely this is
What'
On 08/06/2021 16.27, Alex Bennée wrote:
Richard Henderson writes:
On 6/4/21 8:53 AM, Alex Bennée wrote:
The assumption that the qemu-system-aarch64 image can run all 32 bit
machines is about to be broken...
Um, what?
Really what we want is to probe the -M (machines) that a binary
support
On 08/06/2021 17.35, Alex Bennée wrote:
Thomas Huth writes:
On 08/06/2021 16.27, Alex Bennée wrote:
Richard Henderson writes:
On 6/4/21 8:53 AM, Alex Bennée wrote:
The assumption that the qemu-system-aarch64 image can run all 32 bit
machines is about to be broken...
Um, what?
Really
On 08/06/2021 16.09, Cleber Rosa wrote:
GCC from CentOS Stream 8 is erroring out on a possibily unitialized
varible.
Full version info for the compiler used:
gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-1)
Signed-off-by: Cleber Rosa
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
On 05/05/2021 10.05, Vladimir Sementsov-Ogievskiy wrote:
05.05.2021 10:59, Miroslav Rezanina wrote:
Commit 3108a15cf (block: introduce bdrv_drop_filter()) introduced
uninitialized
variable to_cow_parent in bdrv_replace_node_common function that is used
only when
detach_subchain is true. It is u
On 07/03/2022 08.03, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
glib provides a convenience helper to measure elapsed time. It isn't
subject to wall-clock time changes.
Note that this changes the initial OPENED time, which used to print the
current time.
[...]
@@ -846,21 +828
/commands-win32.c | 19 ---
qga/commands.c | 5 +
3 files changed, 5 insertions(+), 33 deletions(-)
Reviewed-by: Thomas Huth
On 04/03/2022 17.57, Daniel P. Berrangé wrote:
On Tue, Feb 08, 2022 at 07:44:32AM -0500, Paolo Bonzini wrote:
This reverts commit d316859f4e28c74ab8b618895d2a5e0a865d3cf1. The
TAP output is inferior in that it does not include the diff for
failed tests.
Reported-by: Peter Maydell
Signed-off-b
_USER' in config_host
+if targetos == 'linux' and 'CONFIG_VHOST_USER' in config_host
libvhost_user = subproject('libvhost-user')
vhost_user = libvhost_user.get_variable('vhost_user_dep')
endif
Reviewed-by: Thomas Huth
On 07/03/2022 09.05, Marc-André Lureau wrote:
Hi
On Mon, Mar 7, 2022 at 11:46 AM Thomas Huth <mailto:th...@redhat.com>> wrote:
On 07/03/2022 08.03, marcandre.lur...@redhat.com
<mailto:marcandre.lur...@redhat.com> wrote:
> From: Marc-André Lureau mailto:marcandre
These two spots have been missed in commit 9086c7639822 ("Rework the
checks and spots using GNU sed") - they need GNU sed, too, since they
are using the "+" address form.
Signed-off-by: Thomas Huth
---
tests/qemu-iotests/common.filter | 4 ++--
1 file changed, 2 insert
On 09/03/2022 11.24, Philippe Mathieu-Daudé wrote:
Hi Alex, Thomas, Daniel,
Could you ack this patch?
Basically fine for me, but can we really run additional cirrus-ci jobs by
default? IIRC the parallel execution of those were quite limited for the
free tier, so did you look close that we do
On 09/03/2022 13.50, Philippe Mathieu-Daudé wrote:
Would it be beneficial to have a 1 per OS job during PR, and
other jobs run nightly (once a day, not per PR)?
Is there a way to trigger nightly runs in gitlab?
Thomas
vantage of not getting
the detailed progress indication there anymore, but since that was
only working right in single-threaded "make -j1" mode anyway, it's
not a huge loss right now.
Signed-off-by: Thomas Huth
---
v4: updated commit description
meson.build
On 06/02/2022 20.19, Jon Maloy wrote:
Trying again with correct email address.
///jon
On 2/6/22 14:15, Jon Maloy wrote:
On 1/27/22 15:14, Jon Maloy wrote:
On 11/18/21 06:57, Philippe Mathieu-Daudé wrote:
Trivial fix for CVE-2021-3507.
Philippe Mathieu-Daudé (2):
hw/block/fdc: Prevent e
Meson 0.61.3 contains an important fix which helps to see the
output of failed qemu-iotests on the console again:
https://gitlab.com/qemu-project/meson/-/commit/7534cf34f83b9c43
Signed-off-by: Thomas Huth
---
meson | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson b
Meson 0.61.3 contains an important fix which helps to see the
output of failed qemu-iotests on the console again:
https://gitlab.com/qemu-project/meson/-/commit/7534cf34f83b9c43
Acked-by: Paolo Bonzini
Signed-off-by: Thomas Huth
---
v2: Update the version in the configure script, too (as
On 15/03/2022 20.30, Peter Maydell wrote:
On Tue, 15 Mar 2022 at 18:58, Peter Maydell wrote:
On Tue, 15 Mar 2022 at 11:20, Thomas Huth wrote:
Hi Peter!
The following changes since commit 352998df1c53b366413690d95b35f76d0721ebed:
Merge tag 'i2c-20220314' of https://github.
On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Replace a config-time define with a compile time condition
define (compatible with clang and gcc) that must be declared prior to
its usage. This avoids having a global configure time define, but also
prevents from b
On 16/03/2022 12.15, Halil Pasic wrote:
On Wed, 16 Mar 2022 11:28:59 +0100
Thomas Huth wrote:
On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
Replace a config-time define with a compile time condition
define (compatible with clang and gcc) that must be
On 16/03/2022 14.16, Philippe Mathieu-Daudé wrote:
On 16/3/22 10:52, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau
One less qemu-specific macro. It also helps to make some headers/units
only depend on glib, and thus moved in standalone projects eventually.
Signed-off-by: Marc-And
On 18/03/2022 18.04, Hanna Reitz wrote:
On 10.03.22 08:50, Thomas Huth wrote:
If there is a failing iotest, the output is currently not logged to
the console anymore. To get this working again, we need to run the
meson test runner with "--print-errorlogs" (and without "--ve
"Set ADMA error flag");
+s->errintsts |= SDHC_EIS_ADMAERR;
+s->norintsts |= SDHC_NIS_ERR;
+}
+sdhci_update_irq(s);
+} else {
+s->admasysaddr += dscr.incr;
+}
break;
case SDHC
{
break;
}
Looks sane to me!
Reviewed-by: Thomas Huth
On 10/03/2022 18.53, Jon Maloy wrote:
On 3/10/22 12:14, Thomas Huth wrote:
On 06/02/2022 20.19, Jon Maloy wrote:
Trying again with correct email address.
///jon
On 2/6/22 14:15, Jon Maloy wrote:
On 1/27/22 15:14, Jon Maloy wrote:
On 11/18/21 06:57, Philippe Mathieu-Daudé wrote:
Trivial
On 21/03/2022 10.06, Hanna Reitz wrote:
On 18.03.22 18:36, Thomas Huth wrote:
On 18/03/2022 18.04, Hanna Reitz wrote:
On 10.03.22 08:50, Thomas Huth wrote:
If there is a failing iotest, the output is currently not logged to
the console anymore. To get this working again, we need to run the
On 21/03/2022 14.11, Hanna Reitz wrote:
On 21.03.22 10:17, Thomas Huth wrote:
On 21/03/2022 10.06, Hanna Reitz wrote:
On 18.03.22 18:36, Thomas Huth wrote:
On 18/03/2022 18.04, Hanna Reitz wrote:
On 10.03.22 08:50, Thomas Huth wrote:
If there is a failing iotest, the output is currently not
The following changes since commit 2058fdbe81e2985c226a026851dd26b146d3395c:
Merge tag 'fixes-20220318-pull-request' of git://git.kraxel.org/qemu into
staging (2022-03-19 11:28:54 +)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-request-2022-03-21
m>
Signed-off-by: Thomas Huth
---
softmmu/physmem.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 43ae70fbe2..3d968ca92f 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -2816,14 +2816,11 @@ static MemTxResul
MEMTX_ACCESS_ERROR, remove "inline"]
Signed-off-by: Thomas Huth
---
include/exec/memattrs.h | 9 +
softmmu/physmem.c | 44 +++--
2 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/include/exec/memattrs.h b/include/exec/mem
Bulekov
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542
CVE: CVE-2021-3611
Message-Id: <20211218160912.1591633-3-phi...@redhat.com>
Signed-off-by: Thomas Huth
---
hw/audio/intel-hda.c | 2 +-
1 file changed, 1 ins
60912.1591633-2-phi...@redhat.com>
Signed-off-by: Thomas Huth
---
hw/audio/intel-hda.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index 5f8a878f20..47a36acc71 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-h
), triggering a
re-entrancy issue.
Fix by prohibit transactions from the DMA to devices. The DMA engine
is thus restricted to memories.
Reported-by: OSS-Fuzz (Issue 36391)
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/451
901 - 1000 of 1301 matches
Mail list logo
