[Qemu-devel] No cancel callback for usb-ohci

2007-11-07 Thread Salil Bijur
Hello, There is a call to the function usb_cancel_packet in hw/usb-ohci.c. However, there is no cancel_cb callback registered for the ohci->usb_packet resulting in a segmentation fault. Are there any plans to implement this cancel callback? Thanks, Salil

[Qemu-devel] Re: [kvm-devel] FreeBSD image hangs during boot

2007-11-07 Thread Avi Kivity
Aurelien Jarno wrote: > Well the IDE code hasn't changed a lot recently, so I checked the CVS > history and easily (first test) found the commit that causes the problem: > > Last AIO patch, by Vladimir N. Oleynik. > > http://cvs.savannah.nongnu.org/viewvc/qemu/hw/ide.c?root=qemu&r1=1.64&r2=1.65 > >

[Qemu-devel] Re: [kvm-devel] [PATCH 1/2] KVM userspace: Add PCI device passthrough support

2007-11-07 Thread Avi Kivity
Amit Shah wrote: > This patch introduces support for device passthrough > from the host to a paravirtualized guest. > > A new command-line option, -passthrough is added. > For example, to invoke it for an Ethernet device sitting at > PCI bus:dev.fn 04:08.0 with host IRQ 18, use this: > > -passthrou

[Qemu-devel] PC Bios source code?

2007-11-07 Thread Jun Koi
Hi, In pc-bios/ directory, we have bios.bin and bios.diff. As I understand, qemu's bios is modified from bochs bios. But what are the differences between our bios.bin and bochs bios.bin? As there are some differences, where is the source code of our bios.bin?? Thanks, Jun

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-07 Thread Thiemo Seufer
Daniel Jacobowitz wrote: > On Thu, Nov 08, 2007 at 12:05:25AM +0100, Aurelien Jarno wrote: > > Has Thiemo already said, there is no IEEE behavior. If you look at the > > IEEE 754 document you will see that it has requirements on what should > > be supported by an IEEE compliant FPU, but has very fe

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Paul Brook
> I can check the hypervisor feature is not present, for emulating PowerPC > 620 on a target that would have hypervisor emulation support. But I > cannot do as if the CPU do not have the feature if it's actually > available. The PowerPC 64 target emulates PowerPC 64 without the > hypervisor feature

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Paul Brook
On Wednesday 07 November 2007, Bernhard Fischer wrote: > On Wed, Nov 07, 2007 at 11:55:26PM +0100, Fabrice Bellard wrote: > >Why not adding a new CPU type such as "PPC970 with hypervisor" and keep > >the current PPC970 implementation as it is without the hypervisor mode. > >I don't see the problem

Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom

2007-11-07 Thread Fabrice Bellard
Laurent Vivier wrote: > Thiemo Seufer a écrit : >> Laurent Vivier wrote: >>> Daniel P. Berrange a écrit : On Sun, Oct 28, 2007 at 11:43:33PM +0100, [EMAIL PROTECTED] wrote: > From: Laurent Vivier <[EMAIL PROTECTED](none)> > > This patch allows to define where is connected the

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Bernhard Fischer
On Wed, Nov 07, 2007 at 11:55:26PM +0100, Fabrice Bellard wrote: >Why not adding a new CPU type such as "PPC970 with hypervisor" and keep >the current PPC970 implementation as it is without the hypervisor mode. >I don't see the problem in replacing the ifdefs with a new CPU model ! >You cannot rea

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Thiemo Seufer
Fabrice Bellard wrote: > I noticed that some target CPUs macros have been added while they do not > seem necessary. I don't like that because it introduces more #ifdefs > which prevent making a version supporting simultaneously all the CPUs. > > In particular I saw the following: > > - TARGET_MIP

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-07 Thread Daniel Jacobowitz
On Thu, Nov 08, 2007 at 12:05:25AM +0100, Aurelien Jarno wrote: > Has Thiemo already said, there is no IEEE behavior. If you look at the > IEEE 754 document you will see that it has requirements on what should > be supported by an IEEE compliant FPU, but has very few requirements on > the implement

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread J. Mayer
On Wed, 2007-11-07 at 22:47 +, Paul Brook wrote: > > Removing the ppc64h target means, for me, removing any option to emulate > > the hypervisor feature at any time (if removed) or removing the ability > > to use the PowerPC 64 targets the way they are when booting on Apple G5 > > machines (if

Re: [Qemu-devel] [PATCH] Fix NaN handling in softfloat

2007-11-07 Thread Aurelien Jarno
On Tue, Nov 06, 2007 at 09:01:13PM +0100, J. Mayer wrote: > > On Sat, 2007-11-03 at 22:28 +0100, Aurelien Jarno wrote: > > On Sat, Nov 03, 2007 at 02:06:04PM -0400, Daniel Jacobowitz wrote: > > > On Sat, Nov 03, 2007 at 06:35:48PM +0100, Aurelien Jarno wrote: > > > > Hi all, > > > > > > > > The

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Fabrice Bellard
J. Mayer wrote: > On Wed, 2007-11-07 at 22:55 +0100, Fabrice Bellard wrote: >> Jocelyn Mayer wrote: >>> On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduce

Re: [Qemu-devel] RFC: x86_64 Best way to fix 'cast to pointer from integer of different size' problems?

2007-11-07 Thread Paul Brook
> - Modify lock_user() so that it automatically does access_ok() and > returns NULL if access_ok() fails. You'll also need to augment all lock_user calls to indicate whether the buffer needs to be writable. Currently this information is not available until unlock_user is called. Paul

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread J. Mayer
On Wed, 2007-11-07 at 22:55 +0100, Fabrice Bellard wrote: > Jocelyn Mayer wrote: > > On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: > >> I noticed that some target CPUs macros have been added while they do not > >> seem necessary. I don't like that because it introduces more #ifdefs > >

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Fabrice Bellard
Jocelyn Mayer wrote: > On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: >> I noticed that some target CPUs macros have been added while they do not >> seem necessary. I don't like that because it introduces more #ifdefs >> which prevent making a version supporting simultaneously all the CP

Re: [Qemu-devel] Mac OS X Keyboard

2007-11-07 Thread Jeshua Lacock
On Nov 7, 2007, at 12:41 PM, Jeshua Lacock wrote: I tried applying Jo's keyboard patch to Qemu 0.9.0 and I cannot the keyboard to properly work. In FreeDos for example, all of the regular keys work, but when I press the shift key it inputs the letter '

Re: [Qemu-devel] RFC: x86_64 Best way to fix 'cast to pointer from integer of different size' problems?

2007-11-07 Thread Thayne Harbaugh
On Wed, 2007-11-07 at 20:18 +0100, Fabrice Bellard wrote: > Hi, > > Regarding the user memory access, here is my suggestion which should > minimize the changes: The virtue of making the minimum changes is that there are likely fewer errors. Other than that, it's more important to me to make the

[Qemu-devel] Re: [kvm-devel] [PATCH 1/2] KVM userspace: Add PCI device passthrough support

2007-11-07 Thread Hollis Blanchard
I'm sorry these comments aren't substantive, but please watch your whitespace... On Wed, 2007-11-07 at 21:45 +0200, Amit Shah wrote: > diff --git a/qemu/Makefile b/qemu/Makefile > index 053c88c..3e599f3 100644 > --- a/qemu/Makefile > +++ b/qemu/Makefile > @@ -37,7 +37,7 @@ qemu-img$(EXESUF): qemu-

Re: [Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Jocelyn Mayer
On Wed, 2007-11-07 at 19:32 +0100, Fabrice Bellard wrote: > I noticed that some target CPUs macros have been added while they do not > seem necessary. I don't like that because it introduces more #ifdefs > which prevent making a version supporting simultaneously all the CPUs. > > In particular I

[Qemu-devel] Mac OS X Keyboard

2007-11-07 Thread Jeshua Lacock
Greetings, I tried applying Jo's keyboard patch to Qemu 0.9.0 and I cannot the keyboard to properly work. In FreeDos for example, all of the regular keys work, but when I press the shift key it inputs the letter 'a' and again the letter 'a' when the

[Qemu-devel] qemu/slirp slirp.h

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 19:27:18 Modified files: slirp : slirp.h Log message: use config-host.h instead of config.h CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/slirp/slirp.h?cvsroot=qem

[Qemu-devel] qemu/audio audio.h

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 19:26:55 Modified files: audio : audio.h Log message: use config-host.h instead of config.h CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/audio/audio.h?cvsroot=qem

[Qemu-devel] qemu vl.h

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 19:26:23 Modified files: . : vl.h Log message: fixed QEMU_TOOL tests CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/vl.h?cvsroot=qemu&r1=1.288&r2=1.289

[Qemu-devel] qemu configure

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 19:25:15 Modified files: . : configure Log message: SDL and COCA are no longer target dependent - support for common code compilation CVSWeb URLs: http://cvs.savannah

[Qemu-devel] qemu Makefile Makefile.target

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 19:24:02 Modified files: . : Makefile Makefile.target Log message: compile common code once CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/Makefile?cvsroot=qemu

Re: [Qemu-devel] RFC: x86_64 Best way to fix 'cast to pointer from integer of different size' problems?

2007-11-07 Thread Fabrice Bellard
Hi, Regarding the user memory access, here is my suggestion which should minimize the changes: - Keep __put_user() and __get_user() as you did. - Remove put_user(), get_user(), copy_from_user() and copy_to_user() - Modify the signal.c code so that it uses __put_user, __get_user and lock/unlock_

Re: [Qemu-devel] qemu qemu-doc.texi vl.c vl.h hw/mc146818rtc.c

2007-11-07 Thread Fabrice Bellard
Stefan Weil wrote: > Hi, > > the change from mc146818rtc.c might be needed for other timer > implementations, > too (because not all systems emulated by QEMU use mc146818rtc.c). > > A list of candidates is here (fgrep gmtime, fgrep gettime): > hw/m48t59.c:gmtime_r (&t, tm); > hw/omap.c:

Re: [Qemu-devel] qemu qemu-doc.texi vl.c vl.h hw/mc146818rtc.c

2007-11-07 Thread Stefan Weil
Hi, the change from mc146818rtc.c might be needed for other timer implementations, too (because not all systems emulated by QEMU use mc146818rtc.c). A list of candidates is here (fgrep gmtime, fgrep gettime): hw/m48t59.c:gmtime_r (&t, tm); hw/omap.c:s->convert = rtc_utc ? gmtime_r : l

[Qemu-devel] Removal of some target CPU macros

2007-11-07 Thread Fabrice Bellard
I noticed that some target CPUs macros have been added while they do not seem necessary. I don't like that because it introduces more #ifdefs which prevent making a version supporting simultaneously all the CPUs. In particular I saw the following: - TARGET_MIPSN32 : it is always combined with TAR

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-07 Thread Fabrice Bellard
A few more remarks : - tpm_register() must be called in hw/pc.c. - you must also handle incomplete write and reads. Use something like unix_write() in vl.c and the equivalent for read. - The code seems to be Unix specific so it must be disabled for win32. Regards, Fabrice.

[Qemu-devel] qemu cpu-exec.c target-sparc/cpu.h target-sparc...

2007-11-07 Thread Blue Swirl
CVSROOT:/cvsroot/qemu Module name:qemu Changes by: Blue Swirl 07/11/07 17:03:37 Modified files: . : cpu-exec.c target-sparc : cpu.h helper.c op_helper.c translate.c Log message: CPU specific boot mode (Robert Reif) CVSWeb URLs: http://c

[Qemu-devel] qemu/hw pc.c

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 16:54:42 Modified files: hw : pc.c Log message: removed traces CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/hw/pc.c?cvsroot=qemu&r1=1.88&r2=1.89

[Qemu-devel] [Patch][Fix win2k install] Add delay between dma issue & result.

2007-11-07 Thread Dor Laor
Fix win2k install] Add delay between dma issue & result. Using synchonous io leads the guest to unexplored places: If it issues a dma command, it goes to qemu and executed synchrnously and return with irq for data ready. This is not real world scenario and happens when not using a

[Qemu-devel] qemu qemu-doc.texi vl.c vl.h hw/mc146818rtc.c

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 16:24:34 Modified files: . : qemu-doc.texi vl.c vl.h hw : mc146818rtc.c Log message: added -startdate option CVSWeb URLs: http://cvs.savannah.gnu.

Re: [Qemu-devel] [PATCH] sparc32 boot mode flag fix

2007-11-07 Thread Blue Swirl
On 11/6/07, Paul Brook <[EMAIL PROTECTED]> wrote: > > > IIUC enabling/disabling boot mode is no different to and other VM change. > > > If the virtual->physical mapping happens to be the same then it's > > > perfectly ok to reuse the TB. > > > > Not in this case: in boot mode, physical and virtual

[Qemu-devel] qemu dyngen.c

2007-11-07 Thread Fabrice Bellard
CVSROOT:/sources/qemu Module name:qemu Changes by: Fabrice Bellard07/11/07 16:07:32 Modified files: . : dyngen.c Log message: moved declarations CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/qemu/dyngen.c?cvsroot=qemu&r1=1.56&r2=1.57

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-07 Thread Thomas Bleher
* Fabrice Bellard <[EMAIL PROTECTED]> [2007-11-06 20:47]: > Thomas Bleher wrote: > > * Fabrice Bellard <[EMAIL PROTECTED]> [2007-11-05 16:40]: > >> Thomas Bleher wrote: > > +result = write(s->tpm_fd, s->send_data, s->send_data_index); > > +if (result < s->send_data_index) { > > +