[Qemu-devel] Re: [PATCH] Makefile: Change make to be quiet again when doing nothing

2009-10-22 Thread Paolo Bonzini
On 10/21/2009 11:17 PM, Stefan Weil wrote: Paolo Bonzini schrieb: On 10/20/2009 06:17 PM, Stefan Weil wrote: This patch makes make quiet again. There is already a similar patch from Juan Quintela, but maybe this shorter form is preferred. This patch would reintroduce an ordering problem

[Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
Revised patch for getting rid of tcg temporary variable leaks in target-arm/translate.c. This version also includes the leak patch for gen_set_cpsr macro, now converted as a static inline function, which I sent earlier as a separate patch on top of this patch. This patch (the attached version)

Re: [Qemu-devel] [PATCH 07/12] target-arm: fix neon vsri, vshl and vsli ops

2009-10-22 Thread Juha.Riihimaki
On Oct 21, 2009, at 13:46, ext Laurent Desnogues wrote: @@ -4624,31 +4624,31 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) switch (size) { case 0: if (op == 4) -

Re: [Qemu-devel] [PATCH] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 08:40, Riihimaki Juha (Nokia-D/Helsinki) wrote: @@ -4676,12 +4694,16 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) gen_neon_narrow_satu(size - 1, tmp, cpu_V0); } if

Re: [Qemu-devel] [PATCH 07/12] target-arm: fix neon vsri, vshl and vsli ops

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 10:18, ext Laurent Desnogues wrote: On Thu, Oct 22, 2009 at 8:49 AM, juha.riihim...@nokia.com wrote: On Oct 21, 2009, at 13:46, ext Laurent Desnogues wrote: @@ -4624,31 +4624,31 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)

Re: [Qemu-devel] [PATCH 07/12] target-arm: fix neon vsri, vshl and vsli ops

2009-10-22 Thread Laurent Desnogues
On Thu, Oct 22, 2009 at 9:33 AM, juha.riihim...@nokia.com wrote: On Oct 22, 2009, at 10:18, ext Laurent Desnogues wrote: On Thu, Oct 22, 2009 at 8:49 AM,  juha.riihim...@nokia.com wrote: On Oct 21, 2009, at 13:46, ext Laurent Desnogues wrote: @@ -4624,31 +4624,31 @@ static int

Re: [Qemu-devel] sparc64-softmmu Questions

2009-10-22 Thread Artyom Tarasenko
For Solaris/Sparc64 emulation, there is more than one way: - sparc64-softmmu/sun4u + OpenBIOS (default stack): problems described above - sparc64-softmmu/sun4v + hypervisor + OBP: need to port the hypervisor to QEMU, maybe fix/implement a few devices Actually it may be that only the second

Re: [Qemu-devel] [PATCH 12/12] [RESEND] target-arm: fix neon shift helper functions

2009-10-22 Thread Laurent Desnogues
On Wed, Oct 21, 2009 at 1:01 PM, juha.riihim...@nokia.com wrote: Current code is broken at least on gcc 4.2, the result of a comparison -1 = sizeof(type) * 8 results true and causes wrong code path to be taken. The fix utilizes abs() function where applicable and otherwise adds a test to

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Kevin Wolf
Am 21.10.2009 20:08, schrieb Anthony Liguori: Glauber Costa wrote: On Wed, Oct 21, 2009 at 2:55 PM, Anthony Liguori anth...@codemonkey.ws wrote: Glauber Costa wrote: Why don't we provide a mechanism to make a macro out of a sequence of monitor commands, and let the user assign

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Gerd Hoffmann
On 10/21/09 21:39, Glauber Costa wrote: $ rpm -ql kernel-headers | grep kvm /usr/include/asm/kvm.h /usr/include/linux/kvm.h Did you ever build this? You should improve your patch qa ... btw, it builds fine for me even without --kerneldir, just tested. and thelinux/kvm_para.h

Re: [Qemu-devel] [PATCH 3/3 v4] Enable migration without shared storage from the monitor

2009-10-22 Thread Liran Schour
- Liran Anthony Liguori anth...@codemonkey.ws wrote on 21/10/2009 20:27:39: Anthony Liguori anth...@codemonkey.ws 21/10/2009 20:27 To Liran Schour/Haifa/i...@ibmil cc qemu-devel@nongnu.org Subject Re: [Qemu-devel] [PATCH 3/3 v4] Enable migration without shared storage from the

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-22 Thread Christoph Hellwig
On Tue, Oct 20, 2009 at 12:12:55PM +0200, Kevin Wolf wrote: On that note, falling back to POSIX AIO means that paio_submit is called with a Linux AIO aio_ctx. Which works because this parameter is unused anyway, but am I the only one to find this ugly? What is the public interface of

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
Hi, -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) Your mailer mangles the patches. cheers, Gerd

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 11:04, ext Gerd Hoffmann wrote: Hi, -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. That's why I include the patch as an attachment as well -- the attachment

Re: [Qemu-devel] [PATCH 03/12] target-arm: add support for neon vld1.64 instruction

2009-10-22 Thread Laurent Desnogues
On Wed, Oct 21, 2009 at 12:17 PM, juha.riihim...@nokia.com wrote: Add support for neon vld1.64 instruction. From: Riku Voipio riku.voi...@iki.fi Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com --- diff --git a/target-arm/translate.c b/target-arm/translate.c index 3ea9d51..d027572

Re: [Qemu-devel] [PATCH 12/12] [RESEND] target-arm: fix neon shift helper functions

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 10:57, ext Laurent Desnogues wrote: On Wed, Oct 21, 2009 at 1:01 PM, juha.riihim...@nokia.com wrote: Current code is broken at least on gcc 4.2, the result of a comparison -1 = sizeof(type) * 8 results true and causes wrong code path to be taken. The fix utilizes

Re: [Qemu-devel] [PATCH 02/11] Add support for qfloat

2009-10-22 Thread Amit Shah
On (Mon) Oct 19 2009 [09:18:19], Anthony Liguori wrote: + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + * Copyright IBM, Corp. 2009 + * + * Authors: + * Anthony Liguori aligu...@us.ibm.com + * + * This

[Qemu-devel] Re: [PATCH] raw/linux-aio: Also initialize POSIX AIO

2009-10-22 Thread Kevin Wolf
Am 22.10.2009 10:31, schrieb Christoph Hellwig: On Tue, Oct 20, 2009 at 12:12:55PM +0200, Kevin Wolf wrote: On that note, falling back to POSIX AIO means that paio_submit is called with a Linux AIO aio_ctx. Which works because this parameter is unused anyway, but am I the only one to find this

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Avi Kivity
On 10/20/2009 06:40 PM, Carsten Otte wrote: This patch moves s390 processor status word into the base kvm_run struct and keeps it up-to date on all userspace exits. +#include linux/autoconf.h #include linux/types.h #include linux/compiler.h #include linux/ioctl.h Not needed. @@ -116,6

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
On 10/22/09 10:35, juha.riihim...@nokia.com wrote: Hi, -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. Makes it very difficult to extract the patches in a automated way ...

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Alexander Graf
On 22.10.2009, at 11:08, Avi Kivity wrote: On 10/20/2009 06:40 PM, Carsten Otte wrote: This patch moves s390 processor status word into the base kvm_run struct and keeps it up-to date on all userspace exits. +#include linux/autoconf.h #include linux/types.h #include linux/compiler.h

Re: [Qemu-devel] [PATCH 03/12] target-arm: add support for neon vld1.64 instruction

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 11:39, ext Laurent Desnogues wrote: On Wed, Oct 21, 2009 at 12:17 PM, juha.riihim...@nokia.com wrote: Add support for neon vld1.64 instruction. From: Riku Voipio riku.voi...@iki.fi Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com --- diff --git

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Carsten Otte
Avi Kivity wrote: @@ -116,6 +117,11 @@ __u64 cr8; __u64 apic_base; +#ifdef CONFIG_S390 +/* the processor status word for s390 */ +__u64 psw_mask; /* psw upper half */ +__u64 psw_addr; /* psw lower half */ +#endif Doesn't this break backward compatibility by changing the

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Avi Kivity
On 10/22/2009 11:11 AM, Alexander Graf wrote: Doesn't this break backward compatibility by changing the structure? Best to put it after the union (and as a copy, so userspace that expects the previous location still works). If you're reading it from the kernel, also need a way to tell the

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 12:10, ext Gerd Hoffmann wrote: On 10/22/09 10:35, juha.riihim...@nokia.com wrote: Hi, -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. Makes it very

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Alexander Graf
On 22.10.2009, at 11:55, Alexander Graf wrote: PSW = (eflags 32) | pc; Eh - 64 of course. The PSW is 128 bits. Alex

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Avi Kivity
On 10/22/2009 11:55 AM, Alexander Graf wrote: On 22.10.2009, at 11:53, Avi Kivity wrote: On 10/22/2009 11:11 AM, Alexander Graf wrote: Doesn't this break backward compatibility by changing the structure? Best to put it after the union (and as a copy, so userspace that expects the previous

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
On 10/22/09 11:55, juha.riihim...@nokia.com wrote: Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. Makes it very difficult to extract the patches in a automated way ... Well, I tested that the formatting stays correct if I send the mail body HTML format instead

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Alexander Graf
On 22.10.2009, at 12:03, Avi Kivity wrote: On 10/22/2009 11:55 AM, Alexander Graf wrote: On 22.10.2009, at 11:53, Avi Kivity wrote: On 10/22/2009 11:11 AM, Alexander Graf wrote: Doesn't this break backward compatibility by changing the structure? Best to put it after the union (and as

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Carsten Otte
Avi Kivity wrote: gdb is hardly performance critical. Is that the only reason for the change? Right, gdb is not performance critical. gdb is the reason for moving it out of the union, performance is the reason for having it in kvm_run at all. There's only more reason to it: with a little

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Carsten Otte
Avi Kivity wrote: Right, but why? x86 qemu doesn't care about either pc or eflags (with in-kernel irqchip, which s390 essentially is). For different reasons. Most prominent for setting the condition code, which is a sideband result of most instructions that indicates whether or not the

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Avi Kivity
On 10/22/2009 12:22 PM, Carsten Otte wrote: Avi Kivity wrote: Right, but why? x86 qemu doesn't care about either pc or eflags (with in-kernel irqchip, which s390 essentially is). For different reasons. Most prominent for setting the condition code, which is a sideband result of most

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Carsten Otte
Avi Kivity wrote: On x86 we avoid emulating instructions in userspace. Instead the kernel requests userspace to do something (triggered by the instruction), and the kernel does anything which might be implied by the instruction (like copying the result into a register, or updating pc). An

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Avi Kivity
On 10/22/2009 12:43 PM, Carsten Otte wrote: Avi Kivity wrote: On x86 we avoid emulating instructions in userspace. Instead the kernel requests userspace to do something (triggered by the instruction), and the kernel does anything which might be implied by the instruction (like copying the

Re: [Qemu-devel] [PATCH 1/3 v4] Expose a mechanisem to trace block writes

2009-10-22 Thread Liran Schour
qemu-devel-bounces+lirans=il.ibm@nongnu.org wrote on 21/10/2009 20:21:09: Anthony Liguori anth...@codemonkey.ws Sent by: qemu-devel-bounces+lirans=il.ibm@nongnu.org 21/10/2009 20:21 To Liran Schour/Haifa/i...@ibmil cc qemu-devel@nongnu.org Subject Re: [Qemu-devel] [PATCH

[Qemu-devel] Re: [PATCH 0/9] S390x KVM support

2009-10-22 Thread Carsten Otte
Avi Kivity wrote: So why not do it for this instruction as well? Instead of updating the psw, return a success/error code and let the kernel update psw. It's not a single instruction, but a set of reasons we need the psw in userspace: - for logging the instruction address on exits - to check

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Glauber Costa
On Thu, Oct 22, 2009 at 10:00:37AM +0200, Gerd Hoffmann wrote: On 10/21/09 21:39, Glauber Costa wrote: $ rpm -ql kernel-headers | grep kvm /usr/include/asm/kvm.h /usr/include/linux/kvm.h Did you ever build this? You should improve your patch qa ... btw, it builds fine for me

[Qemu-devel] qemu-kvm: sigsegv at exit

2009-10-22 Thread Michael S. Tsirkin
Hi! I'm sometimes getting segfaults when I kill qemu. This time I caught it when qemu was under gdb: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x411d0940 (LWP 14446)] 0x0040afb4 in qemu_mod_timer (ts=0x19f0fd0, expire_time=62275467335) at

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Juha.Riihimaki
On Oct 22, 2009, at 13:08, ext Gerd Hoffmann wrote: On 10/22/09 11:55, juha.riihim...@nokia.com wrote: Your mailer mangles the patches. Yes, I know, I can't help it, I'm sorry. Makes it very difficult to extract the patches in a automated way ... Well, I tested that the formatting

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Gerd Hoffmann
Just defining the msrs instead of using kvm_para.h should be fine, the numbers will not change ... That's not the problem. If one removes kvm_para.h, a lot of other things will not build. For example, the capabilities list. And it has been like this for almost a year now! Without that header,

[Qemu-devel] [PATCH v2][RESEND] target-arm: cleanup internal resource leaks

2009-10-22 Thread juha . riihimaki
From: Juha Riihimäki juha.riihim...@nokia.com Revised patch for getting rid of tcg temporary variable leaks in target-arm/translate.c. This version also includes the leak patch for gen_set_cpsr macro, now converted as a static inline function, which I sent earlier as a separate patch on top of

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Glauber Costa
On Thu, Oct 22, 2009 at 02:15:06PM +0200, Gerd Hoffmann wrote: Just defining the msrs instead of using kvm_para.h should be fine, the numbers will not change ... That's not the problem. If one removes kvm_para.h, a lot of other things will not build. For example, the capabilities list. And it

[Qemu-devel] [PATCH] v2: properly save kvm system time msr registers

2009-10-22 Thread Glauber Costa
Currently, the msrs involved in setting up pvclock are not saved over migration and/or save/restore. This patch puts their value in special fields in our CPUState, and deal with them using vmstate. kvm also has to account for it, by including them in the msr list for the ioctls. This is a

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Riku Voipio
On Thu, Oct 22, 2009 at 02:03:30PM +0200, juha.riihim...@nokia.com wrote: On Oct 22, 2009, at 13:08, ext Gerd Hoffmann wrote: Something git am can handle would be best. git send-email would be perfect if you can get that work. 'git send-email --smtp-server

Re: [Qemu-devel] [PATCH 02/11] Add support for qfloat

2009-10-22 Thread Anthony Liguori
Amit Shah wrote: On (Mon) Oct 19 2009 [09:18:19], Anthony Liguori wrote: + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + * Copyright IBM, Corp. 2009 + * + * Authors: + * Anthony Liguori aligu...@us.ibm.com +

Re: [Qemu-devel] [PATCH 02/11] Add support for qfloat

2009-10-22 Thread Amit Shah
On (Thu) Oct 22 2009 [09:01:48], Anthony Liguori wrote: Amit Shah wrote: On (Mon) Oct 19 2009 [09:18:19], Anthony Liguori wrote: + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. + * + * Copyright IBM, Corp. 2009 +

Re: [Qemu-devel] [PATCH v2] target-arm: cleanup internal resource leaks

2009-10-22 Thread Gerd Hoffmann
Hi, Okay, thanks for the suggestion, I'll try that and resend the v2 patch, let's see what happens. Perfect. unless quoted-printable (and base64 while at it) support is added to git am, this is going to be a common problem for mails sent to qemu-devel. My git version handles it just

Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers

2009-10-22 Thread Anthony Liguori
Glauber Costa wrote: That's not the problem. If one removes kvm_para.h, a lot of other things will not build. For example, the capabilities list. And it has been like this for almost a year now! Without that header, your system should have never successfully built a qemu-kvm instance. This is

[Qemu-devel] [PATCH 01/20] audio: fix compilation of DEBUG_PLIVE

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- audio/audio_template.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 14c648c..19cdb7f 100644 --- a/audio/audio_template.h +++ b/audio/audio_template.h @@

[Qemu-devel] [PATCH 00/20] Port audio to vmstate

2009-10-22 Thread Juan Quintela
Hi THis patch series port audio to vmstate. - fix compliation with DEBUG_PLIVE and DEBUG_AC97 - unfold IO_READ_PROTO/IO_WRITE_PROTO and remove them - audio.c: the easiest thing to port (nothing inside) - sb16: port to vmstate, testing shows that it didn't survive migrations very well (it

[Qemu-devel] [PATCH 02/20] audio: port to vmstate

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- audio/audio.c | 26 +- 1 files changed, 9 insertions(+), 17 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 80a717b..a5305c4 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1784,23 +1784,15 @@ static

[Qemu-devel] [PATCH 03/20] sb16: remove IO_READ_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/sb16.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/sb16.c b/hw/sb16.c index 8654b7d..f4f96d1 100644 --- a/hw/sb16.c +++ b/hw/sb16.c @@ -40,8 +40,6 @@ #define ldebug(...) #endif -#define

[Qemu-devel] [PATCH 04/20] sb16: remove IO_WRITE_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/sb16.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/sb16.c b/hw/sb16.c index f4f96d1..e461970 100644 --- a/hw/sb16.c +++ b/hw/sb16.c @@ -40,9 +40,6 @@ #define ldebug(...) #endif -#define

[Qemu-devel] [PATCH 05/20] sb16: port to vmstate

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/sb16.c | 168 ++--- 1 files changed, 61 insertions(+), 107 deletions(-) diff --git a/hw/sb16.c b/hw/sb16.c index e461970..d66a6e3 100644 --- a/hw/sb16.c +++ b/hw/sb16.c @@ -1246,115

[Qemu-devel] [PATCH 06/20] es1370: remove IO_READ_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/es1370.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 9071a48..fe98267 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -156,8 +156,6 @@ static const unsigned dac1_samplerate[]

[Qemu-devel] [PATCH 07/20] es1370: remove IO_WRITE_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/es1370.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index fe98267..6f0995a 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@ -156,9 +156,6 @@ static const unsigned

[Qemu-devel] [PATCH 08/20] es1370: port to vmstate

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/es1370.c | 77 +++--- 1 files changed, 36 insertions(+), 41 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 6f0995a..532baae 100644 --- a/hw/es1370.c +++ b/hw/es1370.c @@

[Qemu-devel] [PATCH 10/20] adlib: remove IO_WRITE_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/adlib.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/adlib.c b/hw/adlib.c index 3221fea..fa3c6c0 100644 --- a/hw/adlib.c +++ b/hw/adlib.c @@ -51,9 +51,6 @@ void YMF262UpdateOneQEMU (int which, INT16 *dst,

[Qemu-devel] [PATCH 11/20] c4231a: remove IO_READ_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/cs4231a.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/cs4231a.c b/hw/cs4231a.c index e03c5d2..8a91b29 100644 --- a/hw/cs4231a.c +++ b/hw/cs4231a.c @@ -74,9 +74,6 @@ typedef struct CSState { int16_t

[Qemu-devel] [PATCH 13/20] c4231a: port to vmstate

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/cs4231a.c | 58 ++ 1 files changed, 30 insertions(+), 28 deletions(-) diff --git a/hw/cs4231a.c b/hw/cs4231a.c index a077edc..e9468bc 100644 --- a/hw/cs4231a.c +++ b/hw/cs4231a.c @@

[Qemu-devel] [PATCH 14/20] gus: remove IO_READ_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/gus.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/gus.c b/hw/gus.c index c6b98b3..101e645 100644 --- a/hw/gus.c +++ b/hw/gus.c @@ -41,8 +41,6 @@ #define GUS_ENDIANNESS 0 #endif -#define

[Qemu-devel] [PATCH 12/20] c4231a: remove IO_WRITE_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/cs4231a.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/cs4231a.c b/hw/cs4231a.c index 8a91b29..a077edc 100644 --- a/hw/cs4231a.c +++ b/hw/cs4231a.c @@ -74,9 +74,6 @@ typedef struct CSState { int16_t

[Qemu-devel] [PATCH 17/20] ac97: sizeof returns unsigned long

2009-10-22 Thread Juan Quintela
This change makes DEBUG_AC97 to compile again Signed-off-by: Juan Quintela quint...@redhat.com --- hw/ac97.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 610ca60..e4ecbe9 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -323,7 +323,7 @@ static

[Qemu-devel] [PATCH 15/20] gus: remove IO_WRITE_PROTO

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/gus.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/gus.c b/hw/gus.c index 101e645..d9c47b1 100644 --- a/hw/gus.c +++ b/hw/gus.c @@ -41,9 +41,6 @@ #define GUS_ENDIANNESS 0 #endif -#define

[Qemu-devel] [PATCH 18/20] ac97: recalculate active after loadvm

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/ac97.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index e4ecbe9..b1a6395 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1242,6 +1242,9 @@ static int ac97_load (QEMUFile *f, void *opaque, int

[Qemu-devel] [PATCH 16/20] gus: port to vmstate

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/gus.c | 47 +-- 1 files changed, 17 insertions(+), 30 deletions(-) diff --git a/hw/gus.c b/hw/gus.c index d9c47b1..50c2523 100644 --- a/hw/gus.c +++ b/hw/gus.c @@ -210,35 +210,22 @@ static int

[Qemu-devel] [PATCH 19/20] ac97: up savevm version and remove active from state

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/ac97.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index b1a6395..8064fc3 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1170,7 +1170,6 @@ static void po_callback (void *opaque, int

[Qemu-devel] [PATCH 20/20] ac97: port to vmstate

2009-10-22 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/ac97.c | 101 ++-- 1 files changed, 44 insertions(+), 57 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index 8064fc3..99a43f8 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -1167,68

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Luiz Capitulino
On Wed, 21 Oct 2009 19:35:03 +0100 Jamie Lokier ja...@shareable.org wrote: Mulyadi Santosa wrote: On Wed, Oct 21, 2009 at 11:24 PM, Glauber Costa glom...@gmail.com wrote: You can provide a monitor command to do that something in the lines of: - add_macro key command_list -

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Kevin Wolf
Am 22.10.2009 16:40, schrieb Luiz Capitulino: On Wed, 21 Oct 2009 19:35:03 +0100 Jamie Lokier ja...@shareable.org wrote: If the monitor accepted ; as a command separator, to put multiple commands on a single line, command_list could just be a quoted string which is processed as a line.

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Anthony Liguori
Luiz Capitulino wrote: Yeah, I agree. When testing migration, for example, I have to type 'migrate -d tcp:0:' several times... Maybe there's a smarter way to do this, but the monitor macros idea seems interesting to me. When we have QMP, we can create a QMP socket at a well known

[Qemu-devel] [PATCH 0/8] Fix bdrv_read/write emulation

2009-10-22 Thread Kevin Wolf
The other day we re-introduced synchronous qcow2 read/write functions to work around the buggy bdrv_read/write emulation, this series implements the proper fix for it. Basically what it's doing is to ensure that the emulation only runs its own AIO callbacks and bottom halves. Callbacks from

[Qemu-devel] [PATCH 1/8] posix-aio-compat: Split out posix_aio_process_queue

2009-10-22 Thread Kevin Wolf
We need to process the request queue and run callbacks separately from reading out the queue in a later patch, so split it out. Signed-off-by: Kevin Wolf kw...@redhat.com --- posix-aio-compat.c | 43 +++ 1 files changed, 27 insertions(+), 16 deletions(-)

[Qemu-devel] [PATCH 2/8] Add qemu_aio_process_queue()

2009-10-22 Thread Kevin Wolf
We'll leave some AIO completions unhandled when we can't call the callback. qemu_aio_process_queue() is used later to run any callbacks that are left and can be run then. Signed-off-by: Kevin Wolf kw...@redhat.com --- aio.c | 30 ++ block/curl.c |

[Qemu-devel] [PATCH 3/8] Split out bottom halves

2009-10-22 Thread Kevin Wolf
Instead of putting more and more stuff into vl.c, let's have the generic functions that deal with asynchronous callbacks in their own file. Signed-off-by: Kevin Wolf kw...@redhat.com --- Makefile.target |2 +- async.c | 130 +++

[Qemu-devel] [PATCH 4/8] Introduce contexts for asynchronous callbacks

2009-10-22 Thread Kevin Wolf
Add the possibility to use AIO and BHs without allowing foreign callbacks to be run. Basically, you put your own AIOs and BHs in a separate context. For details see the comments in the source. Signed-off-by: Kevin Wolf kw...@redhat.com --- async.c | 100

[Qemu-devel] [PATCH 6/8] posix-aio-compat: Honour AsyncContext

2009-10-22 Thread Kevin Wolf
Don't call callbacks that don't belong to the active AsyncContext. Signed-off-by: Kevin Wolf kw...@redhat.com --- posix-aio-compat.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index 4901539..ec58288 100644 ---

[Qemu-devel] [PATCH 7/8] linux-aio: Honour AsyncContext

2009-10-22 Thread Kevin Wolf
Also for Linux AIO, don't call callbacks that don't belong to the active AsyncContext. Signed-off-by: Kevin Wolf kw...@redhat.com --- linux-aio.c | 87 -- 1 files changed, 72 insertions(+), 15 deletions(-) diff --git a/linux-aio.c

[Qemu-devel] [PATCH 5/8] block: Use new AsyncContext for bdrv_read/write emulation

2009-10-22 Thread Kevin Wolf
bdrv_read/write emulation is used as the perfect example why we need something like AsyncContexts. So maybe they better start using it. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 22 ++ 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/block.c

[Qemu-devel] [PATCH 8/8] Revert qcow2: Bring synchronous read/write back to life

2009-10-22 Thread Kevin Wolf
It was merely a workaround and the real fix is done now. This reverts commit ef845c3bf421290153154635dc18eaa677cecb43. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |6 ++-- block/qcow2.c | 51 +--- block/qcow2.h

Re: [Qemu-devel] [PATCH] test for lm capable kernel.

2009-10-22 Thread Anthony Liguori
Glauber Costa wrote: Don't save x86_64-specific msrs if our kernel does not support them. Code is already in qemu-kvm.git, but the test function is slightly different. It follows what the test for msr_start does. Repeat after me: I will not use --target-list when submitting qemu patches.

[Qemu-devel] Re: [ANNOUNCE] Sheepdog: Distributed Storage System for KVM

2009-10-22 Thread Anthony Liguori
Avi Kivity wrote: On 10/21/2009 07:13 AM, MORITA Kazutaka wrote: Hi everyone, Sheepdog is a distributed storage system for KVM/QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. Sheepdog supports advanced volume management features such as snapshot, cloning,

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Luiz Capitulino
On Thu, 22 Oct 2009 17:02:29 +0200 Kevin Wolf kw...@redhat.com wrote: Am 22.10.2009 16:40, schrieb Luiz Capitulino: On Wed, 21 Oct 2009 19:35:03 +0100 Jamie Lokier ja...@shareable.org wrote: If the monitor accepted ; as a command separator, to put multiple commands on a single line,

[Qemu-devel] [PATCH 01/19] net: remove unused includes of if_tun.h and if_tap.h

2009-10-22 Thread Mark McLoughlin
Looks like these are just artifacts of vl.c being split up. Signed-off-by: Mark McLoughlin mar...@redhat.com --- qemu-char.c |6 -- savevm.c|6 -- vl.c|6 -- 3 files changed, 0 insertions(+), 18 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 07/19] net: add a client type code

2009-10-22 Thread Mark McLoughlin
This is so as to allow APIs which operate on specific client types without having to add a function table entry which is only implemented by a single client type. Signed-off-by: Mark McLoughlin mar...@redhat.com --- hw/dp8393x.c |3 ++- hw/etraxfs_eth.c |3 ++- hw/mcf_fec.c |

[Qemu-devel] [PATCH 13/19] net: implement tap support for receive_raw()

2009-10-22 Thread Mark McLoughlin
tap_receive_raw() always prepends a vnet header if IFF_VNET_HDR is enabled. tap_receive() only prepends when the a header is required but the NIC doesn't supply one. Signed-off-by: Mark McLoughlin mar...@redhat.com --- net.c | 23 +++ 1 files changed, 19 insertions(+), 4

[Qemu-devel] [PATCH 02/19] net: import linux tap ioctl definitions

2009-10-22 Thread Mark McLoughlin
Making features dependent on the availability of newer versions if_tun.h is going to get seriously clumsy, so let's just import the definitions we need. It's only a small handful. If and when we're comfortable depending on 2.6.30 headers, we can remove this again. Signed-off-by: Mark McLoughlin

[Qemu-devel] [PATCH 10/19] net: add an API for 'raw' packets

2009-10-22 Thread Mark McLoughlin
In the case where a NIC and backend agree on a packet header format, this API allows injecting packets which lack the agreed upon header. We need this for sending our gratuitous ARP. Signed-off-by: Mark McLoughlin mar...@redhat.com --- net-queue.h |1 + net.c | 37

[Qemu-devel] [PATCH 08/19] net: add tap_has_vnet_hdr() and tap_using_vnet_hdr() APIs

2009-10-22 Thread Mark McLoughlin
These lamely named functions allow virtio-net to query whether IFF_VNET_HDR is enabled on a tap interface and inform the tap code that virtio-net will supply packets with a vnet header. Signed-off-by: Mark McLoughlin mar...@redhat.com --- net.c | 39 +++

[Qemu-devel] [PATCH 05/19] net: refactor tap initialization

2009-10-22 Thread Mark McLoughlin
Re-factor things so that there is only one call site for net_tap_fd_init(). Two concerns about the QemuOpts usage here - firstly, we set the script arguments to their default value and, secondly, we set the ifname value to the name allocated by the kernel if none is supplied. Are we okay with

[Qemu-devel] [PATCH 14/19] virtio-net: add vnet_hdr support

2009-10-22 Thread Mark McLoughlin
With '-netdev tap,id=foo -nic model=virtio,netdev=foo' virtio-net can detect that its peer (i.e. the tap backend) supports vnet headers and advertise to the guest that it can send packets with partial checksums and/or TSO packets. One complication is that if we're migrating and the source host

[Qemu-devel] [PATCH 18/19] Enable UFO on virtio-net and tap devices

2009-10-22 Thread Mark McLoughlin
From: Sridhar Samudrala s...@us.ibm.com Enable UFO on the host tap device if supported and allow setting UFO on virtio-net in the guest. Signed-off-by: Sridhar Samudrala s...@us.ibm.com Signed-off-by: Mark McLoughlin mar...@redhat.com --- hw/virtio-net.c | 11 +-- net.c |

[Qemu-devel] [PATCH 09/19] net: add flags parameter to packet queue interface

2009-10-22 Thread Mark McLoughlin
This allows for the addition of a raw flag, and leaves the way open for other flags too. Signed-off-by: Mark McLoughlin mar...@redhat.com --- net-queue.c | 26 ++ net-queue.h |6 ++ net.c | 14 -- 3 files changed, 36 insertions(+), 10

[Qemu-devel] [PATCH 19/19] virtio-net: add tap_has_ufo flag to saved state

2009-10-22 Thread Mark McLoughlin
If we tell the guest we support UFO and then migrate to host which doesn't support it, we will find ourselves in grave difficulties. Prevent this scenario by adding a flag to virtio-net's savevm format which indicates whether the device requires host UFO support. [v2: - add has_ufo uint8_t

[Qemu-devel] [PATCH 03/15] net: move tap-win32.c under net/

2009-10-22 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin mar...@redhat.com --- Makefile|2 +- net/tap-win32.c | 690 +++ tap-win32.c | 690 --- 3 files changed, 691 insertions(+), 691 deletions(-)

[Qemu-devel] [PATCH 06/15] net: split all the tap code out into net/tap.c

2009-10-22 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin mar...@redhat.com --- Makefile |1 + net.c | 692 +--- net.h |2 + net/tap.c | 759 + 4 files changed, 763 insertions(+), 691

[Qemu-devel] [PATCH 13/15] net: move tap_probe_vnet_hdr() to tap-linux.c

2009-10-22 Thread Mark McLoughlin
Only Linux has support for IFF_VNET_HDR Signed-off-by: Mark McLoughlin mar...@redhat.com --- net/tap-aix.c |4 net/tap-bsd.c |5 + net/tap-linux.c | 12 net/tap-solaris.c |5 + net/tap.c | 12 net/tap.h |1 + 6

[Qemu-devel] [PATCH 01/15] net: move net-queue.[ch] under net/

2009-10-22 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin mar...@redhat.com --- Makefile|6 +- net-queue.c | 260 --- net-queue.h | 71 net.h |2 +- net/queue.c | 260 +++

[Qemu-devel] [PATCH 02/15] net: move net-checksum.c under net/

2009-10-22 Thread Mark McLoughlin
Also add a new net/checksum.h header Signed-off-by: Mark McLoughlin mar...@redhat.com --- Makefile|4 +- hw/e1000.c |1 + hw/virtio-net.c |1 + hw/xen_nic.c|1 + net-checksum.c | 86 --- net.h |

[Qemu-devel] [PATCH 07/15] net: split BSD tap_open() out into net/tap-bsd.c

2009-10-22 Thread Mark McLoughlin
Signed-off-by: Mark McLoughlin mar...@redhat.com --- Makefile |1 + net/tap-bsd.c | 62 + net/tap.c | 50 +++-- net/tap.h |2 + 4 files changed, 69 insertions(+), 46

  1   2   >