Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Gleb Natapov
On Mon, Nov 16, 2009 at 09:26:20PM -0500, Kevin O'Connor wrote: On Mon, Nov 16, 2009 at 04:02:20PM +0200, Avi Kivity wrote: Something that is likely related, I am seeing reboot failures in seabios's pmm_free. Immediately after loading gpxe, seabios is in an endless loop there, likely

[Qemu-devel] [PATCH] qemu-io: Fix memory leak

2009-11-18 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-io.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index cac72e9..c84b361 100644 --- a/qemu-io.c +++ b/qemu-io.c @@ -129,7 +129,8 @@ create_iovec(QEMUIOVector *qiov, char **argv, int

Re: [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ.

2009-11-18 Thread Gerd Hoffmann
On 11/17/09 13:39, Gerd Hoffmann wrote: Isn't that easy because scsi-disk and scsi-generic keep a pool of unused request structures. I didn't change that for now, although I've considered dropping it. Not sure how important it is these days, malloc implementations don't do slow+stupid list walks

[Qemu-devel] [PATCH] qemu-img: Fix memory leak

2009-11-18 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 972843a..e4ffe46 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -607,6 +607,7 @@ static int img_convert(int argc, char **argv) if

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Alexander Graf
On 18.11.2009, at 10:39, Gleb Natapov wrote: On Mon, Nov 16, 2009 at 09:26:20PM -0500, Kevin O'Connor wrote: On Mon, Nov 16, 2009 at 04:02:20PM +0200, Avi Kivity wrote: Something that is likely related, I am seeing reboot failures in seabios's pmm_free. Immediately after loading gpxe,

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Gleb Natapov
On Wed, Nov 18, 2009 at 10:49:37AM +0100, Alexander Graf wrote: On 18.11.2009, at 10:39, Gleb Natapov wrote: On Mon, Nov 16, 2009 at 09:26:20PM -0500, Kevin O'Connor wrote: On Mon, Nov 16, 2009 at 04:02:20PM +0200, Avi Kivity wrote: Something that is likely related, I am seeing reboot

Re: [Qemu-devel] [PATCH 3/3] Add test suite for json marshalling

2009-11-18 Thread Markus Armbruster
Jamie Lokier ja...@shareable.org writes: Anthony Liguori wrote: After checking that we can demarshal, marshal again and compared to the expected decoded value. This doesn't work so well for floats because they cannot be accurately represented in decimal but we try our best. Good

[Qemu-devel] Fwd: qemu code review

2009-11-18 Thread Kevin Wolf
Hi all, as Steve suggests, I'm forwarding the list of issues he found to the mailing list. I've already looked at a few points in the block code and sent patches. If everyone picks up one point, we should get through the list quickly. Who volunteers for the TCG ones? ;-) Kevin

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 10:49:37AM +0100, Alexander Graf wrote: Are you sure vapic.bin still works with SeaBIOS? I've had to modify the multiboot and linuxboot code to write to the stack because the code section of the option rom was read only. SeaBIOS should be making the code writable

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 11:39:49AM +0200, Gleb Natapov wrote: On Mon, Nov 16, 2009 at 09:26:20PM -0500, Kevin O'Connor wrote: I do see an issue if SeaBIOS's reboot vector is called (eg, by using sendkey ctrl-alt-delete while still in the bios) because seabios allows gpxe to modify itself,

[Qemu-devel] Re: [RFC] KVM Fault Tolerance: Kemari for KVM

2009-11-18 Thread Yoshiaki Tamura
2009/11/17 Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp: Avi Kivity wrote: On 11/16/2009 04:18 PM, Fernando Luis Vázquez Cao wrote: Avi Kivity wrote: On 11/09/2009 05:53 AM, Fernando Luis Vázquez Cao wrote: Kemari runs paired virtual machines in an active-passive configuration and

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Avi Kivity
On 11/18/2009 11:39 AM, Gleb Natapov wrote: Hi Avi, Can you send the full qemu command line that you used? I can't seem to reproduce this on my setup. I do see an issue if SeaBIOS's reboot vector is called (eg, by using sendkey ctrl-alt-delete while still in the bios) because seabios allows

[Qemu-devel] Re: [RFC] KVM Fault Tolerance: Kemari for KVM

2009-11-18 Thread Avi Kivity
On 11/18/2009 03:28 PM, Yoshiaki Tamura wrote: I don't think lmbench is intensive but it's sensitive to memory latency. We'll measure kernel build time with minimum config, and post it later. Here are some quick numbers of parallel kernel compile time. The number of vcpu is 1, just for

[Qemu-devel] [PATCH] multiboot: Fix module loading and setting of mmap

2009-11-18 Thread Adam Lackorzynski
Hi, I need to following to fix multiboot booting for me. Should linuxboot.bin and multiboot.bin end up in pc-bios instead of pc-bios/optionrom? Signed-off-by: Adam Lackorzynski a...@os.inf.tu-dresden.de --- hw/pc.c |4 ++-- pc-bios/optionrom/multiboot.S |5 -

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Gleb Natapov
On Wed, Nov 18, 2009 at 03:50:20PM +0200, Avi Kivity wrote: On 11/18/2009 11:39 AM, Gleb Natapov wrote: Hi Avi, Can you send the full qemu command line that you used? I can't seem to reproduce this on my setup. I do see an issue if SeaBIOS's reboot vector is called (eg, by using

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Avi Kivity
On 11/18/2009 04:19 PM, Gleb Natapov wrote: Do we have the same problem with tpr patching rom (vapic,bin)? It modifies itself too. But a reset will reload it. Correct, but Kevin says sendkey ctrl-alt-delete jumps to SeaBIOS's reboot vector without issuing system reset. I am

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Gleb Natapov
On Wed, Nov 18, 2009 at 08:06:26AM -0500, Kevin O'Connor wrote: On Wed, Nov 18, 2009 at 11:39:49AM +0200, Gleb Natapov wrote: On Mon, Nov 16, 2009 at 09:26:20PM -0500, Kevin O'Connor wrote: I do see an issue if SeaBIOS's reboot vector is called (eg, by using sendkey ctrl-alt-delete while

Re: [Qemu-devel] [PATCH] multiboot: Fix module loading and setting of mmap

2009-11-18 Thread Alexander Graf
Adam Lackorzynski wrote: Hi, I need to following to fix multiboot booting for me. Should linuxboot.bin and multiboot.bin end up in pc-bios instead of pc-bios/optionrom? Signed-off-by: Adam Lackorzynski a...@os.inf.tu-dresden.de --- hw/pc.c |4 ++--

Re: [Qemu-devel] [PATCH] multiboot: Fix module loading and setting of mmap

2009-11-18 Thread Anthony Liguori
Adam Lackorzynski wrote: Hi, I need to following to fix multiboot booting for me. Should linuxboot.bin and multiboot.bin end up in pc-bios instead of pc-bios/optionrom? Signed-off-by: Adam Lackorzynski a...@os.inf.tu-dresden.de --- hw/pc.c |4 ++--

[Qemu-devel] Re: [PATCH] qemu-kvm: clear only essential parts of VirtIOBlockReq on object allocation - RESUBMIT

2009-11-18 Thread Saul Tamari
ok, Below is the patch. This time resent with mutt and hopefully without whitespace changes. This patch reduces the amount of memory being cleared on every virtio-blk IO operation. Improve number of IOPS when using

Re: [Qemu-devel] [PATCH 0/2] extboot reloaded.

2009-11-18 Thread Anthony Liguori
Kevin O'Connor wrote: The order of hard drives is determined by the BCV list. There is only one entry in the IPL table for booting from a hard drive - selecting -boot c prioritizes this IPL - hard drive booting always boots from the C drive. It's possible to tell SeaBIOS to map the C drive to

Re: [Qemu-devel] [PATCH] multiboot: Fix module loading and setting of mmap

2009-11-18 Thread Adam Lackorzynski
On Wed Nov 18, 2009 at 15:33:10 +0100, Alexander Graf wrote: Adam Lackorzynski wrote: I need to following to fix multiboot booting for me. Should linuxboot.bin and multiboot.bin end up in pc-bios instead of pc-bios/optionrom? load_image(initrd_filename,

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V2)

2009-11-18 Thread Anthony Liguori
Rusty Russell wrote: On Wed, 18 Nov 2009 07:06:29 am Adam Litke wrote: virtio: Add memory statistics reporting to the balloon driver (V2) Changes since V1: - Use a virtqueue instead of the device config space Hi Adam, If Anthony's happy, I'm happy with this approach. Couple of

Re: [Qemu-devel] [PATCH] multiboot: Fix module loading and setting of mmap

2009-11-18 Thread Alexander Graf
Adam Lackorzynski wrote: On Wed Nov 18, 2009 at 15:33:10 +0100, Alexander Graf wrote: Adam Lackorzynski wrote: I need to following to fix multiboot booting for me. Should linuxboot.bin and multiboot.bin end up in pc-bios instead of pc-bios/optionrom?

Re: [Qemu-devel] Re: [PATCH 01/12] TCG sync op

2009-11-18 Thread Aurelien Jarno
On Wed, Nov 18, 2009 at 01:01:13AM +0100, Alexander Graf wrote: On 18.11.2009, at 00:40, Aurelien Jarno wrote: On Wed, Nov 11, 2009 at 12:56:47AM +, Paul Brook wrote: On Thursday 22 October 2009, Aurelien Jarno wrote: On Wed, Oct 21, 2009 at 03:52:22PM +0200, Ulrich Hecht wrote: sync

[Qemu-devel] [PATCH] qemu-io: build on all platforms

2009-11-18 Thread Aurelien Jarno
Since c32d766af127f68bb75ba5689f2f5239227bf559, qemu-io should be portable. It is currently built only on linux and mingw32. This patch enables qemu-io on all platforms. Tested on FreeBSD. Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- configure |6 ++ 1 files changed, 2

Re: [Qemu-devel] [PATCH 07/10] Introduce QError

2009-11-18 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: QError is a high-level data type which represents an exception in QEMU, it stores the following error information: - class Error class name (eg. ServiceUnavailable) - descriptionA detailed error description, which can contain

Re: [Qemu-devel] [PATCH 08/10] monitor: QError support

2009-11-18 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: This commit adds QError support in the Monitor. A QError member is added to the Monitor struct. This new member stores error information and is also used to check if an error has occurred when the called handler returns. Additionally, a new

Re: [Qemu-devel] [PATCH 09/10] qdev: Use QError for 'device not found' error

2009-11-18 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/qdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d19d531..875ca50 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -29,6

Re: [Qemu-devel] [PATCH 10/10] monitor: do_info_balloon(): use QError

2009-11-18 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 74abef9..e42434f 100644 --- a/monitor.c +++ b/monitor.c @@

Re: [Qemu-devel] Re: [PATCH 01/12] TCG sync op

2009-11-18 Thread Alexander Graf
Aurelien Jarno wrote: On Wed, Nov 18, 2009 at 01:01:13AM +0100, Alexander Graf wrote: On 18.11.2009, at 00:40, Aurelien Jarno wrote: On Wed, Nov 11, 2009 at 12:56:47AM +, Paul Brook wrote: On Thursday 22 October 2009, Aurelien Jarno wrote: On Wed, Oct 21, 2009

Re: [Qemu-devel] Re: [PATCH 01/12] TCG sync op

2009-11-18 Thread Paul Brook
That's an option, basically keeping the list (or only one ?) of aliased TCG variables for each of them, and freeing the others before using one. Yeah, only one. I don't think this should be getting overengineered (and thus slow) :-). Doesn't really sound hard, does it? Any TCG magicians

Re: [Qemu-devel] [RFC 0/8]: QError v2

2009-11-18 Thread Markus Armbruster
Anthony Liguori aligu...@linux.vnet.ibm.com writes: Luiz Capitulino wrote: #define QERR_DEVICE_ALREADY_OPEN {'class': 'DeviceAlreadyOpen', data' : {'bus_num': %d, 'addr': %d} qemu_error_new(QERR_DEVICE_ALREADY_OPEN, bus_num, addr); What about DeviceAlreadyOpen errors with a

Re: [Qemu-devel] [PATCH 10/10] monitor: do_info_balloon(): use QError

2009-11-18 Thread Anthony Liguori
Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 74abef9..e42434f 100644 --- a/monitor.c +++

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-18 Thread Markus Armbruster
I'm sorry, but I'm still quite unhappy with the error reporting part of QMP. In short: 1. QError feels overengineered, particularly for a first iteration of a protocol. We go to great lengths to build highly structured error objects. There is only one sane reason for doing that: a

Re: [Qemu-devel] Fwd: qemu code review

2009-11-18 Thread malc
On Wed, 18 Nov 2009, Kevin Wolf wrote: Hi all, as Steve suggests, I'm forwarding the list of issues he found to the mailing list. I've already looked at a few points in the block code and sent patches. If everyone picks up one point, we should get through the list quickly. Who volunteers

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V2)

2009-11-18 Thread Jamie Lokier
Anthony Liguori wrote: Rusty Russell wrote: The little-endian conversion of the balloon driver is a historical mistake (no other driver does this). Let's not extend it to the stats. I think the mistake is that the other drivers don't do that. We cheat in qemu and assume that the guest is

Re: [Qemu-devel] [PATCH 07/10] Introduce QError

2009-11-18 Thread Luiz Capitulino
On Wed, 18 Nov 2009 16:16:11 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: [...] +static const char *append_field(QString *outstr, const QError *qerror, +const char *start) +{ +QObject *obj; +

Re: [Qemu-devel] [PATCH 08/10] monitor: QError support

2009-11-18 Thread Luiz Capitulino
On Wed, 18 Nov 2009 16:16:40 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: This commit adds QError support in the Monitor. A QError member is added to the Monitor struct. This new member stores error information and is also used to

Re: [Qemu-devel] [PATCH 09/10] qdev: Use QError for 'device not found' error

2009-11-18 Thread Luiz Capitulino
On Wed, 18 Nov 2009 16:17:02 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/qdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-18 Thread Anthony Liguori
Markus Armbruster wrote: 1. QError feels overengineered, particularly for a first iteration of a protocol. We go to great lengths to build highly structured error objects. There is only one sane reason for doing that: a demonstrated client need. I can't see that need. A GUI

Re: [Qemu-devel] [PATCH 10/10] monitor: do_info_balloon(): use QError

2009-11-18 Thread Luiz Capitulino
On Wed, 18 Nov 2009 09:58:30 -0600 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: Markus Armbruster wrote: Luiz Capitulino lcapitul...@redhat.com writes: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |7 --- 1 files changed, 4 insertions(+), 3

[Qemu-devel] Re: [PATCH 00/10]: QError v4

2009-11-18 Thread Paolo Bonzini
2. It falls short of the requirement that clients can reasonably classify errors they don't know. True. (Though adding a classification mechanism can be done later once we have an idea of what errors are there at all). 3. It falls short of the requirement that clients can easily

Re: [Qemu-devel] [PATCH 07/10] Introduce QError

2009-11-18 Thread Daniel P. Berrange
On Tue, Nov 17, 2009 at 05:43:54PM -0200, Luiz Capitulino wrote: QError is a high-level data type which represents an exception in QEMU, it stores the following error information: - class Error class name (eg. ServiceUnavailable) - descriptionA detailed error description, which

Re: [Qemu-devel] Fwd: qemu code review

2009-11-18 Thread Blue Swirl
On Wed, Nov 18, 2009 at 1:39 PM, Kevin Wolf kw...@redhat.com wrote: Hi all, as Steve suggests, I'm forwarding the list of issues he found to the mailing list. I've already looked at a few points in the block code and sent patches. If everyone picks up one point, we should get through the

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-18 Thread Christoph Hellwig
It seems like this series is now in qemu.git, but I still can't boot using -kernel. I'm starting qemu as: /opt/qemu/bin/qemu-system-x86_64 \ -m 1500 -enable-kvm \ -kernel arch/x86/boot/bzImage \ -drive file=/dev/vg00/qemu-root,if=virtio,media=disk,cache=none,aio=threads

Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak

2009-11-18 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] Fwd: qemu code review

2009-11-18 Thread Stefan Weil
Kevin Wolf schrieb: Hi all, as Steve suggests, I'm forwarding the list of issues he found to the mailing list. I've already looked at a few points in the block code and sent patches. If everyone picks up one point, we should get through the list quickly. Who volunteers for the TCG ones? ;-)

[Qemu-devel] CDROM on SCSI?

2009-11-18 Thread Nick Couchman
I'm currently trying to start qemu with an ISO image presented as a CD-ROM on the SCSI bus. The argument looks like this: -drive file=/misc/iso/Solaris/sol-nv-b127-c-dvd.iso,if=scsi,media=cdrom,bus=0,unit=6 but, it looks like qemu is forcing it onto an IDE device. Is CD-ROM on SCSI not

Re: [Qemu-devel] [PATCH] vga: do not resize the screen on hw_invalidate

2009-11-18 Thread Stefan Weil
Stefano Stabellini schrieb: Hi all, currently vga always resizes the screen when vga_hw_invalidate is called while this is not required and all the other graphic emulators don't. This patch fixes it, making vga invalidate behaviour consistent with the other emulated devices. Signed-off-by:

Re: [Qemu-devel] Need a way disable gPXE boot

2009-11-18 Thread Anthony Liguori
Hi Ted, Theodore Ts'o wrote: I recently updated to the latest qemu-kvm git tree (commit c04b2ae) and I ran into the following problem. I want to do a direct Linux boot for some of my testing work, using the -kernel option. Apparently the the gPXE boot code corrupts something in memory or

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-18 Thread Anthony Liguori
Christoph Hellwig wrote: It seems like this series is now in qemu.git, but I still can't boot using -kernel. I'm starting qemu as: /opt/qemu/bin/qemu-system-x86_64 \ -m 1500 -enable-kvm \ -kernel arch/x86/boot/bzImage \ -drive

Re: [Qemu-devel] [PATCH 07/10] Introduce QError

2009-11-18 Thread Anthony Liguori
Daniel P. Berrange wrote: On Tue, Nov 17, 2009 at 05:43:54PM -0200, Luiz Capitulino wrote: QError is a high-level data type which represents an exception in QEMU, it stores the following error information: - class Error class name (eg. ServiceUnavailable) - descriptionA

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-18 Thread Christoph Hellwig
On Wed, Nov 18, 2009 at 01:55:48PM -0600, Anthony Liguori wrote: Did you rebuild qemu and make sure the new BIOS/roms were installed? and it simply hangs with a black screen once the SDL window opens I had this problem because I had not rebuilt qemu. I did a make clean; ./configure;

Re: [Qemu-devel] [PATCH 07/10] Introduce QError

2009-11-18 Thread Luiz Capitulino
On Wed, 18 Nov 2009 13:58:17 -0600 Anthony Liguori aligu...@linux.vnet.ibm.com wrote: Daniel P. Berrange wrote: On Tue, Nov 17, 2009 at 05:43:54PM -0200, Luiz Capitulino wrote: QError is a high-level data type which represents an exception in QEMU, it stores the following error

[Qemu-devel] Re: Need a way disable gPXE boot

2009-11-18 Thread Sebastian Herbszt
Theodore Ts'o wrote: [snip] I was ultimately able to work around the solution by deleting the /usr/local/share/qemu/pxe-*.bin files, but that's a bit of a botch. It would be nice if there was a way to disable the gPXE boot option roms; if you know you are booting off of a passed in hard drive

[Qemu-devel] Fwd: [Vorbis] Open Video Alliance Contest

2009-11-18 Thread jairo mayorga
-- Forwarded message -- From: Josh Levy j...@openvideoalliance.org Date: 2009/11/17 Subject: [Vorbis] Open Video Alliance Contest To: vor...@xiph.org Want to win a trip to South By Southwest 2010? Or maybe a Flip Mino video camera? Read on... Open Video in 60 Seconds The Open

Re: [Qemu-devel] [PATCH 0/6] Fix -kernel with SeaBIOS v2

2009-11-18 Thread Anthony Liguori
Christoph Hellwig wrote: On Wed, Nov 18, 2009 at 01:55:48PM -0600, Anthony Liguori wrote: Did you rebuild qemu and make sure the new BIOS/roms were installed? and it simply hangs with a black screen once the SDL window opens I had this problem because I had not rebuilt qemu.

Re: [Qemu-devel] Need a way disable gPXE boot

2009-11-18 Thread tytso
On Wed, Nov 18, 2009 at 01:53:42PM -0600, Anthony Liguori wrote: We just did a flag day and switched our PXE rom and BIOS. We've encountered a few regressions and we're quickly fixing them. Alex Graf has already fixed the problem you describe above properly and I've merged that into

Re: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V2)

2009-11-18 Thread Rusty Russell
On Thu, 19 Nov 2009 01:32:26 am Anthony Liguori wrote: Rusty Russell wrote: The little-endian conversion of the balloon driver is a historical mistake (no other driver does this). Let's not extend it to the stats. I think the mistake is that the other drivers don't do that. We cheat in

[Qemu-devel] [PATCH 00/13]: QError v5

2009-11-18 Thread Luiz Capitulino
Hi, This new QError version addresses the comments from the last submission. Anthony, please note that my conversion series submitted yesterday: http://lists.gnu.org/archive/html/qemu-devel/2009-11/msg01007.html Doesn't depend on QError and can be merged independently of it. changelog

[Qemu-devel] [PATCH 01/13] QJSON: Introduce qobject_from_jsonv()

2009-11-18 Thread Luiz Capitulino
It accepts a va_list and will be used by QError. Also simplifies the code a little, as the other qobject_from_() functions can use it. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qjson.c | 21 +++-- qjson.h |2 ++ 2 files changed, 13 insertions(+), 10

[Qemu-devel] [PATCH 02/13] QString: Introduce qstring_append_chr()

2009-11-18 Thread Luiz Capitulino
It appends a C char to a QString. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qstring.c | 24 +++- qstring.h |1 + 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/qstring.c b/qstring.c index 441a9e6..e422bd9 100644 --- a/qstring.c +++

[Qemu-devel] [PATCH 03/13] QString: Introduce qstring_append_int()

2009-11-18 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qstring.c |8 qstring.h |2 ++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/qstring.c b/qstring.c index e422bd9..ad17769 100644 --- a/qstring.c +++ b/qstring.c @@ -75,6 +75,14 @@ void

[Qemu-devel] [PATCH 04/13] QString: Introduce qstring_from_substr()

2009-11-18 Thread Luiz Capitulino
Note that we can now write qstring_from_str() as a wrapper. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qstring.c | 20 +++- qstring.h |1 + 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/qstring.c b/qstring.c index ad17769..740a106 100644 ---

[Qemu-devel] [PATCH 05/13] utests: Add qstring_append_chr() unit-test

2009-11-18 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- check-qstring.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/check-qstring.c b/check-qstring.c index ea4dfd0..412038a 100644 --- a/check-qstring.c +++ b/check-qstring.c @@ -55,6 +55,22 @@

[Qemu-devel] [PATCH 06/13] utests: Add qstring_from_substr() unit-test

2009-11-18 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- check-qstring.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/check-qstring.c b/check-qstring.c index 412038a..c308a63 100644 --- a/check-qstring.c +++ b/check-qstring.c @@ -71,6 +71,19 @@

[Qemu-devel] [PATCH 07/13] Introduce QError

2009-11-18 Thread Luiz Capitulino
QError is a high-level data type which represents an exception in QEMU, it stores the following error information: - class Error class name (eg. ServiceUnavailable) - descriptionA detailed error description, which can contain references to run-time error data -

[Qemu-devel] [PATCH 08/13] monitor: QError support

2009-11-18 Thread Luiz Capitulino
This commit adds QError support in the Monitor. A QError member is added to the Monitor struct. This new member stores error information and is also used to check if an error has occurred when the called handler returns. Additionally, a new macro called qemu_error_new() is introduced. It builds

[Qemu-devel] [PATCH 09/13] QError: Add QERR_DEVICE_NOT_FOUND

2009-11-18 Thread Luiz Capitulino
New class for device not found errors. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c |4 qerror.h |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 10b0939..a12e7f7 100644 --- a/qerror.c +++ b/qerror.c @@ -40,6

[Qemu-devel] [PATCH 10/13] qdev: Use QError for 'device not found' error

2009-11-18 Thread Luiz Capitulino
Please, note that we will lose the Try -device '?' for a list hint as it's qdev specific. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/qdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index d19d531..875ca50 100644 ---

[Qemu-devel] [PATCH 11/13] QError: Add QERR_DEVICE_NOT_ACTIVE

2009-11-18 Thread Luiz Capitulino
New class for device not active errors. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index a12e7f7..0c0a510 100644 --- a/qerror.c +++ b/qerror.c @@ -44,6

[Qemu-devel] [PATCH 12/13] QError: Add QERR_KVM_MISSING_CAP

2009-11-18 Thread Luiz Capitulino
New class for KVM unavailable features errors. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 0c0a510..d8b125e 100644 --- a/qerror.c +++ b/qerror.c @@

[Qemu-devel] [PATCH 13/13] monitor: do_info_balloon(): Use QError

2009-11-18 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- monitor.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index da05bf4..549e98b 100644 --- a/monitor.c +++ b/monitor.c @@ -1722,10 +1722,9 @@ static void do_info_balloon(Monitor *mon,

Re: [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 04:22:17PM +0200, Gleb Natapov wrote: On Wed, Nov 18, 2009 at 08:06:26AM -0500, Kevin O'Connor wrote: On Wed, Nov 18, 2009 at 11:39:49AM +0200, Gleb Natapov wrote: On Mon, Nov 16, 2009 at 09:26:20PM -0500, Kevin O'Connor wrote: I do see an issue if SeaBIOS's

Re: [Qemu-devel] [PATCH 0/2] extboot reloaded.

2009-11-18 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 08:42:10AM -0600, Anthony Liguori wrote: Kevin O'Connor wrote: The order of hard drives is determined by the BCV list. There is only one entry in the IPL table for booting from a hard drive - selecting -boot c prioritizes this IPL - hard drive booting always boots from

Re: [Qemu-devel] [PATCH 00/10]: QError v4

2009-11-18 Thread Jamie Lokier
Anthony Liguori wrote: Markus Armbruster wrote: 3. It falls short of the requirement that clients can easily present a human-readable error description to their human users, regardless of whether they know the error or not. That's just incorrect. We provide an example conversion

Re: [Qemu-devel] Re: SeaBIOS cdrom regression with Vista

2009-11-18 Thread Kevin O'Connor
On Wed, Nov 18, 2009 at 12:19:20AM -0500, Kevin O'Connor wrote: On Tue, Nov 17, 2009 at 03:21:31PM +0200, Avi Kivity wrote: qemu-kvm's switch to seabios uncovered a regression with cdrom handling. Vista x64 no longer recognizes the cdrom, while pc-bios still works. Installing works, but

[Qemu-devel] Re: [RFC] KVM Fault Tolerance: Kemari for KVM

2009-11-18 Thread Yoshiaki Tamura
2009/11/18 Avi Kivity a...@redhat.com: On 11/18/2009 03:28 PM, Yoshiaki Tamura wrote: I don't think lmbench is intensive but it's sensitive to memory latency. We'll measure kernel build time with minimum config, and post it later. Here are some quick numbers of parallel kernel compile time.

Re: [gPXE] [Qemu-devel] Stack corruption problem with SeaBIOS/gPXE under QEMU

2009-11-18 Thread Joshua Oreman
On Wed, Nov 18, 2009 at 9:22 AM, Gleb Natapov g...@redhat.com wrote: On Wed, Nov 18, 2009 at 08:06:26AM -0500, Kevin O'Connor wrote: On Wed, Nov 18, 2009 at 11:39:49AM +0200, Gleb Natapov wrote: On Mon, Nov 16, 2009 at 09:26:20PM -0500, Kevin O'Connor wrote: I do see an issue if SeaBIOS's

[Qemu-devel] [BUG] Changing SDL full screen mode no longer works

2009-11-18 Thread Stefan Weil
Stefan Weil schrieb: Stefano Stabellini schrieb: Hi all, currently vga always resizes the screen when vga_hw_invalidate is called while this is not required and all the other graphic emulators don't. This patch fixes it, making vga invalidate behaviour consistent with the other emulated