Re: [Qemu-devel] [PATCH v2 resend 3/4] Block: readonly changes

2010-02-05 Thread Kevin Wolf
Am 04.02.2010 23:04, schrieb Naphtali Sprei: Open backing file for read-only During commit upgrade to read-write and back at end to read-only Signed-off-by: Naphtali Sprei nsp...@redhat.com --- block.c | 68 --- block_int.h |

Re: [Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor directives

2010-02-05 Thread Kevin Wolf
Am 05.02.2010 03:26, schrieb Sheng Yang: On Thursday 04 February 2010 23:49:55 Paolo Bonzini wrote: Patch 1 is the same I sent earlier. Patches 2 and 3/4 fix the other two problems by Sheng (tip: next time use make -k and report all problems in a single message). Paolo Bonzini (4):

Re: [Qemu-devel] [PATCH v2 0/4]: QMP capability negotiation support

2010-02-05 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Capability negotiation allows clients to enable new QMP capabilities they support and thus allows QMP to evolve in a compatible way. This series implements Markus's design and is a revamp of the previous one. It's very simple now, as

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-05 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 02/04/2010 02:13 PM, Luiz Capitulino wrote: Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated in the callers. Signed-off-by: Luiz Capitulinolcapitul...@redhat.com ---

Re: [Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults

2010-02-05 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Ideally, Monitor code should report an error only once and return the error information up the call chain. To assure that this happens as expected and that no error is lost, we have an assert() in qemu_error_internal(). However, we still have

Re: [Qemu-devel] Adding support for MIPS64 as host

2010-02-05 Thread Rtp
pinery pinewood@gmail.com writes: Hi, 於 四,2010-02-04 於 22:56 +0530,Utkarsh Sopan 提到: Can you tell me what is the status of adding MIPS64 support? as at the wiki page it showed Red earlier. On Wed, Feb 3, 2010 at 10:29 PM, Laurent Desnogues laurent.desnog...@gmail.com wrote:

[Qemu-devel] Re: [PATCH 0/4] Fix printf calls embedding preprocessor directives

2010-02-05 Thread Paolo Bonzini
On 02/05/2010 03:26 AM, Sheng Yang wrote: -#ifndef _WIN32 - DEFAULT_NETWORK_SCRIPT, - DEFAULT_NETWORK_DOWN_SCRIPT, -#endif - DEFAULT_GDBSTUB_PORT, - /tmp/qemu.log); + qemu); exit(exitcode); } Is it proper to remove #ifndef _WIN32 there?

[Qemu-devel] [PATCH v2] vnc: Migrate to using QTAILQ instead of custom implementation

2010-02-05 Thread Amit Shah
Just a 1-1 conversion for now. Signed-off-by: Amit Shah amit.s...@redhat.com --- v2: - QTAILQ_INIT the queue. vnc.c | 74 vnc.h |5 ++- 2 files changed, 31 insertions(+), 48 deletions(-) diff --git a/vnc.c b/vnc.c index

[Qemu-devel] Re: [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-05 Thread Jan Kiszka
OHMURA Kei wrote: dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. But We think that dirty-bitmap-traveling by long size is faster than by byte size especially when most of memory is not dirty. Sounds logical - do you have numbers on the improvement? Would be great if you

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-05 Thread Luiz Capitulino
On Thu, 04 Feb 2010 16:31:46 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 02/04/2010 02:13 PM, Luiz Capitulino wrote: Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated in the callers. Signed-off-by: Luiz

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-05 Thread Luiz Capitulino
On Fri, 05 Feb 2010 10:13:33 +0100 Markus Armbruster arm...@redhat.com wrote: Anthony Liguori anth...@codemonkey.ws writes: On 02/04/2010 02:13 PM, Luiz Capitulino wrote: Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is duplicated

[Qemu-devel] Re: kqemu and XP guest - lock-up at mup.sys

2010-02-05 Thread Jan Kiszka
Gordan Bobic wrote: Hi, It would appear that kqemu somehow breaks the XP guest under some circumstances. If I install from scratch in qemu+kqemu, it works fine in kqemu, but not on bare metal. The fact it doesn't work on bare metal COULD be related to the fact that on bare metal I'm

Re: [Qemu-devel] [PATCH 2/4] block: add block topology options

2010-02-05 Thread Christoph Hellwig
On Wed, Feb 03, 2010 at 01:00:47PM -0600, Anthony Liguori wrote: But I don't think this is the wrong place to do it. The BlockDriverState reflects that backing device, not the emulated device itself. In this case, you're trying to set a property of the emulated device. I think that's

[Qemu-devel] [PULL] linux-user-for upstream

2010-02-05 Thread Riku Voipio
Same patchset as sent last week, with the TLS patched changed to the refactor cp15.c13 patch already acked by Laurent. The following changes since commit 117f8eb81dfdf51a0418fbf6d260cbb72bcd4a9d: Markus Armbruster (1): qdev: Add rudimentary help for property value are available in the

Re: [Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults

2010-02-05 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Luiz Capitulino lcapitul...@redhat.com writes: Ideally, Monitor code should report an error only once and return the error information up the call chain. To assure that this happens as expected and that no error is lost, we have an assert() in

Re: [Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults

2010-02-05 Thread Luiz Capitulino
On Fri, 05 Feb 2010 15:21:13 +0100 Markus Armbruster arm...@redhat.com wrote: Markus Armbruster arm...@redhat.com writes: Luiz Capitulino lcapitul...@redhat.com writes: Ideally, Monitor code should report an error only once and return the error information up the call chain. To

[Qemu-devel] TB monitoring

2010-02-05 Thread Clemens Kolbitsch
Guys, I need a Qemu-internals expert to help me out here: I'm trying to monitor execution of certain (user-land) TBs in a i386-softmmu system. For this, the cpu-main loop has been patched: Before jumping into a TB's generated code, I first check its guest-virtual start address whether it

Re: [Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults

2010-02-05 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 05 Feb 2010 15:21:13 +0100 Markus Armbruster arm...@redhat.com wrote: Markus Armbruster arm...@redhat.com writes: Luiz Capitulino lcapitul...@redhat.com writes: Ideally, Monitor code should report an error only once and return

[Qemu-devel] [PATCH 4/4] target-arm: neon fix

2010-02-05 Thread Riku Voipio
From: Juha Riihimäki juha.riihim...@nokia.com add an extra check in two registers and a shift to ensure element size decoding logic cannot fail. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com Signed-off-by: Riku Voipio riku.voi...@nokia.com --- target-arm/translate.c |3 ++- 1 files

[Qemu-devel] [PATCH 0/4] arm/neon fixes

2010-02-05 Thread Riku Voipio
From: Riku Voipio riku.voi...@nokia.com neon emulation enhancements was already sent earlier, other patches are new. vshll and vraddhn fixes are needed to pass the pixman testsuite when pixman is compiled with NEON support. Thanks to Siamashka Siarhei for pointing us to this testsuite. Also

[Qemu-devel] [PATCH 1/4] target-arm: neon - fix VRADDHN/VRSUBHN vs VADDHN/VSUBHN

2010-02-05 Thread Riku Voipio
From: Riku Voipio riku.voi...@nokia.com The rounding/truncating options were inverted. truncating was done when rounding was meant and vice verse. Signed-off-by: Riku Voipio riku.voi...@nokia.com --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 2/4] target-arm: neon vshll instruction fix

2010-02-05 Thread Riku Voipio
From: Juha Riihimäki juha.riihim...@nokia.com implementation only widened the 32bit source vector elements into a 64bit destination vector but forgot to perform the actual shifting operation. Signed-off-by: Juha Riihimäki juha.riihim...@nokia.com Signed-off-by: Riku Voipio riku.voi...@nokia.com

[Qemu-devel] [PATCH 3/4] target-arm: neon emulation enhancements

2010-02-05 Thread Riku Voipio
From: Juha Riihimäki juha.riihim...@nokia.com This patch improves the detection of undefined NEON data instruction encodings, fixes bugs in some of the instruction decodings and adds an implementation for 64bit wide vsli and vsri instructions. Signed-off-by: Juha Riihimäki

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-05 Thread Anthony Liguori
On 02/05/2010 06:12 AM, Luiz Capitulino wrote: On Thu, 04 Feb 2010 16:31:46 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 02/04/2010 02:13 PM, Luiz Capitulino wrote: Add an assert() to qobject_from_jsonf() to assure that the returned QObject is not NULL. Currently this is

Re: [Qemu-devel] Re: kqemu and XP guest - lock-up at mup.sys

2010-02-05 Thread Jamie Lokier
Gordan Bobic wrote: Jan Kiszka wrote: Gordan Bobic wrote: Due to limitations of the x86 architecture, kqemu used to be far a way from providing accurate virtualization. KVM is subject to the same limitations, though, so that point is a bit moot. No, it isn't. The VT/SVM extensions used

Re: [Qemu-devel] [PATCH 2/4] block: add block topology options

2010-02-05 Thread Jamie Lokier
Christoph Hellwig wrote: On Wed, Feb 03, 2010 at 01:00:47PM -0600, Anthony Liguori wrote: But I don't think this is the wrong place to do it. The BlockDriverState reflects that backing device, not the emulated device itself. In this case, you're trying to set a property of the emulated

Re: [Qemu-devel] [PATCH 2/4] block: add block topology options

2010-02-05 Thread Christoph Hellwig
On Fri, Feb 05, 2010 at 04:16:20PM +, Jamie Lokier wrote: If you move your VM to a new system with different backing devices, sometimes you want to be sure there is no guest-visible change. Or even if you just replace a drive - you might prefer confidence that the guest sees no change.

[Qemu-devel] Re: kqemu and XP guest - lock-up at mup.sys

2010-02-05 Thread Jan Kiszka
Gordan Bobic wrote: Jan Kiszka wrote: Gordan Bobic wrote: Hi, It would appear that kqemu somehow breaks the XP guest under some circumstances. If I install from scratch in qemu+kqemu, it works fine in kqemu, but not on bare metal. The fact it doesn't work on bare metal COULD be related

Re: [Qemu-devel] [PATCH 3/4] QError: Don't abort on multiple faults

2010-02-05 Thread Luiz Capitulino
On Fri, 05 Feb 2010 16:15:56 +0100 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 05 Feb 2010 15:21:13 +0100 Markus Armbruster arm...@redhat.com wrote: Markus Armbruster arm...@redhat.com writes: Luiz Capitulino

Re: [Qemu-devel] [PATCH 1/4] qjson: Improve debugging

2010-02-05 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 02/05/2010 06:12 AM, Luiz Capitulino wrote: On Thu, 04 Feb 2010 16:31:46 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 02/04/2010 02:13 PM, Luiz Capitulino wrote: Add an assert() to qobject_from_jsonf() to assure that the

Re: [Qemu-devel] [PATCH 2/4] block: add block topology options

2010-02-05 Thread Jamie Lokier
Christoph Hellwig wrote: Note that not the physical block size attribute can we a data integrity issue, though. I agree. A storage device guarnatees that it can write a sector atomically, I've looked everywhere for confirmation of *atomicity*, and so far all I've seen are rumours. Some

Re: [Qemu-devel] [PATCH 2/4] block: add block topology options

2010-02-05 Thread Anthony Liguori
On 02/05/2010 07:09 AM, Christoph Hellwig wrote: On Wed, Feb 03, 2010 at 01:00:47PM -0600, Anthony Liguori wrote: But I don't think this is the wrong place to do it. The BlockDriverState reflects that backing device, not the emulated device itself. In this case, you're trying to set a

Re: [Qemu-devel] [PATCH v2 RESEND 0/5] clang fixes

2010-02-05 Thread Blue Swirl
Thanks, applied. On Thu, Feb 4, 2010 at 3:31 PM, Paolo Bonzini pbonz...@redhat.com wrote: I removed the patch that malc NACKed. Paolo Bonzini (5):  remove two dead assignments in target-i386/translate.c  fix undefined shifts by 32  exec.c: dead assignments  vnc.c: remove dead code  

[Qemu-devel] rtl8139 timer interrupt rewrote

2010-02-05 Thread Frediano Ziglio
Hi, I rewrote timer implementation for this card. I wrote even a small Linux guest test program (attached as main.c). This patch add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). I tested this patch with a Darwin system and with my test program (I

[Qemu-devel] [RFC] Documentation

2010-02-05 Thread Stefan Weil
The following patches enhance the existing documentation. They contain several parts marked with TODO where information is still missing, so feedback is welcome. They also add an index, or even several of them. There are many ways to organize an index, so I need feedback here, too. Overview of

[Qemu-devel] [PATCH 1/8] Documentation: Add build support for documentation in pdf format

2010-02-05 Thread Stefan Weil
Makefile already supported dvi, html and info formats, but pdf was missing. pdf is especially convenient for printing and for documentation reviews. I hope it will help to improve qemu's documentation. Make now supports the new target 'pdf' which will create qemu-doc.pdf and qemu-tech.pdf. It is

[Qemu-devel] [PATCH 3/8] Documentation: Use UTF-8 encoding and fix one wrong encoding

2010-02-05 Thread Stefan Weil
At least for Linux distributions UTF-8 is now standard, so the QEMU documentation should use this encoding, too. Even if there was currently only a single special character using ISO-8859-1, this might change in the future. So the texinfo keywords @documentlanguage and @documentencoding now

[Qemu-devel] [PATCH 5/8] Documentation: Fix item list

2010-02-05 Thread Stefan Weil
@itemize @minus does not work as expected (the items start with * -). A simple @itemize gives a better result. Signed-off-by: Stefan Weil w...@mail.berlios.de --- qemu-doc.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index

[Qemu-devel] [PATCH 2/8] Documentation: Add direntry for info format

2010-02-05 Thread Stefan Weil
update-info-dir maintains an index of all available documentation in info format (the file /usr/share/info/dir). It reads special @direntry tags in info files. This patch (extracted from a larger patch provided by Dirk Ullrich) adds these tags for qemu-doc.info and qemu-tech.info.

[Qemu-devel] [PATCH 7/8] Documentation: Add monitor commands to function index

2010-02-05 Thread Stefan Weil
* Add monitor commands to function index. * Fix description for acl_remove. Signed-off-by: Stefan Weil w...@mail.berlios.de --- qemu-monitor.hx | 62 ++- 1 files changed, 61 insertions(+), 1 deletions(-) diff --git a/qemu-monitor.hx

[Qemu-devel] [PATCH 6/8] Documentation: Enhance documentation (index, keywords)

2010-02-05 Thread Stefan Weil
* Add some keywords for the concept index. * Add some keywords for the keystroke index. * Mark invalid or unclear documentation with TODO. Is there a better proposal how to do this? * Fix copy+paste error in ColdFire section (options were copied from ARM). * Fix documentation for Wine. *

[Qemu-devel] [PATCH 4/8] Documentation: Add some basic documentation on make targets

2010-02-05 Thread Stefan Weil
This should help new users to get started. Signed-off-by: Stefan Weil w...@mail.berlios.de --- qemu-doc.texi | 41 + 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 84de318..8ecd175 100644 ---

[Qemu-devel] [PATCH 8/8] Documentation: Add command line options to function index

2010-02-05 Thread Stefan Weil
* Add line options to function index. * Add description for -set (TODO). * Add description for -global (TODO). Signed-off-by: Stefan Weil w...@mail.berlios.de --- qemu-options.hx | 153 +-- 1 files changed, 125 insertions(+), 28 deletions(-)

Re: [Qemu-devel] [PATCH] User mode: Handle x86_64 vsyscall

2010-02-05 Thread Stefan Weil
Laurent Desnogues schrieb: On Sun, Oct 18, 2009 at 5:09 AM, Jamie Lokier ja...@shareable.org wrote: [...] Please don't do that. Some code traces instructions through the vsyscall/vdso page, and will be surprised if a syscall instruction does not do what's expected based on the registers at

Re: [Qemu-devel] [PATCH] User mode: Handle x86_64 vsyscall

2010-02-05 Thread Laurent Desnogues
On Fri, Feb 5, 2010 at 11:57 PM, Stefan Weil w...@mail.berlios.de wrote: Laurent Desnogues schrieb: [...] I'm still struggling with bntest and other x86_64-linux-user software calling any of the vsyscall functions. Laurent, your vsyscall patch only works on x86_64 hosts. A lot of software

[Qemu-devel] [PATCH] qemu-kvm: Speed up of the dirty-bitmap-traveling

2010-02-05 Thread OHMURA Kei
dirty-bitmap-traveling is carried out by byte size in qemu-kvm.c. But We think that dirty-bitmap-traveling by long size is faster than by byte size especially when most of memory is not dirty. Signed-off-by: OHMURA Kei ohmura@lab.ntt.co.jp --- qemu-kvm.c | 49

Re: [Qemu-devel] [PATCH] User mode: Handle x86_64 vsyscall

2010-02-05 Thread Stefan Weil
Laurent Desnogues schrieb: On Fri, Feb 5, 2010 at 11:57 PM, Stefan Weil w...@mail.berlios.de wrote: Laurent Desnogues schrieb: [...] I'm still struggling with bntest and other x86_64-linux-user software calling any of the vsyscall functions. Laurent, your vsyscall patch only works on x86_64