[Qemu-devel] Re: [PATCH] QEMU kill CR3_CACHE references

2010-02-19 Thread Zachary Amsden
Hi, The CR3 caching was never implemented in QEMU and is obsoleted by NPT/EPT. This patch removes the unused references to it from target-i386/kvm.c. This feature was broken by design. Glad to see it go. Zach

Re: [Qemu-devel] [PATCH] QMP: Spec: Private Extensions support

2010-02-19 Thread Luiz Capitulino
On Thu, 18 Feb 2010 15:54:04 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 02/18/2010 02:24 PM, Luiz Capitulino wrote: Vendors might want to add their own extensions to QMP, as JSON itself (and several other protocols) allow this someway, I think QMP should allow too. We just

Re: [Qemu-devel] Errors while building qemu

2010-02-19 Thread Luiz Capitulino
On Thu, 18 Feb 2010 23:53:47 +0800 Roy Tam roy...@gmail.com wrote: 2010/2/18 Taimoor Mirza mooni_mi...@hotmail.com: Hi all, I've been getting following errors while building qemu 0.11.1 and 0.12.2 on my Redhat machine. block/curl.c:80: error: syntax error before curl_socket_t

Re: [Qemu-devel] [PATCH] Added Cortex_a8_v3 version, and added a shift instruction for NEON.

2010-02-19 Thread Richard Henderson
On 02/18/2010 03:56 PM, George Karavaev wrote: +tmp64 = tcg_temp_new_i64(); +tcg_gen_movi_i64(tmp64, 0); +tcg_gen_not_i64(tmp64, tmp64); movi -1? +gen_helper_neon_shl_u64(tmp64,

[Qemu-devel] [PATCH 0/9] qemu-kvm: Extended use of upstream code

2010-02-19 Thread Jan Kiszka
Spin-off from my longer series as Marcelo asked for the last patch as the next step. I don't see any value in reordering the series, so I just but off the lower bits. This part mostly cleans up common KVM code that is also present upstream. It also includes the fixed guest debug writeback, first

[Qemu-devel] [PATCH 4/9] qemu-kvm: Use upstream kvm_setup_guest_memory

2010-02-19 Thread Jan Kiszka
Nothing missing in upstream kvm_setup_guest_memory, it is even more careful about error handling. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |3 --- kvm.h |3 +-- qemu-kvm.c | 15 --- qemu-kvm.h |1 - 4 files changed, 1 insertions(+), 21

[Qemu-devel] [PATCH 2/9] qemu-kvm: Clean up register access API

2010-02-19 Thread Jan Kiszka
qemu-kvm's functions for accessing the VCPU registers are kvm_arch_load/save_regs. Use them directly instead of going through various wrappers. Specifically, we do not need on_vcpu wrapping as all users either already run in the related thread or call while the vm is stopped. This is now also

[Qemu-devel] [PATCH 8/9] KVM: Rework of guest debug state writing

2010-02-19 Thread Jan Kiszka
So far we synchronized any dirty VCPU state back into the kernel before updating the guest debug state. This was a tribute to a deficite in x86 kernels before 2.6.33. But as this is an arch-dependent issue, it is better handle in the x86 part of KVM and remove the writeback point for generic code.

[Qemu-devel] [PATCH 1/9] qemu-kvm: Drop vmport changes

2010-02-19 Thread Jan Kiszka
Upstream has proper support now. Drop the old half-broken approach and all surrounding diffs. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/vmport.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c index e9db6de..6c9d7c9

[Qemu-devel] [PATCH 3/9] qemu-kvm: Use upstream kvm_enabled and cpu_synchronize_state

2010-02-19 Thread Jan Kiszka
They are identical, no need for private copies. This requires replacing qemu-kvm.h includes with kvm.h, a good thing anyway, and reveals that there is no need for QEMU_KVM_NO_CPU protection. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/i8254.c|2 +- hw/i8259.c|2 +-

[Qemu-devel] [PATCH 6/9] qemu-kvm: Use upstream kvm_arch_get_supported_cpuid

2010-02-19 Thread Jan Kiszka
It is idential to our version now, so drop the copy. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm.h |3 - qemu-kvm-x86.c| 106 - qemu-kvm.h|5 -- target-i386/kvm.c |4 +- 4 files changed, 2

[Qemu-devel] [PATCH 7/9] qemu-kvm: Use upstream kvm_pit_in_kernel

2010-02-19 Thread Jan Kiszka
Drop private version in favor of recently added upstream service and track it state directly in KVMState. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/i8254.c |4 ++-- hw/pc.c|2 +- hw/pcspk.c |4 ++-- kvm-all.c |2 +- kvm.h |2 +-

[Qemu-devel] [PATCH 5/9] qemu-kvm: Use some more upstream prototypes

2010-02-19 Thread Jan Kiszka
Drop our private typedef of KVMState and use more identical upstream prototypes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm.h |8 +--- qemu-kvm.c |4 +++- qemu-kvm.h | 28 +++- 3 files changed, 11 insertions(+), 29 deletions(-) diff --git

[Qemu-devel] getfd monitor command broken

2010-02-19 Thread Ed Swierk
Commit c62313bbdc48f72e93fa8196f2fff96ba35e4e9d seems to have broken the getfd monitor command in qemu 0.12. tcp_chr_read() calls tcp_chr_recv(), which checks whether the received message includes an SCM_RIGHTS header, and if so, stores the received fd in the CharDriverState struct.

[Qemu-devel] [PATCH 9/9] qemu-kvm: Use upstream guest debug code

2010-02-19 Thread Jan Kiszka
Code was absolute identical except for previous fixes and cleanup in upstream. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- kvm-all.c |7 +- kvm.h |4 - qemu-kvm-x86.c| 197 +++-- qemu-kvm.c| 44

Re: [Qemu-devel] [PATCH 1/6] net: Remove unused net_client_uninit()

2010-02-19 Thread Anthony Liguori
On 02/11/2010 07:44 AM, Markus Armbruster wrote: Unused since commit 9ad4531e. Signed-off-by: Markus Armbrusterarm...@redhat.com Applied all. Thanks. Regards, Anthony Liguori --- net.c | 14 -- net.h |1 - 2 files changed, 0 insertions(+), 15 deletions(-) diff

[Qemu-devel] Re: [PULL] qemu: pci fixes and cleanups

2010-02-19 Thread Anthony Liguori
On 02/14/2010 08:29 AM, Michael S. Tsirkin wrote: The following changes since commit bc798c77e54f73b637e02bdc02bd799660adb7b7: Blue Swirl (1): Remove conditional rom loading support are available in the git repository at:

Re: [Qemu-devel] [PATCH] QEMU kill CR3_CACHE references

2010-02-19 Thread Anthony Liguori
On 02/19/2010 12:43 AM, Jes Sorensen wrote: Hi, The CR3 caching was never implemented in QEMU and is obsoleted by NPT/EPT. This patch removes the unused references to it from target-i386/kvm.c. Let's bring this through uq/master? Sound reasonable Marcelo? Regards, Anthony Liguori Cheers,

Re: [Qemu-devel] [PATCH 1/6] net: Remove unused net_client_uninit()

2010-02-19 Thread Anthony Liguori
On 02/11/2010 07:44 AM, Markus Armbruster wrote: Unused since commit 9ad4531e. Signed-off-by: Markus Armbrusterarm...@redhat.com Applied all. Thanks. Regards, Anthony Liguori --- net.c | 14 -- net.h |1 - 2 files changed, 0 insertions(+), 15 deletions(-) diff

Re: [Qemu-devel] [PATCH] QEMU e820 reservation patch

2010-02-19 Thread Anthony Liguori
On 02/15/2010 11:33 AM, Jes Sorensen wrote: Hi, Kevin and I have agreed on the approach for this one now. So here is the latest version of the patch for QEMU, submitting e820 reservation entries via fw_cfg. Cheers, Jes Acked-by: Anthony Liguori aligu...@us.ibm.com Would be nice to use

[Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-19 Thread Loïc Minier
--- configure | 17 + qemu-lock.h | 13 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0a84b0e..b33f045 100755 --- a/configure +++ b/configure @@ -1823,6 +1823,20 @@ if compile_prog ; then fi

[Qemu-devel] [PATCH 2/2] Make spinlock_t types volatile

2010-02-19 Thread Loïc Minier
--- qemu-lock.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-lock.h b/qemu-lock.h index 5c8eb34..23e3442 100644 --- a/qemu-lock.h +++ b/qemu-lock.h @@ -34,7 +34,7 @@ #else #ifdef CONFIG_GCC_ATOMIC_BUILTINS -typedef int spinlock_t; +typedef volatile int

Re: [Qemu-devel] [PATCH 01/20] eepro100: Fix compiler errors from debug messages

2010-02-19 Thread Anthony Liguori
On 02/14/2010 10:16 AM, Stefan Weil wrote: When debug output was enabled (by defining DEBUG_EEPRO100), some debug messages resulted in a compiler error. This is fixed here. Signed-off-by: Stefan Weilw...@mail.berlios.de Michael, Can you take these through your tree? Regards, Anthony

Re: [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

2010-02-19 Thread Anthony Liguori
On 02/15/2010 10:19 AM, Kevin Wolf wrote: The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be corrupted. I have found that the only way to fix

Re: [Qemu-devel] [PATCH 01/21] Monitor: Introduce cmd_new_ret()

2010-02-19 Thread Anthony Liguori
On 02/10/2010 07:49 PM, Luiz Capitulino wrote: In order to implement the new error handling and debugging mechanism for command handlers, we need to change the cmd_new() callback to return a value. This commit introduces cmd_new_ret(), which returns a value and will be used only temporarily to

Re: [Qemu-devel] [PATCH 1/3] use lazy initialization for display_state

2010-02-19 Thread Anthony Liguori
On 02/10/2010 05:29 PM, Paolo Bonzini wrote: Ensure initialization of a dumb display, if needed, by making all accesses go through get_displaystate. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Applied all. Thanks. Regards, Anthony Liguori --- vl.c | 29

Re: [Qemu-devel] [PATCH] pcnet APROMWE bit location

2010-02-19 Thread Anthony Liguori
On 02/14/2010 07:53 PM, Chris Kilgour wrote: I don't subscribe to the list, so please excuse any breach of etiquette. According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2. Signed-off-by: Christopher Kilgourtechieat whiterocker.com Your mailer munged this patch so it doesn't

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-19 Thread malc
On Fri, 19 Feb 2010, Lo?c Minier wrote: Please look up gcc 4.1 implements compiler builtins for atomic ops thread for reasons why this might not be the best idea. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] ide save/restore pio/atapi cmd transfer fields and io buffer

2010-02-19 Thread Anthony Liguori
On 02/11/2010 02:19 PM, Marcelo Tosatti wrote: Save/restore information necessary to continue in progress PIO/ATAPI CMD transfers. This includes the IO buffer. Signed-off-by: Marcelo Tosattimtosa...@redhat.com Applied. Thanks. Regards, Anthony Liguori diff --git a/hw/ide/core.c

Re: [Qemu-devel] [PATCH] mingw32: Enable C99/POSIX format strings

2010-02-19 Thread Anthony Liguori
On 02/12/2010 04:02 AM, Stefan Weil wrote: Starting with mingw32-runtime 3.15, C99/POSIX format strings (%zu, %lld, ...) are supported by defining __USE_MINGW_ANSI_STDIO=1. As QEMU uses such format strings, unconditionally define this macro. It won't hurt on older revisions of mingw32-runtime.

Re: [Qemu-devel] [PATCH] virtio-serial: pci: Allow MSI to be disabled

2010-02-19 Thread Anthony Liguori
On 02/12/2010 07:22 AM, Amit Shah wrote: Michael noted we don't allow disabling of MSI for the virtio-serial-pci device. Fix that. Signed-off-by: Amit Shahamit.s...@redhat.com CC: Michael S. Tsirkinm...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- hw/virtio-pci.c |6

Re: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command

2010-02-19 Thread Anthony Liguori
On 02/12/2010 02:55 PM, Adam Litke wrote: Arghh... Adding missing S-O-B Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing

Re: [Qemu-devel] [PATCH] USB HID does not support Set_Idle

2010-02-19 Thread Anthony Liguori
On 02/13/2010 05:32 PM, Kevin O'Connor wrote: I found that the QEMU USB keyboard support does not work properly with the Set_Idle command. Once a non-zero value is given to Set_Idle, then the keyboard reports an event on every poll - not based on the time issued in the Set_Idle command. I

Re: [Qemu-devel] [PATCH v4 rebased] block: more read-only changes, related to backing files

2010-02-19 Thread Anthony Liguori
On 02/14/2010 05:39 AM, Naphtali Sprei wrote: Open backing file read-only where possible Upgrade backing file to read-write during commit, back to read-only after commit If upgrade fail, back to read-only. If also fail, disconnect the drive. Signed-off-by: Naphtali Spreinsp...@redhat.com

Re: [Qemu-devel] [PATCH v2 1/3] pc: Bump up pc version to 0.13 and add a 0.12 compat version

2010-02-19 Thread Anthony Liguori
On 02/15/2010 09:13 AM, Amit Shah wrote: The version 0.13 will be the new default and compatibility options will be added to the 0.12 version. Signed-off-by: Amit Shahamit.s...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- v2: register the 0.12 version in this patch instead

Re: [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-19 Thread Anthony Liguori
On 02/16/2010 02:35 AM, Frediano Ziglio wrote: Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). This patch is required for Darwin. Patch has been tested under FreeBSD, Darwin and Linux. Signed-off-by: Frediano Zigliofredd...@gmail.com Alex, I

Re: [Qemu-devel] [PATCH] QEMU e820 reservation patch

2010-02-19 Thread Anthony Liguori
On 02/15/2010 11:33 AM, Jes Sorensen wrote: Hi, Kevin and I have agreed on the approach for this one now. So here is the latest version of the patch for QEMU, submitting e820 reservation entries via fw_cfg. Cheers, Jes Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] qdev: Free opts on failed do_device_add

2010-02-19 Thread Anthony Liguori
On 02/16/2010 06:12 AM, Kevin Wolf wrote: If the device can't be created, don't leak the QemuOpts and release the id of the device that should have been added by the failed device_add. Signed-off-by: Kevin Wolfkw...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- hw/qdev.c

Re: [Qemu-devel] [PATCH] qemu-img: Fix segfault during rebase

2010-02-19 Thread Anthony Liguori
On 02/17/2010 05:32 AM, Kevin Wolf wrote: This fixes a possible read beyond the end of the temporary buffers used for comparing data in the old and the new backing file. Signed-off-by: Kevin Wolfkw...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- qemu-img.c |2 +- 1

Re: [Qemu-devel] [PATCH] qcow2: Fix access after end of array

2010-02-19 Thread Anthony Liguori
On 02/16/2010 08:54 AM, Kevin Wolf wrote: If a write requests crosses a L2 table boundary and all clusters until the end of the L2 table are usable for the request, we must not look at the next L2 entry because we already have arrived at the end of the array. Signed-off-by: Kevin

Re: [Qemu-devel] [PATCH] qemu-img: Fix error message

2010-02-19 Thread Anthony Liguori
On 02/17/2010 05:33 AM, Kevin Wolf wrote: When qemu-img can't open the new backing file for a rebase, it prints an error message which contains the file name of the old backing file. This is wrong, obviously. Signed-off-by: Kevin Wolfkw...@redhat.com Applied. Thanks. Regards, Anthony

Re: [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-19 Thread Alexander Graf
On 19.02.2010, at 22:50, Anthony Liguori wrote: On 02/16/2010 02:35 AM, Frediano Ziglio wrote: Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). This patch is required for Darwin. Patch has been tested under FreeBSD, Darwin and Linux.

Re: [Qemu-devel] [PATCH] rewrote timer implementation for rtl8139.

2010-02-19 Thread Anthony Liguori
On 02/19/2010 04:22 PM, Alexander Graf wrote: On 19.02.2010, at 22:50, Anthony Liguori wrote: On 02/16/2010 02:35 AM, Frediano Ziglio wrote: Add a QEMU timer only when needed (timeout status not set, timeout irq wanted and timer set). This patch is required for Darwin. Patch has

[Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

2010-02-19 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: On 02/15/2010 10:19 AM, Kevin Wolf wrote: The current implementation of alloc_refcount_block and grow_refcount_table has fundamental problems regarding error handling. There are some places where an I/O error means that the image is going to be

[Qemu-devel] [PATCH] target-sparc: fix --enable-debug build

2010-02-19 Thread Jay Foad
On Linux/x86, configuring with --enable-debug, I get:  CC    sparc64-linux-user/translate.o /home/foad/git/qemu/target-sparc/translate.c: In function ‘gen_load_trap_state_at_tl’: /home/foad/git/qemu/target-sparc/translate.c:1684: error: incompatible type for argument 3 of ‘tcg_gen_add_i32’

[Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug

2010-02-19 Thread Jay Foad
After configuring with --enable-debug on Linux/x86, I get: f...@foad-ubuntu:~/qemu/objdir-git$ qemu-alpha /dev/null qemu-alpha: /home/foad/git/qemu/tcg/tcg.c:1055: tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. Aborted (and the same for all other targets). The qemu_ld32s op

Re: [Qemu-devel] Network shutdown under load

2010-02-19 Thread Lothar Behrens
Hi, as I have read that the bug has been fixed, when would it available as a new release for the public or at least as a RPM for openSuSE 11.1? Or is it better to build one myself? What I also have encountered is that some java code would bring the qemu process into a race condition one