[Qemu-devel] Re: GSoC 2010 - Device state visualization

2010-04-06 Thread Jan Kiszka
Hi Ionat, Ionut Cristian Paraschiv wrote: Hello! My name is Ionut Cristian Paraschiv, and I am from Romania. I am a student in the 2nd year at Politehnica University of Bucharest, Faculty of Automatic Control and Computers, Computer Science Department. I like to program in C, Java,

[Qemu-devel] Re: [PATCH 1/5] char: Let the caller know how many bytes were written in case of incomplete writes

2010-04-06 Thread Gerd Hoffmann
Hi, Make 'len' a pointer instead, and indicate how much of the string was written. The return value will either be the same as 'len' or a negative number indicating an error condition. I would follow the unix write syscall semantic here and report the number of written bytes using the

[Qemu-devel] Re: [PATCH 0/5] chardev, virtio-console: flow control, error handling

2010-04-06 Thread Amit Shah
On (Tue) Apr 06 2010 [09:36:17], Gerd Hoffmann wrote: Hi, In case of EAGAIN, the unix_write() function just kept spinning while attempting to write to the chardev till it succeeded. This resulted in a stuck VM in case a chardev had opened connection but wasn't reading anything from qemu.

[Qemu-devel] Re: [PATCH 1/5] char: Let the caller know how many bytes were written in case of incomplete writes

2010-04-06 Thread Amit Shah
On (Tue) Apr 06 2010 [09:40:55], Gerd Hoffmann wrote: Hi, Make 'len' a pointer instead, and indicate how much of the string was written. The return value will either be the same as 'len' or a negative number indicating an error condition. I would follow the unix write syscall semantic

[Qemu-devel] qemu solaris 2.5.1

2010-04-06 Thread ppark
I am trying to use qemu with solaris 2.5.1, as per Artyom Tarasenko's blog and using ss5.bin from Robert Reif. However, no luck! The message I get is as follows: pe...@sempron:~/qemu$ ./sparc-softmmu/qemu-system-sparc -M SS-5 -m 256 -startdate 2009-12-13 -L -bios ss5.bin -nographic -hdb

[Qemu-devel] Re: [PATCH 0/5] chardev, virtio-console: flow control, error handling

2010-04-06 Thread Gerd Hoffmann
So you mean just return -EAGAIN in case write returns with -EAGAIN? Yeah, makes sense. Yes. Note that for EINTR you want re-enter write() through so callers don't have to worry about signals. cheers, Gerd

[Qemu-devel] Re: [PATCH 5/5] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data

2010-04-06 Thread Gerd Hoffmann
Hi, +/* Callback function when the timer expires */ +static void unthrottle_port(VirtConsole *vcon) +{ Why a timer? qemu_set_fd_handler(fd, NULL, write_callback, opaque) ? cheers, Gerd

Re: [Qemu-devel] [PATCH]: block: get rid of the BDRV_O_FILE flag

2010-04-06 Thread Kevin Wolf
Am 05.04.2010 16:53, schrieb Christoph Hellwig: BDRV_O_FILE is only used to communicate between bdrv_file_open and bdrv_open. It affects two things: first bdrv_open only searches for protocols using find_protocol instead of all image formats and host drivers. We can easily move that to the

Re: [Qemu-devel] [PATCH] block: split raw_getlength

2010-04-06 Thread Kevin Wolf
Am 05.04.2010 16:12, schrieb Christoph Hellwig: Split up the raw_getlength into separate generic, solaris and BSD versions to reduce the ifdef maze a bit. The BSD variant still is a complete maze, but to clean it up properly we'd need some people using the BSD variants to figure out what code

Re: [Qemu-devel] s390 - No 'PCI' bus found for device 'virtio-serial-pci'

2010-04-06 Thread Aurelien Jarno
On Mon, Apr 05, 2010 at 07:58:35PM +0200, Alexander Graf wrote: On 05.04.2010, at 17:30, Bastian Blank wrote: On Mon, Apr 05, 2010 at 08:14:00PM +0530, Amit Shah wrote: On (Mon) Apr 05 2010 [16:34:13], Bastian Blank wrote: | $ ./s390x-softmmu/qemu-system-s390x -nographic -enable-kvm

Re: [Qemu-devel] [PATCH 1/5] char: Let the caller know how many bytes were written in case of incomplete writes

2010-04-06 Thread Amit Shah
On (Tue) Apr 06 2010 [10:34:29], Paul Brook wrote: On (Mon) Apr 05 2010 [17:33:38], Paul Brook wrote: There might be cases where a few bytes would have been sent out to char devices and some not. Currently the return values from qemu_chr_write() to char devs are only -1, indicating

Re: [Qemu-devel] [PATCH] cleanup block driver option handling in vl.c

2010-04-06 Thread Kevin Wolf
Am 05.04.2010 16:12, schrieb Christoph Hellwig: Assign directly to the bdrv_flags variable instead of using magic numbers before translating to the BDRV_O_* options. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/vl.c

Re: [Qemu-devel] s390 - No 'PCI' bus found for device 'virtio-serial-pci'

2010-04-06 Thread Alexander Graf
On 06.04.2010, at 11:51, Aurelien Jarno wrote: On Mon, Apr 05, 2010 at 07:58:35PM +0200, Alexander Graf wrote: On 05.04.2010, at 17:30, Bastian Blank wrote: On Mon, Apr 05, 2010 at 08:14:00PM +0530, Amit Shah wrote: On (Mon) Apr 05 2010 [16:34:13], Bastian Blank wrote: | $

[Qemu-devel] [PATCH] [S390] Make virtio-pci building conditional again

2010-04-06 Thread Alexander Graf
Commit b305b9d7d6990e492966ffb1fdf619482adeb7e2 made building of virtio-pci conditional and not enabled on S390x, because it collides with the S390 bus. Commit 087431d1d1bf4e785edfa89e8cd05fcdac558dc3 accidentially reverted that behavior, breaking S390x again. So here's a follow-up patch

Re: [Qemu-devel] [PATCH 1/5] char: Let the caller know how many bytes were written in case of incomplete writes

2010-04-06 Thread Gerd Hoffmann
On 04/06/10 11:58, Amit Shah wrote: It would certainly be beneficial for consumers of virtio-serial to be notified of -EAGAIN so that the guest can be throttled till the chardev catches up with the data being sent. EAGAIN should only ever occur if no bytes are written. Right. That, or just

[Qemu-devel] Re: [PATCH]: block: get rid of the BDRV_O_FILE flag

2010-04-06 Thread Juan Quintela
Christoph Hellwig h...@lst.de wrote: BDRV_O_FILE is only used to communicate between bdrv_file_open and bdrv_open. It affects two things: first bdrv_open only searches for protocols using find_protocol instead of all image formats and host drivers. We can easily move that to the caller and

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Mon, Apr 05, 2010 at 11:11:48PM +0200, Alexander Graf wrote: Howdy, I've been thinking a bit further on the whole issue around libvirt and why the situation as is isn't satisfying. I came to the following points that currently hurt building ease of use for KVM: 1) Brand This is

Re: [Qemu-devel] [PATCH]: block: get rid of the BDRV_O_FILE flag

2010-04-06 Thread Kevin Wolf
Am 05.04.2010 16:53, schrieb Christoph Hellwig: This patch requires Kevin's [PATCH] Replace calls of old bdrv_open to be applied first. Now that this is starting again, let's avoid the annoyance we had the last time when patches were held back because they depended on patches which depended on

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 01:14:36AM +0300, Avi Kivity wrote: On 04/06/2010 12:11 AM, Alexander Graf wrote: I can imagine 1) going away if we would set libvirt + virt-manager as _the_ front-end and have everyone focus on it. I suppose it would also help to rebrand it by then, but I'm not

Re: [Qemu-devel] [PATCH 1/5] char: Let the caller know how many bytes were written in case of incomplete writes

2010-04-06 Thread Amit Shah
On (Tue) Apr 06 2010 [12:21:52], Gerd Hoffmann wrote: On 04/06/10 11:58, Amit Shah wrote: It would certainly be beneficial for consumers of virtio-serial to be notified of -EAGAIN so that the guest can be throttled till the chardev catches up with the data being sent. EAGAIN should only ever

[Qemu-devel] General information about the QEMU project

2010-04-06 Thread loki84
Hi I am searching for some informations about QEMU. 1. Currently it's possible to compile and run QEMU under Windows. Is there a fixed support for Windows platforms (as Host)? Or is it possible that newer releases only work on Linux platforms? 2. I have searched for an atapi cdrom passthrough

Re: [Qemu-devel] [PATCH 1/5] char: Let the caller know how many bytes were written in case of incomplete writes

2010-04-06 Thread Gerd Hoffmann
On 04/06/10 13:05, Amit Shah wrote: On (Tue) Apr 06 2010 [12:21:52], Gerd Hoffmann wrote: On 04/06/10 11:58, Amit Shah wrote: It would certainly be beneficial for consumers of virtio-serial to be notified of -EAGAIN so that the guest can be throttled till the chardev catches up with the data

[Qemu-devel] [PATCH] qemu: address todo comment in exec.c

2010-04-06 Thread Michael S. Tsirkin
exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys, so let's do it, along the lines of stl_phys. The reason to address 16 bit accesses specifically is that virtio relies on these accesses to be done atomically, using memset as we do now breaks this assumption, which is reported to cause

[Qemu-devel] [PATCH] Add KVM CFLAGS to vhost build

2010-04-06 Thread Jan Kiszka
The configure test of vhost uses KVM CFLAGS, so the build must use them as well. Otherwise we specifically miss what --kerneldir provides. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 1/9] eepro100: Don't allow writing SCBStatus

2010-04-06 Thread Stefan Weil
SCBStatus is readonly, but most drivers which were derived from the old Linux eepro100.c do a word write to this address when they want to acknowledge interrupts. So we have to mask these writes here. The patch also removes old unused code for status read / write. Signed-off-by: Stefan Weil

[Qemu-devel] eepro100: New patches

2010-04-06 Thread Stefan Weil
These patches fix two regressions (1, 9) which made eepro100 rather useless, use a simple method to handle the different device variants (2), add a new device variant (4) and fix or clean some smaller issues. [PATCH 1/9] eepro100: Don't allow writing SCBStatus [PATCH 2/9] eepro100: Simplify

[Qemu-devel] [PATCH 2/9] eepro100: Simplify status handling

2010-04-06 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 0415132..741031c 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -175,6 +175,7 @@ typedef enum { }

[Qemu-devel] [PATCH 4/9] eepro100: Add new device variant i82801

2010-04-06 Thread Stefan Weil
This ethernet device is used in Toshiba Tecra 8200 notebooks. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index fde45c9..52c5888 100644 --- a/hw/eepro100.c

[Qemu-devel] [PATCH 3/9] eepro100: Simplified device instantiation

2010-04-06 Thread Stefan Weil
By using a private device info structure (as suggested by Gerd Hoffmann), handling of the different device variants becomes much easier. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 447 + 1 files changed, 167

[Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM

2010-04-06 Thread Stefan Weil
To emulate hardware without an EEPROM, EEPROM_SIZE may be set to 0. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index cedc427..e12ee23 100644 --- a/hw/eepro100.c +++

[Qemu-devel] [PATCH 5/9] eepro100: Set configuration bit for standard TCB

2010-04-06 Thread Stefan Weil
For some devices, this bit is always set. For the others, it is set by default. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 52c5888..cedc427 100644 ---

[Qemu-devel] [PATCH 7/9] eepro100: Set power management capability using pci_reserve_capability

2010-04-06 Thread Stefan Weil
pci_reserve_capability automatically updates PCI status and PCI capability pointer, so use it. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 39 ++- 1 files changed, 18 insertions(+), 21 deletions(-) diff --git a/hw/eepro100.c

[Qemu-devel] [PATCH 8/9] eepro100: Fix mapping of flash memory

2010-04-06 Thread Stefan Weil
Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index f0acdbc..2401888 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -1622,8 +1622,9 @@ static void

[Qemu-devel] [PATCH 9/9] eepro100: Fix PCI interrupt pin configuration regression

2010-04-06 Thread Stefan Weil
Commit 15e89f5916c9e82347cbd1fd416db3e348bab426 removed this setting, but it is still needed. Without this patch, e100 device drivers using interrupts don't work with qemu. See other nic emulations which also set the PCI interrupt pin. Signed-off-by: Stefan Weil w...@mail.berlios.de ---

[Qemu-devel] GSOC Project

2010-04-06 Thread Costas Drogos
Hello, My name is Costas Drogos, and i would like to participate in GSOC with the first Qemu project, Convert Monitor commands to the QObject API. I study Informatics in the University of Piraeus, Greece in an undergraduate level. My previous experience with qemu was through xen and kvm, which

[Qemu-devel] Re: [PATCH 9/9] eepro100: Fix PCI interrupt pin configuration regression

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 01:44:09PM +0200, Stefan Weil wrote: Commit 15e89f5916c9e82347cbd1fd416db3e348bab426 removed this setting, but it is still needed. Without this patch, e100 device drivers using interrupts don't work with qemu. See other nic emulations which also set the PCI

[Qemu-devel] Re: [PATCH 8/9] eepro100: Fix mapping of flash memory

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 01:44:08PM +0200, Stefan Weil wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index f0acdbc..2401888 100644 --- a/hw/eepro100.c +++

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Avi Kivity
On 04/06/2010 01:29 AM, Alexander Graf wrote: Well, I did suggest (and then withdraw) qemud. The problem is that to get something working we'd duplicate all the work that's gone into libvirt - storage pools, svirt, network setup, etc. That's infrastructure that should probably go

[Qemu-devel] Re: [PATCH 7/9] eepro100: Set power management capability using pci_reserve_capability

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 01:44:07PM +0200, Stefan Weil wrote: pci_reserve_capability automatically updates PCI status and PCI capability pointer, so use it. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c | 39 ++- 1 files changed, 18

[Qemu-devel] Re: [PATCH 6/9] eepro100: Support compilation without EEPROM

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 01:44:06PM +0200, Stefan Weil wrote: To emulate hardware without an EEPROM, EEPROM_SIZE may be set to 0. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/eepro100.c

[Qemu-devel] Re: [PATCH 2/9] eepro100: Simplify status handling

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 01:44:02PM +0200, Stefan Weil wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 0415132..741031c 100644 --- a/hw/eepro100.c

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Alexander Graf
Avi Kivity wrote: On 04/06/2010 01:29 AM, Alexander Graf wrote: Well, I did suggest (and then withdraw) qemud. The problem is that to get something working we'd duplicate all the work that's gone into libvirt - storage pools, svirt, network setup, etc. That's infrastructure that

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Avi Kivity
On 04/06/2010 03:28 PM, Alexander Graf wrote: Note things like network setup are a bottomless pit. Pretty soon you need to setup vlans and bonding etc. If a user needs one of these and qemud doesn't provide it, then qemud becomes useless to them. But the same problem applies to libvirt.

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Alexander Graf
Daniel P. Berrange wrote: On Mon, Apr 05, 2010 at 11:11:48PM +0200, Alexander Graf wrote: Howdy, I've been thinking a bit further on the whole issue around libvirt and why the situation as is isn't satisfying. I came to the following points that currently hurt building ease of use for

[Qemu-devel] Re: eepro100: New patches

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 01:44:00PM +0200, Stefan Weil wrote: These patches fix two regressions (1, 9) which made eepro100 rather useless, use a simple method to handle the different device variants (2), add a new device variant (4) and fix or clean some smaller issues. [PATCH 1/9] eepro100:

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Alexander Graf
Daniel P. Berrange wrote: On Tue, Apr 06, 2010 at 01:14:36AM +0300, Avi Kivity wrote: On 04/06/2010 12:11 AM, Alexander Graf wrote: I can imagine 1) going away if we would set libvirt + virt-manager as _the_ front-end and have everyone focus on it. I suppose it would also help to

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Alexander Graf
Avi Kivity wrote: On 04/06/2010 03:28 PM, Alexander Graf wrote: Note things like network setup are a bottomless pit. Pretty soon you need to setup vlans and bonding etc. If a user needs one of these and qemud doesn't provide it, then qemud becomes useless to them. But the same problem

Re: [Qemu-devel] KVM call agenda for Apr 6

2010-04-06 Thread Alexander Graf
Chris Wright wrote: Please send in any agenda items you are interested in covering. Management stack discussion (again :)) Alex

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Avi Kivity
On 04/06/2010 03:43 PM, Alexander Graf wrote: Does VMware Player support OVF? Does VMware Workstation support OVF? Does VMware Server support OVF? Do older VMware ESX versions support OVF? Does it make sense to build an OVF with a Xen PV image? We need to deliver vendor specific configs

[Qemu-devel] Re: Semantic meaning of stop command?

2010-04-06 Thread Juan Quintela
Jun Koi junkoi2...@gmail.com wrote: Hi, I always thought that the stop command provided by the monitor interface would pause the VM completely, but it doesnt seem so? I checked this by issuing the stop command on my VM, and noted its clock. Few minutes later, I resumed the VM (with cont

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 02:49:23PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: On Tue, Apr 06, 2010 at 01:14:36AM +0300, Avi Kivity wrote: On 04/06/2010 12:11 AM, Alexander Graf wrote: I can imagine 1) going away if we would set libvirt + virt-manager as _the_

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Alexander Graf
Daniel P. Berrange wrote: On Tue, Apr 06, 2010 at 02:49:23PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: On Tue, Apr 06, 2010 at 01:14:36AM +0300, Avi Kivity wrote: On 04/06/2010 12:11 AM, Alexander Graf wrote: I can imagine 1) going away if

Re: [Qemu-devel] [PATCH 1/5] char: Let the caller know how many bytes were written in case of incomplete writes

2010-04-06 Thread Jamie Lokier
Gerd Hoffmann wrote: On 04/06/10 13:05, Amit Shah wrote: On (Tue) Apr 06 2010 [12:21:52], Gerd Hoffmann wrote: On 04/06/10 11:58, Amit Shah wrote: It would certainly be beneficial for consumers of virtio-serial to be notified of -EAGAIN so that the guest can be throttled till the chardev

[Qemu-devel] [PATCH 0/6] qcow2: More error path fixes

2010-04-06 Thread Kevin Wolf
This is part three of the qcow2 error path fixes. More to come... May depend on any patches sent earlier that are in my queue (I think it does depend at least on the blkdebug series to apply cleanly) Kevin Wolf (6): qcow2: Don't ignore immediate read/write failures qcow2: Return 0/-errno in

[Qemu-devel] [PATCH 2/6] qcow2: Return 0/-errno in write_l2_entries

2010-04-06 Thread Kevin Wolf
Change write_l2_entries to return the real error code instead of -1. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 9b3d686..65b16db 100644

[Qemu-devel] [PATCH 1/6] qcow2: Don't ignore immediate read/write failures

2010-04-06 Thread Kevin Wolf
Returning -EIO is far from optimal, but at least it's an error code. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 5bea8f5..2f34eec 100644 --- a/block/qcow2.c +++

[Qemu-devel] [PATCH 6/6] qcow2: Remove request from in-flight list after error

2010-04-06 Thread Kevin Wolf
If we complete a request with a failure we need to remove it from the list of requests that are in flight. If we don't do it, the next time the same AIOCB is used for a cluster allocation it will create a loop in the list and qemu will hang in an endless loop. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 4/6] qcow2: Return 0/-errno in write_l1_entry

2010-04-06 Thread Kevin Wolf
Change write_l1_entry to return the real error code instead of -1. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 8cc742b..a2d3962 100644

[Qemu-devel] [PATCH 3/6] qcow2: Fix error return code in qcow2_alloc_cluster_link_l2

2010-04-06 Thread Kevin Wolf
Fix qcow2_alloc_cluster_link_l2 to return the real error code like it does in all other error cases. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c

[Qemu-devel] [PATCH 5/6] qcow2: Return 0/-errno in l2_allocate

2010-04-06 Thread Kevin Wolf
Returning NULL on error doesn't allow distinguishing between different errors. Change the interface to return an integer for -errno. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 40 +++- 1 files changed, 23 insertions(+), 17

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 02:43:47PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: With appliances there are two core aspects 1. The description of VM hardware requirements 2. The disk format Traditionally VMware appliances have shipped a VMX file for 1. and a VMDK file for

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Alexander Graf
Daniel P. Berrange wrote: On Tue, Apr 06, 2010 at 02:43:47PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: With appliances there are two core aspects 1. The description of VM hardware requirements 2. The disk format Traditionally VMware appliances have shipped a VMX

[Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Daniel P. Berrange
On Tue, Apr 06, 2010 at 03:53:16PM +0200, Alexander Graf wrote: Daniel P. Berrange wrote: If instead there was a common machine description file that everyone knows, there'd be a single point of knowledge. A RHEL-V admin could work on plain qemu. A qemu developer would feel right at home

[Qemu-devel] Re: [PATCH 8/9] eepro100: Fix mapping of flash memory

2010-04-06 Thread Stefan Weil
Michael S. Tsirkin schrieb: On Tue, Apr 06, 2010 at 01:44:08PM +0200, Stefan Weil wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index f0acdbc..2401888

[Qemu-devel] Re: [PATCH 2/9] eepro100: Simplify status handling

2010-04-06 Thread Stefan Weil
Michael S. Tsirkin schrieb: On Tue, Apr 06, 2010 at 01:44:02PM +0200, Stefan Weil wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index

[Qemu-devel] Re: [PATCH 8/9] eepro100: Fix mapping of flash memory

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 04:23:41PM +0200, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Tue, Apr 06, 2010 at 01:44:08PM +0200, Stefan Weil wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

[Qemu-devel] Re: [PATCH 2/9] eepro100: Simplify status handling

2010-04-06 Thread Michael S. Tsirkin
On Tue, Apr 06, 2010 at 04:29:45PM +0200, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Tue, Apr 06, 2010 at 01:44:02PM +0200, Stefan Weil wrote: Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/eepro100.c |9 + 1 files changed, 5 insertions(+), 4

[Qemu-devel] [PATCH 1/3] monitor: Cleanup ID assignment for compat switch

2010-04-06 Thread Jan Kiszka
Canonicalize the ID assignment when creating monitor devices via the legacy switch and use less easily colliding names. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- vl.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index 6768cf1..bda5f1e

[Qemu-devel] [PATCH 2/3] monitor: Reorder intialization to drop initial mux focus

2010-04-06 Thread Jan Kiszka
So far a multiplexed monitor started disabled. Restore this property for the new way of configuring by moving the monitor initialization before all devices (the last one to attach to a char-mux will gain the focus). Once we have a real use case for that, we may also consider assigning the initial

[Qemu-devel] Re: Semantic meaning of stop command?

2010-04-06 Thread Jun Koi
On Tue, Apr 6, 2010 at 9:59 PM, Juan Quintela quint...@redhat.com wrote: Jun Koi junkoi2...@gmail.com wrote: Hi, I always thought that the stop command provided by the monitor interface would pause the VM completely, but it doesnt seem so? I checked this by issuing the stop command on my

[Qemu-devel] [PATCH 3/3] chardev: Document mux option

2010-04-06 Thread Jan Kiszka
Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- qemu-options.hx | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index f4b3bfe..83b54c3 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1175,32

[Qemu-devel] [PATCH 0/3] monitor: Small usability fixes

2010-04-06 Thread Jan Kiszka
Here are some patches that address what I brought up in [1]: - avoid naming collisions between new -mon and old -monitor - fix mux'ed monitor startup focus - document new mux syntax [1] http://thread.gmane.org/gmane.comp.emulators.qemu/65976 Jan Kiszka (3): monitor: Cleanup ID assignment

[Qemu-devel] KVM call minutes for Apr 6

2010-04-06 Thread Chris Wright
Management stack again - qemud? - external mgmt stack, qemu/kvm devs less inclined to care - Oh, you're using virsh, try #virt on OFTC - standard libvirt issues - concern about speed of adopting kvm features - complicated, XML hard to understand - being slowed by hv agnositc - ... -

Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM

2010-04-06 Thread Richard Henderson
On 04/06/2010 04:44 AM, Stefan Weil wrote: +#if EEPROM_SIZE 0 /* Add 64 * 2 EEPROM. i82557 and i82558 support a 64 word EEPROM, * i82559 and later support 64 or 256 word EEPROM. */ s-eeprom = eeprom93xx_new(EEPROM_SIZE); +#endif If EEPROM_SIZE is known to be defined, even if

Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM

2010-04-06 Thread Stefan Weil
Richard Henderson schrieb: On 04/06/2010 04:44 AM, Stefan Weil wrote: +#if EEPROM_SIZE 0 /* Add 64 * 2 EEPROM. i82557 and i82558 support a 64 word EEPROM, * i82559 and later support 64 or 256 word EEPROM. */ s-eeprom = eeprom93xx_new(EEPROM_SIZE); +#endif If

[Qemu-devel] Re: eepro100: New patches

2010-04-06 Thread Stefan Weil
Michael S. Tsirkin schrieb: On Tue, Apr 06, 2010 at 01:44:00PM +0200, Stefan Weil wrote: These patches fix two regressions (1, 9) which made eepro100 rather useless, use a simple method to handle the different device variants (2), add a new device variant (4) and fix or clean some smaller

[Qemu-devel] [PATCH 1/2] block: Fix error code in multiwrite for immediate failures

2010-04-06 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 9233af1..ae5aba3 100644 --- a/block.c +++ b/block.c @@ -1890,10 +1890,10 @@ int bdrv_aio_multiwrite(BlockDriverState *bs, BlockRequest *reqs,

[Qemu-devel] [PATCH 2/2] block: Fix multiwrite memory leak in error case

2010-04-06 Thread Kevin Wolf
Previously multiwrite_user_cb was never called if a request in the multiwrite batch failed right away because it did set mcb-error immediately. Make it look more like a normal callback to fix this. Reported-by: Juan Quintela quint...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 0/2] block: Multiwrite error path fixes

2010-04-06 Thread Kevin Wolf
Kevin Wolf (2): block: Fix error code in multiwrite for immediate failures block: Fix multiwrite memory leak in error case block.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

Re: [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS, STACK_OFFSET} definitions.

2010-04-06 Thread Andreas Färber
Am 16.02.2010 um 22:14 schrieb Juergen Lock: On Sun, Feb 14, 2010 at 09:13:31PM +0100, Juergen Lock wrote: Submitted by: Andreas Tobler andre...@fgznet.ch Signed-off-by: Juergen Lock n...@jelal.kn-bremen.de --- a/tcg/ppc/tcg-target.h +++ b/tcg/ppc/tcg-target.h @@ -69,7 +69,7 @@ #define

Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without EEPROM

2010-04-06 Thread Richard Henderson
On 04/06/2010 09:01 AM, Stefan Weil wrote: Richard Henderson schrieb: On 04/06/2010 04:44 AM, Stefan Weil wrote: +#if EEPROM_SIZE 0 /* Add 64 * 2 EEPROM. i82557 and i82558 support a 64 word EEPROM, * i82559 and later support 64 or 256 word EEPROM. */ s-eeprom =

[Qemu-devel] AHCI emulation

2010-04-06 Thread Roland Elek
Seeing the controversy about the S3 Trio, and the fact that there seems to be another applicant interested in it, I've decided to prepare a proposal for the AHCI emulation project, the other project of my interest. I have skimmed through the documentation and some Qemu code, and it seems to me

[Qemu-devel] [PATCH v2] cleanup block driver option handling in vl.c

2010-04-06 Thread Christoph Hellwig
Assign directly to the bdrv_flags variable instead of using magic numbers before translating to the BDRV_O_* options. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/vl.c === --- qemu.orig/vl.c 2010-04-06

[Qemu-devel] [PATCH v2] block: split raw_getlength

2010-04-06 Thread Christoph Hellwig
Split up the raw_getlength into separate generic, solaris and BSD versions to reduce the ifdef maze a bit. The BSD variant still is a complete maze, but to clean it up properly we'd need some people using the BSD variants to figure out what code is used for what variant. Signed-off-by: Christoph

Re: [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions.

2010-04-06 Thread malc
On Tue, 6 Apr 2010, Andreas F?rber wrote: Am 16.02.2010 um 22:14 schrieb Juergen Lock: On Sun, Feb 14, 2010 at 09:13:31PM +0100, Juergen Lock wrote: Submitted by: Andreas Tobler andre...@fgznet.ch Signed-off-by: Juergen Lock n...@jelal.kn-bremen.de ---

Re: [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions.

2010-04-06 Thread malc
On Tue, 6 Apr 2010, Andreas F?rber wrote: Am 06.04.2010 um 19:14 schrieb malc: On Tue, 6 Apr 2010, Andreas F?rber wrote: 5da79c86a3744e3a901c7986c109dd06951befd2 broke compilation on Mac OS X v10.5 ppc: Apparently _CALL_DARWIN is not defined, so it runs into the #else. Which

Re: [Qemu-devel] Source Code for QObject API

2010-04-06 Thread Luiz Capitulino
On Tue, 6 Apr 2010 17:02:16 +0530 ashish gupta ashish12.it...@gmail.com wrote: Hi all, We talked by IRC, but will duplicate some info here. I am a undergraduate (final year) student of Computer Science and Engineering in Institute of Technology, Banaras Hindu University, India. I am very

[Qemu-devel] OXE810DSE (ARM) based NAS emulation

2010-04-06 Thread Alexey Zhelezov
Hi, I have written an hw addition to emulate my NAS (XTreamer EtrayZ), which is based on OXE810DSE. Emulation includes RPS, SATA controller, Ethernet controller and several other small components. The primary target of this development was a platform to test another kernel (since I do not

Re: [Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Jamie Lokier
Alexander Graf wrote: So what if you had a special section that gives you the necessary information to do that mapping? A vendor specific section so to say. That would make it a perfect master config format, right? XML with XML Namespaces is quite good for mixing data intended for different

Re: [Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Jamie Lokier
Daniel P. Berrange wrote: The different formats are serving different needs really. People use the libvirt XML format because they want a representation that works across multiple hypervisors. Then my use-case is being missed. I tried using the libvirt XML format because I want to use the

Re: [Qemu-devel] Re: libvirt vs. in-qemu management

2010-04-06 Thread Jamie Lokier
Alexander Graf wrote: One way to avoid it is to have a rich plugin API so if some needs some to, say, set up traffic control on the interface, they can write a plugin to do that. Another way would be to have an active open source community that just writes the support for traffic control

[Qemu-devel] [PATCH] fix 100% cpu utilization when cpu is stopped (was Re: d6f4ade214a9f74dca9495b83a24ff9c113e4f9a)

2010-04-06 Thread Paolo Bonzini
On 04/05/2010 03:51 PM, malc wrote: Hello, d6f4ade214a9f74dca9495b83a24ff9c113e4f9a: disentangle tcg and deadline calculation introduces following regression(s): 100% cpu utilization when QEMU is invoked like: qemu -S -s ... ditto when gdb takes control over the session via gdb-stub (i.e.

[Qemu-devel] Re: [PATCH] fix 100% cpu utilization when cpu is stopped (was Re: d6f4ade214a9f74dca9495b83a24ff9c113e4f9a)

2010-04-06 Thread malc
On Tue, 6 Apr 2010, Paolo Bonzini wrote: On 04/05/2010 03:51 PM, malc wrote: Hello, d6f4ade214a9f74dca9495b83a24ff9c113e4f9a: disentangle tcg and deadline calculation introduces following regression(s): 100% cpu utilization when QEMU is invoked like: qemu -S -s ... ditto

[Qemu-devel] [PATCH resend] fix 100% cpu utilization when cpu is stopped

2010-04-06 Thread Paolo Bonzini
Hello, d6f4ade (disentangle tcg and deadline calculation, 2010-03-10) introduces following regression(s): 100% cpu utilization when QEMU is invoked like: qemu -S -s ... ditto when gdb takes control over the session via gdb-stub (i.e. the breakpoint is hit or C-c is pressed inside gdb to

[Qemu-devel] [PATCH 1/3] net: remove NICInfo.bootable field

2010-04-06 Thread Eduardo Habkost
It is just set by net_set_boot_mask() and never used. The logic for rom loading changed a lot since this field was introduced. It is not needed anymore. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- net.c |1 - net.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 3/3] boot: remove unused boot_devices_bitmap variable

2010-04-06 Thread Eduardo Habkost
In addition to removing the variable, this also renames the parse_bootdevices() function to validate_bootdevices(), as we don't need its return value anymore. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- vl.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PATCH 2/3] net: remove broken net_set_boot_mask() boot device validation

2010-04-06 Thread Eduardo Habkost
There are many problems with net_set_boot_mask(): 1) It is broken when using the device model instead of -net nic. Example: $ qemu-system-x86_64 -device rtl8139,vlan=0,id=net0,mac=52:54:00:82:41:fd,bus=pci.0,addr=0x4 -net user,vlan=0,name=hostnet0 -vnc 0.0.0.0:0 -boot n Cannot boot from

[Qemu-devel] [PATCH 0/3] fix network booting when using -device instead of -net nic

2010-04-06 Thread Eduardo Habkost
This series fixes the following issue: $ qemu-system-x86_64 -device rtl8139,vlan=0,id=net0,mac=52:54:00:82:41:fd,bus=pci.0,addr=0x4 -net user,vlan=0,name=hostnet0 -vnc 0.0.0.0:0 -boot n Cannot boot from non-existent NIC $ Patches 1 and 3 are just cleanups. The actual fix is on patch 2.

Res: [Qemu-devel] full dynamic instruction trace for MIPS target

2010-04-06 Thread Boris Cámara
Hi Vince, The aproach you are using on http://www.csl.cornell.edu/~vince/projects/qemu-trace/ to get the PC dump is similar to mine but as you dont disable the TB caches It is not a full execution trace. You only dump the PC when they are compiled and inserted on the TB cache. When qemu

[Qemu-devel] [PATCH 1/1] QMP test code - qmp.py

2010-04-06 Thread Costas Drogos
Hello there, a very small patch to address two small issues: 1) The json state in python2.5 and python2.6. json module is included by default on python2.6, whereas you have to import simplejson in python2.5. I have this problem on Debian testing, so feel free to test if this is applicable in

  1   2   >