Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion

2010-05-04 Thread Christoph Hellwig
On Tue, May 04, 2010 at 04:01:35PM +0200, Kevin Wolf wrote: > Great, I'm going to submit it as a proper patch then. > > Christoph, by now I'm pretty sure it's right, but can you have another > look if this is correct, anyway? It looks correct to me - we really shouldn't update the the fields unti

[Qemu-devel] Re: [PATCH] qemu-iotests: Improve rebase test

2010-05-04 Thread Christoph Hellwig
On Thu, Apr 29, 2010 at 02:47:17PM +0200, Kevin Wolf wrote: > The old test didn't consider cases in which the COW files contains some > unallocated clusters and after them allocated ones again. > > Signed-off-by: Kevin Wolf Thanks, applied.

[Qemu-devel] Re: [PATCH v2][qemu-iotests] test bdrv_truncate()

2010-05-04 Thread Christoph Hellwig
On Mon, Apr 26, 2010 at 11:13:31AM +0100, Stefan Hajnoczi wrote: > This patch adds an image resize grow test to ensure that existing data > is not lost during grow and new space is zeroed. > > Signed-off-by: Stefan Hajnoczi Thanks, applied.

[Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice, where possible

2010-05-04 Thread Brad Jorsch
The emulated mice should emulate a horizontal wheel when possible. This patch series does that for the USB mouse and tablet and the ExPS/2 mouse. As far as I can tell the vmmouse protocol doesn't handle a horizontal wheel, and I have no idea if emulating a wheel might make sense for any of the othe

[Qemu-devel] [PATCH 5/5] Add a horizontal wheel to the exps/2 mouse

2010-05-04 Thread Brad Jorsch
Have the emulated mouse report horizontal wheel events when in exps/2 mode. Signed-off-by: Brad Jorsch --- hw/ps2.c | 56 +++- 1 files changed, 43 insertions(+), 13 deletions(-) diff --git a/hw/ps2.c b/hw/ps2.c index db5605d..09e4365 100644

[Qemu-devel] [PATCH 4/5] Add a horizontal wheel to the USB mouse and tablet

2010-05-04 Thread Brad Jorsch
Adjust the USB report descriptors to indicate that the mouse and tablet have horizontal wheels, and then report the delta when polled. Signed-off-by: Brad Jorsch --- hw/usb-hid.c | 44 1 files changed, 36 insertions(+), 8 deletions(-) diff --git a/

[Qemu-devel] [PATCH 3/5] Pass hwheel events from the front-ends

2010-05-04 Thread Brad Jorsch
SDL seems to report hwheel events as SDL_BUTTON_X1 and SDL_BUTTON_X2. VNC I am guessing is similar, and online docs indicate that Cocoa reports hwheel deltas in deltaX for NSScrollWheel. Signed-off-by: Brad Jorsch --- cocoa.m |2 +- sdl.c | 12 ++-- vnc.c | 11 --- 3

[Qemu-devel] [PATCH 1/5] Add function parameters for hwheel

2010-05-04 Thread Brad Jorsch
Add a parameter for the hwheel delta to QEMUPutMouseEntry and kbd_mouse_event, and adjust all users of those to match. At the moment, all calls to kbd_mouse_event will pass 0 for the delta. Signed-off-by: Brad Jorsch --- cocoa.m |6 +++--- console.h |4 ++-- hw/adb.

[Qemu-devel] [PATCH 2/5] Add hwheel to monitor mouse_move

2010-05-04 Thread Brad Jorsch
Adds a parameter to the monitor's mouse_move command to specify the hwheel delta. Signed-off-by: Brad Jorsch --- monitor.c |8 ++-- qemu-monitor.hx |4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 520d48d..baff2cf 100644 --- a/

Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs

2010-05-04 Thread Jan Kiszka
Anthony Liguori wrote: > On 05/04/2010 11:01 AM, Alexander Graf wrote: >> Am 04.05.2010 um 16:34 schrieb Anthony Liguori : >> >>> On 05/04/2010 09:30 AM, Alexander Graf wrote: Am 04.05.2010 um 15:44 schrieb Anthony Liguori : > On 04/20/2010 11:56 AM, Alexander Graf wrote: >>

Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs

2010-05-04 Thread Anthony Liguori
On 05/04/2010 11:01 AM, Alexander Graf wrote: Am 04.05.2010 um 16:34 schrieb Anthony Liguori : On 05/04/2010 09:30 AM, Alexander Graf wrote: Am 04.05.2010 um 15:44 schrieb Anthony Liguori : On 04/20/2010 11:56 AM, Alexander Graf wrote: Virtio-Console can only process one character at a ti

Re: [Qemu-devel] Patch to improve handling of server sockets

2010-05-04 Thread Anthony Liguori
On 05/04/2010 08:49 AM, Reinhard Max wrote: Hi, I am maintaining the tightvnc package for openSUSE and was recently confronted with an alleged vnc problem with QWMU that turned out to be a shortcoming in QEMU's code for handling TCP server sockets, which is used by the vnc and char modules.

Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs

2010-05-04 Thread Alexander Graf
Am 04.05.2010 um 16:34 schrieb Anthony Liguori : On 05/04/2010 09:30 AM, Alexander Graf wrote: Am 04.05.2010 um 15:44 schrieb Anthony Liguori : On 04/20/2010 11:56 AM, Alexander Graf wrote: Virtio-Console can only process one character at a time. Using it on S390 gave me strage "lags"

[Qemu-devel] Patch to improve handling of server sockets

2010-05-04 Thread Reinhard Max
Hi, I am maintaining the tightvnc package for openSUSE and was recently confronted with an alleged vnc problem with QWMU that turned out to be a shortcoming in QEMU's code for handling TCP server sockets, which is used by the vnc and char modules. The problem occurs when the address to liste

[Qemu-devel] Re: Qemu-KVM 0.12.3 and Multipath -> Assertion

2010-05-04 Thread André Weidemann
Hi Peter, On 03.05.2010 23:26, Peter Lieven wrote: Hi Qemu/KVM Devel Team, i'm using qemu-kvm 0.12.3 with latest Kernel 2.6.33.3. As backend we use open-iSCSI with dm-multipath. Multipath is configured to queue i/o if no path is available. If we create a failure on all paths, qemu starts to c

Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs

2010-05-04 Thread Anthony Liguori
On 05/04/2010 09:30 AM, Alexander Graf wrote: Am 04.05.2010 um 15:44 schrieb Anthony Liguori : On 04/20/2010 11:56 AM, Alexander Graf wrote: Virtio-Console can only process one character at a time. Using it on S390 gave me strage "lags" where I got the character I pressed before when pressi

Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs

2010-05-04 Thread Alexander Graf
Am 04.05.2010 um 15:44 schrieb Anthony Liguori : On 04/20/2010 11:56 AM, Alexander Graf wrote: Virtio-Console can only process one character at a time. Using it on S390 gave me strage "lags" where I got the character I pressed before when pressing one. So I typed in "abc" and only received

Re: [Qemu-devel] [PATCH] document boot option to -drive parameter

2010-05-04 Thread Anthony Liguori
On 04/16/2010 12:11 PM, Bruce Rogers wrote: The boot option is missing from the documentation for the -drive parameter. If there is a better way to descibe it, I'm all ears. Signed-off-by: Bruce Rogers This is only in qemu-kvm.git. Regards, Anthony Liguori

[Qemu-devel] Re: QEMU: current user mode breakage

2010-05-04 Thread Riku Voipio
On Fri, Apr 30, 2010 at 11:43:43AM +0200, Martin Mohring wrote: > not sure how to handle the situation. But since the commit of the new > memory allocator for QEMU user mode, my test suites show it is broken. The "0 sized write" patch still isn't applied upstream. Is that the issue (eg visible by

Re: [Qemu-devel] [PATCH] vnc: split encoding in specific files

2010-05-04 Thread Anthony Liguori
On 05/04/2010 03:12 AM, Kevin Wolf wrote: Am 03.05.2010 19:15, schrieb Anthony Liguori: On 05/03/2010 07:31 AM, Corentin Chary wrote: This will allow to implement new encodings (tight, zrle, ..) in a cleaner way. This may hurt performances, because some functions like vnc_convert_pixe

[Qemu-devel] KVM call minutes for May 4

2010-05-04 Thread Chris Wright
KVM Forum topic ideas - mgmt interface (qemud) - working breakout sessions are welcome at the Forum stable tree - have a volunteer (thanks Justin) - Anthony will write up proposal which is basically - bug fixes actively proposed for stable tree - stable maintainer collects and applies - per

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-04 Thread Luiz Capitulino
On Mon, 03 May 2010 08:16:35 -0500 Anthony Liguori wrote: > On 05/03/2010 08:06 AM, Markus Armbruster wrote: > > Luiz Capitulino writes: > > > > > >> We need to expose errno in QMP, for three reasons: > >> > >>1. Some error handling functions print errno codes to the user, > >> whi

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion

2010-05-04 Thread Kevin Wolf
Am 04.05.2010 15:42, schrieb Peter Lieven: > hi kevin, > > you did it *g* > > looks promising. applied this patched and was not able to reproduce yet :-) > > secure way to reproduce was to shut down all multipath paths, then > initiate i/o > in the vm (e.g. start an application). of course, eve

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-04 Thread Anthony Liguori
On 05/04/2010 08:56 AM, Luiz Capitulino wrote: On Mon, 03 May 2010 08:16:35 -0500 Anthony Liguori wrote: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz Capitulino writes: We need to expose errno in QMP, for three reasons: 1. Some error handling functions pri

[Qemu-devel] [patch uq/master 8/9] kvm: validate context for kvm cpu get/put operations

2010-05-04 Thread Marcelo Tosatti
From: Jan Kiszka Validate that KVM vcpu state is only read/written from cpu thread itself or that cpu is stopped. Signed-off-by: Marcelo Tosatti Index: qemu/target-i386/kvm.c === --- qemu.orig/target-i386/kvm.c +++ qemu/target-i38

[Qemu-devel] [patch uq/master 2/9] make SIG_IPI to tcg vcpu thread reliable

2010-05-04 Thread Marcelo Tosatti
Store tcg loop exit request on a global variable, and transfer it to per-CPUState exit_request after assignment of cpu_single_env. This makes exit request signal from robust. Drop the timedlock hack. Signed-off-by: Marcelo Tosatti Index: qemu/cpu-exec.c =

[Qemu-devel] [patch uq/master 1/9] kvm: set cpu_single_env around KVM_RUN ioctl

2010-05-04 Thread Marcelo Tosatti
Zero cpu_single_env before leaving global lock protection, and restore on return. Signed-off-by: Marcelo Tosatti Index: qemu/kvm-all.c === --- qemu.orig/kvm-all.c +++ qemu/kvm-all.c @@ -846,9 +846,11 @@ int kvm_cpu_exec(CPUState *en

[Qemu-devel] [patch uq/master 3/9] standardize on qemu_cpu_kick for signalling cpu thread(s)

2010-05-04 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Index: qemu/cpus.c === --- qemu.orig/cpus.c +++ qemu/cpus.c @@ -454,8 +454,7 @@ void qemu_cpu_kick(void *_env) { CPUState *env = _env; qemu_cond_broadcast(env->halt_cond); -if (kvm_enable

Re: [Qemu-devel] [PATCH] hw: better i440 emulation

2010-05-04 Thread Anthony Liguori
On 04/20/2010 01:48 PM, Bernhard M. Wiedemann wrote: updated version of an old patch http://xenon.stanford.edu/~eswierk/misc/qemu-linuxbios/qemu-piix-ram-size.patch that together with http://www.mail-archive.com/linuxb...@linuxbios.org/msg02390.html (which is already in coreboot trunk) allows cor

Re: [Qemu-devel] [PATCH] [RESEND] Make char muxer more robust wrt small FIFOs

2010-05-04 Thread Anthony Liguori
On 04/20/2010 11:56 AM, Alexander Graf wrote: Virtio-Console can only process one character at a time. Using it on S390 gave me strage "lags" where I got the character I pressed before when pressing one. So I typed in "abc" and only received "a", then pressed "d" but the guest received "b" and so

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion

2010-05-04 Thread Peter Lieven
hi kevin, you did it *g* looks promising. applied this patched and was not able to reproduce yet :-) secure way to reproduce was to shut down all multipath paths, then initiate i/o in the vm (e.g. start an application). of course, everything hangs at this point. after reenabling one path, v

[Qemu-devel] [patch uq/master 0/9] enable smp > 1 and related fixes

2010-05-04 Thread Marcelo Tosatti

Re: [Qemu-devel] Problem with QEMU on KVM

2010-05-04 Thread Anthony Liguori
On 05/04/2010 12:09 AM, Gerhard Wiesinger wrote: On Sat, 24 Apr 2010, Gerhard Wiesinger wrote: Guess problems comes from the following commit (not yet verified): commit 37c34d9d5d87ea9d51760310c8863b82cb8c055a Author: Anthony Liguori Date: Wed Mar 10 09:38:29 2010 -0600 input: make vnc us

[Qemu-devel] [PATCH] vnc: make sure to send pointer type change event on SetEncodings

2010-05-04 Thread Anthony Liguori
Commit 37c34d9d5d87ea9d51760310c8863b82cb8c055a introduced a regression when using relative mouse mode with a client that understands the PointerTypeChange pseudo-encoding. Reported-by: Marcelo Tosatti Reported-by: Gerhard Wiesinger Signed-off-by: Anthony Liguori --- vnc.c |2 ++ 1 files c

[Qemu-devel] Re: [PATCH 0/5] scsi: More reset and hotplug fixes

2010-05-04 Thread Gerd Hoffmann
On 05/04/10 14:20, Jan Kiszka wrote: This series finally stabilizes system reset during ongoing SCSI I/O here. The first patch is a repost, the others include missing reset related bits that mostly concern the LSI controller. And the last patch addresses a disk hotplugging issue: The LSI used to

[Qemu-devel] Re: [PATCH v5 3/6] char: Let writers know how much data was written in case of errors

2010-05-04 Thread Gerd Hoffmann
On 05/04/10 13:31, Amit Shah wrote: On (Tue) May 04 2010 [13:24:58], Gerd Hoffmann wrote: @@ -531,8 +534,12 @@ static int unix_write(int fd, const uint8_t *buf, int len1) while (len> 0) { ret = write(fd, buf, len); if (ret< 0) { -if (errno != EINTR&&

Re: [Qemu-devel] simple block driver cleanups

2010-05-04 Thread Christoph Hellwig
On Tue, May 04, 2010 at 02:38:07PM +0200, Kevin Wolf wrote: > Am 04.05.2010 12:43, schrieb Christoph Hellwig: > > This series cleans up the simple read-only block drivers to use the > > qemu block device API to access their backing devices, making the code > > simpler and usable over nbd/curl. I'v

[Qemu-devel] Re: qemu-user[armel/mips] and debian-rootfs

2010-05-04 Thread Kenneth Johansson
On Mon, 2010-05-03 at 21:30 +0200, Kenneth Johansson wrote: > I'm trying to setup a debian root that I can chroot into for armel and > mips from an ubuntu 9.10 x86_64. > > While I have it working for armel on a specific qemu the mips target is > more problematic. > > first both fail for qemu n

[Qemu-devel] [patch uq/master 9/9] kvm: enable smp > 1

2010-05-04 Thread Marcelo Tosatti
Process INIT/SIPI requests and enable -smp > 1. Signed-off-by: Marcelo Tosatti Index: qemu/kvm-all.c === --- qemu.orig/kvm-all.c +++ qemu/kvm-all.c @@ -593,11 +593,6 @@ int kvm_init(int smp_cpus) int ret; int i; -if

[Qemu-devel] [patch uq/master 6/9] add cpu_is_stopped helper

2010-05-04 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti Index: qemu/cpu-all.h === --- qemu.orig/cpu-all.h +++ qemu/cpu-all.h @@ -818,6 +818,7 @@ void cpu_watchpoint_remove_all(CPUState void cpu_single_step(CPUState *env, int enabled); void cpu_reset(CPU

[Qemu-devel] [patch uq/master 7/9] move stop/stopped CPU_COMMON fields after area zeroed by reset

2010-05-04 Thread Marcelo Tosatti
cpu_reset zeroes CPUState upto breakpoints member. Contents of stop/stopped should not be zeroed on cpu_reset. Signed-off-by: Marcelo Tosatti Index: qemu/cpu-defs.h === --- qemu.orig/cpu-defs.h +++ qemu/cpu-defs.h @@ -159,8 +159,6 @

[Qemu-devel] [patch uq/master 4/9] port qemu-kvm's on_vcpu code

2010-05-04 Thread Marcelo Tosatti
run_on_cpu allows to execute work on a given CPUState context. Signed-off-by: Marcelo Tosatti Index: qemu/cpu-all.h === --- qemu.orig/cpu-all.h +++ qemu/cpu-all.h @@ -818,6 +818,7 @@ void cpu_watchpoint_remove_all(CPUState void

[Qemu-devel] [patch uq/master 5/9] kvm: synchronize state from cpu context

2010-05-04 Thread Marcelo Tosatti
From: Jan Kiszka It is not safe to retrieve the KVM internal state of a given cpu while its potentially modifying it. Queue the request to run on cpu context, similarly to qemu-kvm. Signed-off-by: Marcelo Tosatti Index: qemu/kvm-all.c ==

Re: [Qemu-devel] simple block driver cleanups

2010-05-04 Thread Kevin Wolf
Am 04.05.2010 12:43, schrieb Christoph Hellwig: > This series cleans up the simple read-only block drivers to use the > qemu block device API to access their backing devices, making the code > simpler and usable over nbd/curl. I've not touched dmg yet as it's even > more bitrot than usual and dese

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion

2010-05-04 Thread Kevin Wolf
Am 04.05.2010 13:38, schrieb Peter Lieven: > hi kevin, > > i set a breakpint at bmdma_active_if. the first 2 breaks encountered > when the last path in the multipath > failed, but the assertion was not true. > when i kicked one path back in the breakpoint was reached again, this > time leading t

[Qemu-devel] [PATCH 2/5] scsi-disk: Clear aiocb on read completion

2010-05-04 Thread Jan Kiszka
Once the I/O completion callback returned, aiocb will be released by the controller. So we have to clear the reference not only in scsi_write_complete, but also in scsi_read_complete. Otherwise we risk inconsistencies when a reset hits us before the related request is released. Signed-off-by: Jan

[Qemu-devel] [PATCH 1/5] SCSI: Add disk reset handler

2010-05-04 Thread Jan Kiszka
Ensure that pending requests of an SCSI disk are purged on system reset and also restore max_lba. The latter is no only present in the reset handler as that one is called after init as well. Signed-off-by: Jan Kiszka --- hw/scsi-disk.c | 35 +++ 1 files changed,

[Qemu-devel] [PATCH 3/5] lsi: Purge message queue on reset

2010-05-04 Thread Jan Kiszka
Declare the input message queue empty and initialize the related state machine properly on controller reset. This fixes unrecoverable errors when the controller was reset during ongoing requests. Signed-off-by: Jan Kiszka --- hw/lsi53c895a.c |2 ++ 1 files changed, 2 insertions(+), 0 deletio

[Qemu-devel] [PATCH 5/5] lsi: Handle removal of selected devices

2010-05-04 Thread Jan Kiszka
We must not store references to selected devices as they may be hot-removed. Instead, look up the device based on its tag right before using it. If the device disappeared, throw an interrupt and disconnect. Signed-off-by: Jan Kiszka --- hw/lsi53c895a.c | 60 ++--

[Qemu-devel] [PATCH 0/5] scsi: More reset and hotplug fixes

2010-05-04 Thread Jan Kiszka
This series finally stabilizes system reset during ongoing SCSI I/O here. The first patch is a repost, the others include missing reset related bits that mostly concern the LSI controller. And the last patch addresses a disk hotplugging issue: The LSI used to keep pointers to the selected device, p

[Qemu-devel] [PATCH 4/5] lsi: Adjust some register reset values

2010-05-04 Thread Jan Kiszka
According to the LSI spec, the reset value of dcmd, dstat, and ctest2 were wrong, and sdid as well as ssid require zero initialization. There are surely more discrepancies, this is just another increment. Signed-off-by: Jan Kiszka --- hw/lsi53c895a.c |8 +--- 1 files changed, 5 insertion

[Qemu-devel] Re: [PATCH v4 3/5] char: unix/tcp: Add a non-blocking write handler

2010-05-04 Thread Amit Shah
On (Tue) May 04 2010 [09:43:04], Gerd Hoffmann wrote: > On 05/04/10 09:17, Amit Shah wrote: >> Add a non-blocking write handler that can return with -EAGAIN to the >> caller and also callback when the socket becomes writable. >> >> Non-blocking writes are only enabled for sockets that are opened in

[Qemu-devel] [PATCH] vnc: set the right prefered encoding

2010-05-04 Thread Corentin Chary
>From RFB specs: "The order of the encoding types given in this message is a hint by the client as to its preference (the first encoding specified being most preferred)" Signed-off-by: Corentin Chary --- vnc.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion

2010-05-04 Thread Peter Lieven
hi kevin, i set a breakpint at bmdma_active_if. the first 2 breaks encountered when the last path in the multipath failed, but the assertion was not true. when i kicked one path back in the breakpoint was reached again, this time leading to an assert. the stacktrace is from the point shortly

Re: [Qemu-devel] [PATCH 1/6] bochs: use pread

2010-05-04 Thread Christoph Hellwig
On Tue, May 04, 2010 at 07:20:22PM +0800, Roy Tam wrote: > 2010/5/4 Christoph Hellwig : > > Use pread instead of lseek + read in preparation of using the qemu > > block API. > > > > IIRC there is no pread in MinGW. It gets replaced in the next patch anyway.

[Qemu-devel] Re: [PATCH v5 3/6] char: Let writers know how much data was written in case of errors

2010-05-04 Thread Amit Shah
On (Tue) May 04 2010 [13:24:58], Gerd Hoffmann wrote: >> @@ -531,8 +534,12 @@ static int unix_write(int fd, const uint8_t *buf, int >> len1) >> while (len> 0) { >> ret = write(fd, buf, len); >> if (ret< 0) { >> -if (errno != EINTR&& errno != EAGAIN) >> +

[Qemu-devel] [PATCH v5 0/4] Introduce bit-based phys_ram_dirty, and bit-based dirty page checker.

2010-05-04 Thread Yoshiaki Tamura
The dirty and non-dirty pages are checked one by one. When most of the memory is not dirty, checking the dirty and non-dirty pages by multiple page size should be much faster than checking them one by one. We introduced bit-based phys_ram_dirty for VGA, CODE, MIGRATION, MASTER, and cpu_physical_m

[Qemu-devel] Re: [PATCH v5 3/6] char: Let writers know how much data was written in case of errors

2010-05-04 Thread Gerd Hoffmann
@@ -531,8 +534,12 @@ static int unix_write(int fd, const uint8_t *buf, int len1) while (len> 0) { ret = write(fd, buf, len); if (ret< 0) { -if (errno != EINTR&& errno != EAGAIN) +if (len1 - len) { +return len1 - len; +

[Qemu-devel] [PATCH 4/4] doc: Clean up monitor command function index

2010-05-04 Thread Markus Armbruster
Remove bogus entries "count", "format" and "size". Accidentally added in commit 70fcbbe7. Add missing entry "qmp_capabilities". Was forgotten in commit 4a7e1190. Signed-off-by: Markus Armbruster --- qemu-monitor.hx |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/qe

Re: [Qemu-devel] [PATCH 1/6] bochs: use pread

2010-05-04 Thread Roy Tam
2010/5/4 Christoph Hellwig : > Use pread instead of lseek + read in preparation of using the qemu > block API. > IIRC there is no pread in MinGW.

[Qemu-devel] [PATCH 0/4] doc: Monitor command documentation fixes

2010-05-04 Thread Markus Armbruster
Markus Armbruster (4): doc: Fix host forwarding monitor command documentation doc: Fix acl monitor command documentation doc: Heading for monitor command cpu got lost, restore it doc: Clean up monitor command function index qemu-monitor.hx | 26 +- 1 files change

[Qemu-devel] [PATCH 2/4] doc: Fix acl monitor command documentation

2010-05-04 Thread Markus Armbruster
Commit 15dfcd45 added acl_add and acl_reset, but fat-fingered their documentation to read acl_allow and acl_remove. Signed-off-by: Markus Armbruster --- qemu-monitor.hx |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 21aeb6b.

[Qemu-devel] [PATCH 1/4] doc: Fix host forwarding monitor command documentation

2010-05-04 Thread Markus Armbruster
Commit f3546deb replaced host_net_redir by hostfwd_add, hostfwd_remove, but neglected to update documentation. Signed-off-by: Markus Armbruster --- qemu-monitor.hx | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 5ea574

[Qemu-devel] [PATCH 3/4] doc: Heading for monitor command cpu got lost, restore it

2010-05-04 Thread Markus Armbruster
Broken in commit 2313086a. Signed-off-by: Markus Armbruster --- qemu-monitor.hx |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index bf47ae0..220ed9c 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -611,6 +611,8 @@ ETEXI },

[Qemu-devel] [PATCH] iov: Move from hw/ to topdir

2010-05-04 Thread Amit Shah
The iov functions can be useful to other code as well. Signed-off-by: Amit Shah CC: Christoph Hellwig --- hw/iov.c => iov.c |0 hw/iov.h => iov.h |0 2 files changed, 0 insertions(+), 0 deletions(-) rename hw/iov.c => iov.c (100%) rename hw/iov.h => iov.h (100%) diff --git a/hw/iov.c

[Qemu-devel] [PATCH v5 6/6] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data

2010-05-04 Thread Amit Shah
If the char device we're connected to is overwhelmed with data and it can't accept any more, signal to the virtio-serial-bus to stop sending us more data till we tell otherwise. If the current buffer being processed hasn't been completely written out to the char device, we have to keep it around a

[Qemu-devel] [PATCH v5 2/6] char: Add a QemuChrHandlers struct to initialise chardev handlers

2010-05-04 Thread Amit Shah
Instead of passing each handler in the qemu_add_handlers() function, create a struct of handlers that can be passed to the function instead. Signed-off-by: Amit Shah --- gdbstub.c|9 +++-- hw/debugcon.c|2 +- hw/escc.c|9 +++-- hw/etraxfs_ser.c

[Qemu-devel] [PATCH v5 5/6] char: unix/tcp: Add a non-blocking write handler

2010-05-04 Thread Amit Shah
Add a non-blocking write handler that can return with -EAGAIN to the caller and also callback when the socket becomes writable. Non-blocking writes are only enabled for sockets that are opened in non-blocking mode and only for callers that have registered a callback handler for resuming writes. S

[Qemu-devel] [PATCH v5 4/6] char: Add qemu_chr_write_nb() for nonblocking writes

2010-05-04 Thread Amit Shah
For char devices whose backing files are open in non-blocking mode, non-blocking writes can now be made using qemu_chr_write_nb(). For non-blocking chardevs, we can return -EAGAIN to callers of qemu_chr_write_nb(). When the backend is ready to accept more data, we can let the caller know via a cal

[Qemu-devel] [PATCH v5 3/6] char: Let writers know how much data was written in case of errors

2010-05-04 Thread Amit Shah
On writing errors, we just returned -1 even if some bytes were already written out. Ensure we return the number of bytes written before we return the error (on a subsequent call to qemu_chr_write()). Signed-off-by: Amit Shah --- qemu-char.c |9 - 1 files changed, 8 insertions(+), 1 d

[Qemu-devel] [PATCH v5 0/6] char: non-blocking writes, virtio-console flow control

2010-05-04 Thread Amit Shah
Hello, This series lets interested callers ask for an -EAGAIN return from the chardev backends (only unix and tcp sockets as of now) to implement their own flow control. A new call, qemu_chr_write_nb() is added, that will fallback to qemu_chr_write() if the backend file isn't non-blocking or if n

[Qemu-devel] [PATCH v5 1/6] virtio-console: Factor out common init between console and generic ports

2010-05-04 Thread Amit Shah
The initialisation for generic ports and console ports is similar. Factor out the parts that are the same in a different function that can be called from each of the initfns. Signed-off-by: Amit Shah --- hw/virtio-console.c | 31 ++- 1 files changed, 14 insertions(+

[Qemu-devel] [PATCH 6/6] parallels: use qemu block API

2010-05-04 Thread Christoph Hellwig
Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Signed-off-by: Christoph Hellwig Index: qemu-kevin/block/parallels.c ===

[Qemu-devel] [PATCH 5/6] parallels: use pread

2010-05-04 Thread Christoph Hellwig
Use pread instead of lseek + read in preparation of using the qemu block API. Signed-off-by: Christoph Hellwig Index: qemu-kevin/block/parallels.c === --- qemu-kevin.orig/block/parallels.c 2010-05-03 13:00:09.711253925 +0200 +++ q

[Qemu-devel] [PATCH 4/6] cloop: use qemu block API

2010-05-04 Thread Christoph Hellwig
Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Signed-off-by: Christoph Hellwig Index: qemu-kevin/block/cloop.c ===

[Qemu-devel] [PATCH 3/6] cloop: use pread

2010-05-04 Thread Christoph Hellwig
Use pread instead of lseek + read in preparation of using the qemu block API. Signed-off-by: Christoph Hellwig Index: qemu-kevin/block/cloop.c === --- qemu-kevin.orig/block/cloop.c 2010-05-03 13:01:09.035025542 +0200 +++ qemu-

[Qemu-devel] [PATCH 2/6] bochs: use qemu block API

2010-05-04 Thread Christoph Hellwig
Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Signed-off-by: Christoph Hellwig Index: qemu-kevin/block/bochs.c ===

[Qemu-devel] [PATCH 1/6] bochs: use pread

2010-05-04 Thread Christoph Hellwig
Use pread instead of lseek + read in preparation of using the qemu block API. Signed-off-by: Christoph Hellwig Index: qemu-kevin/block/bochs.c === --- qemu-kevin.orig/block/bochs.c 2010-05-03 12:58:53.419012621 +0200 +++ qemu-

[Qemu-devel] simple block driver cleanups

2010-05-04 Thread Christoph Hellwig
This series cleans up the simple read-only block drivers to use the qemu block device API to access their backing devices, making the code simpler and usable over nbd/curl. I've not touched dmg yet as it's even more bitrot than usual and deserves it's own series.

[Qemu-devel] [PATCH v5 3/4] Use cpu_physical_memory_set_dirty_range() to update phys_ram_dirty.

2010-05-04 Thread Yoshiaki Tamura
Modifies kvm_physical_sync_dirty_bitmap to use cpu_physical_memory_set_dirty_range() to update the row of the bit-based phys_ram_dirty bitmap at once. Signed-off-by: OHMURA Kei Signed-off-by: Yoshiaki Tamura --- kvm-all.c | 24 +--- 1 files changed, 9 insertions(+), 15 del

[Qemu-devel] Re: [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblocking writes

2010-05-04 Thread Gerd Hoffmann
Hi, -static int unix_write(int fd, const uint8_t *buf, int len1) +static int unix_write(int fd, const uint8_t *buf, int len1, bool nonblock) { int ret, len; @@ -522,6 +537,9 @@ static int unix_write(int fd, const uint8_t *buf, int len1) while (len> 0) { ret = write(fd

[Qemu-devel] Re: [PATCH] virtio-spec: document block CMD and FLUSH

2010-05-04 Thread Christoph Hellwig
On Tue, May 04, 2010 at 02:08:24PM +0930, Rusty Russell wrote: > On Fri, 19 Feb 2010 08:52:20 am Michael S. Tsirkin wrote: > > I took a stub at documenting CMD and FLUSH request types in virtio > > block. Christoph, could you look over this please? > > > > I note that the interface seems full of

[Qemu-devel] Re: [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblocking writes

2010-05-04 Thread Amit Shah
On (Tue) May 04 2010 [09:38:11], Gerd Hoffmann wrote: > Hi, > >> -static int unix_write(int fd, const uint8_t *buf, int len1) >> +static int unix_write(int fd, const uint8_t *buf, int len1, bool nonblock) >> { >> int ret, len; >> >> @@ -522,6 +537,9 @@ static int unix_write(int fd, const

[Qemu-devel] Re: apparent key mapping error for usb keyboard

2010-05-04 Thread Avi Kivity
On 04/27/2010 12:46 PM, Michael Tokarev wrote: I've a debian bugreport that claims to have a fix for apparently wrong keymap for usb keyboard. I noticed this before with ps/2 keyboard too, the sympthoms were that e.g windows keys were not working in guests, but later on that has been fixed. But

[Qemu-devel] [PATCH v5 2/4] Introduce cpu_physical_memory_get_dirty_range().

2010-05-04 Thread Yoshiaki Tamura
It checks the first row and puts dirty addr in the array. If the first row is empty, it skips to the first non-dirty row or the end addr, and put the length in the first entry of the array. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- cpu-all.h |4 +++ exec.c| 67

Re: [Qemu-devel] [PATCH] vnc: split encoding in specific files

2010-05-04 Thread Kevin Wolf
Am 03.05.2010 19:15, schrieb Anthony Liguori: > On 05/03/2010 07:31 AM, Corentin Chary wrote: >> This will allow to implement new encodings (tight, zrle, ..) >> in a cleaner way. This may hurt performances, because some >> functions like vnc_convert_pixel are not static anymore, but >> should not b

Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-05-04 Thread Daniel P. Berrange
On Mon, May 03, 2010 at 11:59:55AM -0500, Anthony Liguori wrote: > On 05/03/2010 04:29 AM, Markus Armbruster wrote: > >Why am I proposing to remove pci_add from QMP before its replacement is > >ready? I want it out sooner rather than later, because it isn't fully > >functional (errors and drive_ad

Re: [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting

2010-05-04 Thread Kevin Wolf
Am 03.05.2010 19:01, schrieb Anthony Liguori: > On 03/29/2010 06:03 AM, Kevin Wolf wrote: >> Am 28.03.2010 19:07, schrieb Ryota Ozaki: >> >>> - use err(3) instead of errx(3) if errno is available >>>to report why failed >>> - let fail prior to daemon(3) if opening a nbd file >>>is likel

[Qemu-devel] [PATCH v5 1/4] Modify DIRTY_FLAG value and introduce DIRTY_IDX to use as indexes of bit-based phys_ram_dirty.

2010-05-04 Thread Yoshiaki Tamura
Replaces byte-based phys_ram_dirty bitmap with four (MASTER, VGA, CODE, MIGRATION) bit-based phys_ram_dirty bitmap. On allocation, it sets all bits in the bitmap. It uses ffs() to convert DIRTY_FLAG to DIRTY_IDX. Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_r

[Qemu-devel] [PATCH v5 4/4] Use cpu_physical_memory_get_dirty_range() to check multiple dirty pages.

2010-05-04 Thread Yoshiaki Tamura
Modifies ram_save_block() and ram_save_remaining() to use cpu_physical_memory_get_dirty_range() to check multiple dirty and non-dirty pages at once. Signed-off-by: Yoshiaki Tamura Signed-off-by: OHMURA Kei --- arch_init.c | 54 +- 1 files ch

[Qemu-devel] Re: [PATCH] virtio-spec: document block CMD and FLUSH

2010-05-04 Thread Jens Axboe
On Tue, May 04 2010, Rusty Russell wrote: > On Fri, 19 Feb 2010 08:52:20 am Michael S. Tsirkin wrote: > > I took a stub at documenting CMD and FLUSH request types in virtio > > block. Christoph, could you look over this please? > > > > I note that the interface seems full of warts to me, > > this

Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject"

2010-05-04 Thread Markus Armbruster
Anthony Liguori writes: > On 05/03/2010 04:29 AM, Markus Armbruster wrote: [...] >> Why am I proposing to remove pci_add from QMP before its replacement is >> ready? I want it out sooner rather than later, because it isn't fully >> functional (errors and drive_add are missing), and we do not pla

Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion

2010-05-04 Thread Kevin Wolf
Am 03.05.2010 23:26, schrieb Peter Lieven: > Hi Qemu/KVM Devel Team, > > i'm using qemu-kvm 0.12.3 with latest Kernel 2.6.33.3. > As backend we use open-iSCSI with dm-multipath. > > Multipath is configured to queue i/o if no path is available. > > If we create a failure on all paths, qemu starts

[Qemu-devel] Re: [PATCH] virtio-spec: document block CMD and FLUSH

2010-05-04 Thread Avi Kivity
On 05/04/2010 07:38 AM, Rusty Russell wrote: On Fri, 19 Feb 2010 08:52:20 am Michael S. Tsirkin wrote: I took a stub at documenting CMD and FLUSH request types in virtio block. Christoph, could you look over this please? I note that the interface seems full of warts to me, this might be a

Re: [Qemu-devel] [PATCH v4 1/4] Modify DIRTY_FLAG value and introduce DIRTY_IDX to use as indexes of bit-based phys_ram_dirty.

2010-05-04 Thread Yoshiaki Tamura
Sure. Submitted as v5. Thanks, Yoshi 2010/5/4 Anthony Liguori : > Hi Yoshi, > > Could you rebase this series and resubmit?  It conflicts with the latest > HEAD. > > Regards, > > Anthony Liguori > > On 04/19/2010 10:40 PM, Yoshiaki Tamura wrote: >> >> Replaces byte-based phys_ram_dirty bitmap wi

[Qemu-devel] Re: [PATCH v4 3/5] char: unix/tcp: Add a non-blocking write handler

2010-05-04 Thread Gerd Hoffmann
On 05/04/10 09:56, Amit Shah wrote: The logic will be pretty much the same for all filehandle-based backends on unix. So maybe create some helper functions, so implementing $backend_chr_write_unblocked can be done with just three lines of code? Yes, that's the next step. Let's push this for no

[Qemu-devel] Re: [PATCH v4 3/5] char: unix/tcp: Add a non-blocking write handler

2010-05-04 Thread Gerd Hoffmann
On 05/04/10 09:17, Amit Shah wrote: Add a non-blocking write handler that can return with -EAGAIN to the caller and also callback when the socket becomes writable. Non-blocking writes are only enabled for sockets that are opened in non-blocking mode and only for callers that have registered a ca

[Qemu-devel] [PATCH v4 0/5] char: non-blocking writes, virtio-console flow control

2010-05-04 Thread Amit Shah
Hello, This series lets interested callers ask for an -EAGAIN return from the chardev backends (only unix and tcp sockets as of now) to implement their own flow control. A new call, qemu_chr_write_nb() is added, that will fallback to qemu_chr_write() if the backend file isn't non-blocking or if n

[Qemu-devel] [PATCH v4 5/5] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data

2010-05-04 Thread Amit Shah
If the char device we're connected to is overwhelmed with data and it can't accept any more, signal to the virtio-serial-bus to stop sending us more data till we tell otherwise. If the current buffer being processed hasn't been completely written out to the char device, we have to keep it around a

[Qemu-devel] [PATCH v4 2/5] char: Add qemu_chr_write_nb() for nonblocking writes

2010-05-04 Thread Amit Shah
For char devices whose backing files are open in non-blocking mode, non-blocking writes can now be made using qemu_chr_write_nb(). For non-blocking chardevs, we can return -EAGAIN to callers of qemu_chr_write_nb(). When the backend is ready to accept more data, we can let the caller know via a cal

  1   2   >