On Thu, 6 May 2010 03:49:46 pm Michael S. Tsirkin wrote:
> Now, I also added an mb() in guest between read and write so
> that last used index write can not get ahead of used index read.
> It does feel good to have it there, but I can not say why
> it's helpful. Works fine without it, but then thes
On Thu, 6 May 2010 07:30:00 pm Avi Kivity wrote:
> On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote:
> > + /* We publish the last-seen used index at the end of the available ring.
> > +* It is at the end for backwards compatibility. */
> > + vr->last_used_idx =&(vr)->avail->ring[num];
> > +
On Thu, Nov 19, 2009 at 01:19:55PM +0100, Jan Kiszka wrote:
> Hi,
>
> I just managed to push a qemu-kvm process (git rev. b496fe3431) into an
> endless loop in qcow2_alloc_cluster_offset, namely over
> QLIST_FOREACH(old_alloc, &s->cluster_allocs, next_in_flight):
>
> (gdb) bt
> #0 0x0048
2010/4/28 Artyom Tarasenko :
> 2010/4/27 Richard Henderson :
>> On 04/26/2010 02:54 PM, Artyom Tarasenko wrote:
>>> This patch introduces a regression. qemu crashes on lance test:
>>
>> I'm not sure how to get to this, since the sparc-test images don't
>> include ifconfig, and I havn't been able to
On 05/06/10 22:19, Sebastian Herbszt wrote:
Gerd Hoffmann wrote:
Hi,
Works for stdvga and qxl. vmware fails as it has the memory at pci
region 1 (region 0 has ioports) and it seems vgabios isn't prepared to
handle that ...
Do you mean vgabios currently doesn't work with qemu and "-vga vmware
Thanks, applied all.
On 5/4/10, Igor V. Kovalenko wrote:
> From: Igor V. Kovalenko
>
> - match global tte against any context
> - show global tte in MMU dump
>
> v0->v1: added default case to switch statement in demap_tlb
> - should fix gcc warning about uninitialized context variable
>
> S
Gerd Hoffmann wrote:
Hi,
Works for stdvga and qxl. vmware fails as it has the memory at pci
region 1 (region 0 has ioports) and it seems vgabios isn't prepared to
handle that ...
Do you mean vgabios currently doesn't work with qemu and "-vga vmware" ?
It works, but uses the bochs lfb at t
Function usage is only used locally, so add "static".
Signed-off-by: Stefan Weil
---
darwin-user/main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/darwin-user/main.c b/darwin-user/main.c
index ade7d48..175e12f 100644
--- a/darwin-user/main.c
+++ b/darwin-user/main.
mips_abi_choices and mips_arch_choices are only used locally.
Signed-off-by: Stefan Weil
---
mips-dis.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mips-dis.c b/mips-dis.c
index 56bffe5..4623a1c 100644
--- a/mips-dis.c
+++ b/mips-dis.c
@@ -3035,7 +3035,7 @@ struct
Function usage() is only used locally.
Signed-off-by: Stefan Weil
---
tests/qruncom.c |2 +-
tests/runcom.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qruncom.c b/tests/qruncom.c
index a8d0ef6..079f7a2 100644
--- a/tests/qruncom.c
+++ b/tests/qruncom.c
@
Use bdrv_pwrite to access the backing device instead of pread, and
convert the driver to implementing the bdrv_open method which gives
it an already opened BlockDriverState for the underlying device.
Signed-off-by: Christoph Hellwig
Index: qemu-kevin/block/parallels.c
===
Use pread instead of lseek + read in preparation of using the qemu
block API.
Signed-off-by: Christoph Hellwig
Index: qemu-kevin/block/parallels.c
===
--- qemu-kevin.orig/block/parallels.c 2010-05-06 21:59:25.809255629 +0200
+++
On Thu, May 06, 2010 at 04:44:34PM +0200, Kevin Wolf wrote:
> When reopening the image, don't guess the driver, but use the same driver as
> was used before. This is important if the format=... option was used for that
> image.
>
> Signed-off-by: Kevin Wolf
Looks good,
Reviewed-by: Christoph H
On Thu, May 06, 2010 at 02:56:38PM +0200, Kevin Wolf wrote:
> We can't assume the file protocol for Windows devices, they need the same
> detection as other files for which an explicit protocol is not specified.
Looks good,
Reviewed-by: Christoph Hellwig
+static const char cursor_left_ptr_32[32*32] = {
+""
+" X "
+" XX "
+" X.X"
+" X..X "
+" X...X
On 5/6/10, Gerd Hoffmann wrote:
> >
> > > +static const char cursor_left_ptr_32[32*32] = {
> > > +""
> > > +" X "
> > > +" XX "
> > > +" X.X"
> > > +" X..X
Hi,
Works for stdvga and qxl. vmware fails as it has the memory at pci
region 1 (region 0 has ioports) and it seems vgabios isn't prepared to
handle that ...
Do you mean vgabios currently doesn't work with qemu and "-vga vmware" ?
It works, but uses the bochs lfb at the magic address 0xe00
Arpit Patel wrote:
> Hi All,
>
> I am trying to share files between host OS and guest OS, both are Ubuntu.
>
> Here is the command line that I am using to start guest OS
> *qemu -kernel kernelimage -initrd initrd.img /dev/zero -append "cmdline"
> -smb /tmp*
> *
> *
> After which I tried to *mount
Stuart Brady wrote:
On Tue, May 04, 2010 at 10:51:37PM +0200, Sebastian Herbszt wrote:
>diff --git a/hw/pci_ids.h b/hw/pci_ids.h
>index fe7a121..4d4de93 100644
>--- a/hw/pci_ids.h
>+++ b/hw/pci_ids.h
>@@ -97,3 +97,4 @@
>#define PCI_DEVICE_ID_INTEL_82371AB 0x7111
>#define PCI_DEVICE_ID_INTEL
On 5/5/10, Igor Kovalenko wrote:
> On Wed, May 5, 2010 at 12:21 AM, Blue Swirl wrote:
> > On 5/3/10, Igor Kovalenko wrote:
> >> On Mon, May 3, 2010 at 11:54 PM, Blue Swirl wrote:
> >> > On 5/3/10, Igor Kovalenko wrote:
> >> >> On Mon, May 3, 2010 at 11:24 PM, Blue Swirl
> wrote:
> >>
Even it is not very useful, users may create images of size 0.
Without the special option CONFIG_ZERO_MALLOC, qemu_mallocz
aborts execution when it is told to allocate 0 bytes,
so avoid this kind of call.
Cc: Kevin Wolf
Signed-off-by: Stefan Weil
---
block/vdi.c |9 +++--
1 files chang
Saves one bundle per memory operation.
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 132
1 files changed, 88 insertions(+), 44 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index acd4ce8..0d275e9 100644
Am 05.05.2010 22:03, schrieb Sebastian Herbszt:
eepro100_register_devices() references three option roms:
- gpxe-eepro100-80861209.rom
- gpxe-eepro100-80861229.rom
- gpxe-eepro100-80862449.rom
The last one seems to be missing because it's not in the pc-bios
directory.
Sebastian
Yes, it is m
This patch fixes a regression introduced by commit
95a2f9bc588c3f83375d87b0a9394f89a1bcfada.
The fix is based on a patch from Kevin Wolf. Here his comment:
"The number of blocks needs to be rounded up to cover all of the virtual hard
disk. Without this fix, we can't even open our own images if th
Gerd Hoffmann wrote:
First, I'd like to be able to load the vgabios via PCI ROM bar on all
pci vga cards (stdvga, vmware, soon qxl). The PCI ID in the bios has to
match the PCI ID of the card, so we'll need a bunch of vga bios
binaries, all identical except for the PCI ID. Or we need some kind
This will allow backends to make intelligent choices about how
to implement GUEST_BASE.
Signed-off-by: Richard Henderson
---
bsd-user/main.c |9 -
exec.c|5 +
linux-user/main.c |9 -
tcg/tcg.c |3 +++
tcg/tcg.h |1 +
5 files c
On 5/5/10, Gerd Hoffmann wrote:
> Add a new cursor type to console.h and a bunch of functions to
> deal with cursors the (new) cursor.c file.
>
> Signed-off-by: Gerd Hoffmann
> ---
> Makefile.objs |3 +-
> console.h | 24 ++-
> cursor.c | 208
>
Gerd Hoffmann wrote:
Hi,
First, I'd like to be able to load the vgabios via PCI ROM bar on all
pci vga cards (stdvga, vmware, soon qxl). The PCI ID in the bios has
to match the PCI ID of the card, so we'll need a bunch of vga bios
binaries, all identical except for the PCI ID. Or we need some
Am 06.05.2010 14:55, schrieb Kevin Wolf:
The number of blocks needs to be rounded up to cover all of the
virtual hard
disk. Without this fix, we can't even open our own images if their
size is not
a multiple of the block size.
Signed-off-by: Kevin Wolf
---
block/vdi.c | 2 +-
1 files changed,
On Thu, May 6, 2010 at 11:32 AM, Anthony Liguori wrote:
> On 04/21/2010 12:53 PM, Cam Macdonell wrote:
>>
>> Support an inter-vm shared memory device that maps a shared-memory object
>> as a
>> PCI device in the guest. This patch also supports interrupts between
>> guest by
>> communicating over
On 5/5/10, Kevin Wolf wrote:
> Hi Blue Swirl,
>
> did I miss the patch posted for this commit? I can't find it on the
> mailing list. I think the BlockDriver declarations should really stay at
> the end of the source file of each driver.
>
> What about using a different way to get rid of the s
On 05/06/2010 10:52 AM, Markus Armbruster wrote:
Anthony, no reply from you; did it fall through the cracks? If you're
fine with my draft, I'll turn it into a proper patch.
Yes, sorry, I thought I had already responded as such.
Regards,
Anthony Liguori
Markus Armbruster writes:
Now that the prologue is generated after GUEST_BASE is fixed,
we can load it as an immediate, and also avoid reserving the
register if it isn't necessary.
Signed-off-by: Richard Henderson
---
tcg/hppa/tcg-target.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git
(1) The output registers were not marked call-clobbered, even though
they can be modified by called functions.
(2) The thread pointer was not marked reserved.
(3) R4-R6 are call-saved, but not saved by the prologue. Rather than
save them, mark them reserved so that we don't use them.
Sign
On 04/21/2010 12:53 PM, Cam Macdonell wrote:
Support an inter-vm shared memory device that maps a shared-memory object as a
PCI device in the guest. This patch also supports interrupts between guest by
communicating over a unix domain socket. This patch applies to the qemu-kvm
repository.
We need not reserve the register unless we're going to use it.
Signed-off-by: Richard Henderson
---
tcg/ppc/tcg-target.c |8
tcg/ppc64/tcg-target.c |9 -
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c
index ce
By doing this we can make any number of decisions about code generation
during the prologue. For instance, we can decide whether or not to
reserve a register to hold the value of GUEST_BASE.
This fixes a latent bug in the two ppc ports in that GUEST_BASE was
being loaded as an immediate before t
On Wed, May 5, 2010 at 5:20 PM, Frank Berreth wrote:
> Hi there,
> this is just an update if you are interested in the outcome. I turns out
> that my initial assumption that there would be page faults/trapping on the
> memory pages was false. The reason the throughput is so low is because the
> me
Dear Developers,
I am working on a Xen HVM platform and trying to add AUDIO CD
support to Qemu. I modified ide_atapi_cmd function to handle audio media.
This includes changing cdrom_read_toc to set ADR/Control bits to
0x10 if media is CDS_AUDIO. Changed GPCMD_MODE_SENSE_10
case to include cdda bit
Anthony, no reply from you; did it fall through the cracks? If you're
fine with my draft, I'll turn it into a proper patch.
Markus Armbruster writes:
> Anthony asked me to take a stab at rewriting his draft to something more
> along the lines of what I'm thinking. Here goes. I put some remar
The number of blocks needs to be rounded up to cover all of the virtual hard
disk. Without this fix, we can't even open our own images if their size is not
a multiple of the block size.
Signed-off-by: Kevin Wolf
---
block/vdi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --
Michael S. Tsirkin wrote:
> Hi!
> I see this in virtio_ring.c:
>
> /* Put entry in available array (but don't update avail->idx *
> until they do sync). */
>
> Why is it done this way?
> It seems that updating the index straight away would be simpler, while
> this might allow the
On Wed, May 05, 2010 at 03:38:21PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> Today we have two vgabios versions in qemu: The standard one
> (vgabios.bin) and the cirrus one (vgabios-cirrus.bin).
>
> The cirrus vgabios is a PCI ROM. We can (and do) load it into the ROM
> PCI bar. The vgabios ch
On 05/05/2010 11:58 PM, Michael S. Tsirkin wrote:
+ /* We publish the last-seen used index at the end of the available ring.
+* It is at the end for backwards compatibility. */
+ vr->last_used_idx =&(vr)->avail->ring[num];
+ /* Verify that last used index does not spill
Kevin Wolf wrote:
> When reopening the image, don't guess the driver, but use the same driver as
> was used before. This is important if the format=... option was used for that
> image.
>
> Signed-off-by: Kevin Wolf
> ---
> block.c |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-
Am 05.05.2010 20:27, schrieb Christoph Hellwig:
> Currently we have four very simple, read-only block drivers in the
> tree:
>
> - cloop:
> This one is known buggy for non-trivial use and didn't get
> any chance but the usual API changes and cleanup sweeps
> since it was commite
Implementation of the optimized code for these two functions.
This is necessary for virtio which reads and writes VirtQueue index
fields using these functions. The assumption is that this are atomic
operations, which is not the case, if the memcpy() function which is
used in the non optimized cod
Hi there,
I'm working on the conversion of the 'info network' command do QMP,
and I think I've found some problems.
Running qemu like this: qemu -net socket,listen=:
In net/socket.c, the function net_socket_listen_init() [1] is called
and a listening socket is created. There is nothing regis
Signed-off-by: Corentin Chary
---
vnc-encoding-zlib.c |9 -
vnc.h |1 +
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/vnc-encoding-zlib.c b/vnc-encoding-zlib.c
index 6a16a79..29dd1b7 100644
--- a/vnc-encoding-zlib.c
+++ b/vnc-encoding-zlib.c
@@ -83,1
Rusty Russell wrote:
> On Wed, 5 May 2010 05:47:05 am Jamie Lokier wrote:
> > Jens Axboe wrote:
> > > On Tue, May 04 2010, Rusty Russell wrote:
> > > > ISTR someone mentioning a desire for such an API years ago, so CC'ing
> > > > the
> > > > usual I/O suspects...
> > >
> > > It would be nice to h
On 05/04/2010 03:45 PM, Marcelo Tosatti wrote:
From: Jan Kiszka
It is not safe to retrieve the KVM internal state of a given cpu
while its potentially modifying it.
Queue the request to run on cpu context, similarly to qemu-kvm.
Even better is to query the state in the cpu thread; but tha
Rusty Russell wrote:
> > Seems over-zealous.
> > If the recovery_header held a strong checksum of the recovery_data you would
> > not need the first fsync, and as long as you have two places to write
> > recovery
> > data, you don't need the 3rd and 4th syncs.
> > Just:
> >
> > write_internally
On Tue, Apr 06, 2010 at 02:18:19PM +0300, Michael S. Tsirkin wrote:
> exec.c has a comment 'XXX: optimize' for lduw_phys/stw_phys,
> so let's do it, along the lines of stl_phys.
>
> The reason to address 16 bit accesses specifically is that virtio relies
> on these accesses to be done atomically,
>From RFB specs: "The order of the encoding types given in this
message is a hint by the client as to its preference (the first
encoding specified being most preferred)"
Signed-off-by: Corentin Chary
---
vnc.c | 15 +++
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git
On 05/06/2010 08:09 AM, Kevin Wolf wrote:
Am 08.04.2010 20:37, schrieb Aurelien Jarno:
Hi all,
A number of fixes have been accumulated in the stable-0.12 branch, and
I think it's time to release a new stable version. I would like to see
that happening for the end of next week (around the 18
Reduces irq_window in guest by only injecting
an interrupt if guest has handled all buffers we
used so far.
Signed-off-by: Michael S. Tsirkin
---
This is the qemu part of the story.
hw/vhost_net.c |6 ++
hw/virtio.c| 15 +++
hw/virtio.h|4
3 files changed
When reopening the image, don't guess the driver, but use the same driver as
was used before. This is important if the format=... option was used for that
image.
Signed-off-by: Kevin Wolf
---
block.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
First, I'd like to be able to load the vgabios via PCI ROM bar on all
pci vga cards (stdvga, vmware, soon qxl). The PCI ID in the bios has to
match the PCI ID of the card, so we'll need a bunch of vga bios
binaries, all identical except for the PCI ID. Or we need some kind of
binary patching. O
On Tue, May 4, 2010 at 2:01 PM, Corentin Chary wrote:
> From RFB specs: "The order of the encoding types given in this
> message is a hint by the client as to its preference (the first
> encoding specified being most preferred)"
>
> Signed-off-by: Corentin Chary
> ---
> vnc.c | 14 ++--
I'm all for killing the blocking interface. Problem is that converting
over all users isn't exactly trivial and we have plenty of them. IMHO
it isn't realistic to do the switch with a single patch series.
If we're agreed we ought to kill the blocking interface, let's define a
new proper interfac
On Wed, 5 May 2010 03:33:43 pm Neil Brown wrote:
> On Wed, 5 May 2010 14:28:41 +0930
> Rusty Russell wrote:
>
> > On Wed, 5 May 2010 05:47:05 am Jamie Lokier wrote:
> > > Jens Axboe wrote:
> > > > On Tue, May 04 2010, Rusty Russell wrote:
> > > > > ISTR someone mentioning a desire for such an API
On Thu, May 06, 2010 at 12:01:34PM +0930, Rusty Russell wrote:
> On Thu, 6 May 2010 06:28:14 am Michael S. Tsirkin wrote:
> > Rusty,
> > this is a simplified form of a patch you posted in the past.
> > I have a vhost patch that, using this feature, shows external
> > to host bandwidth grow from 5 t
On Mon, Mar 29, 2010 at 10:54:42AM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
Thanks, applied.
> ---
> exec.c |3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/exec.c b/exec.c
> index 33854e1..d69194c 100644
> --- a/exec.c
> +++ b/exec.c
>
Hi,
First, I'd like to be able to load the vgabios via PCI ROM bar on all
pci vga cards (stdvga, vmware, soon qxl). The PCI ID in the bios has
to match the PCI ID of the card, so we'll need a bunch of vga bios
binaries, all identical except for the PCI ID. Or we need some kind of
binary patchi
You need to export your share on host OS.
AFAIR in the guest OS the address to access SAMBA shares was 10.0.2.4.
Regards,
Sergei.
--- On Wed, 5/5/10, Arpit Patel wrote:
From: Arpit Patel
Subject: [Qemu-devel] Qemu - samba share help
To: qemu-devel@nongnu.org
Date: Wednesday, May 5, 2010, 1
This patch avoids handling write watchpoints on read-only memory access.
It also breaks the searching loop for watchpoint once the setup for
handling watchpoint later is done.
Signed-off-by: Jun Koi
diff --git a/exec.c b/exec.c
index 14d1fd7..6fd859f 100644
--- a/exec.c
+++ b/exec.c
@@ -2236,10
On Wed, 5 May 2010 08:39:47 pm Michael S. Tsirkin wrote:
> Hi!
> I see this in virtio_ring.c:
>
> /* Put entry in available array (but don't update avail->idx *
> until they do sync). */
>
> Why is it done this way?
> It seems that updating the index straight away would be simple
Hi there,
this is just an update if you are interested in the outcome. I turns out
that my initial assumption that there would be page faults/trapping on the
memory pages was false. The reason the throughput is so low is because the
memory was mapped non-cached. The VGA driver and the ivshmem driv
I use a legacy guest OS which sends the command 0xfd to the keyboard
controller during initialization. To get rid of the message
"qemu: unsupported keyboard cmd=0x%02x\n" I added support for
the pulse output bit commands.
Signed-off-by: Bernhard Kohl
---
hw/pckbd.c | 23 --
Implementation of the optimized code for these two functions.
This is necessary for virtio which reads and writes VirtQueue index
fields using these functions. The assumption is that this are atomic
operations, which is not the case, if the memcpy() function which is
used in the non optimized cod
I use a legacy guest OS which sends the command 0xfd to the keyboard
controller during initialization. To get rid of the message
"qemu: unsupported keyboard cmd=0x%02x\n" I added support for
the pulse output bit commands.
Signed-off-by: Bernhard Kohl
---
hw/pckbd.c | 23 --
Am 08.04.2010 20:37, schrieb Aurelien Jarno:
> Hi all,
>
> A number of fixes have been accumulated in the stable-0.12 branch, and
> I think it's time to release a new stable version. I would like to see
> that happening for the end of next week (around the 18th of April).
>
> If you want to see s
We can't assume the file protocol for Windows devices, they need the same
detection as other files for which an explicit protocol is not specified.
Signed-off-by: Kevin Wolf
---
block.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 10a2
On 05/04/2010 03:45 PM, Marcelo Tosatti wrote:
Applied all, thanks.
--
error compiling committee.c: too many arguments to function
On 05/05/2010 09:24 PM, Anthony Liguori wrote:
On 05/04/2010 07:45 AM, Marcelo Tosatti wrote:
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
How does this
According to http://tigervnc.org/cgi-bin/rfbproto#zlib-encoding
Signed-off-by: Corentin Chary
---
vnc-encoding-zlib.c | 12 +---
vnc.h |2 +-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/vnc-encoding-zlib.c b/vnc-encoding-zlib.c
index 4a495ad..6a16a7
Signed-off-by: Corentin Chary
---
vnc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vnc.c b/vnc.c
index a91c3a3..d0c0d00 100644
--- a/vnc.c
+++ b/vnc.c
@@ -655,7 +655,7 @@ static void send_framebuffer_update(VncState *vs, int x,
int y, int w, int h)
{
switch(v
77 matches
Mail list logo
