Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/15/2010 01:54 AM, Luiz Capitulino wrote: On Fri, 14 May 2010 19:03:36 +0200 Markus Armbruster wrote: What about PCI domains? Good point. Better to provide for them neatly now, instead of kludging them in later. When I did this conversion I asked Micheal for help wi

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-14 Thread Avi Kivity
On 05/14/2010 12:10 AM, Cam Macdonell wrote: On Mon, May 10, 2010 at 5:59 AM, Avi Kivity wrote: On 04/21/2010 08:53 PM, Cam Macdonell wrote: + +/* allocate/initialize space for interrupt handling */ +s->eventfds = qemu_mallocz(s->nr_alloc_guests * sizeof(int *));

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-14 Thread Alexander Graf
On 14.05.2010, at 18:17, Jan Kiszka wrote: > Alexander Graf wrote: >> On 12.05.2010, at 20:51, Jan Kiszka wrote: >> >>> Alexander Graf wrote: Jan Kiszka wrote: > Alexander Graf wrote: > >> Jan Kiszka wrote: >> >>> Move the buffer flush from mux_chr_read to mux_chr_can_

[Qemu-devel] [PATCH 2/2] [block]: Skip refresh_total_sectors() for scsi-generic devices

2010-05-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a BlockDriverState->sg check in block.c:bdrv_common_open() to skip the new refresh_total_sectors() call once we know we are working with a scsi-generic device. We go ahead and skip this call for scsi-generic devices because block/raw-posix.c:raw_getlength

[Qemu-devel] [PATCH 1/2] [block]: Fix scsi-generic breakage in find_image_format()

2010-05-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a special BlockDriverState->sg check in block.c:find_image_format() after bdrv_file_open() -> block/raw-posix.c:hdev_open() has been called to determine if we are dealing with a Linux host scsi-generic device or not. The patch then returns the BlockDriv

[Qemu-devel] [PATCH 0/2] Fix scsi-generic breakage in upstream qemu-kvm.git

2010-05-14 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Greetings Kevin and hch, After pulling from upstream qemu-kvm.git/master into the megasas qemu-kvm.git tree, I ran into some breakage with scsi-generic devices returning an -ESPIPE exception in bdrv_open() -> find_image_format() -> bdrv_read(), and then again from brdv

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 19:08:07 +0200 Jan Kiszka wrote: > Avi Kivity wrote: > > On 05/14/2010 08:01 PM, Avi Kivity wrote: > >> On 05/14/2010 07:52 PM, Jan Kiszka wrote: > In order not to compromise QMP adoption and make users' life easier, > this commit adds a simple text documentation whi

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 19:03:36 +0200 Markus Armbruster wrote: > > What about PCI domains? > > Good point. Better to provide for them neatly now, instead of kludging > them in later. When I did this conversion I asked Micheal for help with that and he said QEMU doesn't support PCI domains.

[Qemu-devel] Re: [PATCH RFC] virtio_blk: Use blk-iopoll for host->guest notify

2010-05-14 Thread Brian Jackson
On Friday, May 14, 2010 03:47:37 pm Stefan Hajnoczi wrote: > This patch adds blk-iopoll interrupt mitigation to virtio-blk. Instead > of processing completed requests inside the virtqueue interrupt handler, > a softirq is scheduled to process up to a maximum number of completed > requests in one g

[Qemu-devel] [PATCH] virtio-blk: Avoid zeroing every request structure

2010-05-14 Thread Stefan Hajnoczi
The VirtIOBlockRequest structure is about 40 KB in size. This patch avoids zeroing every request by only initializing fields that are read. The other fields are either written to or may not be used at all. Oprofile shows about 10% of CPU samples in memset called by virtio_blk_alloc_request(). Th

[Qemu-devel] [PATCH RFC] virtio_blk: Use blk-iopoll for host->guest notify

2010-05-14 Thread Stefan Hajnoczi
This patch adds blk-iopoll interrupt mitigation to virtio-blk. Instead of processing completed requests inside the virtqueue interrupt handler, a softirq is scheduled to process up to a maximum number of completed requests in one go. If the number of complete requests exceeds the maximum number,

[Qemu-devel] Re: [PATCH v2] sh: sm501: add 2D engine support

2010-05-14 Thread Blue Swirl
On 5/11/10, Shin-ichiro KAWASAKI wrote: > Hello Blue Swirl, and thank you for the review. > > Here's the patch modified according to your comments. > abort() is used instead of assert(), and const modifier added for > CPU*MemoryFunc. The patch does not apply. It seems to be based on some versio

[Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c

2010-05-14 Thread Miguel Di Ciurcio Filho
On Fri, May 14, 2010 at 2:03 PM, Jan Kiszka wrote: >> >> In both cases the info_str string is written inside >> net_socket_fd_init_(stream|dgram), and after that, it is >> overwritten on a subsequent snprintf() in net_socket_accept(). >> > > There is non-zero time window between registration and a

[Qemu-devel] [PATCH] Add QEMU DirectFB display driver

2010-05-14 Thread Julian Pidancet
This patch implements a DirectFB driver for QEMU. It allows Qemu to draw a VM graphic output directly in the framebuffer of the host, without having to rely on X11. DirectFB also provides with a generic interface take advantage of graphic hardware acceleration for a bunch of different supported car

[Qemu-devel] [PATCH] Add QEMU DirectFB display driver

2010-05-14 Thread Julian Pidancet
This patch implements a DirectFB driver for QEMU. It allows Qemu to draw a VM graphic output directly in the framebuffer of the host, without having to rely on X11. DirectFB also provides with a generic interface take advantage of graphic hardware acceleration for a bunch of different supported car

Re: [Qemu-devel] [PATCH 0/8] Basic device state visualization

2010-05-14 Thread Blue Swirl
On 5/14/10, Jan Kiszka wrote: > While recently fixing the SCSI reset issues, I once again had the need > for displaying the state of involved devices. So far the common approach > is to attach gdb to qemu (or even inject some printf). But that time I > hacked up a 30-minute patch to dump the vm

Re: [Qemu-devel] [PATCH 0/8] Basic device state visualization

2010-05-14 Thread Anthony Liguori
On 05/14/2010 08:20 AM, Jan Kiszka wrote: While recently fixing the SCSI reset issues, I once again had the need for displaying the state of involved devices. So far the common approach is to attach gdb to qemu (or even inject some printf). But that time I hacked up a 30-minute patch to dump the

Re: [Qemu-devel] [PATCH 3/8] Add QBuffer

2010-05-14 Thread Anthony Liguori
On 05/14/2010 08:20 AM, Jan Kiszka wrote: diff --git a/qjson.c b/qjson.c index 483c667..4d1c21a 100644 --- a/qjson.c +++ b/qjson.c @@ -19,7 +19,9 @@ #include "qlist.h" #include "qbool.h" #include "qfloat.h" +#include "qbuffer.h" #include "qdict.h" +#include "base64.h" typedef struct JS

[Qemu-devel] [PATCH 10/21] block: Fix bdrv_commit

2010-05-14 Thread Kevin Wolf
When reopening the image, don't guess the driver, but use the same driver as was used before. This is important if the format=... option was used for that image. Signed-off-by: Kevin Wolf --- block.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c

[Qemu-devel] [PATCH 19/21] use qemu_free() instead of free()

2010-05-14 Thread Kevin Wolf
From: Bruce Rogers There is a call to free() where qemu_free() should instead be used. Signed-off-by: Bruce Rogers Signed-off-by: Kevin Wolf --- block.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index c134c2b..96ef1b1 100644 --- a/block.c +++

[Qemu-devel] [PATCH 21/21] block: Remove special case for vvfat

2010-05-14 Thread Kevin Wolf
The special case doesn't really us buy anything. Without it vvfat works more consistently as a protocol. We get raw on top of vvfat now, which works just as well as using vvfat directly. Signed-off-by: Kevin Wolf --- block.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 08:08 PM, Jan Kiszka wrote: I mean, a patch introducing or modifying a monitor command. The snippets should be readable by themselves. They may be readable, but that doesn't mean anyone will read them. It's a lot easier for someone who isn't involved in the code (the li

[Qemu-devel] [PATCH 20/21] Fix docs for block stats monitor command

2010-05-14 Thread Kevin Wolf
From: Daniel P. Berrange The 'parent' field in the 'query-blockstats' monitor command is part of the top level block device QDict, not part of the 2nd level 'stats' QDict. * block.c: Fix docs for 'parent' field in block stats monitor command output Signed-off-by: Daniel P. Berrange Signed-of

[Qemu-devel] [PATCH 18/21] block/vdi: Fix image opening and creation for odd disk sizes

2010-05-14 Thread Kevin Wolf
From: Stefan Weil The fix is based on a patch from Kevin Wolf. Here his comment: "The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of the block size." While Kevin's patch addres

[Qemu-devel] [PATCH 17/21] dmg: use qemu block API

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Dmg actually does an lseek to a negative offset in the open routine, whi

[Qemu-devel] [PATCH 02/21] qemu-nbd: Improve error reporting

2010-05-14 Thread Kevin Wolf
From: Ryota Ozaki - use err(3) instead of errx(3) if errno is available to report why failed - let fail prior to daemon(3) if opening a nbd file is likely to fail after daemonizing to avoid silent failure exit - add missing 'ret = 1' when unix_socket_outgoing failed Signed-off-by: Ryota Oz

[Qemu-devel] [PATCH 16/21] dmg: use pread

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use pread instead of lseek + read in preparation of using the qemu block API. Note that dmg actually uses the implicit file offset a lot in dmg_open, and we had to replace it with an offset variable. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block

[Qemu-devel] [PATCH 14/21] block/vpc: Fix conversion from size to disk geometry

2010-05-14 Thread Kevin Wolf
From: Stefan Weil The VHD algorithm calculates a disk geometry which is usually smaller than the requested size. QEMU tried to round up but failed for certain sizes: qemu-img create -f vpc disk.vpc 9437184 would create an image with 9435136 bytes (which is too small for qemu-img convert). Inst

[Qemu-devel] [PATCH 15/21] dmg: fix reading of uncompressed chunks

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig When dmg_read_chunk encounters an uncompressed chunk it currently calls read without any previous adjustment of the file postion. This seems very wrong, and the "reference" implementation in dmg2img does a search to the same offset as done in the various compression cases

[Qemu-devel] [PATCH 12/21] parallels: use pread

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use pread instead of lseek + read in preparation of using the qemu block API. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block/parallels.c | 33 +++-- 1 files changed, 11 insertions(+), 22 deletions(-) diff --git a/blo

[Qemu-devel] [PATCH 11/21] block/vdi: Allow disk images of size 0

2010-05-14 Thread Kevin Wolf
From: Stefan Weil Even it is not very useful, users may create images of size 0. Without the special option CONFIG_ZERO_MALLOC, qemu_mallocz aborts execution when it is told to allocate 0 bytes, so avoid this kind of call. Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf -

[Qemu-devel] [PATCH 05/21] ide: Fix ide_dma_cancel

2010-05-14 Thread Kevin Wolf
When cancelling a request, bdrv_aio_cancel may decide that it waits for completion of a request rather than for cancellation. IDE therefore can't abandon its DMA status before calling bdrv_aio_cancel; otherwise the callback of a completed request would use invalid data. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 09/21] block: Fix protocol detection for Windows devices

2010-05-14 Thread Kevin Wolf
We can't assume the file protocol for Windows devices, they need the same detection as other files for which an explicit protocol is not specified. Signed-off-by: Kevin Wolf --- block.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 6345

[Qemu-devel] [PATCH 06/21] bochs: use pread

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use pread instead of lseek + read in preparation of using the qemu block API. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block/bochs.c | 63 ++-- 1 files changed, 20 insertions(+), 43 deletions(-

[Qemu-devel] [PATCH 04/21] cloop: use qemu block API

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block/

[Qemu-devel] [PATCH 13/21] parallels: use qemu block API

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block/

[Qemu-devel] [PULL 00/21] Block patches

2010-05-14 Thread Kevin Wolf
The following changes since commit 14ac15d3ac8e0ef1c91204e2ac772b6412a6b99e: Anthony Liguori (1): Update SeaBIOS are available in the git repository at: git://repo.or.cz/qemu/kevin.git block Bruce Rogers (1): use qemu_free() instead of free() Christoph Hellwig (9): cloop

[Qemu-devel] [PATCH 07/21] bochs: use qemu block API

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block/

[Qemu-devel] [PATCH 08/21] block: Avoid unchecked casts for AIOCBs

2010-05-14 Thread Kevin Wolf
Use container_of for one direction and &acb->common for the other one. Signed-off-by: Kevin Wolf --- block.c |3 ++- block/blkdebug.c |4 ++-- block/qcow.c |2 +- block/qcow2.c|2 +- block/vdi.c |2 +- 5 files changed, 7 insertions(+), 6 deletions(-) di

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 08:03 PM, Markus Armbruster wrote: Avi Kivity writes: On 05/14/2010 11:50 AM, Markus Armbruster wrote: + +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } } Oh, we do have more. Please document the units for this value (bits per

[Qemu-devel] [PATCH 01/21] block: Remove semicolon in BDRV_SECTOR_MASK macro

2010-05-14 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.h b/block.h index f87d24e..278259c 100644 --- a/block.h +++ b/block.h @@ -38,7 +38,7 @@ typedef struct QEMUSnapshotInfo {

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Jan Kiszka
Avi Kivity wrote: > On 05/14/2010 08:01 PM, Avi Kivity wrote: >> On 05/14/2010 07:52 PM, Jan Kiszka wrote: In order not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. Thi

[Qemu-devel] [PATCH 03/21] cloop: use pread

2010-05-14 Thread Kevin Wolf
From: Christoph Hellwig Use pread instead of lseek + read in preparation of using the qemu block API. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block/cloop.c | 32 +--- 1 files changed, 17 insertions(+), 15 deletions(-) diff --git a/block/cl

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Avi Kivity writes: > On 05/14/2010 11:50 AM, Markus Armbruster wrote: >> + +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } } >>> Oh, we do have more. >>> >>> Please document the units for this value (bits per second)? >>> >> bytes per second? >>

Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver

2010-05-14 Thread Anthony Liguori
On 05/14/2010 11:58 AM, Julian Pidancet wrote: This patch implements a DirectFB driver for QEMU. It allows Qemu to draw a VM graphic output directly in the framebuffer of the host, without having to rely on X11. DirectFB also provides with a generic interface take advantage of graphic hardware ac

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Markus Armbruster
Avi Kivity writes: > On 05/14/2010 11:33 AM, Markus Armbruster wrote: >> >> And we absolutely need to make use of that license to improve stuff. >> Premature stability leads to stable crap. Having to get everything >> right the first time is just too hard for mortals. >> > > If that is the w

[Qemu-devel] Re: [PATCH] net: Remove dead code from net/socket.c

2010-05-14 Thread Jan Kiszka
Miguel Di Ciurcio Filho wrote: > When a connection is accepted, the handler net_socket_accept() calls > net_socket_fd_init(). If the socket is UDP/multicast, > net_socket_fd_init() calls net_socket_fd_init_dgram, if > the socket is TCP it calls net_socket_fd_init_dgram_stream. > > In both cases th

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 08:01 PM, Avi Kivity wrote: On 05/14/2010 07:52 PM, Jan Kiszka wrote: In order not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. This is not ideal for a number of reasons (ha

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 07:52 PM, Jan Kiszka wrote: In order not to compromise QMP adoption and make users' life easier, this commit adds a simple text documentation which fully describes all QMP supported commands. This is not ideal for a number of reasons (harder to maintain, text-only, etc) but does

[Qemu-devel] [PATCH] Add QEMU DirectFB display driver

2010-05-14 Thread Julian Pidancet
This patch implements a DirectFB driver for QEMU. It allows Qemu to draw a VM graphic output directly in the framebuffer of the host, without having to rely on X11. DirectFB also provides with a generic interface take advantage of graphic hardware acceleration for a bunch of different supported car

[Qemu-devel] Re: [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Jan Kiszka
Luiz Capitulino wrote: > One of the most important missing feature in QMP today is its > supported commands documentation. > > The plan is to make it part of self-description support, however > self-description is a big task we have been postponing for a > long time now and still don't know when i

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 11:33 AM, Markus Armbruster wrote: And we absolutely need to make use of that license to improve stuff. Premature stability leads to stable crap. Having to get everything right the first time is just too hard for mortals. If that is the way we go (and I'm not sure what's the

[Qemu-devel] [PATCH] net: Remove dead code from net/socket.c

2010-05-14 Thread Miguel Di Ciurcio Filho
When a connection is accepted, the handler net_socket_accept() calls net_socket_fd_init(). If the socket is UDP/multicast, net_socket_fd_init() calls net_socket_fd_init_dgram, if the socket is TCP it calls net_socket_fd_init_dgram_stream. In both cases the info_str string is written inside net_soc

[Qemu-devel] Re: [PATCH 0/8] Basic device state visualization

2010-05-14 Thread Avi Kivity
On 05/14/2010 07:24 PM, Jan Kiszka wrote: I'd like to see qmp command documentation for this. Will add it once the doc baseline is merged. How about posting it as a patch on top of the documentation patch? That allows us to review it (which IMO should be a condition for acce

[Qemu-devel] Re: [PATCH 0/8] Basic device state visualization

2010-05-14 Thread Jan Kiszka
Avi Kivity wrote: > On 05/14/2010 04:20 PM, Jan Kiszka wrote: >> While recently fixing the SCSI reset issues, I once again had the need >> for displaying the state of involved devices. So far the common approach >> is to attach gdb to qemu (or even inject some printf). But that time I >> hacked up

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-14 Thread Jan Kiszka
Alexander Graf wrote: > On 12.05.2010, at 20:51, Jan Kiszka wrote: > >> Alexander Graf wrote: >>> Jan Kiszka wrote: Alexander Graf wrote: > Jan Kiszka wrote: > >> Move the buffer flush from mux_chr_read to mux_chr_can_read. While the >> latter is called periodically, the

[Qemu-devel] Re: [PATCH 0/8] Basic device state visualization

2010-05-14 Thread Avi Kivity
On 05/14/2010 04:20 PM, Jan Kiszka wrote: While recently fixing the SCSI reset issues, I once again had the need for displaying the state of involved devices. So far the common approach is to attach gdb to qemu (or even inject some printf). But that time I hacked up a 30-minute patch to dump the

[Qemu-devel] Re: [PATCH] char: Flush read buffer in mux_chr_can_read

2010-05-14 Thread Alexander Graf
On 12.05.2010, at 20:51, Jan Kiszka wrote: > Alexander Graf wrote: >> Jan Kiszka wrote: >>> Alexander Graf wrote: >>> Jan Kiszka wrote: > Move the buffer flush from mux_chr_read to mux_chr_can_read. While the > latter is called periodically, the former will only be invoked whe

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp > 1

2010-05-14 Thread Alexander Graf
On 14.05.2010, at 17:54, Jan Kiszka wrote: > Alexander Graf wrote: >> On 14.05.2010, at 17:48, Avi Kivity wrote: >> >>> On 05/14/2010 05:06 PM, Alexander Graf wrote: On 12.05.2010, at 23:25, Marcelo Tosatti wrote: > Process INIT/SIPI requests and enable -smp> 1. >

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp > 1

2010-05-14 Thread Jan Kiszka
Alexander Graf wrote: > On 14.05.2010, at 17:48, Avi Kivity wrote: > >> On 05/14/2010 05:06 PM, Alexander Graf wrote: >>> On 12.05.2010, at 23:25, Marcelo Tosatti wrote: >>> >>> Process INIT/SIPI requests and enable -smp> 1. >>> Does this enable real SMP or does it still only al

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp > 1

2010-05-14 Thread Alexander Graf
On 14.05.2010, at 17:48, Avi Kivity wrote: > On 05/14/2010 05:06 PM, Alexander Graf wrote: >> On 12.05.2010, at 23:25, Marcelo Tosatti wrote: >> >> >>> Process INIT/SIPI requests and enable -smp> 1. >>> >> Does this enable real SMP or does it still only allow one vcpu to run at a >> ti

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp > 1

2010-05-14 Thread Avi Kivity
On 05/14/2010 05:06 PM, Alexander Graf wrote: On 12.05.2010, at 23:25, Marcelo Tosatti wrote: Process INIT/SIPI requests and enable -smp> 1. Does this enable real SMP or does it still only allow one vcpu to run at a time? The realest ever. Still doesn't use in-kernel irqchip

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Avi Kivity
On 05/14/2010 11:50 AM, Markus Armbruster wrote: + +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } } Oh, we do have more. Please document the units for this value (bits per second)? bytes per second? Bandwidth is typically measured in bits per second.

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/14/2010 10:02 AM, Daniel P. Berrange wrote: On Fri, May 14, 2010 at 09:52:53AM -0500, Anthony Liguori wrote: On 05/14/2010 09:42 AM, Daniel P. Berrange wrote: It is preferable to query the explicit capability wanted, because version numbers are useless when distros backport feat

Re: [Qemu-devel] [PATCH 1/2] QMP: Introduce commands doc

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 10:39:29 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Thu, 13 May 2010 16:48:13 +0300 > > Avi Kivity wrote: > > > >> On 05/05/2010 10:11 PM, Luiz Capitulino wrote: > >> > One of the most important missing feature in QMP today is its > >> > supported com

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 09:52:53AM -0500, Anthony Liguori wrote: > On 05/14/2010 09:42 AM, Daniel P. Berrange wrote: > > > >It is preferable to query the explicit capability wanted, because > >version numbers are useless when distros backport features, > > Unless distros add their own release numb

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/14/2010 09:42 AM, Daniel P. Berrange wrote: It is preferable to query the explicit capability wanted, because version numbers are useless when distros backport features, Unless distros add their own release number to the version information and libvirt learns about the features they add

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 09:22:55AM -0500, Anthony Liguori wrote: > On 05/14/2010 08:54 AM, Daniel P. Berrange wrote: > >On Fri, May 14, 2010 at 08:24:09AM -0500, Anthony Liguori wrote: > > > >>On 05/13/2010 08:07 AM, Jes Sorensen wrote: > >> > >>>On 05/13/10 15:04, Cole Robinson wrote: > >>

Re: [Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Markus Armbruster
Anthony Liguori writes: > Can we do this all via the monitor? IOW, can libvirt invoke qemu > blindly and strictly interact with the monitor? I think that's exactly where should be heading longer term. It's not a practical immediate solution, e.g. because device_add can't cold-plug, yet.

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/14/2010 08:54 AM, Daniel P. Berrange wrote: On Fri, May 14, 2010 at 08:24:09AM -0500, Anthony Liguori wrote: On 05/13/2010 08:07 AM, Jes Sorensen wrote: On 05/13/10 15:04, Cole Robinson wrote: On 05/13/2010 04:35 AM, Jes Sorensen wrote: On 05/12/10 22:48, C

[Qemu-devel] Re: [PATCH] Fix docs for block stats monitor command

2010-05-14 Thread Kevin Wolf
Am 14.05.2010 16:05, schrieb Luiz Capitulino: > On Fri, 14 May 2010 10:15:32 +0200 > Kevin Wolf wrote: > >> Am 13.05.2010 12:30, schrieb Daniel P. Berrange: >>> The 'parent' field in the 'query-blockstats' monitor command is >>> part of the top level block device QDict, not part of the 2nd >>> le

[Qemu-devel] [PATCH] [S390] [KVM] Enable SIGP Initial Reset

2010-05-14 Thread Alexander Graf
For SMP to work with KVM, we need to properly emulate the SIGP Initial Reset Command. Recent (2.6.32) kernels issue that before the SIGP Reset command that actually wakes up the vcpu. This patch makes -smp work on S390x. Signed-off-by: Alexander Graf --- target-s390x/kvm.c | 17 ++

Re: [Qemu-devel] Re: [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 08:21:55AM -0500, Anthony Liguori wrote: > On 05/13/2010 03:32 AM, jes.soren...@redhat.com wrote: > >From: Jes Sorensen > > > >Add -version-simple argument for QEMU, printing just the version > >number, without any supporting text. > > > > I'm not a huge fan of the name.

Re: [Qemu-devel] [RFC] New Monitor command: 'info netdevices'

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 09:38:58 -0300 Miguel Di Ciurcio Filho wrote: > On Fri, May 14, 2010 at 6:46 AM, Markus Armbruster wrote: > > > > There's also > > > > 3. Convert it anyway.  Clean up the mess.  Change the output. > > > > I agree. > > It seams to me that no one is concerned with any Monitor

[Qemu-devel] Re: [PATCH 10/12] kvm: enable smp > 1

2010-05-14 Thread Alexander Graf
On 12.05.2010, at 23:25, Marcelo Tosatti wrote: > Process INIT/SIPI requests and enable -smp > 1. Does this enable real SMP or does it still only allow one vcpu to run at a time? Alex

[Qemu-devel] Re: [PATCH] Fix docs for block stats monitor command

2010-05-14 Thread Luiz Capitulino
On Fri, 14 May 2010 10:15:32 +0200 Kevin Wolf wrote: > Am 13.05.2010 12:30, schrieb Daniel P. Berrange: > > The 'parent' field in the 'query-blockstats' monitor command is > > part of the top level block device QDict, not part of the 2nd > > level 'stats' QDict. > > > > * block.c: Fix docs for '

Re: [Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 08:48:58AM -0500, Anthony Liguori wrote: > On 05/14/2010 05:06 AM, Daniel P. Berrange wrote: > >On Fri, May 14, 2010 at 11:42:57AM +0200, Markus Armbruster wrote: > > > >>"Daniel P. Berrange" writes: > >> > >> > >>>On Thu, May 13, 2010 at 10:32:52AM +0200, jes.soren

Re: [Qemu-devel] Re: [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Chris Lalancette
On 05/14/2010 09:21 AM, Anthony Liguori wrote: > On 05/13/2010 03:32 AM, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> Add -version-simple argument for QEMU, printing just the version >> number, without any supporting text. >> > > I'm not a huge fan of the name. > > But what info

[Qemu-devel] Re: [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Anthony Liguori
On 05/13/2010 03:32 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Add -version-simple argument for QEMU, printing just the version number, without any supporting text. I'm not a huge fan of the name. But what information are we trying to convey? Just major/minor number or would

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 08:24:09AM -0500, Anthony Liguori wrote: > On 05/13/2010 08:07 AM, Jes Sorensen wrote: > >On 05/13/10 15:04, Cole Robinson wrote: > > > >>On 05/13/2010 04:35 AM, Jes Sorensen wrote: > >> > >>>On 05/12/10 22:48, Cole Robinson wrote: > >>>I think rather than 1, it woul

Re: [Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Anthony Liguori
On 05/14/2010 05:06 AM, Daniel P. Berrange wrote: On Fri, May 14, 2010 at 11:42:57AM +0200, Markus Armbruster wrote: "Daniel P. Berrange" writes: On Thu, May 13, 2010 at 10:32:52AM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen Add -version-simple argument for QE

Re: [Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 01:24:44PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Fri, May 14, 2010 at 11:42:57AM +0200, Markus Armbruster wrote: > >> "Daniel P. Berrange" writes: > [...] > >> > It would also be nice to avoid having to parse the -help output to > >> > d

Re: [Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 08:27:54AM -0500, Anthony Liguori wrote: > On 05/13/2010 08:33 AM, Daniel P. Berrange wrote: > >On Thu, May 13, 2010 at 10:32:52AM +0200, jes.soren...@redhat.com wrote: > > > >>From: Jes Sorensen > >> > >>Add -version-simple argument for QEMU, printing just the version >

[Qemu-devel] Re: [RFC] New Monitor command: 'info netdevices'

2010-05-14 Thread Anthony Liguori
On 05/13/2010 09:18 AM, Luiz Capitulino wrote: Hi there, Miguel is working on converting 'info network' to QMP, but turns out that it's been quite difficult to maintain the exact same output. The main problem seems to be the usage of the 'info_str' string, which some drivers (like tap, xe

Re: [Qemu-devel] [PATCH 1/1] Add -version-simple argument, printing only version number.

2010-05-14 Thread Anthony Liguori
On 05/13/2010 08:33 AM, Daniel P. Berrange wrote: On Thu, May 13, 2010 at 10:32:52AM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen Add -version-simple argument for QEMU, printing just the version number, without any supporting text. This makes it simpler for other apps, such as

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/13/2010 08:07 AM, Jes Sorensen wrote: On 05/13/10 15:04, Cole Robinson wrote: On 05/13/2010 04:35 AM, Jes Sorensen wrote: On 05/12/10 22:48, Cole Robinson wrote: I think rather than 1, it would be better to add a patch to libvirt to catch both formats. I know Chris Lalancette al

[Qemu-devel] [PATCH 3/8] Add QBuffer

2010-05-14 Thread Jan Kiszka
This introduces a buffer object for use with QMP. As a buffer is not natively encodable in JSON, we encode it as a base64 string. To decode this kind of strings back to a QBuffer, the receiving side has to be aware of their semantic, which is normally no problem within QMP. The first use case of t

Re: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Daniel P. Berrange
On Fri, May 14, 2010 at 08:17:50AM -0500, Anthony Liguori wrote: > On 05/12/2010 03:48 PM, Cole Robinson wrote: > >On 05/12/2010 04:38 PM, Jes Sorensen wrote: > > > >>On 05/12/10 22:29, Cole Robinson wrote: > >> > >>>Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version > >>>s

[Qemu-devel] [PATCH 2/8] Add base64 encoder/decoder

2010-05-14 Thread Jan Kiszka
Will be used by QBuffer. Signed-off-by: Jan Kiszka --- Makefile.objs |2 +- base64.c | 202 + base64.h | 18 + 3 files changed, 221 insertions(+), 1 deletions(-) create mode 100644 base64.c create mode 100644 base64.h

[Qemu-devel] [PATCH 8/8] qdev: Add new devices/buses at the tail

2010-05-14 Thread Jan Kiszka
Cosmetic change to align the instance number assignment with bus ordering. The current ordering is a bit annoying when you dump the qtree or address devices via 'driver.instance'. Signed-off-by: Jan Kiszka --- hw/qdev.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH 0/8] Basic device state visualization

2010-05-14 Thread Jan Kiszka
While recently fixing the SCSI reset issues, I once again had the need for displaying the state of involved devices. So far the common approach is to attach gdb to qemu (or even inject some printf). But that time I hacked up a 30-minute patch to dump the vmstate of any (fully converted) qdev device

[Qemu-devel] [PATCH 6/8] qmp: Fix python helper /wrt long return strings

2010-05-14 Thread Jan Kiszka
Remove the arbitrary limitation of 1024 characters per return string and read complete lines instead. Required for device_show. Signed-off-by: Jan Kiszka --- QMP/qmp.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/QMP/qmp.py b/QMP/qmp.py index d9da603..b8f1741 100644

[Qemu-devel] [PATCH 4/8] monitor: Add basic device state visualization

2010-05-14 Thread Jan Kiszka
This introduces device_show, a monitor command that saves the vmstate of a qdev device and visualizes it. QMP is also supported. Buffers are cut after 16 byte by default, but the full content can be requested via '-f'. To pretty-print sub-arrays, vmstate is extended to store the start index name.

[Qemu-devel] [PATCH 7/8] Add QLIST_INSERT_TAIL

2010-05-14 Thread Jan Kiszka
As the QLIST has not tail pointer, this requires list walking. Still useful when lists are short or insertion time doesn't matter. Signed-off-by: Jan Kiszka --- qemu-queue.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/qemu-queue.h b/qemu-queue.h index 1d07745

[Qemu-devel] [PATCH 5/8] qmp: Teach basic capability negotiation to python example

2010-05-14 Thread Jan Kiszka
As sending "qmp_capabilities" on session start became mandatory, both python examples were broken. Signed-off-by: Jan Kiszka --- QMP/qmp-shell |1 + QMP/vm-info |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-shell b/QMP/qmp-shell index f89b9af..a5b72d1 100

[Qemu-devel] [PATCH 1/8] qdev: Allow device addressing via 'driver.instance'

2010-05-14 Thread Jan Kiszka
Extend qbus_find_dev to allow addressing of devices without an unique id via an optional instance number. The new formats are 'driver.instance' and 'alias.instance'. Signed-off-by: Jan Kiszka --- hw/qdev.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --

[Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'

2010-05-14 Thread Anthony Liguori
On 05/12/2010 03:48 PM, Cole Robinson wrote: On 05/12/2010 04:38 PM, Jes Sorensen wrote: On 05/12/10 22:29, Cole Robinson wrote: Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version string from: QEMU PC Emulator version x.yy.z to QEMU Emulator version x.yy.z libvirt

[Qemu-devel] Re: [PATCH 1/2] Add no-op aio emulation stub

2010-05-14 Thread Kevin Wolf
Am 13.05.2010 01:36, schrieb Alexander Graf: > We need to be able to do nothing in AIO fashion. Since I suspect this > could be useful for more cases than the non flushing, I figured I'd > create a new function that does everything AIO-like, but doesn't do > anything. > > Signed-off-by: Alexander

Re: [Qemu-devel] [PATCH] linux-user: use default mmap_min_addr 65536 when /proc/sys/vm/mmap_min_addr cannot be read

2010-05-14 Thread Richard Henderson
On 05/13/2010 12:26 PM, Martin Jansa wrote: > BTW: I noticed that qemu-arm works ok when mmap_min_addr is low enough > (and doesn't have to be zero). > > my box had mmap_min_addr 4096 and qemu-arm worked fine even without > reading it Paul Brook's c581deda322080e8beb88b2e468d4af54454e4b3 had the

[Qemu-devel] Re: [RFC PATCH v2 2/3] block: call the snapshot handlers of the protocol drivers

2010-05-14 Thread Kevin Wolf
Am 14.05.2010 11:51, schrieb MORITA Kazutaka: > When snapshot handlers of the format driver is not defined, it is > better to call the ones of the protocol driver. > > This enables us to implement snapshot support in the protocol driver. > > Signed-off-by: MORITA Kazutaka > int bdrv_snapshot_g

  1   2   >