[Qemu-devel] [PATCH 0/3] Monitor commands for 'simple' trace backend

2010-06-07 Thread Prerna Saxena
This patchset is based on Stefan's trace framework: ( http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02407.html ) This adds the following monitor commands for the 'simple' backend: - trace : to view current contents of the trace buffer - info tracepoints : to view all

[Qemu-devel] [PATCH] Re: Tracing backends : Fix for building with --prefix

2010-06-07 Thread Prerna Saxena
This patch is a minor fix over Stefan's tracing framework, to enable compilation when the build directory is different from source. Signed-off-by: Prerna Saxena --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index a9f79a9..ef4ae55 10

[Qemu-devel] Re: [PATCH v3 00/17] clean up vl.c code

2010-06-07 Thread Jes Sorensen
On 06/07/10 23:41, Juan Quintela wrote: > Acked-by: Juan Quintela > > Nice, thanks. Once there, perhaps you want to look about moving osdep.c > definitions to os-{posix,win32}.c. And no, that file is not nice > either. Good idea! Once I see the first set in Anthony's tree, I'll have a look at

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
On 06/08/2010 01:23 AM, Anthony Liguori wrote: A better example would be a generic counter kernel mechanism. I can envision such a device as doing nothing more than providing a read-only view of a counter with a userspace configurable divider and width. Any write to the counter or read of any

Re: [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text

2010-06-07 Thread Amit Shah
On (Mon) Jun 07 2010 [11:09:32], Anthony Liguori wrote: > On 05/31/2010 07:41 AM, Amit Shah wrote: > >Hello, > > > >This patch series adds support to specify some descriptive help text > >to qdev device parameters. This series adds some help text to the > >virtserialport and net family of devices a

Re: [Qemu-devel] [PATCH 5/5] qdev: Add new '-device help' option, shows all devices and properties

2010-06-07 Thread Amit Shah
On (Mon) Jun 07 2010 [16:43:05], Markus Armbruster wrote: > > There is "-device \?" and "-device help", but the user interface > provides no clue about the difference between them. > > "-device help" loses when we ever pick up a device model with name > "help". Not that "?" was a particularly sm

Re: [Qemu-devel] [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-07 Thread MORITA Kazutaka
At Fri, 4 Jun 2010 16:35:59 -0300, Miguel Di Ciurcio Filho wrote: > > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted an

Re: [Qemu-devel] [PATCH 0/22] Refactor machine support

2010-06-07 Thread Paul Brook
> This series introduces a rather radical change in the way we deal with > machine definitions in QEMU. I think we should aim to eliminate machine_register_core, and design appropriately. In particular I'd try and avoid adding options that become trivially redundant once you can easily change t

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Paul Brook
> max_cpus is complicated because it was used for multiple purposes. I don't see any such uses. > > This is a fundamental property/limitation of the hardware. Expect qemu to > > crash if the value is modified. > > In this case, the machine cores should be rejecting totally invalid > values to pr

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Anthony Liguori
On 06/07/2010 08:01 PM, Paul Brook wrote: diff --git a/hw/realview.c b/hw/realview.c index a36bdbe..8dcef80 100644 --- a/hw/realview.c +++ b/hw/realview.c @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = { .init = realview_eb_mpcore_init, .opts_default = (QemuOptVal

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Paul Brook
> diff --git a/hw/realview.c b/hw/realview.c > index a36bdbe..8dcef80 100644 > --- a/hw/realview.c > +++ b/hw/realview.c > @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = { > .init = realview_eb_mpcore_init, > .opts_default = (QemuOptValue[]) { > QOPT_VALUE("d

Re: [Qemu-devel] [PATCH 22/22] machine: introduce -machine-def option to define a machine via config

2010-06-07 Thread Anthony Liguori
On 06/07/2010 06:52 PM, Anthony Liguori wrote: Since we have MachineCore and can represent a machine entirely via default options, we can introduce a new option that let's us dynamically register a machine based on those options. For instance, we could add the following to target-x86_64.conf: [

[Qemu-devel] [PATCH 18/22] machine: final conversion to pure QemuOpts

2010-06-07 Thread Anthony Liguori
All we need to do is convert name and desc over and we're now purely opts driven. Signed-off-by: Anthony Liguori diff --git a/hw/an5206.c b/hw/an5206.c index 0d6a6f0..5dd679c 100644 --- a/hw/an5206.c +++ b/hw/an5206.c @@ -88,9 +88,12 @@ static void an5206_init(QemuOpts *opts) } static QEMUMa

[Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Anthony Liguori
max_cpus is a weird property today. On the one hand, it represents the maximum CPUs a board can support and is used to validate the number of vcpus requested by the user. On the other hand, max_cpus can be set by the user in which case it is taken to mean the number of physical sockets that shoul

[Qemu-devel] [PATCH 21/22] machine: convert pc machines to split core vs machine API

2010-06-07 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 5696aa7..c7c1bd7 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -162,134 +162,113 @@ static void pc_init(QemuOpts *opts) } } -static QemuOptDesc pc_opts_desc[] = { -COMMON_MACHINE_OPTS(), -{ -.n

[Qemu-devel] [PATCH 12/22] machine: some sugary macros to simplify machine default options

2010-06-07 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/hw/boards.h b/hw/boards.h index c7358ae..e05637b 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -33,6 +33,12 @@ int qemu_register_machine(QEMUMachine *m); extern QEMUMachine *current_machine; +#define QOPT_COMPAT(driver, property, value) \ +QOPT

[Qemu-devel] [PATCH 19/22] machine: introduce accel option to allow selection of kvm or tcg

2010-06-07 Thread Anthony Liguori
Syntax is -machine accel=kvm -machine accel=tcg -machine accel=kvm|tcg kvm|tcg tries kvm and fallbacks on tcg if kvm support isn't available. Signed-off-by: Anthony Liguori diff --git a/hw/boards.h b/hw/boards.h index 947fa33..1097561 100644 --- a/hw/boards.h +++ b/hw/boards

[Qemu-devel] [PATCH 11/22] machine: replace compat_props with opts_default

2010-06-07 Thread Anthony Liguori
Right now, machine structs can hard code GlobalProperty lists of default qdev global properties. This doesn't generalize well to a config file though because there are three parameters: driver, property, value. This patch moves this data to the generic machine opts default list. In the process,

[Qemu-devel] [PATCH 16/22] machine: move default machine out of machine definitions

2010-06-07 Thread Anthony Liguori
There can only be one default machine so instead of setting in each machine whether it's the default, simply declare what the name of the default machine is. A nice characteristic of this is that we technically don't need to describe the default machine in QEMU anymore. Instead, it could be descr

[Qemu-devel] [PATCH 17/22] machine: kill machine->alias

2010-06-07 Thread Anthony Liguori
Just duplicate the machine structure for now diff --git a/hw/boards.h b/hw/boards.h index b99dc68..a4dde9f 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -11,7 +11,6 @@ typedef void QEMUMachineInitFunc(QemuOpts *opts); struct QEMUMachine { const char *name; -const char *alias; cons

[Qemu-devel] [PATCH 22/22] machine: introduce -machine-def option to define a machine via config

2010-06-07 Thread Anthony Liguori
Since we have MachineCore and can represent a machine entirely via default options, we can introduce a new option that let's us dynamically register a machine based on those options. For instance, we could add the following to target-x86_64.conf: [machine-def] name = "pc-0.11" desc = "Standard

[Qemu-devel] [PATCH 20/22] machine: introduce machine core and split qemu_register_machine

2010-06-07 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/hw/boards.h b/hw/boards.h index 1097561..25881bb 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -5,18 +5,25 @@ #include "qdev.h" -typedef void QEMUMachineInitFunc(QemuOpts *opts); +typedef void QEMUCoreInitFunc(QemuOpts *opts); typedef struct QEM

[Qemu-devel] [PATCH 10/22] machine: allow boards to specify default values and use it in isapc

2010-06-07 Thread Anthony Liguori
Let boards describe default options. Structuring this way is an important step in making board definitions readable by a config file. To use the new mechanism, introduce a pci=on|off option to the pc boards and unify all of them into a single function. isapc is now just another pc board that hap

[Qemu-devel] [PATCH 06/22] Make -acpi-enable a machine specific option

2010-06-07 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/hw/boards.h b/hw/boards.h index c3f4f68..728908b 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -25,6 +25,7 @@ struct QEMUMachine { no_sdcard:1; int is_default; GlobalProperty *compat_props; +QemuOptDesc *opts_desc; struct QEM

[Qemu-devel] [PATCH 13/22] machine: get rid of global default QEMUMachine members

2010-06-07 Thread Anthony Liguori
Right now, we have a lot of default device type options in the QEMUMachine structure. This is used by code within vl.c to determine whether it should add classes of devices (like serial). Really, vl.c has no business adding devices but all we need to do to support this is create common machine op

[Qemu-devel] [PATCH 14/22] machine: replace QEMUMachine.use_scsi with -machine default_drive

2010-06-07 Thread Anthony Liguori
Some boards only support scsi and there's some ugliness to accomodate this. This patch removes that and introduces a default_drive common option for machines. The absence of this option assumes ide. It can be explicitly set to scsi and this is used to replace all current occurrances of use_scsi.

[Qemu-devel] [PATCH 07/22] machine: introduce -machine option

2010-06-07 Thread Anthony Liguori
This introduces a new -machine option that can be used to tweak machine specific parameters. One unusal feature of -machine is that there is only one machine instance and all uses of -machine are combined together. The last operation to a parameter is given priority. This let's a configuration f

[Qemu-devel] [PATCH 05/22] machine: pass all init options as a single QemuOpts

2010-06-07 Thread Anthony Liguori
The current method of passing arguments to machine init functions is haphazard. We pass some arguments as via the init function. We pass a lot of other arguments as global variables some that are supported by a lot of boards and others that are only supported by one board. It's very difficult to

[Qemu-devel] [PATCH 08/22] machine: implement -kernel/-append/-initrd options in term of -machine

2010-06-07 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/vl.c b/vl.c index 001adbe..4553648 100644 --- a/vl.c +++ b/vl.c @@ -2577,10 +2577,8 @@ int main(int argc, char **argv, char **envp) { const char *gdbstub_dev = NULL; int i; -int snapshot, linux_boot; +int snapshot; const char *ic

[Qemu-devel] [PATCH 04/22] machine: package all init arguments into a QemuOpts (v2)

2010-06-07 Thread Anthony Liguori
This patch creates a QemuOpts structure and stores all of the machine init arguments in that structure. It introduces a temporary list of QemuOptDescs in vl.c such that the current common options can be validated. The long term vision is that that list becomes a #define and that each machine can

[Qemu-devel] [PATCH 09/22] machine: implement -m in terms of -machine

2010-06-07 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/vl.c b/vl.c index 4553648..398d3b4 100644 --- a/vl.c +++ b/vl.c @@ -2968,35 +2968,14 @@ int main(int argc, char **argv, char **envp) version(); exit(0); break; -case QEMU_OPTION_m: { -

[Qemu-devel] [PATCH 02/22] QemuOpts: make qemu_opts_validate() store the description list for later use

2010-06-07 Thread Anthony Liguori
Otherwise qemu_opt_set doesn't work as expected after a validate call Signed-off-by: Anthony Liguori diff --git a/qemu-option.c b/qemu-option.c index e0cb91b..03b1ef7 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -525,6 +525,7 @@ struct QemuOpt { struct QemuOpts { char *id; QemuOp

[Qemu-devel] [PATCH 01/22] QemuOpts: fix a bug in QemuOpts when setting an option twice

2010-06-07 Thread Anthony Liguori
Right now, if you set a QemuOpts option in a section twice, when you get the option you'll receive the value that was set the first time. This is less than ideal because if you're manipulating options in two places like a global config followed by the command line, you really want the later to ove

[Qemu-devel] [PATCH 0/22] Refactor machine support

2010-06-07 Thread Anthony Liguori
This series introduces a rather radical change in the way we deal with machine definitions in QEMU. Here are the features this series introduces: - Machines are definable via a -machine-def option or a [machine-def] config stanza - Parameters such as -kernel, -initrd, -append, -m, -acpi-enab

[Qemu-devel] [PATCH 03/22] QemuOpts: add function to set QemuOpts from defaults

2010-06-07 Thread Anthony Liguori
This lets us hard code a list of default QemuOpts values in a structured way. Signed-off-by: Anthony Liguori diff --git a/qemu-option.c b/qemu-option.c index 03b1ef7..b990cf5 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -954,3 +954,23 @@ int qemu_opts_foreach(QemuOptsList *list, qemu_opts_

Re: [Qemu-devel] Getting tcg in a standalone library

2010-06-07 Thread Alexander Graf
On 07.06.2010, at 23:27, Peter Fritzsche wrote: > Hi, > > I am currently quite interesting in tcg for binary translation. There are > many > emulator projects (I mean mostly console emulators) out there which start to > implement more or less bad ILs to translate their specific cpu (for examp

[Qemu-devel] Re: KVM call agenda for June 8

2010-06-07 Thread Anthony Liguori
On 06/07/2010 05:26 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. - Accelerating counters (aka moving PIT to userspace, keeping HPET in userspace) - Live migration + hotplug Regards

[Qemu-devel] KVM call agenda for June 8

2010-06-07 Thread Chris Wright
Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. thanks, -chris

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Anthony Liguori
On 06/07/2010 01:42 PM, Avi Kivity wrote: On 06/07/2010 08:04 PM, Anthony Liguori wrote: I think we could also move the local APIC. I'm not even sure we can safely move the ioapic/pic (mostly due to churn). But the local APIC is so heavily accessed by the guest that it's impossible to move

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 04:37 PM, Anthony Liguori wrote: On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlan

[Qemu-devel] Re: [PATCH v3 00/17] clean up vl.c code

2010-06-07 Thread Juan Quintela
jes.soren...@redhat.com wrote: > From: Jes Sorensen > > Hi, > > Ok third time lucky ... I hope! This fixes the missing git add on > qemu-options.h as building for win32 using mingw (thanks Paolo!). > > The patches try to clean up the vl.c code by separating out OS > specific code into OS specific

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. The probl

[Qemu-devel] Getting tcg in a standalone library

2010-06-07 Thread Peter Fritzsche
Hi, I am currently quite interesting in tcg for binary translation. There are many emulator projects (I mean mostly console emulators) out there which start to implement more or less bad ILs to translate their specific cpu (for example gameboy has z80, n64 has r4300i, gamecube has powerpc 750CX

Re: [Qemu-devel] Build problem on Mac OS 10.6.3

2010-06-07 Thread Andreas Färber
Am 07.06.2010 um 21:00 schrieb Programmingkid: This is how I configured Qemu: ./configure --enable-cocoa --target-list=x86-softmmu One thing I did notice is this message at the end of the configure output: Unsupported target CPU It's either x86_64-softmmu or i386-softmmu. HTH, Andreas

[Qemu-devel] Live Migration of 32-bit Linux guest broken since 2.6.32-rc2

2010-06-07 Thread Peter Lieven
Hi, I freshly installed kernel 2.6.32-rc2 using userspace qemu-kvm 0.12.4. When I live migrate a 32-bit opensuse-11.2 VM, the incoming VM shows the following error after the mem transfer has finished: kvm: unhandled exit 8022 kvm: kvm_run returned -22 cmdline: /usr/bin/qemu-kvm-0.12.4 -net

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: > On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: >> >> So I see two ways to go forward: switch default value in my patch, >> or disable vlans unconditionally. >> > > The problem with disabling vlans unconditionally is that you

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. The problem with disabling vlans unconditionally is that you break -net socket and -net dump. If we can come up with an alternative way

Re: [Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 12:01 PM, Markus Armbruster wrote: >>          { >>             "device": "user.0", >>             "type": "user", >>             "info": { >>                "net": "10.0.2.0", >>                "netmask": "255.255.255.0" >>             }, >>          }, > > And this one's n

Re: [Qemu-devel] [PATCH 2/2] tcg-i386: Use segment registers to implement GUEST_BASE.

2010-06-07 Thread Richard Henderson
On 06/03/2010 11:35 PM, Alexander Graf wrote: > > On 04.06.2010, at 02:35, Richard Henderson wrote: > >> For 32-bit, using a segment override is smaller than the 4-byte >> immediate offset. For 64-bit, segments can hold the entire 64-bit >> offset whereas the 4-byte immediate cannot. > > Very

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 11:48 AM, Anthony Liguori wrote: >> >> How about this small draft: >> >> Possible values for "type": tap, user, vde and socket. The 'info' >> object contains all the parameters available via -netdev type,args. >> >> Notice: vlan is still there, unless the support for it is r

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 11:52:05AM -0500, Anthony Liguori wrote: > On 06/07/2010 11:42 AM, Paul Brook wrote: >>> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: >>> > With -netdev, there now seems to be little need to support vlans, > enabling them leads to user confusion

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
On 06/07/2010 09:54 PM, David S. Ahern wrote: So it's important to know how often your RHEL3/4 guest queries the PIT (not just receives interrupts, actually reads the counter) under a realistic load. If you have such a number (in reads/sec) that would be a good input to this discussion.

Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 11:42 AM, Daniel P. Berrange wrote: > This adds a new QMP command called query-netdev to provide information > about the available netdev backends in the QEMU binary. There is no > existing '-netdev ?' support, but if there was, this would obsolete it > Hi Daniel, Could we

[Qemu-devel] Build problem on Mac OS 10.6.3

2010-06-07 Thread Programmingkid
I would just like to know if anyone else has seen this build problem with Qemu when building on Mac OS 10.6.3: Makefile:7: config-devices.mak: No such file or directory make[1]: *** No rule to make target `config-devices.mak'. Stop. make: *** [subdir-x86-softmmu] Error 2 I am using the most re

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread David S. Ahern
On 06/07/10 12:46, Avi Kivity wrote: > On 06/07/2010 07:31 PM, David S. Ahern wrote: >> >> On 06/07/10 09:26, Avi Kivity wrote: >> >> >>> The original motivation for moving the PIC and IOAPIC into the kernel >>> was performance, especially for assigned devices. Both devices are high >>> inter

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
On 06/07/2010 07:31 PM, David S. Ahern wrote: On 06/07/10 09:26, Avi Kivity wrote: The original motivation for moving the PIC and IOAPIC into the kernel was performance, especially for assigned devices. Both devices are high interaction since they deal with interrupts; practically after e

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
On 06/07/2010 08:04 PM, Anthony Liguori wrote: I think we could also move the local APIC. I'm not even sure we can safely move the ioapic/pic (mostly due to churn). But the local APIC is so heavily accessed by the guest that it's impossible to move it. Run an ftrace one day, especially on

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote: > > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > > With -netdev, there now seems to be little need to support vlans, > > > > enabling them leads to user confusion and bad performance. > > > > Disable support for vlans

[Qemu-devel] [PATCH v5] block: add sheepdog driver for distributed storage support

2010-06-07 Thread MORITA Kazutaka
Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special (no metadata node, no control node, etc) - Linear scal

[Qemu-devel] Re: FYI: Qemu support on s5pc110

2010-06-07 Thread Ben Dooks
On Sun, Jun 06, 2010 at 02:03:39PM +0900, Kyungmin Park wrote: > Dear all, > > FYI: My team release the qemu support on s5pc110 at > http://en.sourceforge.jp/projects/sfnet_slp-emulator/ Interesting, any plans on merginging it back into qemu? > You can find a s5pc110 files at hw directories. >

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 12:07:56PM -0500, Anthony Liguori wrote: > On 06/07/2010 11:44 AM, Daniel P. Berrange wrote: > >On Mon, Jun 07, 2010 at 10:13:27AM -0500, Anthony Liguori wrote: > > > >>On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >> > >>>Add a new QMP monitor command 'query-m

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 11:44 AM, Daniel P. Berrange wrote: On Mon, Jun 07, 2010 at 10:13:27AM -0500, Anthony Liguori wrote: On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Add a new QMP monitor command 'query-machines' to discover what machines are defined in the QEMU binary. This is an easi

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Anthony Liguori
On 06/07/2010 10:26 AM, Avi Kivity wrote: I am currently investigating a problem with the a guest running Linux malfunctioning in the NMI watchdog code. The problem is that we don't handle NMI delivery mode for the local APIC LINT0 pin; instead we expect ExtInt deliver mode or that the line is

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 10:13:27AM -0500, Anthony Liguori wrote: > On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >Add a new QMP monitor command 'query-machines' to discover what > >machines are defined in the QEMU binary. This is an easily > >parsable replacement for 'qemu -M ?' > > > > [

Re: [Qemu-devel] [PATCH v6 5/6] Inter-VM shared memory PCI device

2010-06-07 Thread Cam Macdonell
On Sat, Jun 5, 2010 at 3:44 AM, Blue Swirl wrote: > On Fri, Jun 4, 2010 at 9:45 PM, Cam Macdonell wrote: >> Support an inter-vm shared memory device that maps a shared-memory object as >> a >> PCI device in the guest.  This patch also supports interrupts between guest >> by >> communicating ove

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 11:42 AM, Paul Brook wrote: On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: With -netdev, there now seems to be little need to support vlans, enabling them leads to user confusion and bad performance. Disable support for vlans by default, add config option to enab

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread David S. Ahern
On 06/07/10 09:26, Avi Kivity wrote: > The original motivation for moving the PIC and IOAPIC into the kernel > was performance, especially for assigned devices. Both devices are high > interaction since they deal with interrupts; practically after every > interrupt there is either a PIC ioport

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Paul Brook
> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > With -netdev, there now seems to be little need to support vlans, > > > enabling them leads to user confusion and bad performance. > > > Disable support for vlans by default, add config option to enable. > > > > No. If you want to

Re: [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text

2010-06-07 Thread Anthony Liguori
On 05/31/2010 07:41 AM, Amit Shah wrote: Hello, This patch series adds support to specify some descriptive help text to qdev device parameters. This series adds some help text to the virtserialport and net family of devices as an example, and the new output is shown in the respective commits. T

Re: [Qemu-devel] [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: The QMP monitor provides a number of commands for querying info about the QEMU binary capabilities. Given that these commands don't take any options and just return static data, requiring the use of QMP is unnecessarily onerous. This adds a new '-

Re: [Qemu-devel] [PATCH 11/19] Add a query-devices command to QMP

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 10:14:00AM -0500, Anthony Liguori wrote: > On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >Adds a command to QMP called 'query-devices' to allow for discovery > >of all devices known to the QEMU binary. THis is inteded to replace > >use of the '-device ?' and '-device d

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > With -netdev, there now seems to be little need to support vlans, > > enabling them leads to user confusion and bad performance. > > Disable support for vlans by default, add config option to enable. > > No. If you want to remove vlan

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Paul Brook
> With -netdev, there now seems to be little need to support vlans, > enabling them leads to user confusion and bad performance. > Disable support for vlans by default, add config option to enable. No. If you want to remove vlans, then actually do that. As I've said before if you want a point-poin

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-07 Thread Paul Brook
> Kill nographic timer. Have a global gui_timer instead. Have the gui > timer enabled unconditionally. We need a timer running anyway for mmio > flush, so the whole have-gui-timer-only-when-needed logic is pretty > pointless. It also simplifies displaylisteners coming and going at > runtime, we

[Qemu-devel] Re: [PATCH 13/19] Add a query-target command to QMP

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: +#ifdef CONFIG_KVM +qlist_append_obj(engines, qobject_from_jsonf("{ 'name': 'kvm' }")); +#endif +#ifdef CONFIG_XEN +qlist_append_obj(engines, qobject_from_jsonf("{ 'name': 'xen' }")); +#endif I suggest using kvm_available() and xen_avail

[Qemu-devel] Re: [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 06:04:24PM +0200, Paolo Bonzini wrote: > On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: > >The QMP monitor provides a number of commands for querying info about > >the QEMU binary capabilities. Given that these commands don't take > >any options and just return static dat

[Qemu-devel] Re: [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: The QMP monitor provides a number of commands for querying info about the QEMU binary capabilities. Given that these commands don't take any options and just return static data, requiring the use of QMP is unnecessarily onerous. This adds a new '-

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
Hi Daniel, On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: As everyone here agrees, having management apps parse -help output to determine the QEMU capabilities is not at all nice, because it is an ill-defined& fragile data format. Looking more broadly these same issues apply to all the other

[Qemu-devel] Re: [PATCH] Fix --enable-user-pie compilation.

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 05:07 PM, Richard Henderson wrote: Ping^4 r~ On 05/21/2010 10:04 AM, Richard Henderson wrote: We forgot to propagate -fpie to the libdis-user directory. Signed-off-by: Richard Henderson --- configure |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/

[Qemu-devel] Re: [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
On 06/07/2010 11:02 AM, Paolo Bonzini wrote: On 06/07/2010 04:58 PM, Anthony Liguori wrote: A query-argv is a really bad idea IMHO. Agreed. Instead we should work towards improve the configurability of QEMU via monitor commands or -readconfig. libvirt is already using -nodefaults on recen

[Qemu-devel] Re: [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:58 PM, Anthony Liguori wrote: A query-argv is a really bad idea IMHO. Agreed. Instead we should work towards improve the configurability of QEMU via monitor commands or -readconfig. libvirt is already using -nodefaults on recent QEMU, so this is not _that_ far away. Paol

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Avi Kivity
On 06/07/2010 04:48 PM, Anthony Liguori wrote: Yes. I'd want separate queries for each, or perhaps a single query that returns { 'hostdev': some-object-with-host-device-properties-only, 'nic': some-object-that-describes-the-guest-nic } We need a query-netdev and then info qdm already provi

Re: [Qemu-devel] [PATCH] make qemu_thread_create block all signals

2010-06-07 Thread Richard Henderson
On 06/03/2010 06:20 AM, Paolo Bonzini wrote: > All signals will thus be routed through the IO thread. > > Signed-off-by: Paolo Bonzini > --- > cpus.c| 38 +++--- > qemu-thread.c |7 +++ > 2 files changed, 18 insertions(+), 27 deletions(-) Acked-

[Qemu-devel] [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
I am currently investigating a problem with the a guest running Linux malfunctioning in the NMI watchdog code. The problem is that we don't handle NMI delivery mode for the local APIC LINT0 pin; instead we expect ExtInt deliver mode or that the line is disabled completely. In addition the i82

Re: [Qemu-devel] [PATCH 07/19] Convert netdev client types to use an enumeration

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 10:09:02AM -0500, Anthony Liguori wrote: > On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >Declare an enumeration for all netdev client types, values > >matching indexes in the net_client_types array. Use the > >enum helpers for the string<-> int conversion of client t

Re: [Qemu-devel] [PATCH 07/19] Convert netdev client types to use an enumeration

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Declare an enumeration for all netdev client types, values matching indexes in the net_client_types array. Use the enum helpers for the string<-> int conversion of client types. Before: $ qemu -net type=foo,sfs qemu: -net type=foo,sfs: Pa

Re: [Qemu-devel] [PATCH] Fix --enable-user-pie compilation.

2010-06-07 Thread Richard Henderson
Ping^4 r~ On 05/21/2010 10:04 AM, Richard Henderson wrote: > We forgot to propagate -fpie to the libdis-user directory. > > Signed-off-by: Richard Henderson > --- > configure |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index 3cd2c5f

[Qemu-devel] Re: [PATCH 02/19] Add support for compile time assertions

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: The verify.h header, taken from GNULIB, provides macros for doing compile time assertions. There are two main variants For use in global namespace (eg header files, or global decls) verify(CONDITION) There is QEMU_BUILD_BUG_ON already. Pa

Re: [Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Markus Armbruster
Miguel Di Ciurcio Filho writes: > On Mon, Jun 7, 2010 at 10:48 AM, Anthony Liguori > wrote: $ qemu -netdev tap,id=tap0 -device e1000,netdev=tap0 This makes a 1:1 relation. So clearly tap0 is a host device, e1000.0 will be a guest device, and they are connected. >>> >>>

Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: This adds a new QMP command called query-netdev to provide information about the available netdev backends in the QEMU binary. There is no existing '-netdev ?' support, but if there was, this would obsolete it The data format looks like [

[Qemu-devel] [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Daniel P. Berrange
The QMP monitor provides a number of commands for querying info about the QEMU binary capabilities. Given that these commands don't take any options and just return static data, requiring the use of QMP is unnecessarily onerous. This adds a new '-capabilities' command line argument as a syntactic s

Re: [Qemu-devel] [PATCH 14/19] Add a query-argv command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Add a new QMP command called 'query-argv' to information about the command line arguments supported by the QEMU binary. This is intended to remove the need for apps to parse '-help' output. This is just as bad as parsing -help output IMHO.

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
On 06/07/2010 10:10 AM, Daniel P. Berrange wrote: On Mon, Jun 07, 2010 at 09:58:11AM -0500, Anthony Liguori wrote: On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: As everyone here agrees, having management apps parse -help output to determine the QEMU capabilities is not at all nice

[Qemu-devel] [PATCH 18/19] Add option to turn on JSON pretty printing in monitor

2010-06-07 Thread Daniel P. Berrange
Expaned '-mon' arg to allow a 'pretty=on' flag. This makes the monitor pretty print its replies to easy human debugging / reading Signed-off-by: Daniel P. Berrange --- monitor.c |5 - monitor.h |1 + qemu-config.c |3 +++ vl.c |3 +++ 4 files changed, 11 inse

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: As everyone here agrees, having management apps parse -help output to determine the QEMU capabilities is not at all nice, because it is an ill-defined& fragile data format. Looking more broadly these same issues apply to all the other command lin

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Add a new QMP monitor command 'query-machines' to discover what machines are defined in the QEMU binary. This is an easily parsable replacement for 'qemu -M ?' [ { "name": "pc-0.13", "description": "Standar

Re: [Qemu-devel] [PATCH 11/19] Add a query-devices command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Adds a command to QMP called 'query-devices' to allow for discovery of all devices known to the QEMU binary. THis is inteded to replace use of the '-device ?' and '-device devtype,?' command line args The data format is designed to allow easy ext

[Qemu-devel] [PATCH 15/19] Expand query-argv to include help string

2010-06-07 Thread Daniel P. Berrange
This expands the query-argv data format to include the help string for each argument. This is not really very desirable since the help strings are not in a predictable format for apps to use. Ideally the full structured details about each argument parameter would be included instead. This makes the

Re: [Qemu-devel] [PATCH 09/19] Change 'query-version' to output broken down version string

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: A previous discussion brought up the fact that clients should not have to parse version string from QMP, it should be given to them pre-split. Change query-version output format from: { "qemu": "0.11.50", "package": "" } to: { qemu: { "m

[Qemu-devel] [PATCH 06/19] Convert drive options to use enumeration data type

2010-06-07 Thread Daniel P. Berrange
This converts the drive options if, trans, media, cache, aio, rerror and werror to use the QEMU_OPT_ENUM datatype. This standardizes the string parsing and error reporting $ qemu -drive file=foo,werror=stop3 qemu: -drive file=foo,if=mtd,werror=stop3: Parameter 'werror' expects report, ignore

  1   2   >