[Qemu-devel] VxWorks kernel for qemu emulating PowerPC?

2010-06-07 Thread hadi motamedi
Dear All Can you please let me know if the qemu emulating PowerPC (I mean qemu-system-ppc.exe) can accept VxWork kernet for boot up? Thank you

Re: [Qemu-devel] [PATCH] Change 'query-version' to output broken down version string

2010-06-07 Thread Daniel P. Berrange
On Fri, Jun 04, 2010 at 03:34:48PM -0300, Luiz Capitulino wrote: > On Wed, 2 Jun 2010 13:40:06 +0100 > "Daniel P. Berrange" wrote: > > > A previous discussion brought up the fact that clients should > > not have to parse version string from QMP, it should be given > > to them pre-split. > > Ri

[Qemu-devel] [PATCHv2] virtio-net: truncating packet

2010-06-07 Thread Michael S. Tsirkin
virtio net attempts to peek into virtio queue to determine that we have enough space for the complete packet to fit. However, it fails to account for space consumed by virtio net header when it does this, under stress this results in a failure with the message 'truncating packet'. redhat bz 591494

Re: [Qemu-devel] VxWorks kernel for qemu emulating PowerPC?

2010-06-07 Thread Alexander Graf
On 07.06.2010, at 11:03, hadi motamedi wrote: > Dear All > Can you please let me know if the qemu emulating PowerPC (I mean > qemu-system-ppc.exe) can accept VxWork kernet for boot up? I doubt it. Patches are welcome. Alex

Re: [Qemu-devel] VxWorks kernel for qemu emulating PowerPC?

2010-06-07 Thread Alexander Graf
On 07.06.2010, at 11:33, hadi motamedi wrote: > I doubt it. Patches are welcome. > > > Thank you for your reply. Can you please let me know which qemu hardware > architecture does support for VxWorks kernel boot? Natalia keeps a list of verified to work OSs for exactly that purpose: http://w

[Qemu-devel] Re: [PATCH v4] savevm: Really verify if a drive supports snapshots

2010-06-07 Thread Kevin Wolf
Am 04.06.2010 21:35, schrieb Miguel Di Ciurcio Filho: > Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized. > > First issue: Their names implies different porpouses, but they do the same > thing > and have exactly the same code. Maybe copied and pasted and forgotten? > b

Re: [Qemu-devel] VxWorks kernel for qemu emulating PowerPC?

2010-06-07 Thread hadi motamedi
> > I doubt it. Patches are welcome. > > > Thank you for your reply. Can you please let me know which qemu hardware architecture does support for VxWorks kernel boot?

[Qemu-devel] [PATCH 1/3] cow: use pread/pwrite

2010-06-07 Thread Christoph Hellwig
Use pread/pwrite instead of lseek + read/write in preparation of using the qemu block API. Signed-off-by: Christoph Hellwig Index: qemu/block/cow.c === --- qemu.orig/block/cow.c 2010-05-04 19:11:24.897004616 +0200 +++ qemu/blo

[Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-06-07 Thread Christoph Hellwig
We don't have an equivalent to mmap in the qemu block API, so read and write the bitmap directly. At least in the dumb implementation added in this patch this is a lot less efficient, but it means cow can also work on windows, and over nbd or curl. And it fixes qemu-iotests testcase 012 which did

[Qemu-devel] [PATCH 3/3] cow: use qemu block API

2010-06-07 Thread Christoph Hellwig
Use bdrv_pwrite to access the backing device instead of pread, and convert the driver to implementing the bdrv_open method which gives it an already opened BlockDriverState for the underlying device. Signed-off-by: Christoph Hellwig Index: qemu/block/cow.c ===

Re: [Qemu-devel] VxWorks kernel for qemu emulating PowerPC?

2010-06-07 Thread hadi motamedi
> > Natalia keeps a list of verified to work OSs for exactly that purpose: > http://www.claunia.com/qemu/ > > > Thank you . From your list, it seems that qemu doesn't support for VxWorks on any architecture. Please confirm.

Re: [Qemu-devel] Re: [V9fs-developer] [PATCH] virtio-9p: getattr server implementation for 9P2000.L protocol.

2010-06-07 Thread Sripathi Kodi
On Sat, 05 Jun 2010 19:11:53 +0530 "Aneesh Kumar K. V" wrote: > On Fri, 04 Jun 2010 07:59:42 -0700, "Venkateswararao Jujjuri (JV)" > wrote: > > Aneesh Kumar K. V wrote: > > > On Thu, 3 Jun 2010 18:29:02 +0530, Sripathi Kodi > > > wrote: > > >> On Wed, 02 Jun 2010 19:49:24 +0530 > > >> "Aneesh

Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

2010-06-07 Thread Kevin Wolf
Am 02.06.2010 00:12, schrieb Eduardo Habkost: > Resubmitting a patch that was submitted in December[1]. It was on the staging > tree but somehow it got dropped. I have rebased it to current master branch on > git. > > [1] http://article.gmane.org/gmane.comp.emulators.qemu/59813 > > >

Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

2010-06-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 02.06.2010 00:12, schrieb Eduardo Habkost: >> Resubmitting a patch that was submitted in December[1]. It was on the staging >> tree but somehow it got dropped. I have rebased it to current master branch >> on >> git. >> >> [1] http://article.gmane.org/gmane.comp.emulat

Re: [Qemu-devel] [PATCH 3/3] cow: use qemu block API

2010-06-07 Thread Markus Armbruster
Christoph Hellwig writes: > Use bdrv_pwrite to access the backing device instead of pread, and > convert the driver to implementing the bdrv_open method which gives > it an already opened BlockDriverState for the underlying device. > > Signed-off-by: Christoph Hellwig In my (admittedly limited)

Re: [V9fs-developer] [Qemu-devel] Re: [PATCH] virtio-9p: getattr server implementation for 9P2000.L protocol.

2010-06-07 Thread Sripathi Kodi
On Mon, 7 Jun 2010 16:04:17 +0530 Sripathi Kodi wrote: There was one mistake in my patch. See below. > On Sat, 05 Jun 2010 19:11:53 +0530 > "Aneesh Kumar K. V" wrote: > > > On Fri, 04 Jun 2010 07:59:42 -0700, "Venkateswararao Jujjuri (JV)" > > wrote: > > > Aneesh Kumar K. V wrote: > > > > On

Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

2010-06-07 Thread Eduardo Habkost
On Mon, Jun 07, 2010 at 02:19:28PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > Am 02.06.2010 00:12, schrieb Eduardo Habkost: > >> The first eject command didn't work because the is_inserted() check > >> failed. > > > > But does it really make a difference? The guest should not see a m

Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

2010-06-07 Thread Kevin Wolf
Am 07.06.2010 14:43, schrieb Eduardo Habkost: > On Mon, Jun 07, 2010 at 02:19:28PM +0200, Markus Armbruster wrote: >> Kevin Wolf writes: >>> Am 02.06.2010 00:12, schrieb Eduardo Habkost: The first eject command didn't work because the is_inserted() check failed. >>> >>> But does it reall

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Sun, Jun 6, 2010 at 12:50 PM, Avi Kivity wrote: >> +Each json-object contain the following: >> + >> +- "device": device name (json-string) >> +- "vlan": only present if the device is attached to a VLAN (json-int) >> +- "info": json-object containing the following: >> +          - "model": type

Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted

2010-06-07 Thread Markus Armbruster
Kevin Wolf writes: > Am 07.06.2010 14:43, schrieb Eduardo Habkost: >> On Mon, Jun 07, 2010 at 02:19:28PM +0200, Markus Armbruster wrote: >>> Kevin Wolf writes: Am 02.06.2010 00:12, schrieb Eduardo Habkost: > The first eject command didn't work because the is_inserted() check > faile

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Avi Kivity
On 06/07/2010 03:57 PM, Miguel Di Ciurcio Filho wrote: On Sun, Jun 6, 2010 at 12:50 PM, Avi Kivity wrote: +Each json-object contain the following: + +- "device": device name (json-string) +- "vlan": only present if the device is attached to a VLAN (json-int) +- "info": json-object containin

[Qemu-devel] Re: [PATCH v2 2/2] vnc: threaded VNC server

2010-06-07 Thread Paolo Bonzini
On 06/06/2010 03:54 PM, Avi Kivity wrote: One option is to disable vnc on Windows and let a Windows maintainer materialize and add the corresponding support. Adding Windows support to qemu-threads must be done anyway sooner or later and most of the code can be found for example in git. Being

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Anthony Liguori
On 06/07/2010 08:39 AM, Avi Kivity wrote: On 06/07/2010 03:57 PM, Miguel Di Ciurcio Filho wrote: On Sun, Jun 6, 2010 at 12:50 PM, Avi Kivity wrote: +Each json-object contain the following: + +- "device": device name (json-string) +- "vlan": only present if the device is attached to a VLAN (jso

[Qemu-devel] [PATCHv3] virtio-net: truncating packet

2010-06-07 Thread Michael S. Tsirkin
virtio net attempts to peek into virtio queue to determine that we have enough space for the complete packet to fit. However, it fails to account for space consumed by virtio net header when it does this, under stress this results in a failure with the message 'truncating packet'. redhat bz 591494

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 10:48 AM, Anthony Liguori wrote: >>> >>> $ qemu -netdev tap,id=tap0 -device e1000,netdev=tap0 >>> >>> This makes a 1:1 relation. So clearly tap0 is a host device, e1000.0 >>> will be a guest device, and they are connected. >> >> Yes.  I'd want separate queries for each, or p

[Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Daniel P. Berrange
As everyone here agrees, having management apps parse -help output to determine the QEMU capabilities is not at all nice, because it is an ill-defined & fragile data format. Looking more broadly these same issues apply to all the other command line options that accept a '?' flag for querying capabi

[Qemu-devel] [PATCH 02/19] Add support for compile time assertions

2010-06-07 Thread Daniel P. Berrange
The verify.h header, taken from GNULIB, provides macros for doing compile time assertions. There are two main variants For use in global namespace (eg header files, or global decls) verify(CONDITION) For use in code blocks verify_true(CONDITION) Example usage, consider if there was an enu

[Qemu-devel] [PATCH 11/19] Add a query-devices command to QMP

2010-06-07 Thread Daniel P. Berrange
Adds a command to QMP called 'query-devices' to allow for discovery of all devices known to the QEMU binary. THis is inteded to replace use of the '-device ?' and '-device devtype,?' command line args The data format is designed to allow easy extension to support more data: [ {

[Qemu-devel] [PATCH 08/19] Convert RTC to use enumerations for configuration parameters

2010-06-07 Thread Daniel P. Berrange
Convert the rtc clock and driftfix parameters to use enums for configuration. This ensures strict validation at time of config parsing. Also fixes a bug in qemu-config.c where 'driftfix' was never enabled because this is a target independant compliation unit, thus cannot include config-target.h an

[Qemu-devel] [PATCH 03/19] Add enum handlers for easy & efficient string <-> int conversion

2010-06-07 Thread Daniel P. Berrange
There is quite alot of code using an enumeration of possible values, which also needs todo conversions to/from a string representation of enum values. These string <-> int conversions have been repeated in an adhoc manner throughout the code. This makes it hard to report on the list of valid strin

[Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-07 Thread Daniel P. Berrange
This adds a new QMP command called query-netdev to provide information about the available netdev backends in the QEMU binary. There is no existing '-netdev ?' support, but if there was, this would obsolete it The data format looks like [ { "name": "user", "pro

[Qemu-devel] [PATCH 01/19] Add support for JSON pretty printing

2010-06-07 Thread Daniel P. Berrange
The monitor does not pretty-print JSON output, so that everything will be on a single line reply. When JSON docs get large this is quite unpleasant to read. For the future command line capabilities query ability, huge JSON docs will be available. This needs the ability to pretty-print. This introd

[Qemu-devel] [PATCH 14/19] Add a query-argv command to QMP

2010-06-07 Thread Daniel P. Berrange
Add a new QMP command called 'query-argv' to information about the command line arguments supported by the QEMU binary. This is intended to remove the need for apps to parse '-help' output. [ { "name": "help", }, { "name": "M", "param

[Qemu-devel] [PATCH 04/19] Add support for a option parameter as an enum

2010-06-07 Thread Daniel P. Berrange
This adds a new option parameter QEMU_OPT_ENUM. The user provides the value in its string representation. The parser validates this and converts it to integer representation for internal use. If the user supplies an invalid value it will report the precise allowed list of values. Signed-off-by: Da

[Qemu-devel] [PATCH 05/19] Ensure that QEMU exits if drive_add parsing fails

2010-06-07 Thread Daniel P. Berrange
The drive_add() method returns NULL if it failed to parse the parameter values for any reason. All callers must check this and exit if failure occurred. Annotate the method so that the compiler validates this. Signed-off-by: Daniel P. Berrange --- vl.c | 38 ++--

[Qemu-devel] [PATCH] qcow2: Restore L1 entry on l2_allocate failure

2010-06-07 Thread Kevin Wolf
If writing the L1 table to disk failed, we need to restore its old content in memory to avoid inconsistencies. Reported-by: Juan Quintela Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qc

Re: [Qemu-devel] [PATCH 5/5] qdev: Add new '-device help' option, shows all devices and properties

2010-06-07 Thread Markus Armbruster
I like PATCH 1-3/5, but this one needs discussion. Amit Shah writes: > The new '-device help' option shows all the devices that are registered > with qdev and prints out all the properties each device has, along with > the description for each property. > > This is useful in creating automatic d

[Qemu-devel] [PATCH 12/19] Add a query-cputypes command to QMP

2010-06-07 Thread Daniel P. Berrange
This adds a new QMP command called 'query-cputypes' to allow for discovery of CPU types known to the QEMU binary. This is intended to relpace the need to parse '-cpu ?', '-cpu ?model' and '-cpu ?dump' Most targets have a simple structure listing just the CPU model names (and optionally a 'descript

[Qemu-devel] [PATCH 07/19] Convert netdev client types to use an enumeration

2010-06-07 Thread Daniel P. Berrange
Declare an enumeration for all netdev client types, values matching indexes in the net_client_types array. Use the enum helpers for the string <-> int conversion of client types. Before: $ qemu -net type=foo,sfs qemu: -net type=foo,sfs: Parameter 'type' expects a network client type After:

[Qemu-devel] [PATCH 09/19] Change 'query-version' to output broken down version string

2010-06-07 Thread Daniel P. Berrange
A previous discussion brought up the fact that clients should not have to parse version string from QMP, it should be given to them pre-split. Change query-version output format from: { "qemu": "0.11.50", "package": "" } to: { qemu: { "major": 0, "minor": 11, "micro": 5 }, "package": "" }

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:41 AM, Miguel Di Ciurcio Filho wrote: On Mon, Jun 7, 2010 at 10:48 AM, Anthony Liguori wrote: $ qemu -netdev tap,id=tap0 -device e1000,netdev=tap0 This makes a 1:1 relation. So clearly tap0 is a host device, e1000.0 will be a guest device, and they are connected.

[Qemu-devel] [PATCH 17/19] Add a query-config command to QMP

2010-06-07 Thread Daniel P. Berrange
Add a new command to QMP called 'query-config' that provides information about the allowed configuration file entries for the binary. The data format looks like [ { "name": "drive", "properties": [ { "name": "bus",

[Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Daniel P. Berrange
Add a new QMP monitor command 'query-machines' to discover what machines are defined in the QEMU binary. This is an easily parsable replacement for 'qemu -M ?' [ { "name": "pc-0.13", "description": "Standard PC", "default": 0 }, {

[Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
With -netdev, there now seems to be little need to support vlans, enabling them leads to user confusion and bad performance. Disable support for vlans by default, add config option to enable. Signed-off-by: Michael S. Tsirkin --- configure | 12 net.c |7 +++ 2 files c

[Qemu-devel] [PATCH 13/19] Add a query-target command to QMP

2010-06-07 Thread Daniel P. Berrange
Add a command to QMP to provide information about the QEMU binary target being emulated. This replaces the need to guess the architecture and wordsize based on the 'qemu-system-' suffix. It also declares what CPU execution engines are available in the binary (tcg, kvm, xen, etc) The data form

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 09:58:11AM -0500, Anthony Liguori wrote: > On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >As everyone here agrees, having management apps parse -help output > >to determine the QEMU capabilities is not at all nice, because it > >is an ill-defined& fragile data format.

[Qemu-devel] [PATCH 06/19] Convert drive options to use enumeration data type

2010-06-07 Thread Daniel P. Berrange
This converts the drive options if, trans, media, cache, aio, rerror and werror to use the QEMU_OPT_ENUM datatype. This standardizes the string parsing and error reporting $ qemu -drive file=foo,werror=stop3 qemu: -drive file=foo,if=mtd,werror=stop3: Parameter 'werror' expects report, ignore

Re: [Qemu-devel] [PATCH 09/19] Change 'query-version' to output broken down version string

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: A previous discussion brought up the fact that clients should not have to parse version string from QMP, it should be given to them pre-split. Change query-version output format from: { "qemu": "0.11.50", "package": "" } to: { qemu: { "m

[Qemu-devel] [PATCH 15/19] Expand query-argv to include help string

2010-06-07 Thread Daniel P. Berrange
This expands the query-argv data format to include the help string for each argument. This is not really very desirable since the help strings are not in a predictable format for apps to use. Ideally the full structured details about each argument parameter would be included instead. This makes the

Re: [Qemu-devel] [PATCH 11/19] Add a query-devices command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Adds a command to QMP called 'query-devices' to allow for discovery of all devices known to the QEMU binary. THis is inteded to replace use of the '-device ?' and '-device devtype,?' command line args The data format is designed to allow easy ext

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Add a new QMP monitor command 'query-machines' to discover what machines are defined in the QEMU binary. This is an easily parsable replacement for 'qemu -M ?' [ { "name": "pc-0.13", "description": "Standar

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: As everyone here agrees, having management apps parse -help output to determine the QEMU capabilities is not at all nice, because it is an ill-defined& fragile data format. Looking more broadly these same issues apply to all the other command lin

[Qemu-devel] [PATCH 18/19] Add option to turn on JSON pretty printing in monitor

2010-06-07 Thread Daniel P. Berrange
Expaned '-mon' arg to allow a 'pretty=on' flag. This makes the monitor pretty print its replies to easy human debugging / reading Signed-off-by: Daniel P. Berrange --- monitor.c |5 - monitor.h |1 + qemu-config.c |3 +++ vl.c |3 +++ 4 files changed, 11 inse

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
On 06/07/2010 10:10 AM, Daniel P. Berrange wrote: On Mon, Jun 07, 2010 at 09:58:11AM -0500, Anthony Liguori wrote: On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: As everyone here agrees, having management apps parse -help output to determine the QEMU capabilities is not at all nice

Re: [Qemu-devel] [PATCH 14/19] Add a query-argv command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Add a new QMP command called 'query-argv' to information about the command line arguments supported by the QEMU binary. This is intended to remove the need for apps to parse '-help' output. This is just as bad as parsing -help output IMHO.

[Qemu-devel] [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Daniel P. Berrange
The QMP monitor provides a number of commands for querying info about the QEMU binary capabilities. Given that these commands don't take any options and just return static data, requiring the use of QMP is unnecessarily onerous. This adds a new '-capabilities' command line argument as a syntactic s

Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: This adds a new QMP command called query-netdev to provide information about the available netdev backends in the QEMU binary. There is no existing '-netdev ?' support, but if there was, this would obsolete it The data format looks like [

Re: [Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Markus Armbruster
Miguel Di Ciurcio Filho writes: > On Mon, Jun 7, 2010 at 10:48 AM, Anthony Liguori > wrote: $ qemu -netdev tap,id=tap0 -device e1000,netdev=tap0 This makes a 1:1 relation. So clearly tap0 is a host device, e1000.0 will be a guest device, and they are connected. >>> >>>

[Qemu-devel] Re: [PATCH 02/19] Add support for compile time assertions

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: The verify.h header, taken from GNULIB, provides macros for doing compile time assertions. There are two main variants For use in global namespace (eg header files, or global decls) verify(CONDITION) There is QEMU_BUILD_BUG_ON already. Pa

Re: [Qemu-devel] [PATCH] Fix --enable-user-pie compilation.

2010-06-07 Thread Richard Henderson
Ping^4 r~ On 05/21/2010 10:04 AM, Richard Henderson wrote: > We forgot to propagate -fpie to the libdis-user directory. > > Signed-off-by: Richard Henderson > --- > configure |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index 3cd2c5f

Re: [Qemu-devel] [PATCH 07/19] Convert netdev client types to use an enumeration

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Declare an enumeration for all netdev client types, values matching indexes in the net_client_types array. Use the enum helpers for the string<-> int conversion of client types. Before: $ qemu -net type=foo,sfs qemu: -net type=foo,sfs: Pa

Re: [Qemu-devel] [PATCH 07/19] Convert netdev client types to use an enumeration

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 10:09:02AM -0500, Anthony Liguori wrote: > On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >Declare an enumeration for all netdev client types, values > >matching indexes in the net_client_types array. Use the > >enum helpers for the string<-> int conversion of client t

[Qemu-devel] [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
I am currently investigating a problem with the a guest running Linux malfunctioning in the NMI watchdog code. The problem is that we don't handle NMI delivery mode for the local APIC LINT0 pin; instead we expect ExtInt deliver mode or that the line is disabled completely. In addition the i82

Re: [Qemu-devel] [PATCH] make qemu_thread_create block all signals

2010-06-07 Thread Richard Henderson
On 06/03/2010 06:20 AM, Paolo Bonzini wrote: > All signals will thus be routed through the IO thread. > > Signed-off-by: Paolo Bonzini > --- > cpus.c| 38 +++--- > qemu-thread.c |7 +++ > 2 files changed, 18 insertions(+), 27 deletions(-) Acked-

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Avi Kivity
On 06/07/2010 04:48 PM, Anthony Liguori wrote: Yes. I'd want separate queries for each, or perhaps a single query that returns { 'hostdev': some-object-with-host-device-properties-only, 'nic': some-object-that-describes-the-guest-nic } We need a query-netdev and then info qdm already provi

[Qemu-devel] Re: [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:58 PM, Anthony Liguori wrote: A query-argv is a really bad idea IMHO. Agreed. Instead we should work towards improve the configurability of QEMU via monitor commands or -readconfig. libvirt is already using -nodefaults on recent QEMU, so this is not _that_ far away. Paol

[Qemu-devel] Re: [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
On 06/07/2010 11:02 AM, Paolo Bonzini wrote: On 06/07/2010 04:58 PM, Anthony Liguori wrote: A query-argv is a really bad idea IMHO. Agreed. Instead we should work towards improve the configurability of QEMU via monitor commands or -readconfig. libvirt is already using -nodefaults on recen

[Qemu-devel] Re: [PATCH] Fix --enable-user-pie compilation.

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 05:07 PM, Richard Henderson wrote: Ping^4 r~ On 05/21/2010 10:04 AM, Richard Henderson wrote: We forgot to propagate -fpie to the libdis-user directory. Signed-off-by: Richard Henderson --- configure |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-07 Thread Anthony Liguori
Hi Daniel, On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: As everyone here agrees, having management apps parse -help output to determine the QEMU capabilities is not at all nice, because it is an ill-defined& fragile data format. Looking more broadly these same issues apply to all the other

[Qemu-devel] Re: [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: The QMP monitor provides a number of commands for querying info about the QEMU binary capabilities. Given that these commands don't take any options and just return static data, requiring the use of QMP is unnecessarily onerous. This adds a new '-

[Qemu-devel] Re: [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 06:04:24PM +0200, Paolo Bonzini wrote: > On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: > >The QMP monitor provides a number of commands for querying info about > >the QEMU binary capabilities. Given that these commands don't take > >any options and just return static dat

[Qemu-devel] Re: [PATCH 13/19] Add a query-target command to QMP

2010-06-07 Thread Paolo Bonzini
On 06/07/2010 04:42 PM, Daniel P. Berrange wrote: +#ifdef CONFIG_KVM +qlist_append_obj(engines, qobject_from_jsonf("{ 'name': 'kvm' }")); +#endif +#ifdef CONFIG_XEN +qlist_append_obj(engines, qobject_from_jsonf("{ 'name': 'xen' }")); +#endif I suggest using kvm_available() and xen_avail

Re: [Qemu-devel] [PATCH] Fix and simplify gui timer logic.

2010-06-07 Thread Paul Brook
> Kill nographic timer. Have a global gui_timer instead. Have the gui > timer enabled unconditionally. We need a timer running anyway for mmio > flush, so the whole have-gui-timer-only-when-needed logic is pretty > pointless. It also simplifies displaylisteners coming and going at > runtime, we

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Paul Brook
> With -netdev, there now seems to be little need to support vlans, > enabling them leads to user confusion and bad performance. > Disable support for vlans by default, add config option to enable. No. If you want to remove vlans, then actually do that. As I've said before if you want a point-poin

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > With -netdev, there now seems to be little need to support vlans, > > enabling them leads to user confusion and bad performance. > > Disable support for vlans by default, add config option to enable. > > No. If you want to remove vlan

Re: [Qemu-devel] [PATCH 11/19] Add a query-devices command to QMP

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 10:14:00AM -0500, Anthony Liguori wrote: > On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >Adds a command to QMP called 'query-devices' to allow for discovery > >of all devices known to the QEMU binary. THis is inteded to replace > >use of the '-device ?' and '-device d

Re: [Qemu-devel] [PATCH 19/19] Add a -capabilities argument to allow easy query for static QEMU info

2010-06-07 Thread Anthony Liguori
On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: The QMP monitor provides a number of commands for querying info about the QEMU binary capabilities. Given that these commands don't take any options and just return static data, requiring the use of QMP is unnecessarily onerous. This adds a new '-

Re: [Qemu-devel] [PATCH 0/5] Add '-device help' output for device params and help text

2010-06-07 Thread Anthony Liguori
On 05/31/2010 07:41 AM, Amit Shah wrote: Hello, This patch series adds support to specify some descriptive help text to qdev device parameters. This series adds some help text to the virtserialport and net family of devices as an example, and the new output is shown in the respective commits. T

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Paul Brook
> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > With -netdev, there now seems to be little need to support vlans, > > > enabling them leads to user confusion and bad performance. > > > Disable support for vlans by default, add config option to enable. > > > > No. If you want to

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread David S. Ahern
On 06/07/10 09:26, Avi Kivity wrote: > The original motivation for moving the PIC and IOAPIC into the kernel > was performance, especially for assigned devices. Both devices are high > interaction since they deal with interrupts; practically after every > interrupt there is either a PIC ioport

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 11:42 AM, Paul Brook wrote: On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: With -netdev, there now seems to be little need to support vlans, enabling them leads to user confusion and bad performance. Disable support for vlans by default, add config option to enab

Re: [Qemu-devel] [PATCH v6 5/6] Inter-VM shared memory PCI device

2010-06-07 Thread Cam Macdonell
On Sat, Jun 5, 2010 at 3:44 AM, Blue Swirl wrote: > On Fri, Jun 4, 2010 at 9:45 PM, Cam Macdonell wrote: >> Support an inter-vm shared memory device that maps a shared-memory object as >> a >> PCI device in the guest.  This patch also supports interrupts between guest >> by >> communicating ove

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 10:13:27AM -0500, Anthony Liguori wrote: > On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >Add a new QMP monitor command 'query-machines' to discover what > >machines are defined in the QEMU binary. This is an easily > >parsable replacement for 'qemu -M ?' > > > > [

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Anthony Liguori
On 06/07/2010 10:26 AM, Avi Kivity wrote: I am currently investigating a problem with the a guest running Linux malfunctioning in the NMI watchdog code. The problem is that we don't handle NMI delivery mode for the local APIC LINT0 pin; instead we expect ExtInt deliver mode or that the line is

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Anthony Liguori
On 06/07/2010 11:44 AM, Daniel P. Berrange wrote: On Mon, Jun 07, 2010 at 10:13:27AM -0500, Anthony Liguori wrote: On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Add a new QMP monitor command 'query-machines' to discover what machines are defined in the QEMU binary. This is an easi

Re: [Qemu-devel] [PATCH 10/19] Add a query-machines command to QMP

2010-06-07 Thread Daniel P. Berrange
On Mon, Jun 07, 2010 at 12:07:56PM -0500, Anthony Liguori wrote: > On 06/07/2010 11:44 AM, Daniel P. Berrange wrote: > >On Mon, Jun 07, 2010 at 10:13:27AM -0500, Anthony Liguori wrote: > > > >>On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: > >> > >>>Add a new QMP monitor command 'query-m

[Qemu-devel] Re: FYI: Qemu support on s5pc110

2010-06-07 Thread Ben Dooks
On Sun, Jun 06, 2010 at 02:03:39PM +0900, Kyungmin Park wrote: > Dear all, > > FYI: My team release the qemu support on s5pc110 at > http://en.sourceforge.jp/projects/sfnet_slp-emulator/ Interesting, any plans on merginging it back into qemu? > You can find a s5pc110 files at hw directories. >

[Qemu-devel] [PATCH v5] block: add sheepdog driver for distributed storage support

2010-06-07 Thread MORITA Kazutaka
Sheepdog is a distributed storage system for QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. This patch adds a qemu block driver for Sheepdog. Sheepdog features are: - No node in the cluster is special (no metadata node, no control node, etc) - Linear scal

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote: > > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > > With -netdev, there now seems to be little need to support vlans, > > > > enabling them leads to user confusion and bad performance. > > > > Disable support for vlans

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
On 06/07/2010 08:04 PM, Anthony Liguori wrote: I think we could also move the local APIC. I'm not even sure we can safely move the ioapic/pic (mostly due to churn). But the local APIC is so heavily accessed by the guest that it's impossible to move it. Run an ftrace one day, especially on

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
On 06/07/2010 07:31 PM, David S. Ahern wrote: On 06/07/10 09:26, Avi Kivity wrote: The original motivation for moving the PIC and IOAPIC into the kernel was performance, especially for assigned devices. Both devices are high interaction since they deal with interrupts; practically after e

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread David S. Ahern
On 06/07/10 12:46, Avi Kivity wrote: > On 06/07/2010 07:31 PM, David S. Ahern wrote: >> >> On 06/07/10 09:26, Avi Kivity wrote: >> >> >>> The original motivation for moving the PIC and IOAPIC into the kernel >>> was performance, especially for assigned devices. Both devices are high >>> inter

[Qemu-devel] Build problem on Mac OS 10.6.3

2010-06-07 Thread Programmingkid
I would just like to know if anyone else has seen this build problem with Qemu when building on Mac OS 10.6.3: Makefile:7: config-devices.mak: No such file or directory make[1]: *** No rule to make target `config-devices.mak'. Stop. make: *** [subdir-x86-softmmu] Error 2 I am using the most re

Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 11:42 AM, Daniel P. Berrange wrote: > This adds a new QMP command called query-netdev to provide information > about the available netdev backends in the QEMU binary. There is no > existing '-netdev ?' support, but if there was, this would obsolete it > Hi Daniel, Could we

[Qemu-devel] Re: [RFC] Moving the kvm ioapic, pic, and pit back to userspace

2010-06-07 Thread Avi Kivity
On 06/07/2010 09:54 PM, David S. Ahern wrote: So it's important to know how often your RHEL3/4 guest queries the PIT (not just receives interrupts, actually reads the counter) under a realistic load. If you have such a number (in reads/sec) that would be a good input to this discussion.

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 11:52:05AM -0500, Anthony Liguori wrote: > On 06/07/2010 11:42 AM, Paul Brook wrote: >>> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: >>> > With -netdev, there now seems to be little need to support vlans, > enabling them leads to user confusion

[Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 11:48 AM, Anthony Liguori wrote: >> >> How about this small draft: >> >> Possible values for "type": tap, user, vde and socket. The 'info' >> object contains all the parameters available via -netdev type,args. >> >> Notice: vlan is still there, unless the support for it is r

Re: [Qemu-devel] [PATCH 2/2] tcg-i386: Use segment registers to implement GUEST_BASE.

2010-06-07 Thread Richard Henderson
On 06/03/2010 11:35 PM, Alexander Graf wrote: > > On 04.06.2010, at 02:35, Richard Henderson wrote: > >> For 32-bit, using a segment override is smaller than the 4-byte >> immediate offset. For 64-bit, segments can hold the entire 64-bit >> offset whereas the 4-byte immediate cannot. > > Very

Re: [Qemu-devel] Re: [RFC] QMP: Introduce query-netdevices documentation

2010-06-07 Thread Miguel Di Ciurcio Filho
On Mon, Jun 7, 2010 at 12:01 PM, Markus Armbruster wrote: >>          { >>             "device": "user.0", >>             "type": "user", >>             "info": { >>                "net": "10.0.2.0", >>                "netmask": "255.255.255.0" >>             }, >>          }, > > And this one's n

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. The problem with disabling vlans unconditionally is that you break -net socket and -net dump. If we can come up with an alternative way

  1   2   >