Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-07-30 Thread malc
On Thu, 29 Jul 2010, Hollis Blanchard wrote: The kernel's BSS size is lost by mkimage, which only considers file size. As a result, loading other blobs (e.g. device tree, initrd) immediately after the kernel location can result in them being zeroed by the kernel's BSS initialization code.

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-30 Thread Kevin Wolf
Am 27.07.2010 21:04, schrieb Andrea Arcangeli: Subject: avoid canceling ide dma From: Andrea Arcangeli aarca...@redhat.com The reason for not actually canceling the I/O is because with virtualization and lots of VM running, a guest fs may mistake a overload of the host, as an IDE timeout.

Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Markus Armbruster
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes: This patch address two issues. 1) When savevm is run using an previously saved snapshot id or name, it will delete the original and create a new one, using the same id and name and not prompting the user of what just happened. This

Re: [Qemu-devel] [PATCH 1/3] cleanup: bdrv_snaphost_find() returns zero or -ENOENT

2010-07-30 Thread Markus Armbruster
Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes: The bdrv_snaphost_find() returns zero in case it finds an snapshot or -ENOENT in case it doesn't. Checking returning values as = zero doesn't make sense. Debatable. RETVAL 0 is an idiomatic check for error. RETVAL = 0 is merely its

Re: [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-07-30 Thread Markus Armbruster
Why? I figure the next patch wants it, but if that's the reason, the commit message should state it.

[Qemu-devel] [PATCH 0/8] RFC: qbus reset callback and implement pci bus reset

2010-07-30 Thread Isaku Yamahata
This patch isn't for 0.13 release. and for MST pci branch. (git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git pci) Patch description: Introduce bus reset notion at qbus layer and implement pci bus reset with it. At first related codes are cleaned up and then introduce bus reset callback.

[Qemu-devel] [PATCH 3/8] pci: export pci_bus_reset() and pci_device_reset() for later use.

2010-07-30 Thread Isaku Yamahata
export pci_bus_reset() and pci_device_reset() for later use with slight function signature adjustment. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 17 + hw/pci.h |4 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/pci.c

[Qemu-devel] [PATCH 7/8] pci: eliminate work around in pci_device_reset().

2010-07-30 Thread Isaku Yamahata
Eliminate work around in pci_device_reset() by making each pci reset function to call pci_device_reset_default(). Each device should know reset itself. It shouldn't be done pci generic layer automatically. PCI layer should just signal reset and let each device respond to reset. Signed-off-by:

[Qemu-devel] [PATCH 1/8] apb: fix typo.

2010-07-30 Thread Isaku Yamahata
fix typo. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/apb_pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/apb_pci.c b/hw/apb_pci.c index 10a5baa..c619112 100644 --- a/hw/apb_pci.c +++ b/hw/apb_pci.c @@ -362,7 +362,7 @@ PCIBus

[Qemu-devel] [PATCH 2/8] qdev: export qdev_reset() for later use.

2010-07-30 Thread Isaku Yamahata
export qdev_reset() for later use. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/qdev.c | 29 + hw/qdev.h |1 + 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index e99c73f..322b315 100644 --- a/hw/qdev.c +++

[Qemu-devel] [PATCH 5/8] qdev: introduce bus reset callback and helper functions.

2010-07-30 Thread Isaku Yamahata
Introduce bus reset callback to support bus reset at qbus layer and a function to trigger bus reset. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/qdev.c | 39 +-- hw/qdev.h |7 +++ 2 files changed, 44 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 4/8] pci: make pci_device_reset() aware of qdev.

2010-07-30 Thread Isaku Yamahata
Make pci_device_reset handle qdevfied device and non-converted device differently. Later they will be handled differently. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 35 +-- hw/pci.h |1 + 2 files changed, 34 insertions(+), 2

[Qemu-devel] [Bug 611640] [NEW] snapshot mode is broken for raw images

2010-07-30 Thread Victor Shkamerda
Public bug reported: The snapshot mode is not working if you use raw format for image instead of qcow2. Create a raw disk image by running dd of=xxx.img bs=1 count=0 seek=8G. Then run qemu -snapshot xxx.img. In monitor console run info block. There should be qcow2 temporary image backed by the

[Qemu-devel] [Bug 611646] [NEW] isa bus not working

2010-07-30 Thread Victor Shkamerda
Public bug reported: isa bus emulation not working anymore. Try running qemu -M isapc. It will crash with segmentation fault. This is a qemu HEAD from git on Fedora linux. ** Affects: qemu Importance: Undecided Status: New -- isa bus not working

Re: [Qemu-devel] Latest git version failed to run 403.gcc benchmark in SPEC CPU2006

2010-07-30 Thread amateur
On Thu. 2010-07-29 22:20:28 +0200, Artyom Tarasenko wrote: 2010/7/29 amateur tianlei.z...@gmail.com: Hi, All I'm trying to run benchmarks from SPEC CPU2006 compiled for SPARC on top of qemu-sparc32plus. However, several benchmarks failed to get the correct result. Can you try to

Re: [Qemu-devel] [PATCH] linux-user: Protect against allocation failure in load_symbols.

2010-07-30 Thread Jay Foad
+/* Attempt to free the storage associated with the local symbols + that we threw away. Whether or not this has any effect on the + memory allocation depends on the malloc implementation and how + many symbols we managed to discard. */ syms = realloc(syms, nsyms *

[Qemu-devel] [Bug 571432] Re: qemu-system-arm crashed with SIGSEGV in subpage_register()

2010-07-30 Thread cmchao
The base address is a little strange By your StackTrace.log, the base address, passed into smc91c111_init, is 0x40CC28C0. But this address should be 0x1001000, hard-coded in source code. -- qemu-system-arm crashed with SIGSEGV in subpage_register() https://bugs.launchpad.net/bugs/571432 You

[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Luiz Capitulino
On Wed, 28 Jul 2010 16:30:24 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: This patch address two issues. Then it should be split in two. 1) When savevm is run using an previously saved snapshot id or name, it will delete the original and create a new one, using the same id

Re: [Qemu-devel] [PATCH 1/3] cleanup: bdrv_snaphost_find() returns zero or -ENOENT

2010-07-30 Thread Luiz Capitulino
On Fri, 30 Jul 2010 11:44:26 +0200 Markus Armbruster arm...@redhat.com wrote: Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes: The bdrv_snaphost_find() returns zero in case it finds an snapshot or -ENOENT in case it doesn't. Checking returning values as = zero doesn't make

Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Luiz Capitulino
On Fri, 30 Jul 2010 11:34:57 +0200 Markus Armbruster arm...@redhat.com wrote: Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes: This patch address two issues. 1) When savevm is run using an previously saved snapshot id or name, it will delete the original and create a new one,

Re: [Qemu-devel] [PATCH] linux-user: Protect against allocation failure in load_symbols.

2010-07-30 Thread malc
On Fri, 30 Jul 2010, Jay Foad wrote: +/* Attempt to free the storage associated with the local symbols + that we threw away. Whether or not this has any effect on the + memory allocation depends on the malloc implementation and how + many symbols we managed to

[Qemu-devel] Re: sparc scsi/iommu/dma (was NMI handling)

2010-07-30 Thread Blue Swirl
On Tue, Jul 27, 2010 at 8:10 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/7/27 Blue Swirl blauwir...@gmail.com: On Mon, Jul 26, 2010 at 10:23 PM, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/7/26 Blue Swirl blauwir...@gmail.com: On Mon, Jul 26, 2010 at 4:53 PM, Artyom

Re: [Qemu-devel] Latest git version failed to run 403.gcc benchmark in SPEC CPU2006

2010-07-30 Thread Vince Weaver
Hello have you tried older versions of qemu, in an attempt to see if this is a recent problem? As of about a year ago I had qemu-sparc32plus running most of SPEC2006 properly, validated against hardware perf counters. gcc definitely worked. I had issues with calculix, dealII, soplex, wrf,

Re: [Qemu-devel] [PATCH] Use --strip-program to accommodate cross-compilers

2010-07-30 Thread Blue Swirl
On Fri, Jul 30, 2010 at 1:45 AM, Hollis Blanchard hol...@penguinppc.org wrote: From: Hollis Blanchard hollis_blanch...@mentor.com Fixes this error during make install: ... install -m0755 -p -s qemu-nbd qemu-img qemu-io /opt/ppc440-angstrom-linux/usr/local/bin strip: Unable to recognise the

Re: [Qemu-devel] Latest git version failed to run 403.gcc benchmark in SPEC CPU2006

2010-07-30 Thread Blue Swirl
On Thu, Jul 29, 2010 at 3:40 PM, amateur tianlei.z...@gmail.com wrote: Hi, All I'm trying to run benchmarks from SPEC CPU2006 compiled for SPARC on top of qemu-sparc32plus. However, several benchmarks failed to get the correct result. One of the failed benchmarks, 403.gcc, runs for a while

[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino lcapitul...@redhat.com wrote: TODO: I have no clue on how to create a timestamp string when using Windows. So, what happens on windows? I've found some code in bdrv_snapshot_dump() that formats a timestamp when using Windows. I will use it as

Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 30 Jul 2010 11:34:57 +0200 Markus Armbruster arm...@redhat.com wrote: Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes: This patch address two issues. 1) When savevm is run using an previously saved snapshot id or name, it

Re: [Qemu-devel] [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Luiz Capitulino
On Fri, 30 Jul 2010 16:43:09 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 30 Jul 2010 11:34:57 +0200 Markus Armbruster arm...@redhat.com wrote: Miguel Di Ciurcio Filho miguel.fi...@gmail.com writes: This patch address two

[Qemu-devel] Re: [PATCH 3/3] savevm: prevent snapshot overwriting and generate a default name

2010-07-30 Thread Luiz Capitulino
On Fri, 30 Jul 2010 11:42:44 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: On Fri, Jul 30, 2010 at 10:39 AM, Luiz Capitulino lcapitul...@redhat.com wrote: TODO: I have no clue on how to create a timestamp string when using Windows. So, what happens on windows? I've

Re: [Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-07-30 Thread Kevin O'Connor
On Sun, Jul 25, 2010 at 08:15:24PM -, CurtisNelson wrote: My next step at this point was to install hexedit and compare the two resulting images. Specifically, the mbr at the beginning of the disk and the ntfs partition starting at sector 63. On the net there is some talk about changing

[Qemu-devel] [PATCH] Rearrange block headers

2010-07-30 Thread Blue Swirl
Changing block.h or blockdev.h resulted in recompiling most objects. Move DriveInfo typedef and BlockInterfaceType enum definitions to qemu-common.h and rearrange blockdev.h use to decrease churn. Signed-off-by: Blue Swirl blauwir...@gmail.com --- blockdev.h| 10 ++

Re: [Qemu-devel] [RFC PATCH 12/14] KVM-test: Add a subtest of netperf

2010-07-30 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:36 +0800, Amos Kong wrote: Add network load by netperf, server is launched on guest, execute netperf client with different protocols on host. if all clients execute successfully, case will be pass. Test result will be record into result.txt. Now this case only tests

[Qemu-devel] enabling X86_FEATURE_ARCH_PERFMON in guest

2010-07-30 Thread David S. Ahern
How do I get X86_FEATURE_ARCH_PERFMON enabled for a guest? I've tried -cpu host,+perfmon and -cpu host,+arch_perfmon, but both get rejected with an error: CPU feature perfmon not found Host processor: model name : Intel(R) Xeon(R) CPU E5540 @ 2.53GHz stepping: 5 ...

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-07-30 Thread James Pulver
I'm getting the same error with restoring an Acronis based image to KVM on Scientific Linux 5.4. The image is known good, and I just tested to physical hardware and it boots fine. I hope this can be fixed... How are people hex editing the disk? -- Windows XP/2003 doesn't boot

Re: [Qemu-devel] [PATCH 2/3] cleanup: del_existing_snapshots() must return the upstream error code

2010-07-30 Thread Miguel Di Ciurcio Filho
On Fri, Jul 30, 2010 at 6:45 AM, Markus Armbruster arm...@redhat.com wrote: Why? I figure the next patch wants it, but if that's the reason, the commit message should state it. To better identify what happened and where, IMHO.

Re: [Qemu-devel] [PATCH] savevm: Fix memory leak of compat struct

2010-07-30 Thread Aurelien Jarno
On Wed, Jul 21, 2010 at 08:35:31AM -0600, Alex Williamson wrote: Forgot to check for and free these. Found-by: Zachary Amsden zams...@redhat.com Signed-off-by: Alex Williamson alex.william...@redhat.com --- 0.13 Candidate savevm.c |6 ++ 1 files changed, 6 insertions(+), 0

Re: [Qemu-devel] [PATCH 0/3] Fix broken if statements

2010-07-30 Thread Aurelien Jarno
On Wed, Jul 21, 2010 at 03:05:14PM -0500, Joel Schopp wrote: I have decided to apply the broken window theory of crime http://en.wikipedia.org/wiki/Broken_windows_theory to code, and more specifically to qemu. I'm hoping that fixing seemingly trivial bugs will actually fix some more serious

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-30 Thread Aurelien Jarno
On Fri, Jul 23, 2010 at 05:56:38PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup at init time, it is not possible to load an option ROM for a hotplug device when running in compat

Re: [Qemu-devel] [PATCH] migration: Accept 'cont' only after successful incoming migration

2010-07-30 Thread Aurelien Jarno
On Tue, Jul 27, 2010 at 03:49:19PM +0530, Amit Shah wrote: When a 'cont' is issued on a VM that's just waiting for an incoming migration, the VM reboots and boots into the guest, possibly corrupting its storage since it could be shared with another VM running elsewhere. Ensure that a VM

Re: [Qemu-devel] [PATCH] mips64el: fulong: PCI_DEVFN() clean up.

2010-07-30 Thread Aurelien Jarno
On Tue, Jul 27, 2010 at 03:24:47PM +0900, Isaku Yamahata wrote: Use PCI_DEVFN() where appropriate. The resulted stripped binary remains same with/without thie patch. Cc: Huacai Chen zltjiang...@gmail.com Cc: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Isaku Yamahata

Re: [Qemu-devel] [PATCH 1/1] Remove unused eventfd.h

2010-07-30 Thread Aurelien Jarno
On Thu, Jul 29, 2010 at 07:50:14AM +0900, Mike McCormack wrote: This header is not present on my system and causes a build failure, but is also not used in these files, so remove it. Signed-off-by: Mike McCormack mi...@ring3k.org --- hw/vhost.c |1 - hw/vhost_net.c |1 - 2

Re: [Qemu-devel] [PATCH] Ignore writes of perf reg (cp15 with crm == 12)

2010-07-30 Thread Aurelien Jarno
On Wed, Jul 28, 2010 at 04:23:05PM +0200, Loïc Minier wrote: I found out Matt Waddel has written a better looking patch, but I didn't test it; reviews welcome -- attached -- Loïc Minier Return-Path: loic.minier+caf_=lool=dooz@linaro.org X-Spam-Checker-Version: SpamAssassin 3.1.4

Re: [Qemu-devel] [PATCH for master 0/3] pci, pcihost: pci host bus clean up

2010-07-30 Thread Aurelien Jarno
On Tue, Jul 27, 2010 at 03:23:21PM +0900, Isaku Yamahata wrote: Changes for pci branch - master tree: - rebased to master branch. - dropped bonito clean up.(will send it separately) - introduced pci: move out pci internal structures which is already commited to pci branch. but not into

Re: [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage

2010-07-30 Thread Edgar E. Iglesias
On Thu, Jul 29, 2010 at 06:48:24PM -0700, Hollis Blanchard wrote: The kernel's BSS size is lost by mkimage, which only considers file size. As a result, loading other blobs (e.g. device tree, initrd) immediately after the kernel location can result in them being zeroed by the kernel's BSS

Re: [Qemu-devel] Latest git version failed to run 403.gcc benchmark in SPEC CPU2006

2010-07-30 Thread amateur
On Fri. 2010-07-30 14:21:42 +, Blue Swirl wrote: On Thu, Jul 29, 2010 at 3:40 PM, amateur tianlei.z...@gmail.com wrote: Hi, All There's '-d in_asm,op,out_asm' but it may not help much. Since the program runs a while before fail, that counts a lot of instructions(hundreds of millions).