Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-02 Thread Michael S. Tsirkin
On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: +static inline void pci_memory_read(PCIDevice *dev, + pcibus_t addr, + uint8_t *buf, + pcibus_t len) +{ + pci_memory_rw(dev, addr, buf, len, 0); +} + +static inline void pci_memory_write(PCIDevice *dev, + pcibus_t addr, +

Re: [Qemu-devel] snapshots in qemu

2010-09-02 Thread Stefan Hajnoczi
On Thu, Sep 2, 2010 at 5:49 AM, chandra shekar chandrashekar...@gmail.com wrote: hello every one can any one tell which part of code or file in qemu deals with snapshots any help or suggestions,thanks There are two features called snapshot in QEMU: 1. The -snapshot mode creates a temporary

[Qemu-devel] Re: [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-02 Thread Eduard - Gabriel Munteanu
On Thu, Sep 02, 2010 at 08:28:26AM +0300, Michael S. Tsirkin wrote: On Sat, Aug 28, 2010 at 05:54:53PM +0300, Eduard - Gabriel Munteanu wrote: PCI devices should access memory through pci_memory_*() instead of cpu_physical_memory_*(). This also provides support for translation and access

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-02 Thread Eduard - Gabriel Munteanu
On Thu, Sep 02, 2010 at 09:00:46AM +0300, Michael S. Tsirkin wrote: On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: +static inline void pci_memory_read(PCIDevice *dev, + pcibus_t addr, + uint8_t *buf, + pcibus_t len) +{ + pci_memory_rw(dev, addr, buf, len, 0); +} +

[Qemu-devel] [PATCH 6/6] pci bridge: implement secondary bus reset.

2010-09-02 Thread Isaku Yamahata
implement secondary bus reset. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e23ac1b..183f595 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1626,6 +1626,9 @@ static void

[Qemu-devel] [PATCH 4/6] pci: make pci reset use qdev reset frame work.

2010-09-02 Thread Isaku Yamahata
make pci reset use qdev reset frame work. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c | 38 ++ hw/pci.h |2 ++ 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 655fead..4c99390 100644 ---

[Qemu-devel] [PATCH 5/6] pci: teach pci devices that have reset callback how to reset common registers.

2010-09-02 Thread Isaku Yamahata
teach pci devices that have reset callback how to reset common registers. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/e1000.c |1 + hw/lsi53c895a.c |2 ++ hw/pci.c|6 -- hw/pcnet.c |1 + hw/rtl8139.c|2 ++ hw/virtio-pci.c |1 + 6

[Qemu-devel] [PATCH 1/6] qdev: Make qbus_walk_children() call busfn for root bus.

2010-09-02 Thread Isaku Yamahata
Make qbus_walk_children() call busfn for root bus. and it fixes qbus_realize_all(). The current qbus_walk_children() doesn't call busfn for root bus. It cause qbus_relialize_all() to fail to call realize the system bus. This patch also refactor qbus_walk_children() a bit. Another only user of

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

2010-09-02 Thread Eduard - Gabriel Munteanu
On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: On Sat, Aug 28, 2010 at 05:54:55PM +0300, Eduard - Gabriel Munteanu wrote: Emulated PCI IDE controllers now use the memory access interface. This also allows an emulated IOMMU to translate and check accesses. Map

[Qemu-devel] [Bug 568445] Re: LVM backed drives should default to cache='none'

2010-09-02 Thread Alex Muntada
** Bug watch added: Red Hat Bugzilla #623188 https://bugzilla.redhat.com/show_bug.cgi?id=623188 ** Also affects: virt-manager via https://bugzilla.redhat.com/show_bug.cgi?id=623188 Importance: Unknown Status: Unknown -- LVM backed drives should default to cache='none'

[Qemu-devel] Re: [PATCH] qemu-io: Make alloc output useful when nb_sectors=1

2010-09-02 Thread Kevin Wolf
Am 02.09.2010 11:38, schrieb Stefan Hajnoczi: There is no indication whether or not the sector is allocated when nb_sectors=1: sector allocated at offset 64 KiB This message is produced whether or not the sector is allocated. Simply use the same message as the plural case, I don't

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

2010-09-02 Thread Michael S. Tsirkin
On Thu, Sep 02, 2010 at 12:12:00PM +0300, Eduard - Gabriel Munteanu wrote: On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: On Sat, Aug 28, 2010 at 05:54:55PM +0300, Eduard - Gabriel Munteanu wrote: Emulated PCI IDE controllers now use the memory access interface. This

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

2010-09-02 Thread Eduard - Gabriel Munteanu
On Thu, Sep 02, 2010 at 12:58:13PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 02, 2010 at 12:12:00PM +0300, Eduard - Gabriel Munteanu wrote: On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: On Sat, Aug 28, 2010 at 05:54:55PM +0300, Eduard - Gabriel Munteanu wrote: I

[Qemu-devel] [PATCH v2 4/4] virtio-net: Introduce a new bottom half packet TX

2010-09-02 Thread Alex Williamson
Based on a patch from Mark McLoughlin, this patch introduces a new bottom half packet transmitter that avoids the latency imposed by the tx_timer approach. Rather than scheduling a timer when a TX packet comes in, schedule a bottom half to be run from the iothread. The bottom half handler first

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

2010-09-02 Thread Michael S. Tsirkin
On Thu, Sep 02, 2010 at 06:01:35PM +0300, Eduard - Gabriel Munteanu wrote: On Thu, Sep 02, 2010 at 12:58:13PM +0300, Michael S. Tsirkin wrote: On Thu, Sep 02, 2010 at 12:12:00PM +0300, Eduard - Gabriel Munteanu wrote: On Thu, Sep 02, 2010 at 08:19:11AM +0300, Michael S. Tsirkin wrote: On

[Qemu-devel] Re: [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx

2010-09-02 Thread Michael S. Tsirkin
On Thu, Sep 02, 2010 at 09:00:42AM -0600, Alex Williamson wrote: Incorporated feedback. txburst= and txtimer= are now x- prefixed developer options. I added a tx= option, because I do want there to be a supported way to switch between TX strategies. This also drops the magic value of

[Qemu-devel] [PATCH v2 3/4] virtio-net: Rename tx_timer_active to tx_waiting

2010-09-02 Thread Alex Williamson
De-couple this from the timer since we might want to use different backends to send the packet. Signed-off-by: Alex Williamson alex.william...@redhat.com --- hw/virtio-net.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/virtio-net.c

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-02 Thread Stefan Weil
Am 02.09.2010 10:51, schrieb Eduard - Gabriel Munteanu: On Wed, Sep 01, 2010 at 10:10:30PM +0200, Stefan Weil wrote: Please see my comments at the end of this mail. Am 30.08.2010 00:08, schrieb Eduard - Gabriel Munteanu: PCI devices should access memory through pci_memory_*()

[Qemu-devel] Re: [PATCH 4/7] ide: use the PCI memory access interface

2010-09-02 Thread Avi Kivity
On 09/02/2010 06:39 PM, Michael S. Tsirkin wrote: On Thu, Sep 02, 2010 at 06:24:25PM +0300, Avi Kivity wrote: That's not a practical long term solution. Eventually everything gets turned on. That's why I wanted a simple !iommu check and fallback. This way unless it's really used there's no

[Qemu-devel] [PATCH] virtio-9p: Make sure -virtfs option works correctly

2010-09-02 Thread Aneesh Kumar K.V
When making copy of arguments we were doing partial copy Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- vl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 9f7358e..df11ab3 100644 --- a/vl.c +++ b/vl.c @@ -2332,7 +2332,7 @@ int

Re: [Qemu-devel] [PATCH 2/7] pci: memory access API and IOMMU support

2010-09-02 Thread Eduard - Gabriel Munteanu
On Thu, Sep 02, 2010 at 06:05:39PM +0200, Stefan Weil wrote: Am 02.09.2010 10:51, schrieb Eduard - Gabriel Munteanu: [snip] The functions pci_memory_read and pci_memory_write not only read or write byte data but many different data types which leads to a lot of type casts in your other

[Qemu-devel] [PATCH v2 0/4] virtio-net: More configurability and bh handling for tx

2010-09-02 Thread Alex Williamson
Incorporated feedback. txburst= and txtimer= are now x- prefixed developer options. I added a tx= option, because I do want there to be a supported way to switch between TX strategies. This also drops the magic value of txtimer= 1 or 0 (setting default timeout or switching modes). I also

Re: [Qemu-devel] [PATCH] raw-posix: Don't use file name for host_cdrom detection on Linux

2010-09-02 Thread Christoph Hellwig
On Thu, Sep 02, 2010 at 05:50:09PM +0200, Kevin Wolf wrote: On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose anything but false positives by removing the check for a /dev/cd* path. Agreed. Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] Template for developing a Qe mu device with PCIe and MSI-X

2010-09-02 Thread Adnan Khaleel
I've tried everything you mentioned and I still get the same problem. The only thing that seems to avoid that issue is if I reduce the aperture size from 0x20ull to 0x200ull. Here is the relevant section of code: static const unsigned long long BAR_Regions[6][2] = { // len ,

[Qemu-devel] gdb for sparc64?

2010-09-02 Thread Artyom Tarasenko
Does any gdb version work with current qemu-system-sparc64 ? I tried 7.1 and 6.8 with --target=sparc64-linux and --target=sparc64 And result seems to be pretty much the same: GNU gdb 6.8 Copyright (C) 2008 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

[Qemu-devel] [PATCH-V5 00/28] Consolidated VirtFS work

2010-09-02 Thread Venkateswararao Jujjuri (JV)
This patch series is a consolidated view of various VirtFS patches on the Mailing List. None of these patches are new in this series. For sometime all these patches were on the mainling list individually. Changes from V4: - Added two patches: o

[Qemu-devel] [PATCH -V5 01/28] qemu: virtio-9p: Recognize 9P2000.L protocol

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Make 9P server recognize 9P2000.L protocol version Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p.c |6 +- hw/virtio-9p.h |6 ++ 2 files changed, 11

[Qemu-devel] [PATCH -V5 04/28] [V4] virtio-9p: readdir implementation for 9p2000.L

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com This patch implements the server part of readdir() implementation for 9p2000.L SYNOPSIS size[4] Treaddir tag[2] fid[4] offset[8] count[4] size[4] Rreaddir tag[2] count[4] data[count] DESCRIPTION The readdir request asks the server

[Qemu-devel] [PATCH -V5 05/28] virtio-9p: Compute iounit based on host filesystem block size

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Compute iounit based on the host filesystem block size and pass it to client with open/create response. Also return iounit as statfs's f_bsize for optimal block size transfers. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Reviewd-by: Sripathi Kodi

[Qemu-devel] [PATCH -V5 03/28] virtio-9p: Return correct error from v9fs_remove

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com Signed-off-by: Sripathi Kodi sripat...@in.ibm.com In v9fs_remove_post_remove() we currently ignore the error returned by the previous call to remove() and return an error only if freeing the fid fails. However, the client expects to see the error from

[Qemu-devel] [PATCH -V5 02/28] qemu: virtio-9p: Implement statfs support in server

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Implement statfs support in qemu server based on Sripathi's initial statfs patch. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Sripathi Kodi sripat...@in.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH -V5 16/28] [virtio-9p] qemu: virtio-9p: Implement LOPEN

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Implement 9p2000.L version of open(LOPEN) interface in qemu 9p server. For LOPEN, no need to convert the flags to and from 9p mode to VFS mode. Synopsis: size[4] Tlopen tag[2] fid[4] mode[4] size[4] Rlopen tag[2] qid[13] iounit[4] Current qemu 9p

[Qemu-devel] [PATCH -V5 08/28] [virtio-9p] Make v9fs_do_utimensat accept timespec structures instead of v9stat.

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com Currently v9fs_do_utimensat takes a V9fsStat argument and builds timespec structures. It sets tv_nsec values to 0 by default. Instead of this it should take struct timespec[2] and pass it down to the system directly. This will make it more generic and

[Qemu-devel] [PATCH -V5 26/28] [virtio-9p] Remove all instances of unnecessary dotu variable.

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Arun R Bharadwaj a...@linux.vnet.ibm.com Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p-debug.c | 26 hw/virtio-9p-debug.h |1 - hw/virtio-9p.c | 115

[Qemu-devel] [PATCH -V5 17/28] virtio-9p: Add fidtype so that we can do type specific operation

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We want to add type specific operation during read/write Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p.c | 110

[Qemu-devel] [PATCH -V5 19/28] virtio-9p: Implement TXATTRCREATE

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com TXATTRCREATE: Prepare a fid for setting xattr value on a file system object. size[4] TXATTRCREATE tag[2] fid[4] name[s] attr_size[8] flags[4] size[4] RXATTRWALK tag[2] txattrcreate gets a fid pointing to xattr. This fid can later be used

[Qemu-devel] [PATCH -V5 11/28] [virtio-9p] Define and implement TSYMLINK for 9P2000.L

2010-09-02 Thread Venkateswararao Jujjuri (JV)
This patch implements creating a symlink for TSYMLINK request and responds with RSYMLINK. In the case of error, we return RERROR. SYNOPSIS size[4] Tsymlink tag[2] fid[4] name[s] symtgt[s] gid[4] size[4] Rsymlink tag[2] qid[13] DESCRIPTION Create a symbolic link named 'name'

[Qemu-devel] [PATCH -V5 14/28] qemu: virtio-9p: Implement TMKDIR

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Synopsis size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4] size[4] Rmkdir tag[2] qid[13] Description mkdir asks the file server to create a directory with given name, mode and gid. The qid for the new directory is returned with the

[Qemu-devel] [PATCH -V5 25/28] virtio-9p: Make sure -virtfs option works correctly

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com When making copy of arguments we were doing partial copy Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- vl.c |4 ++-- 1 files changed, 2 insertions(+),

[Qemu-devel] [PATCH -V5 20/28] virtio-9p: Hide user.virtfs xattr in case of mapped security.

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With mapped security mode we use user.virtfs namespace is used to store the virtFs related attributes. So hide it from user. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri

[Qemu-devel] [PATCH -V5 18/28] virtio-9p: Implement TXATTRWALK

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com TXATTRWALK: Descend a ATTR namespace size[4] TXATTRWALK tag[2] fid[4] newfid[4] name[s] size[4] RXATTRWALK tag[2] size[8] txattrwalk gets a fid pointing to xattr. This fid can later be used to get read the xattr value. If name is NULL the

[Qemu-devel] [PATCH -V5 24/28] virtio-9p: Add support for removing xattr

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/file-op-9p.h |1 + hw/virtio-9p-local.c | 17 + hw/virtio-9p.c | 25

[Qemu-devel] [PATCH -V5 22/28] virtio-9p: Use lchown which won't follow symlink

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We should always use functions which don't follow symlink on the server Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p-local.c |2 +- 1

[Qemu-devel] [PATCH -V5 21/28] virtio-9p: Add SM_NONE security model

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This is equivalent to SM_PASSTHROUGH security model. The only exception is, failure of privilige operation like chown are ignored. This makes a passthrough like security model usable for people who runs kvm as non root Signed-off-by: Aneesh

[Qemu-devel] [PATCH -V5 28/28] virtio-9p: Change handling of flags in open() path for 9P2000.L

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com This patch applies on top of 9P2000.L patches that we have on the list. I took a look at how 9P server is handling open() flags in 9P2000.L path. I think we can do away with the valid_flags() function and simplify the code. The reasoning is as follows:

[Qemu-devel] [PATCH -V5 23/28] virtio-9p: Fix the memset usage

2010-09-02 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com The arguments are wrong. Use qemu_mallocz directly Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p.c |3 +-- 1 files changed, 1

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Stefan Weil
Am 02.09.2010 22:27, schrieb Adam Lackorzynski: Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynskia...@os.inf.tu-dresden.de --- target-arm/translate.c |6 +- 1 files changed, 5 insertions(+), 1

[Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Adam Lackorzynski
Handle smc as an undefined instruction instead of having it wrongly interpreted as some other one. Signed-off-by: Adam Lackorzynski a...@os.inf.tu-dresden.de --- target-arm/translate.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/target-arm/translate.c

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Peter Maydell
On Thu, Sep 02, 2010 at 11:40:50PM +0200, Adam Lackorzynski wrote: +case 7: +/* SMC? */ +if ((insn 0xfff0) == 0xe1600070) { +goto illegal_op; +} +/* bkpt */ This doesn't look right to me. SMC in the ARM encoding is

Re: [Qemu-devel] Template for developing a Qe mu device with PCIe and MSI-X

2010-09-02 Thread Adnan Khaleel
During bootup, I also see the following error message: pci :40:00.0: BAR 0 bad alignment 20: 0x00-0x1f Any idea whats causing this? AK _ From: Isaku Yamahata [mailto:yamah...@valinux.co.jp] To: Adnan Khaleel [mailto:ad...@khaleel.us] Cc: Cam

[Qemu-devel] [PATCH] Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

2010-09-02 Thread Jonathan A. Kollasch
From: Jonathan A. Kollasch jakll...@siwenna.kollasch.net Signed-off-by: Jonathan A. Kollasch jakll...@kollasch.net --- hw/ide/core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 3651d2b..2fa26f4 100644 --- a/hw/ide/core.c +++

Re: [Qemu-devel] [PATCH] Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

2010-09-02 Thread Jonathan A. Kollasch
In case it isn't obvious, git hates me, a lot. I may just give up on this bug. Jonathan Kollasch

Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction

2010-09-02 Thread Adam Lackorzynski
On Thu Sep 02, 2010 at 23:14:23 +0100, Peter Maydell wrote: On Thu, Sep 02, 2010 at 11:40:50PM +0200, Adam Lackorzynski wrote: +case 7: +/* SMC? */ +if ((insn 0xfff0) == 0xe1600070) { +goto illegal_op; +} +

[Qemu-devel] [PATCH 4/4] PPC: Make e500 pci byte swap config data

2010-09-02 Thread Alexander Graf
The config data field on the e500 pci controller is in little endian, so we need to enable byte swap there. Signed-off-by: Alexander Graf ag...@suse.de --- hw/ppce500_pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c index

[Qemu-devel] [PULL 0/4] PPC updates

2010-09-02 Thread Alexander Graf
This time around I also included a fix for the shmem compile bug, as my tree wouldn't compile otherwise. The following changes since commit cb93bbdd7db92e50ff5e60a346b23df68acae46b: Blue Swirl (1): Fix OpenBSD linker warning are available in the git repository at:

[Qemu-devel] [PATCH 1/4] Fix compile of ivshmem on 32 bit hosts

2010-09-02 Thread Alexander Graf
The compile of ivshmem.c on my ppc system breaks with the following error: ivshmem.c: In function ‘check_shm_size’: ivshmem.c:356: error: format ‘%ld’ expects type ‘long int’, but argument 4 has type ‘__off64_t’ This patch adds an explicit cast, making printf happy.

Re: [Qemu-devel] [PATCH] Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0.

2010-09-02 Thread Alexander Graf
On 03.09.2010, at 01:10, Jonathan A. Kollasch wrote: In case it isn't obvious, git hates me, a lot. I may just give up on this bug. Why? Things looked pretty good except for the subject line/content mess. When writing a patch, just make sure to have the subject be in the first line of the

[Qemu-devel] [PATCH] Improve ATA IDENTIFY word 64 contents.

2010-09-02 Thread Jonathan A. Kollasch
Fill in word 64 of IDENTIFY data to indicate support for PIO modes 3 and 4. This allows NetBSD guests to use UltraDMA modes instead of just PIO mode 0. --- hw/ide/core.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index

[Qemu-devel] correct bswap functions?

2010-09-02 Thread Jonathan A. Kollasch
Hi, Is my guess that it's the bswapXX functions and not the bswap_XX functions that are supposed to be used outside of bswap.[ch]? Jonathan Kollasch

[Qemu-devel] sh: can't access tty; job control turned off on Linux/SPARC w/ QEMU

2010-09-02 Thread 권영수
I am currently working on QEMU emulating Linux/SPARC. I have compiled QEMU-0.12.5 and downloaded sparc-test-0.2.tar.gz from qemu.org website. When I have executed “qemu-g” which boots Linux/SPARC, the window appears but finally it generates the following error.

[Qemu-devel] Re: [SeaBIOS] [PATCH] pciinit: remove unused variable, old_addr, in pci_set_io_region_addr().

2010-09-02 Thread Kevin O'Connor
On Mon, Aug 30, 2010 at 11:32:01AM +0900, Isaku Yamahata wrote: old_addr is initialized, but not used. remove the useless variable. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Thanks. -Kevin

[Qemu-devel] Re: [PATCH] Use signed 16-bit values for ivshmem register writes

2010-09-02 Thread Hidetoshi Seto
(2010/08/31 1:58), Cam Macdonell wrote: fixes gcc 4.1 warning Signed-off-by: Cam Macdonell c...@cs.ualberta.ca --- hw/ivshmem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index bbb5cba..fa9c684 100644 --- a/hw/ivshmem.c +++

[Qemu-devel] [PATCH] ivshmem: remove unnecessary checks for unsigned

2010-09-02 Thread Hidetoshi Seto
fixes gcc 4.1 warning: In function 'ivshmem_io_writel': 202: warning: comparison is always false due to limited range of data type 208: warning: comparison is always true due to limited range of data type Signed-off-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com --- hw/ivshmem.c |4 ++--

Re: [Qemu-devel] Template for developing a Qemu device with PCIe?and MSI-X

2010-09-02 Thread Isaku Yamahata
On Thu, Sep 02, 2010 at 12:42:42PM -0500, Adnan Khaleel wrote: I've tried everything you mentioned and I still get the same problem. The only thing that seems to avoid that issue is if I reduce the aperture size from 0x20ull to 0x200ull. I suppose that Cam is seeing the same issue.

[Qemu-devel] Re: [PATCH 1/4] pci: expand tabs to spaces in pci_ids.h and pci_regs.h

2010-09-02 Thread Kevin O'Connor
On Sat, Aug 28, 2010 at 06:02:55PM +0300, Eduard - Gabriel Munteanu wrote: The conversion was done using the GNU 'expand' tool (default settings) to make it obey the SeaBIOS coding style. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Thanks Eduard. Patch 1 - I don't

[Qemu-devel] Re: [SeaBIOS] [PATCH 2/4] pci: add foreachcap() helper

2010-09-02 Thread Isaku Yamahata
Given the usage of 3/4, u32 pci_find_capability(bdf, cap) would be more direct. Maybe this is a matter of taste, though. On Sat, Aug 28, 2010 at 06:02:56PM +0300, Eduard - Gabriel Munteanu wrote: This iterates over capabilities exposed by PCI devices. It's needed by IOMMU initialization code

[Qemu-devel] Re: [SeaBIOS] [PATCH 4/4] iommu: provide ACPI tables

2010-09-02 Thread Isaku Yamahata
How about the following approach? Although I'm not sure how much multiple iommus is wanted, it wouldn't pose single iommu limit and global variables in 3/4 would be unnecessary. In stead of ACPI_INIT_TABLE(build_ivrs()), something like foreachpci() { if (class ==

[Qemu-devel] Re: [SeaBIOS] [PATCH 3/4] iommu: introduce AMD IOMMU support, initialize it

2010-09-02 Thread Isaku Yamahata
I think those global variables are unnecessary. Please see the comment on 4/4. thanks, On Sat, Aug 28, 2010 at 06:02:57PM +0300, Eduard - Gabriel Munteanu wrote: The AMD IOMMU must be discovered and initialized by the BIOS if present. Signed-off-by: Eduard - Gabriel Munteanu

[Qemu-devel] Re: [PATCH] ivshmem: remove unnecessary checks for unsigned

2010-09-02 Thread Hidetoshi Seto
(2010/09/03 10:54), Hidetoshi Seto wrote: fixes gcc 4.1 warning: In function 'ivshmem_io_writel': 202: warning: comparison is always false due to limited range of data type 208: warning: comparison is always true due to limited range of data type Signed-off-by: Hidetoshi Seto

Re: [Qemu-devel] information about PL110 LCD controller

2010-09-02 Thread Chih-Min Chao
On Thu, Sep 2, 2010 at 6:41 PM, Andrea Galeazzi galea...@korg.it wrote: Hi every body, I'm a newbie about the qemu word but I'd like to emulate the versatile ARM platform. In particular I'm very interested in knowing how much the emulation of PL110 LCD controller fits the real hardware. Are