[Qemu-devel] [PATCH 3/4] Fix test suite build with tracing enabled

2010-10-22 Thread Luiz Capitulino
From: Jan Kiszka qemu_malloc instrumentations require linking against the trace objects. Signed-off-by: Jan Kiszka Acked-by: Stefan Hajnoczi Signed-off-by: Luiz Capitulino --- Makefile | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile ind

[Qemu-devel] [PATCH 2/4] Silence compiler warning in json test case

2010-10-22 Thread Luiz Capitulino
From: Jan Kiszka This avoids error: zero-length gnu_printf format string Signed-off-by: Jan Kiszka Signed-off-by: Luiz Capitulino --- check-qjson.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/check-qjson.c b/check-qjson.c index 0b60e45..64fcdcb 100644 ---

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 15:53:39 +0200 Paolo Bonzini wrote: > On 10/22/2010 03:44 PM, Luiz Capitulino wrote: > > > We could also have check-i386, check-qmp, etc. and check would simply > > > call all of them. > > > > That would be perfect, I think. I mean, if we could stick only to check > > to do

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 15:38:34 +0200 Paolo Bonzini wrote: > On 10/22/2010 03:26 PM, Luiz Capitulino wrote: > > On Thu, 21 Oct 2010 10:18:34 +0200 > > Paolo Bonzini wrote: > > > >> This is a small start from the autoconfy configure series. Actually, > >> this part is almost completely new. It cle

[Qemu-devel] [PATCH 1/4] Trivial fix for QMP/qmp-events.txt

2010-10-22 Thread Luiz Capitulino
From: Hidetoshi Seto Fix example of STOP event that was just copy-and-pasted. Signed-off-by: Hidetoshi Seto Signed-off-by: Luiz Capitulino --- QMP/qmp-events.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 01ec85f..aa

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:57 AM, Kevin Wolf wrote: Am 22.10.2010 15:45, schrieb Anthony Liguori: On a physical system, if you don't have a battery backed disk and you enable the WC on your disk, then even with cache=writethrough we're unsafe. I don't think that's right. O_SYNC should guar

Re: [Qemu-devel] [PATCH 1/2] usb-ccid: add CCID bus

2010-10-22 Thread Markus Armbruster
Alon Levy writes: > A CCID device is a smart card reader. It is a USB device, defined at [1]. > This patch introduces the usb-ccid device that is a ccid bus. Next patches > will > introduce two card types to use it, a passthru card and an emulated card. > > [1] http://www.usb.org/developers/dev

[Qemu-devel] [PATCH 08/11] qemu-img: Fix qemu-img convert -obacking_file

2010-10-22 Thread Kevin Wolf
The old -B option caused a backing file to be used for the converted image and to avoid copying clusters from the old backing file. When replaced with -obacking_file, qemu-img convert does assign the backing file to the new image, but it doesn't realize that it should avoid copying clusters from th

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:35 AM, Kevin Wolf wrote: Am 22.10.2010 14:58, schrieb Anthony Liguori: On 10/22/2010 03:29 AM, Kevin Wolf wrote: I agree. Of course, as Laurent said a while ago, there is no specification for NBD, so it's hard to say what the intended semantics is. Howeve

[Qemu-devel] [PATCH 07/11] block: Use GCC_FMT_ATTR and fix a format error

2010-10-22 Thread Kevin Wolf
From: Stefan Weil Adding the gcc format attribute detects a format bug which is fixed here. v2: Don't use type cast. BDRV_SECTOR_SIZE is unsigned long long, so %lld should be the correct format specifier. Cc: Blue Swirl Cc: Kevin Wolf Signed-off-by: Stefan Weil Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PATCH 09/11] ide: Factor ide_flush_cache out

2010-10-22 Thread Kevin Wolf
The next patch reuses this code, so put it in its own function. Signed-off-by: Kevin Wolf --- hw/ide/core.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 5ccb09c..6d8606e 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @

[Qemu-devel] [PATCH 10/11] ide: Handle flush failure

2010-10-22 Thread Kevin Wolf
Instead of always assuming success for bdrv_aio_flush, actually do something with the error. This respects the werror option and accordingly ignores the error, reports it to the guest or stops the VM and retries after cont. Ignoring the error is trivial, obviously. For stopping the VM and retrying

[Qemu-devel] [PATCH 06/11] qemu-io: New command map

2010-10-22 Thread Kevin Wolf
The new map command in qemu-io lists all allocated/unallocated areas in an image file. Signed-off-by: Kevin Wolf --- qemu-io.c | 39 +++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index b4e5cc8..ff353eb 100644 --- a

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:17 AM, Luiz Capitulino wrote: You and Gerd asked about the purpose of this command, turns out that it's only useful for developing new USB devices for QEMU, so I thought it would be better to restrict it, so that people don't start using this the wrong way or worse, we can't drop

[Qemu-devel] [PATCH 05/11] Copy snapshots out of QCOW2 disk

2010-10-22 Thread Kevin Wolf
From: edison In order to backup snapshots, created from QCOW2 iamge, we want to copy snapshots out of QCOW2 disk to a seperate storage. The following patch adds a new option in "qemu-img": qemu-img convert -f qcow2 -O qcow2 -s snapshot_name src_img bck_img. Right now, it only supports to copy t

[Qemu-devel] [PATCH 01/11] qcow2: Support exact L1 table growth

2010-10-22 Thread Kevin Wolf
From: Stefan Hajnoczi The L1 table grow operation includes a size calculation that bumps up the new L1 table size in order to anticipate the size needs of vmstate data. This helps reduce the number of times that the L1 table has to be grown when vmstate data is appended. This size overhead is n

[Qemu-devel] [PATCH 04/11] ide: set WCACHE supported in IDENTIFY data

2010-10-22 Thread Kevin Wolf
From: Christoph Hellwig ATA does not only have the WCACHE enabled bit in identify word 85, but also a WCACHE supported bit in word 82. While the Linux kernel is fine with the latter at least hdparm also needs the former before correctly displaying the cache settings. There's also a non-zero cha

[Qemu-devel] [PATCH 03/11] qcow2: Remove old image creation function

2010-10-22 Thread Kevin Wolf
They have been #ifdef'd out by the previous patch. Signed-off-by: Kevin Wolf --- block/qcow2.c | 224 - 1 files changed, 0 insertions(+), 224 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3b2e38c..45ed073 100644 --- a/bloc

[Qemu-devel] [PATCH 02/11] qcow2: Simplify image creation

2010-10-22 Thread Kevin Wolf
Instead of doing lots of magic for setting up initial refcount blocks and stuff create a minimal (inconsistent) image, open it and initialize the rest with regular qcow2 functions. This is a complete rewrite of the image creation function. The old implementating is #ifdef'd out and will be removed

[Qemu-devel] [PULL 00/11] Block patches

2010-10-22 Thread Kevin Wolf
The following changes since commit d03703c81a202cea156811e5dbc8e88627c19986: curses: Fix contro...@[\]^_} and ESC (2010-10-21 18:31:28 +0200) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Christoph Hellwig (1): ide: set WCACHE supported in IDENTIFY

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Paolo Bonzini
On 10/22/2010 03:26 PM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 10:18:34 +0200 Paolo Bonzini wrote: This is a small start from the autoconfy configure series. Actually, this part is almost completely new. It cleans up the tests Makefile so that the i386-linux-user testsuite's Makefile tar

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 14:58, schrieb Anthony Liguori: > On 10/22/2010 03:29 AM, Kevin Wolf wrote: >>> I agree. >>> >> Of course, as Laurent said a while ago, there is no specification for >> NBD, so it's hard to say what the intended semantics is. >> >> However, I did have a look at the nbdserver cod

Re: [Qemu-devel] [PATCH 0/7] [PULL] qemu-kvm.git uq/master queue

2010-10-22 Thread Anthony Liguori
On 10/21/2010 01:25 PM, Marcelo Tosatti wrote: The following changes since commit 633aa0acfe2c4d3e56acfe28c912796bf54de6d3: Fix pci hotplug to generate level triggered interrupt. (2010-10-20 17:23:28 -0500) Pulled. Thanks. Regards, Anthony Liguori are available in the git reposito

Re: [Qemu-devel] [PATCH 0/6] First part of autoconfy series: cleanup tests/

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 10:18:34 +0200 Paolo Bonzini wrote: > This is a small start from the autoconfy configure series. Actually, > this part is almost completely new. It cleans up the tests Makefile > so that the i386-linux-user testsuite's Makefile targets are more > easily extensible and can wo

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 03:29 AM, Kevin Wolf wrote: I agree. Of course, as Laurent said a while ago, there is no specification for NBD, so it's hard to say what the intended semantics is. However, I did have a look at the nbdserver code and it looks as if it implements something similar to writethr

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Anthony Liguori
On 10/22/2010 07:48 AM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levy wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote: v2->v3 changes:

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 07:55:02 -0500 Anthony Liguori wrote: > On 10/22/2010 07:48 AM, Luiz Capitulino wrote: > > On Thu, 21 Oct 2010 15:27:23 +0200 > > Alon Levy wrote: > > > > > >> On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > >> > >>> On 10/21/2010 08:03 AM, Gerd H

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levy wrote: > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > > On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > > >On 10/21/10 08:36, Alon Levy wrote: > > >>v2->v3 changes: > > >> * add configure parameter > > >> * fix docs > > >> > > >>

[Qemu-devel] Re: [RESEND PATCH] monitor: properly handle illegal fd/vhostfd from command line

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 19:29:02 +0800 Jason Wang wrote: > When hanlding fd/vhostfd form command line through net_handle_fd_param(), > we need to check mon and return value of strtol() other than we could > get segmentation fault or invalid fd when user type an illegal fd/vhostfd. > > This patch is

Re: [Qemu-devel] Re: [PATCH v6 07/12] pcie/hotplug: introduce pushing attention button command

2010-10-22 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Oct 20, 2010 at 05:18:56PM +0900, Isaku Yamahata wrote: >> glue pcie_push_attention_button command. >> >> Signed-off-by: Isaku Yamahata > > So as a high level command, I think we need to > think about how to tie this into pci_add/pci_del. > Right? [...] D

Re: [Qemu-devel] [PATCH]: VNC: set listener socket to non-blocking mode

2010-10-22 Thread Gianni Tedesco
On Thu, 2010-10-21 at 17:44 +0100, Anthony Liguori wrote: > On 10/21/2010 11:18 AM, Gianni Tedesco wrote: > > This prevents qemu from hanging waiting for a client to connect. I have > > reproduced this when doing a loadvm but it may be a more general problem > > in that poll/accept may race if a cl

Re: [Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-22 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Oct 20, 2010 at 05:18:57PM +0900, Isaku Yamahata wrote: >> This patch implements helper functions for pcie aer capability >> which will be used later. >> >> Signed-off-by: Isaku Yamahata > > Some style comments and a couple of minor bugs. [...] >> + >> +st

Re: [Qemu-devel] [PATCH 2/2] v2 Fix Block Hotplug race with drive_unplug()

2010-10-22 Thread Kevin Wolf
Am 21.10.2010 23:37, schrieb Ryan Harper: > * Daniel P. Berrange [2010-10-21 08:29]: >> On Tue, Oct 19, 2010 at 09:32:29AM -0500, Ryan Harper wrote: >>> Block hot unplug is racy since the guest is required to acknowlege the ACPI >>> unplug event; this may not happen synchronously with the device r

[Qemu-devel] Re: [PATCH 2/2] Replace remaining gcc format attributes by macro GCC_FMT_ATTR (format checking)

2010-10-22 Thread Stefan Weil
Am 13.10.2010 20:54, schrieb Stefan Weil: Replace the remaining format attribute printf by macro GCC_FMT_ATTR which uses gnu_printf (if supported). v2 * Removal of dyngen specific code is now done in a separate patch. * Handle attribute in new ui/spice-display.c, too. Cc: Blue Swirl Signed-off-

Re: [Qemu-devel] v6: [PATCH 0/3]: Threadlets: A generic task offloading framework

2010-10-22 Thread Amit Shah
On (Wed) Oct 20 2010 [08:18:51], Anthony Liguori wrote: > On 10/20/2010 07:05 AM, Stefan Hajnoczi wrote: > >On Wed, Oct 20, 2010 at 12:57 PM, Amit Shah wrote: > >>On (Tue) Oct 19 2010 [23:12:20], Arun R Bharadwaj wrote: > >>>Hi, > >>> > >>>This is the v6 of the patch-series to have a generic async

[Qemu-devel] Re: [PATCH v6 08/12] pcie/aer: helper functions for pcie aer capability

2010-10-22 Thread Michael S. Tsirkin
On Fri, Oct 22, 2010 at 08:53:15AM +0900, Isaku Yamahata wrote: > On Thu, Oct 21, 2010 at 10:07:01AM +0200, Michael S. Tsirkin wrote: > > On Thu, Oct 21, 2010 at 02:15:24PM +0900, Isaku Yamahata wrote: > > > Thank you for detailed review. > > > > > > On Wed, Oct 20, 2010 at 11:56:16AM +0200, Micha

Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it

2010-10-22 Thread Markus Armbruster
Jes Sorensen writes: > On 10/22/10 09:59, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >>> From: Jes Sorensen >>> This patch introduces cutils.c: strtosz() and gets rid of the >>> multiple custom hacks for parsing byte sizes. In addition it adds >>> supports for specifying human s

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 07:43, schrieb MORITA Kazutaka: > At Thu, 21 Oct 2010 16:07:28 +0200, > Kevin Wolf wrote: >> >> Hi all, >> >> I'm currently looking into adding a return value to qemu's bdrv_flush >> function and I noticed that your block drivers (nbd, rbd and sheepdog) >> don't implement bdrv_flush a

Re: Fwd: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
[ Adding qemu-devel to CC again ] Am 21.10.2010 20:59, schrieb Sage Weil: > On Thu, 21 Oct 2010, Christian Brunner wrote: >> Hi, >> >> is there a flush operation in librados? - I guess the only way to >> handle this, would be waiting until all aio requests are finished? That's not the semantics o

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 21.10.2010 21:32, schrieb Laurent Vivier: > Le jeudi 21 octobre 2010 à 10:07 -0500, Anthony Liguori a écrit : >> On 10/21/2010 09:07 AM, Kevin Wolf wrote: >>> Hi all, >>> >>> I'm currently looking into adding a return value to qemu's bdrv_flush >>> function and I noticed that your block drivers

[Qemu-devel] Re: VM with two interfaces

2010-10-22 Thread Stefan Hajnoczi
On Thu, Oct 21, 2010 at 11:49 PM, Nirmal Guhan wrote: > On Thu, Oct 21, 2010 at 9:23 AM, Nirmal Guhan wrote: >> Hi, >> >> Am trying to create a VM using qemu-kvm with two interfaces(fedora12 >> is the host and vm) and running into an issue. Given below is the >> command : >> >> qemu-kvm -net nic,

Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it

2010-10-22 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > This patch introduces cutils.c: strtosz() and gets rid of the > multiple custom hacks for parsing byte sizes. In addition it adds > supports for specifying human style sizes such as 1.5G. Last it > eliminates the horrible abuse of a float t

Re: [Qemu-devel] [PATCH 2/2] v2 Fix Block Hotplug race with drive_unplug()

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 04:37:46PM -0500, Ryan Harper wrote: > * Daniel P. Berrange [2010-10-21 08:29]: > > On Tue, Oct 19, 2010 at 09:32:29AM -0500, Ryan Harper wrote: > > > Block hot unplug is racy since the guest is required to acknowlege the > > > ACPI > > > unplug event; this may not happen

Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it

2010-10-22 Thread Jes Sorensen
On 10/22/10 09:59, Markus Armbruster wrote: > jes.soren...@redhat.com writes: >> From: Jes Sorensen >> This patch introduces cutils.c: strtosz() and gets rid of the >> multiple custom hacks for parsing byte sizes. In addition it adds >> supports for specifying human style sizes such as 1.5G. Last

[Qemu-devel] [Bug 663713] Re: Mouse frozen under an emulated ubuntu

2010-10-22 Thread FredBezies
Well, looks like the patch was added on 20 october. http://git.qemu.org/qemu.git/commit/?id=cd496926155afcb3b6323e70dd720dc118b3a255 With a little luck, it would be in Qemu 0.13.1. Thanks for the URL and the patch. Have a good day. -- Mouse frozen under an emulated ubuntu https://bugs.launchp

Re: [Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-22 Thread Balbir Singh
* Arun R B [2010-10-21 17:40:45]: > From: Aneesh Kumar K.V > > This patch creates a generic asynchronous-task-offloading infrastructure named > threadlets. The core idea has been borrowed from the threading framework that > is being used by paio. > > The reason for creating this generic infras

<    1   2