On 01/13/2011 06:28 PM, David Ahern wrote:
@@ -1087,8 +1087,10 @@ void pc_vga_init(PCIBus *pci_bus)
} else if (std_vga_enabled) {
if (pci_bus) {
pci_vga_init(pci_bus);
+#ifdef CONFIG_VGA_ISA
} else {
isa_vga_init();
+#endif
Should this
On Thu, 2011-01-13 at 17:01 +0800, Jan Kiszka wrote:
> Am 13.01.2011 09:34, Huang Ying wrote:
> > In Linux kernel HWPoison processing implementation, the virtual
> > address in processes mapping the error physical memory page is marked
> > as HWPoison. So that, the further accessing to the virtual
On Fri, 2011-01-14 at 05:14 +0800, Blue Swirl wrote:
> On Thu, Jan 13, 2011 at 8:34 AM, Huang Ying wrote:
> > qemu_ram_remap() unmaps the specified RAM pages, then re-maps these
> > pages again. This is used by KVM HWPoison support to clear HWPoisoned
> > page tables across guest rebooting, so th
On Thu, Jan 13, 2011 at 6:14 AM, Amit Shah wrote:
> On (Wed) Jan 12 2011 [19:03:58], Blue Swirl wrote:
>> +static QemuChrHandlers null_handlers = {
>> + /* All handlers are initialised to NULL */
>> +};
>> +
>> void qemu_chr_add_handlers(CharDriverState *s,
>> -
On Thu, Jan 13, 2011 at 5:15 PM, Yoshiaki Tamura
wrote:
> When -k option is set to migrate command, it will turn on ft_mode to
> start FT migration mode (Kemari).
>
> Signed-off-by: Yoshiaki Tamura
> ---
> hmp-commands.hx | 7 ---
> migration.c | 3 +++
> qmp-commands.hx | 7 +++
On Thu, Jan 13, 2011 at 5:15 PM, Yoshiaki Tamura
wrote:
> Introduce qemu_savevm_state_{begin,commit} to send the memory and
> device info together, while avoiding cancelling memory state tracking.
>
> Signed-off-by: Yoshiaki Tamura
> ---
> savevm.c | 88
> +
On Thu, Jan 13, 2011 at 8:34 AM, Huang Ying wrote:
> qemu_ram_remap() unmaps the specified RAM pages, then re-maps these
> pages again. This is used by KVM HWPoison support to clear HWPoisoned
> page tables across guest rebooting, so that a new page may be
> allocated later to recover the memory
On 01/13/2011 11:13 AM, Alexander Graf wrote:
Yes, I had intended to do that but left it out.
Should it be a bitmask or just a button count? Buttons really have no standard
meaning so usually a button count is sufficient.
Some random thoughts:
* multitouch capabilities would be go
On 01/13/2011 11:08 AM, Gerd Hoffmann wrote:
On 01/13/11 16:55, Anthony Liguori wrote:
On 01/13/2011 05:51 AM, Gerd Hoffmann wrote:
On 01/13/11 12:01, Stefan Hajnoczi wrote:
Can you elaborate how the spice display channel comes into play? On a
physical machine you just have input devices with
On 01/13/2011 11:09 AM, Paolo Bonzini wrote:
On 01/13/2011 05:39 PM, Anthony Liguori wrote:
On 01/13/2011 10:14 AM, Avi Kivity wrote:
On 01/13/2011 05:52 PM, Anthony Liguori wrote:
/* host->guest, sent before any other events */
typedef struct qemu_pvtablet_init {
uint32_t res_x; /* x axis re
On Thu, Jan 13, 2011 at 01:44:50PM -0600, Adam Litke wrote:
> On Thu, 2011-01-13 at 21:18 +0200, Alon Levy wrote:
> > On Thu, Jan 13, 2011 at 09:01:34AM -0600, Adam Litke wrote:
> > > On Tue, 2011-01-11 at 20:33 +0200, Alon Levy wrote:
> > > > > Spice guest agent:
> > > > > - virt agent, matahari,
floatx80_is_{quiet,signaling}_nan() functions are incorrectly detecting
the type of NaN, depending on SNAN_BIT_IS_ONE, one of the two is
returning the correct value, and the other true for any kind of NaN.
This patch fixes that by applying the same kind of comparison as for
other float formats, bu
On Thu, Jan 13, 2011 at 11:19:52AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> Just throwing a quick writeup into the ring to kickstart the design
> discussion ;)
I apologize for not reading everything before sending, I just don't want
to forget this detail: Whatever we design needs to address having
On Thu, 2011-01-13 at 21:18 +0200, Alon Levy wrote:
> On Thu, Jan 13, 2011 at 09:01:34AM -0600, Adam Litke wrote:
> > On Tue, 2011-01-11 at 20:33 +0200, Alon Levy wrote:
> > > > Spice guest agent:
> > > > - virt agent, matahari, spice agent...what is in spice agent?
> > > > - spice char device
> >
On 01/13/2011 07:19 PM, Gerd Hoffmann wrote:
On 01/13/11 17:18, Avi Kivity wrote:
On 01/13/2011 12:19 PM, Gerd Hoffmann wrote:
Hi,
Just throwing a quick writeup into the ring to kickstart the design
discussion ;)
typedef struct qemu_pvtablet_message {
uint32_t size; /* whole message size */
On Thu, Jan 13, 2011 at 09:01:34AM -0600, Adam Litke wrote:
> On Tue, 2011-01-11 at 20:33 +0200, Alon Levy wrote:
> > > Spice guest agent:
> > > - virt agent, matahari, spice agent...what is in spice agent?
> > > - spice char device
> > > - mouse, copy 'n paste, screen resolution change
> > > - c
On 01/13/2011 09:00 AM, Amit Shah wrote:
Hi,
This patchset adds new interfaces to work with iohandlers. It adds:
int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque)
-- Specify io handlers for an fd
int remove_fd_handlers(int fd)
-- Remove fd handlers for fd (mark ioh for de
When ft_mode is set in the header, tcp_accept_incoming_migration()
sets ft_trans_incoming() as a callback, and call
qemu_file_get_notify() to receive FT transaction iteratively. We also
need a hack no to close fd before moving to ft_transaction mode, so
that we can reuse the fd for it. vm_change_
Signed-off-by: Yoshiaki Tamura
---
vl.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 8bbb785..9faeb27 100644
--- a/vl.c
+++ b/vl.c
@@ -162,6 +162,7 @@ int main(int argc, char **argv)
#include "qemu-queue.h"
#include "cpus.h"
#include "arch_init.h
Record ioport event to replay it upon failover.
Signed-off-by: Yoshiaki Tamura
---
ioport.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/ioport.c b/ioport.c
index aa4188a..74aebf5 100644
--- a/ioport.c
+++ b/ioport.c
@@ -27,6 +27,7 @@
#include "ioport.h"
#include
event-tap function is called only when it is on.
Signed-off-by: Yoshiaki Tamura
---
net.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/net.c b/net.c
index 9ba5be2..1176124 100644
--- a/net.c
+++ b/net.c
@@ -36,6 +36,7 @@
#include "qemu-common.h"
#include "qe
On 01/13/11 10:04, Paolo Bonzini wrote:
> On 01/13/2011 07:34 AM, David Ahern wrote:
>>
>> +#ifdef CONFIG_FDC
>> /* floppy type */
>>
>> fd0 = fdctrl_get_drive_type(floppy_controller, 0);
>> @@ -403,6 +408,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t
>> above_4g_mem_size,
>>
For regular migration inuse == 0 always as requests are flushed before
save. However, event-tap log when enabled introduces an extra queue
for requests which is not being flushed, thus the last inuse requests
are left in the event-tap queue. Move the last_avail_idx value sent
to the remote back to
On Wed, Jan 12, 2011 at 07:42:47PM +0100, Aurelien Jarno wrote:
> The current FPU code returns 0.0 if one of the operand is a
> signaling NaN and the VXSNAN exception is disabled.
>
> fload_invalid_op_excp() doesn't return a qNaN in case of a VXSNAN
> exception as the operand should be propagated
On Wed, Jan 12, 2011 at 07:42:48PM +0100, Aurelien Jarno wrote:
> Some tests in FPU emulation code were wrongly using float64_is_nan()
> before commit 185698715dfb18c82ad2a5dbc169908602d43e81, and wrongly
> using float64_is_quiet_nan() after. Fix them by using float64_is_any_nan()
> instead.
>
> C
Hi,
This patch series is a revised version of Kemari for KVM, which
applied comments for the previous post. The current code is based on
qemu.git d03d11260ee2d55579e8b76116e35ccdf5031833.
The changes from v0.2.3 -> v0.2.4 are:
- call vm_start() before event_tap_flush_one() to avoid failure in
This code implements VM transaction protocol. Like buffered_file, it
sits between savevm and migration layer. With this architecture, VM
transaction protocol is implemented mostly independent from other
existing code.
Signed-off-by: Yoshiaki Tamura
Signed-off-by: OHMURA Kei
---
Makefile.objs
Introduce skip_header parameter to qemu_loadvm_state() so that it can
be called iteratively without reading the header.
Signed-off-by: Yoshiaki Tamura
---
migration.c |2 +-
savevm.c| 24 +---
sysemu.h|2 +-
3 files changed, 15 insertions(+), 13 deletions(-)
The option looks like, -incoming ::,ft_mode
Signed-off-by: Yoshiaki Tamura
---
migration.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index d4922ce..1822e97 100644
--- a/migration.c
+++ b/migration.c
@@ -42,9 +42,16 @@ static Migrat
Make deleting handlers robust against deletion of any elements in a
handler by using a deleted flag like in file descriptors.
Signed-off-by: Yoshiaki Tamura
---
vl.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 0292184..8bbb785 100644
---
When -k option is set to migrate command, it will turn on ft_mode to
start FT migration mode (Kemari).
Signed-off-by: Yoshiaki Tamura
---
hmp-commands.hx |7 ---
migration.c |3 +++
qmp-commands.hx |7 ---
3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/hm
On 01/13/11 10:02, Paolo Bonzini wrote:
> On 01/13/2011 07:34 AM, David Ahern wrote:
>> Signed-off-by: David Ahern
>> ---
>> hw/pc.c |2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index e7514fd..11b570f 100644
>> --- a/hw/pc.c
>> +++ b/hw
To utilize ft_trans_file function, savevm needs interfaces to be
exported.
Signed-off-by: Yoshiaki Tamura
---
hw/hw.h |5 ++
savevm.c | 148 ++
2 files changed, 153 insertions(+), 0 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
ind
event-tap function is called only when it is on, and requests sent
from device emulators.
Signed-off-by: Yoshiaki Tamura
---
block.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index ff2795b..85bd8b8 100644
--- a/block.c
+++ b/block.c
@@
Signed-off-by: Yoshiaki Tamura
---
qemu-char.c |2 +-
qemu_socket.h |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index edc9ad6..737d347 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2116,7 +2116,7 @@ static void tcp_chr_telnet_init(int
event-tap controls when to start FT transaction, and provides proxy
functions to called from net/block devices. While FT transaction, it
queues up net/block requests, and flush them when the transaction gets
completed.
Signed-off-by: Yoshiaki Tamura
Signed-off-by: OHMURA Kei
---
Makefile.targe
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction
cycle. When ft_mode is on, migrate_fd_put_ready() would open
ft_trans_file and turn on event_tap. To end or cancel FT transaction,
ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is
called to receive ack from
On 01/13/11 17:18, Avi Kivity wrote:
On 01/13/2011 12:19 PM, Gerd Hoffmann wrote:
Hi,
Just throwing a quick writeup into the ring to kickstart the design
discussion ;)
typedef struct qemu_pvtablet_message {
uint32_t size; /* whole message size */
uint32_t type; /* qemu_pvtablet_type */
uint64
Currently buf size is fixed at 32KB. It would be useful if it could
be flexible.
Signed-off-by: Yoshiaki Tamura
---
hw/hw.h |2 ++
savevm.c | 20 +++-
2 files changed, 21 insertions(+), 1 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
index 163a683..a506688 100644
--- a/hw/
Introduce qemu_savevm_state_{begin,commit} to send the memory and
device info together, while avoiding cancelling memory state tracking.
Signed-off-by: Yoshiaki Tamura
---
savevm.c | 88 ++
sysemu.h |2 +
2 files changed, 90 inser
Record mmio write event to replay it upon failover.
Signed-off-by: Yoshiaki Tamura
---
exec.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/exec.c b/exec.c
index 49c28b1..4a171cc 100644
--- a/exec.c
+++ b/exec.c
@@ -33,6 +33,7 @@
#include "osdep.h"
#include "kvm.h
Currently FdMigrationState doesn't support read(), and this patch
introduces it to get response from the other side.
Signed-off-by: Yoshiaki Tamura
---
migration-tcp.c | 15 +++
migration.c | 12
migration.h |3 +++
3 files changed, 30 insertions(+), 0 de
On 13.01.2011, at 17:39, Anthony Liguori wrote:
> On 01/13/2011 10:14 AM, Avi Kivity wrote:
>> On 01/13/2011 05:52 PM, Anthony Liguori wrote:
>>>
>>> /* host->guest, sent before any other events */
>>> typedef struct qemu_pvtablet_init {
>>>uint32_t res_x; /* x axis resolution */
>>>ui
On 01/13/2011 07:34 AM, David Ahern wrote:
Signed-off-by: David Ahern
---
hw/pc.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index e7514fd..11b570f 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1087,8 +1087,10 @@ void pc_vga_init(PCIBus *pci_bus)
On 01/13/2011 05:39 PM, Anthony Liguori wrote:
On 01/13/2011 10:14 AM, Avi Kivity wrote:
On 01/13/2011 05:52 PM, Anthony Liguori wrote:
/* host->guest, sent before any other events */
typedef struct qemu_pvtablet_init {
uint32_t res_x; /* x axis resolution */
uint32_t res_y; /* y axis resoluti
On 01/13/2011 10:57 AM, Isaku Yamahata wrote:
How about creating stub functions instead of #ifdefs?
I think David's #ifdef's are okay. Ultimately what you'd want is to
drive all this from configuration files, and if this were done you
wouldn't need stub functions.
Paolo
On 01/13/2011 07:34 AM, David Ahern wrote:
+#ifdef CONFIG_FDC
/* floppy type */
fd0 = fdctrl_get_drive_type(floppy_controller, 0);
@@ -403,6 +408,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t
above_4g_mem_size,
val |= 0x02; /* FPU is there */
val |= 0x04; /* PS
On 01/13/11 16:55, Anthony Liguori wrote:
On 01/13/2011 05:51 AM, Gerd Hoffmann wrote:
On 01/13/11 12:01, Stefan Hajnoczi wrote:
Can you elaborate how the spice display channel comes into play? On a
physical machine you just have input devices with no notion of
display. It's up to the windowin
On 01/13/2011 10:18 AM, Avi Kivity wrote:
On 01/13/2011 12:19 PM, Gerd Hoffmann wrote:
Hi,
Just throwing a quick writeup into the ring to kickstart the design
discussion ;)
typedef struct qemu_pvtablet_message {
uint32_t size;/* whole message size */
uint32_t type;
On 01/13/2011 10:14 AM, Avi Kivity wrote:
On 01/13/2011 05:52 PM, Anthony Liguori wrote:
/* host->guest, sent before any other events */
typedef struct qemu_pvtablet_init {
uint32_t res_x; /* x axis resolution */
uint32_t res_y; /* y axis resolution */
uint32_t features; /* qem
Windows 7 KVM install runs unbelievably fast on SL 6 ( alpha 3) vs F14 with the
most recent libvirt stuff :
[root@fedora14b ~]# rpm -qa|grep libvirt
libvirt-python-0.8.7-1.fc14.x86_64
libvirt-0.8.7-1.fc14.x86_64
libvirt-client-0.8.7-1.fc14.x86_64
Boris.
P.S. It happens no matter of pre-install lo
On 01/13/2011 12:19 PM, Gerd Hoffmann wrote:
Hi,
Just throwing a quick writeup into the ring to kickstart the design
discussion ;)
typedef struct qemu_pvtablet_message {
uint32_t size;/* whole message size */
uint32_t type;/* qemu_pvtablet_type */
uin
On 01/13/2011 05:52 PM, Anthony Liguori wrote:
/* host->guest, sent before any other events */
typedef struct qemu_pvtablet_init {
uint32_t res_x; /* x axis resolution */
uint32_t res_y; /* y axis resolution */
uint32_t features; /* qemu_pvtablet_features */
uint32_t available
On 01/11/2011 04:43 PM, Anthony Liguori wrote:
- invalidate all buffers for that block device on machine A after
migration.
* with NFS, just close + reopen the file (and pray that nobody else
has it also opened)
* with block devices: use BLKFLBLK ioctl, and pray that nobody
else i
On 13/01/11 15:24, Mark Cave-Ayland wrote:
On 13/01/11 15:09, Mateusz Loskot wrote:
Hi,
I'm building current Git master (SHA1:facf1a60) using latest MingW32
on Windows Vista and compilation fails with the following error:
g:/src/qemu/_git/master/disas.c: In function 'generic_print_address':
g
On 13/01/11 12:40, Mateusz Loskot wrote:
On 13/01/11 10:13, Michal Suchanek wrote:
On 13 January 2011 00:34, Mateusz Loskot wrote:
On 12/01/11 17:15, Mateusz Loskot wrote:
On 12/01/11 16:48, Michal Suchanek wrote:
On 12 January 2011 16:21, Mateusz Loskot wrote:
Thinking of future, could any
On 01/13/2011 05:51 AM, Gerd Hoffmann wrote:
On 01/13/11 12:01, Stefan Hajnoczi wrote:
Can you elaborate how the spice display channel comes into play? On a
physical machine you just have input devices with no notion of
display. It's up to the windowing system to process input events and
hand
On 01/13/2011 04:19 AM, Gerd Hoffmann wrote:
Hi,
Just throwing a quick writeup into the ring to kickstart the design
discussion ;)
cheers,
Gerd
#ifndef __QEMU_PVTABLET__
#define __QEMU_PVTABLET__ 1
/*
* qemu patavirtual tablet interface
*/
#include
/* our virtio-serial channel */
#
Am 20.12.2010 13:45, schrieb Christoph Hellwig:
> Factor the DMA I/O path that is duplicated between read and write
> commands, into common helpers using the s->is_read flag added for
> the macio ATA controller.
>
> Signed-off-by: Christoph Hellwig
Thanks, applied all to the block branch.
Kevin
vmstate_pxa2xx_i2c incorrectly recursed to itself instead of going
to store slave device. Fix that stop stop qemu from segfaulting
during savevm for pxa2xx-based devices.
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/pxa2xx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --gi
Second instance of scoop contains registers shifted to 0x40 from the start
of the page. Instead of messing with register mapping, just limit register
address to 0x00..0x3f.
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/zaurus.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff
Mainstone board has two flash chips (emulated by two ram regions), however
currently code tries to allocate them with the same name, which fails.
Fix that to make mainstone emulation work again.
Signed-off-by: Dmitry Eremin-Solenikov
---
hw/mainstone.c |2 +-
1 files changed, 1 insertions(+)
On 07/01/11 17:28, Mateusz Loskot wrote:
I'm wondering if the following setup would work at all:
1. Quad-core workstation with 16GB RAM with Windows Vista 64-bit
as host OS
2. The Windows runs VirtualBox with Linux installed as guest OS.
3. The Linux guest OS runs QEMU
4. QEMU runs Solaris (SPAR
On 13/01/11 15:09, Mateusz Loskot wrote:
Hi,
I'm building current Git master (SHA1:facf1a60) using latest MingW32
on Windows Vista and compilation fails with the following error:
g:/src/qemu/_git/master/disas.c: In function 'generic_print_address':
g:/src/qemu/_git/master/disas.c:65:5: warning
On 01/13/11 16:00, Amit Shah wrote:
This patchset adds new interfaces to work with iohandlers. It adds:
int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque)
-- Specify io handlers for an fd
int remove_fd_handlers(int fd)
-- Remove fd handlers for fd (mark ioh for deletion)
in
Hi,
I'm building current Git master (SHA1:facf1a60) using latest MingW32
on Windows Vista and compilation fails with the following error:
g:/src/qemu/_git/master/disas.c: In function 'generic_print_address':
g:/src/qemu/_git/master/disas.c:65:5: warning: 'I' flag used with '%x'
gnu_printf format
Each iohandler for an fd can now be individually enabled or disabled.
Signed-off-by: Amit Shah
---
qemu-char.h |4 +++
vl.c| 78 --
2 files changed, 79 insertions(+), 3 deletions(-)
diff --git a/qemu-char.h b/qemu-char.h
inde
If an iohandler is asked to be enabled but the handler doesn't exist,
don't enable the handler.
This can be used to simplify the conditions in main_loop_wait().
Signed-off-by: Amit Shah
---
vl.c | 29 -
1 files changed, 20 insertions(+), 9 deletions(-)
diff --git
This function will be used to assign fd handlers. Future commits will
be enable each handler to be enabled/disabled individually.
Make qemu_set_fd_handler2() a wrapper to assign_fd_handlers().
remove_fd_handlers() removes all the assigned handlers and marks the
iohandler for deletion. It's a wr
Add a get_iohandler() function instead of looking up the ioh twice in
qemu_set_fd_handler2().
Signed-off-by: Amit Shah
---
vl.c | 44 ++--
1 files changed, 26 insertions(+), 18 deletions(-)
diff --git a/vl.c b/vl.c
index 0292184..9e365f6 100644
--- a/vl
On Tue, 2011-01-11 at 20:33 +0200, Alon Levy wrote:
> > Spice guest agent:
> > - virt agent, matahari, spice agent...what is in spice agent?
> > - spice char device
> > - mouse, copy 'n paste, screen resolution change
> > - could be generic (at least input and copy/paste)
> > - send protocol de
Collect all the handlers in a IOHandlerOps struct instead of being
passed one at a time to each function.
Signed-off-by: Amit Shah
---
qemu-char.h |7 ++-
vl.c| 56
2 files changed, 38 insertions(+), 25 deletions(-)
diff
Hi,
This patchset adds new interfaces to work with iohandlers. It adds:
int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque)
-- Specify io handlers for an fd
int remove_fd_handlers(int fd)
-- Remove fd handlers for fd (mark ioh for deletion)
int set_read_poll_fd_action(int fd, b
Am 23.12.2010 22:58, schrieb Nicholas A. Bellinger:
> On Tue, 2010-12-21 at 12:49 +1100, Benjamin Herrenschmidt wrote:
>>> Yep, so it appears that commit 89c0f6438d16 did introduce the bogus
>>> 'double complete' in scsi_read_complete, which I think was intended to
>>> handle residual counts for TY
Hi,
I can't see such a race window given that most qemu code runs
serialized anyway. If you call assign_fd_handlers() +
set_write_fd_action(false) in sequence I can't see how a select call
can happen inbetween ...
Not today, but later when we have threads doing this stuff?
Unlikely I thin
On 01/13/11 06:43, Markus Armbruster wrote:
> David Ahern writes:
>
>> make_device_config currently emits an error:
>>
>> make config-all-devices.mak
>> GEN x86_64-softmmu/config-devices.mak
>> /home/dsa/kvm/releases/qemu.git/make_device_config.sh: line 21:
>> /home/dsa/kvm/releases/qemu.g
On 01/13/11 02:57, Isaku Yamahata wrote:
> How about creating stub functions instead of #ifdefs?
> something like
>
> pc-stubs.c
> #ifndef CONFIG_VMWARE_VGA
> pci_vmsvga_init()
> {
> error ...
> }
> #endif
> #ifndef CONFIG_...
> ...
I wasn't trying to re-architect how the CONFIG_ is i
On (Thu) Jan 13 2011 [15:08:51], Gerd Hoffmann wrote:
> On 01/13/11 15:00, Amit Shah wrote:
> >On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote:
> >>On 01/13/11 14:00, Amit Shah wrote:
> >>> {
> >>>-return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write,
> >>>opaque);
> >>>+ass
On (Thu) Jan 13 2011 [14:59:26], Gerd Hoffmann wrote:
> >+int assign_fd_handlers(int fd,
> >+ IOCanReadHandler *fd_read_poll,
> >+ IOHandler *fd_read,
> >+ IOHandler *fd_write,
> >+ void *opaque);
> >+void remov
On (Thu) Jan 13 2011 [15:02:37], Gerd Hoffmann wrote:
> Hi,
>
> >+ioh->ops.fd_read_poll = ops->fd_read_poll;
> >+ioh->ops.fd_read = ops->fd_read;
> >+ioh->ops.fd_write = ops->fd_write;
>
> You can write this as "ioh->ops = *ops" btw.
>
> I guess the long-term plan (to be committed
On 01/13/11 15:00, Amit Shah wrote:
On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote:
On 01/13/11 14:00, Amit Shah wrote:
{
-return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque);
+assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque);
+set_read_poll
On 01/13/11 14:00, Amit Shah wrote:
Hi,
This patchset adds new interfaces to work with iohandlers. It adds:
int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque)
-- Specify io handlers for an fd
int remove_fd_handlers(int fd)
-- Remove fd handlers for fd (mark ioh for deletio
Hi,
+ioh->ops.fd_read_poll = ops->fd_read_poll;
+ioh->ops.fd_read = ops->fd_read;
+ioh->ops.fd_write = ops->fd_write;
You can write this as "ioh->ops = *ops" btw.
I guess the long-term plan (to be committed after killing the last user
of the old interface) is to store a pointer
On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote:
> On 01/13/11 14:00, Amit Shah wrote:
> > {
> >-return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque);
> >+assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque);
> >+set_read_poll_fd_action(fd, true);
> >+
On 01/13/11 14:00, Amit Shah wrote:
This function will be used to assign fd handlers. Future commits will
be enable each handler to be enabled/disabled individually.
Make qemu_set_fd_handler2() a wrapper to assign_fd_handlers().
remove_fd_handlers() removes all the assigned handlers and marks
On 01/13/11 14:00, Amit Shah wrote:
{
-return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque);
+assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque);
+set_read_poll_fd_action(fd, true);
+set_read_fd_action(fd, true);
+set_write_fd_action(fd, true);
David Ahern writes:
> make_device_config currently emits an error:
>
> make config-all-devices.mak
> GEN x86_64-softmmu/config-devices.mak
> /home/dsa/kvm/releases/qemu.git/make_device_config.sh: line 21:
> /home/dsa/kvm/releases/qemu.git/default-configs/pci.mak : No such file or
> director
Collect all the handlers in a IOHandlerOps struct instead of being
passed one at a time to each function.
Signed-off-by: Amit Shah
---
qemu-char.h |7 ++-
vl.c| 51 ---
2 files changed, 34 insertions(+), 24 deletions(-)
diff --gi
This function will be used to assign fd handlers. Future commits will
be enable each handler to be enabled/disabled individually.
Make qemu_set_fd_handler2() a wrapper to assign_fd_handlers().
remove_fd_handlers() removes all the assigned handlers and marks the
iohandler for deletion. It's a wr
Hi,
This patchset adds new interfaces to work with iohandlers. It adds:
int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque)
-- Specify io handlers for an fd
int remove_fd_handlers(int fd)
-- Remove fd handlers for fd (mark ioh for deletion)
int set_read_poll_fd_action(int fd, b
On Thu, Jan 13, 2011 at 12:46:57PM +0100, Fabien Chouteau wrote:
> On Windows, this is required to flush the remaining data in the IO stream,
> otherwise Gdb do not receive the last packet.
>
> Version 2:
>Fix linux-user build error.
Hi, It seems a bit odd to explicitely close for system mode
Add a get_iohandler() function instead of looking up the ioh twice in
qemu_set_fd_handler2().
Signed-off-by: Amit Shah
---
vl.c | 44 ++--
1 files changed, 26 insertions(+), 18 deletions(-)
diff --git a/vl.c b/vl.c
index 0292184..9e365f6 100644
--- a/vl
If an iohandler is asked to be enabled but the handler doesn't exist,
don't enable the handler.
This can be used to simplify the conditions in main_loop_wait().
Signed-off-by: Amit Shah
---
vl.c | 29 -
1 files changed, 20 insertions(+), 9 deletions(-)
diff --git
Each iohandler for an fd can now be individually enabled or disabled.
Signed-off-by: Amit Shah
---
qemu-char.h |4
vl.c| 58 ++
2 files changed, 58 insertions(+), 4 deletions(-)
diff --git a/qemu-char.h b/qemu-char.h
ind
On 13/01/11 10:13, Michal Suchanek wrote:
On 13 January 2011 00:34, Mateusz Loskot wrote:
On 12/01/11 17:15, Mateusz Loskot wrote:
On 12/01/11 16:48, Michal Suchanek wrote:
On 12 January 2011 16:21, Mateusz Loskotwrote:
Thinking of future, could anyone estimate when it will be possible
On 13 January 2011 01:31, Aurelien Jarno wrote:
> On Wed, Jan 12, 2011 at 03:05:10PM -0600, Peter Maydell wrote:
>> Actually, will
>> return ((a.high & 0x7fff) == 0x7fff) && (a.low >=
>> LIT64(0x4000));
>> do? Untested but I think it will do the right thing. I'm not sure
>
> The exp
Signed-off-by: Arun R Bharadwaj
Signed-off-by: Gautham R Shenoy
---
docs/async-support.txt | 141
1 files changed, 141 insertions(+), 0 deletions(-)
create mode 100644 docs/async-support.txt
diff --git a/docs/async-support.txt b/docs/async-supp
Remove all instances of CONFIG_THREAD, which is not used
anymore.
Signed-off-by: Arun R Bharadwaj
---
configure |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index a079a49..addf733 100755
--- a/configure
+++ b/configure
@@ -2456,7 +2456,6 @@ if t
This patch allows subsystems to create their own private
queues with associated pools of threads.
Signed-off-by: Arun R Bharadwaj
---
qemu-threadlets.c | 75 ++---
qemu-threadlets.h |4 +++
2 files changed, 58 insertions(+), 21 deletions(-)
This patch adds aio_signal_handler threadlet API. Earler
posix-aio-compat.c had its own signal handler code. Now
abstract this, in the later patch it is moved to a generic
code so that it can be used by other subsystems.
Signed-off-by: Arun R Bharadwaj
---
posix-aio-compat.c | 49 +
1 - 100 of 132 matches
Mail list logo
