Re: [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19

2011-02-01 Thread Gleb Natapov
On Tue, Feb 01, 2011 at 05:02:55PM -0600, Anthony Liguori wrote: > On 01/31/2011 03:02 AM, Gleb Natapov wrote: > >Currently linuxboot.bin and multiboot.bin option roms override int19 > >vector to intercept boot process. No sane option rom should do that. > >Provide bev entry instead that will be ca

Re: [Qemu-devel] Re: [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-01 Thread David Ahern
On 02/01/11 20:01, Juan Quintela wrote: > Blue Swirl wrote: >> On Tue, Feb 1, 2011 at 4:53 PM, Eduardo Habkost wrote: >>> Hi, >>> >>> This series makes CONFIG_VMWARE_VGA actually work (today we can't disable >>> the >>> option without getting a build error). >>> >>> It also add two new options

[Qemu-devel] Re: paravirtual mouse/tablet, v5

2011-02-01 Thread Peter Hutterer
sorry, late again. conference last week. On Thu, Jan 27, 2011 at 02:11:35PM +0100, Gerd Hoffmann wrote: > Next revision the pvmouse protocol. It is quite different now, I've > decided to move to a model with one message per updated value, > simliar to the linux input layer. There isn't a "mouse

[Qemu-devel] Reminder about your invitation from Sam Liao

2011-02-01 Thread Sam Liao (LinkedIn Invitations)
LinkedIn This invitation is awaiting your response: From Sam Liao -- (c) 2011, LinkedIn Corporation

[Qemu-devel] Re: [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-01 Thread Juan Quintela
Blue Swirl wrote: > On Tue, Feb 1, 2011 at 4:53 PM, Eduardo Habkost wrote: >> Hi, >> >> This series makes CONFIG_VMWARE_VGA actually work (today we can't disable the >> option without getting a build error). >> >> It also add two new options: CONFIG_VMMOUSE and CONFIG_VMPORT, for vmmouse.o >> and

[Qemu-devel] stable-0.14 is now open

2011-02-01 Thread Anthony Liguori
Please start sending patches and pull requests specifically against this branch. The 0.14.0-rc0 will be officially announced tomorrow once the mirrors propagate. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Mike Frysinger
On Tue, Feb 1, 2011 at 13:45, Peter Maydell wrote: > On 1 February 2011 18:16, Mike Frysinger wrote: >> On Tue, Feb 1, 2011 at 12:30, Peter Maydell wrote: >>> That's OK too, that would fall into my category (3). >> >> so the TB invalidation checking can be taken care of implicitly if i >> handled t

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Jan Kiszka
On 2011-02-01 16:54, Chris Wright wrote: > KVM upstream merge: status, plans, coordination > - Jan has a git tree, consolidating > - qemu-kvm io threading is still an issue > - Anthony wants to just merge > - concerns with non-x86 arch and merge > - concerns with big-bang patch merge and follow

[Qemu-devel] [PATCH v2 24/24] Fix a few coding style violations in cpus.c

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka No functional changes. Signed-off-by: Jan Kiszka --- cpus.c | 97 ++- 1 files changed, 58 insertions(+), 39 deletions(-) diff --git a/cpus.c b/cpus.c index 0d11a20..dd24fe8 100644 --- a/cpus.c +++ b/cpus.c @@ -138,

[Qemu-devel] [PATCH v2 09/24] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- cpus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 5dfc54e..312c7a2 100644 --- a/cpus.c +++ b/cpus.c @@ -607,8 +607,8 @@ static void *kvm_cpu_thread_fn(void *arg) qemu_mutex_lock(&qemu_gl

Re: [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19

2011-02-01 Thread Anthony Liguori
On 01/31/2011 03:02 AM, Gleb Natapov wrote: Currently linuxboot.bin and multiboot.bin option roms override int19 vector to intercept boot process. No sane option rom should do that. Provide bev entry instead that will be called by BIOS if option rom is selected for booting. Signed-off-by: Gleb N

Re: [Qemu-devel] [PULL 0/8] spice patch queue

2011-02-01 Thread Anthony Liguori
On 01/27/2011 04:12 AM, Gerd Hoffmann wrote: Hi, This is the updated spice patch queue. Changes: * rebased against latest master, solved conflicts (trace-events). * added one more locking bugfix, found by Alon. please pull, Gerd The following changes since commit 0fad6efce5d3f182

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-02-01 Thread Michael Roth
On 01/31/2011 08:41 AM, Michael Roth wrote: On 01/18/2011 08:13 AM, Anthony Liguori wrote: On 01/18/2011 08:02 AM, Gerd Hoffmann wrote: On 01/17/11 15:53, Michael Roth wrote: On 01/17/2011 07:53 AM, Gerd Hoffmann wrote: What is your plan to handle system-level queries+actions (such as reboot)

[Qemu-devel] [PATCH v2 10/24] kvm: Handle kvm_init_vcpu errors

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Do not ignore errors of kvm_init_vcpu, they are fatal. Signed-off-by: Jan Kiszka --- cpus.c | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index 312c7a2..8475757 100644 --- a/cpus.c +++ b/cpus.c @@ -273,12 +273,18 @@

[Qemu-devel] [PATCH v2 03/24] Stop current VCPU on synchronous reset requests

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka If some I/O operation ends up calling qemu_system_reset_request in VCPU context, we record this and inform the io-thread, but we do not terminate the VCPU loop. This can lead to fairly unexpected behavior if the triggering reset operation is supposed to work synchronously. Fix t

[Qemu-devel] [PATCH v2 12/24] Refactor signal setup functions in cpus.c

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Move {tcg,kvm}_init_ipi and block_io_signals to avoid prototypes, rename the former two to clarify that they deal with more than SIG_IPI. No functional changes - except for the tiny fixup of strerror usage. The forward declaration of sigbus_handler is just temporarily, it will b

[Qemu-devel] [PATCH v2 15/24] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Move qemu_kvm_eat_signals around and call it also when the IO-thread is not used. Do not yet process SIGBUS, will be armed in a separate step. Signed-off-by: Jan Kiszka --- cpus.c | 90 +--- 1 files changed, 52 inse

[Qemu-devel] [PATCH v2 22/24] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka The reset we issue on KVM_EXIT_SHUTDOWN implies that we should also leave the VCPU loop. As we now check for exit_request which is set by qemu_system_reset_request, this bug is no longer critical. Still it's an unneeded extra turn. Signed-off-by: Jan Kiszka --- kvm-all.c |

[Qemu-devel] [PATCH v2 02/24] Prevent abortion on multiple VCPU kicks

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka If we call qemu_cpu_kick more than once before the target was able to process the signal, pthread_kill will fail, and qemu will abort. Prevent this by avoiding the redundant signal. This logic can be found in qemu-kvm as well. Signed-off-by: Jan Kiszka --- cpu-defs.h |1 +

[Qemu-devel] [PATCH v2 06/24] Leave inner main_loop faster on pending requests

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka If there is any pending request that requires us to leave the inner loop if main_loop, makes sure we do this as soon as possible by enforcing non-blocking IO processing. At this change, move variable definitions out of the inner loop to improve readability. Signed-off-by: Jan K

[Qemu-devel] [PATCH v2 19/24] Introduce VCPU self-signaling service

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU context. First user will be kvm. Signed-off-by: Jan Kiszka --- cpus.c| 21 + qemu-common.h |1 + 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c i

[Qemu-devel] [PATCH v2 05/24] Trigger exit from cpu_exec_all on pending IO events

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Except for timer events, we currently do not leave the loop over all VCPUs if an IO event was filed. That may cause unexpected IO latencies under !CONFIG_IOTHREAD in SMP scenarios. Fix it by setting the global exit_request which breaks the loop. Signed-off-by: Jan Kiszka --- c

[Qemu-devel] [PATCH v2 16/24] Set up signalfd under !CONFIG_IOTHREAD

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Will be required for SIGBUS handling. For obvious reasons, this will remain a nop on Windows hosts. Signed-off-by: Jan Kiszka Reviewed-by: Paolo Bonzini --- Makefile.objs |2 +- cpus.c| 117 +++-- 2 files change

[Qemu-devel] [PATCH v2 08/24] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Signed-off-by: Jan Kiszka --- kvm-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 9976762..1a55a10 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -219,6 +219,7 @@ int kvm_init_vcpu(CPUState *env) mmap_size = kvm_ioctl

[Qemu-devel] [PATCH v2 20/24] kvm: Unconditionally reenter kernel after IO exits

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka KVM requires to reenter the kernel after IO exits in order to complete instruction emulation. Failing to do so will leave the kernel state inconsistently behind. To ensure that we will get back ASAP, we issue a self-signal that will cause KVM_RUN to return once the pending operat

[Qemu-devel] [PATCH v2 14/24] kvm: Refactor qemu_kvm_eat_signals

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka We do not use the timeout, so drop its logic. As we always poll our signals, we do not need to drop the global lock. Removing those calls allows some further simplifications. Also fix the error processing of sigpending at this chance. Signed-off-by: Jan Kiszka Reviewed-by: Paol

[Qemu-devel] [PATCH v2 18/24] kvm: Add MCE signal support for !CONFIG_IOTHREAD

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Currently, we only configure and process MCE-related SIGBUS events if CONFIG_IOTHREAD is enabled. The groundwork is laid, we just need to factor out the required handler registration and system configuration. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin

[Qemu-devel] [PATCH v2 13/24] kvm: Set up signal mask also for !CONFIG_IOTHREAD

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Block SIG_IPI, unblock it during KVM_RUN, just like in io-thread mode. It's unused so far, but this infrastructure will be required for self-IPIs and to process SIGBUS plus, in KVM mode, SIGIO and SIGALRM. As Windows doesn't support signal services, we need to provide a stub for

[Qemu-devel] [PATCH v2 00/24] [uq/master] Patch queue, part II

2011-02-01 Thread Jan Kiszka
Version 2 of part II. Changes: - Fixed "Unconditionally reenter kernel after IO exits" to take self-INIT into account - Fixed misplaced hunk in "Fix race between timer signals and vcpu entry under !IOTHREAD" (rebase artifact) - Factor out block_synchronous_signals (analogue to block_io_sig

[Qemu-devel] [PATCH v2 01/24] kvm: x86: Fix build in absence of KVM_CAP_ASYNC_PF

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Reported by Stefan Hajnoczi. Signed-off-by: Jan Kiszka --- target-i386/kvm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 8e8880a..05010bb 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -167,7

[Qemu-devel] [PATCH v2 04/24] Process vmstop requests in IO thread

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka A pending vmstop request is also a reason to leave the inner main loop. So far we ignored it, and pending stop requests issued over VCPU threads were simply ignored. Signed-off-by: Jan Kiszka --- vl.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) dif

[Qemu-devel] [PATCH v2 21/24] kvm: Remove static return code of kvm_handle_io

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Improve the readability of the exit dispatcher by moving the static return value of kvm_handle_io to its caller. Signed-off-by: Jan Kiszka --- kvm-all.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index d961697

[Qemu-devel] [PATCH v2 07/24] Flatten the main loop

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka First of all, vm_can_run is a misnomer, it actually means "no request pending". Moreover, there is no need to check all pending requests twice, the first time via the inner loop check and then again when actually processing the requests. We can simply remove the inner loop and do

[Qemu-devel] [PATCH v2 23/24] Refactor kvm&tcg function names in cpus.c

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Pure interface cosmetics: Ensure that only kvm core services (as declared in kvm.h) start with "kvm_". Prepend "qemu_" to those that violate this rule in cpus.c. Also rename the corresponding tcg functions for the sake of consistency. Signed-off-by: Jan Kiszka --- cpus.c | 1

[Qemu-devel] [PATCH v2 17/24] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for exit_request on vcpu entry and timer signals arriving before KVM starts to catch them. Plug it by blocking both timer related signals also on !CONFIG_IOTHREAD and process those via signalfd. As this f

[Qemu-devel] [PATCH v2 11/24] kvm: Provide sigbus services arch-independently

2011-02-01 Thread Jan Kiszka
From: Jan Kiszka Provide arch-independent kvm_on_sigbus* stubs to remove the #ifdef'ery from cpus.c. This patch also fixes --disable-kvm build by providing the missing kvm_on_sigbus_vcpu kvm-stub. Signed-off-by: Jan Kiszka Reviewed-by: Paolo Bonzini Acked-by: Alexander Graf --- cpus.c

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Anthony Liguori
On 02/01/2011 11:03 AM, Jan Kiszka wrote: On 2011-02-01 17:53, Anthony Liguori wrote: On 02/01/2011 10:36 AM, Jan Kiszka wrote: On 2011-02-01 16:54, Chris Wright wrote: KVM upstream merge: status, plans, coordination - Jan has a git tree, consolidating - qemu-kvm io threadin

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Mike Frysinger
On Tue, Feb 1, 2011 at 05:31, Peter Maydell wrote: > So for instance here: > > +static void gen_hwloop_check(DisasContext *dc) > +{ > +    bool loop1, loop0; > +    int endl; > + > +    loop1 = (dc->pc == dc->env->lbreg[1]); > +    loop0 = (dc->pc == dc->env->lbreg[0]); > > I suspect that this chec

Re: [Qemu-devel] [PATCHv3 0.14] vhost: force vhost off for non-MSI guests

2011-02-01 Thread Anthony Liguori
On 02/01/2011 02:13 PM, Michael S. Tsirkin wrote: When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes more context switches and higher CPU utilization than userspace virtio which handles networking in the same thread. We'll need to

Re: [Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Anthony Liguori
On 02/01/2011 11:34 AM, Jan Kiszka wrote: On 2011-02-01 18:20, Anthony Liguori wrote: On 02/01/2011 11:03 AM, Jan Kiszka wrote: On 2011-02-01 17:53, Anthony Liguori wrote: On 02/01/2011 10:36 AM, Jan Kiszka wrote: On 2011-02-01 16:54, Chris Wright wrote:

[Qemu-devel] Re: [PATCHv3 0.14] vhost: force vhost off for non-MSI guests

2011-02-01 Thread Alex Williamson
On Tue, 2011-02-01 at 22:13 +0200, Michael S. Tsirkin wrote: > When MSI is off, each interrupt needs to be bounced through the io > thread when it's set/cleared, so vhost-net causes more context switches and > higher CPU utilization than userspace virtio which handles networking in > the same threa

[Qemu-devel] Re: [PATCH] make tsc stable over migration and machine start

2011-02-01 Thread Jan Kiszka
On 2011-02-01 20:17, Glauber Costa wrote: > If the machine is stopped, we should not record two different tsc values > upon a save operation. The same problem happens with kvmclock. > > But kvmclock is taking a different diretion, being now seen as a separate > device. Since this is unlikely to ha

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Richard W.M. Jones
On Tue, Feb 01, 2011 at 11:04:47PM +0300, Vasiliy G Tolstov wrote: > On Tue, 2011-02-01 at 16:04 +, Richard W.M. Jones wrote: > > > There are some experimental patches to libguestfs to do live > > filesystem and partition manipulations now: > > > > https://www.redhat.com/archives/libguestfs

[Qemu-devel] [PATCHv3 0.14] vhost: force vhost off for non-MSI guests

2011-02-01 Thread Michael S. Tsirkin
When MSI is off, each interrupt needs to be bounced through the io thread when it's set/cleared, so vhost-net causes more context switches and higher CPU utilization than userspace virtio which handles networking in the same thread. We'll need to fix this by adding level irq support in kvm irqfd,

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Vasiliy G Tolstov
On Tue, 2011-02-01 at 16:04 +, Richard W.M. Jones wrote: > There are some experimental patches to libguestfs to do live > filesystem and partition manipulations now: > > https://www.redhat.com/archives/libguestfs/2011-January/msg00096.html > > Rich. > Sorry, but i can't found any info ab

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 20:58, Aurelien Jarno wrote: > On Tue, Feb 01, 2011 at 07:35:01PM +0100, Alexander Graf wrote: >> When using level based interrupts, the interrupt is treated the same as an >> edge triggered one: leaving the line up does not retrigger the interrupt. >> >> In fact, when not lowe

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Aurelien Jarno
On Tue, Feb 01, 2011 at 07:35:01PM +0100, Alexander Graf wrote: > When using level based interrupts, the interrupt is treated the same as an > edge triggered one: leaving the line up does not retrigger the interrupt. > > In fact, when not lowering the line, we won't ever get a new interrupt inside

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Peter Maydell
On 1 February 2011 17:20, Mike Frysinger wrote: > On Tue, Feb 1, 2011 at 05:31, Peter Maydell wrote: >> I suspect that this check of pc against the lbreg[] >> values should be being done in the generated code, >> not at translate time. > the way i'm doing it atm i believe is safe.  if a lbreg cha

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Anthony Liguori
On 02/01/2011 10:36 AM, Jan Kiszka wrote: On 2011-02-01 16:54, Chris Wright wrote: KVM upstream merge: status, plans, coordination - Jan has a git tree, consolidating - qemu-kvm io threading is still an issue - Anthony wants to just merge - concerns with non-x86 arch and merge - concer

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Jan Kiszka
On 2011-02-01 18:20, Anthony Liguori wrote: > On 02/01/2011 11:03 AM, Jan Kiszka wrote: >> On 2011-02-01 17:53, Anthony Liguori wrote: >> >>> On 02/01/2011 10:36 AM, Jan Kiszka wrote: >>> On 2011-02-01 16:54, Chris Wright wrote: > KVM upstream merge: status, pla

[Qemu-devel] [PATCH] make tsc stable over migration and machine start

2011-02-01 Thread Glauber Costa
If the machine is stopped, we should not record two different tsc values upon a save operation. The same problem happens with kvmclock. But kvmclock is taking a different diretion, being now seen as a separate device. Since this is unlikely to happen with the tsc, I am taking the approach here of

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Michael Roth
On 02/01/2011 08:41 AM, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:36 PM, Jes Sorensen wrote: On 02/01/11 15:34, Stefan Hajnoczi wrote: On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen wrote: I have to admit you lost me here, where do you get that 500ms time from? Is that the XMLRPC polling

Re: [Qemu-devel] [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-01 Thread Blue Swirl
On Tue, Feb 1, 2011 at 4:53 PM, Eduardo Habkost wrote: > Hi, > > This series makes CONFIG_VMWARE_VGA actually work (today we can't disable the > option without getting a build error). > > It also add two new options: CONFIG_VMMOUSE and CONFIG_VMPORT, for vmmouse.o > and vmport.o. Nack, see the li

[Qemu-devel] [PATCH 1/4] Add config-devices.h again

2011-02-01 Thread Eduardo Habkost
This reverts part of commit a992fe3d0fc185112677286f7a02204d8245b61e. We do have code that needs #ifdefs depending on the list of enabled devices, but currently that code breaks when we try to disable a feature that is enabled by default. For example, if we try to disable CONFIG_VMWARE_VGA, we ge

Re: [Qemu-devel] [PATCH 1/3] use nanoseconds everywhere for timeout computation

2011-02-01 Thread Aurelien Jarno
On Mon, Jan 31, 2011 at 04:17:52PM -0600, Anthony Liguori wrote: > On 01/31/2011 03:51 PM, Paolo Bonzini wrote: >> Suggested by Aurelien Jarno. >> >> Signed-off-by: Paolo Bonzini >> > > Something I've found is that we have a lot of bugs that are the result > of unit conversions when the unit

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Peter Maydell
On 1 February 2011 18:16, Mike Frysinger wrote: > On Tue, Feb 1, 2011 at 12:30, Peter Maydell wrote: >> That's OK too, that would fall into my category (3). > > so the TB invalidation checking can be taken care of implicitly if i > handled things in cpu_get_tb_cpu_state() ?  that would be nice. I

Re: [Qemu-devel] [PATCH 1/3] use nanoseconds everywhere for timeout computation

2011-02-01 Thread Aurelien Jarno
On Mon, Jan 31, 2011 at 10:51:17PM +0100, Paolo Bonzini wrote: > Suggested by Aurelien Jarno. > > Signed-off-by: Paolo Bonzini > --- > qemu-timer.c | 30 +++--- > 1 files changed, 15 insertions(+), 15 deletions(-) Reviewed-by: Aurelien Jarno > diff --git a/qemu-timer

[Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
When using level based interrupts, the interrupt is treated the same as an edge triggered one: leaving the line up does not retrigger the interrupt. In fact, when not lowering the line, we won't ever get a new interrupt inside the guest. So let's always retrigger an interrupt as soon as the OS ack

Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port

2011-02-01 Thread Mike Frysinger
On Tue, Feb 1, 2011 at 12:30, Peter Maydell wrote: > On 1 February 2011 17:20, Mike Frysinger wrote: >> On Tue, Feb 1, 2011 at 05:31, Peter Maydell wrote: >>> I suspect that this check of pc against the lbreg[] >>> values should be being done in the generated code, >>> not at translate time. >> >>

Re: [Qemu-devel] [PATCH 1/4] Add config-devices.h again

2011-02-01 Thread Stefan Weil
Am 01.02.2011 17:53, schrieb Eduardo Habkost: This reverts part of commit a992fe3d0fc185112677286f7a02204d8245b61e. We do have code that needs #ifdefs depending on the list of enabled devices, but currently that code breaks when we try to disable a feature that is enabled by default. For exampl

[Qemu-devel] Re: [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Blue Swirl
Thanks, applied. On Tue, Feb 1, 2011 at 3:54 PM, Peter Maydell wrote: > Suppress a gcc array bounds overrun warning when filling in the SPARC > signal frame by adjusting our definition of the structure so that the > fp and callers_pc membes are part of the ins[] array rather than > separate field

[Qemu-devel] Re: [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-02-01 Thread Yoshiaki Tamura
Paolo, I refactored the savevm functions. Could you give me your comments? Thanks, Yoshi diff --git a/savevm.c b/savevm.c index 5418280..90aae55 100644 --- a/savevm.c +++ b/savevm.c @@ -1602,29 +1602,68 @@ bool qemu_savevm_state_blocked(Monitor *mon) return false; } -int qemu_savevm_sta

Re: [Qemu-devel] [PATCH v2] SPARC: Fix Leon3 cache control

2011-02-01 Thread Blue Swirl
Thanks, applied. On Mon, Jan 31, 2011 at 10:36 AM, Fabien Chouteau wrote: > The "leon3_cache_control_int" (op_helper.c) function is called within leon3.c > which leads to segfault error with the global "env". > > Now cache control is a CPU feature and everything is handled in op_helper.c. > > Sig

Re: [Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Blue Swirl
On Tue, Feb 1, 2011 at 4:00 PM, Peter Maydell wrote: > On 1 February 2011 15:54, Peter Maydell wrote: >> --- a/linux-user/signal.c >> +++ b/linux-user/signal.c >> @@ -1817,9 +1817,10 @@ struct target_sigcontext { >>  /* A Sparc stack frame */ >>  struct sparc_stackf { >>         abi_ulong locals[

[Qemu-devel] Re: [PATCH] hw/slavio_intctl.c: fix gcc warning about array bounds overrun

2011-02-01 Thread Blue Swirl
Thanks, applied. On Mon, Jan 31, 2011 at 10:42 AM, Peter Maydell wrote: > The Ubuntu 10.10 gcc for ARM complains that we might be overrunning > the cpu_irqs[][] array: silence this by correcting the bounds on the > loop. (In fact we would not have overrun the array because bit > MAX_PILS in pil_p

[Qemu-devel] KVM: Windows 64-bit troubles with user space irqchip

2011-02-01 Thread Jan Kiszka
Hi, testing my KVM patches, I noticed that none of the 64-bit Windows versions I have around (early Win7 & 2003 server) boot in KVM mode when using 2 or more VCPUs and the user space irqchip. This applies to both upstream KVM and qemu-kvm, with our without any of my current patches. A subtle diffe

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Christoph Hellwig
On Tue, Feb 01, 2011 at 05:36:13PM +0100, Jan Kiszka wrote: > kvm_cpu_exec/kvm_run, and start wondering "What needs to be done to > upstream so that qemu-kvm could use that implementation?". If they > differ, the reasons need to be understood and patched away, either by > fixing/enhancing upstream

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Aurelien Jarno
On Tue, Feb 01, 2011 at 06:10:56PM +0100, Alexander Graf wrote: > > On 01.02.2011, at 18:06, Aurelien Jarno wrote: > > > On Tue, Feb 01, 2011 at 05:53:43PM +0100, Alexander Graf wrote: > >> > >> On 01.02.2011, at 17:34, Aurelien Jarno wrote: > >> > >>> On Tue, Feb 01, 2011 at 03:51:32PM +0100,

[Qemu-devel] [PATCH 2/4] skip pci_vmsvga_init() calls if CONFIG_VMWARE_VGA is disabled

2011-02-01 Thread Eduardo Habkost
I was planning to add the check for CONFIG_VMWARE to the command-line parsing code in vl.c, but vl.c is not built by Makefile.target, so we can't test for a per-target config option there. It is not the best solution, but it is better than simply having a CONFIG_VMWARE_VGA option that doesn't work

[Qemu-devel] [PATCH 3/4] add CONFIG_VMMOUSE option

2011-02-01 Thread Eduardo Habkost
This will allow vmmouse to be disabled at build time if necessary. Signed-off-by: Eduardo Habkost --- Makefile.target|5 - default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/pc.c|2 ++ 4 files c

[Qemu-devel] [PATCH 0/4] fix/add CONFIG_* options for VMWare device emulation

2011-02-01 Thread Eduardo Habkost
Hi, This series makes CONFIG_VMWARE_VGA actually work (today we can't disable the option without getting a build error). It also add two new options: CONFIG_VMMOUSE and CONFIG_VMPORT, for vmmouse.o and vmport.o. Eduardo Habkost (4): Add config-devices.h again skip pci_vmsvga_init() calls if

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 17:34, Aurelien Jarno wrote: > On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: >> When using level based interrupts, the interrupt is treated the same as an >> edge triggered one: leaving the line up does not retrigger the interrupt. >> >> In fact, when not lowe

[Qemu-devel] Re: KVM call minutes for Feb 1

2011-02-01 Thread Jan Kiszka
On 2011-02-01 17:53, Anthony Liguori wrote: > On 02/01/2011 10:36 AM, Jan Kiszka wrote: >> On 2011-02-01 16:54, Chris Wright wrote: >> >>> KVM upstream merge: status, plans, coordination >>> - Jan has a git tree, consolidating >>> - qemu-kvm io threading is still an issue >>> - Anthony wants to

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 18:06, Aurelien Jarno wrote: > On Tue, Feb 01, 2011 at 05:53:43PM +0100, Alexander Graf wrote: >> >> On 01.02.2011, at 17:34, Aurelien Jarno wrote: >> >>> On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: When using level based interrupts, the interrupt is t

[Qemu-devel] [PATCH 4/4] add CONFIG_VMPORT option

2011-02-01 Thread Eduardo Habkost
This allows vmport to be easily enabled or disabled at build time. Signed-off-by: Eduardo Habkost --- Makefile.target|3 ++- default-configs/i386-softmmu.mak |2 ++ default-configs/x86_64-softmmu.mak |2 ++ hw/pc_piix.c |2 ++ 4 files c

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Aurelien Jarno
On Tue, Feb 01, 2011 at 05:53:43PM +0100, Alexander Graf wrote: > > On 01.02.2011, at 17:34, Aurelien Jarno wrote: > > > On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: > >> When using level based interrupts, the interrupt is treated the same as an > >> edge triggered one: leaving

Re: [Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Aurelien Jarno
On Tue, Feb 01, 2011 at 03:51:32PM +0100, Alexander Graf wrote: > When using level based interrupts, the interrupt is treated the same as an > edge triggered one: leaving the line up does not retrigger the interrupt. > > In fact, when not lowering the line, we won't ever get a new interrupt inside

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Michael Roth
On 02/01/2011 04:58 AM, jes.soren...@redhat.com wrote: From: Jes Sorensen Implement freeze/thaw support in the guest, allowing the host to request the guest freezes all it's file systems before a live snapshot is performed. - fsfreeze(): Walk the list of mounted local real file systems,

Re: [Qemu-devel] [PATCH 0/2] virtagent - fsfreeze support

2011-02-01 Thread Richard W.M. Jones
On Tue, Feb 01, 2011 at 02:25:12PM +0300, Vasiliy G Tolstov wrote: > On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote: > > From: Jes Sorensen > > > > Hi > > > > This is a first attempt to add fsfreeze support to virtagent. The idea > > is for the guest agent to walk the list of l

Re: [Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Peter Maydell
On 1 February 2011 15:54, Peter Maydell wrote: > --- a/linux-user/signal.c > +++ b/linux-user/signal.c > @@ -1817,9 +1817,10 @@ struct target_sigcontext { >  /* A Sparc stack frame */ >  struct sparc_stackf { >         abi_ulong locals[8]; > -        abi_ulong ins[6]; > -        struct sparc_stack

Re: [Qemu-devel] [PATCH 0.14] tap: safe sndbuf default

2011-02-01 Thread Anthony Liguori
On 02/01/2011 06:25 AM, Michael S. Tsirkin wrote: With current sndbuf default value, a blocked target guest can prevent another guest from transmitting any packets. While current sndbuf value (1M) is reported to help some UDP based workloads, the default should be safe (0). Can you be more

[Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc

2011-02-01 Thread Peter Maydell
Suppress a gcc array bounds overrun warning when filling in the SPARC signal frame by adjusting our definition of the structure so that the fp and callers_pc membes are part of the ins[] array rather than separate fields; since qemu has no need to access the fields individually there is no need to

[Qemu-devel] KVM call minutes for Feb 1

2011-02-01 Thread Chris Wright
KVM upstream merge: status, plans, coordination - Jan has a git tree, consolidating - qemu-kvm io threading is still an issue - Anthony wants to just merge - concerns with non-x86 arch and merge - concerns with big-bang patch merge and following stability - post 0.14 conversion to glib mainloop

[Qemu-devel] [PATCH 1/7] ahci: split ICH9 from core

2011-02-01 Thread Alexander Graf
From: Sebastian Herbszt There are multiple ahci devices out there. The currently implemented ich-9 is only one of the many. So let's split that one out into a separate file to stress the difference. Signed-off-by: Sebastian Herbszt Signed-off-by: Alexander Graf --- Makefile.objs |1 + hw/

[Qemu-devel] [PATCH] Make spice dummy functions inline to fix calls not checking return values

2011-02-01 Thread Jes . Sorensen
From: Jes Sorensen qemu_spice_set_passwd() and qemu_spice_set_pw_expire() dummy functions needs to be inline, in order to handle the case where they are called without checking the return value. Signed-off-by: Jes Sorensen --- ui/qemu-spice.h | 12 ++-- 1 files changed, 10 insertions

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 16:05, Anthony Liguori wrote: > On 02/01/2011 08:37 AM, Alexander Graf wrote: >> >> o SeaBIOS update for 0.14 - I'd like to see an AHCI boot capable version >> there >> > > I'll update to the latest release before I fork today. Last time I checked, AHCI was disabled by de

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Anthony Liguori
On 02/01/2011 08:37 AM, Alexander Graf wrote: o SeaBIOS update for 0.14 - I'd like to see an AHCI boot capable version there I'll update to the latest release before I fork today. Regards, Anthony Liguori Alex

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Jes Sorensen
On 02/01/11 15:48, Adam Litke wrote: > On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote: >> +/* >> + * va_fsfreeze(): Walk list of mounted file systems in the guest, and >> + * freeze the ones which are real local file systems. >> + * rpc return values: Number of file systems froz

[Qemu-devel] [PATCH 2/7] ahci: add license header in ahci.h

2011-02-01 Thread Alexander Graf
Due to popular request, this patch adds a license header to ahci.h Signed-off-by: Alexander Graf --- hw/ide/ahci.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h index 63ef785..d65b5e3 100644 --- a/hw/ide/ahci.h +++ b

[Qemu-devel] [PATCH 7/7] ahci: work around bug with level interrupts

2011-02-01 Thread Alexander Graf
When using level based interrupts, the interrupt is treated the same as an edge triggered one: leaving the line up does not retrigger the interrupt. In fact, when not lowering the line, we won't ever get a new interrupt inside the guest. So let's always retrigger an interrupt as soon as the OS ack

[Qemu-devel] [PATCH 3/7] ahci: split ICH and AHCI even more

2011-02-01 Thread Alexander Graf
Sebastian's patch already did a pretty good job at splitting up ICH-9 AHCI code and the AHCI core. We need some more though. Copyright was missing, the lspci dump belongs to ICH-9, we don't need the AHCI core to have its own qdev device duplicate. So let's split them a bit more in this patch, maki

[Qemu-devel] [PATCH 6/7] ahci: make number of ports runtime determined

2011-02-01 Thread Alexander Graf
Different AHCI controllers have a different number of ports, so the core shouldn't care about the amount of ports available. This patch makes the number of ports available to the AHCI core runtime configurable, allowing us to have multiple different AHCI implementations with different amounts of p

[Qemu-devel] [PATCH 5/7] ahci: Implement HBA reset

2011-02-01 Thread Alexander Graf
The ahci code was missing its soft reset functionality. This wasn't really an issue for Linux guests, but Windows gets confused when the controller doesn't reset when it tells it so. Using this patch I can now successfully boot Windows 7 from AHCI using AHCI enabled SeaBIOS. Signed-off-by: Alexan

[Qemu-devel] [PATCH 4/7] ahci: send init d2h fis on fis enable

2011-02-01 Thread Alexander Graf
The drive sends a d2h init fis on initialization. Usually, the guest doesn't receive fises yet at that point though, so the delivery is deferred. Let's reflect that by sending the init fis on fis receive enablement. Signed-off-by: Alexander Graf --- v1 -> v2: - add comment on d2h delay hack

[Qemu-devel] [PATCH 0/7] Some more AHCI work v2

2011-02-01 Thread Alexander Graf
Clearly, AHCI as is is not perfect yet (intentionally, release early, release often, remember?). This patch set makes it work with SeaBIOS so booting Windows 7 works flawlessly for me. it also adds some speedups and fixes a level based interrupts, rendering ahci useful on PPC targets. In preparati

[Qemu-devel] Re: [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Adam Litke
On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote: > +/* > + * va_fsfreeze(): Walk list of mounted file systems in the guest, and > + * freeze the ones which are real local file systems. > + * rpc return values: Number of file systems frozen, -1 on error. > + */ > +static xmlrpc_va

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:37, Jan Kiszka wrote: > On 2011-02-01 15:21, Jan Kiszka wrote: >> On 2011-02-01 15:10, Marcelo Tosatti wrote: >>> On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: On 2011-02-01 14:48, Marcelo Tosatti wrote: > On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka

Re: [Qemu-devel] [PATCH 1/2] Add virtagent file system freeze/thaw

2011-02-01 Thread Stefan Hajnoczi
On Tue, Feb 1, 2011 at 2:36 PM, Jes Sorensen wrote: > On 02/01/11 15:34, Stefan Hajnoczi wrote: >> On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen wrote: >>> I have to admit you lost me here, where do you get that 500ms time from? >>> Is that the XMLRPC polling time or? I just used the example code

[Qemu-devel] Re: [PATCH 14/22] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-01 Thread Jan Kiszka
On 2011-02-01 15:21, Jan Kiszka wrote: > On 2011-02-01 15:10, Marcelo Tosatti wrote: >> On Tue, Feb 01, 2011 at 02:58:02PM +0100, Jan Kiszka wrote: >>> On 2011-02-01 14:48, Marcelo Tosatti wrote: On Tue, Feb 01, 2011 at 02:32:38PM +0100, Jan Kiszka wrote: > On 2011-02-01 13:47, Marcelo Tos

Re: [Qemu-devel] Re: KVM call agenda for Feb 1

2011-02-01 Thread Alexander Graf
On 01.02.2011, at 13:56, Luiz Capitulino wrote: > On Tue, 1 Feb 2011 10:53:21 -0200 > Luiz Capitulino wrote: > >> On Mon, 31 Jan 2011 15:39:22 -0600 >> Anthony Liguori wrote: >> >>> On 01/31/2011 12:10 PM, Jan Kiszka wrote: On 2011-01-31 11:02, Juan Quintela wrote: > Please sen

  1   2   >