Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-14 Thread Paolo Bonzini
On 02/13/2011 08:57 PM, Anthony Liguori wrote: It shouldn't be able to dead lock if the locking is designed right. As an aside, one advantage of the qemuthread wrappers is that we can add lockdep mechanisms. (It's true that these could be added to glib as well, but getting stuff into glib

[Qemu-devel] [PATCH] target-arm: fix support for vrecpe.

2011-02-14 Thread Christophe Lyon
Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon christophe.l...@st.com --- target-arm/helper.c | 72 ++ 1 files changed, 60 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c

[Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Kevin Wolf
Am 13.02.2011 19:08, schrieb Anthony Liguori: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with (hopefully) all of the hard problems solved. There is only one remaining thing to attack before posting for inclusion and that's events. Here's my

Re: [Qemu-devel] [RFC][PATCH v6 00/23] virtagent: host/guest RPC communication agent

2011-02-14 Thread Gerd Hoffmann
Hi, A brain-dump on how we're planning to do this. I tried to keep it concise, but that only went so far :) We extend qemu-va, the virtagent guest agent, to be able to create a unix socket in the guest that listens for connections. [ ... ] 1) There may be user-level RPCs that are

[Qemu-devel] [RFC] Some more io-thread optimizations

2011-02-14 Thread Jan Kiszka
Hi, patch below further reduces the io-thread overhead in tcg mode so that specifically emulating smp boxes gets noticeably faster. Its essence: poll the file descriptors until select returns 0, keeping the global mutex locked. This reduces ping pong with the vcpu threads, most noticeably in tcg

[Qemu-devel] Ping: [PATCH] Handle icount for powerpc tbl/tbu/decr load and store.

2011-02-14 Thread Tristan Gingold
Potential reviewers CC: On Feb 8, 2011, at 10:59 AM, Tristan Gingold wrote: Handle option '-icount X' on powerpc targets. Signed-off-by: Tristan Gingold ging...@adacore.com --- target-ppc/translate_init.c | 36 1 files changed, 36 insertions(+), 0

[Qemu-devel] [PATCH V6 4/4 resend] nmi: report error(QError) when the cpu-index is invalid

2011-02-14 Thread Lai Jiangshan
When cpu-index is found invalid in runtime, it will report QERR_INVALID_PARAMETER_VALUE. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/monitor.c b/monitor.c index 1b1c0ba..82935f0 100644 --- a/monitor.c +++ b/monitor.c @@ -2563,6 +2563,7 @@ static int do_inject_nmi(Monitor

[Qemu-devel] [PATCH V6 1/4 resend] nmi: convert cpu_index to cpu-index

2011-02-14 Thread Lai Jiangshan
cpu-index which uses hyphen is better name. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/hmp-commands.hx b/hmp-commands.hx index 5d4cb9e..e43ac7c 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -721,7 +721,7 @@ ETEXI #if defined(TARGET_I386) { .name

[Qemu-devel] [PATCH V6 2/4 resend] nmi: make cpu-index argument optional

2011-02-14 Thread Lai Jiangshan
When the argument cpu-index is not given, then nmi command will inject NMI on all CPUs. This simulate the nmi button on physical machine. Note: it will allow non-argument nmi command and change the human monitor behavior. Thanks to Markus Armbruster for correcting the logic detecting

[Qemu-devel] [PATCH V6 3/4 resend] qmp, nmi: convert do_inject_nmi() to QObject

2011-02-14 Thread Lai Jiangshan
Make we can inject NMI via qemu-monitor-protocol. We use inject-nmi for the qmp command name, the meaning is clearer. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/hmp-commands.hx b/hmp-commands.hx index b2c6cd6..6d3e7d2 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@

[Qemu-devel] Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index

2011-02-14 Thread Lai Jiangshan
On 02/09/2011 07:48 PM, Luiz Capitulino wrote: You should use Anthony's tree: git://git.qemu.org/qemu.git Done, thank you for your concern and patience. see my sent emails: [PATCH V6 1/4 resend] [PATCH V6 2/4 resend] [PATCH V6 3/4 resend] [PATCH V6 4/4 resend] Thanks again. Lai

[Qemu-devel] [PATCH v2 0/2] target-arm: fix Neon VUZP, VZIP instructions

2011-02-14 Thread Peter Maydell
This patch series fixes bugs in the Neon VZIP and VUZP instructions by abandoning the existing inline implementations in favour of calling out to straightforward helper functions. The inline routines could generate 50+ TCG ops each, which is well over the recommended limit in tcg/README for using

[Qemu-devel] [PATCH v2 2/2] target-arm: Move Neon VZIP to helper functions

2011-02-14 Thread Peter Maydell
Move the implementation of the Neon VUZP unzip instruction from inline code to helper functions. (At 50+ TCG ops it was well over the recommended limit for coding inline.) The helper implementations also give the correct answers where the inline implementation did not. Signed-off-by: Peter

[Qemu-devel] [PATCH v2 1/2] target-arm: Move Neon VUZP to helper functions

2011-02-14 Thread Peter Maydell
Move the implementation of the Neon VUZP unzip instruction from inline code to helper functions. (At 50+ TCG ops it was well over the recommended limit for coding inline.) The helper implementations also fix the handling of the quadword version of the instruction. Signed-off-by: Peter Maydell

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-14 Thread Gleb Natapov
On Sun, Feb 13, 2011 at 01:38:12PM -0600, Anthony Liguori wrote: On 02/13/2011 12:08 PM, Gleb Natapov wrote: On Sun, Feb 13, 2011 at 10:56:30AM -0600, Anthony Liguori wrote: qemu -device i440fx,id=nb -device piix3,id=sb,chipset=nb -device ioapic,id=ioapic,chipset=sb -device

Re: [Qemu-devel] [PATCH] target-arm: fix support for vrecpe.

2011-02-14 Thread Christophe Lyon
On 14.02.2011 10:46, Christophe Lyon wrote: Now use the same algorithm as described in the ARM ARM. oops sorry, I have sent the wrong patch. Please ignore this version. Christophe.

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc '

2011-02-14 Thread Gerd Hoffmann
On 01/31/11 21:43, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of setting the VNC password to an empty string from disabling login to disabling authentication. This commit refactors

[Qemu-devel] Re: [RFC] prep: enable irq sharing on ide again

2011-02-14 Thread Gerd Hoffmann
On 02/08/11 00:26, Alexander Graf wrote: The new ISA infrastructure checks for potential irq sharing bugs on interrupt lines, because usually irq lines on isa can't be shared. The PREP spec however mandates that the irq lines for both IDE ports are shared and according to Aurelien this also

[Qemu-devel] Re: Ping: [PATCH] Handle icount for powerpc tbl/tbu/decr load and store.

2011-02-14 Thread Alexander Graf
Tristan Gingold wrote: Potential reviewers CC: On Feb 8, 2011, at 10:59 AM, Tristan Gingold wrote: Handle option '-icount X' on powerpc targets. Signed-off-by: Tristan Gingold ging...@adacore.com Braces are broken. Edgar knows his way around icount a lot better than me - I've

[Qemu-devel] Re: [RFC] prep: enable irq sharing on ide again

2011-02-14 Thread Alexander Graf
Gerd Hoffmann wrote: On 02/08/11 00:26, Alexander Graf wrote: The new ISA infrastructure checks for potential irq sharing bugs on interrupt lines, because usually irq lines on isa can't be shared. The PREP spec however mandates that the irq lines for both IDE ports are shared and according

[Qemu-devel] Re: [RFC] prep: enable irq sharing on ide again

2011-02-14 Thread Jan Kiszka
On 2011-02-14 12:22, Gerd Hoffmann wrote: On 02/08/11 00:26, Alexander Graf wrote: The new ISA infrastructure checks for potential irq sharing bugs on interrupt lines, because usually irq lines on isa can't be shared. The PREP spec however mandates that the irq lines for both IDE ports are

Re: [Qemu-devel] [PATCH v2] PS/2 keyboard Scancode Set 3 support

2011-02-14 Thread Kevin Wolf
Am 13.02.2011 11:07, schrieb Roy Tam: The following patch adds PS/2 keyboard Scancode Set 3 support. Sign-off-by: Roy Tam roy...@gmail.com -- v2: checkpatch.pl style fixes diff --git a/hw/ps2.c b/hw/ps2.c index 762bb00..6bea0ef 100644 --- a/hw/ps2.c +++ b/hw/ps2.c @@ -143,13 +143,85

[Qemu-devel] Re: Ping: [PATCH] Handle icount for powerpc tbl/tbu/decr load and store.

2011-02-14 Thread Edgar E. Iglesias
On Mon, Feb 14, 2011 at 12:34:05PM +0100, Alexander Graf wrote: Tristan Gingold wrote: Potential reviewers CC: On Feb 8, 2011, at 10:59 AM, Tristan Gingold wrote: Handle option '-icount X' on powerpc targets. Signed-off-by: Tristan Gingold ging...@adacore.com Braces

[Qemu-devel] Re: Ping: [PATCH] Handle icount for powerpc tbl/tbu/decr load and store.

2011-02-14 Thread Tristan Gingold
On Feb 14, 2011, at 12:46 PM, Edgar E. Iglesias wrote: On Mon, Feb 14, 2011 at 12:34:05PM +0100, Alexander Graf wrote: Tristan Gingold wrote: Potential reviewers CC: On Feb 8, 2011, at 10:59 AM, Tristan Gingold wrote: Handle option '-icount X' on powerpc targets. Signed-off-by:

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Anthony Liguori
On 02/14/2011 03:50 AM, Kevin Wolf wrote: Am 13.02.2011 19:08, schrieb Anthony Liguori: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with (hopefully) all of the hard problems solved. There is only one remaining thing to attack before posting for

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc '

2011-02-14 Thread Anthony Liguori
On 02/14/2011 04:57 AM, Gerd Hoffmann wrote: On 01/31/11 21:43, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of setting the VNC password to an empty string from disabling login to

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc '

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 06:10:04AM -0600, Anthony Liguori wrote: On 02/14/2011 04:57 AM, Gerd Hoffmann wrote: On 01/31/11 21:43, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Kevin Wolf
Am 14.02.2011 13:03, schrieb Anthony Liguori: On 02/14/2011 03:50 AM, Kevin Wolf wrote: Am 13.02.2011 19:08, schrieb Anthony Liguori: Proposal for events in QAPI For QAPI, I'd like to model events on the notion of signals and slots[2]. A client would explicitly connect to a signal through a

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Luiz Capitulino
On Mon, 14 Feb 2011 13:32:45 +0100 Kevin Wolf kw...@redhat.com wrote: Am 14.02.2011 13:03, schrieb Anthony Liguori: On 02/14/2011 03:50 AM, Kevin Wolf wrote: Am 13.02.2011 19:08, schrieb Anthony Liguori: Proposal for events in QAPI For QAPI, I'd like to model events on the notion of

[Qemu-devel] [Bug 706766] Re: [Qemu-kvm] qemu-img fail to create qcow image

2011-02-14 Thread xudong
Fixed patch in qemu-kvm: 96df67d1c3928704cd76d0b2e76372ef18658e85, close this bug. ** Changed in: qemu Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/706766

Re: [Qemu-devel] [PATCH v2] PS/2 keyboard Scancode Set 3 support

2011-02-14 Thread Roy Tam
2011/2/14 Kevin Wolf kw...@redhat.com: Am 13.02.2011 11:07, schrieb Roy Tam: The following patch adds PS/2 keyboard Scancode Set 3 support. Sign-off-by: Roy Tam roy...@gmail.com -- v2: checkpatch.pl style fixes diff --git a/hw/ps2.c b/hw/ps2.c index 762bb00..6bea0ef 100644 --- a/hw/ps2.c

[Qemu-devel] [PATCH v3] PS/2 keyboard Scancode Set 3 support

2011-02-14 Thread Roy Tam
The following patch adds PS/2 keyboard Scancode Set 3 support. Sign-off-by: Roy Tam roy...@gmail.com -- v3: change from switch to array, more style fixes v2: checkpatch.pl style fixes diff --git a/hw/ps2.c b/hw/ps2.c index 762bb00..da4737a 100644 --- a/hw/ps2.c +++ b/hw/ps2.c @@ -110,14 +110,24

Re: [Qemu-devel] [PATCH v2] PS/2 keyboard Scancode Set 3 support

2011-02-14 Thread Kevin Wolf
Am 14.02.2011 13:49, schrieb Roy Tam: 2011/2/14 Kevin Wolf kw...@redhat.com: Am 13.02.2011 11:07, schrieb Roy Tam: The following patch adds PS/2 keyboard Scancode Set 3 support. Sign-off-by: Roy Tam roy...@gmail.com -- v2: checkpatch.pl style fixes diff --git a/hw/ps2.c b/hw/ps2.c index

Re: [Qemu-devel] [PATCH v3] PS/2 keyboard Scancode Set 3 support

2011-02-14 Thread Kevin Wolf
Am 14.02.2011 13:59, schrieb Roy Tam: The following patch adds PS/2 keyboard Scancode Set 3 support. Sign-off-by: Roy Tam roy...@gmail.com -- v3: change from switch to array, more style fixes v2: checkpatch.pl style fixes Looks much better now. :-) Kevin

Re: [Qemu-devel] [PATCH v2] PS/2 keyboard Scancode Set 3 support

2011-02-14 Thread Roy Tam
2011/2/14 Kevin Wolf kw...@redhat.com: Am 14.02.2011 13:49, schrieb Roy Tam: 2011/2/14 Kevin Wolf kw...@redhat.com: Am 13.02.2011 11:07, schrieb Roy Tam: The following patch adds PS/2 keyboard Scancode Set 3 support. Sign-off-by: Roy Tam roy...@gmail.com -- v2: checkpatch.pl style fixes

[Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Luiz Capitulino
On Sun, 13 Feb 2011 12:08:04 -0600 Anthony Liguori anth...@codemonkey.ws wrote: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with (hopefully) all of the hard problems solved. There is only one remaining thing to attack before posting for inclusion

[Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 11:28:52AM -0200, Luiz Capitulino wrote: On Sun, 13 Feb 2011 12:08:04 -0600 Anthony Liguori anth...@codemonkey.ws wrote: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with (hopefully) all of the hard problems solved. There

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc '

2011-02-14 Thread Gerd Hoffmann
On 02/14/11 13:10, Anthony Liguori wrote: On 02/14/2011 04:57 AM, Gerd Hoffmann wrote: On 01/31/11 21:43, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of setting the VNC password to

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc '

2011-02-14 Thread Anthony Liguori
On 02/14/2011 06:24 AM, Daniel P. Berrange wrote: On Mon, Feb 14, 2011 at 06:10:04AM -0600, Anthony Liguori wrote: On 02/14/2011 04:57 AM, Gerd Hoffmann wrote: On 01/31/11 21:43, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc '

2011-02-14 Thread Anthony Liguori
On 02/14/2011 07:56 AM, Gerd Hoffmann wrote: On 02/14/11 13:10, Anthony Liguori wrote: On 02/14/2011 04:57 AM, Gerd Hoffmann wrote: On 01/31/11 21:43, Anthony Liguori wrote: commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed

[Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Anthony Liguori
On 02/14/2011 07:33 AM, Daniel P. Berrange wrote: On Mon, Feb 14, 2011 at 11:28:52AM -0200, Luiz Capitulino wrote: On Sun, 13 Feb 2011 12:08:04 -0600 Anthony Liguorianth...@codemonkey.ws wrote: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with

[Qemu-devel] Re: Migration of WinXP Guest - usb+network failure

2011-02-14 Thread Gerd Hoffmann
On 02/08/11 14:32, Peter Lieven wrote: Hi, is there any known issue when migrating a WinXP SP3 guest with qemu-kvm 0.13.0 or qemu-kvm-0.12.5? If I migrate such a guest with a Realtek rtl8139 Network Device and an USB Mouse Tablet after migration the USB Tablet doesn't work any more and

[Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Anthony Liguori
On 02/14/2011 07:28 AM, Luiz Capitulino wrote: On Sun, 13 Feb 2011 12:08:04 -0600 Anthony Liguorianth...@codemonkey.ws wrote: Hi, In my QAPI branch[1], I've now got almost every existing QMP command converted with (hopefully) all of the hard problems solved. There is only one remaining

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Anthony Liguori
On 02/14/2011 06:45 AM, Luiz Capitulino wrote: So the question is: how does the schema based design support extending commands or events? Does it require adding new commands/events? Well, let me ask you, how do we do that today? Let's say that I want to add a new parameter to the `change'

[Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc '

2011-02-14 Thread Daniel P. Berrange
On Mon, Feb 14, 2011 at 08:14:07AM -0600, Anthony Liguori wrote: On 02/14/2011 06:24 AM, Daniel P. Berrange wrote: On Mon, Feb 14, 2011 at 06:10:04AM -0600, Anthony Liguori wrote: On 02/14/2011 04:57 AM, Gerd Hoffmann wrote: On 01/31/11 21:43, Anthony Liguori wrote: commit

[Qemu-devel] Remote Desktop integration

2011-02-14 Thread Gary Mort
I was wondering if there is any documentation on what the original source for the VNC/RDP/Spice/etc remote disktop servers and what changes were needed to integrate with Qemu. I'm in the process of setting up a Virtual server and I noticed that my favorite Remote Desktop server is not one of

[Qemu-devel] Re: Problem with DOS application and 286 DOS Extender application

2011-02-14 Thread Kevin O'Connor
On Sun, Feb 13, 2011 at 03:06:44PM +0100, Gerhard Wiesinger wrote: Hello, After some fortune I found out that also Turbo Debugger 286 doesn't work under plain DOS 6.22 (without any memory mananger just pressing F5) or with some memory mananagers (HIMEM.SYS, EMM386, QEMM386). Error message

[Qemu-devel] [PATCH 29/37] kvm: Separate TCG from KVM cpu execution

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Mixing up TCG bits with KVM already led to problems around eflags emulation on x86. Moreover, quite some code that TCG requires on cpu enty/exit is useless for KVM. So dispatch between tcg_cpu_exec and kvm_cpu_exec as early as possible. The core logic of

[Qemu-devel] [PATCH 05/37] Leave inner main_loop faster on pending requests

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com If there is any pending request that requires us to leave the inner loop if main_loop, makes sure we do this as soon as possible by enforcing non-blocking IO processing. At this change, move variable definitions out of the inner loop to improve

[Qemu-devel] [PATCH 24/37] Refactor cpu_has_work/any_cpu_has_work in cpus.c

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Avoid duplicate use of the function name cpu_has_work, it's confusing, also their scope. Refactor cpu_has_work to cpu_thread_is_idle and do the same with any_cpu_has_work. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 25/37] Fix a few coding style violations in cpus.c

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com No functional changes. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- cpus.c | 71 +++ 1 files changed, 44 insertions(+), 27

[Qemu-devel] [PATCH 01/37] Prevent abortion on multiple VCPU kicks

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com If we call qemu_cpu_kick more than once before the target was able to process the signal, pthread_kill will fail, and qemu will abort. Prevent this by avoiding the redundant signal. This logic can be found in qemu-kvm as well. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 00/37] [PULL] qemu-kvm.git uq/master queue

2011-02-14 Thread Marcelo Tosatti
The following changes since commit 8668f61d20eac971d116ebbe8436b4ae963884a8: vmmouse: fix queue_size field initialization (2011-02-12 17:44:11 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Anthony PERARD (1): Introduce

[Qemu-devel] [PATCH 21/37] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com The reset we issue on KVM_EXIT_SHUTDOWN implies that we should also leave the VCPU loop. As we now check for exit_request which is set by qemu_system_reset_request, this bug is no longer critical. Still it's an unneeded extra turn. Signed-off-by: Jan

[Qemu-devel] [PATCH 32/37] kvm: x86: Catch and report failing IRQ and NMI injections

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com We do not need to abort, but the user should be notified that weird things go on. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/kvm.c | 16 +--- 1 files changed, 13

[Qemu-devel] [PATCH 27/37] Refactor debug and vmstop request interface

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Instead of fiddling with debug_requested and vmstop_requested directly, introduce qemu_system_debug_request and turn qemu_system_vmstop_request into a public interface. This aligns those services with exiting ones in vl.c. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 06/37] Flatten the main loop

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com First of all, vm_can_run is a misnomer, it actually means no request pending. Moreover, there is no need to check all pending requests twice, the first time via the inner loop check and then again when actually processing the requests. We can simply remove

[Qemu-devel] [PATCH 13/37] kvm: Refactor qemu_kvm_eat_signals

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com We do not use the timeout, so drop its logic. As we always poll our signals, we do not need to drop the global lock. Removing those calls allows some further simplifications. Also fix the error processing of sigpending at this chance. Signed-off-by: Jan

[Qemu-devel] [PATCH 36/37] kvm: Make kvm_state globally available

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com KVM-assisted devices need access to it but we have no clean channel to distribute a reference. As a workaround until there is a better solution, export kvm_state for global use, though use should remain restricted to the mentioned scenario. Signed-off-by:

[Qemu-devel] [PATCH 03/37] Process vmstop requests in IO thread

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com A pending vmstop request is also a reason to leave the inner main loop. So far we ignored it, and pending stop requests issued over VCPU threads were simply ignored. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 18/37] Introduce VCPU self-signaling service

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Introduce qemu_cpu_kick_self to send SIG_IPI to the calling VCPU context. First user will be kvm. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- cpus.c| 21 +

[Qemu-devel] [PATCH 26/37] Improve vm_stop reason declarations

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Define and use dedicated constants for vm_stop reasons, they actually have nothing to do with the EXCP_* defines used so far. At this chance, specify more detailed reasons so that VM state change handlers can evaluate them. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 10/37] kvm: Provide sigbus services arch-independently

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Provide arch-independent kvm_on_sigbus* stubs to remove the #ifdef'ery from cpus.c. This patch also fixes --disable-kvm build by providing the missing kvm_on_sigbus_vcpu kvm-stub. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Reviewed-by: Paolo Bonzini

[Qemu-devel] [PATCH 12/37] kvm: Set up signal mask also for !CONFIG_IOTHREAD

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Block SIG_IPI, unblock it during KVM_RUN, just like in io-thread mode. It's unused so far, but this infrastructure will be required for self-IPIs and to process SIGBUS plus, in KVM mode, SIGIO and SIGALRM. As Windows doesn't support signal services, we need

[Qemu-devel] [PATCH 08/37] kvm: Drop redundant kvm_enabled from kvm_cpu_thread_fn

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- cpus.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cpus.c b/cpus.c index 0abc009..8232d44 100644 --- a/cpus.c +++

[Qemu-devel] [PATCH 37/37] kvm: x86: Introduce kvmclock device to save/restore its state

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com If kvmclock is used, which implies the kernel supports it, register a kvmclock device with the sysbus. Its main purpose is to save and restore the kernel state on migration, but this will also allow to visualize it one day. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 35/37] cirrus: Remove obsolete kvm.h include

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- hw/cirrus_vga.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 5f45b5d..2724f7b 100644

[Qemu-devel] [PATCH 19/37] kvm: Unconditionally reenter kernel after IO exits

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com KVM requires to reenter the kernel after IO exits in order to complete instruction emulation. Failing to do so will leave the kernel state inconsistently behind. To ensure that we will get back ASAP, we issue a self-signal that will cause KVM_RUN to return

[Qemu-devel] [PATCH 34/37] Introduce log_start/log_stop in CPUPhysMemoryClient

2011-02-14 Thread Marcelo Tosatti
From: Anthony PERARD anthony.per...@citrix.com In order to use log_start/log_stop with Xen as well in the vga code, this two operations have been put in CPUPhysMemoryClient. The two new functions cpu_physical_log_start,cpu_physical_log_stop are used in hw/vga.c and replace the

[Qemu-devel] [PATCH 31/37] kvm: Drop return values from kvm_arch_pre/post_run

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com We do not check them, and the only arch with non-empty implementations always returns 0 (this is also true for qemu-kvm). Signed-off-by: Jan Kiszka jan.kis...@siemens.com CC: Alexander Graf ag...@suse.de Signed-off-by: Marcelo Tosatti mtosa...@redhat.com

[Qemu-devel] [PATCH 07/37] kvm: Report proper error on GET_VCPU_MMAP_SIZE failures

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 2ec9e09..55f6ac3 100644 --- a/kvm-all.c

[Qemu-devel] [PATCH 02/37] Stop current VCPU on synchronous reset requests

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com If some I/O operation ends up calling qemu_system_reset_request in VCPU context, we record this and inform the io-thread, but we do not terminate the VCPU loop. This can lead to fairly unexpected behavior if the triggering reset operation is supposed to

[Qemu-devel] [PATCH 14/37] kvm: Call qemu_kvm_eat_signals also under !CONFIG_IOTHREAD

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Move qemu_kvm_eat_signals around and call it also when the IO-thread is not used. Do not yet process SIGBUS, will be armed in a separate step. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- cpus.c |

[Qemu-devel] [PATCH 30/37] kvm: x86: Prepare VCPU loop for in-kernel irqchip

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Effectively no functional change yet as kvm_irqchip_in_kernel still only returns 0, but this patch will allow qemu-kvm to adopt the VCPU loop of upsteam KVM. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 15/37] Set up signalfd under !CONFIG_IOTHREAD

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Will be required for SIGBUS handling. For obvious reasons, this will remain a nop on Windows hosts. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com ---

[Qemu-devel] [PATCH 22/37] kvm: make tsc stable over migration and machine start

2011-02-14 Thread Marcelo Tosatti
From: Glauber Costa glom...@redhat.com If the machine is stopped, we should not record two different tsc values upon a save operation. The same problem happens with kvmclock. But kvmclock is taking a different diretion, being now seen as a separate device. Since this is unlikely to happen with

Re: [Qemu-devel] Remote Desktop integration

2011-02-14 Thread Corentin Chary
On Mon, Feb 14, 2011 at 3:01 PM, Gary Mort garyam...@gmail.com wrote: I was wondering if there is any documentation on what the original source for the VNC/RDP/Spice/etc remote disktop servers and what changes were needed to integrate with Qemu. I'm in the process of setting up a Virtual

[Qemu-devel] [PATCH 16/37] kvm: Fix race between timer signals and vcpu entry under !IOTHREAD

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Found by Stefan Hajnoczi: There is a race in kvm_cpu_exec between checking for exit_request on vcpu entry and timer signals arriving before KVM starts to catch them. Plug it by blocking both timer related signals also on !CONFIG_IOTHREAD and process those

[Qemu-devel] [PATCH 23/37] Refactor kvmtcg function names in cpus.c

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Pure interface cosmetics: Ensure that only kvm core services (as declared in kvm.h) start with kvm_. Prepend qemu_ to those that violate this rule in cpus.c. Also rename the corresponding tcg functions for the sake of consistency. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 09/37] kvm: Handle kvm_init_vcpu errors

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Do not ignore errors of kvm_init_vcpu, they are fatal. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- cpus.c | 19 +++ 1 files changed, 15 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 11/37] Refactor signal setup functions in cpus.c

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Move {tcg,kvm}_init_ipi and block_io_signals to avoid prototypes, rename the former two to clarify that they deal with more than SIG_IPI. No functional changes - except for the tiny fixup of strerror usage. The forward declaration of sigbus_handler is just

[Qemu-devel] [PATCH 28/37] Move debug exception handling out of cpu_exec

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com To prepare splitting up KVM and TCG CPU entry/exit, move the debug exception into cpus.c and invoke cpu_handle_debug_exception on return from qemu_cpu_exec. This also allows to clean up the debug request signaling: We can assign the job of informing

[Qemu-devel] [PATCH 33/37] kvm: Remove unneeded memory slot reservation

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com The number of slots and the location of private ones changed several times in KVM's early days. However, it's stable since 2.6.29 (our required baseline), and slots 8..11 are no longer reserved since then. So remove this unneeded restriction.

[Qemu-devel] [PATCH 20/37] kvm: Remove static return code of kvm_handle_io

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Improve the readability of the exit dispatcher by moving the static return value of kvm_handle_io to its caller. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c | 17 - 1

[Qemu-devel] [PATCH 17/37] kvm: Add MCE signal support for !CONFIG_IOTHREAD

2011-02-14 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Currently, we only configure and process MCE-related SIGBUS events if CONFIG_IOTHREAD is enabled. The groundwork is laid, we just need to factor out the required handler registration and system configuration. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH] softfloat: export float32_nan and float32_infinity.

2011-02-14 Thread Christophe Lyon
These two special values are needed to implement some helper functions, which return these values in some cases. Signed-off-by: Christophe Lyon christophe.l...@st.com --- fpu/softfloat-specialize.h |9 + fpu/softfloat.h|2 ++ 2 files changed, 11 insertions(+), 0

[Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver

2011-02-14 Thread Vasily Khoruzhick
RST bit is (1 3) bit, not (1 2), fix condition that enables i2s if ENB is set and RST is not set. Signed-off-by: Vasily Khoruzhick anars...@gmail.com --- hw/pxa2xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pxa2xx.c b/hw/pxa2xx.c index d966846..68b67ae

[Qemu-devel] Re: RFC: New API for PPC for vcpu mmu access

2011-02-14 Thread Scott Wood
On Sun, 13 Feb 2011 23:43:40 +0100 Alexander Graf ag...@suse.de wrote: struct kvmppc_book3e_tlb_entry { union { __u64 mas8_1; struct { __u32 mas8; __u32 mas1; }; }; __u64 mas2; union {

Re: [Qemu-devel] KVM call minutes for Feb 8

2011-02-14 Thread Blue Swirl
On Mon, Feb 14, 2011 at 12:42 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 02/13/2011 03:00 PM, Blue Swirl wrote: On Sun, Feb 13, 2011 at 9:57 PM, Anthony Liguorianth...@codemonkey.ws  wrote: On 02/13/2011 01:37 PM, Blue Swirl wrote: On Sun, Feb 13, 2011 at 5:31 PM, Anthony

Re: [Qemu-devel] [PATCH 3/6] target-arm: fix unsigned 64 bit right shifts.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:10, christophe.l...@st.com wrote: From: Christophe Lyon christophe.l...@st.com Fix range of shift amounts which always give 0 as result. Signed-off-by: Christophe Lyon christophe.l...@st.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH 5/6] target-arm: fix Neon VQSHRN and VSHRN.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:11, christophe.l...@st.com wrote: From: Christophe Lyon christophe.l...@st.com Call the normal shift helpers instead of the rounding ones. Signed-off-by: Christophe Lyon christophe.l...@st.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH 4/6] target-arm: fix saturated values for Neon right shifts.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:11, christophe.l...@st.com wrote: --- a/target-arm/neon_helper.c +++ b/target-arm/neon_helper.c @@ -903,7 +903,7 @@ uint64_t HELPER(neon_qrshl_u64)(CPUState *env, uint64_t val, uint64_t shiftop)         dest = src1 tmp; \         if ((dest tmp) != src1) { \      

Re: [Qemu-devel] [PATCH 4/6] target-arm: fix saturated values for Neon right shifts.

2011-02-14 Thread Peter Maydell
On 14 February 2011 17:46, Peter Maydell peter.mayd...@linaro.org wrote: On 11 February 2011 15:11,  christophe.l...@st.com wrote:  NEON_VOP_ENV(qrshl_s8, neon_s8, 4) @@ -924,7 +924,11 @@ uint32_t HELPER(neon_qrshl_s32)(CPUState *env, uint32_t valop, uint32_t shiftop)         dest = val

Re: [Qemu-devel] [PATCH 6/6] target-arm: fix decoding of Neon 64 bit shifts.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:11, christophe.l...@st.com wrote: From: Christophe Lyon christophe.l...@st.com Fix decoding of 64 bits variants of VSHRN, VRSHRN, VQSHRN, VQSHRUN, VQRSHRN, VQRSHRUN, taking into account whether inputs are unsigned or not. Signed-off-by: Christophe Lyon

[Qemu-devel] KVM call agenda for Feb 15

2011-02-14 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

Re: [Qemu-devel] [PATCH 1/6] target-arm: Fix rounding constant addition for Neon shift instructions.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:10, christophe.l...@st.com wrote: +uint32_t HELPER(neon_rshl_s32)(uint32_t valop, uint32_t shiftop) +{ +    int32_t dest; +    int32_t val = (int32_t)valop; +    int8_t shift = (int8_t)shiftop; +    if (shift = 32) { +        dest = 0; +    } else if (shift -32) {

Re: [Qemu-devel] [PULL 0.14] linux-user fixes

2011-02-14 Thread Justin M. Forbes
On Thu, Feb 10, 2011 at 11:53:10AM +0200, Riku Voipio wrote: The following changes since commit 343c1de916b1841cd5fd5f813add9c87590d72e8: x86: Fix MCA broadcast parameters for TCG case (2011-02-08 12:37:30 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH 2/6] target-arm: fix Neon right shifts with shift amount == input width.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:10, christophe.l...@st.com wrote: From: Christophe Lyon christophe.l...@st.com Fix rshl helpers (s8, s16, s64, u8, u16) Signed-off-by: Christophe Lyon christophe.l...@st.com ---  target-arm/neon_helper.c |    6 +++---  1 files changed, 3 insertions(+), 3

Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

2011-02-14 Thread Peter Maydell
On 11 February 2011 15:10, christophe.l...@st.com wrote: From: Christophe Lyon christophe.l...@st.com This patch series provides fixes such that ARM Neon instructions VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now pass all my tests. I have reworked all these patches

Re: [Qemu-devel] Re: [RFC] qapi: events in QMP

2011-02-14 Thread Luiz Capitulino
On Mon, 14 Feb 2011 08:39:11 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 02/14/2011 06:45 AM, Luiz Capitulino wrote: So the question is: how does the schema based design support extending commands or events? Does it require adding new commands/events? Well, let me ask you,

  1   2   >