[Qemu-devel] [PATCH 06/26] Correct ppc popcntb logic, implement popcntw and popcntd

2011-03-16 Thread David Gibson
From: David Gibson d...@au1.ibm.com qemu already includes support for the popcntb instruction introduced in POWER5 (although it doesn't actually allow you to choose POWER5). However, the logic is slightly incorrect: it will generate results truncated to 32-bits when the CPU is in 32-bit mode.

Re: [Qemu-devel] [PATCH] Fix net_check_clients warnings: make it per vlan.

2011-03-16 Thread Markus Armbruster
Tristan Gingold ging...@adacore.com writes: Signed-off-by: Tristan Gingold ging...@adacore.com --- net.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index ddcca97..b2dfaa8 100644 --- a/net.c +++ b/net.c @@ -1305,9 +1305,10 @@ void

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Jes Sorensen
On 03/15/11 15:23, Alon Levy wrote: On Tue, Mar 15, 2011 at 08:45:29AM -0500, Anthony Liguori wrote: On 03/15/2011 08:14 AM, Alon Levy wrote: Alternatively the external apps that build against it should be taught to link with the QEMU version. That would require me to teach qemu's configure

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Jes Sorensen
On 03/15/11 16:14, Alon Levy wrote: On Tue, Mar 15, 2011 at 03:59:26PM +0100, Jes Sorensen wrote: I don't think it is necessary for distro packaging. Most distros will build multiple binary packages from one source package, and it is up to the user to decide which ones to install. if

[Qemu-devel] [PATCH v2] vl.c: Replace -virtfs string manipulation with QemuOpts

2011-03-16 Thread Stefan Hajnoczi
The -virtfs option creates an fsdev representing the pass-through file system and a guest-visible virtio-9p-pci device that can access this file system. This patch replaces the string manipulation used to build and reparse option lists with direct QemuOpts calls. Removing the string manipulation

Re: [Qemu-devel] Windows 7 on pure qemu-0.14

2011-03-16 Thread Gleb Natapov
On Tue, Mar 15, 2011 at 11:41:19PM +0100, Marco Cianfriglia wrote: Hi to all, thanks for the suggestion to make use of the -cpu nehalem switch. It should be -cpu Nehalem. I try to use the option you suggest but I receive this error: Unable to find x86 CPU definition

Re: [Qemu-devel] [Bug 735752] [NEW] qemu squeeze crashes BUG: unable to handle kernel NULL pointer dereference at (null)

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 9:28 PM, Aidar Kamalov 735...@bugs.launchpad.net wrote: Mar 15 17:58:04 mainhost kernel: [65866.980085] Call Trace: Mar 15 17:58:04 mainhost kernel: [65866.980085]  [8100f06f] ? 0x8100f06f Mar 15 17:58:04 mainhost kernel: [65866.980085]  

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Alon Levy
On Wed, Mar 16, 2011 at 09:23:20AM +0100, Jes Sorensen wrote: On 03/15/11 15:23, Alon Levy wrote: On Tue, Mar 15, 2011 at 08:45:29AM -0500, Anthony Liguori wrote: On 03/15/2011 08:14 AM, Alon Levy wrote: Alternatively the external apps that build against it should be taught to link with

Re: [Qemu-devel] [PATCH 4/7] libcacard: initial commit

2011-03-16 Thread Jes Sorensen
On 03/16/11 09:40, Alon Levy wrote: On Wed, Mar 16, 2011 at 09:23:20AM +0100, Jes Sorensen wrote: It's really not far off, most of it is in the Makefiles. You really just need to have a libcacard flag that is enabled per default (and is required if one asks for --enable-smartcard), but can be

[Qemu-devel] Re: [PATCH v3] Add qcow2 documentation

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 11:55 AM, Kevin Wolf kw...@redhat.com wrote: This adds a description of the qcow2 file format to the docs/ directory. Besides documenting what's there, which is never wrong, the document should provide a good basis for the discussion of format extensions (called qcow3

Re: [Qemu-devel] [PATCH -V3 7/8] hw/9pfs: Add new virtfs option cache=none to skip host page cache

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 12:30 PM, Aneesh Kumar K. V aneesh.ku...@linux.vnet.ibm.com wrote: On Tue, 15 Mar 2011 11:11:46 +, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Mar 15, 2011 at 9:19 AM, Aneesh Kumar K. V aneesh.ku...@linux.vnet.ibm.com wrote: On Mon, 14 Mar 2011 10:20:57

[Qemu-devel] Re: Windows 7 on pure qemu-0.14

2011-03-16 Thread Jan Kiszka
On 2011-03-16 09:33, Gleb Natapov wrote: On Tue, Mar 15, 2011 at 11:41:19PM +0100, Marco Cianfriglia wrote: Hi to all, thanks for the suggestion to make use of the -cpu nehalem switch. It should be -cpu Nehalem. We neither have nehalem nor Nehalem as CPU definition in qemu or

[Qemu-devel] Re: [PATCH 21/35] Break up user and system cpu_interrupt implementations

2011-03-16 Thread Jan Kiszka
On 2011-03-15 22:50, Marcelo Tosatti wrote: From: Jan Kiszka jan.kis...@siemens.com Both have only two lines in common, and we will convert the system service into a callback which is of no use for user mode operation. From KVM POV, the value of this patch is not that high as long as we do

[Qemu-devel] Re: Windows 7 on pure qemu-0.14

2011-03-16 Thread Gleb Natapov
On Wed, Mar 16, 2011 at 10:02:43AM +0100, Jan Kiszka wrote: On 2011-03-16 09:33, Gleb Natapov wrote: On Tue, Mar 15, 2011 at 11:41:19PM +0100, Marco Cianfriglia wrote: Hi to all, thanks for the suggestion to make use of the -cpu nehalem switch. It should be -cpu Nehalem.

[Qemu-devel] [PATCH] ioapic: when switches to level trigger mode, interrupts raised repeatedly.

2011-03-16 Thread Isaku Yamahata
- the trigger mode is edge at first - During initializatoin, the interrupt is raised as edge which is masked. The corresponding bit of irr is set. - Then the mode is switched to level and it's unmasked. - the bit of irr is set, so the interrupt is raised repeatedly by ioapic_service(). - OS

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-03-16 Thread Alon Levy
On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote: On 02/23/11 12:20, Alon Levy wrote: diff --git a/configure b/configure index 791b71d..147aab3 100755 --- a/configure +++ b/configure @@ -174,6 +174,7 @@ trace_backend=nop trace_file=trace spice= rbd= +smartcard=yes

Re: [Qemu-devel] [PATCH 4/4] hw/qxl-render: drop cursor locks, add TODO's.

2011-03-16 Thread Hans de Goede
Hi, As discussed on irc I think we need to look into this and see if we can fix it properly while at it. IOW to be continued... Regards, Hans On 03/15/2011 09:17 PM, Alon Levy wrote: Dropping the locks prevents a deadlock when running with -sdl or -vnc in addition to -spice. When server

Re: [Qemu-devel] [PATCH 3/4] qxl/spice: remove qemu_mutex_{un, }lock_iothread around dispatcher

2011-03-16 Thread Hans de Goede
Ack (assuming the issues with the previous 2 patches are fixed): Acked-by: Hans de Goede hdego...@redhat.com On 03/15/2011 09:17 PM, Alon Levy wrote: with the previous patch making sure get_command no longer needs to lock, there is no reason to drop the qemu iothread mutex in qxl.c and in

[Qemu-devel] Re: [v1 PATCH 2/3]: Helper routines to use GLib threadpool infrastructure in 9pfs.

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 1:13 PM, Anthony Liguori aligu...@us.ibm.com wrote: Why even bothering signaling for completion with the virtio-9p threadpool? There's no sane guest that's going to poll on virtio-9p completion with interrupts disabled and no timer.  Once we enable the I/O thread by

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-03-16 Thread Jes Sorensen
On 03/16/11 10:15, Alon Levy wrote: On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote: +typedef struct __attribute__ ((__packed__)) CCID_Header { +uint8_t bMessageType; +uint32_tdwLength; +uint8_t bSlot; +uint8_t bSeq; +} CCID_Header; Is this

[Qemu-devel] [PATCH 06/26] pci_bridge: add helper function to convert PCIBridge into PCIDevice

2011-03-16 Thread Isaku Yamahata
pci_bridge_to_pci() which converts PCIBridge into PCIDevice which will be used later by pci_p2pbr. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci_bridge.c |6 ++ hw/pci_bridge.h |1 + 2 files changed, 7 insertions(+), 0

[Qemu-devel] [PATCH 13/26] usb/uhci: add ich9 usb uhci id's device

2011-03-16 Thread Isaku Yamahata
add uhci device which has ich9 device id. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci_ids.h |2 ++ hw/usb-uhci.c |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index ea3418c..9daea23 100644 --- a/hw/pci_ids.h

[Qemu-devel] [PATCH 10/26] ide/ahci/ich: use qdev.reset

2011-03-16 Thread Isaku Yamahata
use DeviceInfo::reset callback instead of qemu_register_reset(). With this patch, its reset is done before parent pci device's reset. Cc: Alexander Graf ag...@suse.de Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/ide/ich.c |9 ++--- 1 files changed, 6 insertions(+), 3

[Qemu-devel] [PATCH 17/26] pc, pc_piix: split out pc nic initialization

2011-03-16 Thread Isaku Yamahata
Factor out pc nic initialization. This simplifies the pc initialization and will reduce the code duplication of q35 pc initialization. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pc.c | 15 +++ hw/pc.h |1 + hw/pc_piix.c |9 + 3 files

[Qemu-devel] [PATCH 16/26] pc, pc_piix: split out allocating isa irqs

2011-03-16 Thread Isaku Yamahata
Factor out the logic of allocating isa irqs. This simplifies the pc initialization and will reduce the code duplication of q35 pc initialization. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pc.c | 16 ++-- hw/pc.h |2 +- hw/pc_piix.c |8 +--- 3

[Qemu-devel] [PATCH 11/26] ahci: add ide device initialization helper

2011-03-16 Thread Isaku Yamahata
Introduce a helper function which initialize ahci port with ide device It will be used by q35 support later. Cc: Alexander Graf ag...@suse.de Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/ide.h |3 +++ hw/ide/ahci.c | 15 +++ 2 files changed, 18

[Qemu-devel] [PATCH 18/26] ioapic: move ioapic_init() from pc_piix.c to pc.c

2011-03-16 Thread Isaku Yamahata
ioapic isn't piix specific. And q35 pc will use it. So move ioapic_init() from pc_piix.c to common place, pc.c. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pc.c | 16 hw/pc.h |2 ++ hw/pc_piix.c | 16 3 files changed, 18

[Qemu-devel] [PATCH 14/26] ide: consolidate drive_get(IF_IDE)

2011-03-16 Thread Isaku Yamahata
factor out ide initialization to call drive_get(IF_IDE) Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/ide.h |3 +++ hw/ide/core.c | 14 ++ hw/mips_fulong2e.c |9 + hw/mips_malta.c| 10 +- hw/mips_r4k.c | 10

[Qemu-devel] [PATCH 02/26] pci: add opaque argument to pci_map_irq_fn

2011-03-16 Thread Isaku Yamahata
Pass opaque argument to pci_map_irq_fn like pci_set_irq_fn. ICH9 irq routing is not static, but configurable by chipset configuration registers, so the corresponding irq mapping function of pci_map_irq_fn needs to know the pointer to ich9. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH 20/26] pc, i440fx: simply i440fx initialization

2011-03-16 Thread Isaku Yamahata
simply i440fx initialization by eliminating i440fx_init_memory_mappings(). Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pc.h |2 +- hw/pc_piix.c |8 +--- hw/piix_pci.c | 15 ++- 3 files changed, 8 insertions(+), 17 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 1/4] block: clarify the meaning of BDRV_O_NOCACHE

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 2:11 PM, Christoph Hellwig h...@lst.de wrote: Change BDRV_O_NOCACHE to only imply bypassing the host OS file cache, but no writeback semantics.  All existing callers are changed to also specify BDRV_O_CACHE_WB to give them writeback semantics. Signed-off-by: Christoph

[Qemu-devel] [PATCH 03/26] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle

2011-03-16 Thread Isaku Yamahata
introduce pci_swizzle_map_irq_fn() for interrupt pin swizzle which is standardized. PCI bridge swizzle is common logic, by introducing this function duplicated swizzle logic will be avoided later. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp ---

[Qemu-devel] [PATCH 21/26] acpi, acpi_piix: factor out PM_TMR logic

2011-03-16 Thread Isaku Yamahata
factor out PM_TMR logic. Later This will be used by ich9 acpi. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/acpi.c | 45 + hw/acpi.h | 24 hw/acpi_piix4.c | 45

[Qemu-devel] [PATCH 01/26] pci: replace the magic, 256, for the maximum of slot

2011-03-16 Thread Isaku Yamahata
Introduce symbol PCI_SLOT_MAX for the maximum of slot. and replace the magic, 256. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.h |1 + hw/pci_internals.h |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff

[Qemu-devel] [PATCH 24/26] acpi, acpi_piix: factor out GPE logic

2011-03-16 Thread Isaku Yamahata
factor out ACPI GPE logic. Later it will be used by ICH9 ACPI. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/acpi.c | 66 ++ hw/acpi.h | 17 ++ hw/acpi_piix4.c | 95 ++

[Qemu-devel] [PATCH 00/26] q35 chipset support for native pci express support

2011-03-16 Thread Isaku Yamahata
/q35/20110316/qemu git clone http://people.valinux.co.jp/~yamahata/qemu/q35/20110316/seabios Example: qemu-system-x86_64 ... -M pc_q35 -acpitable 'load_header,data=roms/seabios/src/q35-acpi-dsdt.aml The motivation is to support newer hardware features because piix chipset is very old. Especially I

[Qemu-devel] [PATCH 09/26] dec_pci: simplify dec_pci.c by using pci_p2pbr

2011-03-16 Thread Isaku Yamahata
apply pci_p2pbr for dec_pci.c. Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/dec_pci.c | 49 ++--- 1 files changed, 14 insertions(+), 35 deletions(-) diff --git

[Qemu-devel] [PATCH 04/26] pci: add accessor function to get irq levels

2011-03-16 Thread Isaku Yamahata
Introduce accessor function to know INTx levels. It will be used later by q35. Although piix_pci tracks the intx line levels, it can be eliminated by this helper function. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci.c |7 +++

[Qemu-devel] [PATCH 23/26] acpi, acpi_piix: factor out PM1_CNT logic

2011-03-16 Thread Isaku Yamahata
factor out ACPI PM1_CNT logic. This will be used by ich9 acpi. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/acpi.c | 49 + hw/acpi.h | 14 ++ hw/acpi_piix4.c | 40 ++--

[Qemu-devel] [PATCH 25/26] pci_ids: add intel 82801BA pci-to-pci bridge id and PCI_CLASS_SERIAL_SMBUS

2011-03-16 Thread Isaku Yamahata
Adds pci id constants which will be used by q35. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/pci_ids.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 9daea23..a597a7b 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@

[Qemu-devel] [PATCH 22/26] acpi, acpi_piix: factor out PM1a EVT logic

2011-03-16 Thread Isaku Yamahata
factor out ACPI PM1a EVT logic. Later this will be used by ich9 acpi. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/acpi.c | 37 + hw/acpi.h | 13 + hw/acpi_piix4.c | 52

[Qemu-devel] [PATCH 07/26] pci/p2pbr: generic pci p2p bridge

2011-03-16 Thread Isaku Yamahata
Create generic pci p2p bridge device which can be customized via properties like vendor id/device id and so on. With this, we can avoid to create many pci p2p bridge which only differs in those ids. Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp ---

[Qemu-devel] [PATCH 05/26] piix_pci: eliminate PIIX3State::pci_irq_levels

2011-03-16 Thread Isaku Yamahata
PIIX3State::pci_irq_levels are redundant which is already tracked by PCIBus layer. So eliminate them. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/piix_pci.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/hw/piix_pci.c

[Qemu-devel] [PATCH 08/26] apb_pci: simplify apb_pci.c by using pci_p2pbr

2011-03-16 Thread Isaku Yamahata
apply pci_p2pbr for apb_pci.c. Cc: Michael S. Tsirkin m...@redhat.com Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/apb_pci.c | 63 - 1 files changed, 27 insertions(+), 36 deletions(-)

[Qemu-devel] [PATCH 15/26] smbus_eeprom: consolidate smbus eeprom creation

2011-03-16 Thread Isaku Yamahata
consolidate smbus initialization for pc_piix, mips_malta and mips_fulong. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Cc: Aurelien Jarno aurel...@aurel32.net Cc: Huacai Chen zltjiang...@gmail.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/mips_fulong2e.c |9

[Qemu-devel] Re: [PATCH 2/4] block: add a helper to change writeback mode on the fly

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 2:11 PM, Christoph Hellwig h...@lst.de wrote: Add a new bdrv_change_cache that can set/clear the writeback flag at runtime by stopping all I/O and closing/reopening the image file. All code is based on a patch from Prerna Saxena pre...@linux.vnet.ibm.com with minimal

[Qemu-devel] ACPI table loading [was: q35 chipset support for native pci express support]

2011-03-16 Thread Michael Tokarev
clone http://people.valinux.co.jp/~yamahata/qemu/q35/20110316/qemu git clone http://people.valinux.co.jp/~yamahata/qemu/q35/20110316/seabios Example: qemu-system-x86_64 ... -M pc_q35 -acpitable 'load_header,data=roms/seabios/src/q35-acpi-dsdt.aml My question is unrelated to your q35 work, but I

[Qemu-devel] Re: [PATCH 1/4] block: clarify the meaning of BDRV_O_NOCACHE

2011-03-16 Thread Kevin Wolf
Am 16.03.2011 10:42, schrieb Stefan Hajnoczi: On Tue, Mar 15, 2011 at 2:11 PM, Christoph Hellwig h...@lst.de wrote: Change BDRV_O_NOCACHE to only imply bypassing the host OS file cache, but no writeback semantics. All existing callers are changed to also specify BDRV_O_CACHE_WB to give them

[Qemu-devel] [PATCH 19/26] pc/piix_pci: factor out smram/pam logic

2011-03-16 Thread Isaku Yamahata
Factor out smram/pam logic for later use. Which will be used by q35 too. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- Makefile.target |2 +- hw/pam.c| 128 +++ hw/pam.h| 96

[Qemu-devel] QEMU-user mode profiling

2011-03-16 Thread maheen butt
hiI want to profile mips ELF with the help of QEMU so that I can find more time consuming portion of the code. does QEMU user mode emulation provide such feature? I did a small experiment. I configure QEMU with --enable-gprof and makeafterwards i gave following command$qemu-mips hw_mipswhere

[Qemu-devel] [PATCH 12/26] usb/uhci: generalize initialization

2011-03-16 Thread Isaku Yamahata
generalize initialization to make vendir/device id customizable. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- hw/usb-uhci.c | 87 - 1 files changed, 43 insertions(+), 44 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c

[Qemu-devel] Developing custom PCI devices in qemu

2011-03-16 Thread अनुज
Hi All I am interested in developing a custom PCI device for qemu. For learning purpose, It could be just a very basic device e.g. a device which just loopbacks the contents from device memory to some system buffer. Please guide me how such a device can be developed in qemu. Do qemu have some

[Qemu-devel] [PATCH] [PPC] Add support for 6 SPE instructions (evmra, evmwsmi{a{a}}, evmwumi{a{a}})

2011-03-16 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau chout...@adacore.com --- target-ppc/translate.c | 201 +++- 1 files changed, 197 insertions(+), 4 deletions(-) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index 89413c5..e438433 100644 ---

[Qemu-devel] Re: [PATCH 2/4] block: add a helper to change writeback mode on the fly

2011-03-16 Thread Kevin Wolf
Am 16.03.2011 10:49, schrieb Stefan Hajnoczi: On Tue, Mar 15, 2011 at 2:11 PM, Christoph Hellwig h...@lst.de wrote: Add a new bdrv_change_cache that can set/clear the writeback flag at runtime by stopping all I/O and closing/reopening the image file. All code is based on a patch from Prerna

[Qemu-devel] Re: [v1 PATCH 3/3]: Convert v9fs_stat to threaded model.

2011-03-16 Thread Stefan Hajnoczi
On Tue, Mar 15, 2011 at 10:39 AM, Arun R Bharadwaj a...@linux.vnet.ibm.com wrote: -static void v9fs_stat_post_lstat(V9fsState *s, V9fsStatState *vs, int err) +static void v9fs_stat_post_lstat(void *opaque)  { -    if (err == -1) { -        err = -errno; +    V9fsStatState *vs =

[Qemu-devel] [PATCH master,stable] vhost: fix dirty page handling

2011-03-16 Thread Michael S. Tsirkin
vhost was passing a physical address to cpu_physical_memory_set_dirty, which is wrong: we need to translate to ram address first. Signed-off-by: Michael S. Tsirkin m...@redhat.com Note: this lead to crashes during migration, so the patch is needed on the stable branch too. --- hw/vhost.c |

[Qemu-devel] vcpu hotplug status

2011-03-16 Thread William Dauchy
Hi, I wanted to test vcpu hotplug. When adding a cpu I'm getting qdev_create_from_info: Assertion `bus-allow_hotplug' failed. I went through a discussion about the subject here http://lists.nongnu.org/archive/html/qemu-devel/2010-08/msg00999.html To make sure whether it was working, I hard-coded

[Qemu-devel] [PATCH 3/9] Add error message for loading snapshot without VM state

2011-03-16 Thread Kevin Wolf
It already fails, but it didn't tell the user why. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- savevm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 60d2f2a..d1b9b4a 100644 --- a/savevm.c +++

[Qemu-devel] [PATCH 8/9] hw/xen_disk: aio_inflight not released in handling ioreq when nr_segments==0

2011-03-16 Thread Kevin Wolf
From: Feiran Zheng famc...@gmail.com In hw/xen_disk.c, async writing ioreq is leaked when ioreq-req.nr_segments==0, because `aio_inflight` flag is not released properly (skipped by misplaced break). Signed-off-by: Feiran Zheng famc...@gmail.com Acked-by: Stefano Stabellini

[Qemu-devel] [PULL 0/9] Block patches

2011-03-16 Thread Kevin Wolf
The following changes since commit cc015e9a5dde2f03f123357fa060acbdfcd570a4: add Win32 IPI service (2011-03-13 14:44:22 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Brian Wheeler (1): Fix ATA SMART and CHECK POWER MODE Feiran Zheng (1):

Re: [Qemu-devel] Re: Windows 7 on pure qemu-0.14

2011-03-16 Thread TeLeMan
I have another problem: Windows 7 x86 setup hangs when Setup Is Starting Windows. Any suggestions?

[Qemu-devel] [PATCH 4/9] tools: Use real async.c instead of stubs

2011-03-16 Thread Kevin Wolf
It's wrong to call BHs directly, even in tools. The only operations that schedule BHs are called in a loop that (indirectly) contains a call to qemu_bh_poll anyway, so we're not losing the scheduled BHs: Tools either use synchronous functions, which are guaranteed to have completed (including any

[Qemu-devel] [PATCH 2/9] block/qcow: Don't ignore immediate read/write and other failures

2011-03-16 Thread Kevin Wolf
From: Stefan Weil w...@mail.berlios.de This patch is similar to 171e3d6b9997c98a97d0c525867f7cd9b640cadd which fixed qcow2: Returning -EIO is far from optimal, but at least it's an error code. In addition to read/write failures, -EIO is also returned when decompress_cluster failed. Cc: Kevin

[Qemu-devel] [PATCH 5/9] Don't allow multiwrites against a block device without underlying medium

2011-03-16 Thread Kevin Wolf
From: Ryan Harper ry...@us.ibm.com If the block device has been closed, we no longer have a medium to submit IO against, check for this before submitting io. This prevents a segfault further in the code where we dereference elements of the block driver. Signed-off-by: Ryan Harper

[Qemu-devel] [PATCH 6/9] Fix ATA SMART and CHECK POWER MODE

2011-03-16 Thread Kevin Wolf
From: Brian Wheeler bdwhe...@indiana.edu This patch fixes two things: 1) CHECK POWER MODE The error return value wasn't always zero, so it would show up as offline. Error is now explicitly set to zero. 2) SMART The smart values that were returned were invalid and tools like skdump would

[Qemu-devel] [PATCH 9/9] Add qcow2 documentation

2011-03-16 Thread Kevin Wolf
This adds a description of the qcow2 file format to the docs/ directory. Besides documenting what's there, which is never wrong, the document should provide a good basis for the discussion of format extensions (called qcow3 in previous discussions) Signed-off-by: Kevin Wolf kw...@redhat.com

[Qemu-devel] [PATCH 6/7] error message if user specifies curses on cmd line when curses is disabled

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx |2 -- vl.c|7 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 3e9a274..4220aad 100644 ---

[Qemu-devel] [PATCH 7/9] Improve error handling in do_snapshot_blkdev()

2011-03-16 Thread Kevin Wolf
From: Jes Sorensen jes.soren...@redhat.com In case we cannot open the newly created snapshot image, try to fall back to the original image file and continue running on that, which should prevent the guest from aborting. This is a corner case which can happen if the admin by mistake specifies the

[Qemu-devel] [PATCH v4 0/7] Introduce -display and make VNC optional

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This is v4 version of the -display patches and the option to make VNC optional. It introduces a new -display argument to consolidate the current -sdl/-curses/-nographic/-vnc arguments. Only change in v4 is to fix the problem where the build would

[Qemu-devel] [PATCH 3/7] Introduce -display none

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com New option -display none. This option differs from -display nographic by not trying to take control of stdio etc. but instead behaves as if a graphics display is enabled, except that it doesn't show one. Signed-off-by: Jes Sorensen

[Qemu-devel] [PATCH 2/7] Introduce -display argument

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is equivalent to -nographic) Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx |

[Qemu-devel] [PATCH 4/7] Add support for -display vnc

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx |5 - vl.c| 14 ++ 2 files changed, 18 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index d4f365a..ac3c2e5 100644

[Qemu-devel] [PATCH 1/7] Consolidate DisplaySurface allocation in qemu_alloc_display()

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This removes various code duplication from console.e and sdl.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- console.c | 46 -- console.h |2 ++ ui/sdl.c | 20 3 files

[Qemu-devel] [PATCH 5/7] error message if user specifies SDL cmd line option when SDL is disabled

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx | 10 -- vl.c|8 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index ac3c2e5..3e9a274 100644

Re: [Qemu-devel] Re: Windows 7 on pure qemu-0.14

2011-03-16 Thread Gleb Natapov
On Wed, Mar 16, 2011 at 06:49:27PM +0800, TeLeMan wrote: I have another problem: Windows 7 x86 setup hangs when Setup Is Starting Windows. Any suggestions? Same. Try -cpu Nehalem. I am not sure this alone will help, but worth trying. -- Gleb.

[Qemu-devel] [PATCH 7/7] Make VNC support optional

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Per default VNC is enabled. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.objs | 19 ++- configure | 37 + console.h | 26 -- monitor.c |

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-16 Thread Peter Maydell
On 16 March 2011 11:00, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is equivalent to -nographic) You forgot to

[Qemu-devel] Re: [PATCH 3/7] Introduce -display none

2011-03-16 Thread Peter Maydell
On 16 March 2011 11:00, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com New option -display none. This option differs from -display nographic by not trying to take control of stdio etc. but instead behaves as if a graphics display is enabled, except that it doesn't

Re: [Qemu-devel] Re: Windows 7 on pure qemu-0.14

2011-03-16 Thread TeLeMan
I tried. This issue should be associated with some IO device or bus. On 2011-03-16, Gleb Natapov g...@redhat.com wrote: On Wed, Mar 16, 2011 at 06:49:27PM +0800, TeLeMan wrote: I have another problem: Windows 7 x86 setup hangs when Setup Is Starting Windows. Any suggestions? Same. Try -cpu

[Qemu-devel] problems with alsa - Not able to hear sound on windows-xp

2011-03-16 Thread Wasim Muhammed
Hi All, I am Not able to hear sound on windows-xp ,I have built qemu statically with alsa support .Below is the log wat it spews out ,Can anyone help me out to solve this issue. Thanks wasim root@user-desktop:~/testing_qemu/qemu-kvm-0.14.0/x86_64-softmmu# export

[Qemu-devel] Re: [PATCH 2/7] Introduce -display argument

2011-03-16 Thread Jes Sorensen
On 03/16/11 12:46, Peter Maydell wrote: On 16 March 2011 11:00, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default/serial (serial is

Re: [Qemu-devel] ACPI table loading [was: q35 chipset support for native pci express support]

2011-03-16 Thread Isaku Yamahata
. (vgabios doesn't need patches, so use the upstream one) git clone http://people.valinux.co.jp/~yamahata/qemu/q35/20110316/qemu git clone http://people.valinux.co.jp/~yamahata/qemu/q35/20110316/seabios Example: qemu-system-x86_64 ... -M pc_q35 -acpitable 'load_header,data=roms

[Qemu-devel] IDE/SCSI devices support in ARM realview-pbx-a9 board

2011-03-16 Thread Sid Kapoor
Hi all, I am trying to run ARM realview-pbx-a9 board in QEMU. I am able to mount rootfs through NFS, by appending root=/dev/nfs. But I want to run the rootfs by creating a rootfs.img (by qemu-img command). I was running NFS rootfs as follows: $ qemu-system-arm -M realview-pbx-a9 -m 1024M

[Qemu-devel] [PATCH 4/7] Add support for -display vnc

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx |5 - vl.c| 14 ++ 2 files changed, 18 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 08a99b5..5f8dc04 100644

[Qemu-devel] [PATCH 1/7] Consolidate DisplaySurface allocation in qemu_alloc_display()

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This removes various code duplication from console.e and sdl.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- console.c | 46 -- console.h |2 ++ ui/sdl.c | 20 3 files

[Qemu-devel] [PATCH v5 0/7] Introduce -display and make VNC optional

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Hi, This is v5 version of the -display patches and the option to make VNC optional. It introduces a new -display argument to consolidate the current -sdl/-curses/-nographic/-vnc arguments. v5 fixes the commit messages and adds some documentation

[Qemu-devel] [PATCH 5/7] error message if user specifies SDL cmd line option when SDL is disabled

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx | 10 -- vl.c|8 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 5f8dc04..1193d94 100644

[Qemu-devel] [PATCH 3/7] Introduce -display none

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com New option -display none. This option differs from -nographic by not trying to take control of stdio etc. but instead behaves as if a graphics display is enabled, except that it doesn't show one. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

Re: [Qemu-devel] IDE/SCSI devices support in ARM realview-pbx-a9 board

2011-03-16 Thread Peter Maydell
On 16 March 2011 12:24, Sid Kapoor sidkapoor2...@gmail.com wrote: I am trying to run qemu after building rootfs.img as follows: $ qemu-system-arm -M realview-pbx-a9 -m 1024M -kernel zImage.rfs -serial stdio -append root=/dev/hda1 rw console=ttyAMA0 rdinit=/sbin/init -net nic -net

[Qemu-devel] [PATCH 7/7] Make VNC support optional

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Per default VNC is enabled. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- Makefile.objs | 19 ++- configure | 37 + console.h | 26 -- monitor.c |

[Qemu-devel] [PATCH 2/7] Introduce -display argument

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch introduces a -display argument which consolidates the setting of the display mode. Valid options are: sdl/curses/default Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx | 22 vl.c| 75

[Qemu-devel] [PATCH 6/7] error message if user specifies curses on cmd line when curses is disabled

2011-03-16 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- qemu-options.hx |2 -- vl.c|7 +-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 1193d94..ef60730 100644 ---

[Qemu-devel] [PATCH v2 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-16 Thread Alon Levy
Switching locking protection of ds-cursor_set/cursor_move to moving every call to these functions into the iothread and using the ssd-pipe to transfer that, adding QXL_SERVER_CURSOR_SET, QXL_SERVER_CURSOR_MOVE. This is tested with both -vnc :0 -spice and -sdl -spice. --- hw/qxl-render.c | 25

Re: [Qemu-devel] Developing custom PCI devices in qemu

2011-03-16 Thread Markus Armbruster
अनुज anu...@gmail.com writes: Hi All I am interested in developing a custom PCI device for qemu. For learning purpose, It could be just a very basic device e.g. a device which just loopbacks the contents from device memory to some system buffer. Please guide me how such a device can be

[Qemu-devel] [PATCH v2 3/4] qxl/spice: remove qemu_mutex_{un, }lock_iothread around dispatcher

2011-03-16 Thread Alon Levy
with the previous patch making sure get_command no longer needs to lock, there is no reason to drop the qemu iothread mutex in qxl.c and in ui/spice-display.c The only location where the lock remains are the cursor related callbacks, that path is currently broken. It is only triggered if running

[Qemu-devel] [PATCH v2 2/4] qxl: implement get_command in vga mode without locks

2011-03-16 Thread Alon Levy
From: Uri Lublin u...@redhat.com This patch and the next drop the requirement to lose the global qemu mutex during dispatcher calls. This patch enables it, the next drops the unlock/lock pairs around dispatcher calls. The current solution of dropping the locks is buggy: * it allows multiple

[Qemu-devel] Re: [PATCH master, stable] vhost: fix dirty page handling

2011-03-16 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: vhost was passing a physical address to cpu_physical_memory_set_dirty, which is wrong: we need to translate to ram address first. Signed-off-by: Michael S. Tsirkin m...@redhat.com Note: this lead to crashes during migration, so the patch is needed

[Qemu-devel] [PATCH v2 1/4] qxl/spice-display: move pipe to ssd

2011-03-16 Thread Alon Levy
this moves the int pipe[2] and pthread_t main data from the PCIQXLDevice struct to the SimpleSpiceDisplay. This will let us reuse it in the next patch for both -spice with no -qxl usage and for vga mode from qxl. --- hw/qxl.c | 32 hw/qxl.h |

Re: [Qemu-devel] IDE/SCSI devices support in ARM realview-pbx-a9 board

2011-03-16 Thread Sid Kapoor
Hi PMM, Thanks for a quick reply. Well if this is the case then I would stick to the NFS rootfs itself. Actually in the NFS case, the network bridge/tap that I have created is a bit scrappy. For eg., a file transfer runs for sometime and then halts for a minute or two, resulting in almost 8-10

[Qemu-devel] [PATCH v2 0/4] qxl: implement vga mode without locks

2011-03-16 Thread Alon Levy
v1-v2 changes: * patch 4 rewrite: instead of todos implemented usage of pipe for cursor_set and cursor_move. * small fixes: (Hans de Goede) * fix introducing function in patch 1 and renaming it in patch 2. (s/qxl_create_vcpu_to_iothread_pipe/qxl_create_server_to_iothread_pipe/) * move

  1   2   3   >