[Qemu-devel] [PATCH] Clean up after "make pdf"

2011-04-12 Thread Brad Hards
--- .gitignore |3 +++ Makefile |5 - 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index 1d79680..08013fc 100644 --- a/.gitignore +++ b/.gitignore @@ -44,6 +44,9 @@ QMP/qmp-commands.txt *.ky *.log *.pdf +*.cps +*.fns +*.kys *.pg *.pyc *

Re: [Qemu-devel] [PATCH 3/3] target-unicore32: mark a few helpers const + pure

2011-04-12 Thread Guan Xuetao
Applied, thanks. Tested-and-Acked-by: Guan Xuetao Guan > -Original Message- > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > Sent: Wednesday, April 13, 2011 6:31 AM > To: qemu-devel@nongnu.org > Cc: Aurelien Jarno; Guan Xuetao > Subject: [PATCH 3/3] target-unicore32: mark a few hel

[Qemu-devel] [PATCH] target-unicore32: move FPU helpers to op_helper.c

2011-04-12 Thread Guan Xuetao
The original patch missed the last empty line in target-unicore32/helper.c So I re-format it. Original patch From: Aurelien Jarno This patch moves FPU helpers to op_helper.c, which has direct access to the env pointer. This means one less argument to pass, so a gain in speed. Signed-off-by: Aur

Re: [Qemu-devel] [PATCH 1/3] target-unicore32: remove cpu_halted()

2011-04-12 Thread Guan Xuetao
Applied. Thanks. Guan Xuetao > -Original Message- > From: Aurelien Jarno [mailto:aurel...@aurel32.net] > Sent: Wednesday, April 13, 2011 6:31 AM > To: qemu-devel@nongnu.org > Cc: Aurelien Jarno; Guan Xuetao > Subject: [PATCH 1/3] target-unicore32: remove cpu_halted() > > cpu_halted() ha

Re: [Qemu-devel] [qemu-iotests][PATCH] Update rbd support

2011-04-12 Thread Josh Durgin
On Wed, 13 Apr 2011 04:43:39 +0200, Christoph Hellwig wrote: >> @@ -43,6 +43,10 @@ _supported_fmt raw >> _supported_proto generic >> _supported_os Linux >> >> +# rbd images are not growable >> +if [ "$IMGPROTO" = "rbd" ]; then >> +_notrun "image protocol $IMGPROTO does not support growable i

Re: [Qemu-devel] [PATCH 11/15] s390x: Implement opcode helpers

2011-04-12 Thread Alexander Graf
Am 12.04.2011 um 23:32 schrieb Aurelien Jarno : > On Mon, Apr 04, 2011 at 04:32:20PM +0200, Alexander Graf wrote: >> There are some instructions that can't (or shouldn't) be expressed by pure >> tcg code. For those, we call into externally compiled C functions. >> >> This patch implements those

Re: [Qemu-devel] [PATCH v3 0/4] Fix -icount with iothread

2011-04-12 Thread Paolo Bonzini
On 04/12/2011 11:50 PM, Edgar E. Iglesias wrote: I also tested the code and it works beautifully for my testcases! iothread & icount ran faster than icount without iothread. That's very good news, thanks! Paolo

Re: [Qemu-devel] [Bug 757702] Re: Undefined instruction exception starts at offset 0x8 instead of 0x4

2011-04-12 Thread Anup Patel
Hi, Were you able to replicate the problem with the steps that I had mentioned ? The key thing is is if you don't set breakpoint at 0x4 or 0x8 just follow the execution flow using "si" command of GDB. You will definitely hit the problem. --Anup On Tue, Apr 12, 2011 at 5:57 PM, Anup Patel wrote:

[Qemu-devel] [PATCH 03/19] target-i386: use CPU_LDoubleU instead of a private union

2011-04-12 Thread Aurelien Jarno
Use CPU_LDoubleU in cpu_dump_state() instead of redefining a union for doing the conversion. Based on a patch from Laurent Vivier . Cc: Laurent Vivier Signed-off-by: Aurelien Jarno --- target-i386/helper.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/targ

[Qemu-devel] [PATCH 00/19] softfloat and FPU fixes/improvements

2011-04-12 Thread Aurelien Jarno
This patch series started with the goal of improving the build of target-i386 with softfloat (instead of softfloat-native), but it slowly became a collection of fixes and improvements with regard to softfloat and targets FPU.

[Qemu-devel] [PATCH 02/19] cpu-all.h: define CPU_LDoubleU

2011-04-12 Thread Aurelien Jarno
Add a CPU_LDoubleU type, matching the floatx80 definition and the long double type on x86 hosts. Based on a patch from Laurent Vivier . Cc: Laurent Vivier Signed-off-by: Aurelien Jarno --- cpu-all.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/cpu-all.h b/

[Qemu-devel] [PATCH 04/19] target-i386: use float unions from cpu-all.h

2011-04-12 Thread Aurelien Jarno
Use float unions from cpu-all.h instead of redefining new (wrong for arm) ones in target-i386. This also allows building cpu-exec.o with softfloat. Signed-off-by: Aurelien Jarno --- target-i386/exec.h | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) diff --g

[Qemu-devel] [PATCH 12/19] softfloat: rename float*_eq_signaling() into float*_eq()

2011-04-12 Thread Aurelien Jarno
float*_eq_signaling functions have a different semantics than other comparison functions. Fix that by renaming float*_quiet_signaling() into float*_eq(). Note that it is purely mechanical, and the behaviour should be unchanged. Signed-off-by: Aurelien Jarno --- fpu/softfloat-native.h |6 +++

[Qemu-devel] [PATCH 01/19] softfloat: use GCC builtins to count the leading zeros

2011-04-12 Thread Aurelien Jarno
Softfloat has its own implementation to count the leading zeros. However a lot of architectures have either a dedicated instruction or an optimized to do that. When using GCC >= 3.4, this patch uses GCC builtins instead of the handcoded implementation. Note that I amware that QEMU_GNUC_PREREQ is d

Re: [Qemu-devel] [PATCH] target-arm: Don't overflow when calculating value for signed VABAL

2011-04-12 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 04:32:08PM +0100, Peter Maydell wrote: > In the VABAL instruction we take the absolute difference of two > values of size x and store it in a result of size 2x. This means > we have to be careful to calculate the absolute difference using > a wide enough type that we don't a

Re: [Qemu-devel] [PATCH 10/15] s390x: helper functions for system emulation

2011-04-12 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:19PM +0200, Alexander Graf wrote: > When running system emulation, we need to transverse through the MMU and > deliver interrupts according to the specification. > > This patch implements those two pieces and in addition adjusts the CPU > initialization code to accoun

Re: [Qemu-devel] [PATCH 2/2] Support for Cavium-Octeon specific instruction

2011-04-12 Thread Aurelien Jarno
On Sat, Apr 09, 2011 at 04:05:45PM +0500, Khansa Butt wrote: > From 7fd3ef1360b78ad85848e54e36d97ab50d77e6a6 Mon Sep 17 00:00:00 2001 > From: Ehsan-ul-Haq & Khansa Butt > Date: Sat, 9 Apr 2011 11:09:18 +0500 > Subject: [PATCH 2/2] Support for Cavium-Octeon specific instruction > > > Signed-off-b

Re: [Qemu-devel] [PATCH 1/2] Support for MIPS64 user mode emulation

2011-04-12 Thread Aurelien Jarno
[I don't know very well linux-user, it would be nice to Cc: Riku Voipio, the linux-user maintainer for the next version.] On Sat, Apr 09, 2011 at 04:02:31PM +0500, Khansa Butt wrote: > From e96e20e50cada1c9e1b65de5925281cdd5659746 Mon Sep 17 00:00:00 2001 > From: Ehsan-ul-Haq & Khansa Butt > Dat

Re: [Qemu-devel] [PATCH 12/15] s390x: Adjust internal kvm code

2011-04-12 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:21PM +0200, Alexander Graf wrote: > We're now finally emulating an s390x CPU, so we can move quite some logic > from the kvm code out into generic CPU code. > > This patch does this and adjusts the interfaces according to what the code > around now expects to be able

Re: [Qemu-devel] [qemu-iotests][PATCH] Update rbd support

2011-04-12 Thread Christoph Hellwig
> @@ -43,6 +43,10 @@ _supported_fmt raw > _supported_proto generic > _supported_os Linux > > +# rbd images are not growable > +if [ "$IMGPROTO" = "rbd" ]; then > +_notrun "image protocol $IMGPROTO does not support growable images" > +fi I suspect we only support the weird writing past size

Re: [Qemu-devel] [PATCH V2] fix acpi regression

2011-04-12 Thread Aurelien Jarno
On Tue, Apr 12, 2011 at 05:27:44PM +0800, Wen Congyang wrote: > This bug is introduced by commit 23910d3f. > > Signed-off-by: Wen Congyang > > --- > hw/acpi.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied. > diff --git a/hw/acpi.c b/hw/acpi.c > index e372474..a

Re: [Qemu-devel] [PATCH 17/19] target-ppc: fix SPE comparison functions

2011-04-12 Thread Nathan Froyd
On Tue, Apr 12, 2011 at 11:59:29PM +0200, Aurelien Jarno wrote: > Given that float32_*() functions are IEEE754 compliant, the efscmp*() > functions are correctly implemented, while efstst*() are not. This > patch reverse the implementation of this two groups of functions and > fix the comments. It

Re: [Qemu-devel] [PATCH 09/15] s390x: Prepare cpu.h for emulation

2011-04-12 Thread Aurelien Jarno
On Mon, Apr 04, 2011 at 04:32:18PM +0200, Alexander Graf wrote: > We need to add some more logic to the CPU description to leverage emulation > of an s390x CPU. This patch adds all the required helpers, fields in CPUState > and constant definitions required for user and system emulation. > > Signe

Re: [Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-12 Thread Stefan Hajnoczi
On Tue, Apr 12, 2011 at 4:38 PM, Sage Weil wrote: > On Tue, 12 Apr 2011, Stefan Hajnoczi wrote: >> On Tue, Apr 12, 2011 at 1:18 AM, Josh Durgin >> wrote: >> > On 04/08/2011 01:43 AM, Stefan Hajnoczi wrote: >> >> >> >> On Mon, Mar 28, 2011 at 04:15:57PM -0700, Josh Durgin wrote: >> >>> >> >>> lib

[Qemu-devel] [PATCH 17/19] target-ppc: fix SPE comparison functions

2011-04-12 Thread Aurelien Jarno
efstst*() functions are fast SPE funtions which do not take into account special values (infinites, NaN, etc.), while efscmp*() functions are IEEE754 compliant. Given that float32_*() functions are IEEE754 compliant, the efscmp*() functions are correctly implemented, while efstst*() are not. This

[Qemu-devel] [PATCH 14/19] softfloat: improve description of comparison functions

2011-04-12 Thread Aurelien Jarno
Make clear for all comparison functions which ones trigger an exception for all NaNs, and which one only for sNaNs. Signed-off-by: Aurelien Jarno --- fpu/softfloat.c | 85 +++ 1 files changed, 48 insertions(+), 37 deletions(-) diff --git a/f

[Qemu-devel] [PATCH 16/19] target-alpha: fix wrong usage of float64_eq_quiet()

2011-04-12 Thread Aurelien Jarno
On alpha, all NaN should trap during a comparison, not only sNaN. Fix this by using float64_eq() instead of float64_eq_quiet(). Signed-off-by: Aurelien Jarno (cherry picked from commit 64990e0735007f75fe03123c1339366bcb496268) --- target-alpha/op_helper.c |5 +++-- 1 files changed, 3 inserti

[Qemu-devel] [PATCH 10/19] target-i386: fix CMPUNORDPS/D and CMPORDPS/D instructions

2011-04-12 Thread Aurelien Jarno
SSE instructions CMPUNORDPS/D and CMPORDPS/D do not trigger an invalid exception if operands are qNANs. Signed-off-by: Aurelien Jarno --- target-i386/ops_sse.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h index 3232abd.

[Qemu-devel] [PATCH 09/19] target-mips: use new float*_unordered*() functions

2011-04-12 Thread Aurelien Jarno
Use the new float*_unordered*() functions from softfloat instead of redefining a private version. Signed-off-by: Aurelien Jarno --- target-mips/op_helper.c | 168 --- 1 files changed, 70 insertions(+), 98 deletions(-) diff --git a/target-mips/op_help

[Qemu-devel] [PATCH 11/19] softfloat: rename float*_eq() into float*_eq_quiet()

2011-04-12 Thread Aurelien Jarno
float*_eq functions have a different semantics than other comparison functions. Fix that by first renaming float*_quiet() into float*_eq_quiet(). Note that it is purely mechanical, and the behaviour should be unchanged. That said it clearly highlight problems due to this different semantics, they

[Qemu-devel] [PATCH 18/19] target-mips: simplify FP comparisons

2011-04-12 Thread Aurelien Jarno
As the softfloat comparison functions already test for NaN, there is no need to always call the float*_unordered*() functions. Signed-off-by: Aurelien Jarno --- target-mips/op_helper.c | 72 +++--- 1 files changed, 36 insertions(+), 36 deletions(-) diff

[Qemu-devel] [PATCH 08/19] target-alpha: use new float64_unordered() function

2011-04-12 Thread Aurelien Jarno
Use float64_unordered() in helper_cmptun() instead of doing the the comparison manually. This also fixes the wrong behaviours with sNaNs. Signed-off-by: Aurelien Jarno --- target-alpha/op_helper.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target-alpha/op_helper

Re: [Qemu-devel] [PATCH] target-arm: Don't overflow when calculating value for signed VABAL

2011-04-12 Thread Peter Maydell
On 12 April 2011 22:32, Aurelien Jarno wrote: > On Mon, Apr 11, 2011 at 04:32:08PM +0100, Peter Maydell wrote: >> @@ -1524,12 +1528,12 @@ uint64_t HELPER(neon_abdl_u16)(uint32_t a, uint32_t >> b) >>  { >>      uint64_t tmp; >>      uint64_t result; >> -    DO_ABD(result, a, b, uint8_t); >> -    

[Qemu-devel] [PATCH 13/19] softfloat: move float*_eq and float*_eq_quiet

2011-04-12 Thread Aurelien Jarno
I am not a big fan of code moving, but having the signaling version in the middle of quiet versions and vice versa doesn't make the code easy to read. This patch is a simple code move, basically swapping locations of float*_eq and float*_eq_quiet. Signed-off-by: Aurelien Jarno --- fpu/softfloat

[Qemu-devel] [PATCH 19/19] target-mips: don't hardcode softfloat exception bits

2011-04-12 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-mips/op_helper.c | 35 --- 1 files changed, 20 insertions(+), 15 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index abcb6eb..0a62361 100644 --- a/target-mips/op_helper.c +++ b/target-mips/op

[Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet()

2011-04-12 Thread Aurelien Jarno
I haven't look at the documentation, but for the neighbouring code it looks clear that floatx80_eq() should be used instead of floatx80_eq_quiet(). Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- linux-user/arm/nwfpe/fpa11_cprt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH 00/13] ARM: Handle UNDEF cases in Neon data processing insns

2011-04-12 Thread Aurelien Jarno
On Mon, Apr 11, 2011 at 04:26:10PM +0100, Peter Maydell wrote: > This extremely dull patch set cleans up the UNDEF handling in the Neon > data processing instruction space, so that we UNDEF in all the cases where > the architecture demands it, and do so early enough that we don't leak > a TCG tempo

[Qemu-devel] Model of simple Bus Mastering ADC for QEMU

2011-04-12 Thread wzab
Hi All, I'm interested in using of QEMU as a simple environment providing virtual hardware for my students, learning how to write device drivers for different devices. Unfortunately the QEMU's API seems to be not very strictly documented :-(. I've tried to implement a simple Analog to Digital Co

Re: [Qemu-devel] [PATCH] configure: disable opengl per default

2011-04-12 Thread Aurelien Jarno
On Sat, Apr 09, 2011 at 11:13:20PM +0200, Michael Walle wrote: > There is a bug in nvidia's binary GPU driver, which causes a segmentation > fault if linked to libGL. > > Signed-off-by: Michael Walle > --- > configure |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied.

Re: [Qemu-devel] [PATCH] Replace cpu_physical_memory_rw were possible

2011-04-12 Thread Aurelien Jarno
On Sun, Apr 10, 2011 at 06:23:39PM +0200, Stefan Weil wrote: > Using cpu_physical_memory_read, cpu_physical_memory_write and ldub_phys > improves readability and allows removing some type casts. > > lduw_phys and ldl_phys were not used because both require aligned > addresses. Therefore it is not

Re: [Qemu-devel] [PATCH 0/2] ARM: Detect FP tininess before rounding

2011-04-12 Thread Aurelien Jarno
On Tue, Apr 12, 2011 at 01:56:39PM +0100, Peter Maydell wrote: > Softfloat supports two kinds of FP tininess detection: before and > after rounding (corresponding to the two behaviours permitted by > IEEE754). The ARM architecture mandates detection before rounding, > so set the flag appropriately.

[Qemu-devel] [PATCH 3/4] milkymist-sysctl: fix timers

2011-04-12 Thread Michael Walle
Prevent timers from firing right after starting. Signed-off-by: Michael Walle --- hw/milkymist-sysctl.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/hw/milkymist-sysctl.c b/hw/milkymist-sysctl.c index eaea543..6bd0cb9 100644 --- a/hw/milkymis

Re: [Qemu-devel] [PATCH v3 0/4] Fix -icount with iothread

2011-04-12 Thread Edgar E. Iglesias
On Tue, Apr 12, 2011 at 03:26:39PM +0200, Paolo Bonzini wrote: > On 04/12/2011 11:26 AM, Jan Kiszka wrote: > > On 2011-04-12 10:44, Paolo Bonzini wrote: > >> This series finally fixes -icount with iothread and avoids deadlocks > >> due to the vm_clock not making progress when the VM is stopped. > >

Re: [Qemu-devel] [PATCH 1/2] Implement basic part of SA-1110/SA-1100

2011-04-12 Thread Aurelien Jarno
On Tue, Apr 12, 2011 at 05:09:02PM +0400, Dmitry Eremin-Solenikov wrote: > Basic implementation of DEC/Intel SA-1100/SA-1110 chips emulation. > Implemented: > - IRQs > - GPIO > - PPC > - RTC > - UARTs (no IrDA/etc.) > - OST reused from pxa25x > > Everything else is TODO (esp. PM/idle/sleep!)

[Qemu-devel] [PATCH 2/4] milkymist-vgafb: fix console resizing

2011-04-12 Thread Michael Walle
After enabling the framebuffer, ensure that the console is resized. Signed-off-by: Michael Walle --- hw/milkymist-vgafb.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/milkymist-vgafb.c b/hw/milkymist-vgafb.c index 8922731..2e55e42 100644 --- a/hw/milkymist-vgafb.

[Qemu-devel] [PATCH 1/4] lm32: fix exception handling

2011-04-12 Thread Michael Walle
Global interrupt enable bit is already saved within the exception handler helper routine. Thus remove extra code in translation routines. Additionally, debug exceptions has always DEBA as base address. Signed-off-by: Michael Walle --- target-lm32/helper.c|6 +- target-lm32/translate

[Qemu-devel] [PATCH 0/4] lm32 and BSP fixes

2011-04-12 Thread Michael Walle
This patchset combines some lm32/bsp fixes and support for the new Milkymist minimac2 hardware.

[Qemu-devel] [PATCH 1/3] target-unicore32: remove cpu_halted()

2011-04-12 Thread Aurelien Jarno
cpu_halted() has been removed on all targets in commit eda48c344f35e5bd511dea3e8be56fb08c19b399. Also remove it on unicore32. Cc: Guan Xuetao Signed-off-by: Aurelien Jarno --- target-unicore32/exec.h | 15 --- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/target-

[Qemu-devel] [PATCH 4/4] lm32: add Milkymist Minimac2 support

2011-04-12 Thread Michael Walle
This patch adds support for Milkymist's minimal Ethernet MAC v2. It superseds minimac1. Signed-off-by: Michael Walle --- Makefile.target |2 +- hw/milkymist-hw.h | 20 ++ hw/milkymist-minimac.c | 568 --- hw/milkymist-minimac2.c |

[Qemu-devel] [PATCH 06/19] softfloat: add float*_unordered_{, quiet}() functions

2011-04-12 Thread Aurelien Jarno
Add float*_unordered() functions to softfloat, matching the softfloat-native ones. Also add float*_unordered_quiet() functions to match the others comparison functions. This allow target-i386/ops_sse.h to be compiled with softfloat. Signed-off-by: Aurelien Jarno --- fpu/softfloat.c | 167 +

[Qemu-devel] [PATCH 07/19] softfloat-native: add float*_unordered_quiet() functions

2011-04-12 Thread Aurelien Jarno
Add float*_unordered_quiet() functions to march the softfloat versions. As FPU status is not tracked with softfloat-native, they don't differ from the signaling version. Signed-off-by: Aurelien Jarno --- fpu/softfloat-native.h | 15 --- 1 files changed, 12 insertions(+), 3 deletion

[Qemu-devel] [PATCH 3/3] target-unicore32: mark a few helpers const + pure

2011-04-12 Thread Aurelien Jarno
Helpers that do not trigger exceptions and do only access to the arguments can be declared as const + pure. Cc: Guan Xuetao Signed-off-by: Aurelien Jarno --- target-unicore32/helper.h | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target-unicore32/helper.h

[Qemu-devel] [PATCH 2/3] target-unicore32: move FPU helpers to op_helper.c

2011-04-12 Thread Aurelien Jarno
This patch moves FPU helpers to op_helper.c, which has direct access to the env pointer. This means one less argument to pass, so a gain in speed. Cc: Guan Xuetao Signed-off-by: Aurelien Jarno --- target-unicore32/helper.c| 329 -- target-unicore32/h

[Qemu-devel] [PATCH 05/19] target-i386: add floatx_{add, mul, sub} and use them

2011-04-12 Thread Aurelien Jarno
Add floatx_{add,mul,sub} defines, and use them instead of using direct C operations. Signed-off-by: Aurelien Jarno --- target-i386/exec.h |6 ++ target-i386/op_helper.c | 18 -- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/target-i386/exec.h b/t

Re: [Qemu-devel] [PATCH 15/19] target-arm: fix wrong usage of floatx80_eq_quiet()

2011-04-12 Thread Peter Maydell
On 12 April 2011 22:59, Aurelien Jarno wrote: > I haven't look at the documentation, but for the neighbouring code it looks > clear that floatx80_eq() should be used instead of floatx80_eq_quiet(). Actually I think it's irrelevant -- PerformComparisonOperation() is called only once, and the code

[Qemu-devel] [PATCH v3 1/4] rbd: use the higher level librbd instead of just librados

2011-04-12 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 787 +++-

[Qemu-devel] [PATCH v3 2/4] rbd: allow configuration of rados from the rbd filename

2011-04-12 Thread Josh Durgin
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies a Ceph configuration file to read. This allows rbd volumes from more than one Ceph cluster to be used by speci

Re: [Qemu-devel] [PATCH 2/2] add fw_dir option to option-rom switch

2011-04-12 Thread Glauber Costa
On Tue, 2011-04-12 at 14:19 -0500, Anthony Liguori wrote: > On 04/12/2011 01:47 PM, Glauber Costa wrote: > > For sure, but if we had this discussion a while ago, > > sgabios wouldn't exist back then, and now it does =p > > Actually, it's been around for ages :-) > > >>>And the fact that not a

[Qemu-devel] [PATCH v3 3/4] rbd: check return values when scheduling aio

2011-04-12 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20 insertions(+), 4 deletions(-) dif

[Qemu-devel] [PATCH v3 4/4] rbd: Add bdrv_truncate implementation

2011-04-12 Thread Josh Durgin
Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index ac20282..4514dbd 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -686,6 +686,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState *b

[Qemu-devel] [PATCH 3/3] Slirp Reverse UDP Firewall

2011-04-12 Thread Daisuke Nojiri
This patch series adds a reverse UDP firewall functionality to Slirp. The series consists of three patches. Each adds one -net user option: 1. dropudp=y|n - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=udp:ADDR:PORT - adds an allow rule e.g.) $ qemu -ne

[Qemu-devel] [qemu-iotests][PATCH] Update rbd support

2011-04-12 Thread Josh Durgin
rbd is not growable, so test 016 is skipped. rbd implements bdrv_truncate, so test 025 will work. Signed-off-by: Josh Durgin --- 016 |4 025 |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/016 b/016 index 16f151f..8fa921f 100755 --- a/016 +++ b/016 @@ -43,6 +4

[Qemu-devel] [PATCH 1/3] Slirp Reverse UDP Firewall

2011-04-12 Thread Daisuke Nojiri
This patch series adds a reverse UDP firewall functionality to Slirp. The series consists of three patches. Each adds one -net user option: 1. dropudp=y|n - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=udp:ADDR:PORT - adds an allow rule e.g.) $ qemu -ne

[Qemu-devel] [PATCH v3 0/4] rbd improvements

2011-04-12 Thread Josh Durgin
This patchset moves the complexity of the rbd format into librbd and adds truncation support. This passes qemu-iotests when 016 is skipped. A patch for this is in a separate email. Changes since v2: * return values are checked in rbd_aio_rw_vector * bdrv_truncate added Josh Durgin (4): rbd: u

[Qemu-devel] [PATCH 2/3] Slirp Reverse UDP Firewal

2011-04-12 Thread Daisuke Nojiri
This patch series adds a reverse UDP firewall functionality to Slirp. The series consists of three patches. Each adds one -net user option: 1. dropudp=y|n - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=udp:ADDR:PORT - adds an allow rule e.g.) $ qemu -ne

[Qemu-devel] [PATCH 3/3] Slirp Reverse UDP Firewall

2011-04-12 Thread Daisuke Nojiri
This patch series adds a reverse UDP firewall functionality to Slirp. The series consists of three patches. Each adds one -net user option: 1. dropudp=y|n - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=udp:ADDR:PORT - adds an allow rule e.g.) $ qemu -ne

[Qemu-devel] [PATCH 3/3] Slirp Reverse UDP Firewall

2011-04-12 Thread Daisuke Nojiri
This patch series adds a reverse UDP firewall functionality to Slirp. The series consists of three patches. Each adds one -net user option: 1. dropudp=y|n - enables the firewall 2. droplog=FILE - sets the drop log filename 3. allow=udp:ADDR:PORT - adds an allow rule e.g.) $ qemu -ne

[Qemu-devel] [Bug 754591] Re: NIC doesn't work when it had been used before

2011-04-12 Thread Alex Williamson
Nevermind, reproduced on 2.6.38 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/754591 Title: NIC doesn't work when it had been used before Status in QEMU: New Bug description: Environment: -

Re: [Qemu-devel] [PATCHv3 0/3] unicore32: add unicore32-linux-user support for qemu 0.14

2011-04-12 Thread Blue Swirl
On Tue, Apr 12, 2011 at 11:25 AM, Guan Xuetao wrote: > > The patch set adds new unicore32-linux-user support for qemu-stable-0.14 >    Patch 1 adds target-unicore32 directory >    Patch 2 adds linux-user/unicore32 directory >    Patch 3 adds necessary modifications for other files Thanks, applied

Re: [Qemu-devel] [PATCH 2/2] add fw_dir option to option-rom switch

2011-04-12 Thread Anthony Liguori
On 04/12/2011 01:47 PM, Glauber Costa wrote: For sure, but if we had this discussion a while ago, sgabios wouldn't exist back then, and now it does =p Actually, it's been around for ages :-) And the fact that not all of them should live in genroms persists. Actually genroms should disappe

Re: [Qemu-devel] [PATCH 2/2] add fw_dir option to option-rom switch

2011-04-12 Thread Glauber Costa
On Tue, 2011-04-12 at 13:31 -0500, Anthony Liguori wrote: > On 04/12/2011 01:13 PM, Glauber Costa wrote: > > On Tue, 2011-04-12 at 12:40 -0500, Anthony Liguori wrote: > >> On 04/12/2011 12:23 PM, Glauber Costa wrote: > >>> The option-rom puts all roms passed by this switch in the genroms > >>> dir

Re: [Qemu-devel] [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command

2011-04-12 Thread Blue Swirl
On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity wrote: > On 04/11/2011 08:15 PM, Blue Swirl wrote: >> >> On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbruster >>  wrote: >> >  Avi Kivity  writes: >> > >> >>  On 04/08/2011 12:41 AM, Anthony Liguori wrote: >> >>> >> >>>  And it's a good thing to have, bu

Re: [Qemu-devel] [PATCH 2/2] add fw_dir option to option-rom switch

2011-04-12 Thread Anthony Liguori
On 04/12/2011 01:13 PM, Glauber Costa wrote: On Tue, 2011-04-12 at 12:40 -0500, Anthony Liguori wrote: On 04/12/2011 12:23 PM, Glauber Costa wrote: The option-rom puts all roms passed by this switch in the genroms directory, through the fw_dir option. But as it turns out, not all roms should be

Re: [Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-12 Thread Josh Durgin
On 04/12/2011 01:54 AM, Stefan Hajnoczi wrote: Is qemu-iotests passing for you now? Yes, they all pass when 016 is skipped. Josh

Re: [Qemu-devel] [PATCH 2/2] add fw_dir option to option-rom switch

2011-04-12 Thread Glauber Costa
On Tue, 2011-04-12 at 12:40 -0500, Anthony Liguori wrote: > On 04/12/2011 12:23 PM, Glauber Costa wrote: > > The option-rom puts all roms passed by this switch in the genroms directory, > > through the fw_dir option. But as it turns out, not all roms should be > > placed there. > > > > VGA roms ar

Re: [Qemu-devel] [PATCH 2/2] add fw_dir option to option-rom switch

2011-04-12 Thread Anthony Liguori
On 04/12/2011 12:23 PM, Glauber Costa wrote: The option-rom puts all roms passed by this switch in the genroms directory, through the fw_dir option. But as it turns out, not all roms should be placed there. VGA roms are a of a different kind. They live in a different segment, and are scanned f

Re: [Qemu-devel] [V9fs-developer] Breaking out virtfs as a standalone server?

2011-04-12 Thread Rob Landley
On 04/12/2011 09:34 AM, Venkateswararao Jujjuri wrote: > On 04/11/2011 10:52 PM, Rob Landley wrote: >> On 04/11/2011 03:28 PM, Venkateswararao Jujjuri wrote: >>> On 04/11/2011 06:42 AM, Rob Landley wrote: Right now, there's no decent userspace server for the 9p filesystem that I can find.

[Qemu-devel] [PATCH 2/2] add fw_dir option to option-rom switch

2011-04-12 Thread Glauber Costa
The option-rom puts all roms passed by this switch in the genroms directory, through the fw_dir option. But as it turns out, not all roms should be placed there. VGA roms are a of a different kind. They live in a different segment, and are scanned first. This patch allows qemu to use external vg

[Qemu-devel] [PATCH 1/2] document bootindex option

2011-04-12 Thread Glauber Costa
bootindex option was added to -option-rom switch, but never documented. Signed-off-by: Glauber Costa --- qemu-options.hx | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 18f54d2..96927cc 100644 --- a/qemu-options.hx +++ b/

[Qemu-devel] [PATCH 0/2] allow fw_dir to be specified in the option-rom switch

2011-04-12 Thread Glauber Costa
Some roms should not live in genroms/, the default place for all roms passed through -option-rom switch. Rather, they'd like to be placed in vgaroms. This patch allows it to happen. Glauber Costa (2): document bootindex option add fw_dir option to option-rom switch hw/pc.c |7 +++

Re: [Qemu-devel] [PATCH] Slirp reverse UDP firewall

2011-04-12 Thread Jan Kiszka
On 2011-04-12 18:19, Daisuke Nojiri wrote: > This patch adds: -drop-udp, -allow-udp ADDR:PORT, -drop-log FILE > > e.g.) $ qemu -net user -drop-log qemu.drop -drop-udp -allow-udp > 10.0.2.3:53 No more stand-alone slirp arguments please. That syntax breaks when instantiating >1 back-ends. > > -

Re: [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-12 Thread Paolo Bonzini
On 04/12/2011 06:06 PM, Amit Shah wrote: The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a mandatory command in the spec but we don't really implement it any of its sub-commands. The commit message for the last commit explains why implementing just the media subcommand is helpful an

[Qemu-devel] [PATCH] Slirp reverse UDP firewall

2011-04-12 Thread Daisuke Nojiri
This patch adds: -drop-udp, -allow-udp ADDR:PORT, -drop-log FILE e.g.) $ qemu -net user -drop-log qemu.drop -drop-udp -allow-udp 10.0.2.3:53 -drop-udp enables usermode firewall for out-going UDP packats from a guest. All UDP packets except ones allowed by -allow-udp will be dropped. Dropped pac

[Qemu-devel] [Bug 691424] Re: qemu/kvm SDL over ssh -X broken

2011-04-12 Thread Bernhard M. Wiedemann
I now found that it depends on my client side. The bug happens when I ssh -XC from my netbook with 1024x600(intel) to a server, but when I ssh -XC to the same server from my laptop with 1024x768(fbdev), then it works. So might be that the scaling code that made the difference in my bisecting, is

Re: [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-12 Thread Jes Sorensen
On 04/12/11 18:06, Amit Shah wrote: > The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a > mandatory command in the spec but we don't really implement it any of > its sub-commands. > > The commit message for the last commit explains why implementing just > the media subcommand is helpf

[Qemu-devel] [PATCH v5 4/5] atapi: GESN: Standardise event response handling for future additions

2011-04-12 Thread Amit Shah
Handle GET_EVENT_STATUS_NOTIFICATION's No Event Available response in a generic way so that future additions to the code to handle other response types is easier. Signed-off-by: Amit Shah --- hw/ide/core.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH v5 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Amit Shah
Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION command. This helps us report tray open, tray closed, no media, media present states to the guest. Newer Linux kernels (2.6.38+) rely on this command to revalidate discs after media change. This patch also sends out tray open

[Qemu-devel] [PATCH v5 3/5] atapi: GESN: Use structs for commonly-used field types

2011-04-12 Thread Amit Shah
Instead of using magic numbers, use structs that are more descriptive of the fields being used. Signed-off-by: Amit Shah --- hw/ide/core.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 5b64676..3fa2044 100644 --- a/hw

[Qemu-devel] [PATCH v5 2/5] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function

2011-04-12 Thread Amit Shah
This makes the code more readable. Also, there's a block like: if () { ... } else { ... } Split that into if () { ... return; } ... Signed-off-by: Amit Shah --- hw/ide/core.c | 37 - 1 files changed, 24 insertions(+), 13 deletions(-) diff --git

[Qemu-devel] [PATCH v5 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change

2011-04-12 Thread Amit Shah
After a media change, the only commands allowed from the guest were REQUEST_SENSE and INQUIRY. The guest may also issue GET_EVENT_STATUS_NOTIFICATION commands to get media changed notification. Signed-off-by: Amit Shah --- hw/ide/core.c | 20 ++-- 1 files changed, 14 insertion

[Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN

2011-04-12 Thread Amit Shah
The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a mandatory command in the spec but we don't really implement it any of its sub-commands. The commit message for the last commit explains why implementing just the media subcommand is helpful and how it goes a long way in getting guests

Re: [Qemu-devel] [PATCH V12 05/17] xen: Add xenfv machine

2011-04-12 Thread Jan Kiszka
On 2011-04-12 16:57, Anthony PERARD wrote: > On Mon, Apr 11, 2011 at 20:55, Jan Kiszka wrote: >> >> On 2011-04-11 20:10, Anthony PERARD wrote: > } > > static CPUState *pc_new_cpu(const char *cpu_model) > @@ -952,7 +957,12 @@ void pc_cpus_init(const char *cpu_model) > #endif

Re: [Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-12 Thread Sage Weil
On Tue, 12 Apr 2011, Stefan Hajnoczi wrote: > On Tue, Apr 12, 2011 at 1:18 AM, Josh Durgin > wrote: > > On 04/08/2011 01:43 AM, Stefan Hajnoczi wrote: > >> > >> On Mon, Mar 28, 2011 at 04:15:57PM -0700, Josh Durgin wrote: > >>> > >>> librbd stacks on top of librados to provide access > >>> to rbd

Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [17:11:22], Kevin Wolf wrote: > Am 12.04.2011 17:03, schrieb Amit Shah: > > On (Tue) 12 Apr 2011 [16:54:53], Kevin Wolf wrote: > >> Am 12.04.2011 16:09, schrieb Amit Shah: > >>> Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION > >>> command. This helps us

Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Jes Sorensen
On 04/12/11 17:13, Kevin Wolf wrote: > Am 12.04.2011 17:03, schrieb Jes Sorensen: >> Shouldn't you verify that you don't exceed max_len in this? > > Not necessary (the buffer is always 2048 bytes), but it looks like the > max_len parameter is unused now, so it could be removed. > > Kevin That wo

Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 17:03, schrieb Jes Sorensen: > On 04/12/11 16:09, Amit Shah wrote: >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index dafc049..209d8e6 100644 >> --- a/hw/ide/core.c >> +++ b/hw/ide/core.c >> @@ -1084,6 +1084,49 @@ static int ide_dvd_read_structure(IDEState *s, int >> format, >>

Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Kevin Wolf
Am 12.04.2011 17:03, schrieb Amit Shah: > On (Tue) 12 Apr 2011 [16:54:53], Kevin Wolf wrote: >> Am 12.04.2011 16:09, schrieb Amit Shah: >>> Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION >>> command. This helps us report tray open, tray closed, no media, media >>> present s

Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [20:33:39], Amit Shah wrote: > On (Tue) 12 Apr 2011 [16:54:53], Kevin Wolf wrote: > > Am 12.04.2011 16:09, schrieb Amit Shah: > > > Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION > > > command. This helps us report tray open, tray closed, no media, medi

Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Jes Sorensen
On 04/12/11 16:09, Amit Shah wrote: > diff --git a/hw/ide/core.c b/hw/ide/core.c > index dafc049..209d8e6 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -1084,6 +1084,49 @@ static int ide_dvd_read_structure(IDEState *s, int > format, > } > } > > +static unsigned int event_status_m

Re: [Qemu-devel] [PATCH v4 5/5] atapi: GESN: implement 'media' subcommand

2011-04-12 Thread Amit Shah
On (Tue) 12 Apr 2011 [16:54:53], Kevin Wolf wrote: > Am 12.04.2011 16:09, schrieb Amit Shah: > > Implement the 'media' sub-command of the GET_EVENT_STATUS_NOTIFICATION > > command. This helps us report tray open, tray closed, no media, media > > present states to the guest. > > > > Newer Linux ke

  1   2   3   >