Re: [Qemu-devel] [PATCH 6/9] net: Improve layout of 'info network'

2011-06-08 Thread Markus Armbruster
Jan Kiszka writes: > Improve the layout when listing non-vlan clients via 'info network'. The > result looks like this: > > (qemu) info network > Devices not on any VLAN: > orphan: net=10.0.2.0, restricted=n > virtio-net-pci.0: model=virtio-net-pci,macaddr=52:54:00:12:34:56 >\ network2: f

Re: [Qemu-devel] [PATCH 0/9] Various net and slirp fixes & enhancements

2011-06-08 Thread Markus Armbruster
6-9/9 look good. I didn't review the slirp stuff.

Re: [Qemu-devel] [PATCH] hw/usb-ohci.c: Implement remote wakeup

2011-06-08 Thread Gerd Hoffmann
This patch fixes USB keyboard support on (the not-yet-upstream) OMAP3 for me -- without it Linux puts the port and then the OHCI controller into suspend, and usb-kbd can't get the controller out of reset when you press a key. It works for me and I think it's right, but I'm no USB expert and it co

Re: [Qemu-devel] [PATCH] hw/usb-ohci.c: Ignore writes to HcPeriodCurrentED register

2011-06-08 Thread Gerd Hoffmann
Hi, I'm not sure what the consensus is for cases like this where QEMU's correct to warn about dodgy device access but a popular operating system(tm) does them anyway. Suppressing the warning seems a bit more user-friendly to the average QEMU user... It is also a (minor) DoS, the guest can fl

Re: [Qemu-devel] [PATCH 2/2] ioapic: Implement polarity

2011-06-08 Thread Stefan Hajnoczi
On Tue, Jun 07, 2011 at 05:55:10PM +0200, Jan Kiszka wrote: > On 2011-05-15 13:07, Jan Kiszka wrote: > > From: Jan Kiszka > > > > If the polarity bit is set in a redirection table entry, the input level > > simply has to inverted as it is low active in this case. > > Ping for this and > http://t

Re: [Qemu-devel] Qcow2

2011-06-08 Thread Stefan Hajnoczi
On Tue, Jun 7, 2011 at 6:10 PM, wrote: > Any update on this... what could be the reason... If I am not able to > start VM and if I add two virtual hard disk and one virtual hard disk is > more than 500GB. > > Virtual harddisk type is virtio. Created by using qcow2 Sorry, nothing obvious from you

[Qemu-devel] [PATCH 4/6] m68k: Replace gen_im32() by tcg_const_i32()

2011-06-08 Thread Stefan Hajnoczi
From: Laurent Vivier Signed-off-by: Laurent Vivier Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- target-m68k/translate.c | 43 --- 1 files changed, 20 insertions(+), 23 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/

Re: [Qemu-devel] [RFC v2 00/10] ISA reconfigurability v2

2011-06-08 Thread Gerd Hoffmann
Hi, Just wondering, if we're allowing to change qdev properties at runtime here, don't these fields need to be considered for VMState? Yes. Option one is to have the isa devices save them themself, option two is to save them as part of the pc87312 state. cheers, Gerd

[Qemu-devel] [PATCH v2 6/9] net: Improve layout of 'info network'

2011-06-08 Thread Jan Kiszka
Improve the layout when listing non-vlan clients via 'info network'. The result looks like this: (qemu) info network Devices not on any VLAN: orphan: net=10.0.2.0, restricted=n virtio-net-pci.0: model=virtio-net-pci,macaddr=52:54:00:12:34:56 \ network2: fd=5 e1000.0: model=e1000,macaddr=5

[Qemu-devel] [PATCH v2 8/9] net: Dump client type 'info network'

2011-06-08 Thread Jan Kiszka
Include the client type name into the output of 'info network'. The result looks like this: (qemu) info network VLAN 0 devices: rtl8139.0: type=nic,model=rtl8139,macaddr=52:54:00:12:34:57 Devices not on any VLAN: virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56 \ ne

[Qemu-devel] [PATCH 5/6] target-i386: Make x86 mfence and lfence illegal without SSE2

2011-06-08 Thread Stefan Hajnoczi
From: Martin Simmons While trying to use qemu -cpu pentium3 to test for incorrect uses of certain SSE2 instructions, I found that QEMU allowed the mfence and lfence instructions to be executed even though Pentium 3 doesn't support them. According to the processor specs (and experience on a real

Re: [Qemu-devel] [PATCH] virtio: Move virtio-pci to hw library

2011-06-08 Thread Stefan Hajnoczi
On Tue, Jun 07, 2011 at 05:55:01PM +0200, Jan Kiszka wrote: > On 2011-05-15 00:44, Aurelien Jarno wrote: > > On Tue, Apr 26, 2011 at 01:32:08PM +0200, Jan Kiszka wrote: > >> This module has no target dependencies (except for target_phys_addr_t > >> size) and can thus be built as part of libhw. > >>

[Qemu-devel] [PATCH 1/6] Fix compilation warning due to missing header for sigaction

2011-06-08 Thread Stefan Hajnoczi
From: Alexandre Raymond Fix the following warning by including signal.h directly in qemu-common.h 8< iohandler.c: In function ‘qemu_init_child_watch’: iohandler.c:172: warning: implicit declaration of function ‘sigaction’ iohandler.c:172: warning: nested extern declaration of ‘sigaction’

[Qemu-devel] [PATCH 3/6] slirp: fix guestfwd id

2011-06-08 Thread Stefan Hajnoczi
From: Alexander Graf When using -net user,guestfwd=... Qemu immediately complains about the id being in invalid format. This is because we pass in an id that contains a colon, while the id restrictions don't allow colons. This patch changes the colon into a dot, making guestfwd work again. Sign

[Qemu-devel] [PULL 0/6] Trivial patches for May 30 to June 8 2011

2011-06-08 Thread Stefan Hajnoczi
The following changes since commit a90d4690074526f54ad0851fce19fa6783f06803: Add an isa device for SGA (2011-06-07 13:52:30 -0500) are available in the git repository at: git://repo.or.cz/qemu/stefanha.git trivial-patches Alexander Graf (1): slirp: fix guestfwd id Alexandre Raymond (2

[Qemu-devel] [PATCH 6/6] virtio: Move virtio-pci to hw library

2011-06-08 Thread Stefan Hajnoczi
From: Jan Kiszka This module has no target dependencies (except for target_phys_addr_t size) and can thus be built as part of libhw. Signed-off-by: Jan Kiszka Reviewed-by: Aurelien Jarno Signed-off-by: Stefan Hajnoczi --- Makefile.objs |1 + Makefile.target |1 - 2 files changed, 1

[Qemu-devel] [PATCH 2/6] Fix compilation warning due to missing header for sigaction (followup)

2011-06-08 Thread Stefan Hajnoczi
From: Alexandre Raymond This patch removes all references to signal.h when qemu-common.h is included as they become redundant. Signed-off-by: Alexandre Raymond Signed-off-by: Stefan Hajnoczi --- audio/audio_pt_int.c |2 -- audio/sdlaudio.c |1 - block/raw-posix.c |2 --

[Qemu-devel] [PATCH] Fix a number of unused-but-set-variable warnings (new with gcc-4.6)

2011-06-08 Thread Hans de Goede
--- hw/lsi53c895a.c |2 -- target-i386/kvm.c |4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 83084b6..90c6cbc 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -889,7 +889,6 @@ static void lsi_do_msgout(LSIState *s)

Re: [Qemu-devel] [PATCH v3 1/2] pxa2xx_lcd: add proper rotation support

2011-06-08 Thread Vasily Khoruzhick
On Friday 03 June 2011 18:36:36 Vasily Khoruzhick wrote: > Until now, pxa2xx_lcd only supported 90deg rotation, but > some machines (for example Zipit Z2) needs 270deg rotation. > > Signed-off-by: Vasily Khoruzhick Ping

Re: [Qemu-devel] [PATCH] Fix a number of unused-but-set-variable warnings (new with gcc-4.6)

2011-06-08 Thread Kevin Wolf
Am 08.06.2011 10:28, schrieb Hans de Goede: > --- > hw/lsi53c895a.c |2 -- > target-i386/kvm.c |4 ++-- > 2 files changed, 2 insertions(+), 4 deletions(-) SoB is missing. And don't we have multiple patches to fix the same thing already? Someone should just merge them... Kevin

Re: [Qemu-devel] [PATCH v2 6/9] net: Improve layout of 'info network'

2011-06-08 Thread Markus Armbruster
Jan Kiszka writes: > Improve the layout when listing non-vlan clients via 'info network'. The > result looks like this: > > (qemu) info network > Devices not on any VLAN: > orphan: net=10.0.2.0, restricted=n > virtio-net-pci.0: model=virtio-net-pci,macaddr=52:54:00:12:34:56 >\ network2: f

Re: [Qemu-devel] Qcow2

2011-06-08 Thread arun.sasi1
Hello Stephen. Error from Syslog messages. - May 30 11:36:49 sd0005srv01 libvirtd: 11:36:49.044: error : internal error Timed out while reading console log output May 30 11:36:49 sd0005srv01 libvirtd: 11:36:49.044: error : internal error unable to start guest:

Re: [Qemu-devel] [PATCH v3 1/2] pxa2xx_lcd: add proper rotation support

2011-06-08 Thread Peter Maydell
On 3 June 2011 16:36, Vasily Khoruzhick wrote: > Until now, pxa2xx_lcd only supported 90deg rotation, but > some machines (for example Zipit Z2) needs 270deg rotation. > > Signed-off-by: Vasily Khoruzhick Still haven't tested this yet, but some very quick first pass comments. > +static void px

[Qemu-devel] [PATCH v2] qcow2: Fix in-flight list after qcow2_cache_put failure

2011-06-08 Thread Kevin Wolf
If qcow2_cache_put returns an error during cluster allocation and the allocation fails, it must be removed from the list of in-flight allocations. Otherwise we'd get a loop in the list when the ACB is used for the next allocation. Luckily, this qcow2_cache_put shouldn't fail anyway because the L2

[Qemu-devel] QEMU suitable for mission critical applications?

2011-06-08 Thread Felix Oxley
Hello, I have a an (almost) EOL factory planning system running on Solaris Sparc which I would like to move to intel (and preferably virtualise) in order to avoid having to maintain the Sun system and backup system. The text based cobol application runs on this system: SunOS gplan 5.9 Generic_1185

[Qemu-devel] [PATCH 5/7] ahci/intel-hda: Properly reset MSI state

2011-06-08 Thread Jan Kiszka
Also invoke msi_reset on device reset to unsure proper config space state. CC: Gerd Hoffmann CC: Alexander Graf Signed-off-by: Jan Kiszka --- hw/ide/ahci.c |2 ++ hw/intel-hda.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1

[Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Jan Kiszka
Terminate msi/msix_write_config early if support is not enabled. This allows to remove checks at the caller site if MSI is optional. CC: Gerd Hoffmann Signed-off-by: Jan Kiszka --- hw/intel-hda.c |6 +- hw/msi.c |3 ++- hw/msix.c |2 +- 3 files changed, 4 insertions(+

[Qemu-devel] [PATCH 0/7] msi: Small cleanups and fixes

2011-06-08 Thread Jan Kiszka
A few patches to the MSI and MSI-X layer that clean up the interfaces and fix reset issues. They are from my MSI rework to prepare it for KVM's requirements (in-kernel irqchip). CC: Alexander Graf CC: Gerd Hoffmann Jan Kiszka (7): msi: Fix copy&paste mistake in msi_uninit msi: Guard msi/msi

[Qemu-devel] [PATCH 4/7] msi: Use msi/msix_present more consistently

2011-06-08 Thread Jan Kiszka
Replace some open-coded msi/msix_present checks and drop redundant msix_supported tests (present implies supported). Signed-off-by: Jan Kiszka --- hw/msi.c |2 +- hw/msix.c | 13 - 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index b039893

[Qemu-devel] [PATCH 1/7] msi: Fix copy&paste mistake in msi_uninit

2011-06-08 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/msi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index b087fe5..e8c5607 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -172,7 +172,7 @@ void msi_uninit(struct PCIDevice *dev) } flags = pci_get_word(dev->config

[Qemu-devel] [PATCH 7/7] msi: Move PCI_MSI_PENDING_32/64 into pci_regs.h

2011-06-08 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/msi.c |4 hw/pci_regs.h |2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 09bcdd1..edd3e5b 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -21,10 +21,6 @@ #include "msi.h" #include "range.h" -/* Eventuall

[Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them

2011-06-08 Thread Jan Kiszka
Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant names to libpci style. Will be used for device assignment code in qemu-kvm. Signed-off-by: Jan Kiszka --- hw/msix.c | 24 +++- hw/pci_regs.h | 14 -- 2 files changed, 19 insertions(+),

[Qemu-devel] [PATCH 3/7] msi: Guard msi_reset with msi_present

2011-06-08 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/msi.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index b7a92c9..b039893 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -183,6 +183,10 @@ void msi_reset(PCIDevice *dev) uint16_t flags; bool msi64bit; +if

Re: [Qemu-devel] [PATCH 5/7] ahci/intel-hda: Properly reset MSI state

2011-06-08 Thread Alexander Graf
On 08.06.2011, at 12:26, Jan Kiszka wrote: > Also invoke msi_reset on device reset to unsure proper config space ensure. Otherwise looks sane :) Alex

[Qemu-devel] [PATCH 8/7] ivshmem: Reset MSI-X state on device reset

2011-06-08 Thread Jan Kiszka
CC: Cam Macdonell Signed-off-by: Jan Kiszka --- hw/ivshmem.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index 7b19a81..386f19f 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -545,6 +545,7 @@ static void ivshmem_reset(DeviceState *d) {

Re: [Qemu-devel] [PATCH 5/7] ahci/intel-hda: Properly reset MSI state

2011-06-08 Thread Jan Kiszka
On 2011-06-08 12:53, Alexander Graf wrote: > > On 08.06.2011, at 12:26, Jan Kiszka wrote: > >> Also invoke msi_reset on device reset to unsure proper config space > > ensure. Sure. :) Michael, please fix up on commit unless I'll have to repost anyway. > > Otherwise looks sane :) > > > Alex

Re: [Qemu-devel] QEMU suitable for mission critical applications?

2011-06-08 Thread Stefan Hajnoczi
On Wed, Jun 8, 2011 at 11:08 AM, Felix Oxley wrote: > I have a an (almost) EOL factory planning system running on Solaris > Sparc which I would like to move to intel (and preferably virtualise) > in order to avoid having to maintain the Sun system and backup system. > The text based cobol applicat

Re: [Qemu-devel] [PATCH v3 1/2] pxa2xx_lcd: add proper rotation support

2011-06-08 Thread Vasily Khoruzhick
On Wednesday 08 June 2011 12:50:50 Peter Maydell wrote: > On 3 June 2011 16:36, Vasily Khoruzhick wrote: > > Until now, pxa2xx_lcd only supported 90deg rotation, but > > some machines (for example Zipit Z2) needs 270deg rotation. > > > > Signed-off-by: Vasily Khoruzhick > > Still haven't tested

[Qemu-devel] [PATCH] [qemu-iotests] Update filter for default cluster size

2011-06-08 Thread Kevin Wolf
Until recently, qemu-img create displayed cluster_size=0 for the default cluster size. It is changed to display the real cluster size now, which results in the cluster size not being filtered out any more. If the cluster size is specified explicitly in CLUSTER_SIZE, keep the output, and if using t

[Qemu-devel] [PATCH RFC 3/3] sysbus: Allow passthrough of single IRQ

2011-06-08 Thread Peter Maydell
Add a sysbus_pass_one_irq() function to allow one sysbus device to pass a single IRQ through to another. (It is already possible to delegate all your IRQs to another device with sysbus_pass_irq().) Signed-off-by: Peter Maydell --- hw/sysbus.c |9 + hw/sysbus.h |1 + 2 files chang

Re: [Qemu-devel] [PATCH] Fix a number of unused-but-set-variable warnings (new with gcc-4.6)

2011-06-08 Thread Christophe Fergeau
On Wed, Jun 08, 2011 at 11:22:06AM +0200, Kevin Wolf wrote: > Am 08.06.2011 10:28, schrieb Hans de Goede: > > --- > > hw/lsi53c895a.c |2 -- > > target-i386/kvm.c |4 ++-- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > SoB is missing. And don't we have multiple patches to fix

[Qemu-devel] [PATCH RFC 1/3] sysbus: Add support for resizing and unmapping MMIOs

2011-06-08 Thread Peter Maydell
From: Juha Riihimäki Add new functions sysbus_mmio_unmap() and sysbus_mmio_resize() which allow a sysbus device user to trim the size of the device's mmio region and also to unmap it. The rationale here is twofold: * Some generic qdev devices might have an mmio region that doesn't match the

Re: [Qemu-devel] [PATCH 1/2] Support for MIPS64 user mode emulation

2011-06-08 Thread Khansa Butt
please see inline comments at the end. On Fri, Apr 29, 2011 at 2:01 PM, Aurelien Jarno wrote: > On Mon, Apr 25, 2011 at 04:54:19PM +0500, Khansa Butt wrote: > > please see inline comments highlighted in red color. > > > > On Wed, Apr 13, 2011 at 2:32 AM, Aurelien Jarno >wrote: > > > > > [I don't

[Qemu-devel] [PATCH RFC 2/3] sysbus: Allow sysbus MMIO passthrough

2011-06-08 Thread Peter Maydell
Add new function sysbus_pass_mmio() to allow a sysbus device to delegate MMIO to another sysbus device. This allows a limited form of composition for sysbus devices. Signed-off-by: Peter Maydell --- hw/sysbus.c | 26 ++ hw/sysbus.h |3 +++ 2 files changed, 29 insert

[Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices

2011-06-08 Thread Peter Maydell
At the moment you can't really implement one sysbus device by saying that it's composed of a set of other sysbus devices. This patch adds new functions sysbus_pass_mmio() and sysbus_pass_one_irq() which allow a sysbus device to delegate an MMIO or IRQ to another sysbus device (The approach is inspi

[Qemu-devel] [PATCH] doc: Minor typo fix.

2011-06-08 Thread Brad Hards
Thanks to agraf_, stefanha and Snader_LB for their IRC assistance. Signed-off-by: Brad Hards --- qemu-options.hx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 82e085a..005c141 100644 --- a/qemu-options.hx +++ b/qemu-options.hx

Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Gerd Hoffmann
@@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci) static void intel_hda_write_config(PCIDevice *pci, uint32_t addr, uint32_t val, int len) { -IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci); - pci_default_write_config(pci, add

Re: [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices

2011-06-08 Thread Jan Kiszka
On 2011-06-08 13:33, Peter Maydell wrote: > At the moment you can't really implement one sysbus device by saying > that it's composed of a set of other sysbus devices. This patch adds > new functions sysbus_pass_mmio() and sysbus_pass_one_irq() which > allow a sysbus device to delegate an MMIO or I

Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Jan Kiszka
On 2011-06-08 14:28, Gerd Hoffmann wrote: >> @@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci) >> static void intel_hda_write_config(PCIDevice *pci, uint32_t addr, >> uint32_t val, int len) >> { >> -IntelHDAState *d = DO_UPCAST(IntelHDASta

Re: [Qemu-devel] [PATCH] [qemu-iotests] Update filter for default cluster size

2011-06-08 Thread Stefan Hajnoczi
On Wed, Jun 8, 2011 at 12:23 PM, Kevin Wolf wrote: > Until recently, qemu-img create displayed cluster_size=0 for the default > cluster size. It is changed to display the real cluster size now, which > results > in the cluster size not being filtered out any more. > > If the cluster size is speci

Re: [Qemu-devel] [PATCH] doc: Minor typo fix.

2011-06-08 Thread Alexander Graf
Am 08.06.2011 um 14:07 schrieb Brad Hards : > Thanks to agraf_, stefanha and Snader_LB for their IRC assistance. > > Signed-off-by: Brad Hards > --- > qemu-options.hx |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 82

Re: [Qemu-devel] QMP: RFC: I/O error info & query-stop-reason

2011-06-08 Thread Anthony Liguori
On 06/06/2011 10:30 AM, Luiz Capitulino wrote: On Mon, 6 Jun 2011 16:27:55 +0100 "Daniel P. Berrange" wrote: On Mon, Jun 06, 2011 at 08:08:51AM -0500, Anthony Liguori wrote: On 06/06/2011 04:25 AM, Kevin Wolf wrote: Am 02.06.2011 20:09, schrieb Luiz Capitulino: I'm ok with either way. But i

Re: [Qemu-devel] arm1136 CPU emulation won't run current kernels?

2011-06-08 Thread Peter Maydell
On 8 June 2011 01:32, Rob Landley wrote: > QEMU's -cpu arm1136 emulation stopped working in the 2.6.35 and later > kernels, now QEMU dies early in the kernel boot with: > >  qemu: fatal: Unimplemented cp15 register write (c13, c0, {0, 3}) > The CPUID for arm1136 QEMU emulates a process that shoul

[Qemu-devel] vmdk fails qemu-iotest 019

2011-06-08 Thread Kevin Wolf
Hi Fam, now that I had a VMDK patch in the queue for the first time since quite a while, I ran qemu-iotests for VMDK and I noticed that test case 019 fails. It doesn't seem to be a regression, even 0.14 and 0.13 fail it. I think you're running qemu-iotests to check your VMDK patches, so I wonder

Re: [Qemu-devel] vmdk fails qemu-iotest 019

2011-06-08 Thread Fam Zheng
Yes I noticed the failure, but it's trivial mismatch between `qemu-img create` output. The old test case has "cluster_size=65536" but I find the latest qemu-img omits this info, as the diff: -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=6442450944 cluster_size=65536 +Formatting 'TEST_DIR/t.IMGF

[Qemu-devel] [PATCH 06/12] rbd: use the higher level librbd instead of just librados

2011-06-08 Thread Kevin Wolf
From: Josh Durgin librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Reviewed-by: Christian Brunner Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh Si

[Qemu-devel] [PATCH 04/12] block/raw-posix: use a character device if a block device is given

2011-06-08 Thread Kevin Wolf
From: Christoph Egger On NetBSD a userland process is better with the character device interface. In addition, a block device can't be opened twice; if a Xen backend opens it, qemu can't and vice-versa. Signed-off-by: Christoph Egger Signed-off-by: Kevin Wolf --- block/raw-posix.c | 43

[Qemu-devel] [PATCH 03/12] vmdk: fix endianness bugs

2011-06-08 Thread Kevin Wolf
From: Alexander Graf The vmdk code is sloppy when handling the header descriptor during creation of an image. Fix all header accesses in the create path to either store native endianness or convert it when appropriate. Reported-by: Yury Tsarev Signed-off-by: Alexander Graf Signed-off-by: Kevin

[Qemu-devel] [PATCH 07/12] rbd: allow configuration of rados from the rbd filename

2011-06-08 Thread Kevin Wolf
From: Josh Durgin The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies a Ceph configuration file to read. This allows rbd volumes from more than one Ceph cluster

[Qemu-devel] [PATCH 02/12] block: clarify the meaning of BDRV_O_NOCACHE

2011-06-08 Thread Kevin Wolf
From: Christoph Hellwig Change BDRV_O_NOCACHE to only imply bypassing the host OS file cache, but no writeback semantics. All existing callers are changed to also specify BDRV_O_CACHE_WB to give them writeback semantics. Signed-off-by: Christoph Hellwig Signed-off-by: Kevin Wolf --- block.c

[Qemu-devel] [PATCH 08/12] rbd: check return values when scheduling aio

2011-06-08 Thread Kevin Wolf
From: Josh Durgin If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reviewed-by: Christian Brunner Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin Signed-off-by: Kevin Wolf --- block/rbd.c | 24 +

[Qemu-devel] [PATCH 01/12] ide/core: Remove explicit setting of BM_STATUS_INT

2011-06-08 Thread Kevin Wolf
BM_STATUS_INT is automatically set during ide_set_irq(), there's no reason to set it manually in addition. There is even one case where the interrupt status bit was set, but no IRQ was raised. This is when the PRD table was reached but there is more data to transfer. The correct behaviour for this

[Qemu-devel] [PATCH 05/12] block/raw-posix: get right partition size

2011-06-08 Thread Kevin Wolf
From: Christoph Egger use the correct way to get the size of a disk device or partition From: Adam Hamsik Signed-off-by: Christoph Egger Signed-off-by: Kevin Wolf --- block/raw-posix.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/bl

[Qemu-devel] [PULL 00/12] Block patches

2011-06-08 Thread Kevin Wolf
The following changes since commit a90d4690074526f54ad0851fce19fa6783f06803: Add an isa device for SGA (2011-06-07 13:52:30 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Alexander Graf (1): vmdk: fix endianness bugs Christoph Egger (2):

[Qemu-devel] [PATCH 10/12] qcow2: Fix memory leaks in error cases

2011-06-08 Thread Kevin Wolf
This fixes memory leaks that may be caused by I/O errors during L1 table growth (can happen during save_vm) and in qemu-img check. Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |2 +- block/qcow2-refcount.c |9 ++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 09/12] rbd: Add bdrv_truncate implementation

2011-06-08 Thread Kevin Wolf
From: Josh Durgin Reviewed-by: Christian Brunner Signed-off-by: Josh Durgin Signed-off-by: Kevin Wolf --- block/rbd.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index f4da6ab..bdc448a 100644 --- a/block/rbd.c +++ b/block/rb

[Qemu-devel] [PATCH 12/12] qemu-img create: Fix displayed default cluster size

2011-06-08 Thread Kevin Wolf
When not specifying a cluster size on the command line, qemu-img printed a cluster size of 0: Formatting '/tmp/test.qcow2', fmt=qcow2 size=67108864 encryption=off cluster_size=0 This patch adds the default cluster size to the QEMUOptionParameter list, so that it displays the default value

[Qemu-devel] [PATCH 11/12] bdrv_img_create: Fix segfault

2011-06-08 Thread Kevin Wolf
Block drivers that don't support creating images don't have a size option. Fail gracefully instead of segfaulting when trying to access the option's value. Signed-off-by: Kevin Wolf --- block.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 3

Re: [Qemu-devel] vmdk fails qemu-iotest 019

2011-06-08 Thread Kevin Wolf
Am 08.06.2011 15:29, schrieb Fam Zheng: > Yes I noticed the failure, but it's trivial mismatch between `qemu-img > create` output. The old test case has "cluster_size=65536" but I find > the latest qemu-img omits this info, as the diff: > > -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=64424509

[Qemu-devel] [PATCH 05/12] kvm: ppc: Drop CONFIG_KVM_PPC_PVR

2011-06-08 Thread Jan Kiszka
Required header support is now unconditionally available. CC: Alexander Graf Signed-off-by: Jan Kiszka --- configure|1 - target-ppc/kvm.c |9 - 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/configure b/configure index ed54db9..0947f98 100755 --- a/conf

[Qemu-devel] [PATCH 01/12] Add kernel header update script

2011-06-08 Thread Jan Kiszka
This helper pulls the required kernel headers for KVM and vhost into a specified directory. The update is triggered via scripts/update-linux-headers.sh LINUX_PATH and will place the output under linux-headers/linux and linux-headers/asm-*. It also imports the COPYING to care for headers witho

[Qemu-devel] [PATCH 09/12] kvm: ppc: Drop KVM_CAP build dependencies

2011-06-08 Thread Jan Kiszka
No longer needed with accompanied kernel headers. CC: Alexander Graf Signed-off-by: Jan Kiszka --- target-ppc/kvm.c | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 0500e3f..21f35af 100644 --- a/target-ppc/kvm.c +++

[Qemu-devel] [PATCH 11/12] kvm: x86: Pass KVMState to kvm_arch_get_supported_cpuid

2011-06-08 Thread Jan Kiszka
kvm_arch_get_supported_cpuid checks for global cpuid restrictions, it does not require any CPUState reference. Changing its interface allows to call it before any VCPU is initialized. CC: Eduardo Habkost Signed-off-by: Jan Kiszka --- kvm.h |2 +- target-i386/cpuid.c | 20 +++

[Qemu-devel] [PATCH 04/12] kvm: Drop CONFIG_KVM_PARA

2011-06-08 Thread Jan Kiszka
The kvm_para.h header is now always available. Signed-off-by: Jan Kiszka --- configure |1 - hw/kvmclock.c |9 - target-i386/kvm.c | 26 +- 3 files changed, 1 insertions(+), 35 deletions(-) diff --git a/configure b/configure index 0e1dc46..e

Re: [Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them

2011-06-08 Thread Jan Kiszka
On 2011-06-08 16:43, Isaku Yamahata wrote: > On Wed, Jun 08, 2011 at 12:26:44PM +0200, Jan Kiszka wrote: >> Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant >> names to libpci style. Will be used for device assignment code in >> qemu-kvm. > > So since libpci would be used by

[Qemu-devel] [PATCH 00/12] [uq/master] Import linux headers and some cleanups

2011-06-08 Thread Jan Kiszka
Licensing of the virtio headers is no clarified. So we can finally resolve the clumbsy and constantly buggy #ifdef'ery around old KVM and virtio headers. Recent example: current qemu-kvm does not build against 2.6.32 headers. This series introduces an import mechanism for all required Linux header

[Qemu-devel] [PATCH 12/12] Remove unneeded kvm.h from cpu-exec.c

2011-06-08 Thread Jan Kiszka
This was obsoleted by 6792a57bf1. Signed-off-by: Jan Kiszka --- cpu-exec.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 6ddd8dd..9bb6405 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -20,7 +20,6 @@ #include "exec.h" #include "disas.h" #i

[Qemu-devel] [PATCH 08/12] kvm: x86: Drop KVM_CAP build dependencies

2011-06-08 Thread Jan Kiszka
No longer needed with accompanied kernel headers. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 67 ++-- 1 files changed, 3 insertions(+), 64 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 0efcf97..1c2d32c 100644 --- a

Re: [Qemu-devel] [PATCH 2/7] msi: Guard msi/msix_write_config with msi_present

2011-06-08 Thread Jan Kiszka
On 2011-06-08 14:33, Jan Kiszka wrote: > On 2011-06-08 14:28, Gerd Hoffmann wrote: >>> @@ -1173,12 +1173,8 @@ static int intel_hda_exit(PCIDevice *pci) >>> static void intel_hda_write_config(PCIDevice *pci, uint32_t addr, >>> uint32_t val, int len) >>> { >>>

[Qemu-devel] [PATCH 07/12] kvm: Drop KVM_CAP build dependencies

2011-06-08 Thread Jan Kiszka
No longer needed with accompanied kernel headers. We are only left with build dependencies that are controlled by kvm arch headers. CC: Alexander Graf Signed-off-by: Jan Kiszka --- kvm-all.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/kvm-all.c b/kvm-all.c in

[Qemu-devel] [PATCH v2 01/12] Add kernel header update script

2011-06-08 Thread Jan Kiszka
This helper pulls the required kernel headers for KVM and vhost into a specified directory. The update is triggered via scripts/update-linux-headers.sh LINUX_PATH and will place the output under linux-headers/linux and linux-headers/asm-*. It also imports the COPYING to care for headers witho

[Qemu-devel] [PATCH 10/12] kvm: Clean up stubs

2011-06-08 Thread Jan Kiszka
No one references kvm_check_extension, kvm_has_vcpu_events, and kvm_has_robust_singlestep outside KVM code. kvm_update_guest_debug is never called, thus has no job besides returning an error. Signed-off-by: Jan Kiszka --- kvm-stub.c | 18 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH 03/12] Switch build system to accompanied kernel headers

2011-06-08 Thread Jan Kiszka
This helps reducing our build-time checks for feature support in the available Linux kernel headers. And it helps users that do not have sufficiently recent headers installed on their build machine. Consequently, the patch removes and build-time checks for kvm and vhost in configure, the --kerneld

Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script

2011-06-08 Thread Peter Maydell
On 8 June 2011 15:10, Jan Kiszka wrote: > --- /dev/null > +++ b/scripts/update-linux-headers.sh > @@ -0,0 +1,55 @@ > +#!/bin/sh -e > +# > +if [ -z "$output" ]; then > +    output=$PWD > +fi > +    mkdir -p $output/linux-headers/asm-$arch This script is rather lacking in quoting throughout. As a

Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script

2011-06-08 Thread Jan Kiszka
On 2011-06-08 16:33, Peter Maydell wrote: > On 8 June 2011 15:10, Jan Kiszka wrote: >> --- /dev/null >> +++ b/scripts/update-linux-headers.sh >> @@ -0,0 +1,55 @@ >> +#!/bin/sh -e >> +# > >> +if [ -z "$output" ]; then >> +output=$PWD >> +fi > >> +mkdir -p $output/linux-headers/asm-$arch >

[Qemu-devel] [PATCH 06/12] kvm: Drop useless zero-initializations

2011-06-08 Thread Jan Kiszka
Backing KVMState is alreay zero-initialized. Signed-off-by: Jan Kiszka --- kvm-all.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 106eb3a..4a9910a 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -764,28 +764,23 @@ int kvm_init(void) } #

Re: [Qemu-devel] [PATCH 6/7] msix: Align MSI-X constants to libpci definitions and extend them

2011-06-08 Thread Isaku Yamahata
On Wed, Jun 08, 2011 at 12:26:44PM +0200, Jan Kiszka wrote: > Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant > names to libpci style. Will be used for device assignment code in > qemu-kvm. So since libpci would be used by qemu, you are claiming that it should be switched to

Re: [Qemu-devel] [PATCH 01/12] Add kernel header update script

2011-06-08 Thread Peter Maydell
2011/6/8 Jan Kiszka : > On 2011-06-08 16:33, Peter Maydell wrote: >> On 8 June 2011 15:10, Jan Kiszka wrote: >>> +tmpdir=$TMPDIR/.tmp-hdrs-$$ >> >> Better (safer) to use mktemp, I think. > > Is that portable? I don't think so. We don't expect every random end user to run this script, though, righ

[Qemu-devel] inconsistency between device traversal in qdev and legacy

2011-06-08 Thread Peter Maydell
If you have a model with more than one USB bus, and you create a USB device on the command line without specifying which bus to plug it into, QEMU will choose a different bus depending on whether you use the legacy "-usbdevice keyboard" or the qdev "-device usb-kbd". This is because the legacy opt

Re: [Qemu-devel] vmdk fails qemu-iotest 019

2011-06-08 Thread Fam Zheng
Oh, you're right, and I think there is a patch of mine related to the fail: "[PATCH 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster" Can you test if this fixes it? On Wed, Jun 8, 2011 at 9:52 PM, Kevin Wolf wrote: > Am 08.06.2011 15:29, schrieb Fam Zheng: >> Yes I noticed the

[Qemu-devel] [PATCH] CPU consumption optimization of 'qemu-img convert' using bdrv_is_allocated()

2011-06-08 Thread Dmitry Konishchev
This patch optimizes 'qemu-img convert' operation for volumes which are almost fully unallocated. Here are the results of simple tests: We have a snapshot of a volume: $ qemu-img info snapshot.qcow2 image: snapshot.qcow2 file format: qcow2 virtual size: 5.0G (5372805120 bytes) disk size: 4.0G clus

Re: [Qemu-devel] [PATCH v2 01/12] Add kernel header update script

2011-06-08 Thread Peter Maydell
On 8 June 2011 16:06, Jan Kiszka wrote: > +    if [ $arch == x86 ]; then This should be a single '=' -- '==' is a bashism. The 'checkbashisms' script (available in 'devscripts' package on debian and ubuntu) catches this: cam-vm-266:maverick:testing$ checkbashisms scripts/update-linux-headers.sh

[Qemu-devel] [PATCH v2 3/9] msi: Guard msi_reset with msi_present

2011-06-08 Thread Jan Kiszka
Signed-off-by: Jan Kiszka --- hw/msi.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index b7a92c9..b039893 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -183,6 +183,10 @@ void msi_reset(PCIDevice *dev) uint16_t flags; bool msi64bit; +if

Re: [Qemu-devel] vmdk fails qemu-iotest 019

2011-06-08 Thread Kevin Wolf
Am 08.06.2011 16:17, schrieb Fam Zheng: > Oh, you're right, and I think there is a patch of mine related to the fail: > > "[PATCH 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster" > > Can you test if this fixes it? Thanks, this works for me. However, I had to fix your patch man

[Qemu-devel] [PATCH v2 6/9] msi: Invoke msi/msix_write_config from PCI core

2011-06-08 Thread Jan Kiszka
Also this functions is better invoked by the core than by each and every device. This allows to drop the config_write callbacks from ich and intel-hda. CC: Alexander Graf CC: Gerd Hoffmann CC: Isaku Yamahata Signed-off-by: Jan Kiszka --- hw/ide/ich.c|8 hw/intel-hda.c

Re: [Qemu-devel] [patch 6/7] QEMU live block copy

2011-06-08 Thread Jagane Sundar
On 6/7/2011 5:15 AM, Stefan Hajnoczi wrote: On Mon, Jun 6, 2011 at 5:55 PM, Marcelo Tosatti wrote: I haven't reviewed this whole patch yet, but comments below. This patch, like image streaming, may hit deadlocks due to synchronous I/O emulation. I discovered this problem when working on image

[Qemu-devel] [PATCH v2 0/9] msi: Small cleanups and fixes

2011-06-08 Thread Jan Kiszka
A few patches to the MSI and MSI-X layer that clean up the interfaces and fix reset issues. They are from my MSI rework to prepare it for KVM's requirements (in-kernel irqchip). In contrast to the previous version, this one moves msi[x]_reset, msi[x]_write_config and msi[x]_uninit into the PCI cor

[Qemu-devel] [PATCH v2 8/9] msix: Align MSI-X constants to libpci definitions and extend them

2011-06-08 Thread Jan Kiszka
Add PCI_MSIX_TABLE and PCI_MSIX_PBA, align other MSIX related constant names to libpci style. Will be used for device assignment code in qemu-kvm. Signed-off-by: Jan Kiszka --- hw/msix.c | 24 +++- hw/pci_regs.h | 14 -- 2 files changed, 19 insertions(+),

Re: [Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v2

2011-06-08 Thread Luiz Capitulino
On Fri, 3 Jun 2011 17:32:58 -0500 Michael Roth wrote: > This is Set 2/3 of the QAPI+QGA patchsets. I have started taking a look at this series, but it turns out that this is complex stuff and I'd like to spend time playing with it and testing it throughly. I don't oppose merging this as is, as

[Qemu-devel] [PATCH] Clean up virtio-9p error handling code

2011-06-08 Thread Sassan Panahinejad
In a lot of cases, the handling of errors was quite ugly. This patch moves reading of errno to immediately after the system calls and passes it up through the system more cleanly. Also, in the case of the xattr functions (and possibly others), completely the wrong error was being returned. This

  1   2   >