Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around Qemu to test kernels

2011-08-23 Thread Américo Wang
On Wed, Aug 24, 2011 at 1:19 PM, Pekka Enberg wrote: > > It's nice to see such an honest attempt at improving QEMU usability, > Alexander! > > One comment: in my experience, having shell scripts under > Documentation reduces the likelihood that people actually discover > them so you might want to

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around Qemu to test kernels

2011-08-23 Thread Pekka Enberg
On Wed, Aug 24, 2011 at 1:16 AM, Alexander Graf wrote: > On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool > would be doing and what he expects from it. Basically he wants a > small and simple tool he and other developers can run to try out and > see if the kernel they just built

Re: [Qemu-devel] MPC5200 + BestComm support in QEMU

2011-08-23 Thread Alexander Graf
On 23.08.2011, at 09:52, steve.belan...@ca.transport.bombardier.com wrote: > > Hi, > > I'm Steve, an embedded software developper for Bombardier Transportation > Canada. We use the MPC5200 for most of our onboard computers inside train > control systems. To enhance our SW engineering process

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alexander Graf
On 23.08.2011, at 18:51, Benjamin Herrenschmidt wrote: > >>> For us the most simple and logical approach (which is also what pHyp >>> uses and what Linux handles well) is really to expose a given PCI host >>> bridge per group to the guest. Believe it or not, it makes things >>> easier :-) >> >>

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alexander Graf
On 23.08.2011, at 18:41, Benjamin Herrenschmidt wrote: > On Tue, 2011-08-23 at 10:23 -0600, Alex Williamson wrote: >> >> Yeah. Joerg's idea of binding groups internally (pass the fd of one >> group to another via ioctl) is one option. The tricky part will be >> implementing it to support hot u

[Qemu-devel] [RFC PATCH v5 3/4] Separate migration bitmap

2011-08-23 Thread Umesh Deshpande
This patch creates a migration bitmap, which is periodically kept in sync with the qemu bitmap. A separate copy of the dirty bitmap for the migration avoids concurrent access to the qemu bitmap from iothread and migration thread. Signed-off-by: Umesh Deshpande --- arch_init.c | 17

[Qemu-devel] [RFC PATCH v5 0/4] Separate thread for VM migration

2011-08-23 Thread Umesh Deshpande
Following patch series deals with VCPU and iothread starvation during the migration of a guest. Currently the iothread is responsible for performing the guest migration. It holds qemu_mutex during the migration and doesn't allow VCPU to enter the qemu mode and delays its return to the guest. The gu

[Qemu-devel] [RFC PATCH v5 4/4] Separate thread for VM migration

2011-08-23 Thread Umesh Deshpande
This patch creates a separate thread for the guest migration on the source side. All exits (on completion/error) from the migration thread are handled by a bottom handler, which is called from the iothread. Signed-off-by: Umesh Deshpande --- buffered_file.c | 75 +-

[Qemu-devel] [RFC PATCH v5 1/4] MRU ram list

2011-08-23 Thread Umesh Deshpande
This patch creates a new list of RAM blocks in MRU order. So that separate locking rules can be applied to the regular RAM block list and the MRU list. Signed-off-by: Paolo Bonzini --- cpu-all.h |2 ++ exec.c| 17 - 2 files changed, 14 insertions(+), 5 deletions(-) dif

[Qemu-devel] [RFC PATCH v5 2/4] Migration thread mutex

2011-08-23 Thread Umesh Deshpande
ramlist mutex is implemented to protect the RAMBlock list traversal in the migration thread from their addition/removal from the iothread. Note: Combination of iothread mutex and migration thread mutex works as a rw-lock. Both mutexes are acquired while modifying the ram_list members or RAM block

[Qemu-devel] [PATCH 16/16] isa: Remove isa_init_ioport_range and isa_init_ioport.

2011-08-23 Thread Richard Henderson
All users have been converted to either isa_register_ioport or isa_register_old_portio_list. Signed-off-by: Richard Henderson --- hw/isa-bus.c | 19 +-- hw/isa.h |2 -- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 648

[Qemu-devel] [PATCH 13/16] pc: Convert port92 to isa_register_ioport.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/pc.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 263fb1a..4c460fd 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -428,6 +428,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_siz

[Qemu-devel] [PATCH 10/16] parallel: Convert to isa_register_portio_list.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/parallel.c | 47 --- 1 files changed, 28 insertions(+), 19 deletions(-) diff --git a/hw/parallel.c b/hw/parallel.c index ecbc8c3..8494d94 100644 --- a/hw/parallel.c +++ b/hw/parallel.c @@ -448,6 +448,29 @@ stat

[Qemu-devel] [PATCH 11/16] sb16: Convert to isa_register_portio_list.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/sb16.c | 32 +--- 1 files changed, 13 insertions(+), 19 deletions(-) diff --git a/hw/sb16.c b/hw/sb16.c index a76df1b..fe927e2 100644 --- a/hw/sb16.c +++ b/hw/sb16.c @@ -1341,12 +1341,21 @@ static const VMStateDescription vmst

[Qemu-devel] [PATCH 04/16] isa: Add isa_register_portio_list().

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/isa-bus.c | 79 ++ hw/isa.h | 31 ++- memory.c |8 +++--- 3 files changed, 113 insertions(+), 5 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index e9c1712.

[Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/vga-isa.c | 10 -- hw/vga.c | 55 --- 2 files changed, 28 insertions(+), 37 deletions(-) diff --git a/hw/vga-isa.c b/hw/vga-isa.c index 0d19901..510ace8 100644 --- a/hw/vga-isa.c +++ b/hw/

[Qemu-devel] [PATCH 02/16] fixup: merge with last arm_sysctl patch

2011-08-23 Thread Richard Henderson
--- hw/arm_sysctl.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c index 5b845a2..17cf6f7 100644 --- a/hw/arm_sysctl.c +++ b/hw/arm_sysctl.c @@ -19,7 +19,6 @@ typedef struct { SysBusDevice busdev; MemoryRegion iomem; qemu_i

Re: [Qemu-devel] Execute QEMU "the same"

2011-08-23 Thread 陳韋任
> I read the user manual and find options like: "-clock dynticks -rtc > base=2006-06-17T16:01:21,clock=vm -icount 1". > Would QEMU run "the same" with these options?? > > PS. I also found the function cpu_io_recompile() with comments: > /* in deterministic execution mode, instructions doing

[Qemu-devel] [PATCH 14/16] vmport: Convert to isa_register_ioport.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/vmport.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c index c8aefaa..b5c6fa1 100644 --- a/hw/vmport.c +++ b/hw/vmport.c @@ -38,6 +38,7 @@ typedef struct _VMPortState { ISADevice de

[Qemu-devel] [PATCH 09/16] ne2000: Convert to isa_register_ioport.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ne2000-isa.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c index 756ed5c..11ffee7 100644 --- a/hw/ne2000-isa.c +++ b/hw/ne2000-isa.c @@ -68,10 +68,7 @@ static int isa_ne2000_initfn(ISADevice *

[Qemu-devel] [PATCH 08/16] rtc: Convert to isa_register_ioport.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/mc146818rtc.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index feb3b25..2aaca2f 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -81,6 +81,7 @@ typedef struct RTCStat

[Qemu-devel] [PATCH 06/16] gus: Convert to isa_register_portio_list.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/gus.c | 39 +++ 1 files changed, 19 insertions(+), 20 deletions(-) diff --git a/hw/gus.c b/hw/gus.c index 37e543a..1532686 100644 --- a/hw/gus.c +++ b/hw/gus.c @@ -232,6 +232,22 @@ static const VMStateDescription vmsta

[Qemu-devel] [PATCH 03/16] isa: Tidy support code for isabus_get_fw_dev_path.

2011-08-23 Thread Richard Henderson
The only user of ISADevice.ioports is isabus_get_fw_dev_path, and it only looks at the first entry of the array. Which suggests that this entire array+sort operation can be replaced by a simple minimum. Signed-off-by: Richard Henderson --- hw/isa-bus.c | 25 + hw/isa.h

[Qemu-devel] [PATCH 07/16] m48t59: Convert to isa_register_ioport.

2011-08-23 Thread Richard Henderson
The sysbus interface is as yet unconverted. Signed-off-by: Richard Henderson --- hw/m48t59.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/m48t59.c b/hw/m48t59.c index 0cc361e..f318e67 100644 --- a/hw/m48t59.c +++ b/hw/m48t59.c @@ -73,6 +73,7 @@ struc

[Qemu-devel] [PATCH 15/16] ide: Convert to isa_register_portio_list.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/ide/core.c | 30 +++--- hw/ide/internal.h |3 ++- hw/ide/isa.c |4 +--- hw/ide/piix.c |7 --- hw/ide/via.c |7 --- 5 files changed, 30 insertions(+), 21 deletions(-) diff --git a/hw/ide/co

[Qemu-devel] [PATCH 05/16] fdc: Convert to isa_register_portio_list.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/fdc.c | 34 -- 1 files changed, 4 insertions(+), 30 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index c3ae956..b83c045 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -425,7 +425,6 @@ typedef struct FDCtrlSysBus { typedef str

[Qemu-devel] [PATCH 01/16] fixup: merge with last sm501 patch

2011-08-23 Thread Richard Henderson
--- hw/devices.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/devices.h b/hw/devices.h index 36c21e7..8ac384f 100644 --- a/hw/devices.h +++ b/hw/devices.h @@ -2,7 +2,7 @@ #define QEMU_DEVICES_H /* ??? Not all users of this file can include cpu-common.h. */ -t

[Qemu-devel] [PATCH 00/16] isa_register_portio_list, v2

2011-08-23 Thread Richard Henderson
The problem that malc saw with sb16 was a major think-o on my part with the whole interface. We can't re-use the const sub-arrays of the original MemoryRegionPortio array because they have the wrong offset for the MemoryRegion to which it is attached -- the lookup in find_portio fails. We must ad

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Benjamin Herrenschmidt
> > For us the most simple and logical approach (which is also what pHyp > > uses and what Linux handles well) is really to expose a given PCI host > > bridge per group to the guest. Believe it or not, it makes things > > easier :-) > > I'm all for easier. Why does exposing the bridge use less b

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Benjamin Herrenschmidt
On Tue, 2011-08-23 at 10:23 -0600, Alex Williamson wrote: > > Yeah. Joerg's idea of binding groups internally (pass the fd of one > group to another via ioctl) is one option. The tricky part will be > implementing it to support hot unplug of any group from the > supergroup. > I believe Ben had a

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Benjamin Herrenschmidt
On Tue, 2011-08-23 at 15:18 +0200, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 05:03:53PM -0400, Benjamin Herrenschmidt wrote: > > > > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > > assigned to a guest, there can also be an ioctl to bind a group to an > > > address-sp

[Qemu-devel] [PATCH] KVM: Add wrapper script around Qemu to test kernels

2011-08-23 Thread Alexander Graf
On LinuxCon I had a nice chat with Linus on what he thinks kvm-tool would be doing and what he expects from it. Basically he wants a small and simple tool he and other developers can run to try out and see if the kernel they just built actually works. Fortunately, Qemu can do that today already! T

Re: [Qemu-devel] Grand Unified Tracing

2011-08-23 Thread Blue Swirl
On Tue, Aug 23, 2011 at 2:54 PM, Blue Swirl wrote: > On Tue, Aug 23, 2011 at 2:45 PM, Stefan Hajnoczi wrote: >> On Tue, Aug 23, 2011 at 3:34 PM, Blue Swirl wrote: >>> On Tue, Aug 23, 2011 at 5:35 AM, Stefan Hajnoczi wrote: On Mon, Aug 22, 2011 at 9:59 PM, Blue Swirl wrote: > On Mon, A

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Don Dutile
On 08/23/2011 03:30 PM, Michael S. Tsirkin wrote: On Tue, Aug 23, 2011 at 01:12:19PM -0600, Alex Williamson wrote: On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH 2/3] PPC: E500: Inject SPE exception on invalid SPE access

2011-08-23 Thread Edgar E. Iglesias
On Tue, Aug 23, 2011 at 06:55:43AM +0200, Alexander Graf wrote: > When accessing an SPE instruction despite it being not available, > throw an SPE exception instead of an APU exception. That way the > guest knows what's going on and actually uses SPE. > > Reported-by: Jason Wessel > Signed-off-by

Re: [Qemu-devel] [PATCH 0/3] PPC: E500: Support SPE guest

2011-08-23 Thread Edgar E. Iglesias
On Tue, Aug 23, 2011 at 12:00:00PM -0500, Jason Wessel wrote: > On 08/22/2011 11:55 PM, Alexander Graf wrote: > > When I bumped into Jason on Linuxcon, we tried out to run the e500 target > > on his Windriver build that used SPE and immediately ran into emulation > > issues. Fortunately there weren

Re: [Qemu-devel] [PATCH] hw/omap_gpmc: Don't try to map CS0 twice on reset

2011-08-23 Thread Edgar E. Iglesias
On Tue, Aug 23, 2011 at 07:24:32PM +0100, Peter Maydell wrote: > Remove a spurious second map of the OMAP GPMC CS0 region on reset. > This fixes an assertion failure when we try to add the region to > its container when it was already added. (The old code did not > complain about mismatched map/unm

Re: [Qemu-devel] Execute QEMU "the same"

2011-08-23 Thread Edgar E. Iglesias
On Tue, Aug 23, 2011 at 07:04:43PM +0800, Lyu Mitnick wrote: > Hello all, > > I am wondering to know whether QEMU could run "the same" twice. ie. > the same of execution trace. > I read the user manual and find options like:  "-clock dynticks -rtc > base=2006-06-17T16:01:21,clock=vm -icount 1". >

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 22:30 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 01:12:19PM -0600, Alex Williamson wrote: > > On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > > > > On Tue, 2011-08-23 at 21:17

Re: [Qemu-devel] [PATCH] tcg: Update --enable-debug for TCG_OPF_NOT_PRESENT.

2011-08-23 Thread Edgar E. Iglesias
On Tue, Aug 23, 2011 at 07:41:35PM +0100, Peter Maydell wrote: > On 23 August 2011 18:43, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > > Reviewed-by: Peter Maydell > > Confirmed that this fixes the assertion on x86-64 host. I've applied this. Thanks both of you for the quic

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 07:01 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2011-08-22 at 09:45 -0600, Alex Williamson wrote: > > > Yes, that's the idea. An open question I have towards the configuration > > side is whether we might add iommu driver specific options to the > > groups. For instanc

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 01:12:19PM -0600, Alex Williamson wrote: > On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > > > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Aug 23, 2011 at 07:

Re: [Qemu-devel] PPC* and Sparc32 crash

2011-08-23 Thread Edgar E. Iglesias
On Tue, Aug 23, 2011 at 06:59:01PM +0100, Peter Maydell wrote: > On 23 August 2011 18:55, Blue Swirl wrote: > > qemu-system-ppc: /src/qemu/memory.c:1183: > > memory_region_add_subregion_common: Assertion `!subregion->parent' > > failed. > > Aborted > > qemu-system-ppc64: /src/qemu/memory.c:1183: >

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > > > From: Alex Williamson > > > >

Re: [Qemu-devel] [PATCH] tcg: Update --enable-debug for TCG_OPF_NOT_PRESENT.

2011-08-23 Thread Peter Maydell
On 23 August 2011 18:43, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Confirmed that this fixes the assertion on x86-64 host. -- PMM

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > > From: Alex Williamson > > > > > > Nothing good can happen when we overlap capabilities > > > > > >

[Qemu-devel] [PATCH] hw/omap_gpmc: Don't try to map CS0 twice on reset

2011-08-23 Thread Peter Maydell
Remove a spurious second map of the OMAP GPMC CS0 region on reset. This fixes an assertion failure when we try to add the region to its container when it was already added. (The old code did not complain about mismatched map/unmap calls, but the new MemoryRegion implementation does.) Signed-off-by

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > From: Alex Williamson > > > > Nothing good can happen when we overlap capabilities > > > > [ Jan: rebased over qemu, minor formatting ] > > > > Signed-off-by: Jan Kiszk

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > From: Alex Williamson > > Nothing good can happen when we overlap capabilities > > [ Jan: rebased over qemu, minor formatting ] > > Signed-off-by: Jan Kiszka I'll stick an assert there instead. Normal devices don't generate overlap

[Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2011-08-23 Thread Rick Vernam
Using qemu-kvm-0.15.0 for a few weeks now, I'd like to report that maybe 1/10 times it works as expected: ie, there is no virtio-serial-bus error, vdagent in the windows guest starts, etc. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 10:33 -0700, Aaron Fabbri wrote: > > > On 8/23/11 10:01 AM, "Alex Williamson" wrote: > > > On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: > >> On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: > >> > >>> I'm not following you. > >>> > >>> You have to e

Re: [Qemu-devel] PPC* and Sparc32 crash

2011-08-23 Thread Peter Maydell
On 23 August 2011 18:55, Blue Swirl wrote: > qemu-system-ppc: /src/qemu/memory.c:1183: > memory_region_add_subregion_common: Assertion `!subregion->parent' > failed. > Aborted > qemu-system-ppc64: /src/qemu/memory.c:1183: > memory_region_add_subregion_common: Assertion `!subregion->parent' > faile

[Qemu-devel] PPC* and Sparc32 crash

2011-08-23 Thread Blue Swirl
qemu-system-ppc: /src/qemu/memory.c:1183: memory_region_add_subregion_common: Assertion `!subregion->parent' failed. Aborted qemu-system-ppc64: /src/qemu/memory.c:1183: memory_region_add_subregion_common: Assertion `!subregion->parent' failed. Aborted qemu-system-sparc: /src/qemu/hw/sysbus.c:156: s

[Qemu-devel] [PATCH] tcg: Update --enable-debug for TCG_OPF_NOT_PRESENT.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 06ce214..411f971 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -1128,18 +1128,19 @@ void tcg_add_target_add_op_defs(const TCGTargetOpDef *

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Aaron Fabbri
On 8/23/11 10:01 AM, "Alex Williamson" wrote: > On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: >> >>> I'm not following you. >>> >>> You have to enforce group/iommu domain assignment whether you have the >>> existing uio

[Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Jan Kiszka
From: Alex Williamson Nothing good can happen when we overlap capabilities [ Jan: rebased over qemu, minor formatting ] Signed-off-by: Jan Kiszka --- hw/pci.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6124790..ff20631 1006

[Qemu-devel] Nous sommes là pour

2011-08-23 Thread Prod6
  Nous sommes là pour vous faire bénéficier d’une étude GRATUITE et sans engagement de votre part pour l’installation de :   • Climatisation réversible, • Chauffe-eau solaire • Energie solaire pour chauffer votre piscine • Isolation thermique des combles • Adoucisseur d’eau • L’é

Re: [Qemu-devel] [PATCH 2/6] tcg: Always define all of the TCGOpcode enum members.

2011-08-23 Thread Richard Henderson
On 08/23/2011 10:11 AM, Peter Maydell wrote: > A compile-time check that the tcg target has #defined all the > TCG_TARGET_HAS_foo to 0/1 and not left any undefined might be > useful? That compile-time check is the uses in tcg-op.h. If they're not defined you'll get undefined symbol errors in that

Re: [Qemu-devel] [PATCH] sheepdog: use coroutines

2011-08-23 Thread MORITA Kazutaka
At Tue, 23 Aug 2011 14:29:50 +0200, Kevin Wolf wrote: > > Am 12.08.2011 14:33, schrieb MORITA Kazutaka: > > This makes the sheepdog block driver support bdrv_co_readv/writev > > instead of bdrv_aio_readv/writev. > > > > With this patch, Sheepdog network I/O becomes fully asynchronous. The > > bl

Re: [Qemu-devel] [PATCH 2/6] tcg: Always define all of the TCGOpcode enum members.

2011-08-23 Thread Peter Maydell
On 17 August 2011 22:11, Richard Henderson wrote: > By always defining these symbols, we can eliminate a lot of ifdefs. > > To allow this to be checked reliably, the semantics of the > TCG_TARGET_HAS_* macros must be changed from def/undef to true/false. > This allows even more ifdefs to be remove

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 15:14 +0200, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 03:17:00PM -0400, Alex Williamson wrote: > > On Mon, 2011-08-22 at 19:25 +0200, Joerg Roedel wrote: > > > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > > assigned to a guest, there can also

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: > > > I'm not following you. > > > > You have to enforce group/iommu domain assignment whether you have the > > existing uiommu API, or if you change it to your proposed > > ioctl

Re: [Qemu-devel] [PATCH 0/3] PPC: E500: Support SPE guest

2011-08-23 Thread Jason Wessel
On 08/22/2011 11:55 PM, Alexander Graf wrote: > When I bumped into Jason on Linuxcon, we tried out to run the e500 target > on his Windriver build that used SPE and immediately ran into emulation > issues. Fortunately there weren't too many, so here are the patches to get > a guest using SPE instru

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread aafabbri
On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > On Mon, Aug 22, 2011 at 08:52:18PM -0400, aafabbri wrote: >> You have to enforce group/iommu domain assignment whether you have the >> existing uiommu API, or if you change it to your proposed >> ioctl(inherit_iommu) API. >> >> The only change neede

Re: [Qemu-devel] [PATCH 1/4] qmp: add block_stream command

2011-08-23 Thread Adam Litke
Under libvirt, I get the following error when trying to start a block stream: qerror: bad call in function 'do_block_stream': qerror: -> error format '{ 'class': 'NotSupported', 'data': {} }' not found qerror: call at blockdev.c:808 2011-08-23 11:30:09.974: shutting down Is this patch missing a p

[Qemu-devel] [PATCH 1/3] rbd: fix leak in failure path

2011-08-23 Thread Sage Weil
Fix leak of s->snap when rados_create fails. Reported-by: Stefan Hajnoczi Signed-off-by: Sage Weil --- block/rbd.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index d5659cd..52b79fa 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -393

[Qemu-devel] [PATCH 3/3] rbd: clean up, fix style

2011-08-23 Thread Sage Weil
No assignment in condition. Remove duplicate ret > 0 check. Signed-off-by: Sage Weil --- block/rbd.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index e239e04..5423a2d 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -391,15 +3

[Qemu-devel] [PATCH 2/3] rbd: allow client id to be specified in config string

2011-08-23 Thread Sage Weil
Allow the client id to be specified in the config string via 'id=' so that users can control who they authenticate as. Currently they are stuck with the default ('admin'). This is necessary for anyone using authentication in their environment. Signed-off-by: Sage Weil --- block/rbd.c | 52 ++

Re: [Qemu-devel] [PATCH 4/4] qmp: add query-block-jobs

2011-08-23 Thread Adam Litke
On Tue, 2011-08-23 at 13:58 +0100, Stefan Hajnoczi wrote: > diff --git a/blockdev.c b/blockdev.c > index 036b7eb..e9098f6 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -835,3 +835,13 @@ int do_block_job_cancel(Monitor *mon, const QDict > *params, QObject **ret_data) > qerror_report(QERR_D

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 12:38 +1000, David Gibson wrote: > On Mon, Aug 22, 2011 at 09:45:48AM -0600, Alex Williamson wrote: > > On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: > > > On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: > > > > We had an extremely productive VFIO BoF

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Anthony Liguori
On 08/23/2011 11:18 AM, Daniel P. Berrange wrote: On Tue, Aug 23, 2011 at 11:14:20AM -0500, Anthony Liguori wrote: On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: $(block-obj-y) pulls in 'aio.o' which is built from aio.c which is licensed "GPLv2 only". So even those many files are BSD licen

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 11:14:20AM -0500, Anthony Liguori wrote: > On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: > >$(block-obj-y) pulls in 'aio.o' which is built from aio.c which > >is licensed "GPLv2 only". So even those many files are BSD > >licenses, the combined work will be GPLv2-only.

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/23/2011 11:50 AM, Kevin Wolf wrote: Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: >> >> >> On 08/22/2011 02:39 PM, Blue Swirl wrote: >>> On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant wrote: > > >On

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Anthony Liguori
On 08/23/2011 11:12 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 02:29:00PM -0500, Anthony Liguori wrote: On 08/22/2011 12:06 PM, Saggi Mizrahi wrote: libvdisk is a library that packages qemu's handling of disk images. This allows for other programs to link to it and get access to qemu

Re: [Qemu-devel] [PATCH 2/2] Added target to build libvdisk

2011-08-23 Thread Daniel P. Berrange
On Mon, Aug 22, 2011 at 02:29:00PM -0500, Anthony Liguori wrote: > On 08/22/2011 12:06 PM, Saggi Mizrahi wrote: > >libvdisk is a library that packages qemu's handling of disk images. This > >allows for other programs to link to it and get access to qemu image > >file abstractions. > > > >To use ins

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 04:51:31PM +0100, Daniel P. Berrange wrote: > On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: > > Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > > > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > > >> > > >> > > >> On 08/22/2011 02:39 PM, Blu

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 05:50:03PM +0200, Kevin Wolf wrote: > Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > >> > >> > >> On 08/22/2011 02:39 PM, Blue Swirl wrote: > >>> On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant > >>> wrote

Re: [Qemu-devel] [PATCH 2/2] [FYI] coverage test for Linux installs

2011-08-23 Thread Ryan Harper
* Anthony Liguori [2011-08-08 14:33]: > This is a simple tool that I've been using for the past couple months to help > with day-to-day testing of changes. It may seem like it's similar to > kvm-autotest but it's actually quite different. Most noticably: > > - It's a coverage test instead of a

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 17:26, schrieb Daniel P. Berrange: > On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: >> >> >> On 08/22/2011 02:39 PM, Blue Swirl wrote: >>> On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant >>> wrote: > > > On 08/22/2011 01:25 PM, Anthony Liguori wrote: >>

Re: [Qemu-devel] [PATCH v3 00/15] qcow/qcow2 cleanups

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 15:21, schrieb Frediano Ziglio: > These patches mostly cleanup some AIO code using coroutines. > Mostly they use stack instead of allocated AIO structure. > Feel free to collapse it too short. > > Frediano Ziglio (15): > qcow: allocate QCowAIOCB structure using stack > qcow: QCow

Re: [Qemu-devel] [PATCH v3 15/15] qcow2: small optimization

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 15:21, schrieb Frediano Ziglio: > Signed-off-by: Frediano Ziglio > --- > block/qcow2-refcount.c | 11 +-- > 1 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 0f9a64a..243c24b 100644 > --- a/block/qcow

Re: [Qemu-devel] [PATCH v3 14/15] qcow2: small math optimization

2011-08-23 Thread Kevin Wolf
Am 23.08.2011 15:21, schrieb Frediano Ziglio: > Signed-off-by: Frediano Ziglio > --- > block/qcow2-refcount.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c > index 2a915be..0f9a64a 100644 > --- a/block/qcow2-refc

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Daniel P. Berrange
On Tue, Aug 23, 2011 at 11:13:34AM -0400, Corey Bryant wrote: > > > On 08/22/2011 02:39 PM, Blue Swirl wrote: > >On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant > >wrote: > >>> > >>> > >>> On 08/22/2011 01:25 PM, Anthony Liguori wrote: > > > > On 08/22/2011 11:50 AM, Daniel P. Berrange

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/22/2011 02:39 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 5:42 PM, Corey Bryant wrote: > > > On 08/22/2011 01:25 PM, Anthony Liguori wrote: >> >> On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: >>> >>> On Mon, Aug 22, 2011 at 11:29:12AM -0500, Anthony Liguori wrote:

Re: [Qemu-devel] RFCv2: virDomainSnapshotCreateXML enhancements

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 2:40 PM, Eric Blake wrote: > On 08/23/2011 03:52 AM, Stefan Hajnoczi wrote: >> >> On Wed, Aug 10, 2011 at 11:08 PM, Eric Blake  wrote: >>> >>> disk snapshot: the state of a virtual disk used at a given time; once a >>> snapshot exists, then it is possible to track a delta o

Re: [Qemu-devel] Grand Unified Tracing

2011-08-23 Thread Blue Swirl
On Tue, Aug 23, 2011 at 2:45 PM, Stefan Hajnoczi wrote: > On Tue, Aug 23, 2011 at 3:34 PM, Blue Swirl wrote: >> On Tue, Aug 23, 2011 at 5:35 AM, Stefan Hajnoczi wrote: >>> On Mon, Aug 22, 2011 at 9:59 PM, Blue Swirl wrote: On Mon, Aug 22, 2011 at 8:23 PM, Stefan Hajnoczi wrote:

[Qemu-devel] MPC5200 + BestComm support in QEMU

2011-08-23 Thread steve . belanger
Hi, I'm Steve, an embedded software developper for Bombardier Transportation Canada. We use the MPC5200 for most of our onboard computers inside train control systems. To enhance our SW engineering process, we would like the emulate the MPC5200 processor using QEMU, an open source software CPU

Re: [Qemu-devel] Grand Unified Tracing

2011-08-23 Thread Stefan Hajnoczi
On Tue, Aug 23, 2011 at 3:34 PM, Blue Swirl wrote: > On Tue, Aug 23, 2011 at 5:35 AM, Stefan Hajnoczi wrote: >> On Mon, Aug 22, 2011 at 9:59 PM, Blue Swirl wrote: >>> On Mon, Aug 22, 2011 at 8:23 PM, Stefan Hajnoczi wrote: On Mon, Aug 22, 2011 at 7:14 PM, Blue Swirl wrote: > OpenBIOS

Re: [Qemu-devel] Grand Unified Tracing

2011-08-23 Thread Blue Swirl
On Tue, Aug 23, 2011 at 5:35 AM, Stefan Hajnoczi wrote: > On Mon, Aug 22, 2011 at 9:59 PM, Blue Swirl wrote: >> On Mon, Aug 22, 2011 at 8:23 PM, Stefan Hajnoczi wrote: >>> On Mon, Aug 22, 2011 at 7:14 PM, Blue Swirl wrote: OpenBIOS uses traditional DPRINTFs for debugging. I was considering

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Anthony Liguori
On 08/23/2011 09:26 AM, Corey Bryant wrote: On 08/22/2011 03:25 PM, Anthony Liguori wrote: On 08/22/2011 01:22 PM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 12:25:25PM -0500, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 11:29:12AM -0

Re: [Qemu-devel] [libvirt] [PATCH v4] Add support for fd: protocol

2011-08-23 Thread Corey Bryant
On 08/22/2011 03:25 PM, Anthony Liguori wrote: On 08/22/2011 01:22 PM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 12:25:25PM -0500, Anthony Liguori wrote: On 08/22/2011 11:50 AM, Daniel P. Berrange wrote: On Mon, Aug 22, 2011 at 11:29:12AM -0500, Anthony Liguori wrote: I don't think it

Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues

2011-08-23 Thread Jan Kiszka
On 2011-08-23 16:02, Anthony Liguori wrote: > On 08/23/2011 08:02 AM, Jan Kiszka wrote: >> On 2011-08-23 14:40, Anthony Liguori wrote: >>> You should be able to just use an eventfd or pipe. >>> >>> Better yet, we should look at using GThreadPool to replace posix-aio-compat. >> >> When interacting w

[Qemu-devel] [PATCH v3 08/15] qcow2: remove l2meta from QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index f920dbe..4b9ec29 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,7 +381,6 @@ typedef struct QCowAIOCB { uint64_t

[Qemu-devel] [PATCH v3 11/15] qcow2: reindent and use while before the big jump

2011-08-23 Thread Frediano Ziglio
prepare to remove read/write callbacks Signed-off-by: Frediano Ziglio --- block/qcow2.c | 272 - 1 files changed, 135 insertions(+), 137 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 519fc8b..287dd99 100644 --- a/block/qco

[Qemu-devel] [PATCH v3 06/15] qcow2: removed unused fields

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index bb6c75e..4171b47 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -381,11 +381,8 @@ typedef struct QCowAIOCB { uint64_t byt

[Qemu-devel] [PATCH v3 07/15] qcow2: removed cur_nr_sectors field in QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 98 + 1 files changed, 43 insertions(+), 55 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 4171b47..f920dbe 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -377,7 +377,6

Re: [Qemu-devel] [PATCH v2] posix-aio-compat: fix latency issues

2011-08-23 Thread Anthony Liguori
On 08/23/2011 08:02 AM, Jan Kiszka wrote: On 2011-08-23 14:40, Anthony Liguori wrote: You should be able to just use an eventfd or pipe. Better yet, we should look at using GThreadPool to replace posix-aio-compat. When interacting with the thread pool is part of some time-critical path (easil

Re: [Qemu-devel] [PATCH v2 00/15] qcow/qcow2 cleanups

2011-08-23 Thread Frediano Ziglio
2011/8/22 Kevin Wolf : > Am 09.08.2011 09:46, schrieb Frediano Ziglio: >> These patches mostly cleanup some AIO code using coroutines. >> Mostly they use stack instead of allocated AIO structure. >> Feel free to collapse it too short. >> >> Frediano Ziglio (15): >>   qcow: allocate QCowAIOCB struct

[Qemu-devel] [PATCH v3 10/15] qcow2: remove common from QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 7e13283..519fc8b 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -373,7 +373,7 @@ int qcow2_backing_read1(BlockDriverState *bs, Q

[Qemu-devel] [PATCH v3 09/15] qcow2: remove cluster_offset from QCowAIOCB

2011-08-23 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- block/qcow2.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 4b9ec29..7e13283 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -378,7 +378,6 @@ typedef struct QCowAIOCB {

  1   2   >