Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-10-20 Thread Peter Maydell
On 20 October 2011 23:51, Andreas Färber wrote: > I have now come across such a heterogeneous SoC myself: Renesas announced > the R-Car H1 this week, a SoC with one SH4A core and four ARM Cortex-A9 > cores. Does it expose the SH4 to apps/OSes, or is it mostly used for power management or similar

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-20 Thread Alexander Graf
On 20.10.2011, at 22:06, David Gibson wrote: > On Thu, Oct 20, 2011 at 07:40:00PM -0700, Alexander Graf wrote: >> On 20.10.2011, at 17:41, David Gibson wrote: >>> On Thu, Oct 20, 2011 at 10:12:51AM -0700, Alexander Graf wrote: On 17.10.2011, at 21:15, David Gibson wrote: > [snip] >>> So, I

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy

2011-10-20 Thread Paolo Bonzini
On 10/20/2011 07:23 PM, Stefan Hajnoczi wrote: On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote: Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- block/qed.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Thanks, applied to the trivial patches tr

[Qemu-devel] QEMU via GDB

2011-10-20 Thread Davide
Dear all, I am trying to debug QEMU via GDB. I configured and compiled QEMU with debugging flags, i.e., # CFLAGS="-g3 -O0" ./configure --disable-gfx-check and run gdb: # gdb ./i386-linux-user/qemu-i386 (gdb) break main (gdb) run Starting program: /home/test/femu/i386-linux-user/qemu-i386

Re: [Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode

2011-10-20 Thread Stefan Weil
Am 20.10.2011 23:36, schrieb malc: On Thu, 20 Oct 2011, Stefan Weil wrote: [..snip..] +/* Trace message to see program flow. */ +#if defined(CONFIG_DEBUG_TCG_INTERPRETER) +#define TRACE() \ +loglevel \ +? fprintf(stderr, "TCG %s:%u: %s()\n", __FILE__, __LINE__, __func__) \ +: (void

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-20 Thread David Gibson
On Thu, Oct 20, 2011 at 07:40:00PM -0700, Alexander Graf wrote: > On 20.10.2011, at 17:41, David Gibson wrote: > > On Thu, Oct 20, 2011 at 10:12:51AM -0700, Alexander Graf wrote: > >> On 17.10.2011, at 21:15, David Gibson wrote: [snip] > > So, I really don't follow what the logic you want is. It

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-20 Thread David Gibson
On Thu, Oct 20, 2011 at 08:35:45PM +0200, Gerd Hoffmann wrote: > Hi, > > > If there are build problems with libfdt on any platform let me know > > about them. I would like it to build clean as widely as possible, but > > I don't have that great a diversity of build environments, so I have > > t

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-20 Thread Alexander Graf
On 20.10.2011, at 17:41, David Gibson wrote: > On Thu, Oct 20, 2011 at 10:12:51AM -0700, Alexander Graf wrote: >> On 17.10.2011, at 21:15, David Gibson wrote: > [snip] >>> const ppc_def_t *kvmppc_host_cpu_def(void) >>> { >>>uint32_t host_pvr = mfpvr(); >>>const ppc_def_t *base_spec; >>>

[Qemu-devel] buildbot failure in qemu on qmp_x86_64_debian_6_0

2011-10-20 Thread qemu
The Buildbot has detected a new failure on builder qmp_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_x86_64_debian_6_0/builds/67 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

[Qemu-devel] buildbot failure in qemu on qmp_i386_debian_6_0

2011-10-20 Thread qemu
The Buildbot has detected a new failure on builder qmp_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_i386_debian_6_0/builds/67 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason:

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Avoid decrementer related kvm exits

2011-10-20 Thread David Gibson
On Thu, Oct 20, 2011 at 10:08:36AM -0700, Alexander Graf wrote: > > On 16.10.2011, at 22:26, David Gibson wrote: > > > In __cpu_ppc_store_decr(), we set up a regular timer used to trigger > > decrementer interrupts. This is necessary to implement the decrementer > > properly under TCG, but is un

Re: [Qemu-devel] passing secrets to block devices

2011-10-20 Thread shu ming
On 2011-10-21 5:48, Josh Durgin wrote: On 10/20/2011 12:24 PM, Daniel P. Berrange wrote: On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret. Normally, to avoid put

Re: [Qemu-devel] [PATCH] Add wildcard trace event support

2011-10-20 Thread Mars.Cao
On 10/20/2011 05:38 PM, Mark Wu wrote: A basic wildcard matching is supported in both the monitor command "trace-event" and the events list file. That means you can enable/disable the events having a common prefix in a batch. For example, virtio-blk trace events could be enabled using: trace

Re: [Qemu-devel] [PATCH 1/1] ACPI: Call ACPI remove handler when handling ACPI eject event

2011-10-20 Thread Chen Gong
于 2011/10/20 17:37, qemul...@gmail.com 写道: On Wed, Oct 19, 2011 at 09:35:46PM +0800, Gong Chen wrote: On Wed, Oct 19, 2011 at 10:47 AM, wrote: From: Liu Ping Fan Call the remove handler for ACPI_NOTIFY_EJECT_REQUEST Signed-off-by: Liu Ping Fan --- drivers/acpi/bus.c |2 +- driver

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-20 Thread David Gibson
On Thu, Oct 20, 2011 at 10:12:51AM -0700, Alexander Graf wrote: > On 17.10.2011, at 21:15, David Gibson wrote: [snip] > > const ppc_def_t *kvmppc_host_cpu_def(void) > > { > > uint32_t host_pvr = mfpvr(); > > const ppc_def_t *base_spec; > > +ppc_def_t *spec; > > +uint32_t vmx = kvmpp

Re: [Qemu-devel] [PATCH 1/5] Convert calls to g_malloc() using casts to g_new()

2011-10-20 Thread Stuart Brady
On Thu, Oct 20, 2011 at 10:55:38AM +0200, Paolo Bonzini wrote: > On 10/20/2011 10:03 AM, Stuart Brady wrote: > >Convert calls to g_malloc() and g_malloc0() to g_new() and g_new0() > >respectively, in cases where the return value is casted to the same > >type as specified using sizeof() in the param

Re: [Qemu-devel] [PATCH 5/5] Convert remaining calls to g_malloc(sizeof(type)) to g_new()

2011-10-20 Thread Stuart Brady
On Thu, Oct 20, 2011 at 11:05:33AM +0200, Paolo Bonzini wrote: > On 10/20/2011 10:03 AM, Stuart Brady wrote: > >Coccinelle did not match these when matching assignments involving an > >expression corresponding to the type used for determining the size to > >allocate. > > They all look okay, perhap

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-10-20 Thread Andreas Färber
Am 26.05.2011 um 21:11 schrieb Blue Swirl: On Wed, May 25, 2011 at 10:20 PM, Peter Maydell wrote: On 25 May 2011 19:44, Greg McGary wrote: I would like to create a QEMU model of an SoC that has several CPU cores having different architectures. I'm guessing this can be done. It's not suppo

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

2011-10-20 Thread Michael S. Tsirkin
On Wed, Oct 19, 2011 at 01:17:03PM +0200, Jan Kiszka wrote: > On 2011-10-19 11:03, Michael S. Tsirkin wrote: > >>> I thought we need to match APIC ID. That needs a table lookup, no? > >> > >> Yes. But that's completely independent of a concrete MSI message. In > >> fact, this is the same thing we n

Re: [Qemu-devel] passing secrets to block devices

2011-10-20 Thread Josh Durgin
On 10/20/2011 12:24 PM, Daniel P. Berrange wrote: On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret. Normally, to avoid putting the secret on the command line, you

Re: [Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode

2011-10-20 Thread malc
On Thu, 20 Oct 2011, Stefan Weil wrote: [..snip..] > +/* Trace message to see program flow. */ > +#if defined(CONFIG_DEBUG_TCG_INTERPRETER) > +#define TRACE() \ > +loglevel \ > +? fprintf(stderr, "TCG %s:%u: %s()\n", __FILE__, __LINE__, __func__) \ > +: (void)0 This is wrong, fprintf

[Qemu-devel] [PATCH v2 5/6] tcg: Add tci disassembler

2011-10-20 Thread Stefan Weil
Signed-off-by: Stefan Weil --- dis-asm.h |1 + disas.c |4 +++- tci-dis.c | 59 +++ 3 files changed, 63 insertions(+), 1 deletions(-) create mode 100644 tci-dis.c diff --git a/dis-asm.h b/dis-asm.h index 5b07d7f..4f15fad 100644

[Qemu-devel] [PATCH v2 4/6] tcg: Add interpreter for bytecode

2011-10-20 Thread Stefan Weil
Signed-off-by: Stefan Weil --- tci.c | 1225 + 1 files changed, 1225 insertions(+), 0 deletions(-) create mode 100644 tci.c diff --git a/tci.c b/tci.c new file mode 100644 index 000..470d696 --- /dev/null +++ b/tci.c @@ -0,0 +1

[Qemu-devel] [PATCH v2 6/6] tcg: Add tcg interpreter to configure / make

2011-10-20 Thread Stefan Weil
Signed-off-by: Stefan Weil --- Makefile.target |4 configure | 34 -- 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/Makefile.target b/Makefile.target index 417f23e..924f733 100644 --- a/Makefile.target +++ b/Makefile.target @@ -69

[Qemu-devel] [PATCH v2 3/6] tcg: Add bytecode generator for tcg interpreter

2011-10-20 Thread Stefan Weil
Unlike other tcg target code generators, this one does not generate machine code for some cpu. It generates machine independent bytecode which is interpreted later. This allows running QEMU on any host. Interpreted bytecode is slower than direct execution of generated machine code. Signed-off-by

[Qemu-devel] [PATCH v2 2/6] tcg: Make ARRAY_SIZE(tcg_op_defs) globally available

2011-10-20 Thread Stefan Weil
tcg_op_defs was already a global array. The tci disassembler also needs ARRAY_SIZE(tcg_op_defs), so add a new global constant with this value. Signed-off-by: Stefan Weil --- tcg/tcg.c |1 + tcg/tcg.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tcg/tcg.c b/tcg/tc

[Qemu-devel] [PATCH v2 0/6] tcg/interpreter: Add TCG + interpreter for bytecode

2011-10-20 Thread Stefan Weil
This is a new version of my patch series which adds support for QEMU on any host by using a TCG interpreter (TCI). Some of the suggestions from the last patch version (http://lists.nongnu.org/archive/html/qemu-devel/2011-09/msg02270.html) are included now. Thank you to all who reviewed the code an

[Qemu-devel] [PATCH v2 1/6] tcg: TCG targets may define tcg_qemu_tb_exec

2011-10-20 Thread Stefan Weil
Targets may use a non standard definition of tcg_tb_exec by defining this macro in their tcg_target.h. This is used here by ppc. It will be used by the TCG interpreter, too. Signed-off-by: Stefan Weil --- tcg/ppc/tcg-target.h |4 tcg/tcg.h|9 - 2 files changed,

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Rich Wellum
On Oct 20, 2011, at 2:17 PM, Stefan Hajnoczi wrote: > On Thu, Oct 20, 2011 at 10:54 AM, Rich Wellum wrote: >> Hi Stefan, >>> qemu-img >> qemu-img version 0.15.50, Copyright (c) 2004-2008 Fabrice Bellard >> I haven't got this to work on any version - I was trying this version >> because of the ex

Re: [Qemu-devel] [PATCH] hw/9pfs: Fix broken compilation caused by wrong trace events

2011-10-20 Thread Anthony Liguori
On 10/20/2011 02:55 PM, Stefan Weil wrote: Commit c572f23a3e7180dbeab5e86583e43ea2afed6271 added trace events with mismatching format string and arguments. gcc reports these errors: In file included from trace.c:2:0: trace.h: In function ‘trace_v9fs_attach’: trace.h:2850:9: error: too many argu

Re: [Qemu-devel] [PATCH] hw/9pfs: Fix broken compilation caused by wrong trace events

2011-10-20 Thread Stefan Weil
Am 20.10.2011 21:48, schrieb Stefan Weil: > Commit c572f23a3e7180dbeab5e86583e43ea2afed6271 added trace events > with mismatching format string and arguments. > > gcc reports these errors: > > In file included from trace.c:2:0: > trace.h: In function ‘trace_v9fs_attach’: > trace.h:2850:9: error: to

[Qemu-devel] [PATCH] hw/9pfs: Fix broken compilation caused by wrong trace events

2011-10-20 Thread Stefan Weil
Commit c572f23a3e7180dbeab5e86583e43ea2afed6271 added trace events with mismatching format string and arguments. gcc reports these errors: In file included from trace.c:2:0: trace.h: In function ‘trace_v9fs_attach’: trace.h:2850:9: error: too many arguments for format [-Werror=format-extra-args]

[Qemu-devel] [PATCH] hw/9pfs: Fix broken compilation caused by wrong trace events

2011-10-20 Thread Stefan Weil
Commit c572f23a3e7180dbeab5e86583e43ea2afed6271 added trace events with mismatching format string and arguments. gcc reports these errors: In file included from trace.c:2:0: trace.h: In function ‘trace_v9fs_attach’: trace.h:2850:9: error: too many arguments for format [-Werror=format-extra-args]

Re: [Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-20 Thread Stefan Weil
Am 20.10.2011 21:20, schrieb Max Filippov: > Hi. > > Current git head build with trace enabled is broken by the commit > c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p > pdu handlers. > Error messages: > > In file included from trace.c:2:0: > trace.h: In function ‘trac

Re: [Qemu-devel] passing secrets to block devices

2011-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: > We're working on libvirt support for block device authentication [1]. To > authenticate, rbd needs a username and a secret. Normally, to > avoid putting the secret on the command line, you can store the secret > in a file and pass the f

[Qemu-devel] build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers

2011-10-20 Thread Max Filippov
Hi. Current git head build with trace enabled is broken by the commit c572f23a3e7180dbeab5e86583e43ea2afed6271 hw/9pfs: Introduce tracing for 9p pdu handlers. Error messages: In file included from trace.c:2:0: trace.h: In function ‘trace_v9fs_attach’: trace.h:2850:9: error: too many arguments f

[Qemu-devel] [PATCH] monitor: refactor whitespace and optional argument parsing

2011-10-20 Thread Alon Levy
Takes out the optional ('?') message parsing from the main switch loop in monitor_parse_command. Adds optional argument option for boolean parameters. Signed-off-by: Alon Levy --- Previous patch used qemu_free (that's how old it is), fixed. monitor.c | 79 +++--

[Qemu-devel] [PATCH] monitor: refactor whitespace and optional argument parsing

2011-10-20 Thread Alon Levy
Takes out the optional ('?') message parsing from the main switch loop in monitor_parse_command. Adds optional argument option for boolean parameters. Signed-off-by: Alon Levy --- Hi, I think I've sent this before as part of another series, but the rest of the patches became non relevant (the

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: Fail configure when libfdt is not available

2011-10-20 Thread Gerd Hoffmann
Hi, > If there are build problems with libfdt on any platform let me know > about them. I would like it to build clean as widely as possible, but > I don't have that great a diversity of build environments, so I have > to reply on bug reports. Fails to build on RHEL-5: CC convert-dts

[Qemu-devel] passing secrets to block devices

2011-10-20 Thread Josh Durgin
We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret. Normally, to avoid putting the secret on the command line, you can store the secret in a file and pass the file to qemu, but when this is automated, there's no good way to know

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Stefan Hajnoczi
On Thu, Oct 20, 2011 at 10:54 AM, Rich Wellum wrote: > Hi Stefan, >> qemu-img > qemu-img version 0.15.50, Copyright (c) 2004-2008 Fabrice Bellard > I haven't got this to work on any version - I was trying this version > because of the expanded list of sub format versions - I thought one of them >

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Rich Wellum
Hi Stefan, > qemu-img qemu-img version 0.15.50, Copyright (c) 2004-2008 Fabrice Bellard I haven't got this to work on any version - I was trying this version because of the expanded list of sub format versions - I thought one of them might be accepted. Thanks, ||Rich On Oct 20, 2011, at 1:50

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Stefan Hajnoczi
On Thu, Oct 20, 2011 at 8:48 AM, Rich Wellum wrote: > When I convert an ISO to a VMDk and try to deploy it as part of an OVF > package in vSphere I get the following error: > > I've tried: > qemu-img convert -O vmdk image.iso image.vmdk > qemu-img convert -f raw image.iso -O vmdk image.vmdk > I'm

Re: [Qemu-devel] [PATCH 1/2] qemu-img: Don't allow preallocation and compression at the same time

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 8:47 AM, Kevin Wolf wrote: > Only qcow and qcow2 can do compression at all, and they require unallocated > clusters when writing the compressed data. > > Signed-off-by: Kevin Wolf > --- >  qemu-img.c |    9 + >  1 files changed, 9 insertions(+), 0 deletions(-) Rev

Re: [Qemu-devel] [Question]WinDbg runs too slowly or exits unexpectly when debug windows guest driver under QEMU 0.15.50

2011-10-20 Thread Stefan Hajnoczi
On Wed, Oct 19, 2011 at 3:24 AM, Mars.Cao wrote: > /usr/local/bin/qemu-system-x86_64 -drive > file=winxpsp3.img,if=virtio,format=qcow2,cache=none,aio=threads -smp 2 -net > tap,ifname=tap0,script=no,downscript=no -net > nic,model=virtio,macaddr=52:54:00:d6:be:bb -m 1024 --enable-kvm -serial > tcp:1

Re: [Qemu-devel] [RFC 5/6] block: core copy-on-read logic

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 7:00 AM, Marcelo Tosatti wrote: > On Mon, Oct 17, 2011 at 04:47:31PM +0100, Stefan Hajnoczi wrote: >> Signed-off-by: Stefan Hajnoczi >> --- >>  block.c      |   69 >> ++ >>  trace-events |    1 + >>  2 files changed,

Re: [Qemu-devel] [RFC 3/6] block: wait for overlapping requests

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 6:48 AM, Marcelo Tosatti wrote: > On Mon, Oct 17, 2011 at 04:47:29PM +0100, Stefan Hajnoczi wrote: >> When copy-on-read is enabled it is necessary to wait for overlapping >> requests before issuing new requests.  This prevents races between the >> copy-on-read and a write r

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: remove unneeded variable assignment

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:17:56PM +0400, Pavel Borzenkov wrote: > 'ret' is unconditionally overwitten by qed_read_l1_table_sync() > > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/qed.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks, applied t

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: don't pass NULL to memcpy

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:17:35PM +0400, Pavel Borzenkov wrote: > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/qed.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.gi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: vmdk_read_cid returns garbage if p_name is NULL

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:19:03PM +0400, Pavel Borzenkov wrote: > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/vmdk.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/s

[Qemu-devel] [PATCH 3/8] qemu: Add opt_set_bool functionality

2011-10-20 Thread Aneesh Kumar K.V
From: "M. Mohan Kumar" Signed-off-by: M. Mohan Kumar Signed-off-by: Aneesh Kumar K.V --- qemu-option.c | 43 +++ qemu-option.h |3 ++- 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 105d760..1fd2

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: remove unneeded variable assignment

2011-10-20 Thread Stefan Hajnoczi
On Tue, Oct 18, 2011 at 09:18:22PM +0400, Pavel Borzenkov wrote: > Spotted by Clang Analyzer > > Signed-off-by: Pavel Borzenkov > --- > block/vmdk.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree: http://repo.or.cz/w/qemu/stefanha.git/sh

Re: [Qemu-devel] [PATCH] PPC: Bump qemu-system-ppc to 64-bit physical address space

2011-10-20 Thread Alexander Graf
On 18.10.2011, at 02:36, Andreas Färber wrote: > Am 18.10.2011 01:52, schrieb Alexander Graf: >> Some 32-bit PPC CPUs can use up to 36 bit of physicall address space. >> Treat them accordingly in the qemu-system-ppc binary type. > > physical > >> Signed-off-by: Alexander Graf >> --- >> configu

Re: [Qemu-devel] [PATCH] pseries: Correct vmx/dfp handling in both KVM and TCG cases

2011-10-20 Thread Alexander Graf
On 17.10.2011, at 21:15, David Gibson wrote: > Currently, when KVM is enabled, the pseries machine checks if the host > CPU supports VMX, VSX and/or DFP instructions and advertises > accordingly in the guest device tree. It does this regardless of what > CPU is selected on the command line. On

Re: [Qemu-devel] [PATCH] ppc: Avoid decrementer related kvm exits

2011-10-20 Thread Alexander Graf
On 16.10.2011, at 22:26, David Gibson wrote: > In __cpu_ppc_store_decr(), we set up a regular timer used to trigger > decrementer interrupts. This is necessary to implement the decrementer > properly under TCG, but is unnecessary under KVM (true for both Book3S-PR > and Book3S-HV KVM variants),

[Qemu-devel] [PATCH 0/8] VirtFS update 7 for review

2011-10-20 Thread Aneesh Kumar K.V
Hi, This patchset contain patches that will be included in the next pull request. Most of them are already posted to the list. Some of the patches got updated when adding to the v9fs.git tree. Please review -aneesh

[Qemu-devel] [PATCH 5/8] hw/9pfs: Abstract open state of fid to V9fsFidOpenState

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" To implement synthetic file system in Qemu we may not really require file descriptor and Dir *. Make generic code use V9fsFidOpenState instead. Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h | 32 -- hw/9pfs/codir.c| 16 -

[Qemu-devel] [PATCH 8/8] hw/9pfs: Replace rwlocks with RCU variants of interfaces.

2011-10-20 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora Use QLIST_INSERT_HEAD_RCU and rcu_read_lock/unlock instead of rwlocks. Use v9fs_synth_mutex as a write-only mutex to handle concurrent writers. Signed-off-by: Harsh Prateek Bora Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-synth.c | 29 +

[Qemu-devel] [PATCH 1/8] hw/9pfs: Fix error handling in local_mknod

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Update local_chown to remove unnecessary if loop Signed-off-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-local.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index d561de8..b611

[Qemu-devel] [PATCH 6/8] hw/9pfs: Add synthetic file system support using 9p

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" This patch create a synthetic file system with mount tag v_synth when -virtfs_synth command line option is specified in qemu. The synthetic file system can be mounted in guest using 9p using the below command line mount -t 9p -oversion=9p2000.L,trans=virtio v_synth Sy

[Qemu-devel] [PATCH 4/8] hw/9pfs: Read-only support for 9p export

2011-10-20 Thread Aneesh Kumar K.V
From: "M. Mohan Kumar" A new fsdev parameter "readonly" is introduced to control accessing 9p export. readonly=on|off can be used to specify the access type. By default rw access is given to 9p export. Signed-off-by: M. Mohan Kumar Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h |

Re: [Qemu-devel] [Qemu-trivial] [PATCH] device_tree: Fix potential memory leak

2011-10-20 Thread Stefan Hajnoczi
On Mon, Oct 17, 2011 at 10:12:09PM +0200, Stefan Weil wrote: > cppcheck error report: > > device_tree.c:156: error: Memory leak: dupname > > Signed-off-by: Stefan Weil > --- > device_tree.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches tree

[Qemu-devel] [PATCH 7/8] qemu-queue: Introduce QLIST_INSERT_HEAD_RCU and dummy RCU wrappers.

2011-10-20 Thread Aneesh Kumar K.V
From: Harsh Prateek Bora SynthFS needs a QLIST_INSERT_HEAD_RCU to make sure list instructions are not re-ordered and therefore avoiding a crash. There may be parallel readers which should be allowed for lock-free access and this variant allows us to get rid of rwlocks used by readers. SynthFS is

[Qemu-devel] [PATCH 2/8] configure: Update configure so that open_by_handle_at check returns correct value

2011-10-20 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" According to David Gibson for some compiler/libc combinations, open_by_handle_at test in configure isn't quite right: because the file_handle pointer is never dereferenced, gcc doesn't complain even if it is undefined. Change the test as suggested by him. Signed-off-by:

Re: [Qemu-devel] [PATCH] pc: Fix floppy drives with if=none

2011-10-20 Thread Markus Armbruster
Kevin Wolf writes: > Commit 63ffb564 broke floppy devices specific on the command line like > -drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it > relies on drive_get() which works only with -fda/-drive if=floppy. > > This patch resembles what we're already doing for IDE,

Re: [Qemu-devel] [PATCH V5] Add stdio char device on windows

2011-10-20 Thread Fabien Chouteau
On 12/10/2011 16:47, Fabien Chouteau wrote: > On 06/10/2011 16:37, Fabien Chouteau wrote: >> Simple implementation of an stdio char device on Windows. >> > > Any comments? > Anthony, can you apply this patch please? Thanks in advance, -- Fabien Chouteau

[Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-20 Thread Rich Wellum
Hi,Apologies in advance if I shouldn't be asking here - I can't find a dedicated forum.When I convert an ISO to a VMDk and try to deploy it as part of an OVF package in vSphere I get the following error:I've tried:qemu-img convert -O vmdk image.iso image.vmdkqemu-img convert -f raw image.iso -O vmd

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-20 Thread Kai Tietz
Hi, For trunk-version I have a tentative patch for this issue. On 4.6.x and older branches this doesn't work, as here we can't differenciate that easy between ms- and sysv-abi. But could somebody give this patch a try? Regards, Kai ChangeLog * config/i386/i386.c (ix86_frame_pointer_re

Re: [Qemu-devel] [PATCH] Raise 9pfs mount_tag limit from 32 to 255 bytes

2011-10-20 Thread Daniel P. Berrange
On Fri, Oct 07, 2011 at 04:49:13PM +0530, Aneesh Kumar K.V wrote: > On Fri, 7 Oct 2011 10:27:56 +0100, "Daniel P. Berrange" > wrote: > > On Thu, Sep 29, 2011 at 04:22:16PM +0100, Daniel P. Berrange wrote: > > > On Thu, Sep 29, 2011 at 08:23:49PM +0530, Aneesh Kumar K.V wrote: > > > > On Thu, 29 S

Re: [Qemu-devel] [PULL 0/5]: QMP queue

2011-10-20 Thread Anthony Liguori
On 10/14/2011 12:26 PM, Luiz Capitulino wrote: Most of the patches are runstate fixes and have been sent to the list already. The changes (since 210b3a70383b0bcc4266856431491b39dcb4f14d) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git qmp/queue Pulled.

Re: [Qemu-devel] [PULL] VirtFS update 6

2011-10-20 Thread Anthony Liguori
On 10/15/2011 05:19 AM, Aneesh Kumar K.V wrote: The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea1a: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2011-10-10 08:21:46 -0500) are available in the git repository at: git://repo.or.cz/qemu/v9fs.git for-

Re: [Qemu-devel] [PULL] Migration queue

2011-10-20 Thread Anthony Liguori
On 10/20/2011 07:31 AM, Juan Quintela wrote: Anthony, Here are the pending patches of my migration series: - subsections detection fix - migration cleanup - migration errors Please consider pulling O:-) Thanks, Juan. The following changes since commit cfce6d8934243871c4dc6d0c5248b0b27a1b8d80

Re: [Qemu-devel] [PULL 00/18] Memory API conversions, batch 12

2011-10-20 Thread Anthony Liguori
On 10/19/2011 05:59 AM, Avi Kivity wrote: Please pull from: git://github.com/avikivity/qemu.git memory/batch Yet more of the same. This has been on the list for a while, with no adverse reviews. Pulled. Thanks. Regards, Anthony Liguori Avi Kivity (18): ppc_oldworld: convert to mem

[Qemu-devel] [PATCH 8/8] target-arm: Fix use of free() in cpu_arm_close()

2011-10-20 Thread Peter Maydell
From: Andreas Färber env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free(). Signed-off-by: Andreas Färber Signed-off-by: Peter Maydell --- target-arm/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper

Re: [Qemu-devel] [PATCH] pc: Fix floppy drives with if=none

2011-10-20 Thread Zeeshan Ali (Khattak)
Hi Kevin, On Thu, Oct 20, 2011 at 5:41 PM, Kevin Wolf wrote: > Commit 63ffb564 broke floppy devices specific on the command line like > -drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it > relies on drive_get() which works only with -fda/-drive if=floppy. > > This patch re

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-20 Thread Kai Tietz
2011/10/20 xunxun : > Hi, all > > I think this issue causes the gdb crash on XP. > You can see the thread: http://sourceware.org/ml/gdb/2011-10/msg00056.html > > My many friends and I can reproduce this crash issue, but no problem on Win7. > > On Thu, Oct 20, 2011 at 5:05 AM, Bob Breuer wrote: >>

[Qemu-devel] [PATCH] pc: Fix floppy drives with if=none

2011-10-20 Thread Kevin Wolf
Commit 63ffb564 broke floppy devices specific on the command line like -drive file=...,if=none,id=floppy -global isa-fdc.driveA=floppy because it relies on drive_get() which works only with -fda/-drive if=floppy. This patch resembles what we're already doing for IDE, i.e. remember the floppy devic

[Qemu-devel] [PULL v2 0/8] target-arm queue

2011-10-20 Thread Peter Maydell
Hi; these are the pending target-arm patches I'd like to get in for 1.0; a couple of minor ones plus the A15 insn work. Please pull. V2 of this pullreq just adds Andreas' trivial patch as 8/8, so I haven't bothered re-emailing the identical 1-7, just this cover letter and 8/8. -- PMM The followi

Re: [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close()

2011-10-20 Thread Peter Maydell
On 20 October 2011 15:18, Andreas Färber wrote: > Am 10.10.2011 14:52, schrieb Andreas Färber: >> env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free(). >> >> Cc: Peter Maydell >> Signed-off-by: Andreas Färber >> --- >>  target-arm/helper.c |    2 +- >>  1 files changed, 1 i

Re: [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close()

2011-10-20 Thread Andreas Färber
Am 10.10.2011 14:52, schrieb Andreas Färber: > env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free(). > > Cc: Peter Maydell > Signed-off-by: Andreas Färber > --- > target-arm/helper.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/target-arm

[Qemu-devel] [PATCH 5/7] softfloat: Implement fused multiply-add

2011-10-20 Thread Peter Maydell
Implement fused multiply-add as a softfloat primitive. This implements "a+b*c" as a single step without any intermediate rounding; it is specified in IEEE 754-2008 and implemented in a number of CPUs. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 178 ++ fpu/soft

[Qemu-devel] [PATCH 4/7] target-arm: Add ARM UDIV/SDIV support

2011-10-20 Thread Peter Maydell
Add support for UDIV and SDIV in ARM mode. This is a new optional feature for A profile cores (Thumb mode has had UDIV and SDIV for M profile cores for some time). Signed-off-by: Peter Maydell --- target-arm/cpu.h |1 + target-arm/helper.c|5 - target-arm/translate.c | 19

[Qemu-devel] [PATCH 6/7] target-arm: Implement VFPv4 fused multiply-accumulate insns

2011-10-20 Thread Peter Maydell
Implement the fused multiply-accumulate instructions (VFMA, VFMS, VFNMA, VFNMS) which are new in VFPv4. Signed-off-by: Peter Maydell --- target-arm/cpu.h |1 + target-arm/helper.c| 14 + target-arm/helper.h|3 ++ target-arm/translate.c | 72 +

[Qemu-devel] [PATCH 2/7] target-arm: v6 media multiply space: UNDEF on unassigned encodings

2011-10-20 Thread Peter Maydell
Clean up the decoding of the v6 media multiply space so that we UNDEF on unassigned encodings rather than randomly interpreting them as some instruction in this space. Signed-off-by: Peter Maydell --- target-arm/translate.c | 24 1 files changed, 20 insertions(+), 4 de

[Qemu-devel] [PATCH 1/7] rsqrte_f32: No need to copy sign bit.

2011-10-20 Thread Peter Maydell
From: Christophe LYON Indeed, the result is known to be always positive. Signed-off-by: Christophe Lyon Signed-off-by: Peter Maydell --- target-arm/helper.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index e2428eb..17ef

[Qemu-devel] [PATCH 7/7] target-arm/machine.c: Restore VFP registers correctly

2011-10-20 Thread Peter Maydell
From: Dmitry Koshelev Fix the restoring of VFP registers on vmload. Signed-off-by: Dmitry Koshelev Reviewed-by: Juan Quintela [peter.maydell: improved commit message a little] Signed-off-by: Peter Maydell --- target-arm/machine.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) d

[Qemu-devel] [PULL 0/7] target-arm queue

2011-10-20 Thread Peter Maydell
Hi; these are the pending target-arm patches I'd like to get in for 1.0; a couple of minor ones plus the A15 insn work. Please pull. PS: I'm not sure who the best person to cc on target-arm pull requests is; any suggestions? thanks -- PMM The following changes since commit cfce6d8934243871c4dc6d

[Qemu-devel] [PATCH 3/7] target-arm: Rename ARM_FEATURE_DIV to _THUMB_DIV

2011-10-20 Thread Peter Maydell
Rename the ARM_FEATURE_DIV feature bit to _THUMB_DIV, to make room for a new feature switch enabling DIV in the ARM encoding. (Cores may implement either (a) no divide insns (b) divide insns in Thumb encodings only (c) divide insns in both ARM and Thumb encodings.) Signed-off-by: Peter Maydell --

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011-10-20 Thread jojelino
On 2011-10-20 AM 6:05, Bob Breuer wrote: We probably have a difference in build or run environment. I've double-checked with another machine and can get the same crash in longjmp when running the test executable on both WinXP and Win2k, but not on Win7. So it looks like Microsoft may have chan

[Qemu-devel] [PATCH v2 2/2] hw/onenand: reject read-only drives

2011-10-20 Thread juha . riihimaki
From: Juha Riihimäki Signed-off-by: Juha Riihimäki --- hw/onenand.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/onenand.c b/hw/onenand.c index 6f68f70..7898da9 100644 --- a/hw/onenand.c +++ b/hw/onenand.c @@ -26,6 +26,7 @@ #include "memory.h" #include "exec

[Qemu-devel] [PATCH v2 1/2] hw/nand: reject read-only drives

2011-10-20 Thread juha . riihimaki
From: Juha Riihimäki also gracefully fail on nand_device_init() for unsupported block size instead of aborting. Signed-off-by: Juha Riihimäki --- hw/nand.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/nand.c b/hw/nand.c index c27783e..fad00d1

[Qemu-devel] [PATCH v2 0/2] nand/onenand: reject read-only drives

2011-10-20 Thread juha . riihimaki
From: Juha Riihimäki Make NAND and OneNAND device models reject read-only drives. Test for example by running $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=foo -device nand,drive=foo,chip_id=0x59 -kernel /dev/null or $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=fo

[Qemu-devel] [PULL] Migration queue

2011-10-20 Thread Juan Quintela
Anthony, Here are the pending patches of my migration series: - subsections detection fix - migration cleanup - migration errors Please consider pulling O:-) Thanks, Juan. The following changes since commit cfce6d8934243871c4dc6d0c5248b0b27a1b8d80: i8259: Move to hw library (2011-10-16 11:1

[Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations

2011-10-20 Thread Paolo Bonzini
This does the first part of the conversion to coroutines, by wrapping bdrv_read implementations to take the read side of the rwlock. Drivers that implement bdrv_read rather than bdrv_co_readv can then benefit from asynchronous operation (at least if the underlying protocol supports it, which is no

[Qemu-devel] [PATCH v2 5/7] block: take lock around bdrv_write implementations

2011-10-20 Thread Paolo Bonzini
This does the first part of the conversion to coroutines, by wrapping bdrv_write implementations to take the write side of the rwlock. Drivers that implement bdrv_write rather than bdrv_co_writev can then benefit from asynchronous operation (at least if the underlying protocol supports it, which i

[Qemu-devel] [PATCH v2 6/7] block: change flush to co_flush

2011-10-20 Thread Paolo Bonzini
Since coroutine operation is now mandatory, convert all bdrv_flush implementations to coroutines. For qcow2, this means taking the lock. Other implementations are simpler and just forward bdrv_flush to the underlying protocol, so they can avoid the lock. The bdrv_flush callback is then unused and

[Qemu-devel] [PATCH v2 3/7] block: add a CoMutex to synchronous read drivers

2011-10-20 Thread Paolo Bonzini
The big conversion of bdrv_read/write to coroutines caused the two homonymous callbacks in BlockDriver to become reentrant. It goes like this: 1) bdrv_read is now called in a coroutine, and calls bdrv_read or bdrv_pread. 2) the nested bdrv_read goes through the fast path in bdrv_rw_co_entry; 3)

[Qemu-devel] [PATCH v2 2/7] vmdk: clean up open

2011-10-20 Thread Paolo Bonzini
Move vmdk_parent_open to vmdk_open. There's another path how vmdk_parent_open can be reached: vmdk_parse_extents() -> vmdk_open_sparse() -> vmdk_open_vmdk4() -> vmdk_open_desc_file(). If that can happen, however, the code is bogus. vmdk_parent_open reads from bs->file: if (bdrv_pread

[Qemu-devel] [PATCH v2 7/7] block: change discard to co_discard

2011-10-20 Thread Paolo Bonzini
Since coroutine operation is now mandatory, convert both bdrv_discard implementations to coroutines. For qcow2, this means taking the lock around the operation. raw-posix remains synchronous. The bdrv_discard callback is then unused and can be eliminated. Reviewed-by: Kevin Wolf Signed-off-by:

[Qemu-devel] [PATCH v2 1/7] vmdk: fix return values of vmdk_parent_open

2011-10-20 Thread Paolo Bonzini
While vmdk_open_desc_file (touched by the patch) correctly changed -1 to -EINVAL, vmdk_open did not. Fix it directly in vmdk_parent_open. Signed-off-by: Paolo Bonzini --- block/vmdk.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmd

  1   2   >