Re: [Qemu-devel] insmod virtio-blk is broken in qemu 1.0

2011-12-20 Thread Gleb Natapov
On Mon, Dec 19, 2011 at 10:38:02PM -0500, Kevin O'Connor wrote: > On Mon, Dec 19, 2011 at 12:02:59PM -0600, Anthony Liguori wrote: > > We really need to update SeaBIOS whenever there is a bug that we > > know requires an update. Things breakdown because of one or more of > > the following reasons:

Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support

2011-12-20 Thread Jan Kiszka
On 2011-12-20 04:10, Anthony Liguori wrote: > On 12/19/2011 08:46 PM, Anthony Liguori wrote: >> On 12/19/2011 07:19 PM, Jan Kiszka wrote: >>> On 2011-12-20 02:08, Anthony Liguori wrote: >> Here's how we solve this problem: >> >> 1) In the short term, advertise both devices as having the same >> VMs

[Qemu-devel] debuging about qemu-dm in xen 3.4.2

2011-12-20 Thread ¤終於aware
Hi, I am a newer to study qemu in xen, I have no idea how to debug and trace the qemu-dm efficiently. cheers bruce

[Qemu-devel] KVM Networking 2 Bridges

2011-12-20 Thread Robert P
Hello, i'm going to realize a KVM / DRBD / Pacemaker Cluster with 5 to 7 KVM instances. Basic Layout of all KVM instances is as following: The physical HP-Server ("hera", HP DL 360G6) has two ethernet devices. For every virtual machine there are the network bridges with a corresponding tun device

[Qemu-devel] [RFC][PATCT 0/8 v3] dump memory when host pci device is used by guest

2011-12-20 Thread Wen Congyang
Hi, all 'virsh dump' can not work when host pci device is used by guest. We have discussed this issue here: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html We have determined to introduce a new command dump to dump memory. The core file's format can be elf. Note: 1. The gue

Re: [Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Stefan Hajnoczi
On Mon, Dec 19, 2011 at 05:26:22PM -, Michael Niehren wrote: > i got the following output with your patch: > > Formatting 'test.img', fmt=qcow2 size=1073741824 encryption=off > cluster_size=65536 > bdrv_rw_co_entry is_write 0 sector_num 0 nb_sectors 1 =waiting for rwco.ret > != NOT_DONE > wa

Re: [Qemu-devel] [PATCH v9 3/3] pc: Support system flash memory with pflash

2011-12-20 Thread Stefan Hajnoczi
On Mon, Dec 19, 2011 at 01:41:03PM -0600, Anthony Liguori wrote: > On 12/15/2011 02:51 PM, Jordan Justen wrote: > >If a pflash image is found, then it is used for the system > >firmware image. > > > >If a pflash image is not initially found, then a read-only > >pflash device is created using the -b

[Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2011-12-20 Thread Dong Xu Wang
From: Dong Xu Wang On some platforms, __LINE__ will not expand to real number in QEMU_BUILD_BUG_ON, so if using QEMU_BUILD_BUG_ON twice, compiler will report errors. This patch will fix it. BTW, I got error message on RHEL 6.1/gcc 4.4.5. Signed-off-by: Dong Xu Wang --- compiler.h |4 +++-

[Qemu-devel] [RFC][PATCH 1/8 v3] Add API to create memory mapping list

2011-12-20 Thread Wen Congyang
The memory mapping list stores virtual address and physical address mapping. The folloing patch will use this information to create PT_LOAD in the vmcore. Signed-off-by: Wen Congyang --- Makefile.target |1 + memory_mapping.c | 130 ++ me

[Qemu-devel] [RFC][PATCH 2/8 v3] Add API to check whether a physical address is I/O address

2011-12-20 Thread Wen Congyang
This API will be used in the following patch. Signed-off-by: Wen Congyang --- cpu-common.h |1 + exec.c | 20 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index 8295e4f..75c01c3 100644 --- a/cpu-common.h +++ b/cpu-co

[Qemu-devel] [RFC][PATCH 3/8 v3] target-i386: implement cpu_get_memory_mapping()

2011-12-20 Thread Wen Congyang
Walk cpu's page table and collect all virtual address and physical address mapping. Then, add these mapping into memory mapping list. Signed-off-by: Wen Congyang --- Makefile.target |2 +- cpu-all.h |7 ++ target-i386/arch-dump.c | 254

[Qemu-devel] [RFC][PATCH 4/8 v3] Add API to get memory mapping

2011-12-20 Thread Wen Congyang
Add API to get all virtual address and physical address mapping. If there is no virtual address for some physical address, the virtual address is 0. Signed-off-by: Wen Congyang --- memory_mapping.c | 55 ++ memory_mapping.h |1 + 2 files

[Qemu-devel] [RFC][PATCH 5/8 v3] target-i386: Add API to write elf notes to core file

2011-12-20 Thread Wen Congyang
The core file contains register's value. These API write registers to core file, and them will be called in the following patch. Signed-off-by: Wen Congyang --- cpu-all.h |6 + target-i386/arch-dump.c | 246 +++ 2 files changed, 252

[Qemu-devel] [RFC][PATCH 6/8 v3] target-i386: Add API to add extra memory mapping

2011-12-20 Thread Wen Congyang
Crash needs extra memory mapping to determine phys_base. Signed-off-by: Wen Congyang --- cpu-all.h |2 ++ target-i386/arch-dump.c | 44 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index 038

[Qemu-devel] [RFC][PATCH 7/8 v3] target-i386: add API to get dump info

2011-12-20 Thread Wen Congyang
Dump info contains: endian, class and architecture. The next patch will use these information to create vmcore. Signed-off-by: Wen Congyang --- cpu-all.h |3 +++ dump.h | 10 ++ target-i386/arch-dump.c | 34 ++ 3 file

[Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'dump' to dump guest's memory

2011-12-20 Thread Wen Congyang
Signed-off-by: Wen Congyang --- Makefile.target |8 +- dump.c | 452 +++ dump.h |4 + hmp-commands.hx | 16 ++ monitor.c |3 + qmp-commands.hx | 24 +++ 6 files changed, 503 insertions(+), 4 deletions(-)

Re: [Qemu-devel] OEM Windows in Qemu

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 12:09:41AM -0700, in...@expertcomputerrepair.com wrote: > I've been trying for several days now to get my OEM > copy of Windows XP to pre-activate properly in Qemu-kvm.  I saw the > instructions for patching the seabios here: href="http://lists.gnu.org/archive/html/qemu-de

Re: [Qemu-devel] debuging about qemu-dm in xen 3.4.2

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 04:47:51PM +0800, ¤終於aware wrote: > I am a newer to study qemu in xen, > I have no idea how to debug and trace the qemu-dm efficiently. Please be more specific about the problem you are trying to debug. The approach you take depends on what you're trying to observe.

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Avi Kivity
On 12/20/2011 02:38 AM, Anthony Liguori wrote: >> That was v1 of my patches. Avi didn't like it, I tried it like this, and >> in the end I had to agree. So, no, I don't think we want such a model. > > > Yes, we do :-) > > The in-kernel APIC is a different implementation of the APIC device. > It's

Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support

2011-12-20 Thread Avi Kivity
On 12/20/2011 02:42 AM, Anthony Liguori wrote: >> Look down http://thread.gmane.org/gmane.comp.emulators.kvm.devel/82598 >> for the discussion of that model. > > > I have. I don't understand the rationale for jumping through hoops here. > > There seems to be an assertion that migrating from in-ker

Re: [Qemu-devel] [PATCH v6 4/4] Add support for net bridge

2011-12-20 Thread Hui Kai Ran
On 12/19/2011 09:11 PM, Corey Bryant wrote: The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is great for portability and flexibility but it's in

Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support

2011-12-20 Thread Avi Kivity
On 12/20/2011 04:46 AM, Anthony Liguori wrote: > > I would hope that you would agree that when designing the device > model, we should aim to do what makes sense independent of migration. > If we cannot achieve a certain feature with migration given the > logical modeling of devices, it probably s

Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support

2011-12-20 Thread Avi Kivity
On 12/20/2011 12:03 PM, Avi Kivity wrote: > On 12/20/2011 04:46 AM, Anthony Liguori wrote: > > > > I would hope that you would agree that when designing the device > > model, we should aim to do what makes sense independent of migration. > > If we cannot achieve a certain feature with migration gi

[Qemu-devel] [Bug 906804] [NEW] SIGSEGV using sheepdog

2011-12-20 Thread Julien Danjou
Public bug reported: While doing a mkfs on a Sheepdog volume attached inside a VM, qemu-kvm segfaults: Program received signal SIGSEGV, Segmentation fault. aio_read_response (opaque=0x0) at /build/buildd-qemu-kvm_1.0+dfsg-2-amd64-V1Rh0p/qemu-kvm-1.0+dfsg/block/sheepdog.c:784 784 /build/bui

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 05:03:47PM +0800, Dong Xu Wang wrote: > From: Dong Xu Wang > > On some platforms, __LINE__ will not expand to real number in > QEMU_BUILD_BUG_ON, > so if using QEMU_BUILD_BUG_ON twice, compiler will report errors. This patch > will > fix it. > > BTW, I got error message

[Qemu-devel] [PATCH] hw/omap_gpmc: Fix region map/unmap when configuring prefetch engine

2011-12-20 Thread Peter Maydell
When configuring the prefetch engine (and also when resetting from a state where the prefetch engine was enabled) be careful to adhere to the "unmap/change config fields/map" ordering, to avoid trying to delete the wrong MemoryRegions. This fixes an assertion failure in some cases. Signed-off-by:

[Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Michael Niehren
attached the binary with your patch ** Attachment added: "qemu-img binary" https://bugs.launchpad.net/qemu/+bug/902148/+attachment/2641005/+files/qemu-img -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

Re: [Qemu-devel] 回复: debuging about qemu-dm in xen 3.4.2

2011-12-20 Thread Stefan Hajnoczi
2011/12/20 ¤終於aware <250716...@qq.com>: >     I want to create a memory snapshot file (such as mm.snap) of current > virtual machine and  the mm.snap can be used as a arg of qemu cmd-line for > restoring the last memory condition. >     But I am not very clear about the structure of the qemu-dm sou

[Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Michael Niehren
here the compiled binary with your patch and the --enable-debug option This one works ** Attachment added: "qemu-img.debug" https://bugs.launchpad.net/qemu/+bug/902148/+attachment/2641012/+files/qemu-img2 -- You received this bug notification because you are a member of qemu- devel-ml, whic

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2011-12-20 Thread Dong Xu Wang
于 2011年12月20日 18:13, Stefan Hajnoczi 写道: On Tue, Dec 20, 2011 at 05:03:47PM +0800, Dong Xu Wang wrote: From: Dong Xu Wang On some platforms, __LINE__ will not expand to real number in QEMU_BUILD_BUG_ON, so if using QEMU_BUILD_BUG_ON twice, compiler will report errors. This patch will fix it.

Re: [Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 10:25 AM, Michael Niehren <902...@bugs.launchpad.net> wrote: > here the compiled binary with your patch and the --enable-debug option > This one works Thanks, I'm able to reproduce the problem here with your original binary. Will send an update once I've figured out what t

Re: [Qemu-devel] [PATCH v9 0/3] PC system flash support

2011-12-20 Thread Avi Kivity
On 12/19/2011 08:27 PM, Jordan Justen wrote: > On Sun, Dec 18, 2011 at 02:04, Avi Kivity wrote: > > On 12/15/2011 11:02 PM, Jordan Justen wrote: > >> I verified that 'info mtree' and 'info qdev' are equivalent for pc-1.0 > >> when using master and with my patches. > >> > >> However, I did discover

[Qemu-devel] Do vm snapshot feature exist in qemu as in VMware

2011-12-20 Thread ¤終於aware
Hi, how to save the current state of the running vm as a file and restore the last running state later by using the file as a arg of qemu cmd line?

Re: [Qemu-devel] [PATCH] hw/pl181.c: Add save/load support

2011-12-20 Thread Avi Kivity
On 12/20/2011 12:01 AM, Peter Maydell wrote: > Add save/load support to the PL181. > > +VMSTATE_INT32(linux_hack, pl181_state), > Is this real state? Can't it be recovered somehow from other state? -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH v6 4/4] Add support for net bridge

2011-12-20 Thread Hui Kai Ran
On 12/20/2011 06:02 PM, Hui Kai Ran wrote: On 12/19/2011 09:11 PM, Corey Bryant wrote: The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is gre

Re: [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix sense of REMAP bit

2011-12-20 Thread Avi Kivity
On 12/19/2011 06:45 PM, Peter Maydell wrote: > Use the new memory mutator API to simplify the flash remap code; > this allows us to drop the flash_mapped flag. > > This patch also fixes the sense of the REMAP bit, which was > reversed. > I'm surprised the word "also" doesn't cause the maintainers'

[Qemu-devel] [PATCH] qemu-options.hx: fix tls-channel help text

2011-12-20 Thread Alon Levy
Remove the default compiled out tunnel channel, add the always available cursor channel. Optimally the man page would depend on compiled in options, but that's harder to do. RHBZ: 688586 Signed-off-by: Alon Levy --- qemu-options.hx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] hw/pl181.c: Add save/load support

2011-12-20 Thread Peter Maydell
On 20 December 2011 10:55, Avi Kivity wrote: > On 12/20/2011 12:01 AM, Peter Maydell wrote: >> Add save/load support to the PL181. >> >> +        VMSTATE_INT32(linux_hack, pl181_state), >> > > Is this real state? Depends what you mean by "real state". It doesn't necessarily correspond to a flipfl

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-20 Thread Paolo Bonzini
+void visit_start_array(Visitor *v, void **obj, const char *name, size_t elem_count, + size_t elem_size, Error **errp); +void visit_next_array(Visitor *v, Error **errp); +void visit_end_array(Visitor *v, Error **errp); void visit_start_optional(Visitor *v, bool *present, c

[Qemu-devel] [PATCH] g_thread_init users: don't call it if glib >= 2.31

2011-12-20 Thread Alon Levy
since commit f9b29ca03 included in release 2.31 (docs below say 2.32 but that is not correct) and onwards g_thread_init is deprecated and calling it is not required: http://developer.gnome.org/glib/unstable/glib-Deprecated-Thread-APIs.html#g-thread-init g_thread_init has been deprecated since

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-20 Thread Paolo Bonzini
On 12/20/2011 12:12 PM, Paolo Bonzini wrote: I think this approach is wrong. We're mashing the design of vmstate with that of visitors and getting something that is not a visitor and not vmstate. Instead, I think you should have something like this: struct VMStateInfo { const ch

Re: [Qemu-devel] Do vm snapshot feature exist in qemu as in VMware

2011-12-20 Thread 陳韋任
On Tue, Dec 20, 2011 at 06:55:19PM +0800, ¤終於aware wrote: > Hi, > how to save the current state of the running vm as a file and restore > the last running state later by using the file as a arg of qemu cmd line? You can see http://en.wikibooks.org/wiki/QEMU/Monitor , search savevm and load

Re: [Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 10:49 AM, Stefan Hajnoczi wrote: > On Tue, Dec 20, 2011 at 10:25 AM, Michael Niehren > <902...@bugs.launchpad.net> wrote: >> here the compiled binary with your patch and the --enable-debug option >> This one works > > Thanks, I'm able to reproduce the problem here with your

Re: [Qemu-devel] [PATCH v2] multiboot: Fix bss segment support

2011-12-20 Thread Göran Weinholt
Alexander Graf writes: > On 19.12.2011, at 23:01, Anthony Liguori wrote: > > On 12/19/2011 11:35 AM, Alexander Graf wrote: > > On 24.07.2011, at 17:55, Göran Weinholt wrote: > > Multiboot images can specify a bss segment. The boot loader must > clear >

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-20 Thread Paolo Bonzini
On 12/20/2011 12:43 PM, Paolo Bonzini wrote: 1) You can still add a vtable to QEMUFile for "visit_type_int*" and "visit_type_uint*". But this vtable doesn't need start/end callbacks. Here I meant something simple like: void (*visit_type_int16) (QEMUFile *f, int16_t *x); that is really t

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 10:47 AM, Dong Xu Wang wrote: > 于 2011年12月20日 18:13, Stefan Hajnoczi 写道: > >> On Tue, Dec 20, 2011 at 05:03:47PM +0800, Dong Xu Wang wrote: >>> >>> From: Dong Xu Wang >>> >>> On some platforms, __LINE__ will not expand to real number in >>> QEMU_BUILD_BUG_ON, >>> so if usin

Re: [Qemu-devel] [PATCH] hw/omap_gpmc: Fix region map/unmap when configuring prefetch engine

2011-12-20 Thread Alexander Graf
On 20.12.2011, at 11:21, Peter Maydell wrote: > When configuring the prefetch engine (and also when resetting from > a state where the prefetch engine was enabled) be careful to adhere > to the "unmap/change config fields/map" ordering, to avoid trying > to delete the wrong MemoryRegions. This f

Re: [Qemu-devel] Do vm snapshot feature exist in qemu as in VMware

2011-12-20 Thread 陳韋任
On Tue, Dec 20, 2011 at 06:55:19PM +0800, ¤終於aware wrote: > Hi, > how to save the current state of the running vm as a file and restore > the last running state later by using the file as a arg of qemu cmd line? BTW, make sure your root file system's format support snapshot. For example, i

[Qemu-devel] [Bug 906864] [NEW] Always mouse grabbing with -usbdevice tablet

2011-12-20 Thread Fred
Public bug reported: version: QEMU emulator version 1.0 (qemu-kvm 1.0) QEMU emulator version 1.0 (qemu 1.0) (source builds) os: archlinux x86-64 last working version: qemu-kvm 0.15.1 commandline: each with "-usb -usbdevice tablet" and sdl output expected behavior: mous

[Qemu-devel] [PATCH] i440fx: remove piix3 field

2011-12-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/piix_pci.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 43c85aa..e188c7a 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -81,7 +81,6 @@ struct PCII440FXState { PAMMemoryRegion pam_regions[

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2011-12-20 Thread Dong Xu Wang
It can compile on my Ubuntu: DISTRIB_ID=Ubuntu DISTRIB_RELEASE=11.10 DISTRIB_CODENAME=oneiric DISTRIB_DESCRIPTION="Ubuntu 11.10" gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1 While "gcc -E", it gets the same output as RHEL's, but it can compile. I do not know why was that. :( 在 2011年12月20日 下午8:08,S

Re: [Qemu-devel] [RFC] Migration convergence - a suggestion

2011-12-20 Thread Anthony Liguori
On 12/20/2011 01:06 AM, Ronen Hod wrote: Well the issue is not new, anyhow, following a conversation with Orit ... Since we want the migration to finish, I believe that the "migration speed" parameter alone cannot do the job. I suggest using two distinct parameters: 1. Migration speed - will be

Re: [Qemu-devel] [PATCH] rewrite QEMU_BUILD_BUG_ON

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 1:12 PM, Dong Xu Wang wrote: > It can compile on my Ubuntu: > > DISTRIB_ID=Ubuntu > DISTRIB_RELEASE=11.10 > DISTRIB_CODENAME=oneiric > DISTRIB_DESCRIPTION="Ubuntu 11.10" > > gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1 > > While "gcc -E", it gets the same output as RHEL's, but

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Anthony Liguori
On 12/20/2011 03:56 AM, Avi Kivity wrote: On 12/20/2011 02:38 AM, Anthony Liguori wrote: That was v1 of my patches. Avi didn't like it, I tried it like this, and in the end I had to agree. So, no, I don't think we want such a model. Yes, we do :-) The in-kernel APIC is a different implementa

Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support

2011-12-20 Thread Anthony Liguori
On 12/20/2011 04:08 AM, Avi Kivity wrote: On 12/20/2011 12:03 PM, Avi Kivity wrote: On 12/20/2011 04:46 AM, Anthony Liguori wrote: I would hope that you would agree that when designing the device model, we should aim to do what makes sense independent of migration. If we cannot achieve a certa

Re: [Qemu-devel] 回复: debuging about qemu-dm in xen 3.4.2

2011-12-20 Thread Anthony PERARD
On Tue, 20 Dec 2011, Stefan Hajnoczi wrote: > 2011/12/20 ¤終於aware <250716...@qq.com>: > >     I want to create a memory snapshot file (such as mm.snap) of current > > virtual machine and  the mm.snap can be used as a arg of qemu cmd-line for > > restoring the last memory condition. > >     But I a

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-20 Thread Anthony Liguori
On 12/20/2011 05:12 AM, Paolo Bonzini wrote: +void visit_start_array(Visitor *v, void **obj, const char *name, size_t elem_count, + size_t elem_size, Error **errp); +void visit_next_array(Visitor *v, Error **errp); +void visit_end_array(Visitor *v, Error **errp); void visit_start_optional(Visitor

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Paolo Bonzini
On 12/20/2011 02:41 PM, Anthony Liguori wrote: On 12/20/2011 03:56 AM, Avi Kivity wrote: On 12/20/2011 02:38 AM, Anthony Liguori wrote: That was v1 of my patches. Avi didn't like it, I tried it like this, and in the end I had to agree. So, no, I don't think we want such a model. Yes, we do :

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Anthony Liguori
On 12/20/2011 07:51 AM, Paolo Bonzini wrote: On 12/20/2011 02:41 PM, Anthony Liguori wrote: On 12/20/2011 03:56 AM, Avi Kivity wrote: On 12/20/2011 02:38 AM, Anthony Liguori wrote: That was v1 of my patches. Avi didn't like it, I tried it like this, and in the end I had to agree. So, no, I don

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Paolo Bonzini
On 12/20/2011 02:54 PM, Anthony Liguori wrote: In QOM parlance Jan implemented this: abstract class Object abstract class Device class APIC: { backend: link } abstract class APICBackend class QEMU_APICBackend class KVM_APICBackend I don't fundamentally object to

[Qemu-devel] [PATCH 0/2] Decouple vmstate from memory API

2011-12-20 Thread Avi Kivity
Currently creating a memory region automatically registers it for live migration. This differs from other state (which is enumerated in a VMStateDescription structure) and ties the live migration code into the memory core. Decouple the two by introducing a separate API, vmstate_register_ram(), fo

[Qemu-devel] [PATCH 1/2] memory: introduce memory_region_name()

2011-12-20 Thread Avi Kivity
Trivial accessor for the name attribute. Signed-off-by: Avi Kivity --- memory.c |5 + memory.h |9 + 2 files changed, 14 insertions(+), 0 deletions(-) diff --git a/memory.c b/memory.c index a90eefd..93f9569 100644 --- a/memory.c +++ b/memory.c @@ -1108,6 +1108,11 @@ uint64_t

Re: [Qemu-devel] [PATCH v2] multiboot: Fix bss segment support

2011-12-20 Thread Alexander Graf
On 20.12.2011, at 12:53, Göran Weinholt wrote: > Alexander Graf writes: > >> On 19.12.2011, at 23:01, Anthony Liguori wrote: >> >>On 12/19/2011 11:35 AM, Alexander Graf wrote: >> >>On 24.07.2011, at 17:55, Göran Weinholt wrote: >> >>Multiboot images can specify a bss

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Anthony Liguori
On 12/20/2011 07:57 AM, Paolo Bonzini wrote: On 12/20/2011 02:54 PM, Anthony Liguori wrote: In QOM parlance Jan implemented this: abstract class Object abstract class Device class APIC: { backend: link } abstract class APICBackend class QEMU_APICBackend class KVM_APICBackend I don't fundament

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Avi Kivity
On 12/20/2011 03:51 PM, Paolo Bonzini wrote: > On 12/20/2011 02:41 PM, Anthony Liguori wrote: >> On 12/20/2011 03:56 AM, Avi Kivity wrote: >>> On 12/20/2011 02:38 AM, Anthony Liguori wrote: > That was v1 of my patches. Avi didn't like it, I tried it like this, > and > in the end I had t

Re: [Qemu-devel] [PATCH] migration: vectorize is_dup_page

2011-12-20 Thread Anthony Liguori
On 12/06/2011 11:25 AM, Paolo Bonzini wrote: is_dup_page is already proceeding in 32-bit chunks. Changing it to 16 bytes using Altivec or SSE is easy, and provides a noticeable improvement. Pierre Riteau measured 30->25 seconds on a 16GB guest, I measured 4.6->3.9 seconds on a 6GB guest (best of

[Qemu-devel] [PATCH] g_thread_init users: don't call it if glib >= 2.31

2011-12-20 Thread Alon Levy
since commit f9b29ca03 included in release 2.31 (docs below say 2.32 but that is not correct) and onwards g_thread_init is deprecated and calling it is not required: http://developer.gnome.org/glib/unstable/glib-Deprecated-Thread-APIs.html#g-thread-init g_thread_init has been deprecated since

Re: [Qemu-devel] [PATCH 2/2] vmstate, memory: decouple vmstate from memory API

2011-12-20 Thread Avi Kivity
On 12/20/2011 04:09 PM, Anthony Liguori wrote: > On 12/20/2011 08:05 AM, Avi Kivity wrote: >> Currently creating a memory region automatically registers it for >> live migration. This differs from other state (which is enumerated >> in a VMStateDescription structure) and ties the live migration co

Re: [Qemu-devel] [PATCH v2 01/10] qapi: add Visitor interfaces for uint*_t and int*_t

2011-12-20 Thread Paolo Bonzini
On 12/20/2011 02:50 PM, Anthony Liguori wrote: For saving, you would adapt your visitor-based vmstate "put" routines so that they put things in a dictionary with no regard for integer types (a bit ugly for uint64, but perfectly fine for everything else). I don't understand this. The visitor int

Re: [Qemu-devel] [PATCH] qemu-options.hx: fix tls-channel help text

2011-12-20 Thread Gerd Hoffmann
On 12/20/11 12:05, Alon Levy wrote: > Remove the default compiled out tunnel channel, add the always available > cursor channel. Optimally the man page would depend on compiled in > options, but that's harder to do. Acked-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH] migration: vectorize is_dup_page

2011-12-20 Thread Avi Kivity
On 12/06/2011 07:25 PM, Paolo Bonzini wrote: > is_dup_page is already proceeding in 32-bit chunks. Changing it to 16 > bytes using Altivec or SSE is easy, and provides a noticeable improvement. > Pierre Riteau measured 30->25 seconds on a 16GB guest, I measured 4.6->3.9 > seconds on a 6GB guest (b

Re: [Qemu-devel] [PATCH 2/8] monitor: add ability to dump SLB entries

2011-12-20 Thread Alexander Graf
On 13.12.2011, at 05:24, David Gibson wrote: > From: Nishanth Aravamudan > > When run with a PPC Book3S (server) CPU Currently 'info tlb' in the > qemu monitor reports "dump_mmu: unimplemented". However, during > bringup work, it can be quite handy to have the SLB entries, which are > availabl

[Qemu-devel] [Bug 432154] Re: dynamic block device attach/detach not functional with karmic KVM

2011-12-20 Thread nix_user
I spent about 3 hr before I can find correct command to attach iSCSI /dev/vda to my instance euca-attach-volume vol-59A00634 -d /dev/vdb -i i-511908A5 I hope this tip save time for somebody. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Michael Niehren
Hi Stefan, here we are. Attached the tgz. I am using no spezial distribution, it's a self compiled LFS with gcc V4.5.1 Is there a different compiler-call if i use --enable-debug, which then works ? Greetings, Michael ** Attachment added: "coroutine-ucontext.tgz" https://bugs.launchpad.n

Re: [Qemu-devel] [0/8] Assorted pseries updates

2011-12-20 Thread Alexander Graf
On 13.12.2011, at 05:24, David Gibson wrote: > Now that qemu 1.0 is out there, here are a number of cleanups and > minor bugfixes for the pseries machine to queue up for post 1.0. Many > of these fix problems with non-default device configurations exposed > by the w.i.p. port of libvirt for powe

Re: [Qemu-devel] [PATCH] migration: vectorize is_dup_page

2011-12-20 Thread Paolo Bonzini
On 12/20/2011 04:24 PM, Avi Kivity wrote: On 12/06/2011 07:25 PM, Paolo Bonzini wrote: is_dup_page is already proceeding in 32-bit chunks. Changing it to 16 bytes using Altivec or SSE is easy, and provides a noticeable improvement. Pierre Riteau measured 30->25 seconds on a 16GB guest, I measur

Re: [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix sense of REMAP bit

2011-12-20 Thread Peter Maydell
On 20 December 2011 11:00, Avi Kivity wrote: > On 12/19/2011 06:45 PM, Peter Maydell wrote: >> Use the new memory mutator API to simplify the flash remap code; >> this allows us to drop the flash_mapped flag. >> >> This patch also fixes the sense of the REMAP bit, which was >> reversed. >> > > I'm

Re: [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix sense of REMAP bit

2011-12-20 Thread Avi Kivity
On 12/20/2011 05:51 PM, Peter Maydell wrote: > On 20 December 2011 11:00, Avi Kivity wrote: > > On 12/19/2011 06:45 PM, Peter Maydell wrote: > >> Use the new memory mutator API to simplify the flash remap code; > >> this allows us to drop the flash_mapped flag. > >> > >> This patch also fixes the

[Qemu-devel] [PATCH v2 1/2] hw/integratorcp: Fix sense of REMAP bit

2011-12-20 Thread Peter Maydell
Fix the sense of the REMAP bit: 0 should mean "map flash", 1 should mean "map RAM". Signed-off-by: Peter Maydell --- hw/integratorcp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 2551236..8e4c154 100644 --- a/hw/integrator

Re: [Qemu-devel] [PATCH v2] linux-user: Fix 32-on-64 mmap for x86_64

2011-12-20 Thread Alexander Graf
On 20.12.2011, at 08:46, 陳韋任 wrote: >> This patch is actually wrong and we should rather make proper -R values the >> default instead of relying on MAP_32BIT. > > I don't understand what "make proper -R values" means. Wher

Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts

2011-12-20 Thread Peter Maydell
On 14 December 2011 01:43, Alexander Graf wrote: > +unsigned long reserved_va = 0xf700; So why 0xf700 rather than the whole of the 32 bit space? (In particular for ARM targets we want to be able to mmap at 0x...) -- PMM

Re: [Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'dump' to dump guest's memory

2011-12-20 Thread Eric Blake
On 12/20/2011 02:15 AM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > Makefile.target |8 +- > dump.c | 452 > +++ > dump.h |4 + > hmp-commands.hx | 16 ++ > monitor.c |3 + > qmp-commands.hx

[Qemu-devel] [PATCH v2 2/2] hw/integratorcp: Simplify flash remap code

2011-12-20 Thread Peter Maydell
Use the new memory mutator API to simplify the flash remap code; this allows us to drop the flash_mapped flag. Signed-off-by: Peter Maydell --- hw/integratorcp.c | 26 +- 1 files changed, 9 insertions(+), 17 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp

[Qemu-devel] [PATCH v2 0/2] integratorcp: fix and simplify flash remap code

2011-12-20 Thread Peter Maydell
Same final result as patch v1, but I've split out fixing the sense of the remap bit into its own patch; Avi rightly pointed out that I was being lazy there. Peter Maydell (2): hw/integratorcp: Fix sense of REMAP bit hw/integratorcp: Simplify flash remap code hw/integratorcp.c | 26

Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts

2011-12-20 Thread Alexander Graf
On 20.12.2011, at 17:17, Peter Maydell wrote: > On 14 December 2011 01:43, Alexander Graf wrote: >> +unsigned long reserved_va = 0xf700; > > So why 0xf700 rather than the whole of the 32 bit space? > > (In particular for ARM targets we want to be able to mmap > at 0x...) Becau

Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts

2011-12-20 Thread Peter Maydell
On 20 December 2011 16:29, Alexander Graf wrote: > On 20.12.2011, at 17:17, Peter Maydell wrote: >> On 14 December 2011 01:43, Alexander Graf wrote: >>> +unsigned long reserved_va = 0xf700; >> >> So why 0xf700 rather than the whole of the 32 bit space? >> >> (In particular for ARM targets

Re: [Qemu-devel] [PATCH v2 2/2] hw/integratorcp: Simplify flash remap code

2011-12-20 Thread Avi Kivity
On 12/20/2011 06:08 PM, Peter Maydell wrote: > Use the new memory mutator API to simplify the flash remap code; > this allows us to drop the flash_mapped flag. > > > -static void integratorcm_do_remap(integratorcm_state *s, int flash) > +static void integratorcm_do_remap(integratorcm_state *s) >

Re: [Qemu-devel] [PATCH] PPC: Fix linker scripts on ppc hosts

2011-12-20 Thread Alexander Graf
On 20.12.2011, at 17:33, Peter Maydell wrote: > On 20 December 2011 16:29, Alexander Graf wrote: >> On 20.12.2011, at 17:17, Peter Maydell wrote: >>> On 14 December 2011 01:43, Alexander Graf wrote: +unsigned long reserved_va = 0xf700; >>> >>> So why 0xf700 rather than the whole o

Re: [Qemu-devel] [PATCH V2 1/5] vl.c: Do not save RAM state when Xen is used.

2011-12-20 Thread Anthony PERARD
On Sun, 18 Dec 2011, Avi Kivity wrote: > On 12/15/2011 05:12 PM, Anthony Liguori wrote: > > On 12/09/2011 03:54 PM, Anthony PERARD wrote: > >> In Xen case, the guest RAM is not handle by QEMU, and it is saved by > >> Xen tools. > >> So, we just avoid to register the RAM save state handler. > >> >

Re: [Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Stefan Hajnoczi
On Tue, Dec 20, 2011 at 3:25 PM, Michael Niehren <902...@bugs.launchpad.net> wrote: > here we are. Attached the tgz. I am using no spezial distribution, it's a > self compiled LFS with > gcc V4.5.1 > > Is there a different compiler-call if i use --enable-debug, which then > works ? Richard Sandif

[Qemu-devel] [PATCH 00/27] qom: add QEMU Object Model type hierarchy to qdev

2011-12-20 Thread Anthony Liguori
This is series 2/4 of the QOM refactoring. These series are divided up based on the major scripted code conversions. This series makes qdev a proper Object and converts qdev's type inheritance to QOM inheritance. The first half of the series are manual cleanups/refactorings. The second half is

[Qemu-devel] [PATCH 05/27] qdev: use a wrapper to access reset and promote reset to a class method

2011-12-20 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/intel-hda.c |4 +--- hw/lsi53c895a.c |2 +- hw/qdev.c | 22 +- hw/qdev.h | 10 +- 4 files changed, 28 insertions(+), 10 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 1b42e10..09459b8 1006

[Qemu-devel] [PATCH 06/27] pci: check for an initialized QOM object instead of looking for an info link

2011-12-20 Thread Anthony Liguori
We want to eliminate DeviceInfo so update the PCI check to look for a valid class pointer. Signed-off-by: Anthony Liguori --- hw/pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 4fc46c2..3ea6223 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1

Re: [Qemu-devel] [PATCH 00/27] qom: add QEMU Object Model type hierarchy to qdev

2011-12-20 Thread Anthony Liguori
On 12/20/2011 10:51 AM, Anthony Liguori wrote: This is series 2/4 of the QOM refactoring. These series are divided up based on the major scripted code conversions. Dang, this should have been an RFC, apologies. This series makes qdev a proper Object and converts qdev's type inheritance to Q

[Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)

2011-12-20 Thread Stefan Hajnoczi
** Bug watch added: GCC Bugzilla #45967 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45967 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/902148 Title: qemu-img V1.0 hangs on creating Image (0.15.

[Qemu-devel] [PATCH 01/27] qom: add the base Object class

2011-12-20 Thread Anthony Liguori
This class provides the main building block for QEMU Object Model and is extensively documented in the header file. It is largely inspired by GObject. Signed-off-by: Anthony Liguori --- Makefile.objs |2 + hw/object.c | 469 + hw/ob

Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse

2011-12-20 Thread Jan Kiszka
On 2011-12-20 15:07, Anthony Liguori wrote: > On 12/20/2011 07:57 AM, Paolo Bonzini wrote: >> On 12/20/2011 02:54 PM, Anthony Liguori wrote: In QOM parlance Jan implemented this: abstract class Object abstract class Device class APIC: { backend: link } abstract class A

[Qemu-devel] [PATCH] Strip trailing '\n' from error_report()'s first argument (again)

2011-12-20 Thread Markus Armbruster
Commit 6daf194d got rid of them, but Hans and Gerd added some more lately. Tracked down with this Coccinelle semantic patch: @r@ expression fmt; position p; @@ error_report(fmt, ...)@p @script:python@ fmt << r.fmt; p << r.p; @@ if "\\n" in str(fmt): print "%s:%s:%s:%s" % (

Re: [Qemu-devel] [PATCH v6 4/4] Add support for net bridge

2011-12-20 Thread Corey Bryant
On 12/19/2011 06:15 PM, Anthony Liguori wrote: On 12/19/2011 04:55 PM, Corey Bryant wrote: diff --git a/net.c b/net.c index f7bebf8..9296224 100644 --- a/net.c +++ b/net.c @@ -952,6 +952,14 @@ static const struct { .type = QEMU_OPT_STRING, .help = "script to shut down the interface", }, { +

[Qemu-devel] [PATCH 23/27] virtio-serial: convert to QEMU Object Model

2011-12-20 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/virtio-console.c| 67 +--- hw/virtio-serial-bus.c | 70 + hw/virtio-serial.h | 81 ++-- 3 files changed, 128 insertions(+), 9

  1   2   >