Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Jan Kiszka
On 2012-02-27 00:46, Anthony Liguori wrote: I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of discoverability but it's worse than I think most people

Re: [Qemu-devel] [PATCH 2/3] Allow larger return values from get_image_size()

2012-02-27 Thread Markus Armbruster
David Gibson da...@gibson.dropbear.id.au writes: Currently get_image_size(), used to find the size of files, returns an int. But for modern systems, int may be only 32-bit and we can have files larger than that. This patch, therefore, changes the return type of get_image_size() to off_t

Re: [Qemu-devel] [PATCH 7/8] gtk: add translation support

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 12:46 AM, Anthony Liguori wrote: The de_DE translation is just a placeholder so that I could test the infrastructure. Here is an it_IT translation that you can use instead. Paolo # Italian translation for QEMU. # This file is put in the public domain. # Paolo Bonzini

Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for qemu-tool compatibility

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 08:35 AM, Zhi Yong Wu wrote: Since vm_clock is created via qemu_init_main_loop(), when QED read vm_clock, why will this call abort()? Can you elaborate this? what is its call path? It will crash in cpu_get_clock() (in qemu-tool.c). Paolo

Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for qemu-tool compatibility

2012-02-27 Thread Zhi Yong Wu
On Mon, Feb 27, 2012 at 4:42 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/27/2012 08:35 AM, Zhi Yong Wu wrote: Since vm_clock is created via qemu_init_main_loop(), when QED read vm_clock, why will this call abort()? Can you elaborate this? what is its call path? It will crash in

Re: [Qemu-devel] [PATCH 2/3] Allow larger return values from get_image_size()

2012-02-27 Thread David Gibson
On Mon, Feb 27, 2012 at 09:21:25AM +0100, Markus Armbruster wrote: David Gibson da...@gibson.dropbear.id.au writes: Currently get_image_size(), used to find the size of files, returns an int. But for modern systems, int may be only 32-bit and we can have files larger than that. This

Re: [Qemu-devel] [PATCH]qemu: deal with guest paniced event

2012-02-27 Thread Jan Kiszka
On 2012-02-27 04:05, Wen Congyang wrote: When the host knows the guest is paniced, it will set exit_reason to KVM_EXIT_GUEST_PANIC. So if qemu receive this exit_reason, we can send a event to tell management application that the guest is paniced. Signed-off-by: Wen Congyang

[Qemu-devel] SPARC64: unable to boot OpenBIOS from git master

2012-02-27 Thread Mark Cave-Ayland
Hi all, I've been experimenting with SPARC64 under QEMU, and with current git master I am unable to boot OpenBIOS at all with the following error: OpenBIOS for Sparc64 Unhandled Exception 0x0032 PC = 0xffd19d84 NPC = 0xffd19d88 Stopping execution Using git bisect

Re: [Qemu-devel] [PATCH v6 0/7] qxl: fix hangs caused by qxl_render_update

2012-02-27 Thread Gerd Hoffmann
On 02/24/12 22:19, Alon Levy wrote: v5-v6: rebased dropped vga/console patches addressed checkpatch complaints Alon Levy (7): qxl: fix spice+sdl no cursor regression sdl: remove NULL check, g_malloc0 can't fail qxl: drop qxl_spice_update_area_async definition qxl: require

Re: [Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-27 Thread Federico Simoncelli
- Original Message - From: Luiz Capitulino lcapitul...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, mtosa...@redhat.com, pbonz...@redhat.com, kw...@redhat.com, arm...@redhat.com Sent: Friday, February 24, 2012 7:17:22 PM Subject: Re: [PATCH 1/2

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-27 Thread Hannes Reinecke
Hi Micheal, thanks for your review. You'll find the answers inline. On 02/23/2012 04:34 PM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. I've tested it to work with Linux, Windows

[Qemu-devel] Fail to share Samba directory with guest

2012-02-27 Thread Jun Koi
hi, on qemu 1.0.1, i am trying to share a host directory with the Windows guest like below: qemu-system-i386 -enable-kvm -m 1000 -net nic,model=rtl8139 -net user,smb=/tmp img.winxp but in the guest, \\10.0.2.4 doesnt show me any shared directory. i already run Samba on the host (default

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Stefan Hajnoczi
On Thu, Feb 23, 2012 at 4:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Feb 22, 2012 at 5:13 PM, Federico Simoncelli fsimo...@redhat.com wrote: From: Marcelo Tosatti mtosa...@redhat.com Mirrored writes are used by live block copy. I think the right approach is to create a single

Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for qemu-tool compatibility

2012-02-27 Thread Kevin Wolf
Am 27.02.2012 09:42, schrieb Paolo Bonzini: On 02/27/2012 08:35 AM, Zhi Yong Wu wrote: Since vm_clock is created via qemu_init_main_loop(), when QED read vm_clock, why will this call abort()? Can you elaborate this? what is its call path? It will crash in cpu_get_clock() (in qemu-tool.c).

Re: [Qemu-devel] [PATCH 2/3] Allow larger return values from get_image_size()

2012-02-27 Thread Markus Armbruster
David Gibson da...@gibson.dropbear.id.au writes: On Mon, Feb 27, 2012 at 09:21:25AM +0100, Markus Armbruster wrote: David Gibson da...@gibson.dropbear.id.au writes: Currently get_image_size(), used to find the size of files, returns an int. But for modern systems, int may be only 32-bit

[Qemu-devel] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)

2012-02-27 Thread Daniel P. Berrange
I'm seeing current QEMU GIT fail to boot MS-Dos 6.22 with the following crash: # qemu-system-x86_64 -fda ~/MS-DOS\ 6.22.img -m 1 -curses iPXE v1.0.0-591-g7aee315 iPXE (http://ipxe.org) 00:03.0 C900 PCI2.10 PnP PMM++ C900

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] build: replace librt check function

2012-02-27 Thread Ian Campbell
On Thu, 2012-02-23 at 13:34 +, Roger Pau Monné wrote: 2012/2/22 Anthony Liguori anth...@codemonkey.ws: On 02/20/2012 06:11 AM, Roger Pau Monne wrote: Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the clock_getttime function can be used without linking

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] build: replace librt check function

2012-02-27 Thread Roger Pau Monné
2012/2/27 Ian Campbell ian.campb...@citrix.com: On Thu, 2012-02-23 at 13:34 +, Roger Pau Monné wrote: 2012/2/22 Anthony Liguori anth...@codemonkey.ws: On 02/20/2012 06:11 AM, Roger Pau Monne wrote: Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the

[Qemu-devel] [PATCH] qxl: properly handle upright and non-shared surfaces

2012-02-27 Thread Gerd Hoffmann
Although qxl creates a shared displaysurface when the qxl surface is upright and doesn't need to be flipped there is no guarantee that the surface doesn't become unshared for some reason. Rename qxl_flip to qxl_blit and fix it to handle both flip and non-flip cases. Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-27 Thread Michael S. Tsirkin
On Mon, Feb 27, 2012 at 10:17:21AM +0100, Hannes Reinecke wrote: Hi Micheal, thanks for your review. You'll find the answers inline. On 02/23/2012 04:34 PM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote: This patch adds an emulation for the

Re: [Qemu-devel] [PATCH 4/8] Add universal DMA helper functions

2012-02-27 Thread Michael S. Tsirkin
On Mon, Feb 27, 2012 at 11:22:43AM +1100, David Gibson wrote: On Sun, Feb 26, 2012 at 12:04:49PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 24, 2012 at 02:27:39PM +1100, David Gibson wrote: Not that long ago, every device implementation using DMA directly accessed guest memory using

Re: [Qemu-devel] [PATCH 4/8] gtk: add virtual console support (v2)

2012-02-27 Thread Kevin Wolf
Am 27.02.2012 00:46, schrieb Anthony Liguori: This enables VteTerminal to be used to render the text consoles. VteTerminal is the same widget used by gnome-terminal which means it's VT100 emulation is as good as they come. It's also screen reader accessible, supports copy/paste, proper

[Qemu-devel] [PATCH] TCG: Convert global variables to be TLS.

2012-02-27 Thread Evgeny Voevodin
I suggest to send this patch to mailing list. Approve? This patch converts some TCG data to be TLS on the way to make TCG multithreaded. This work was made in assumption that qemu-tls.h defines a general direction to let each VCPU run in its own thread wile being processed by TCG. Evgeny

[Qemu-devel] [PATCH] TCG: Convert global variables to be TLS.

2012-02-27 Thread Evgeny Voevodin
This commit converts code_gen_buffer, code_gen_ptr, tbs, nb_tbs to TLS. We need this if we want TCG to become multithreaded. Initialization of code_gen_buffer and code_gen_ptr is moved to new tcg_gen_buffer_init() function. This is done because we do not need to allocate and initialize TCG

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-27 Thread Stefan Hajnoczi
On Sun, Feb 26, 2012 at 7:31 PM, Jeff Cody jc...@redhat.com wrote: Do you have automated tests for this feature? +/* + * Add new bs contents at the top of an image chain while the chain is live, + * while keeping required fields on the top layer. Please also document the swap behavior. It's

Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for qemu-tool compatibility

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 9:31 AM, Kevin Wolf kw...@redhat.com wrote: Am 27.02.2012 09:42, schrieb Paolo Bonzini: On 02/27/2012 08:35 AM, Zhi Yong Wu wrote: Since vm_clock is created via qemu_init_main_loop(), when QED read vm_clock, why will this call abort()? Can you elaborate this? what is

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-27 Thread Federico Simoncelli
- Original Message - From: Luiz Capitulino lcapitul...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, mtosa...@redhat.com, pbonz...@redhat.com, kw...@redhat.com, arm...@redhat.com Sent: Friday, February 24, 2012 8:01:43 PM Subject: Re: [PATCH 2/2

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 10:23 AM, Stefan Hajnoczi wrote: I think the right approach is to create a single blkmirror driver that also includes blkverify functionality. The code is basically the same except blkverify also compares reads - just use a flag to enable/disable that behavior. Feel free

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 11:37 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/27/2012 10:23 AM, Stefan Hajnoczi wrote: I think the right approach is to create a single blkmirror driver that also includes blkverify functionality.  The code is basically the same except blkverify also

Re: [Qemu-devel] [PATCH] TCG: Convert global variables to be TLS.

2012-02-27 Thread Evgeny Voevodin
On 27.02.2012 15:06, Evgeny Voevodin wrote: This patch converts some TCG data to be TLS on the way to make TCG multithreaded. This work was made in assumption that qemu-tls.h defines a general direction to let each VCPU run in its own thread wile being processed by TCG. Evgeny Voevodin (1):

Re: [Qemu-devel] [PATCH 5/6] usb-redir: Return USB_RET_NAK when we've no data for an interrupt endpoint

2012-02-27 Thread Gerd Hoffmann
On 02/26/12 16:14, Hans de Goede wrote: +if (status) +return usbredir_handle_status(dev, status, 0); Fails checkpatch.pl, braces needed here. cheers, Gerd

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 12:42 PM, Stefan Hajnoczi wrote: Once non-incremental mode is added, I suspect blkmirror will diverge from blkverify significantly. In particular, we would need to track where have writes been done in the destination. We also would need to hooks for block/stream.c, or

Re: [Qemu-devel] [PATCH 4/8] Add universal DMA helper functions

2012-02-27 Thread Eduard - Gabriel Munteanu
On Mon, Feb 27, 2012 at 12:33:49PM +0200, Michael S. Tsirkin wrote: On Mon, Feb 27, 2012 at 11:22:43AM +1100, David Gibson wrote: On Sun, Feb 26, 2012 at 12:04:49PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 24, 2012 at 02:27:39PM +1100, David Gibson wrote: [snip] I'm a bit

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-27 Thread Luiz Capitulino
On Mon, 27 Feb 2012 06:29:39 -0500 (EST) Federico Simoncelli fsimo...@redhat.com wrote: - Original Message - From: Luiz Capitulino lcapitul...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, mtosa...@redhat.com, pbonz...@redhat.com,

[Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS.

2012-02-27 Thread Evgeny Voevodin
This commit converts code_gen_buffer, code_gen_ptr, tbs, nb_tbs to TLS. We need this if we want TCG to become multithreaded. Initialization of code_gen_buffer and code_gen_ptr is moved to new tcg_gen_buffer_init() function. This is done because we do not need to allocate and initialize TCG

Re: [Qemu-devel] [PATCH 5/6] usb-redir: Return USB_RET_NAK when we've no data for an interrupt endpoint

2012-02-27 Thread Gerd Hoffmann
On 02/27/12 12:45, Gerd Hoffmann wrote: On 02/26/12 16:14, Hans de Goede wrote: +if (status) +return usbredir_handle_status(dev, status, 0); Fails checkpatch.pl, braces needed here. Fixed applied (all patches). cheers, Gerd

[Qemu-devel] [PATCH 1/3] build: replace librt check function

2012-02-27 Thread Roger Pau Monne
Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the clock_getttime function can be used without linking against librt (although the manual page states the opposite). Signed-off-by: Roger Pau Monne roger@entel.upc.edu --- configure |3 ++- 1 files changed, 2

[Qemu-devel] [PATCH 3/3] build: check if libm is needed in configure

2012-02-27 Thread Roger Pau Monne
Remove the hardcoded use of libm and instead rely on configure to check for it. It is needed at least for qemu-ga and qemu-system. Signed-off-by: Roger Pau Monne roger@entel.upc.edu --- Makefile.target |4 configure | 14 ++ 2 files changed, 14 insertions(+), 4

[Qemu-devel] [PATCH 2/3] build: add librt to libs_qga

2012-02-27 Thread Roger Pau Monne
librt is needed to link qemu-ga. Signed-off-by: Roger Pau Monne roger@entel.upc.edu --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 68eb3fa..790d495 100755 --- a/configure +++ b/configure @@ -2521,6 +2521,7 @@ if compile_prog

Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS.

2012-02-27 Thread Peter Maydell
On 27 February 2012 12:13, Evgeny Voevodin e.voevo...@samsung.com wrote: This commit converts code_gen_buffer, code_gen_ptr, tbs, nb_tbs to TLS. We need this if we want TCG to become multithreaded. I'm sceptical about doing this kind of thing as a change on its own. A true multithreaded TCG is

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] build: replace librt check function

2012-02-27 Thread Stefano Stabellini
On Mon, 27 Feb 2012, Ian Campbell wrote: On Thu, 2012-02-23 at 13:34 +, Roger Pau Monné wrote: 2012/2/22 Anthony Liguori anth...@codemonkey.ws: On 02/20/2012 06:11 AM, Roger Pau Monne wrote: Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-27 Thread Gerd Hoffmann
qemu-system-x86_64: /home/erik/qemu/hw/usb.c:358 usb_packet_complete: Assertion 'p-state == USB_PACKET_QUEUED' failed. Stacktrace? What kind of device? Hi Gerd, attached the usb logger dump as requested. Stacktrace - I tried that without real success using the gdbserver - I had issues

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 01:12 PM, Luiz Capitulino wrote: If I didn't make any mistake in the code I'm just enforcing that when you specify incremental you also need a new image. There are still other valid cases where they are optional. Which operation will be performed if 'incremental' is not

Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-27 Thread Luiz Capitulino
On Mon, 27 Feb 2012 13:49:17 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 02/27/2012 01:12 PM, Luiz Capitulino wrote: If I didn't make any mistake in the code I'm just enforcing that when you specify incremental you also need a new image. There are still other valid cases where

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 11:48 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/27/2012 12:42 PM, Stefan Hajnoczi wrote: Once non-incremental mode is added, I suspect blkmirror will diverge from blkverify significantly.  In particular, we would need to track where have writes been done

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 02:21 AM, Jan Kiszka wrote: On 2012-02-27 00:46, Anthony Liguori wrote: I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of

Re: [Qemu-devel] [PATCH 7/8] gtk: add translation support

2012-02-27 Thread Anthony Liguori
On 02/27/2012 02:32 AM, Paolo Bonzini wrote: On 02/27/2012 12:46 AM, Anthony Liguori wrote: The de_DE translation is just a placeholder so that I could test the infrastructure. Here is an it_IT translation that you can use instead. Grazie! Regards, Anthony Liguori Paolo

[Qemu-devel] [PATCH] qed: do not evict in-use L2 table cache entries

2012-02-27 Thread Stefan Hajnoczi
The L2 table cache reduces QED metadata reads that would be required when translating LBAs to offsets into the image file. Since requests execute in parallel it is possible to share an L2 table between multiple requests. There is a potential data corruption issue when an in-use L2 table is

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Jan Kiszka
On 2012-02-27 14:10, Anthony Liguori wrote: On 02/27/2012 02:21 AM, Jan Kiszka wrote: On 2012-02-27 00:46, Anthony Liguori wrote: I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with

[Qemu-devel] KVM call agenda for Tuesday 28th

2012-02-27 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Cheers, Juan.

Re: [Qemu-devel] [PATCH 8/8] Make dma_addr_t 64 bit always

2012-02-27 Thread David Gibson
On Sun, Feb 26, 2012 at 09:46:52PM +, Blue Swirl wrote: On Fri, Feb 24, 2012 at 04:57, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, Feb 24, 2012 at 02:27:43PM +1100, David Gibson wrote: Oops, ignore this one folks.  As is probably obvious, this was a testing patch not

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 07:26 AM, Jan Kiszka wrote: On 2012-02-27 14:10, Anthony Liguori wrote: On 02/27/2012 02:21 AM, Jan Kiszka wrote: On 2012-02-27 00:46, Anthony Liguori wrote: I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Jan Kiszka
On 2012-02-27 14:33, Anthony Liguori wrote: That all keyboard inputs are grabbed when the mouse is in the window and you don't need to press ctrl-alt-g explicitly. And the reverse should happen when the mouse reaches the window border. Just like under SDL, give it a try. Right, this was

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote: Non-incremental mode is pre-copy migration. It would stream in the background from the source to the destination. In this case: - you need to differentiate streaming writes from other writes. When streaming, you do not want to issue

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-27 Thread Andreas Färber
Am 23.02.2012 16:34, schrieb Michael S. Tsirkin: On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote: diff --git a/hw/megasas.c b/hw/megasas.c new file mode 100644 index 000..083c3d3 --- /dev/null +++ b/hw/megasas.c +static void megaraid1078_register_types(void) +{ +

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 07:42 AM, Jan Kiszka wrote: On 2012-02-27 14:33, Anthony Liguori wrote: That all keyboard inputs are grabbed when the mouse is in the window and you don't need to press ctrl-alt-g explicitly. And the reverse should happen when the mouse reaches the window border. Just like under

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Jan Kiszka
On 2012-02-27 14:50, Anthony Liguori wrote: On 02/27/2012 07:42 AM, Jan Kiszka wrote: On 2012-02-27 14:33, Anthony Liguori wrote: That all keyboard inputs are grabbed when the mouse is in the window and you don't need to press ctrl-alt-g explicitly. And the reverse should happen when the

Re: [Qemu-devel] [PATCH] usb: Resolve warnings about unassigned bus on usb device creation

2012-02-27 Thread Jan Kiszka
On 2012-02-02 18:59, Jan Kiszka wrote: When creating an USB device the old way, there is no way to specify the target bus. Thus the warning issued by usb_create makes no sense and rather confuses our users. Resolve this by passing a bus reference to the usbdevice_init handler and letting

Re: [Qemu-devel] [PATCH 2/6] slirp: Fix assertion failure on rejected DHCP requests

2012-02-27 Thread Jan Kiszka
On 2012-02-24 01:23, David Gibson wrote: The guest network stack might DHCPREQUEST an address that the slirp built in dhcp server can't let it have - for example if the guest has an old leases file from another network configuration. In this case the dhcp server should and does reject the

Re: [Qemu-devel] [PATCH] usb: Resolve warnings about unassigned bus on usb device creation

2012-02-27 Thread Gerd Hoffmann
On 02/27/12 14:57, Jan Kiszka wrote: On 2012-02-02 18:59, Jan Kiszka wrote: When creating an USB device the old way, there is no way to specify the target bus. Thus the warning issued by usb_create makes no sense and rather confuses our users. Resolve this by passing a bus reference to the

Re: [Qemu-devel] [PATCH 3/6] USB OHCI bug fixes

2012-02-27 Thread Gerd Hoffmann
On 02/24/12 01:23, David Gibson wrote: From: Wei Yang weiy...@linux.vnet.ibm.com This patch fixes two bugs in the OHCI device where the device writes back data to system memory that should be exclusively under the control of the guest side driver. Looks good. Fails checkpatch though. What

[Qemu-devel] [PATCH v2] usb: Resolve warnings about unassigned bus on usb device creation

2012-02-27 Thread Jan Kiszka
When creating an USB device the old way, there is no way to specify the target bus. Thus the warning issued by usb_create makes no sense and rather confuses our users. Resolve this by passing a bus reference to the usbdevice_init handler and letting those handlers forward it to usb_create.

Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for qemu-tool compatibility

2012-02-27 Thread Zhi Yong Wu
On Sun, Feb 26, 2012 at 10:55 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The QED dirty bit timer marks the file clean after allocating writes have drained.  This is cheaper than clearing/setting the dirty bit on each allocating write because the timer introduces a grace period which

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Kevin Wolf
Am 27.02.2012 00:46, schrieb Anthony Liguori: I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of discoverability but it's worse than I think most

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-27 Thread Jeff Cody
On 02/27/2012 06:13 AM, Stefan Hajnoczi wrote: On Sun, Feb 26, 2012 at 7:31 PM, Jeff Cody jc...@redhat.com wrote: Do you have automated tests for this feature? No, not yet. The testing has been manual. +/* + * Add new bs contents at the top of an image chain while the chain is live, +

Re: [Qemu-devel] [PATCHv3 0/4] standard pci bridge device

2012-02-27 Thread Gerd Hoffmann
On 02/20/12 23:52, Michael S. Tsirkin wrote: Here's a new version of the patch. TODOs: - windows guest testing Changes from v2: - added slot id capability - migration support - misc fixes - fix checkpatch errors 64bit prefetch memory window works now: 00:10.0 PCI bridge: Red Hat,

[Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 02:06 PM, Luiz Capitulino wrote: IMHO, this is asking for two commands, where cases 1 2 is one of them and cases 3 4 is the other one. Note how 'incremental' goes away and 'new_image_file' really becomes an optional. I really would have no idea on naming except perhaps

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 08:24 AM, Kevin Wolf wrote: Am 27.02.2012 00:46, schrieb Anthony Liguori: I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 2:26 PM, Jeff Cody jc...@redhat.com wrote: On 02/27/2012 06:13 AM, Stefan Hajnoczi wrote: On Sun, Feb 26, 2012 at 7:31 PM, Jeff Cody jc...@redhat.com wrote: Do you have automated tests for this feature? No, not yet.  The testing has been manual. For image streaming

Re: [Qemu-devel] [PATCH v2] usb: Resolve warnings about unassigned bus on usb device creation

2012-02-27 Thread Gerd Hoffmann
On 02/27/12 15:18, Jan Kiszka wrote: When creating an USB device the old way, there is no way to specify the target bus. Thus the warning issued by usb_create makes no sense and rather confuses our users. Resolve this by passing a bus reference to the usbdevice_init handler and letting

Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for qemu-tool compatibility

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 2:20 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Sun, Feb 26, 2012 at 10:55 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The QED dirty bit timer marks the file clean after allocating writes have drained.  This is cheaper than clearing/setting the dirty bit

Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 08:39 AM, Paolo Bonzini wrote: On 02/27/2012 02:06 PM, Luiz Capitulino wrote: IMHO, this is asking for two commands, where cases 1 2 is one of them and cases 3 4 is the other one. Note how 'incremental' goes away and 'new_image_file' really becomes an optional. I really would

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 1:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote: Non-incremental mode is pre-copy migration.  It would stream in the background from the source to the destination.  In this case: - you need to differentiate streaming

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-27 Thread Erik Rull
On February 27, 2012 at 1:48 PM Gerd Hoffmann kra...@redhat.com wrote: qemu-system-x86_64: /home/erik/qemu/hw/usb.c:358 usb_packet_complete: Assertion 'p-state == USB_PACKET_QUEUED' failed. Stacktrace? What kind of device? Hi Gerd, attached the usb logger dump as requested.

Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 03:46 PM, Anthony Liguori wrote: I think a better way to think of this is as a batch submission. It would be relatively easy to model in QMP too (just have a batch-command that has a list of commands as it's argument). The difference between batch submission and a transaction

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-27 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 24.02.2012 12:37, schrieb Federico Simoncelli: [...] diff --git a/blockdev.c b/blockdev.c index 2c132a3..1df2542 100644 --- a/blockdev.c +++ b/blockdev.c [...] +void qmp_blockdev_migrate(const char *device, BlockMigrateOp mode, +

Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 08:54 AM, Paolo Bonzini wrote: On 02/27/2012 03:46 PM, Anthony Liguori wrote: I think a better way to think of this is as a batch submission. It would be relatively easy to model in QMP too (just have a batch-command that has a list of commands as it's argument). The difference

Re: [Qemu-devel] [PATCH 0/8] Add GTK UI to enable basic accessibility (v2)

2012-02-27 Thread Kevin Wolf
Am 27.02.2012 15:39, schrieb Anthony Liguori: On 02/27/2012 08:24 AM, Kevin Wolf wrote: Am 27.02.2012 00:46, schrieb Anthony Liguori: I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 2:49 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Feb 27, 2012 at 1:47 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote: 3) blkverify in the future could add callbacks to create snapshots or load/save imgstate, and

Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 03:59 PM, Anthony Liguori wrote: The problem is that the current commands are not designed well. For instance, multi-snapshot could look like: block-freeze ide0-hd0 block-freeze ide1-hd1 block-reopen ide0-hd0 my-new-file0.qcow2 block-reopen ide1-hd1 my-new-file1.qcow2

Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 09:03 AM, Paolo Bonzini wrote: On 02/27/2012 03:59 PM, Anthony Liguori wrote: The problem is that the current commands are not designed well. For instance, multi-snapshot could look like: block-freeze ide0-hd0 block-freeze ide1-hd1 block-reopen ide0-hd0 my-new-file0.qcow2

Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver

2012-02-27 Thread Paolo Bonzini
On 02/27/2012 03:59 PM, Stefan Hajnoczi wrote: I guess what I'm saying is, if we need to copy-paste in order to fork them in the future that's fine, but why maintain duplicates in the mean-time? Please make the codebase nice today. We can always extend it in the future, we're not forced

Re: [Qemu-devel] [PATCH] kvm: notify host when guest paniced

2012-02-27 Thread Jan Kiszka
On 2012-02-27 04:01, Wen Congyang wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. This patch implemnts this feature, and the implementation is the same as xen: register panic notifier, and call hypercall when the guest is paniced.

Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Kevin Wolf
Am 27.02.2012 15:59, schrieb Anthony Liguori: On 02/27/2012 08:54 AM, Paolo Bonzini wrote: On 02/27/2012 03:46 PM, Anthony Liguori wrote: I think a better way to think of this is as a batch submission. It would be relatively easy to model in QMP too (just have a batch-command that has a list

[Qemu-devel] ARM brk bug

2012-02-27 Thread Bernhard M. Wiedemann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I found that running a debian arm5 bash with qemu runs into varying problems with -R but works without. Also works fine on both armv5 and armv7hf hardware. This happened with both master and 1.0 builds: curl

Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for qemu-tool compatibility

2012-02-27 Thread Zhi Yong Wu
On Mon, Feb 27, 2012 at 10:41 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Feb 27, 2012 at 2:20 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Sun, Feb 26, 2012 at 10:55 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The QED dirty bit timer marks the file clean after

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-27 Thread Jeff Cody
On 02/27/2012 09:40 AM, Stefan Hajnoczi wrote: On Mon, Feb 27, 2012 at 2:26 PM, Jeff Cody jc...@redhat.com wrote: On 02/27/2012 06:13 AM, Stefan Hajnoczi wrote: On Sun, Feb 26, 2012 at 7:31 PM, Jeff Cody jc...@redhat.com wrote: Do you have automated tests for this feature? No, not yet.

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-27 Thread Hannes Reinecke
On 02/27/2012 11:31 AM, Michael S. Tsirkin wrote: On Mon, Feb 27, 2012 at 10:17:21AM +0100, Hannes Reinecke wrote: [ .. ] The problem with mfi.h is that it's not actually _my_ file, but rather copied over from NetBSD. I felt a bit stupid doing a recoding of all the values which are already

Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

2012-02-27 Thread Anthony Liguori
On 02/27/2012 09:17 AM, Kevin Wolf wrote: Am 27.02.2012 15:59, schrieb Anthony Liguori: On 02/27/2012 08:54 AM, Paolo Bonzini wrote: On 02/27/2012 03:46 PM, Anthony Liguori wrote: I think a better way to think of this is as a batch submission. It would be relatively easy to model in QMP too

Re: [Qemu-devel] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)

2012-02-27 Thread Jan Kiszka
On 2012-02-27 10:51, Daniel P. Berrange wrote: I'm seeing current QEMU GIT fail to boot MS-Dos 6.22 with the following crash: # qemu-system-x86_64 -fda ~/MS-DOS\ 6.22.img -m 1 -curses iPXE v1.0.0-591-g7aee315 iPXE (http://ipxe.org) 00:03.0 C900 PCI2.10

[Qemu-devel] [PULL] slirp: Fix for requeuing crash assert on DHCPNAK, cleanups

2012-02-27 Thread Jan Kiszka
The following changes since commit b4bd0b168e9f4898b98308f4a8a089f647a86d16: audio: Add some fall through comments (2012-02-25 18:16:11 +0400) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp David Gibson (1): slirp: Fix assertion failure on rejected

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-27 Thread Stefan Hajnoczi
On Mon, Feb 27, 2012 at 3:23 PM, Jeff Cody jc...@redhat.com wrote: On 02/27/2012 09:40 AM, Stefan Hajnoczi wrote: On Mon, Feb 27, 2012 at 2:26 PM, Jeff Cody jc...@redhat.com wrote: On 02/27/2012 06:13 AM, Stefan Hajnoczi wrote: On Sun, Feb 26, 2012 at 7:31 PM, Jeff Cody jc...@redhat.com wrote:

[Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-27 Thread Eric Lassauge
More or less same crash for me: Using built-in specs. COLLECT_GCC=d:\MinGW\bin\gcc.exe COLLECT_LTO_WRAPPER=d:/mingw/bin/../libexec/gcc/mingw32/4.6.2/lto-wrapper.exe Target: mingw32 Configured with: ../gcc-4.6.2/configure --enable-languages=c,c++,ada,fortran,objc,obj-c++ --disable-sjlj-exceptions

Re: [Qemu-devel] ARM brk bug

2012-02-27 Thread Peter Maydell
On 27 February 2012 15:16, Bernhard M. Wiedemann bwiedem...@suse.de wrote: I found that running a debian arm5 bash with qemu runs into varying problems with -R but works without. Also works fine on both armv5 and armv7hf hardware. This happened with both master and 1.0 builds: curl

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command

2012-02-27 Thread Kevin Wolf
Am 26.02.2012 20:31, schrieb Jeff Cody: This is a QAPI/QMP only command to take a snapshot of a group of devices. This is similar to the blockdev-snapshot-sync command, except blockdev-group-snapshot-sync accepts a list devices, filenames, and formats. It is attempted to keep the snapshot

Re: [Qemu-devel] [PATCH v6 2/4] cadence_ttc: initial version of device model

2012-02-27 Thread Paul Brook
On Tue, Feb 21, 2012 at 11:04 PM, Paul Brook p...@codesourcery.com wrote: +static inline int64_t is_between(int64_t x, int64_t a, int64_t b) +{ +if (a b) { +return x a x = b; +} +return x a x = b; +} This looks slightly odd -- should the boundary

Re: [Qemu-devel] qemu assertion failed with usb on current git master!

2012-02-27 Thread Gerd Hoffmann
Hi, I'm really sorry, but I don't understand what's happening - I copied the qemu executable on my target system before executing it, but gdb complains that the core file does not match the executable! But except the file paths they are identical. warning: core file may not match

Re: [Qemu-devel] [SeaBIOS] Boot failure with MS-Dos 6.22 (due to bad BIOS build?)

2012-02-27 Thread Peter Stuge
Jan Kiszka wrote: Then I noticed, that if I rebuild the BIOS, from the exact same revision 1.6.3.1 revision that is committed in 'seabios' submodule in QEMU, then it works fine. So AFAICT, it is not the Seabios source code at fault, but rather the binary build we have commited to GIT.

Re: [Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-02-27 Thread Paolo Bonzini
On 02/17/2012 01:53 AM, Roy Tam wrote: Please try these modified configure option which adds the compiler flag needed for multithreading: --extra-cflags=-O0 -pipe -mthreads. For me, -mthreads solved the problem. Yes -mthreads switch does workaround the issue. But using -mthreads making

Re: [Qemu-devel] Fail to share Samba directory with guest

2012-02-27 Thread Shu Ming
On 2012-2-27 17:21, Jun Koi wrote: hi, on qemu 1.0.1, i am trying to share a host directory with the Windows guest like below: qemu-system-i386 -enable-kvm -m 1000 -net nic,model=rtl8139 -net user,smb=/tmp img.winxp but in the guest, \\10.0.2.4 doesnt show me any shared directory. i already

  1   2   >