Re: [Qemu-devel] [PATCH] virtio-spec: clarify ro/rw bits and updating rule of virtio-net status field

2012-03-20 Thread Michael S. Tsirkin
On Wed, Mar 21, 2012 at 10:10:52AM +1030, Rusty Russell wrote: > On Wed, 21 Mar 2012 00:48:05 +0200, "Michael S. Tsirkin" > wrote: > > On Tue, Mar 20, 2012 at 09:35:18PM +1030, Rusty Russell wrote: > > > On Tue, 20 Mar 2012 14:20:21 +0800, Jason Wang > > > wrote: > > > > This patch clarifies VI

Re: [Qemu-devel] [PATCH 1/6] slirp: use socket_set_nonblock

2012-03-20 Thread Paolo Bonzini
Il 21/03/2012 00:14, Stefan Weil ha scritto: > Am 20.03.2012 10:49, schrieb Paolo Bonzini: >> Cc: Jan Kiszka >> Signed-off-by: Paolo Bonzini >> --- >> slirp/misc.c | 46 +- >> slirp/tcp_subr.c |4 ++-- >> 2 files changed, 3 insertions(+), 47

Re: [Qemu-devel] [PATCH v2 2/2] Change timedrift default value to slew

2012-03-20 Thread Paolo Bonzini
Il 20/03/2012 21:59, Crístian Viana ha scritto: > Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as > the time source. If time drift is not enabled, Windows is prone to > blue screening. > > Signed-off-by: Crístian Viana > --- > hw/mc146818rtc.c |2 +- > vl.c

Re: [Qemu-devel] [PATCH v4 1/7] RTC: Remove the logic to update time format when DM bit changed

2012-03-20 Thread Zhang, Yang Z
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Tuesday, March 20, 2012 10:05 PM > To: Zhang, Yang Z > Cc: qemu-devel@nongnu.org; Paolo Bonzini; aligu...@us.ibm.com; > k...@vger.kernel.org > Subject: Re: [Qemu-devel] [PATCH v4 1/7] RTC: Remo

Re: [Qemu-devel] [PATCH] Fix typo in i400FX chipset init code

2012-03-20 Thread Alexey Korolev
> Hi, > > There is a typo in i440FX init code. This is causing problems when > somebody wants to access 64bit PCI range. > > > Signed-off-by: Alexey Korolev > --- > > hw/piix_pci.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c >

[Qemu-devel] [PATCH v2] hw/vexpress.c: Add NOR flash model

2012-03-20 Thread Liming Wang
Vexpress motherboard has two 2x16 NOR flash, but pflash_cfi01 doesn't support interleaving, so here only models two 1x32 flash. Although it's not exactly modeled, it works fine for running linux. Signed-off-by: Liming Wang --- v2: - swap NORFLASH0 and NORFLASH0ALIAS and reserve NORFLASH0ALIAS i

Re: [Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: change print method to avoid complaint

2012-03-20 Thread walimis
On Wed, Mar 21, 2012 at 12:43:49AM +0100, Stefan Weil wrote: >Am 20.03.2012 15:48, schrieb Liming Wang: >>Linux guest os often writes invalid cmd data to reset into read mode, >>which leads many qemu complaint. Here we place all the debug >>message into macro PFLASH_DEBUG. We can turn on the all de

[Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux

2012-03-20 Thread Michael Roth
This currently breaks the build for BSDs. Signed-off-by: Michael Roth --- qga/commands-posix.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 89dde92..16737d7 100644 --- a/qga/commands-posix.c +++ b

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-20 Thread Wen Congyang
At 03/20/2012 11:45 PM, Gleb Natapov Wrote: > On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: >> At 03/19/2012 03:33 PM, Wen Congyang Wrote: >>> At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such f

Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michael Roth
On Tue, Mar 20, 2012 at 01:19:25PM -0500, Michael Roth wrote: > On Tue, Mar 20, 2012 at 05:16:41PM +0100, Michal Privoznik wrote: > > On 20.03.2012 17:10, Michael Roth wrote: > > > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: > > >> Currently, the implementation of that command

[Qemu-devel] [Bug 935945] Re: SLIRP still not working for win32

2012-03-20 Thread Stefan Weil
Please try latest QEMU from git://git.qemu.org/qemu.git. Some slirp related fixes were added recently. I don't see any negative effects caused by -mms-bitfields in my tests. ** Changed in: qemu Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz) -- You received this bug notification be

[Qemu-devel] [PATCH v2 2/2] qapi: add struct-errors test case to test-qmp-output-visitor

2012-03-20 Thread Laszlo Ersek
From: Paolo Bonzini This test case verifies that invalid native enums are caught, and causes qapi to tear down the QObject tree under construction, exercising the previous patch. Signed-off-by: Paolo Bonzini Signed-off-by: Laszlo Ersek --- qapi-schema-test.json |2 +- test-qmp-output-

Re: [Qemu-devel] [PATCH 0/4] MIPS ASE DSP Support for Qemu

2012-03-20 Thread Jia Liu
ping. Please review and commit. Regards, Jia. On Mon, Mar 12, 2012 at 4:32 PM, Jia Liu wrote: > Hi all > > This is the MIPS ASE DSP Support for Qemu. > > > Jia Liu (4): >  add MIPS DSP helpers define >  add MIPS DSP helpers implement >  add MIPS DSP translation >  add MIPS DSP testcase > >  tar

[Qemu-devel] [Bug 538808] Re: qemu-system-x86_64 0.12.2 crashes with -m 967 under Windows

2012-03-20 Thread Stefan Weil
** Changed in: qemu Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/538808 Title: qemu-system-x86_64 0.12.2 crashes with -m 967 under Wind

[Qemu-devel] [PATCH v2 1/2] qapi: fix double free in qmp_output_visitor_cleanup()

2012-03-20 Thread Laszlo Ersek
Stack entries in QmpOutputVisitor are navigation links (weak references), except the bottom (ie. least recently added) entry, which owns the root QObject [1]. Make qmp_output_visitor_cleanup() drop the stack entries, then release the QObject tree by the root. Attempting to serialize an invalid enu

[Qemu-devel] [PATCH v2 0/2] qapi: fix double free in QMP OV cleanup, add test case

2012-03-20 Thread Laszlo Ersek
v1->v2: added Paolo's test case as second patch in the series. Also tried to come up with a better subject for 1/2. Laszlo Ersek (1): qapi: fix double free in qmp_output_visitor_cleanup() Paolo Bonzini (1): qapi: add struct-errors test case to test-qmp-output-visitor qapi-schema-test.json

[Qemu-devel] qemu prompt comes up instead of all the kernel stuff

2012-03-20 Thread Krishna Pavan
Hi, I have tried a kernel to be loaded. I get QEMU prompt and not any kernel text. Please tell me why it is happening so. Here's the screenshot. [image: Inline image 1] Please Suggest! <>

[Qemu-devel] [PATCH 1/2] hw/pflash_cfi01: add "0xf0" to select and deselect read mode

2012-03-20 Thread Liming Wang
In CFI Specification, "0xff" and "0xf0" are both the data to select and deselect read mode, so add "0xf0" here. Linux guest os often uses "0xf0" to select read mode, which leads qemu printing "pflash_write: Unimplemented flash cmd sequence (offset , wcycle 0x0 cmd 0x0 value 0xf0)". This pa

Re: [Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: change print method to avoid complaint

2012-03-20 Thread Stefan Weil
Am 20.03.2012 15:48, schrieb Liming Wang: Linux guest os often writes invalid cmd data to reset into read mode, which leads many qemu complaint. Here we place all the debug message into macro PFLASH_DEBUG. We can turn on the all debug info by define PFLASH_DEBUG if we want to debug pflash_cfi01.

Re: [Qemu-devel] [PATCH] virtio-spec: clarify ro/rw bits and updating rule of virtio-net status field

2012-03-20 Thread Rusty Russell
On Wed, 21 Mar 2012 00:48:05 +0200, "Michael S. Tsirkin" wrote: > On Tue, Mar 20, 2012 at 09:35:18PM +1030, Rusty Russell wrote: > > On Tue, 20 Mar 2012 14:20:21 +0800, Jason Wang wrote: > > > This patch clarifies VIRTIO_NET_S_LINK_UP as a read-only bit and > > > VIRTIO_NET_S_ANNOUNCE as a read-

Re: [Qemu-devel] [PATCH] hw/vexpress.c: Add NOR flash model

2012-03-20 Thread walimis
On Tue, Mar 20, 2012 at 04:13:43PM +, Peter Maydell wrote: >On 20 March 2012 16:00, walimis wrote: >> On Tue, Mar 20, 2012 at 03:13:33PM +, Peter Maydell wrote: >>>On 20 March 2012 14:57, Liming Wang wrote: Vexpress motherboard has two 2x16 NOR flash, but pflash_cfi01 doesn't su

[Qemu-devel] [PATCH 2/2] hw/pflash_cfi01: change print method to avoid complaint

2012-03-20 Thread Liming Wang
Linux guest os often writes invalid cmd data to reset into read mode, which leads many qemu complaint. Here we place all the debug message into macro PFLASH_DEBUG. We can turn on the all debug info by define PFLASH_DEBUG if we want to debug pflash_cfi01. Signed-off-by: Liming Wang --- hw/pflash_

Re: [Qemu-devel] [PATCH 0/6] fix w32 sockets

2012-03-20 Thread Stefan Weil
Am 20.03.2012 10:49, schrieb Paolo Bonzini: The w32 main loop has been mostly broken by the introduction of the glib main loop. glib's g_poll does not use sockets on w32, so we need a separate approach. Patch 1 is a simple cleanup that is needed later in the series. Patch 2 and patch 3 complete

[Qemu-devel] [Bug 938431] Re: Reproducible crash in slirp_remque (qemu 1.0.1)

2012-03-20 Thread Stefan Weil
The latest slirp commits in QEMU git master (commits 953e7f54e679cd40fff28e29189ed9e24bfb0758, e3078bf40a33b59fa11d077b1d0bb8796470982e, f37343197708d90f119007ce5ecc2503be9c04c1, a68adc220603baffc355ecea8865b3ea9707ab00) fixed this issue. ** Changed in: qemu Status: New => Fix Released --

[Qemu-devel] [PATCH] hw/vexpress.c: Add NOR flash model

2012-03-20 Thread Liming Wang
Vexpress motherboard has two 2x16 NOR flash, but pflash_cfi01 doesn't support interleaving, so here only models two 1x32 flash. Although it's not exactly modeled, it works fine for running linux. Signed-off-by: Liming Wang --- hw/vexpress.c | 19 +-- 1 files changed, 17 inserti

Re: [Qemu-devel] [PATCH] hw/vexpress.c: Add NOR flash model

2012-03-20 Thread walimis
On Tue, Mar 20, 2012 at 03:13:33PM +, Peter Maydell wrote: >On 20 March 2012 14:57, Liming Wang wrote: >> Vexpress motherboard has two 2x16 NOR flash, but pflash_cfi01 >> doesn't support interleaving, so here only models two 1x32 flash. >> Although it's not exactly modeled, it works fine for r

[Qemu-devel] [Bug 960515] [NEW] CortexM, NVIC not reseted if qemu_system_reset_request() called

2012-03-20 Thread Oleksiy Bondarenko
Public bug reported: qemu 0.15.1 Interrupts does not work anymore if system reseted from interrupt. There is no reset function registered for armv7m_nvic, and as it is part of the core there is also no any reset for gic/nvic in cpu_reset() for arm. possible solution is to add reset function to

Re: [Qemu-devel] [PATCH 1/6] slirp: use socket_set_nonblock

2012-03-20 Thread Stefan Weil
Am 20.03.2012 10:49, schrieb Paolo Bonzini: Cc: Jan Kiszka Signed-off-by: Paolo Bonzini --- slirp/misc.c | 46 +- slirp/tcp_subr.c |4 ++-- 2 files changed, 3 insertions(+), 47 deletions(-) Hi Paolo, the compiler complains about the

Re: [Qemu-devel] [PATCH] virtio-spec: clarify ro/rw bits and updating rule of virtio-net status field

2012-03-20 Thread Michael S. Tsirkin
On Tue, Mar 20, 2012 at 09:35:18PM +1030, Rusty Russell wrote: > On Tue, 20 Mar 2012 14:20:21 +0800, Jason Wang wrote: > > This patch clarifies VIRTIO_NET_S_LINK_UP as a read-only bit and > > VIRTIO_NET_S_ANNOUNCE as a read-writable bit. Also introduce the write 1 to > > clear semantics for all re

[Qemu-devel] [PATCH v2 2/2] Change timedrift default value to slew

2012-03-20 Thread Crístian Viana
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as the time source. If time drift is not enabled, Windows is prone to blue screening. Signed-off-by: Crístian Viana --- hw/mc146818rtc.c |2 +- vl.c |2 +- 2 files changed, 2 insertions(+), 2 deletio

[Qemu-devel] [PATCH v2 1/2] Force timedrift=none on previous machines

2012-03-20 Thread Crístian Viana
The current value for the -rtc timedrift option is none. This patch makes sure that the old machines configuration will work the same way even after that option changes its default value. Signed-off-by: Crístian Viana --- hw/pc_piix.c | 39 +++ 1 files chang

Re: [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew

2012-03-20 Thread Crístian Viana
On 20-03-2012 17:31, Anthony Liguori wrote: > On 03/20/2012 03:16 PM, Crístian Viana wrote: >> On 20-03-2012 17:05, Anthony Liguori wrote: >>> I think we just want to change: >>> >>> hw/mc146818rtc.h: >>> DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, >>>

Re: [Qemu-devel] [PATCH] virtio-spec: clarify ro/rw bits and updating rule of virtio-net status field

2012-03-20 Thread Rusty Russell
On Tue, 20 Mar 2012 14:20:21 +0800, Jason Wang wrote: > This patch clarifies VIRTIO_NET_S_LINK_UP as a read-only bit and > VIRTIO_NET_S_ANNOUNCE as a read-writable bit. Also introduce the write 1 to > clear semantics for all read-writable bits of config status field. This could > help to reduce th

Re: [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew

2012-03-20 Thread Anthony Liguori
On 03/20/2012 03:16 PM, Crístian Viana wrote: On 20-03-2012 17:05, Anthony Liguori wrote: I think we just want to change: hw/mc146818rtc.h: DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, lost_tick_policy, LOST_TICK_DISCARD), I think we just need t

Re: [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew

2012-03-20 Thread Crístian Viana
On 20-03-2012 17:05, Anthony Liguori wrote: > I think we just want to change: > > hw/mc146818rtc.h: > DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState, >lost_tick_policy, LOST_TICK_DISCARD), > > I think we just need to change this to LOST_TICK_SLEW. Thi

[Qemu-devel] [PATCH 1/3] Makefile: use $(confdir) instead of hardcoding $(sysconfdir)/qemu

2012-03-20 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 1bc3cb0..9d583c4 100644 --- a/Makefile +++ b/Makefile @@ -279,8 +279,8 @@ ifdef CONFIG_VIRTFS $(INSTALL_DATA) fsdev/virtfs-proxy-helper.1 "$(DE

[Qemu-devel] [PATCH 0/3] add ./configure --confsuffix option (v2)

2012-03-20 Thread Eduardo Habkost
This is a new try to make the full configuration path configurable. As the approach using --confdir was rejected because the "package name" is something immutable, this adds a option where we can ask Qemu to use a directory name that is not equal to the package name. Eduardo Habkost (3): Makefi

[Qemu-devel] [PATCH 2/3] qemu-options.hx: refer to confdir instead of sysconfdir on docs

2012-03-20 Thread Eduardo Habkost
The current docs are wrong: ${sysconfdir} is (by default) /etc, ${confdir} is (by default) /etc/qemu, that's where the config files are stored. Signed-off-by: Eduardo Habkost --- qemu-options.hx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-op

[Qemu-devel] [PATCH 3/3] configure: add --confsuffix option

2012-03-20 Thread Eduardo Habkost
This way we can choose a configuration file path different from ${sysconfdir}/PACKAGE. This also changes the configure output to show the full configuration dir path (including $confsuffix), instead of just $sysconfdir. Signed-off-by: Eduardo Habkost --- configure |7 +-- 1 files change

Re: [Qemu-devel] [PATCH 2/2] Change timedrift default value to slew

2012-03-20 Thread Anthony Liguori
On 03/20/2012 02:48 PM, Crístian Viana wrote: Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as the time source. If time drift is not enabled, Windows is prone to blue screening. Signed-off-by: Crístian Viana --- vl.c | 13 - 1 files changed, 12 in

[Qemu-devel] [PATCH 1/2] Force timedrift=none on previous machines

2012-03-20 Thread Crístian Viana
The current value for the -rtc timedrift option is none. This patch makes sure that the old machines configuration will work the same way even after that option changes its default value. Signed-off-by: Crístian Viana --- hw/pc_piix.c | 39 +++ 1 files chang

[Qemu-devel] [PATCH 2/2] Change timedrift default value to slew

2012-03-20 Thread Crístian Viana
Windows 2008+ is very sensitive to missed ticks. The RTC is used by default as the time source. If time drift is not enabled, Windows is prone to blue screening. Signed-off-by: Crístian Viana --- vl.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/vl.c b/

Re: [Qemu-devel] [RFC PATCH 0/9] qemu capabilities reporting and config changes

2012-03-20 Thread Eduardo Habkost
On Mon, Mar 19, 2012 at 05:09:57PM +0100, Paolo Bonzini wrote: > Il 19/03/2012 16:09, Anthony Liguori ha scritto: [...] > > > > I would like to push this series into 1.1 > > I think it's too early. However, we can definitely apply 1/2/7/8/9 now. I like patch 3 a lot, too. It would open the door

Re: [Qemu-devel] [PATCH 8/9] vl: add -query-capabilities

2012-03-20 Thread Eduardo Habkost
On Mon, Mar 19, 2012 at 10:09:22AM -0500, Anthony Liguori wrote: > This dumps the results of query-version, query-commands, and > query-config-capabilities into a single JSON object on stdout. > > Signed-off-by: Anthony Liguori What about a mode where no machine and devices are initialized at al

Re: [Qemu-devel] [RFC/RFA PATCH] qapi: detect extra members inside structs

2012-03-20 Thread Anthony Liguori
On 03/20/2012 07:15 AM, Luiz Capitulino wrote: So let's work through a few examples. Today, you have to maintain a list of commands returned from query-commands and check for set membership: if 'query-netdev2' in commands: qmp.query_netdev2(foo) else: qmp.query_netdev() Pretty simpl

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Michael Roth
On Tue, Mar 20, 2012 at 04:32:31PM +, Peter Maydell wrote: > On 20 March 2012 16:31, Michael Roth wrote: > > Rather than key off an ID you could also just break > > implementation-specific functionality out into a set of interfaces you > > implement/override as part of the objects' initializat

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-20 Thread Eduardo Habkost
I added a summary of the changes I am planning, at: http://wiki.qemu.org/Features/CPUModels#Current_Issues_and_proposed_changes I'm sure I forgot lots of details, so feel free to send me questions and suggestions, or even edit the wiki page directly. On Fri, Mar 09, 2012 at 05:56:52PM -0300, Ed

Re: [Qemu-devel] [PATCH 10/12] trace: [tracetool] Automatically establish available backends and formats

2012-03-20 Thread Lluís Vilanova
Stefan Hajnoczi writes: > 2012/3/20 Lluís Vilanova : >> Stefan Hajnoczi writes: >> >>> 2012/3/13 Lluís Vilanova : Adds decorators to establish which backend and/or format each routine is meant to process. With this, tables enumerating format and backend routines can be

Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support

2012-03-20 Thread Stefano Stabellini
> +/* handle update-ended timer */ > +static void check_update_timer(RTCState *s) > +{ > +uint64_t next_update_time, expire_time; > +uint64_t guest_usec; > +qemu_del_timer(s->update_timer); > +qemu_del_timer(s->update_timer2); > + > +if (!((s->cmos_data[RTC_REG_C] & (REG_C_UF |

Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michael Roth
On Tue, Mar 20, 2012 at 05:16:41PM +0100, Michal Privoznik wrote: > On 20.03.2012 17:10, Michael Roth wrote: > > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: > >> Currently, the implementation of that command is full of > >> Linux specific code. Before any brave man will step i

[Qemu-devel] [PATCH] tcg: Use the GDB JIT debugging interface.

2012-03-20 Thread Richard Henderson
This allows us to generate unwind info for the dynamicly generated code in the code_gen_buffer. Only i386 is converted at this point. Signed-off-by: Richard Henderson --- elf.h |1 + exec.c|1 + tcg/i386/tcg-target.c | 114 +++-- tcg/tcg.

[Qemu-devel] [PATCH v3] Use the GDB JIT interface

2012-03-20 Thread Richard Henderson
Changes v2->v3: * Generate a .debug_info section. * Statically initialize most of the elf file. This fixes the ?? case Peter Maydell found with the softmmu binaries: #0 helper_set_cp15 (env=0x56439770, insn=3993440154, val=0) at /home/rth/work/qemu/qemu/target-arm/helper.c:1455 #1 0

Re: [Qemu-devel] [PATCH v4 5/7] RTC:Add RTC update-ended interrupt support

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > Use a timer to emulate update cycle. When update cycle ended and UIE is > setting, then raise an interrupt. The timer runs only when UF or AF is > cleared. The idea is that if the user requests the update-ended interrupt (UIE) we setup a timer to injec

Re: [Qemu-devel] [PATCH v4 4/7] RTC: Set internal millisecond register to 500ms when reset divider

2012-03-20 Thread Paolo Bonzini
Il 20/03/2012 18:39, Stefano Stabellini ha scritto: > This code is new: does it mean we were not handling divider reset > correctly before? > Also if we are trying to handle the DV registers, shouldn't we emulated > the other RTC frequencies as well? If so, we need a scale factor, in > addition to

Re: [Qemu-devel] [PATCH v4 4/7] RTC: Set internal millisecond register to 500ms when reset divider

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > The first update cycle begins one - half seconds later when divider reset is > removing. > > Signed-off-by: Yang Zhang > --- > hw/mc146818rtc.c | 38 +- > 1 files changed, 33 insertions(+), 5 deletions(-) > > dif

Re: [Qemu-devel] [RFC/RFA PATCH] qapi: detect extra members inside structs

2012-03-20 Thread Paolo Bonzini
Il 19/03/2012 20:56, Anthony Liguori ha scritto: > I'm not sure if the "server ignores unknown" fields thing is even > reasonable to rely upon so maybe we should just draw a line in the sane > and make the change you're suggesting... Yeah, especially since right now it's half-half (worst of both w

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Andreas Färber
Am 20.03.2012 18:14, schrieb Paul Brook: >> Make an ARMCPUClass that maps to the existing ARM support. Do *not* expose >> all of the different features as properties. Make ARMCPUClass abstract. >> >> Subclass ARMCPUClass for specific models, set default flags to implement >> the necessary logic.

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Peter Maydell
On 20 March 2012 17:14, Paul Brook wrote: >> >> Yes, I think I'd agree there. So should we just have an init function >> >> that provides the implementation-specific cp15 registers based on the >> >> value provided in the QOM property for the main ID register? >> > >> > Something like that, yes.  

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Paul Brook
> >> Yes, I think I'd agree there. So should we just have an init function > >> that provides the implementation-specific cp15 registers based on the > >> value provided in the QOM property for the main ID register? > > > > Something like that, yes. I'm not convinced the main ID register is the >

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Paul Brook
> Make an ARMCPUClass that maps to the existing ARM support. Do *not* expose > all of the different features as properties. Make ARMCPUClass abstract. > > Subclass ARMCPUClass for specific models, set default flags to implement > the necessary logic. Expose tunables on a case-by-case basis (if

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-20 Thread Lee Essen
On 20/03/2012 16:59, Stefan Hajnoczi wrote: On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen wrote: On 19 Mar 2012, at 12:32, Andreas Färber wrote: Am 19.03.2012 13:05, schrieb Lee Essen: In my original (way-too-long) patch for Illumos I included fixes for both of the above, the approach I took wa

[Qemu-devel] [PATCH v2] tracetool dtrace disabled-events fix

2012-03-20 Thread Lee Essen
If there are "disabled" entries in the trace-events file then linetod_nop() is called if the backend is dtrace, it's currently not present. Also equivalent fix for stap. Signed-off-by: Lee Essen -- diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..a279c2c 100755 --- a/scripts/tr

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Paul Brook
> Rather than key off an ID you could also just break > implementation-specific functionality out into a set of interfaces you > implement/override as part of the objects' initialization. Same ends, and > still fits the model pretty nicely, assuming the functionality is all > derivable from the com

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-20 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen wrote: > On 19 Mar 2012, at 12:32, Andreas Färber wrote: > >> Am 19.03.2012 13:05, schrieb Lee Essen: >>> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >>> I'm going to spend some time today reviewing recent tracing patches. I'd prefer to mov

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Anthony Liguori
On 03/20/2012 09:08 AM, Paul Brook wrote: Option two looks kind of nice, but I'm not sure whether it would actually work. I think you could do 95% of what you need for a different CPU that way (lots of properties for "value of ID_MMFR1", "value of "ID_MMFR2", "reset value of SCTLR", etc etc, plus

Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michal Privoznik
On 20.03.2012 17:10, Michael Roth wrote: > On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: >> Currently, the implementation of that command is full of >> Linux specific code. Before any brave man will step into >> and port it to other OSes, make this function Linux only. >> >> Sig

[Qemu-devel] [Bug 960378] [NEW] OSX 10.7 build failure

2012-03-20 Thread Hans Simer
Public bug reported: qemu-1.0.1 ./configure --cc=/usr/bin/gcc --disable-darwin-user --disable-bsd-user --disable-guest-agent CCbitops.o CCmigration-exec.o CCmigration-unix.o CCmigration-fd.o CCaudio/audio.o CCaudio/noaudio.o CCaudio/wavaudio.o CCa

Re: [Qemu-devel] [PATCH] tracetool dtrace disabled-events fix

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 1:37 PM, Lee Essen wrote: > If there are "disabled" entries in the trace-events file then > linetod_nop() is called if the backend is dtrace, it's currently > not present. > > Signed-off-by: Lee Essen > > -- > diff --git a/scripts/tracetool b/scripts/tracetool > index 65bd

Re: [Qemu-devel] [PATCH 10/12] trace: [tracetool] Automatically establish available backends and formats

2012-03-20 Thread Stefan Hajnoczi
2012/3/20 Lluís Vilanova : > Stefan Hajnoczi writes: > >> 2012/3/13 Lluís Vilanova : >>> Adds decorators to establish which backend and/or format each routine is >>> meant >>> to process. >>> >>> With this, tables enumerating format and backend routines can be eliminated >>> and >>> part of the u

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Peter Maydell
On 20 March 2012 16:31, Michael Roth wrote: > Rather than key off an ID you could also just break > implementation-specific functionality out into a set of interfaces you > implement/override as part of the objects' initialization. Same ends, and > still fits the model pretty nicely, assuming the

Re: [Qemu-devel] [PATCHv2] virtio-pci: add MMIO property

2012-03-20 Thread Paul Brook
> @@ -682,10 +733,18 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, > VirtIODevice *vdev) if (size & (size-1)) > size = 1 << qemu_fls(size); > > +proxy->bar0_mask = size - 1; You'll get better performance if you use page-sized mappings. You're already creating a mapping bigger tha

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Michael Roth
On Tue, Mar 20, 2012 at 12:12:45PM +, Peter Maydell wrote: > (I can't find the relevant patches in the mailing list at > this point. I'm talking about this tree from Andreas: > http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-cpu-arm ) > > So in an IRC discussion yesterday we didn

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Peter Maydell
On 20 March 2012 16:06, Paul Brook wrote: >> Yes, I think I'd agree there. So should we just have an init function >> that provides the implementation-specific cp15 registers based on the value >> provided in the QOM property for the main ID register? > > Something like that, yes.  I'm not convinc

Re: [Qemu-devel] [PATCH] hw/vexpress.c: Add NOR flash model

2012-03-20 Thread Peter Maydell
On 20 March 2012 16:00, walimis wrote: > On Tue, Mar 20, 2012 at 03:13:33PM +, Peter Maydell wrote: >>On 20 March 2012 14:57, Liming Wang wrote: >>> Vexpress motherboard has two 2x16 NOR flash, but pflash_cfi01 >>> doesn't support interleaving, so here only models two 1x32 flash. >>> Although

Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Peter Maydell
On 20 March 2012 15:41, Andreas Färber wrote: > Tested the default, non-struct version only. > > Juan, would it make sense to add a configure option for this #define, > similar to --enable-debug-tcg? We'd need to fix some of the other targets: target-alpha/machine.c:25: error: invalid operands to

Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michael Roth
On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote: > Currently, the implementation of that command is full of > Linux specific code. Before any brave man will step into > and port it to other OSes, make this function Linux only. > > Signed-off-by: Michal Privoznik Which aspect is

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Paul Brook
> > If we're going to use the class hierachy to implement functionality then > > there are other candidates. Given the primary purpose of QOM is [IMO] > > to handle interaction between devices, the external interface exposed by > > the core seems like a better candidate for subclassing. i.e. > >

Re: [Qemu-devel] [RFC PATCH 08/10] qed: add bdrv_post_incoming_migration operation checking the image

2012-03-20 Thread Stefan Hajnoczi
2012/3/20 Benoît Canet : > > So should I drop the "block: rename *_invalidate_cache_* to > *_post_incoming_migration_*" commit ? Yes, I think there is no semantic change so keeping the name unchanged is good. Stefan

Re: [Qemu-devel] [RFC PATCH 02/10] block: add a function to set incoming live migration

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 06, 2012 at 06:32:21PM +0100, Benoît Canet wrote: > This function will help to inform the block layer that an incoming > live migration is coming in order to make proper usage of the > BDRV_O_INCOMING flag. > > Signed-off-by: Benoit Canet > --- > block.c |8 > block.h |

Re: [Qemu-devel] [RFC PATCH 08/10] qed: add bdrv_post_incoming_migration operation checking the image

2012-03-20 Thread Benoît Canet
So should I drop the "block: rename *_invalidate_cache_* to *_post_incoming_migration_*" commit ? On Tue, Mar 20, 2012 at 4:42 PM, Stefan Hajnoczi wrote: > On Tue, Mar 06, 2012 at 06:32:27PM +0100, Benoît Canet wrote: > > @@ -1529,6 +1529,19 @@ static int > bdrv_qed_change_backing_file(BlockDriv

Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Juan Quintela
Andreas Färber wrote: > Am 20.03.2012 16:24, schrieb Juan Quintela: >> This change makes it compile and return the same value than the #undef one. >> >> Signed-off-by: Juan Quintela > > Cool, > > Acked-by: Andreas Färber > > Tested the default, non-struct version only. > > Juan, would it make s

Re: [Qemu-devel] [RFC PATCH 00/10] make qed and live migration usage safe

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 06, 2012 at 06:32:19PM +0100, Benoît Canet wrote: > QED + live migration is an unsafe and disabled mix. > > This patchset make qed and live migration safe to use. > > The check of QED images is delayed during the incoming migration. > After the migration complete the QED images are ch

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-20 Thread Gleb Natapov
On Tue, Mar 20, 2012 at 05:59:16PM +0800, Wen Congyang wrote: > At 03/19/2012 03:33 PM, Wen Congyang Wrote: > > At 03/08/2012 03:57 PM, Wen Congyang Wrote: > >> We can know the guest is paniced when the guest runs on xen. > >> But we do not have such feature on kvm. > >> > >> Another purpose of thi

Re: [Qemu-devel] [RFC PATCH 08/10] qed: add bdrv_post_incoming_migration operation checking the image

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 06, 2012 at 06:32:27PM +0100, Benoît Canet wrote: > @@ -1529,6 +1529,19 @@ static int > bdrv_qed_change_backing_file(BlockDriverState *bs, > return ret; > } > > +static void bdrv_qed_check_if_needed(BlockDriverState *bs) > +{ > +/* close the block device if the verification

Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Andreas Färber
Am 20.03.2012 16:24, schrieb Juan Quintela: > This change makes it compile and return the same value than the #undef one. > > Signed-off-by: Juan Quintela Cool, Acked-by: Andreas Färber Tested the default, non-struct version only. Juan, would it make sense to add a configure option for this

Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Peter Maydell
On 20 March 2012 15:24, Juan Quintela wrote: > This change makes it compile and return the same value than the #undef one. > > Signed-off-by: Juan Quintela Oops, that would have been my fault when I put in the fused multiply accumulate support. Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-20 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 1.0+noroms-0ubuntu9 --- qemu-kvm (1.0+noroms-0ubuntu9) precise; urgency=low * debian/patches/multiboot-load-fix.diff: fix bug when loading multiboot images such as grub via -kernel parameter (LP: #957622) -- Scott MoserSun, 18 Ma

[Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Juan Quintela
This change makes it compile and return the same value than the #undef one. Signed-off-by: Juan Quintela --- fpu/softfloat.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 81a7d1a..a1f4527 100644 --- a/fpu/softfloat.c +++ b/fpu

Re: [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays

2012-03-20 Thread Juan Quintela
Peter Maydell wrote: > On 19 March 2012 22:57, Juan Quintela wrote: >> +/* 32 bit float */ >> + >> +typedef union { >> +    float32 f; >> +    uint32_t i; >> +} VMStateFloat32; >> + >> +static int get_float32(QEMUFile *f, void *pv, size_t size) >> +{ >> +    float32 *v = pv; >> +    VMStateFloat3

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-20 Thread Serge Hallyn
Thanks, Scott, the patch worked for me so I'll push it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kernel with grub multiboot kernel dumps core or exits Status in QEMU: Con

Re: [Qemu-devel] [PATCH] hw/vexpress.c: Add NOR flash model

2012-03-20 Thread Peter Maydell
On 20 March 2012 14:57, Liming Wang wrote: > Vexpress motherboard has two 2x16 NOR flash, but pflash_cfi01 > doesn't support interleaving, so here only models two 1x32 flash. > Although it's not exactly modeled, it works fine for running linux. > > Signed-off-by: Liming Wang > --- >  hw/vexpress.

[Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michal Privoznik
Currently, the implementation of that command is full of Linux specific code. Before any brave man will step into and port it to other OSes, make this function Linux only. Signed-off-by: Michal Privoznik --- qga/commands-posix.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(

Re: [Qemu-devel] [PATCH] fix multiboot loading if load_end_addr == 0 (fwd)

2012-03-20 Thread Serge E. Hallyn
Quoting Scott Moser (smo...@ubuntu.com): > Re-sending to qemu-devel. I'd originally sent this to kvm mailing list. > > > -- Forwarded message -- > Date: Sat, 17 Mar 2012 00:08:06 > From: Scott Moser > To: k...@vger.kernel.org > Subject: [PATCH] fix multiboot loading if load_end_

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Peter Maydell
On 20 March 2012 14:08, Paul Brook wrote: >> Option two looks kind of nice, but I'm not sure whether it would >> actually work. I think you could do 95% of what you need for a >> different CPU that way (lots of properties for "value of ID_MMFR1", >> "value of "ID_MMFR2", "reset value of SCTLR", et

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-20 Thread Avi Kivity
On 03/19/2012 08:57 PM, Michael S. Tsirkin wrote: > > > > Should be done via an extra BAR (with the same layout, perhaps extended) > > so compatibility is preserved. > > No, that would need guest changes to be of use. The point of this hack > is to make things work for Linux guests where PIO does

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-20 Thread Serge Hallyn
** Description changed: I attempted to use kvm -kernel with a grub multiboot image, specifically grub-maverick-20100729.img at [1]. That file was built using [2] $ url="http://bazaar.launchpad.net/~ubuntu-on-ec2/vmbuilder/automated-ec2-builds/download/head:/grubmaverick20100729-20100729

Re: [Qemu-devel] [PATCH v4 3/7] RTC: Add UIP(update in progress) check logic

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > The UIP(update in progress) is set when RTC is updating. And the update cycle > begins 244us later after UIP is set. And it is cleared when update end. this patch seems good to me > Signed-off-by: Yang Zhang > --- > hw/mc146818rtc.c | 18 +

Re: [Qemu-devel] [PATCH v4 2/7] RTC: Update the RTC clock only when reading it

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: > There has no need to use two periodic timer to update RTC time. In this > patch, we only update it when guest reading it. So the basic idea here is that we don't need to two periodic timers because we are going to calculate the RTC guest time from QEMU'

Re: [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays

2012-03-20 Thread Peter Maydell
On 19 March 2012 22:57, Juan Quintela wrote: > +/* 32 bit float */ > + > +typedef union { > +    float32 f; > +    uint32_t i; > +} VMStateFloat32; > + > +static int get_float32(QEMUFile *f, void *pv, size_t size) > +{ > +    float32 *v = pv; > +    VMStateFloat32 u; > +    qemu_get_be32s(f, &u.i)

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Paul Brook
> Option two looks kind of nice, but I'm not sure whether it would > actually work. I think you could do 95% of what you need for a > different CPU that way (lots of properties for "value of ID_MMFR1", > "value of "ID_MMFR2", "reset value of SCTLR", etc etc, plus properties > for all our existing A

  1   2   >