Re: [Qemu-devel] [RFC PATCH 2/2] target-arm: introduce Exynos4210 SD host controller model

2012-04-20 Thread Peter Crosthwaite
target-arm: is probably non the correct subject prefix for this patch. target-arm generally means you are patching the arm CPU stuff? Peter On Wed, Apr 18, 2012 at 6:43 PM, Igor Mitsyanko i.mitsya...@samsung.com wrote: Exynos4210 SD/MMC host controller is based on SD association standart host

Re: [Qemu-devel] [PATCH v1 1/3] xilinx_zynq: added smp support

2012-04-20 Thread Peter Crosthwaite
Ping! I realise there were issues with the other patches in this series, but this one on its own is self contained and valuable in its own right. Can we get a review accordingly? Regards, Peter On Wed, Apr 11, 2012 at 3:50 AM, John Linn john.l...@xilinx.com wrote: -Original Message-

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Nicholas A. Bellinger
On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: Hi, Hi Anthony, As I've mentioned before in the past, I will apply vhost-* without an extremely compelling argument for it. The reason we ultimately settled on vhost-net is that in the absence of a fundamental change in the

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Zhi Yong Wu
I have pushed the rebased QEMU codes and tcm_vhost codes to my git tree. Perhaps some one is interested in playing with it. 1.) my kernel git g...@github.com:wuzhy/linux.git tcm_vhost https://github.com/wuzhy/linux/commits/tcm_vhost 2.) my QEMU git g...@github.com:wuzhy/qemu.git vhost-scsi

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Nicholas A. Bellinger
On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: Hi Nicholas, On 04/19/2012 06:53 PM, Nicholas A. Bellinger wrote: On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: However, for storage, be it scsi or direct access, the same problem really doesn't exist. There isn't an

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Paolo Bonzini
Il 19/04/2012 21:34, Luiz Capitulino ha scritto: If this turns out to be a problem for libvirt, I'd say it's a libvirt bug. FWIW, I agree completely. Paolo

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread ronnie sahlberg
On Fri, Apr 20, 2012 at 5:00 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: Hi Nicholas, On 04/19/2012 06:53 PM, Nicholas A. Bellinger wrote: On Thu, 2012-04-19 at 07:30 -0500, Anthony Liguori wrote: However, for storage, be

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Nicholas A. Bellinger
On Fri, 2012-04-20 at 17:50 +1000, ronnie sahlberg wrote: On Fri, Apr 20, 2012 at 5:00 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: Hi Nicholas, SNIP The argument that a SCSI target for virtual machines is so complex

Re: [Qemu-devel] [PATCH v8 2/4] sockets: change inet_connect() to support nonblock socket

2012-04-20 Thread Orit Wasserman
On 04/20/2012 07:40 AM, Amos Kong wrote: Add a bool argument to inet_connect() to assign if set socket to block/nonblock, and delete original argument 'socktype' that is unused. Add a new argument to inet_connect()/inet_connect_opts(), to pass back connect error by error class. Retry to

Re: [Qemu-devel] [PATCH v8 4/4] use inet_listen()/inet_connect() to support ipv6 migration

2012-04-20 Thread Orit Wasserman
On 04/20/2012 07:43 AM, Amos Kong wrote: Use help functions in qemu-socket.c for tcp migration, which already support ipv6 addresses. Currently errp will be set to UNDEFINED_ERROR when migration fails, qemu would output migration failed: ..., and current user can see a message(An undefined

Re: [Qemu-devel] [PATCH 14/20] qcow2: Factor out count_cow_clusters

2012-04-20 Thread Kevin Wolf
Am 19.04.2012 23:18, schrieb Marcelo Tosatti: On Thu, Apr 19, 2012 at 05:14:20PM -0300, Marcelo Tosatti wrote: There is one intended change in functionality in this patch, which is that it allocates new clusters even when it could satisfy the first part of the request with already allocated

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Paolo Bonzini
Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: TCM runs in the absolute most privileged context possible. When you're dealing with extremely hostile input, it's pretty obvious that you want to run it in the lowest

Re: [Qemu-devel] [PATCH v3] qemu-img: let 'qemu-img convert' flush data

2012-04-20 Thread Kevin Wolf
Am 13.04.2012 11:17, schrieb Liu Yuan: From: Liu Yuan tailai...@taobao.com The 'qemu-img convert -h' advertise that the default cache mode is 'writeback', while in fact it is 'unsafe'. This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush() 2) is needed because some

Re: [Qemu-devel] Intermittent e1000 failure on qemu-kvm 1.0

2012-04-20 Thread Chris Webb
Hi. Sorry for the slow follow-up. Stefan Hajnoczi stefa...@gmail.com writes: Yes, it's odd that QEMU changes make the issue go away but tcpdump suggests the packet is not being sent from the bridge to the tap device. Indeed. I really don't understand how to the two could possible interact!

Re: [Qemu-devel] [PATCH 3/4] Switch from array based resource allocation to list

2012-04-20 Thread Alexey Korolev
[...] [Patch 5] Track-alignment-explicitly Almost the same as the previous, just changed priority from r-align to r-sum when setting start address of root regions. I guess there are more chances to fit memory regions if we try place regions with higher r-sum like it was before. Consider

Re: [Qemu-devel] [PATCH 09/15] target-i386: Add property getter for CPU model

2012-04-20 Thread Andreas Färber
Am 20.04.2012 02:14, schrieb Michael Roth: On Wed, Apr 18, 2012 at 01:11:13AM +0200, Andreas Färber wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH v4] qemu-img: let 'qemu-img convert' flush data

2012-04-20 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com The 'qemu-img convert -h' advertise that the default cache mode is 'writeback', while in fact it is 'unsafe'. This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush() 2) is needed because some backend storage doesn't have a self-flush

Re: [Qemu-devel] [PATCH v4] qemu-img: let 'qemu-img convert' flush data

2012-04-20 Thread Kevin Wolf
Am 20.04.2012 11:10, schrieb Liu Yuan: From: Liu Yuan tailai...@taobao.com The 'qemu-img convert -h' advertise that the default cache mode is 'writeback', while in fact it is 'unsafe'. This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush() 2) is needed because some

Re: [Qemu-devel] SD card subsystem synchronous I/O

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 20, 2012 at 12:21 AM, andrzej zaborowski balr...@gmail.com wrote: On 18 April 2012 14:35, Stefan Hajnoczi stefa...@gmail.com wrote: Recently there have been new SD card emulation patches so I want to raise the issue of synchronous I/O while there is focus on the SD subsystem.  

Re: [Qemu-devel] Compile/link errors

2012-04-20 Thread Andreas Färber
Am 24.02.2012 19:24, schrieb Anthony Liguori: On 02/24/2012 12:09 PM, Andreas Färber wrote: Am 24.02.2012 18:27, schrieb Anthony Liguori: On 02/24/2012 11:11 AM, Gerhard Wiesinger wrote: Hello, I'm having compile/link errors on 85f38553031b1a6e07f786c9ab0d403af7252b4f: LINK

[Qemu-devel] [PATCH 0/5] qemu-timer: Clean code

2012-04-20 Thread Stefan Weil
These patches remove timer code which is no longer needed and try to improve the remaining code. [PATCH 1/5] qemu-timer: Remove redundant include statements [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending [PATCH 3/5] qemu-timer: Use bool, false, true for boolean values [PATCH

[Qemu-devel] [PATCH 4/5] qemu-timer: Remove function alarm_has_dynticks

2012-04-20 Thread Stefan Weil
Some time ago, the last time which did not have dynticks was removed, so now all timers have dynticks. I also removed a misleading error message for the dynticks timer. If timer_create fails, there is already an error message, and QEMU will use the unix timer which also provides dynamic ticks,

[Qemu-devel] [PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending

2012-04-20 Thread Stefan Weil
The last user of this function was removed by commit 12d4536f7d911b6d87a766ad7300482ea663cea2. Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-timer.c |5 - qemu-timer.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-20 Thread Jan Kiszka
On 2012-04-19 22:03, Eduardo Habkost wrote: Jan/Avi: ping? I would like to get this ABI detail clarified so it can be implemented the right way on Qemu and KVM. My proposal is to simply add tsc-deadline to the data returned by GET_SUPPORTED_CPUID, making KVM_CAP_TSC_DEADLINE_TIMER

Re: [Qemu-devel] [PATCH 4/5] qemu-timer: Remove function alarm_has_dynticks

2012-04-20 Thread Paolo Bonzini
Il 20/04/2012 12:03, Stefan Weil ha scritto: Some time ago, the last time which did not have dynticks was removed, so now all timers have dynticks. I also removed a misleading error message for the dynticks timer. If timer_create fails, there is already an error message, and QEMU will use

Re: [Qemu-devel] [PULL 00/20] Block patches

2012-04-20 Thread Andreas Färber
Am 13.03.2012 03:23, schrieb Anthony Liguori: On 03/12/2012 10:19 AM, Kevin Wolf wrote: The following changes since commit a348f108842fb928563865c9918642900cd0d477: Add missing const attributes for MemoryRegionOps (2012-03-11 11:40:15 +) are available in the git repository at:

Re: [Qemu-devel] [PULL 00/20] Block patches

2012-04-20 Thread Andreas Färber
Am 20.04.2012 12:16, schrieb Andreas Färber: Am 13.03.2012 03:23, schrieb Anthony Liguori: On 03/12/2012 10:19 AM, Kevin Wolf wrote: The following changes since commit a348f108842fb928563865c9918642900cd0d477: Add missing const attributes for MemoryRegionOps (2012-03-11 11:40:15 +)

[Qemu-devel] [PATCH 1/5] qemu-timer: Remove redundant include statements

2012-04-20 Thread Stefan Weil
qemu-timer.h includes qemu-common.h which already includes time.h, sys/time.h, windows.h, unistd.h, fcntl.h, errno.h and signal.h. Therefore those include statements are redundant and can be removed. Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-timer.c | 11 ++- qemu-timer.h |

Re: [Qemu-devel] [RFC PATCH 6/9] pc: pass paravirt info for hotplug memory slots to BIOS

2012-04-20 Thread Igor Mammedov
On 04/19/2012 04:08 PM, Vasilis Liaskovitis wrote: The numa_fw_cfg paravirt interface is extended to include SRAT information for all hotplug-able memslots. There are 3 words for each hotplug-able memory slot, denoting start address, size and node proximity. nb_numa_nodes is set to 1 by

Re: [Qemu-devel] [PULL 00/20] Block patches

2012-04-20 Thread Kevin Wolf
Am 20.04.2012 12:16, schrieb Andreas Färber: Am 13.03.2012 03:23, schrieb Anthony Liguori: On 03/12/2012 10:19 AM, Kevin Wolf wrote: The following changes since commit a348f108842fb928563865c9918642900cd0d477: Add missing const attributes for MemoryRegionOps (2012-03-11 11:40:15 +)

[Qemu-devel] [PATCH 3/5] qemu-timer: Use bool, false, true for boolean values

2012-04-20 Thread Stefan Weil
This avoids conversions between int and bool / char. It also makes the code more readable. Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-timer.c | 31 --- qemu-timer.h |6 +++--- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git

Re: [Qemu-devel] [RFC 0/13] Support for guest visible IOMMUs

2012-04-20 Thread Kevin Wolf
Am 20.04.2012 06:16, schrieb David Gibson: I'm really hoping I can get some extra review of this code path. I believe it's correct, but it's not straightforward to test, since it will not be exercise by correct guest software. Sounds like a good case for qtest. Did you consider that? Kevin

Re: [Qemu-devel] [PULL 00/20] Block patches

2012-04-20 Thread Andreas Färber
Am 20.04.2012 12:37, schrieb Kevin Wolf: Am 20.04.2012 12:16, schrieb Andreas Färber: [...] I've been seeing the following annoying problem on master: $ make check-block /home/andreas/QEMU/qemu/tests/qemu-iotests-quick.sh hostname: Name or service not known hostname: Name or service not

[Qemu-devel] [PATCH 5/5] qemu-timer: Optimize data structures

2012-04-20 Thread Stefan Weil
Remove all holes which were found by pahole on Linux x86_64 (and replace struct QEMUTimer by QEMUTimer). Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-timer.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index

[Qemu-devel] [PATCH v2 4/5] qemu-timer: Remove function alarm_has_dynticks

2012-04-20 Thread Stefan Weil
Some time ago, the last time which did not have dynticks was removed, so now all timers have dynticks. I also removed a misleading error message for the dynticks timer. If timer_create fails, there is already an error message, and QEMU will use the unix timer which also provides dynamic ticks,

Re: [Qemu-devel] [PULL 00/20] Block patches

2012-04-20 Thread Kevin Wolf
Am 20.04.2012 12:38, schrieb Andreas Färber: Am 20.04.2012 12:37, schrieb Kevin Wolf: Am 20.04.2012 12:16, schrieb Andreas Färber: [...] I've been seeing the following annoying problem on master: However `hostname` returns myhostname.site just fine, and I don't understand why a user's local

[Qemu-devel] [PATCH] iotests: Resolve test failures caused by hostname

2012-04-20 Thread Andreas Färber
`hostname -s` may output an errror: hostname: Name or service not known This causes all tests to fail for `make check-block`. Suppress such error messages, letting the tests succeed. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/qemu-iotests/common.config |2 +- 1 files changed,

Re: [Qemu-devel] [RFC PATCH 2/9][SeaBIOS] Implement acpi-dsdt functions for memory hotplug.

2012-04-20 Thread Igor Mammedov
On 04/19/2012 04:08 PM, Vasilis Liaskovitis wrote: Extend the DSDT to include methods for handling memory hot-add and hot-remove notifications and memory device status requests. These functions are called from the memory device SSDT methods. Eject has only been tested with level gpe event, but

Re: [Qemu-devel] [PATCH] iotests: Resolve test failures caused by hostname

2012-04-20 Thread Kevin Wolf
Am 20.04.2012 12:50, schrieb Andreas Färber: `hostname -s` may output an errror: hostname: Name or service not known This causes all tests to fail for `make check-block`. Suppress such error messages, letting the tests succeed. Signed-off-by: Andreas Färber afaer...@suse.de Thanks,

[Qemu-devel] [PATCH] usb: add serial number generator

2012-04-20 Thread Gerd Hoffmann
This patch adds a function which creates unique serial numbers for usb devices and puts it into use. Windows guests tend to become unhappy if they find two identical usb devices in the system. Effects range from non-functional devices (with yellow exclamation mark in device manager) to BSODs.

[Qemu-devel] [PATCH 1/5] hw/ac97: Fix log message in mixer_load

2012-04-20 Thread Hans de Goede
Fix a small copy and paste error in logging. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/ac97.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ac97.c b/hw/ac97.c index dd4917b..05ae63b 100644 --- a/hw/ac97.c +++ b/hw/ac97.c @@ -339,7 +339,7 @@ static

[Qemu-devel] [PATCH 2/5] hw/ac97: Make a bunch of mixer registers read only

2012-04-20 Thread Hans de Goede
The Linux ac97 driver tries to see if optional things like video input volume control are available in 2 ways: 1) See if the mute bit is set after reset, if it is no further tests are done 2) If the mute bit is not set it does a write/read test of the mute bit This patch changes our ac97 to

[Qemu-devel] [PATCH 3/5] hw/ac97: Use AC97_Record_Gain_Mute not AC97_Line_In_Volume_Mute

2012-04-20 Thread Hans de Goede
After commit 19677a380a70348134ed7650b294522617eb03fc: hw/ac97: add support for volume control We are (correctly) using AC97_Record_Gain_Mute and not AC97_Line_In_Volume_Mute for recording volume, but various places in hw/ac97 were still assumimg that we are using AC97_Line_In_Volume_Mute for

[Qemu-devel] [PATCH 4/5] hw/ac97: Mask out unused bits of volume controls

2012-04-20 Thread Hans de Goede
The Linux ac97 drivers does a number of register read/write tests to see how much resolution a volume control actually has. This patch takes this into account by masking out any bits written to a volume control reg which should not be there according to the spec. After this the Linux ac97 driver

[Qemu-devel] [PATCH 5/5] hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes

2012-04-20 Thread Hans de Goede
The Linux AC97 driver tests this bit to decide wether or not to show an External amplifier toggle control. This patch was also tested with a Windows XP guest without any issues. Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/ac97.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 20, 2012 at 8:46 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: On Thu, 2012-04-19 at 19:20 -0500, Anthony Liguori wrote: TCM runs in the absolute most privileged context possible.  When you're dealing with extremely hostile

Re: [Qemu-devel] [PATCH v3 2/4] m25p80: initial verion

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 20, 2012 at 3:12 AM, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: +static inline void flash_sync_area(struct flash *s, int64_t off, int64_t len) +{ +    int64_t start, end; + +    if (!s-bdrv) { +        return; +    } + +    start = off / 512; +    end =

Re: [Qemu-devel] [PATCH v3] ARM: Exynos4210 IRQ: Introduce new IRQ gate functionality.

2012-04-20 Thread Peter Maydell
On 17 April 2012 06:41, Evgeny Voevodin e.voevo...@samsung.com wrote: +static Property exynos4210_irq_gate_properties[] = { +    DEFINE_PROP_UINT32(n_in, Exynos4210IRQGateState, n_in, 1), +    DEFINE_PROP_END_OF_LIST(), +}; +  static const VMStateDescription vmstate_exynos4210_irq_gate = {  

Re: [Qemu-devel] [PATCH 04/15] target-i386: Add family property to X86CPU

2012-04-20 Thread Andreas Färber
Am 20.04.2012 00:34, schrieb Michael Roth: On Wed, Apr 18, 2012 at 01:11:08AM +0200, Andreas Färber wrote: Add the property early in the initfn so that it can be used in helpers such as mce_init(). Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/cpu.c | 38

Re: [Qemu-devel] SD card subsystem synchronous I/O

2012-04-20 Thread andrzej zaborowski
On 20 April 2012 11:50, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Apr 20, 2012 at 12:21 AM, andrzej zaborowski balr...@gmail.com wrote: Yes, controllers would be affected, but there are various ways to go about it.  Some could be simple to implement (looking at pxa2xx_mmci.c).  First

Re: [Qemu-devel] [PATCH v1 1/3] xilinx_zynq: added smp support

2012-04-20 Thread Peter Maydell
On 2 April 2012 06:20, Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com wrote: Added linux smp support for the xilinx zynq platform (2x cpus are supported) Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com ---  hw/xilinx_zynq.c |   64

Re: [Qemu-devel] [PATCH] iotests: Resolve test failures caused by hostname

2012-04-20 Thread Stefan Weil
Am 20.04.2012 12:59, schrieb Kevin Wolf: Am 20.04.2012 12:50, schrieb Andreas Färber: `hostname -s` may output an errror: hostname: Name or service not known This causes all tests to fail for `make check-block`. Suppress such error messages, letting the tests succeed. Signed-off-by: Andreas

Re: [Qemu-devel] [PATCH v3] ARM: Exynos4210 IRQ: Introduce new IRQ gate functionality.

2012-04-20 Thread Evgeny Voevodin
On 20.04.2012 15:13, Peter Maydell wrote: On 17 April 2012 06:41, Evgeny Voevodine.voevo...@samsung.com wrote: +static Property exynos4210_irq_gate_properties[] = { +DEFINE_PROP_UINT32(n_in, Exynos4210IRQGateState, n_in, 1), +DEFINE_PROP_END_OF_LIST(), +}; + static const

Re: [Qemu-devel] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze

2012-04-20 Thread Stefan Hajnoczi
On Thu, Apr 19, 2012 at 10:49:16AM -0500, Michael Roth wrote: On Tue, Apr 17, 2012 at 12:07:38PM -0500, Michael Roth wrote: When linux-specific commands (including guest-fsfreeze-*) were consolidated under defined(__linux__), we forgot to account for the case where defined(__linux__)

Re: [Qemu-devel] [RFC 0/13] Support for guest visible IOMMUs

2012-04-20 Thread David Gibson
On Fri, Apr 20, 2012 at 12:39:36PM +0200, Kevin Wolf wrote: Am 20.04.2012 06:16, schrieb David Gibson: I'm really hoping I can get some extra review of this code path. I believe it's correct, but it's not straightforward to test, since it will not be exercise by correct guest software.

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Michal Privoznik
On 19.04.2012 21:34, Luiz Capitulino wrote: On Thu, 19 Apr 2012 13:57:48 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: On Thu, Apr 19, 2012 at 02:36:53PM -0300, Luiz Capitulino wrote: Michael, I'm going to revive this topic one more time. I was working on v2 of my fixes to the

Re: [Qemu-devel] [PATCH] arm-dis: Fix spelling in comments (iff - if)

2012-04-20 Thread Stefan Hajnoczi
On Tue, Apr 17, 2012 at 07:58:13PM +0200, Stefan Weil wrote: The spelling 'iff' is sometimes used for 'if and only if'. Even if that meaning could be applied here, it is not used consistently. It is also quite unusual to use 'if and only if' in technical documentation. Therefore a simple 'if'

Re: [Qemu-devel] [PATCH] usb: add serial number generator

2012-04-20 Thread Hans de Goede
Hi, Looks good, ack. Regards, Hans On 04/20/2012 12:55 PM, Gerd Hoffmann wrote: This patch adds a function which creates unique serial numbers for usb devices and puts it into use. Windows guests tend to become unhappy if they find two identical usb devices in the system. Effects range

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Add .gitignore for tests/

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 20, 2012 at 11:40:24AM +1000, David Gibson wrote: The new autotests in tests/ generate a number of files, both executable and source, which are not caught by the existing .gitignore files. This patch adds a new .gitignore in tests/ which covers these. Signed-off-by: David Gibson

Re: [Qemu-devel] [Qemu-trivial] [PATCH] e1000: Fix spelling (segmentaion - segmentation) in debug output

2012-04-20 Thread Stefan Hajnoczi
On Wed, Apr 18, 2012 at 07:28:34AM +0200, Stefan Weil wrote: This was reported by https://bugs.launchpad.net/qemu/+bug/984476. I also changed the case for 'error'. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/e1000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH 14/20] qcow2: Factor out count_cow_clusters

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 20, 2012 at 9:24 AM, Kevin Wolf kw...@redhat.com wrote: Am 19.04.2012 23:18, schrieb Marcelo Tosatti: On Thu, Apr 19, 2012 at 05:14:20PM -0300, Marcelo Tosatti wrote: There is one intended change in functionality in this patch, which is that it allocates new clusters even when it

Re: [Qemu-devel] [PATCH] gitignore: ignore qtest binaries

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 13, 2012 at 03:17:21PM +0100, Stefan Hajnoczi wrote: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9859c7d..db74219 100644 --- a/.gitignore +++ b/.gitignore @@

Re: [Qemu-devel] [PATCH 00/20] PPC: AREG0 conversion

2012-04-20 Thread Alexander Graf
On 16.04.2012, at 21:46, Blue Swirl wrote: On Mon, Apr 16, 2012 at 19:28, Peter Maydell peter.mayd...@linaro.org wrote: On 16 April 2012 20:12, Blue Swirl blauwir...@gmail.com wrote: On Mon, Apr 16, 2012 at 16:53, Alexander Graf ag...@suse.de wrote: If you can update it on top of ppc-next

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Paolo Bonzini
Il 20/04/2012 14:07, Michal Privoznik ha scritto: Just to make this clear: this report-only-error behavior concerns only guest-suspend-* and guest-shutdown commands, right? Because otherwise, if we enable such behavior for all commands (e.g. fsfreeze) I think we are entering the world of pain.

[Qemu-devel] [PATCH 4/7] pflash_cfi01: remove redundant line

2012-04-20 Thread Stefan Hajnoczi
From: Eric Bénard e...@eukrea.com Signed-off-by: Eric Bénard e...@eukrea.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/pflash_cfi01.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/pflash_cfi01.c

[Qemu-devel] [PATCH 5/7] spice-qemu-char.c: Show what name is unsupported

2012-04-20 Thread Stefan Hajnoczi
From: Eduardo Elias Ferreira ed...@linux.vnet.ibm.com Signed-off-by: Eduardo Elias Ferreira ed...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- spice-qemu-char.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-qemu-char.c

[Qemu-devel] [PATCH 2/7] fix block_job_set_speed name in documentation

2012-04-20 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hmp-commands.hx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index

[Qemu-devel] [PATCH 3/7] qxl: Add missing GCC_FMT_ATTR and fix format specifier

2012-04-20 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de val is an uint64_t, therefore %d was not correct. Signed-off-by: Stefan Weil s...@weilnetz.de Acked-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/qxl.c |2 +- hw/qxl.h |2 +- 2 files changed, 2

[Qemu-devel] [PATCH 6/7] e1000: Fix spelling (segmentaion - segmentation) in debug output

2012-04-20 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de This was reported by https://bugs.launchpad.net/qemu/+bug/984476. I also changed the case for 'error'. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/e1000.c |2 +- 1 file changed, 1

[Qemu-devel] [PATCH 1/7] error.c: don't return value for void function

2012-04-20 Thread Stefan Hajnoczi
From: Amos Kong ak...@redhat.com It is invalid to return a value from a function returning void. [C99 6.8.6.4 says A return statement with an expression shall not appear in a function whose return type is void but gcc 4.6.3 with QEMU compile flags does not complain. It's still worth fixing

[Qemu-devel] [PULL 0/7] Trivial patches for 14 to 20 April 2012

2012-04-20 Thread Stefan Hajnoczi
The following changes since commit 51006bbc45bc74977ae538190a53df2af534acb9: Merge remote-tracking branch 'origin/master' into staging (2012-04-18 10:06:09 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

[Qemu-devel] [PATCH 7/7] Add .gitignore for tests/

2012-04-20 Thread Stefan Hajnoczi
From: David Gibson da...@gibson.dropbear.id.au The new autotests in tests/ generate a number of files, both executable and source, which are not caught by the existing .gitignore files. This patch adds a new .gitignore in tests/ which covers these. [Changed 'rtc-test' to '*-test' so future

Re: [Qemu-devel] [PATCH 14/20] qcow2: Factor out count_cow_clusters

2012-04-20 Thread Stefan Hajnoczi
On Fri, Apr 20, 2012 at 1:27 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Apr 20, 2012 at 9:24 AM, Kevin Wolf kw...@redhat.com wrote: Am 19.04.2012 23:18, schrieb Marcelo Tosatti: On Thu, Apr 19, 2012 at 05:14:20PM -0300, Marcelo Tosatti wrote: There is one intended change in

Re: [Qemu-devel] [PATCH 1/2 v5-test] add function DMA_set_return and DMA_set_channel_async in dma.c

2012-04-20 Thread Paolo Bonzini
Il 20/04/2012 04:36, Zhi Hui Li ha scritto: If I add the code : if ((0 == (d-mask mask)) (0 != (d-status (mask 4 { channel_run (icont, ichan); } Because function DMA_set_return is called in fdctrl_read_DMA_cb and fdctrl_write_DMA_cb, the fdctrl_stop_transfer will release

Re: [Qemu-devel] [PATCH 14/20] qcow2: Factor out count_cow_clusters

2012-04-20 Thread Kevin Wolf
Am 20.04.2012 15:06, schrieb Stefan Hajnoczi: On Fri, Apr 20, 2012 at 1:27 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Apr 20, 2012 at 9:24 AM, Kevin Wolf kw...@redhat.com wrote: Am 19.04.2012 23:18, schrieb Marcelo Tosatti: On Thu, Apr 19, 2012 at 05:14:20PM -0300, Marcelo Tosatti

[Qemu-devel] [PULL BUILD FIX] build xc_hvm_inject_msi on Xen 4.2

2012-04-20 Thread Stefano Stabellini
Anthony, please pull: git://xenbits.xen.org/people/sstabellini/qemu-dm.git build_fix this small patch series fixes the build breakage introduced by f1dbf015dfb0aa7f66f710a1f1bc58b662951de2 with Xen 4.2. The problem is that xc_hvm_inject_msi is only defined from Xen 4.2 onwards so we need to

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-20 Thread Luiz Capitulino
On Fri, 20 Apr 2012 14:07:16 +0200 Michal Privoznik mpriv...@redhat.com wrote: But, I think if we tell users we'll *only* send response on error, we should do our part to *not* send the responses, rather than relying on them having implemented the reset mechanism to throw them away after

[Qemu-devel] [PATCH] qcow2: Fix refcount block allocation during qcow2_allocate_cluster_at()

2012-04-20 Thread Kevin Wolf
Refcount block allocation and refcount table growth rely on s-free_cluster_index pointing to somewhere after the current allocation. Change qcow2_allocate_cluster_at() to fulfill this assumption. Without this change it could happen that a newly allocated refcount block and the allocated data

Re: [Qemu-devel] [RFC PATCH 2/9][SeaBIOS] Implement acpi-dsdt functions for memory hotplug.

2012-04-20 Thread Vasilis Liaskovitis
Hi, On Fri, Apr 20, 2012 at 12:55:24PM +0200, Igor Mammedov wrote: +/* Memory eject notify method */ +OperationRegion(MEMJ, SystemIO, 0xaf40, 32) +Field (MEMJ, ByteAcc, NoLock, Preserve) +{ +MPE, 256 +} + +Method (MPEJ, 2,

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-20 Thread Vasilis Liaskovitis
On Thu, Apr 19, 2012 at 04:08:38PM +0200, Vasilis Liaskovitis wrote: series is based on uq/master for qemu-kvm, and master for seabios. Can be found also at: forgot to paste the repo links in the original coverletter, here they are if someone wants them:

Re: [Qemu-devel] [PATCH v2 01/14] target-arm: Add QOM subclasses for each ARM cpu implementation

2012-04-20 Thread Andreas Färber
Am 15.04.2012 01:18, schrieb Peter Maydell: On 14 April 2012 18:39, Andreas Färber afaer...@suse.de wrote: Am 14.04.2012 18:42, schrieb Peter Maydell: Register subclasses for each ARM CPU implementation (with the exception of pxa270, which is an alias for pxa270-a0). This is no longer

Re: [Qemu-devel] [PATCH v1 1/3] xilinx_zynq: added smp support

2012-04-20 Thread John Linn
-Original Message- From: Peter Crosthwaite [mailto:peter.crosthwa...@petalogix.com] Sent: Thursday, April 19, 2012 11:18 PM To: John Linn Cc: qemu-devel@nongnu.org; p...@codesourcery.com; peter.mayd...@linaro.org; edgar.igles...@gmail.com; Duy Le; john.willi...@petalogix.com

[Qemu-devel] [PATCH] Remove extra pthread switch

2012-04-20 Thread Peter Portante
From the Department of the Redundancy Department: remove the extra pthread switch which might be there from the package config check for gthreads. Signed-off-by: Peter Portante peter.porta...@redhat.com --- configure | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [PATCH v2 02/14] target-arm: Move feature bit settings to CPU init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: Move the setting of the feature bits from cpu_reset_model_id() to each CPU's instance init function. This requires us to move the features field in CPUARMState so that it is not cleared on reset. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 03/14] target-arm: Move FPSID config to cpu init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: Move the reset FPSID to the ARMCPU struct, and set it in the per-implementation instance init function. At reset we then just copy the reset value into the CPUARMState field. Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

Re: [Qemu-devel] [PATCH v2 02/14] target-arm: Move feature bit settings to CPU init fns

2012-04-20 Thread Peter Maydell
On 20 April 2012 15:43, Andreas Färber afaer...@suse.de wrote: Am 14.04.2012 18:42, schrieb Peter Maydell:  static void pxa270c5_initfn(Object *obj)  {      ARMCPU *cpu = ARM_CPU(obj); +    set_feature(cpu-env, ARM_FEATURE_V7); +    set_feature(cpu-env, ARM_FEATURE_VFP4); +    

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-20 Thread Eduardo Habkost
On Fri, Apr 20, 2012 at 12:12:38PM +0200, Jan Kiszka wrote: On 2012-04-19 22:03, Eduardo Habkost wrote: Jan/Avi: ping? I would like to get this ABI detail clarified so it can be implemented the right way on Qemu and KVM. My proposal is to simply add tsc-deadline to the data returned

Re: [Qemu-devel] [PATCH v2 04/14] target-arm: Move MVFR* setup to per cpu init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: Move the MVFR* VFP feature register values to ARMCPU, so they are set up by the implementation-specific instance init functions rather than in cpu_reset_model_id(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Andreas Färber

Re: [Qemu-devel] [PATCH v2 05/14] target-arm: Move CTR setup to per cpu init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: Move CTR (cache type register) value to an ARMCPU field set up by per-cpu init fns. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Andreas Färber afaer...@suse.de /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg,

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-20 Thread Jan Kiszka
On 2012-04-20 17:00, Eduardo Habkost wrote: On Fri, Apr 20, 2012 at 12:12:38PM +0200, Jan Kiszka wrote: On 2012-04-19 22:03, Eduardo Habkost wrote: Jan/Avi: ping? I would like to get this ABI detail clarified so it can be implemented the right way on Qemu and KVM. My proposal is to simply

Re: [Qemu-devel] [PATCH v2 06/14] target-arm: Move SCTLR reset value setup to per cpu init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: Move the reset value of SCTLR to ARMCPU, initialised in the per-cpu init functions. It can then be reset by a simple copy, and we can drop the code from cpu_reset_model_id(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Andreas

Re: [Qemu-devel] [PATCH v2] versatiblepb: add NOR flash support

2012-04-20 Thread Peter Maydell
On 16 April 2012 16:02, Eric Bénard e...@eukrea.com wrote: - add support for the 64MB NOR CFI01 flash available at 0x3400 on the versatilepb board http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0225d/BBAJIHEC.html - tested with barebox bootloader Signed-off-by: Eric

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-20 Thread Eduardo Habkost
On Fri, Apr 20, 2012 at 05:19:17PM +0200, Jan Kiszka wrote: On 2012-04-20 17:00, Eduardo Habkost wrote: On Fri, Apr 20, 2012 at 12:12:38PM +0200, Jan Kiszka wrote: On 2012-04-19 22:03, Eduardo Habkost wrote: Jan/Avi: ping? I would like to get this ABI detail clarified so it can be

[Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

2012-04-20 Thread Peter Portante
Signed-off-by: Peter Portante peter.porta...@redhat.com --- hw/spapr_hcall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/spapr_hcall.c b/hw/spapr_hcall.c index 634763e..94bb504 100644 --- a/hw/spapr_hcall.c +++ b/hw/spapr_hcall.c @@ -482,7 +482,7 @@ static

[Qemu-devel] [Bug 986241] [NEW] Misspelling of env parameter in deregister_dtl() [hw/spapr_hcall.c]

2012-04-20 Thread Peter Portante
Public bug reported: Looks like there is a simple misspelling of the env parameter, as emv, in hw/spapr_hcall.c:485: static target_ulong deregister_dtl(CPUPPCState *emv, target_ulong addr) ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification

Re: [Qemu-devel] [PATCH v2 09/14] target-arm: Move feature register setup to per-CPU init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: Move feature register value setup to per-CPU init functions. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu-qom.h | 14 target-arm/cpu.c | 91 ++

Re: [Qemu-devel] [PATCH v2 09/14] target-arm: Move feature register setup to per-CPU init fns

2012-04-20 Thread Peter Maydell
On 20 April 2012 16:50, Andreas Färber afaer...@suse.de wrote: Missing cpu-id_mmfr3 = 0x11; [etc] Whoops, that was a bit sloppy. Fixed and new version pushed to git://git.linaro.org/people/pmaydell/qemu-arm.git drop-reset-model-id -- PMM

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Move cache ID register setup to cpu specific init fns

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: Move cache ID register reset out of cpu_reset_model_id() by creating a field for the reset value in ARMCPU and setting it up in the cpu specific init functions. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu-qom.h |

Re: [Qemu-devel] [PATCH v2 11/14] target-arm: Move cache ID register setup to cpu specific init fns

2012-04-20 Thread Peter Maydell
On 20 April 2012 17:00, Andreas Färber afaer...@suse.de wrote: Am 14.04.2012 18:42, schrieb Peter Maydell: +    cpu-clidr = (1 27) | (2 24) | 3; Copypaste, should be (1 27) | (1 24) | 3. Fixed and pushed, sigh. -- PMM

Re: [Qemu-devel] [PATCH v2 12/14] target-arm: Drop cpu_reset_model_id()

2012-04-20 Thread Andreas Färber
Am 14.04.2012 18:42, schrieb Peter Maydell: cpu_reset_model_id() is now empty and we can remove it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Acked-by: Andreas Färber afaer...@suse.de However, ... diff --git a/target-arm/helper.c b/target-arm/helper.c index 5cbc7e0..653885a

  1   2   >