Re: [Qemu-devel] [PATCH v2 05/13] pci: Add ACS validation utility

2012-05-24 Thread Don Dutile
On 05/22/2012 01:05 AM, Alex Williamson wrote: In a PCI environment, transactions aren't always required to reach the root bus before being re-routed. Intermediate switches between an endpoint and the root bus can redirect DMA back downstream before things like IOMMUs have a chance to intervene.

Re: [Qemu-devel] Weird iscsi/fd-event issue since recent merge of event system changes

2012-05-24 Thread ronnie sahlberg
On Wed, May 23, 2012 at 2:31 AM, Michael Tokarev wrote: > On 22.05.2012 14:03, ronnie sahlberg wrote: > [] Doh, now I remember.  Whenever you change the aio handlers you need to call qemu_notify_event() afterwards, if the handler may fire right away. >>> >>> Thanks.  I just confirmed tha

Re: [Qemu-devel] [PATCH v2 12/13] pci: Misc pci_reg additions

2012-05-24 Thread Alex Williamson
On Thu, 2012-05-24 at 17:49 -0400, Don Dutile wrote: > On 05/22/2012 01:05 AM, Alex Williamson wrote: > > Fill in many missing definitions and add sizeof fields for many > > sections allowing for more extensive config parsing. > > > > Signed-off-by: Alex Williamson > > --- > > > overall, i'm very g

Re: [Qemu-devel] [PATCH v2 12/13] pci: Misc pci_reg additions

2012-05-24 Thread Don Dutile
On 05/22/2012 01:05 AM, Alex Williamson wrote: Fill in many missing definitions and add sizeof fields for many sections allowing for more extensive config parsing. Signed-off-by: Alex Williamson --- overall, i'm very glad to see defines instead of hardcoded numbers in the code, but in

[Qemu-devel] [Bug 1004050] [NEW] qemu-system-ppc64 by default has non-working keyboard

2012-05-24 Thread Richard W.M. Jones
Public bug reported: Compile qemu from git and do: ./ppc64-softmmu/qemu-system-ppc64 (ie. no parameters). It boots to an OpenBIOS prompt. However the keyboard doesn't work. After ~10 keypresses, qemu just says: usb-kbd: warning: key event queue full usb-kbd: warning: key event queue full u

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-24 Thread Amos Kong
On 25/05/12 11:51, Eric Blake wrote: On 05/24/2012 09:32 PM, Amos Kong wrote: Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to monitor.c Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Signed-off-by: Amos Kong +## +# @sen

[Qemu-devel] [BUG] qemu-ga: failed to fsfreeze-thaw on RHEL 5.8 Guest

2012-05-24 Thread MATSUDA, Daiki
I encountered the serious bug on QEMU Guest Agent. environment Guest OS : RHEL 5.8 / 5.7 (i686) Guest Agent Version : qemu-1.1.0rc2 and rc3 I am trying to take snapshot via virsh snapshot-create-as command. And to freeze guest's filesystem and take snapshot is succeed. But after sending the thaw

Re: [Qemu-devel] [RFC:kvm] export host NUMA info to guest & make emulated device NUMA attr

2012-05-24 Thread Liu ping fan
On Wed, May 23, 2012 at 10:52 PM, Andrew Theurer wrote: > On 05/22/2012 04:28 AM, Liu ping fan wrote: >> >> On Sat, May 19, 2012 at 12:14 AM, Shirley Ma  wrote: >>> >>> On Thu, 2012-05-17 at 17:20 +0800, Liu Ping Fan wrote: Currently, the guest can not know the NUMA info of the vcpu, whi

[Qemu-devel] [PATCH v2] spapr: Add "memop" hypercall

2012-05-24 Thread Benjamin Herrenschmidt
This adds a qemu-specific hypervisor call to the pseries machine which allows to do what amounts to memmove, memcpy and xor over regions of physical memory such as the framebuffer. This is the simplest way to get usable framebuffer speed from SLOF since the framebuffer isn't mapped in the VRMA and

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-24 Thread Eric Blake
On 05/24/2012 09:32 PM, Amos Kong wrote: > Convert 'sendkey' to use. do_sendkey() depends on some variables > in monitor.c, so reserve qmp_sendkey() to monitor.c > Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' > > Signed-off-by: Amos Kong > +## > +# @sendkey: > +# > +# Send keys t

[Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-24 Thread Amos Kong
Convert 'sendkey' to use. do_sendkey() depends on some variables in monitor.c, so reserve qmp_sendkey() to monitor.c Rename 'string' to 'keys', rename 'hold_time' to 'hold-time' Signed-off-by: Amos Kong --- hmp-commands.hx |4 ++-- hmp.c| 11 +++ hmp.h|

[Qemu-devel] [PATCH 2/3] fix doc of using raw values with sendkey

2012-05-24 Thread Amos Kong
(qemu) sendkey a (qemu) sendkey 0x1e (qemu) sendkey #0x1e unknown key: '#0x1e' The last command doesn't work, '#' is not request before raw values. Signed-off-by: Amos Kong --- hmp-commands.hx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-com

[Qemu-devel] [PATCH 1/3] qerror: add QERR_TOO_MANY_PARAMETERS

2012-05-24 Thread Amos Kong
Signed-off-by: Amos Kong --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 5092fe7..a5b6fd4 100644 --- a/qerror.c +++ b/qerror.c @@ -172,6 +172,10 @@ static const QErrorStringTable qerror_table[] = { .d

Re: [Qemu-devel] [RFC:kvm] export host NUMA info to guest & make emulated device NUMA attr

2012-05-24 Thread Liu ping fan
On Wed, May 23, 2012 at 11:16 PM, Michael S. Tsirkin wrote: > On Wed, May 23, 2012 at 09:52:15AM -0500, Andrew Theurer wrote: >> On 05/22/2012 04:28 AM, Liu ping fan wrote: >> >On Sat, May 19, 2012 at 12:14 AM, Shirley Ma  wrote: >> >>On Thu, 2012-05-17 at 17:20 +0800, Liu Ping Fan wrote: >> >>>Cu

Re: [Qemu-devel] [RFC PATCH] PCI: Introduce INTx check & mask API

2012-05-24 Thread Alexey Kardashevskiy
On 25/05/12 12:29, Jan Kiszka wrote: > On 2012-05-24 22:18, Alexey Kardashevskiy wrote: >> On 24/05/12 22:02, Jan Kiszka wrote: >>> On 2012-05-24 04:44, Alexey Kardashevskiy wrote: [Found while debugging VFIO on POWER but it is platform independent] There is a feature in PCI (>=2.3?)

[Qemu-devel] Tracing message for mu

2012-05-24 Thread Charles . Tsai-蔡清海-研究發展部
Hi Stefan, I had a problem to launch the VM using the script that contains the Qemu options. My script used to work before updating the latest Qemu code suggested by Hans. I also tried to latest code from Freedesktop, it still failed to work either. Obviously, Qemu was broken somewhere in the c

Re: [Qemu-devel] [PATCH 10/15] Openrisc: add a simulation board

2012-05-24 Thread Jia Liu
On Thu, May 24, 2012 at 3:17 AM, Blue Swirl wrote: > On Wed, May 23, 2012 at 7:54 AM, Jia Liu wrote: >> Hi Blue, >> >> On Sat, May 19, 2012 at 3:51 PM, Blue Swirl wrote: >>> On Thu, May 17, 2012 at 8:35 AM, Jia Liu wrote: add a simulation board for openrisc. Signed-off-by: Jia Li

Re: [Qemu-devel] [RFC PATCH] PCI: Introduce INTx check & mask API

2012-05-24 Thread Jan Kiszka
On 2012-05-24 22:18, Alexey Kardashevskiy wrote: > On 24/05/12 22:02, Jan Kiszka wrote: >> On 2012-05-24 04:44, Alexey Kardashevskiy wrote: >>> [Found while debugging VFIO on POWER but it is platform independent] >>> >>> There is a feature in PCI (>=2.3?) to mask/unmask INTx via PCI_COMMAND and >>>

Re: [Qemu-devel] [PATCH] vfio-powerpc: enabled and supported on power

2012-05-24 Thread Alexey Kardashevskiy
On 25/05/12 01:12, Alex Williamson wrote: > On Thu, 2012-05-24 at 13:10 +1000, Alexey Kardashevskiy wrote: >> The patch introduces support of VFIO on POWER. >> >> The patch consists of: >> >> 1. IOMMU driver for VFIO. >> It does not use IOMMU API at all, instead it calls POWER >> IOMMU API directly

Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-24 Thread Andreas Färber
Am 21.05.2012 21:24, schrieb Alexander Graf: > > On 21.05.2012, at 18:31, Andreas Färber wrote: > >> [...] I believe >> op_helper.c is dropped in Blue's AREG0 conversion, so I would recommend >> to rebase on that, since rebasing the large code movements was kind of >> nasty. Now that we've fixed

Re: [Qemu-devel] [PATCH 05/15] Openrisc: add exception support

2012-05-24 Thread Jia Liu
On Thu, May 24, 2012 at 3:11 AM, Blue Swirl wrote: > On Wed, May 23, 2012 at 7:09 AM, Jia Liu wrote: >> Hi Blue, >> >> On Sat, May 19, 2012 at 3:22 PM, Blue Swirl wrote: >>> On Thu, May 17, 2012 at 8:35 AM, Jia Liu wrote: add the openrisc exception support. Signed-off-by: Jia Liu

Re: [Qemu-devel] [RFC PATCH] PCI: Introduce INTx check & mask API

2012-05-24 Thread Alexey Kardashevskiy
On 24/05/12 22:02, Jan Kiszka wrote: > On 2012-05-24 04:44, Alexey Kardashevskiy wrote: >> [Found while debugging VFIO on POWER but it is platform independent] >> >> There is a feature in PCI (>=2.3?) to mask/unmask INTx via PCI_COMMAND and >> PCI_STATUS registers. > > Yes, 2.3 introduced this. Ma

Re: [Qemu-devel] [RFC PATCH] PCI: Introduce INTx check & mask API

2012-05-24 Thread Alexey Kardashevskiy
On 25/05/12 00:41, Alex Williamson wrote: >>> [Found while debugging VFIO on POWER but it is platform independent] >>> >>> There is a feature in PCI (>=2.3?) to mask/unmask INTx via PCI_COMMAND and >>> PCI_STATUS registers. >> >> Yes, 2.3 introduced this. Masking is done via command register, chec

Re: [Qemu-devel] [PATCH v3 13/16] net: Make the monitor output more reasonable hub info

2012-05-24 Thread Zhi Yong Wu
On Fri, May 25, 2012 at 4:34 AM, Jan Kiszka wrote: > On 2012-05-24 14:59, zwu.ker...@gmail.com wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >>  net.c     |    7 ++- >>  net/hub.c |    2 +- >>  2 files changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/net.c b/

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-24 Thread Zhi Yong Wu
On Fri, May 25, 2012 at 4:53 AM, Luiz Capitulino wrote: > On Fri, 25 May 2012 01:59:06 +0800 > zwu.ker...@gmail.com wrote: > >> From: Zhi Yong Wu >> >> The patchset implements network hub stead of vlan. The main work was done by >> stefan, and i rebased it to latest QEMU upstream, did some testi

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread TeLeMan
On Fri, May 25, 2012 at 3:51 AM, Anthony Liguori wrote: > On 05/24/2012 02:42 PM, Stefan Weil wrote: >> >> Am 24.05.2012 20:36, schrieb Anthony Liguori: >>> >>> On 05/24/2012 01:12 PM, Stefan Weil wrote: This discussion looks strange for me. >>> >>> >>> I'm not going to commit patches wi

Re: [Qemu-devel] [PATCH] vfio-powerpc: enabled and supported on power

2012-05-24 Thread Benjamin Herrenschmidt
On Thu, 2012-05-24 at 09:12 -0600, Alex Williamson wrote: > > --- /dev/null > > +++ b/arch/powerpc/kernel/iommu_vfio.c > > Should this be drivers/vfio/vfio_iommu_powerpc.c? Very minor bike shed painting... too long file names suck, in this case what's the point of the "vfio" prefix for files alr

Re: [Qemu-devel] [PATCH 02/10] qdev: remove qdev_prop_exists

2012-05-24 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > Can be replaced everywhere with object_property_find. > > Signed-off-by: Paolo Bonzini [...] > diff --git a/include/qemu/object.h b/include/qemu/object.h > index 5fd2270..b7efc63 100644 > --- a/include/qemu/object.h > +++ b/include/qemu/object.h > @@

Re: [Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-24 Thread Luiz Capitulino
On Fri, 25 May 2012 01:59:06 +0800 zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > The patchset implements network hub stead of vlan. The main work was done by > stefan, and i rebased it to latest QEMU upstream, did some testings and am > responsible for pushing it to QEMU upstream. Hones

Re: [Qemu-devel] [PATCH v3 13/16] net: Make the monitor output more reasonable hub info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 14:59, zwu.ker...@gmail.com wrote: > From: Zhi Yong Wu > > Signed-off-by: Zhi Yong Wu > --- > net.c |7 ++- > net/hub.c |2 +- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/net.c b/net.c > index 61dc28d..79ac51f 100644 > --- a/net.c > +++ b/n

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 6:26 PM, Avi Kivity wrote: > On 05/24/2012 05:11 PM, Max Filippov wrote: >>> >>> Not in breakpoint_invalidate as the missing offset was compensated >>> before your commit (well, starting with c2f07f81a2 in fact). >> >> I'd say that compensation that you mention >> >>     ra

Re: [Qemu-devel] [PATCH 1/1 v4] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-24 Thread Crístian Viana
On 23-05-2012 17:54, Peter Maydell wrote: The point is that your snprintf is not actually using the full power of a format string parser, it's just concatenating two strings ("QEMU " and the version). The simple way to put two strings into a buffer one after the other is to copy string A and then

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Anthony Liguori
On 05/24/2012 02:42 PM, Stefan Weil wrote: Am 24.05.2012 20:36, schrieb Anthony Liguori: On 05/24/2012 01:12 PM, Stefan Weil wrote: This discussion looks strange for me. I'm not going to commit patches with a Signed-off-by if I know the name is an alias. DCO requires the use of a real name.

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Stefan Weil
Am 24.05.2012 20:36, schrieb Anthony Liguori: On 05/24/2012 01:12 PM, Stefan Weil wrote: This discussion looks strange for me. I'm not going to commit patches with a Signed-off-by if I know the name is an alias. DCO requires the use of a real name. DCO is an important part of ensuring the

[Qemu-devel] [PATCH v3 05/16] net: Drop vlan argument to qemu_new_net_client()

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

[Qemu-devel] [PATCH v3 06/16] net: Remove vlan qdev property

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

[Qemu-devel] [PATCH 2/2] qemu-ga: Fix missing environ declaration

2012-05-24 Thread Michael Roth
From: Luiz Capitulino Commit 3674838cd05268954bb6473239cd7f700a79bf0f uses the environ global variable, but is relying on environ to be declared somewhere else. This worked for me because on F16 environ is declared in , but that doesn't happen in OpenBSD for example, causing a build failure. Th

[Qemu-devel] [PATCH 1/2] configure: check if environ is declared

2012-05-24 Thread Michael Roth
From: Luiz Capitulino Some systems may declare environ automatically, others don't. Check for it. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- configure | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/configure b/configure index b5

[Qemu-devel] [PULL 1.1] qemu-ga build fix for OpenBSD

2012-05-24 Thread Michael Roth
The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d: audio: Always call fini on exit (2012-05-24 19:35:27 +0400) are available in the git repository at: git://github.com/mdroth/qemu.git qga-pull-5-24-12 Luiz Capitulino (2): configure: check if environ is declare

[Qemu-devel] [PATCH v3 03/16] net: Look up 'vlan' net clients using hubs

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |5 +++-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/ne

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Anthony Liguori
On 05/24/2012 01:12 PM, Stefan Weil wrote: Am 24.05.2012 15:35, schrieb Andreas Färber: Am 24.05.2012 04:12, schrieb TeLeMan: I won't use my Chinese name because I think it's my privacy. That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for

[Qemu-devel] [PATCH v3 11/16] net: Rename vc local variables to nc

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |

[Qemu-devel] [PATCH v3 14/16] net: cleanup deliver/deliver_iov func pointers

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 insertions(+), 48 deletions(-) diff --git a/net.c b/net.c index 7

[Qemu-devel] [PATCH v3 13/16] net: Make the monitor output more reasonable hub info

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net.c |7 ++- net/hub.c |2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/net.c b/net.c index 61dc28d..79ac51f 100644 --- a/net.c +++ b/net.c @@ -887,6 +887,12 @@ static const struct { }, }, #end

[Qemu-devel] [PATCH v3 15/16] net: determine if packets can be sent before net queue deliver packets

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/queue.c |8 net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 4 insertions(+), 17 deletions(-) diff --git a/net/queue.c b/net/queue.c index 0afd783..7484d2a 100644 -

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Stefan Weil
Am 24.05.2012 15:35, schrieb Andreas Färber: Am 24.05.2012 04:12, schrieb TeLeMan: I won't use my Chinese name because I think it's my privacy. That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for your actions, not hiding in anonymity. It's

[Qemu-devel] [PATCH v3 16/16] hub: add the support for hub own flow control

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/hub.c | 35 --- net/hub.h |2 ++ net/queue.c |5 + 3 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/hub.c b/net/hub.c index 8a583ab..d27c52a 100644 --- a/net/hub.c +++ b/net

[Qemu-devel] [PATCH v3 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepr

[Qemu-devel] [PATCH v3 08/16] net: Remove VLANState

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 127 ++--- net.h |8 net/socket.c |6 +- net/tap.c |6 +- net/

[Qemu-devel] [PATCH v3 09/16] net: Rename non_vlan_clients to net_clients

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Si

[Qemu-devel] [PATCH v3 07/16] net: Remove vlan code from net.c

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [PATCH v3 04/16] hub: Check that hubs are configured correctly

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

[Qemu-devel] [PATCH v3 00/16] net: hub-based networking

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu The patchset implements network hub stead of vlan. The main work was done by stefan, and i rebased it to latest QEMU upstream, did some testings and am responsible for pushing it to QEMU upstream. Changelog from v2: 1.) add the support for hub own flow control [paolo] 2.)

[Qemu-devel] [PATCH v3 02/16] net: Use hubs for the vlan feature

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 46 ++

[Qemu-devel] [PATCH v3 01/16] net: Add a hub net client

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu -

Re: [Qemu-devel] [PATCH 01/10] qdev: remove PropertyInfo range checking

2012-05-24 Thread Andreas Färber
Am 23.05.2012 17:44, schrieb Paolo Bonzini: > Range checking in PropertyInfo is now used only for pci_devfn > properties and some error reporting. Remove all code that implements > it in the various property types, and the now unused fields. > > Signed-off-by: Paolo Bonzini > --- > hw/qdev-prop

[Qemu-devel] [PATCH v2 1/3] monitor: remove unused do_info_trace

2012-05-24 Thread Harsh Prateek Bora
Going forward with simpletrace v2 variable size trace records, we cannot have a generic function to print trace event info and therefore this interface becomes invalid. As per Stefan Hajnoczi: "This command is only available from the human monitor. It's not very useful because it historically ha

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-24 Thread Markus Armbruster
Markus Armbruster writes: > Anthony Liguori writes: > >> On 05/11/2012 10:22 AM, Markus Armbruster wrote: [...] >>> diff --git a/hw/fdc.c b/hw/fdc.c >>> index d9c4fbf..98ff87a 100644 >>> --- a/hw/fdc.c >>> +++ b/hw/fdc.c >>> @@ -54,6 +54,33 @@ >>> /*

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-24 Thread Eric Blake
On 05/24/2012 07:41 AM, Paolo Bonzini wrote: > changes from v1: > - added per-job iostatus > - added description of persistent dirty bitmap > > The same content is also at > http://wiki.qemu.org/Features/LiveBlockMigration/1.2 > > * query-block-jobs: BlockJobInfo gets two new fields, paused and

Re: [Qemu-devel] [PATCH 21/21] qbus: initialize in standard way

2012-05-24 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > From: Anthony Liguori > > Signed-off-by: Anthony Liguori > Signed-off-by: Paolo Bonzini Thanks, applied to qom-next (extending the commit message): http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Andreas -- SUSE LINUX Products

Re: [Qemu-devel] [PATCH 20/21] qbus: make child devices links

2012-05-24 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > From: Anthony Liguori > > Make qbus children show up as link<> properties. There is no stable > addressing > for qbus children so we use an unstable naming convention. > > This is okay in QOM though because the composition name is expected to be >

Re: [Qemu-devel] [PATCH 18/21] qdev: convert busses to QEMU Object Model

2012-05-24 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > From: Anthony Liguori > > This is far less interesting than it sounds. We simply add an Object to each > BusState and then register the types appropriately. Most of the interesting > refactoring will follow in the next patches. > > Since we're chan

Re: [Qemu-devel] [PATCH 19/21] qdev: connect busses with their parent devices

2012-05-24 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > From: Anthony Liguori > > This makes sysbus part of the root hierarchy and all busses children of their > respective parent DeviceState. > > Signed-off-by: Anthony Liguori > Signed-off-by: Paolo Bonzini Thanks, applied to qom-next: http://repo.or.

Re: [Qemu-devel] [PATCH 17/21] qdev: move sysbus initialization to sysbus.c

2012-05-24 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > TYPE_SYSTEM_BUS will be local to hw/sysbus.c, so move existing references > to main_system_bus and system_bus_info there. > > Signed-off-by: Paolo Bonzini Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next

Re: [Qemu-devel] [PATCH 16/21] qdev: use wrapper for qdev_get_path

2012-05-24 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > From: Anthony Liguori > > This makes it easier to remove it from BusInfo. > > Signed-off-by: Anthony Liguori > Signed-off-by: Paolo Bonzini Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next Andreas -

Re: [Qemu-devel] [PATCH 14/21] qdev: remove qdev_prop_set_defaults

2012-05-24 Thread Andreas Färber
Am 02.05.2012 14:30, schrieb Anthony Liguori: > On 05/02/2012 06:31 AM, Paolo Bonzini wrote: >> Instead, qdev_property_add_static can set the default. >> >> Signed-off-by: Paolo Bonzini > > Great idea! > > Reviewed-by: Anthony Liguori Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerb

Re: [Qemu-devel] [PATCH 13/21] qdev: clean up global properties

2012-05-24 Thread Andreas Färber
Am 02.05.2012 13:31, schrieb Paolo Bonzini: > Now that global properties do not depend on buses anymore, set > them directly in the device instance_init function. > > Signed-off-by: Paolo Bonzini Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next And

[Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
For all devices print id, mode and guest_bug status. Known problems: Prints devices from highest id to lowest. Signed-off-by: Alon Levy --- This one builds. Fixed qapi-schema to say additions are for 1.2 hmp.c| 11 +++ hw/qxl.c | 22 ++ qapi-

[Qemu-devel] [PATCH 2/2] hw/qxl: ignore guest from guestbug until reset

2012-05-24 Thread Alon Levy
soft_reset is called from any of: * QXL_IO_RESET * vga io * pci reset handler Signed-off-by: Alon Levy --- hw/qxl.c | 13 - hw/qxl.h |3 +++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 5a7be60..b5e53ce 100644 --- a/hw/qxl.c +++ b/

[Qemu-devel] [PATCH 1/2] qxl: stop dirty loging when not in vga mode

2012-05-24 Thread Alon Levy
Tested with linux guest. Not sure how to check actual performance affect of this. Checked with the previously send traceevent that the kvm ioctl to start/stop dirty logging is being called. (KVM_SET_USER_MEMORY_REGION). Signed-off-by: Alon Levy --- These are the two patches to queue instead of th

Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
On Thu, May 24, 2012 at 02:58:40PM +0200, Gerd Hoffmann wrote: > On 05/24/12 11:38, Alon Levy wrote: > > For all devices print id, mode and guest_bug status. > > Queued up 1+2+4 Please unqueue "qxl: stop dirty loging when not in vga mode" and I'll send it again with the separate patch "hw/qxl: ig

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-24 Thread Dor Laor
On 05/24/2012 05:19 PM, Paolo Bonzini wrote: Il 24/05/2012 16:00, Ori Mamluk ha scritto: The dirty bitmap is managed by these QMP commands: * blockdev-dirty-enable: takes a file name used for the dirty bitmap, and an optional granularity. Setting the granularity will not be supported in the

Re: [Qemu-devel] [PATCH v2] audio: Always call fini on exit

2012-05-24 Thread malc
On Thu, 24 May 2012, Jan Kiszka wrote: > Not only clean up enabled voices but any registered one. Backends like > pulsaudio rely on unconditional fini handler invocations. > > This fixes "Memory pool destroyed but not all memory blocks freed!" > warnings on VM shutdowns when pa is used and lockup

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Igor Mammedov
On 05/24/2012 04:01 PM, Andreas Färber wrote: Am 24.05.2012 15:48, schrieb Igor Mammedov: On 05/24/2012 03:04 PM, Anthony Liguori wrote: I'm not sure how I feel about this. I never intended for a user to be able to create objects that were arbitrary children of other objects. In some ways, I

Re: [Qemu-devel] [PATCH v8 2/2] PCI: acpiphp: remove all functions in slot, even without ACPI _EJx

2012-05-24 Thread Bjorn Helgaas
On Wed, May 23, 2012 at 1:03 AM, Amos Kong wrote: > On Wed, May 23, 2012 at 1:29 PM, Yinghai Lu wrote: >> On Tue, May 22, 2012 at 10:15 PM, Amos Kong wrote: >>> Attached the v7,  test passed. >> >> would be better to have break... > > Yeah. Otherwise, it will delete from the last function. > Att

[Qemu-devel] [PATCH] qemu-iotests: mark 035 qcow2-only

2012-05-24 Thread Stefan Hajnoczi
The 035 parallel aio write test relies on knowledge of qcow2 metadata layout to stress parallel L2 table accesses. This only works for qcow2 unless we add additional calculations for qed or other formats. Mark this test as qcow2-only. Note that the test is strictly speaking non-deterministic alt

Re: [Qemu-devel] [PATCH] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
On Thu, May 24, 2012 at 06:09:51PM +0300, Alon Levy wrote: > For all devices print id, mode and guest_bug status. > > Known problems: Prints devices from highest id to lowest. > > Signed-off-by: Alon Levy > --- > Fixed the documentation to match the command (no more qxl0). > > Sending to QMP ma

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Michael Roth
On Thu, May 24, 2012 at 04:24:53PM +0200, Markus Armbruster wrote: > Anthony Liguori writes: > > > On 05/24/2012 06:43 AM, Markus Armbruster wrote: > >> To create objects via QMP. > >> > >> Test case: > >> > >> $ upstream-qemu --enable-kvm -S -m 384 -vnc :0 -monitor stdio -chardev > >> socket,id

Re: [Qemu-devel] [PATCH] vfio-powerpc: enabled and supported on power

2012-05-24 Thread Alex Williamson
On Thu, 2012-05-24 at 13:10 +1000, Alexey Kardashevskiy wrote: > The patch introduces support of VFIO on POWER. > > The patch consists of: > > 1. IOMMU driver for VFIO. > It does not use IOMMU API at all, instead it calls POWER > IOMMU API directly (ppc_md callbacks). > > 2. A piece of code (mod

[Qemu-devel] [PATCH] hmp/qxl: info spice: add qxl info

2012-05-24 Thread Alon Levy
For all devices print id, mode and guest_bug status. Known problems: Prints devices from highest id to lowest. Signed-off-by: Alon Levy --- Fixed the documentation to match the command (no more qxl0). Sending to QMP maintainers per Kraxel's request for an additional ack. Alon hmp.c

[Qemu-devel] [PATCH v2] audio: Always call fini on exit

2012-05-24 Thread Jan Kiszka
Not only clean up enabled voices but any registered one. Backends like pulsaudio rely on unconditional fini handler invocations. This fixes "Memory pool destroyed but not all memory blocks freed!" warnings on VM shutdowns when pa is used and lockups of QEMU on shutdown as it got stuck on some pa-i

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:51, Zhi Yong Wu wrote: > On Thu, May 24, 2012 at 10:43 PM, Jan Kiszka wrote: >> On 2012-05-24 11:38, Zhi Yong Wu wrote: >>> On Thu, May 24, 2012 at 10:31 PM, Jan Kiszka wrote: On 2012-05-24 11:27, Zhi Yong Wu wrote: > On Thu, May 24, 2012 at 10:25 PM, Jan Kiszka >

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 10:43 PM, Jan Kiszka wrote: > On 2012-05-24 11:38, Zhi Yong Wu wrote: >> On Thu, May 24, 2012 at 10:31 PM, Jan Kiszka wrote: >>> On 2012-05-24 11:27, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 10:25 PM, Jan Kiszka wrote: > Something mangled your reply and m

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Peter Maydell
On 24 May 2012 15:35, Anthony Liguori wrote: > Ah, okay.  So you're taking those comments a bit out of context. > > The right way to use object_new() is: > > Object *foo = object_new(TYPE_E1000); > > If you mistype TYPE_E1000, you should get a compile failure.  There's > basically no way that this

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 10:43 PM, Jan Kiszka wrote: > On 2012-05-24 11:38, Zhi Yong Wu wrote: >> On Thu, May 24, 2012 at 10:31 PM, Jan Kiszka wrote: >>> On 2012-05-24 11:27, Zhi Yong Wu wrote: On Thu, May 24, 2012 at 10:25 PM, Jan Kiszka wrote: > Something mangled your reply and m

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Markus Armbruster
Andreas Färber writes: > Am 24.05.2012 16:08, schrieb Markus Armbruster: >> Andreas Färber writes: >> >>> Am 24.05.2012 13:43, schrieb Markus Armbruster: Beware: second patch is the product of voodoo-coding. >>> >>> Hm, I don't like the voodoo. ;) I would rather expose a proper C API >>> l

Re: [Qemu-devel] [PATCH 6/6] softmmu-semi: fix lock_user* functions not to deref NULL upon OOM

2012-05-24 Thread Jim Meyering
Peter Maydell wrote: > On 16 May 2012 14:08, Jim Meyering wrote: >> From: Jim Meyering >> >> Use g_malloc/g_free in place of malloc/free. >> >> Signed-off-by: Jim Meyering >> --- >>  softmmu-semi.h | 6 +++--- >>  1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/softmmu-semi.h

[Qemu-devel] [PATCH v2 6/6] softmmu-semi: fix lock_user* functions not to deref NULL upon OOM

2012-05-24 Thread Jim Meyering
Return NULL upon malloc failure. Signed-off-by: Jim Meyering --- Improved based on suggestion from Peter Maydell: Handle malloc failure rather than relying on g_malloc, since we can't afford to let guest-provided "len" induce g_malloc's abort. softmmu-semi.h | 5 - 1 file changed, 4 insert

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:38, Zhi Yong Wu wrote: > On Thu, May 24, 2012 at 10:31 PM, Jan Kiszka wrote: >> On 2012-05-24 11:27, Zhi Yong Wu wrote: >>> On Thu, May 24, 2012 at 10:25 PM, Jan Kiszka wrote: Something mangled your reply and made it unreadable. Please retry. >>> Sorry. let it look like belo

Re: [Qemu-devel] [RFC PATCH] PCI: Introduce INTx check & mask API

2012-05-24 Thread Alex Williamson
On Thu, 2012-05-24 at 09:02 -0300, Jan Kiszka wrote: > On 2012-05-24 04:44, Alexey Kardashevskiy wrote: > > [Found while debugging VFIO on POWER but it is platform independent] > > > > There is a feature in PCI (>=2.3?) to mask/unmask INTx via PCI_COMMAND and > > PCI_STATUS registers. > > Yes, 2.

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 10:31 PM, Jan Kiszka wrote: > On 2012-05-24 11:27, Zhi Yong Wu wrote: >> On Thu, May 24, 2012 at 10:25 PM, Jan Kiszka wrote: >>> Something mangled your reply and made it unreadable. Please retry. >> Sorry. let it look like below. Do you think of it? typ=hubport >> >> (qemu

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Anthony Liguori
On 05/24/2012 09:23 AM, Peter Maydell wrote: On 24 May 2012 15:10, Anthony Liguori wrote: On 05/24/2012 08:18 AM, Peter Maydell wrote: Last time I was trying to argue for keeping the "create, set properties, realize" interface for devices/objects as simple as possible you wanted it to have an

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:29, Max Filippov wrote: > On Thu, May 24, 2012 at 6:21 PM, Jan Kiszka wrote: >> On 2012-05-24 11:11, Max Filippov wrote: >>> On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka wrote: On 2012-05-24 09:42, Max Filippov wrote: > On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka >

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:27, Zhi Yong Wu wrote: > On Thu, May 24, 2012 at 10:25 PM, Jan Kiszka wrote: >> Something mangled your reply and made it unreadable. Please retry. > Sorry. let it look like below. Do you think of it? typ=hubport > > (qemu) info network > virtio-net-pci.0: type=nic,model=virtio-

Re: [Qemu-devel] [PATCH RFC 0/2] QMP command qom-new

2012-05-24 Thread Andreas Färber
Am 24.05.2012 16:08, schrieb Markus Armbruster: > Andreas Färber writes: > >> Am 24.05.2012 13:43, schrieb Markus Armbruster: >>> Beware: second patch is the product of voodoo-coding. >> >> Hm, I don't like the voodoo. ;) I would rather expose a proper C API >> like object_try_new(const char *, E

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Max Filippov
On Thu, May 24, 2012 at 6:21 PM, Jan Kiszka wrote: > On 2012-05-24 11:11, Max Filippov wrote: >> On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka wrote: >>> On 2012-05-24 09:42, Max Filippov wrote: On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka wrote: > On 2012-05-24 09:08, Max Filippov wrote:

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Zhi Yong Wu
On Thu, May 24, 2012 at 10:25 PM, Jan Kiszka wrote: > Something mangled your reply and made it unreadable. Please retry. Sorry. let it look like below. Do you think of it? typ=hubport (qemu) info network virtio-net-pci.0: type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56 \ hub0port0: t

Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

2012-05-24 Thread Avi Kivity
On 05/24/2012 05:11 PM, Max Filippov wrote: >> >> Not in breakpoint_invalidate as the missing offset was compensated >> before your commit (well, starting with c2f07f81a2 in fact). > > I'd say that compensation that you mention > > ram_addr = (memory_region_get_ram_addr(section.mr) >

Re: [Qemu-devel] [PATCH v2 13/15] net: Remove obsolete vlan info

2012-05-24 Thread Jan Kiszka
On 2012-05-24 11:14, Zhi Yong Wu wrote: >>> For this output, we can't find which port peers with which emulated >>> NIC or network backend. >> >> Why? This information should be available at least in the hubs. The info > Sorry, More > 18 of 121,110 >> mystrongvpn.org/~Instant_Approval

Re: [Qemu-devel] [PATCH RFC 2/2] qmp: New command qom-new

2012-05-24 Thread Markus Armbruster
Anthony Liguori writes: > On 05/24/2012 06:43 AM, Markus Armbruster wrote: >> To create objects via QMP. >> >> Test case: >> >> $ upstream-qemu --enable-kvm -S -m 384 -vnc :0 -monitor stdio -chardev >> socket,id=qmp,path=test-qmp,server=on,wait=off -mon mode=control,chardev=qmp >> >> Conversatio

  1   2   >