Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions

2012-06-24 Thread Blue Swirl
On Fri, Jun 22, 2012 at 3:29 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: The emulated devices can run simultaneously with the guest, so we need to be careful with ordering of load and stores done by them to the guest system memory, which need to be observed in the right order by

Re: [Qemu-devel] [PATCH 2/2] Creating qemu-seccomp.[ch] and adding call to vl.c

2012-06-24 Thread Blue Swirl
On Thu, Jun 21, 2012 at 10:10 PM, Eduardo Otubo ot...@linux.vnet.ibm.com wrote: I added a syscall struct using priority levels as described in the libseccomp man page. The priority numbers are based to the frequency they appear in a sample strace from a regular qemu guest run under libvirt.

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-24 Thread Blue Swirl
On Fri, Jun 22, 2012 at 9:58 AM, Xin Tong xerox.time.t...@gmail.com wrote: It is a pity that QEMU does not outline the TLB lookup code. I do not know how much impact the inlined TLB code has due to icache misses... With a test case the impact could be measured. Maybe it could be just a program

Re: [Qemu-devel] [PATCH v6 5/6] fdc_test: update media_change test

2012-06-24 Thread Blue Swirl
On Fri, Jun 22, 2012 at 10:33 AM, Pavel Hrdina phrd...@redhat.com wrote: After rewrite DSKCHG bit handling the test has to be updated. Now is needed to seek to different track to clear DSKCHG bit. Signed-off-by: Pavel Hrdina phrd...@redhat.com ---  tests/fdc-test.c |   29

Re: [Qemu-devel] [RFC] migration next tree

2012-06-24 Thread Orit Wasserman
On 06/22/2012 11:43 PM, Vinod Chegu wrote: On Fri, Jun 22, 2012 at 6:59 AM, Juan Quintela quint...@redhat.com mailto:quint...@redhat.com wrote: Hi As discussed on this week kvm call, here are the migration tree with XBRLE + huge memory fixes integrated. There were a

Re: [Qemu-devel] [PATCH 2/2] cpu: for cpu-user and cpu-softmmu and make cpu-softmmu a child of DeviceState

2012-06-24 Thread Blue Swirl
On Sat, Jun 23, 2012 at 2:00 PM, Andreas Färber afaer...@suse.de wrote: Am 22.06.2012 21:36, schrieb Anthony Liguori: The line between linux-user and softmmu is not very well defined right now. linux-user really don't want to include devices and making CpuState a child of DeviceState would

Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions

2012-06-24 Thread Benjamin Herrenschmidt
On Sun, 2012-06-24 at 06:03 +, Blue Swirl wrote: + * A smarter implementation can be devised if needed to + * use lighter barriers based on the direction of the + * transfer, the DMA context, etc... + */ +if (kvm_enabled()) +smp_mb(); Missing braces.

[Qemu-devel] running qemu with image file on a block device

2012-06-24 Thread udit agarwal
Hi, I have set up a block device of 20G on my hard drive and is located at /dev/sda2. Now I have created a raw image inside this device via command: hp1:~ # qemu-img create -f raw /dev/sda2:server.img 10G Then I copied the iso file on this device via command: hp1:~# cp ~/CD.iso /dev/sda2:CD,iso

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Avi Kivity
On 06/23/2012 02:45 PM, Jan Kiszka wrote: Hmm, we may need the iothread lock around cpu_set_apic_tpr for !kvm_irqchip_in_kernel(). And as we are at it, apic_base manipulation can be but there as well. With in-kernel irqchip, there is no such need. Also, no one accesses eflags outside of

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-24 Thread Arndt Kritzner
Booting in safe mode works, but only without networking. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014681 Title: BSOD with newer host kernels (x64) and W2k8S guest (x64) Status in QEMU:

Re: [Qemu-devel] [PULL 0/4] s390 patch queue 2012-06-18

2012-06-24 Thread Blue Swirl
On Mon, Jun 18, 2012 at 1:36 PM, Alexander Graf ag...@suse.de wrote: Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Thanks, pulled. Alex The following changes since commit eb2aeacf983a2a88a2b31e8fee067c38bd10abd3:  malc (1):        audio/winwave: Fix typo

Re: [Qemu-devel] [PULL 00/16] arm-devs queue

2012-06-24 Thread Blue Swirl
On Tue, Jun 19, 2012 at 1:30 PM, Peter Maydell peter.mayd...@linaro.org wrote: Hi; this is an arm-devs pullreq which mostly has patches which I've had queued since before freeze and my holiday. (I had to make a trivial fix to one of the GIC patches to account for the list of object files

Re: [Qemu-devel] [PULL 00/33] target-arm queue

2012-06-24 Thread Blue Swirl
On Wed, Jun 20, 2012 at 12:26 PM, Peter Maydell peter.mayd...@linaro.org wrote: This is a pullreq for outstanding target-arm patches. In fact it only has my cp15 rework series in it. (No changes in that since the v2 series I sent out some weeks back except for a tiny trivial fix for a textual

Re: [Qemu-devel] [PATCH] tci: don't write zero for reloc in tci_out_label

2012-06-24 Thread Blue Swirl
Thanks, applied. On Tue, Jun 19, 2012 at 2:31 AM, Scott Wood scottw...@freescale.com wrote: If tci_out_label is called in the context of tcg_gen_code_search_pc, we could be overwriting an already patched relocation with zero -- and not repatch it because the set_label is past search_pc,

Re: [Qemu-devel] [PULL 00/72] ppc patch queue 2012-06-24

2012-06-24 Thread Blue Swirl
On Sat, Jun 23, 2012 at 11:06 PM, Alexander Graf ag...@suse.de wrote: Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. Thanks, pulled. Alex The following changes since commit affe5189907f397514cdd4ee7446595c1246a0e9:  Alexander Graf (1):        TCG: Fix compile

Re: [Qemu-devel] [PATCH] make: Fix dependencies for fpu/*.c and tcg/*.c

2012-06-24 Thread Blue Swirl
Thanks, applied. On Thu, Jun 21, 2012 at 8:18 PM, Stefan Weil s...@weilnetz.de wrote: Commit dcff25f2cd8c11a9368cc2369aeb0319c32d9e26 removed too many *.d files. The directories fpu/ and tcg/ still don't use the recursive subdir rules. Signed-off-by: Stefan Weil s...@weilnetz.de ---  

Re: [Qemu-devel] [PATCH] qemu-log: Add GCC format attribute

2012-06-24 Thread Blue Swirl
Thanks, applied. On Sat, Jun 23, 2012 at 6:41 PM, Stefan Weil s...@weilnetz.de wrote: The new inline function qemu_log_vprintf should use this attribute. Signed-off-by: Stefan Weil s...@weilnetz.de ---  qemu-log.h |    3 ++-  1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread liu ping fan
On Sat, Jun 23, 2012 at 7:45 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-06-23 11:06, Marcelo Tosatti wrote: On Fri, Jun 22, 2012 at 09:22:59PM -0300, Marcelo Tosatti wrote: On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: Should have declared this [RFC] in the subject and CC'ed

Re: [Qemu-devel] [PATCH 1/2] CPUArchState: introduce per-cpu lock

2012-06-24 Thread liu ping fan
On Fri, Jun 22, 2012 at 8:55 PM, Andreas Färber afaer...@suse.de wrote: Am 21.06.2012 17:06, schrieb Liu Ping Fan: introduce a lock for per-cpu to protect agaist accesing from other vcpu thread. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com ---  cpu-defs.h  |    2 ++  cpus.c      

[Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug

2012-06-24 Thread Stefan Weil
The order of the arguments was wrong (copy+paste error). Signed-off-by: Stefan Weil s...@weilnetz.de --- Hi Alex, hi Blue, there is still one more bug for target-ppc with --enable-debug, so strictly speaking, the subject is not correct: the patch fixes the build only partially. Regards, Stefan

Re: [Qemu-devel] [PATCH 1/2] CPUArchState: introduce per-cpu lock

2012-06-24 Thread liu ping fan
On Fri, Jun 22, 2012 at 8:36 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Jun 21, 2012 at 4:06 PM, Liu Ping Fan qemul...@gmail.com wrote: diff --git a/cpu-defs.h b/cpu-defs.h index f49e950..7305822 100644 --- a/cpu-defs.h +++ b/cpu-defs.h @@ -30,6 +30,7 @@  #include osdep.h  

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Jan Kiszka
On 2012-06-24 10:49, Avi Kivity wrote: On 06/23/2012 02:45 PM, Jan Kiszka wrote: Hmm, we may need the iothread lock around cpu_set_apic_tpr for !kvm_irqchip_in_kernel(). And as we are at it, apic_base manipulation can be but there as well. With in-kernel irqchip, there is no such need.

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Jan Kiszka
On 2012-06-24 15:34, liu ping fan wrote: On Sat, Jun 23, 2012 at 7:45 PM, Jan Kiszka jan.kis...@web.de wrote: On 2012-06-23 11:06, Marcelo Tosatti wrote: On Fri, Jun 22, 2012 at 09:22:59PM -0300, Marcelo Tosatti wrote: On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: Should have

Re: [Qemu-devel] [PATCH 2/2] kvm: use per-cpu lock to free vcpu thread out of the big lock

2012-06-24 Thread liu ping fan
With this patch, the iothread lock will be only hold around 1.kvm_flush_coalesced_mmio_buffer(); 2.kvm_handle_io(); 3.cpu_physical_memory_rw() And I think the cpu_lock is something which we can treat as apic_state device's lock, which the first device, we free it out of the iothread lock

[Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl

2012-06-24 Thread Stefan Weil
This fixes a compiler error when QEMU was configured with --enable-debug. Signed-off-by: Stefan Weil s...@weilnetz.de --- Alex, please review. It fixes the compiler error, but I did the change simply by comparision with other functions, so I have no idea whether it is really correct. Regards,

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Avi Kivity
On 06/24/2012 05:08 PM, Jan Kiszka wrote: On 2012-06-24 10:49, Avi Kivity wrote: On 06/23/2012 02:45 PM, Jan Kiszka wrote: Hmm, we may need the iothread lock around cpu_set_apic_tpr for !kvm_irqchip_in_kernel(). And as we are at it, apic_base manipulation can be but there as well. With

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Avi Kivity
On 06/24/2012 05:08 PM, Jan Kiszka wrote: As a first step, I will post a series later that gets rid of kvm_flush_coalesced_mmio_buffer in the common vmexit path. If you defer this, I can think of two places that need to flush: - anything that accesses those memory areas (such as DMA to the

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Jan Kiszka
On 2012-06-24 16:35, Avi Kivity wrote: On 06/24/2012 05:08 PM, Jan Kiszka wrote: As a first step, I will post a series later that gets rid of kvm_flush_coalesced_mmio_buffer in the common vmexit path. If you defer this, I can think of two places that need to flush: - anything that accesses

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Avi Kivity
On 06/24/2012 05:40 PM, Jan Kiszka wrote: On 2012-06-24 16:35, Avi Kivity wrote: On 06/24/2012 05:08 PM, Jan Kiszka wrote: As a first step, I will post a series later that gets rid of kvm_flush_coalesced_mmio_buffer in the common vmexit path. If you defer this, I can think of two places

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Jan Kiszka
On 2012-06-24 16:46, Avi Kivity wrote: On 06/24/2012 05:40 PM, Jan Kiszka wrote: On 2012-06-24 16:35, Avi Kivity wrote: On 06/24/2012 05:08 PM, Jan Kiszka wrote: As a first step, I will post a series later that gets rid of kvm_flush_coalesced_mmio_buffer in the common vmexit path. If you

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Avi Kivity
On 06/24/2012 05:51 PM, Jan Kiszka wrote: On 2012-06-24 16:46, Avi Kivity wrote: On 06/24/2012 05:40 PM, Jan Kiszka wrote: On 2012-06-24 16:35, Avi Kivity wrote: On 06/24/2012 05:08 PM, Jan Kiszka wrote: As a first step, I will post a series later that gets rid of

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Jan Kiszka
On 2012-06-24 16:56, Avi Kivity wrote: On 06/24/2012 05:51 PM, Jan Kiszka wrote: On 2012-06-24 16:46, Avi Kivity wrote: On 06/24/2012 05:40 PM, Jan Kiszka wrote: On 2012-06-24 16:35, Avi Kivity wrote: On 06/24/2012 05:08 PM, Jan Kiszka wrote: As a first step, I will post a series later that

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-24 Thread Avi Kivity
On 06/24/2012 05:58 PM, Jan Kiszka wrote: Are there really cases where the framebuffer is accessible both via MMIO and RAM-like mappings at the same time? If so, the current flushing on vmexit would help either as the direct mappings would not trigger exits. Or what do you mean? I meant

Re: [Qemu-devel] [PATCH v6 00/17] hub-based networking patchset

2012-06-24 Thread Zhi Yong Wu
pull? On Thu, Jun 21, 2012 at 9:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Jun 20, 2012 at 10:42 AM,  zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com All comments have been addressed and stefan has completed one more reviewing. For this patchset, my git

Re: [Qemu-devel] [PATCH v2 0/3] Some socket fix patches

2012-06-24 Thread Zhi Yong Wu
pull? On Wed, Jun 20, 2012 at 5:46 PM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The patchset is on top of hub-based networking patchset. For this patchset, my git repo: g...@github.com:wuzhy/qemu.git for-anthony Zhi Yong Wu (3):  net: fix the coding style

Re: [Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl

2012-06-24 Thread Alexander Graf
On 24.06.2012, at 16:18, Stefan Weil s...@weilnetz.de wrote: This fixes a compiler error when QEMU was configured with --enable-debug. Signed-off-by: Stefan Weil s...@weilnetz.de --- Alex, please review. It fixes the compiler error, but I did the change simply by comparision with other

Re: [Qemu-devel] [PATCH] target-ppc: Fix build with --enable-debug

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 2:04 PM, Stefan Weil s...@weilnetz.de wrote: The order of the arguments was wrong (copy+paste error). Confirmed, a bug with d0f1562d6ace0fdb7d2db190dd5a9a2e7492c3b3 Signed-off-by: Stefan Weil s...@weilnetz.de --- Hi Alex, hi Blue, there is still one more bug for

[Qemu-devel] [Bug 1017139] [NEW] qemu-system-i386 fails to link on linklevel

2012-06-24 Thread Nigel Horne
Public bug reported: Host: Debian Linux GCC: 4.7.1 Qemu version: 3c01ae0ea29915d165c384d0bd1cbafcf4364a4d configure flags: --enable-linux-aio Fails to link: LINK i386-softmmu/qemu-system-i386 target-i386/helper.o:helper.c:function do_inject_x86_mce: error: undefined reference to 'loglevel'

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: add guest-fstrim command

2012-06-24 Thread Christoph Hellwig
On Fri, Jun 22, 2012 at 10:48:56AM -0700, Chris Wedgwood wrote: FITRIM is a mounted filesystem feature to discard (or trim) blocks which are not in use by the filesystem. This is useful for solid-state drives (SSDs) and thinly-provisioned storage. Provide access to the feature from the

[Qemu-devel] [PATCH 0/7] esp: add AMD PCscsi emulation

2012-06-24 Thread Hervé Poussineau
This patchset adds a PCI connection to the 53c9x emulation already present in QEMU. The emulated card is the AMD PCscsi adapter, and has been tested on multiple Microsoft operating systems. Changes v1 - v2: - use qemu_log_mask(LOG_UNIMP, ...) instead of error_report() - use prefix esp_pci_* for

[Qemu-devel] [PATCH 2/9] esp: delay Transfer Information command if dma is not enabled

2012-06-24 Thread Hervé Poussineau
The same mechanism is already in place for some select commands. Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c |5 + 1 file changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index aff8de6..ac91f00 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -435,6 +435,11 @@

[Qemu-devel] [PATCH 5/9] esp: support future change of chip_id

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/esp.c b/hw/esp.c index 85078e0..a1f5b8a 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -50,6 +50,7 @@ struct ESPState { uint8_t wregs[ESP_REGS];

[Qemu-devel] [PATCH 6/9] esp: use hba_private field instead of a complex cast

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index a1f5b8a..d9dd2aa 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -186,7 +186,7 @@ static void esp_dma_enable(void *opaque, int irq,

[Qemu-devel] [PATCH 3/9] esp: implement Disable selection command

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c |6 ++ trace-events |1 + 2 files changed, 7 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index ac91f00..985a2ee 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -117,6 +117,7 @@ struct ESPState { #define CMD_SELATN

[Qemu-devel] [PATCH 4/9] esp: implement Reset ATN command

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c |4 trace-events |1 + 2 files changed, 5 insertions(+) diff --git a/hw/esp.c b/hw/esp.c index 985a2ee..85078e0 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -113,6 +113,7 @@ struct ESPState { #define CMD_MSGACC

[Qemu-devel] [PATCH 9/9] esp: add AMD PCscsi emulation (PCI SCSI adapter)

2012-06-24 Thread Hervé Poussineau
The PCI version is supported in lots of Operating Systems, and has been successfully tested on: - MS DOS 6.22 with MS Windows 3.11 - MS Windows 98 SE - MS Windows NT 3.1 - MS Windows NT 4.0 Signed-off-by: Hervé Poussineau hpous...@reactos.org --- default-configs/i386-softmmu.mak |1 +

[Qemu-devel] [PATCH 7/9] esp: split esp code into generic chip emulation and sysbus layer

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c | 162 -- 1 file changed, 95 insertions(+), 67 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index d9dd2aa..796cdc1 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -44,12 +44,9

[Qemu-devel] [PATCH 1/9] esp: execute select commands immediately when it is a non-dma command

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 8d73e56..aff8de6 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -270,7 +270,7 @@ static void handle_satn(ESPState *s) uint8_t

[Qemu-devel] [PATCH 8/9] esp: use trace framework instead of stderr output

2012-06-24 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/esp.c | 13 ++--- trace-events |3 +++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index 796cdc1..ec40d93 100644 --- a/hw/esp.c +++ b/hw/esp.c @@ -26,6 +26,7 @@ #include scsi.h

[Qemu-devel] This is a bug, isn't it?

2012-06-24 Thread Martin Husemann
Can somebody explain this code sniplet from hw/sparc32_dma.c to me? Either it is some hidden threaded gem (in which case s-dmaregs need to be volatile at least), or some tests are a bit confused and any reasonably optimizing compiler will create code that apparently the author did not intend:

Re: [Qemu-devel] This is a bug, isn't it?

2012-06-24 Thread Martin Husemann
Ah, my eyes get bad - please disregard, foudn the DMA_INTREN vs. DMA_INTR differences :-( Martin

Re: [Qemu-devel] [PATCH 8/9] esp: use trace framework instead of stderr output

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 5:15 PM, Hervé Poussineau hpous...@reactos.org wrote: Signed-off-by: Hervé Poussineau hpous...@reactos.org ---  hw/esp.c     |   13 ++---  trace-events |    3 +++  2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index

[Qemu-devel] [PATCH] bsd-user: fix build

2012-06-24 Thread Blue Swirl
Link in oslib objects also for BSD user, but avoid using the version of qemu_vmalloc() defined in oslib-posix.c. Signed-off-by: Blue Swirl blauwir...@gmail.com --- Makefile.target |2 +- oslib-posix.c |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] bsd-user: fix build

2012-06-24 Thread Peter Maydell
On 24 June 2012 21:18, Blue Swirl blauwir...@gmail.com wrote: Link in oslib objects also for BSD user, but avoid using the version of qemu_vmalloc() defined in oslib-posix.c. Do you happen to know why bsd-user has its own implementation of qemu_vmalloc() but linux-user doesn't? Discrepancies

Re: [Qemu-devel] [PATCH] bsd-user: fix build

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 8:34 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 24 June 2012 21:18, Blue Swirl blauwir...@gmail.com wrote: Link in oslib objects also for BSD user, but avoid using the version of qemu_vmalloc() defined in oslib-posix.c. Do you happen to know why bsd-user has

[Qemu-devel] [PULL 0/2] ppc patch queue 2012-06-24

2012-06-24 Thread Alexander Graf
Hi Blue / Aurelien, This is a quick fix patch queue for ppc when using. Thanks a lot to Stefan for finding the issues! Please pull. Alex The following changes since commit 3c01ae0ea29915d165c384d0bd1cbafcf4364a4d: Scott Wood (1): tci: don't write zero for reloc in tci_out_label are

[Qemu-devel] [PATCH 1/2] target-ppc: Fix build with --enable-debug

2012-06-24 Thread Alexander Graf
From: Stefan Weil s...@weilnetz.de The order of the arguments was wrong (copy+paste error). Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Alexander Graf ag...@suse.de --- target-ppc/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl

2012-06-24 Thread Alexander Graf
From: Stefan Weil s...@weilnetz.de This fixes a compiler error when QEMU was configured with --enable-debug. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Alexander Graf ag...@suse.de --- target-ppc/translate_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [Qemu-devel] [PULL 0/2] ppc patch queue 2012-06-24

2012-06-24 Thread Blue Swirl
On Sun, Jun 24, 2012 at 8:53 PM, Alexander Graf ag...@suse.de wrote: Hi Blue / Aurelien, This is a quick fix patch queue for ppc when using. Thanks a lot to Stefan for finding the issues! Please pull. Thanks, pulled. Alex The following changes since commit

Re: [Qemu-devel] [RFC PATCH V1 1/2] arm_boot: added linux switch

2012-06-24 Thread Peter Crosthwaite
Ping! @PMM You rejected my workaround in V2 (i.e. using -dtb to force is_linux) on the grounds that youd accept some reasonable way of saying this ELF file is a Linux kernel, That brings us back to V1 - this patch. Any objections? Regards, Peter On Fri, Jun 1, 2012 at 11:41 AM, Peter Maydell

Re: [Qemu-devel] [PATCH v6 11/16] target-or32: Add a IIS dummy board

2012-06-24 Thread Jia Liu
Hi Peter, On Thu, Jun 21, 2012 at 5:03 PM, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: On Thu, Jun 21, 2012 at 12:58 PM, Jia Liu pro...@gmail.com wrote: Add a IIS dummy board. Signed-off-by: Jia Liu pro...@gmail.com ---  hw/openrisc/Makefile.objs |    2 +-  hw/openrisc_sim.c  

Re: [Qemu-devel] [PATCH v6 11/16] target-or32: Add a IIS dummy board

2012-06-24 Thread Peter Crosthwaite
On Mon, Jun 25, 2012 at 12:23 PM, Jia Liu pro...@gmail.com wrote: Hi Peter, On Thu, Jun 21, 2012 at 5:03 PM, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: On Thu, Jun 21, 2012 at 12:58 PM, Jia Liu pro...@gmail.com wrote: Add a IIS dummy board. Signed-off-by: Jia Liu

Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-06-24 Thread guanxuetao
On Wed, Jun 20, 2012 at 1:56 AM, Guan Xuetao g...@mprc.pku.edu.cn wrote: On Mon, 2012-06-18 at 20:02 +, Blue Swirl wrote: [snip] diff --git a/hw/puv3.h b/hw/puv3.h new file mode 100644 index 000..bcfc978 --- /dev/null +++ b/hw/puv3.h @@ -0,0 +1,49 @@ +/* + * Misc PKUnity

Re: [Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support

2012-06-24 Thread guanxuetao
On Wed, Jun 20, 2012 at 2:10 AM, Guan Xuetao g...@mprc.pku.edu.cn wrote: On Mon, 2012-06-18 at 19:59 +, Blue Swirl wrote: [snip] hw_error() also aborts, it would be nice to avoid that. However, the situation is somewhat different from the instruction case, since only privileged guest

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-24 Thread guanxuetao
[snip] +unrecognized: + �� ��cpu_abort(env, Wrong register (%d) or wrong operation (%d) in cp0_set!\n, + �� �� �� �� �� ��creg, cop); The call to cpu_abort() would mean that the guest is able to terminate QEMU at will, which is not OK. What does real HW do? In my opinion, I just want to

Re: [Qemu-devel] [PATCH v6 08/16] target-or32: Add instruction tanslation

2012-06-24 Thread Jia Liu
Hi Max, On Thu, Jun 21, 2012 at 6:24 PM, Max Filippov jcmvb...@gmail.com wrote: On Thu, Jun 21, 2012 at 6:58 AM, Jia Liu pro...@gmail.com wrote: Add OpenRISC instruction tanslation routines. Signed-off-by: Jia Liu pro...@gmail.com [...] +    case 0x0009: +        switch (op1) { +        

Re: [Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-24 Thread guanxuetao
Does this pass scripts/checkpatch.pl? These should become if (cop != 0) { goto unrecognized; } Thanks for pointing it out, and sorry for that. I will correct it in next version. You can run scripts/checkpatch.pl before you submit the patch. Regards, chenwj Thanks, I will