[Qemu-devel] [PATCH 3/4] kvm: i386: Add services required for PCI device assignment

2012-08-26 Thread Jan Kiszka
From: Jan Kiszka These helpers abstract the interaction of upcoming pci-assign with the KVM kernel services. Put them under i386 only as other archs will implement device pass-through via VFIO and not this classic interface. Signed-off-by: Jan Kiszka --- target-i386/kvm.c | 141 +

[Qemu-devel] [PATCH 1/4] kvm: Introduce kvm_irqchip_update_msi_route

2012-08-26 Thread Jan Kiszka
From: Jan Kiszka This service allows to update an MSI route without releasing/reacquiring the associated VIRQ. Will be used by PCI device assignment, later on likely also by virtio/vhost and VFIO. Signed-off-by: Jan Kiszka --- kvm-all.c | 42 ++ kvm.h

[Qemu-devel] [PATCH 2/4] kvm: Introduce kvm_has_intx_set_mask

2012-08-26 Thread Jan Kiszka
From: Jan Kiszka Will be used by PCI device assignment code. Signed-off-by: Jan Kiszka --- kvm-all.c |8 kvm.h |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index fd9d9b4..84d4f7f 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -88,6

[Qemu-devel] [PATCH 0/4] uq/master: Add classic PCI device assignment

2012-08-26 Thread Jan Kiszka
I'm proud to present probably the last patch series to merge qemu-kvm into upstream: This one adds PCI device assignment for x86 using the classic interface that the KVM model provides. See the last patch for reasons why we still want this while next-generation device assignment via VFIO is approac

Re: [Qemu-devel] [PATCH for-1.2 1/2] linux-headers: update asm/kvm_para.h to 3.6

2012-08-26 Thread Jan Kiszka
On 2012-08-26 17:59, Michael S. Tsirkin wrote: > Update asm-x96/kvm_para.h to version present in Linux 3.6. Nope, we have update-linux-headers.sh for this. Just run it again 3.6-rcX, grab the result, and mention the source (release version or kvm.git hash). Jan > This is needed for the new PV EO

Re: [Qemu-devel] [PATCH for-1.2 0/2] migrate PV EOI MSR

2012-08-26 Thread Jan Kiszka
On 2012-08-26 17:59, Michael S. Tsirkin wrote: > It turns out PV EOI gets disabled after migration - > until next guest reset. > This is because we are missing code to actually migrate it. > This patch fixes it up: it does not do anything useful > without kvm irqchip but applies cleanly to qemu.git

Re: [Qemu-devel] [PATCH v2] register reset handler to write image into memory

2012-08-26 Thread Alexander Graf
On 26.08.2012, at 20:50, Yin Olivia-R63875 wrote: > Thanks to Dunrong and Andreas. > > $ scripts/get_maintainer.pl -f hw/loader.c > Alexander Graf (commit_signer:3/6=50%) > Anthony Liguori (commit_signer:2/6=33%) > Stefan Weil (commit_signer:1/6=17%) > Benjamin Herrenschmidt (commit_signer

Re: [Qemu-devel] Implementing qxl-virtio on QEMU

2012-08-26 Thread Gerd Hoffmann
On 08/24/12 21:14, Erlon Cruz wrote: > The following patches makes provides video support to non PCI architectures, > please review! Can you give an overview on the virtio-qxl virtual hardware design? thanks, Gerd

Re: [Qemu-devel] [PATCH 4/4] qxl: introducing virtio-qxl

2012-08-26 Thread Gerd Hoffmann
Hi, > To enable the VirtIOQXL device, use '-virtio-qxl'. Video output will be Please don't add a new option. 'qemu -vga none -device virtio-qxl' should work these days. You could also make virtio-qxl a valid choice for '-vga' for convenience. cheers, Gerd

Re: [Qemu-devel] [PATCH 2/4] qxl: split qxl functions in common and pci files

2012-08-26 Thread Gerd Hoffmann
On 08/24/12 21:14, Erlon Cruz wrote: > From: Fabiano Fidêncio > > This commit splits qxl functions into common functions (located in > qxl.c) and pci-specific functions (located in qxl-pci.c). > All prototypes are being kept in qxl.h, as common MACROS and inline > functions. Moreover, this commit

Re: [Qemu-devel] [PATCH 1/4] qxl: create a qxl common struct!

2012-08-26 Thread Gerd Hoffmann
On 08/24/12 21:14, Erlon Cruz wrote: > From: Fabiano Fidêncio > > This commit is creating a QXLDevice struct, entirely based on > PCIQXLDevice struct, but separating parts that will be shared between > PCIQXLDevice and VirtIOQXLDevice. All functions were changed to support > the new QXLDevice str

Re: [Qemu-devel] [PATCH] hw/pl110: Fix spelling of 'palette'

2012-08-26 Thread Stefan Weil
Am 26.08.2012 23:30, schrieb Peter Maydell: Fix the spelling of 'palette' used in various local variables and structure members. ... and in a comment. See below. Signed-off-by: Peter Maydell --- hw/pl110.c | 28 ++-- hw/pl110_template.h | 22 +++--

Re: [Qemu-devel] [PATCH v2] register reset handler to write image into memory

2012-08-26 Thread Yin Olivia-R63875
Thanks to Dunrong and Andreas. $ scripts/get_maintainer.pl -f hw/loader.c Alexander Graf (commit_signer:3/6=50%) Anthony Liguori (commit_signer:2/6=33%) Stefan Weil (commit_signer:1/6=17%) Benjamin Herrenschmidt (commit_signer:1/6=17%) Avi Kivity (commit_signer:1/6=17%) Dear maintainers, Cou

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-08-26 Thread Alexander Graf
On 26.08.2012, at 10:34, Blue Swirl wrote: > On Sat, Aug 25, 2012 at 2:27 PM, Alexander Graf wrote: >> >> >> On 25.08.2012, at 00:43, Blue Swirl wrote: >> >>> On Wed, Aug 22, 2012 at 10:31 AM, Li Zhang wrote: When -usb option is used, global varible usb_enabled is set. And all t

[Qemu-devel] [PATCH 7/9] qdev: add notifier for when the device loses its parent bus (eject)

2012-08-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/qdev.c |2 ++ hw/qdev.h |3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index fdee91f..86e1337 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -672,6 +672,8 @@ static void device_initfn(Object *obj) object

[Qemu-devel] [PATCH 2/9] object: automatically free objects based on a release function

2012-08-26 Thread Anthony Liguori
Now object_delete() simply has the semantics of unref'ing an object and unparenting it. Signed-off-by: Anthony Liguori --- include/qemu/object.h |5 + qom/object.c | 16 +++- 2 files changed, 20 insertions(+), 1 deletions(-) diff --git a/include/qemu/object.h b/in

[Qemu-devel] [PATCH 1/9] savevm: don't rely on paths if we can store a DeviceState object

2012-08-26 Thread Anthony Liguori
Paths break during tear down which can result in odd behavior since we do path based lookup during unregister (which happens at tear down). For devices, just store the DeviceState directly and use that. Signed-off-by: Anthony Liguori --- savevm.c |5 - 1 files changed, 4 insertions(+),

[Qemu-devel] [PATCH 4/9] object: remove object_finalize

2012-08-26 Thread Anthony Liguori
Callers should just use object_unref Signed-off-by: Anthony Liguori --- hw/qdev.c |4 include/qemu/object.h |9 - qom/object.c |2 +- 3 files changed, 1 insertions(+), 14 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 6b61daa..fdee91f 100644

[Qemu-devel] [PATCH 6/9] qdev: make devices created with device_add nullable so they can be deleted

2012-08-26 Thread Anthony Liguori
A management tool can destroy these devices by writing an empty string into the child link property. Signed-off-by: Anthony Liguori --- hw/qdev-monitor.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 018b386..3

[Qemu-devel] [PATCH 5/9] object: add support for nullable child properties

2012-08-26 Thread Anthony Liguori
A nullable child can be detached from its parent by setting the property to NULL. This provides a mechanism for a management tool to delete certain types of objects. Signed-off-by: Anthony Liguori object: link<>: release reference on finalize, externalize getter/setter Reported-by: Ping Fan Si

[Qemu-devel] [PATCH 3/9] qbus: remove glib_allocated/qom_allocated and use release hook to free memory

2012-08-26 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- hw/pci.c|7 ++- hw/qdev.c | 15 --- hw/qdev.h |7 --- hw/sysbus.c |7 ++- 4 files changed, 12 insertions(+), 24 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 4d95984..437af70 100644 --- a/hw/pci.c +++ b/hw/pci

[Qemu-devel] [PATCH 9/9] hotplug: refactor hotplug to leverage new QOM functions

2012-08-26 Thread Anthony Liguori
1) DeviceState::unplug requests for an eject to happen - the default implementation is a forced eject 2) A bus can eject a device by setting the parent_bus to NULL - this detaches the device from the bus - this does *not* cause the device to disappear 3) The current implementation on unp

[Qemu-devel] [PATCH 8/9] qdev: make qdev_set_parent_bus() just set a link property

2012-08-26 Thread Anthony Liguori
Also make setting the link to NULL break the bus link Signed-off-by: Anthony Liguori --- hw/qdev.c | 48 ++-- 1 files changed, 42 insertions(+), 6 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 86e1337..525a0cb 100644 --- a/hw/qdev.c +++ b/hw

[Qemu-devel] [RFC PATCH 0/9] qom: improve reference counting and hotplug

2012-08-26 Thread Anthony Liguori
Right now, you need to pair up object_new with object_delete. This is impractical when using reference counting because we would like to ensure that object_unref() also frees memory when needed. The first few patches fix this problem by introducing a release callback so that objects that need spe

[Qemu-devel] [PATCH] hw/pl110: Fix spelling of 'palette'

2012-08-26 Thread Peter Maydell
Fix the spelling of 'palette' used in various local variables and structure members. Signed-off-by: Peter Maydell --- hw/pl110.c | 28 ++-- hw/pl110_template.h | 22 +++--- 2 files changed, 25 insertions(+), 25 deletions(-) diff --git a/hw/pl110.

[Qemu-devel] [PATCH] target-sparc: remove useless line in Makefile.objs

2012-08-26 Thread Aurelien Jarno
op_helper.c has been removed in commit 0184e266. Remove the corresponding flags from Makefile.objs. Cc: Blue Swirl Signed-off-by: Aurelien Jarno --- target-sparc/Makefile.objs |2 -- 1 file changed, 2 deletions(-) diff --git a/target-sparc/Makefile.objs b/target-sparc/Makefile.objs index a

Re: [Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec instructions

2012-08-26 Thread Peter Maydell
On 26 August 2012 18:56, Blue Swirl wrote: > On Sun, Aug 26, 2012 at 2:14 PM, Aurelien Jarno wrote: >> Altivec instructions are not working anymore in PowerPC emulation, >> following commit d15f74fb, which inverted two registers in the call >> to helper. Fix that. > I wonder why TCG debug did no

Re: [Qemu-devel] [PATCH for-1.2] tcg/arm: Fix broken CONFIG_TCG_PASS_AREG0 code

2012-08-26 Thread Blue Swirl
Thanks, applied. On Sun, Aug 26, 2012 at 1:40 PM, Peter Maydell wrote: > The CONFIG_TCG_PASS_AREG0 code for calling ld/st helpers was > broken in that it did not respect the ABI requirement that 64 > bit values were passed in even-odd register pairs. The simplest > way to fix this is to implement

Re: [Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec instructions

2012-08-26 Thread Blue Swirl
On Sun, Aug 26, 2012 at 2:14 PM, Aurelien Jarno wrote: > Altivec instructions are not working anymore in PowerPC emulation, > following commit d15f74fb, which inverted two registers in the call > to helper. Fix that. > > Cc: Blue Swirl Acked-by: Blue Swirl I wonder why TCG debug did not catch

Re: [Qemu-devel] Get host virtual address corresponding to guest physical address?

2012-08-26 Thread Blue Swirl
On Sat, Aug 25, 2012 at 1:17 PM, 陳韋任 (Wei-Ren Chen) wrote: > On Sat, Aug 25, 2012 at 11:56:13AM +0100, Peter Maydell wrote: >> On 24 August 2012 04:14, 陳韋任 (Wei-Ren Chen) wrote: >> > I would like to know if there is a function in QEMU which converts >> > a guest physical address into correspond

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/1] Add USB option in machine options

2012-08-26 Thread Blue Swirl
On Sat, Aug 25, 2012 at 2:27 PM, Alexander Graf wrote: > > > On 25.08.2012, at 00:43, Blue Swirl wrote: > >> On Wed, Aug 22, 2012 at 10:31 AM, Li Zhang wrote: >>> When -usb option is used, global varible usb_enabled is set. >>> And all the plafrom will create one USB controller according >>> to

[Qemu-devel] [PATCH for-1.2 2/2] kvm: get/set PV EOI MSR

2012-08-26 Thread Michael S. Tsirkin
Support get/set of new PV EOI MSR, for migration. Add an optional section for MSR value - send it out in case MSR was changed from the default value (0). Signed-off-by: Michael S. Tsirkin --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21 +

[Qemu-devel] [PATCH for-1.2 1/2] linux-headers: update asm/kvm_para.h to 3.6

2012-08-26 Thread Michael S. Tsirkin
Update asm-x96/kvm_para.h to version present in Linux 3.6. This is needed for the new PV EOI feature. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-x86/kvm_para.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/linux-headers/asm-x86/kvm_para.h b/linux-headers/asm-x86/kvm_par

[Qemu-devel] [PATCH for-1.2 0/2] migrate PV EOI MSR

2012-08-26 Thread Michael S. Tsirkin
It turns out PV EOI gets disabled after migration - until next guest reset. This is because we are missing code to actually migrate it. This patch fixes it up: it does not do anything useful without kvm irqchip but applies cleanly to qemu.git as well as qemu-kvm.git, so I think it's cleaner to appl

Re: [Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec instructions

2012-08-26 Thread Andreas Färber
Am 26.08.2012 16:14, schrieb Aurelien Jarno: > Altivec instructions are not working anymore in PowerPC emulation, > following commit d15f74fb, which inverted two registers in the call > to helper. Fix that. > > Cc: Blue Swirl > Cc: Alexander Graf > Cc: Andreas Färber > Signed-off-by: Aurelien J

Re: [Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec instructions

2012-08-26 Thread Peter Maydell
On 26 August 2012 15:14, Aurelien Jarno wrote: > Altivec instructions are not working anymore in PowerPC emulation, > following commit d15f74fb, which inverted two registers in the call > to helper. Fix that. > > Cc: Blue Swirl > Cc: Alexander Graf > Cc: Andreas Färber > Signed-off-by: Aurelien

Re: [Qemu-devel] [PATCH] qdev: unplug request will propagate and release item bottom-up

2012-08-26 Thread Paolo Bonzini
Il 25/08/2012 09:26, Liu Ping Fan ha scritto: > From: Liu Ping Fan > > To achieve uplug a sub tree, we propagate unplug event on the tree. > > Signed-off-by: Liu Ping Fan You're improvising. You need a clear plan of what you're setting to do, what algorithms/techniques you will use, how you w

[Qemu-devel] [PATCH for-1.2] target-ppc: fix altivec instructions

2012-08-26 Thread Aurelien Jarno
Altivec instructions are not working anymore in PowerPC emulation, following commit d15f74fb, which inverted two registers in the call to helper. Fix that. Cc: Blue Swirl Cc: Alexander Graf Cc: Andreas Färber Signed-off-by: Aurelien Jarno --- target-ppc/translate.c |2 +- 1 file changed,

[Qemu-devel] [PATCH for-1.2] tcg/arm: Fix broken CONFIG_TCG_PASS_AREG0 code

2012-08-26 Thread Peter Maydell
The CONFIG_TCG_PASS_AREG0 code for calling ld/st helpers was broken in that it did not respect the ABI requirement that 64 bit values were passed in even-odd register pairs. The simplest way to fix this is to implement some new utility functions for marshalling function arguments into the correct r

[Qemu-devel] [Bug 1022331] Re: -cpu ? causes confusion when directory has 1-character length filenames

2012-08-26 Thread Aurelien Jarno
** Changed in: qemu Status: Invalid => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1022331 Title: -cpu ? causes confusion when directory has 1-character length filenames S

[Qemu-devel] How to edit qemu-kvm DMI strings?

2012-08-26 Thread commiethebeastie
I need to hide from programs that it runs in VM. How to edit DMI strings "Bochs"?

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-26 Thread Richard Davies
Rik van Riel wrote: > Can you get a backtrace to that _raw_spin_lock_irqsave, to see > from where it is running into lock contention? > > It would be good to know whether it is isolate_freepages_block, > yield_to, kvm_vcpu_on_spin or something else... Hi Rik, I got into a slow boot situation on 3

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-26 Thread Alexandre DERUMIER
>>Using snapshot capabilities of the underlying storage is a good idea. >>LVM snapshots have been used with KVM for a long time. The same works >>for zfs, btrfs, etc. They are probably more efficient than using >>QEMU's external snapshots, which must copy data between image files >>when flattening

Re: [Qemu-devel] [PATCH V5 2/8] hw/acpi_piix4.c: replace register_ioport*

2012-08-26 Thread Jan Kiszka
On 2012-08-26 11:10, Jan Kiszka wrote: > On 2012-08-22 14:27, Julien Grall wrote: >> This patch replaces all register_ioport* with the new memory API. It permits >> to use the new Memory stuff like listener. >> >> Signed-off-by: Julien Grall >> --- >> hw/acpi_piix4.c | 160 >> ++

Re: [Qemu-devel] [PATCH V5 3/8] hw/cirrus_vga.c: replace register_ioport*

2012-08-26 Thread Jan Kiszka
On 2012-08-22 14:27, Julien Grall wrote: > This patch replaces all register_ioport* with portio_*. It permits to > use the new Memory stuff like listener. > > Signed-off-by: Julien Grall > --- > hw/cirrus_vga.c | 42 -- > 1 files changed, 24 insertions(+

Re: [Qemu-devel] [PATCH V5 2/8] hw/acpi_piix4.c: replace register_ioport*

2012-08-26 Thread Jan Kiszka
On 2012-08-22 14:27, Julien Grall wrote: > This patch replaces all register_ioport* with the new memory API. It permits > to use the new Memory stuff like listener. > > Signed-off-by: Julien Grall > --- > hw/acpi_piix4.c | 160 ++ > 1 files ch

[Qemu-devel] [PATCH for 1.2] memory: Fix copy&paste mistake in memory_region_iorange_write

2012-08-26 Thread Jan Kiszka
From: Jan Kiszka The last argument of find_portio is "write", so this must be true here. Signed-off-by: Jan Kiszka --- We were likely lucky so far and didn't hit this - it would have caused an assertion. However, there are also rarely used devices... memory.c |2 +- 1 files changed, 1 in

Re: [Qemu-devel] [Bug 1036363] Re: Major network performance problems on AMD hardware

2012-08-26 Thread Stefan Hajnoczi
On Sun, Aug 26, 2012 at 1:08 AM, Ziemowit Pierzycki wrote: > Executed another test: > > F16 KVM <-- 15 gbps --> F17 VM > > So why is F16 much faster? You could try "bisecting" to find the change that slowed down networking: $ git clone git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git $ cd qemu

Re: [Qemu-devel] qcow2: online snasphots : internal vs external ?

2012-08-26 Thread Stefan Hajnoczi
On Sat, Aug 25, 2012 at 6:06 PM, Alexandre DERUMIER wrote: > I work since many years with snapshot on zfs or netapp, > and on these system like ceph, I can rollback at the time of the snapshot, > and have a view of when the snapshot was taken. > > exemple : > image1 : empty dir / > take a snapsho